[
https://issues.apache.org/jira/browse/FLINK-8690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457821#comment-16457821
]
ASF GitHub Bot commented on FLINK-8690:
---
Github user suez1224 commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-8690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457820#comment-16457820
]
ASF GitHub Bot commented on FLINK-8690:
---
Github user suez1224 commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-8690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457679#comment-16457679
]
Rong Rong commented on FLINK-8690:
--
Thanks for the suggestion [~fhueske]. I think this is
[
https://issues.apache.org/jira/browse/FLINK-8690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457676#comment-16457676
]
ASF GitHub Bot commented on FLINK-8690:
---
GitHub user walterddr opened a pull request
[
https://issues.apache.org/jira/browse/FLINK-8690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16445682#comment-16445682
]
Fabian Hueske commented on FLINK-8690:
--
Hi [~walterddr] and [~hequn8128],
Thanks for
[
https://issues.apache.org/jira/browse/FLINK-8690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16394806#comment-16394806
]
Rong Rong commented on FLINK-8690:
--
Sweet. Thank you [~hequn8128]!
I am still a bit skept
[
https://issues.apache.org/jira/browse/FLINK-8690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16394404#comment-16394404
]
Hequn Cheng commented on FLINK-8690:
Looks good for the rule changesĀ :D
> Update logi
[
https://issues.apache.org/jira/browse/FLINK-8690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16394379#comment-16394379
]
Rong Rong commented on FLINK-8690:
--
Thanks [~hequn8128] for the valuable feedback :-)
I d
[
https://issues.apache.org/jira/browse/FLINK-8690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16394069#comment-16394069
]
Hequn Cheng commented on FLINK-8690:
Rename current FlinkLogicalAggregateConverter to
[
https://issues.apache.org/jira/browse/FLINK-8690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16394068#comment-16394068
]
Rong Rong commented on FLINK-8690:
--
You are right. Haven't thought about that. I will ver
[
https://issues.apache.org/jira/browse/FLINK-8690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16394064#comment-16394064
]
Hequn Cheng commented on FLINK-8690:
No need to worry about the {{AggregateExpandDisti
[
https://issues.apache.org/jira/browse/FLINK-8690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16394046#comment-16394046
]
Rong Rong commented on FLINK-8690:
--
That should resolve our problem partially. The real r
[
https://issues.apache.org/jira/browse/FLINK-8690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16394002#comment-16394002
]
Hequn Cheng commented on FLINK-8690:
Hi, we don't have to create a new logical RelNode
[
https://issues.apache.org/jira/browse/FLINK-8690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390467#comment-16390467
]
Rong Rong commented on FLINK-8690:
--
I created one of the initial (not at all perfect) sup
[
https://issues.apache.org/jira/browse/FLINK-8690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376938#comment-16376938
]
Rong Rong commented on FLINK-8690:
--
Yes, changed the description
> Update logical rule s
[
https://issues.apache.org/jira/browse/FLINK-8690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375920#comment-16375920
]
Hequn Cheng commented on FLINK-8690:
Hi, currently, {{FlinkLogicalWindowAggregate}} do
16 matches
Mail list logo