[jira] [Commented] (FLINK-8843) Decouple bind REST address from advertised address

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-8843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404080#comment-16404080
 ] 

ASF GitHub Bot commented on FLINK-8843:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/5707


> Decouple bind REST address from advertised address
> --
>
> Key: FLINK-8843
> URL: https://issues.apache.org/jira/browse/FLINK-8843
> Project: Flink
>  Issue Type: Improvement
>  Components: REST
>Affects Versions: 1.5.0, 1.6.0
>Reporter: Till Rohrmann
>Assignee: Gary Yao
>Priority: Critical
>  Labels: flip-6
> Fix For: 1.5.0
>
>
> The {{RestServerEndpoint}} is currently bound to the same address which is 
> also advertised to the client, namely {{RestOptions#REST_ADDRESS}}. It would 
> be better to start the {{RestServerEndpoint}} listening on all address by 
> binding to {{0.0.0.0}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-8843) Decouple bind REST address from advertised address

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-8843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16403198#comment-16403198
 ] 

ASF GitHub Bot commented on FLINK-8843:
---

Github user yanghua closed the pull request at:

https://github.com/apache/flink/pull/5632


> Decouple bind REST address from advertised address
> --
>
> Key: FLINK-8843
> URL: https://issues.apache.org/jira/browse/FLINK-8843
> Project: Flink
>  Issue Type: Improvement
>  Components: REST
>Affects Versions: 1.5.0, 1.6.0
>Reporter: Till Rohrmann
>Assignee: Gary Yao
>Priority: Critical
>  Labels: flip-6
> Fix For: 1.5.0
>
>
> The {{RestServerEndpoint}} is currently bound to the same address which is 
> also advertised to the client, namely {{RestOptions#REST_ADDRESS}}. It would 
> be better to start the {{RestServerEndpoint}} listening on all address by 
> binding to {{0.0.0.0}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-8843) Decouple bind REST address from advertised address

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-8843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16402379#comment-16402379
 ] 

ASF GitHub Bot commented on FLINK-8843:
---

Github user GJL commented on a diff in the pull request:

https://github.com/apache/flink/pull/5632#discussion_r175192336
  
--- Diff: 
flink-core/src/main/java/org/apache/flink/configuration/RestOptions.java ---
@@ -33,7 +33,7 @@
 */
public static final ConfigOption REST_ADDRESS =
key("rest.address")
-   .defaultValue("localhost")
+   .defaultValue("0.0.0.0")
--- End diff --

yes you can close it


> Decouple bind REST address from advertised address
> --
>
> Key: FLINK-8843
> URL: https://issues.apache.org/jira/browse/FLINK-8843
> Project: Flink
>  Issue Type: Improvement
>  Components: REST
>Affects Versions: 1.5.0, 1.6.0
>Reporter: Till Rohrmann
>Assignee: Gary Yao
>Priority: Critical
>  Labels: flip-6
> Fix For: 1.5.0
>
>
> The {{RestServerEndpoint}} is currently bound to the same address which is 
> also advertised to the client, namely {{RestOptions#REST_ADDRESS}}. It would 
> be better to start the {{RestServerEndpoint}} listening on all address by 
> binding to {{0.0.0.0}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-8843) Decouple bind REST address from advertised address

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-8843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401809#comment-16401809
 ] 

ASF GitHub Bot commented on FLINK-8843:
---

Github user yanghua commented on a diff in the pull request:

https://github.com/apache/flink/pull/5632#discussion_r175073202
  
--- Diff: 
flink-core/src/main/java/org/apache/flink/configuration/RestOptions.java ---
@@ -33,7 +33,7 @@
 */
public static final ConfigOption REST_ADDRESS =
key("rest.address")
-   .defaultValue("localhost")
+   .defaultValue("0.0.0.0")
--- End diff --

Can I close this PR?


> Decouple bind REST address from advertised address
> --
>
> Key: FLINK-8843
> URL: https://issues.apache.org/jira/browse/FLINK-8843
> Project: Flink
>  Issue Type: Improvement
>  Components: REST
>Affects Versions: 1.5.0, 1.6.0
>Reporter: Till Rohrmann
>Assignee: Gary Yao
>Priority: Critical
>  Labels: flip-6
> Fix For: 1.5.0
>
>
> The {{RestServerEndpoint}} is currently bound to the same address which is 
> also advertised to the client, namely {{RestOptions#REST_ADDRESS}}. It would 
> be better to start the {{RestServerEndpoint}} listening on all address by 
> binding to {{0.0.0.0}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-8843) Decouple bind REST address from advertised address

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-8843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401806#comment-16401806
 ] 

ASF GitHub Bot commented on FLINK-8843:
---

Github user GJL commented on a diff in the pull request:

https://github.com/apache/flink/pull/5632#discussion_r175072436
  
--- Diff: 
flink-core/src/main/java/org/apache/flink/configuration/RestOptions.java ---
@@ -33,7 +33,7 @@
 */
public static final ConfigOption REST_ADDRESS =
key("rest.address")
-   .defaultValue("localhost")
+   .defaultValue("0.0.0.0")
--- End diff --

It's not enough to set the default value to `0.0.0.0`. The rest client uses 
the value under this config key to connect. I am taking over this ticket now. 
#5707 


> Decouple bind REST address from advertised address
> --
>
> Key: FLINK-8843
> URL: https://issues.apache.org/jira/browse/FLINK-8843
> Project: Flink
>  Issue Type: Improvement
>  Components: REST
>Affects Versions: 1.5.0, 1.6.0
>Reporter: Till Rohrmann
>Assignee: Gary Yao
>Priority: Critical
>  Labels: flip-6
> Fix For: 1.5.0
>
>
> The {{RestServerEndpoint}} is currently bound to the same address which is 
> also advertised to the client, namely {{RestOptions#REST_ADDRESS}}. It would 
> be better to start the {{RestServerEndpoint}} listening on all address by 
> binding to {{0.0.0.0}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-8843) Decouple bind REST address from advertised address

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-8843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401804#comment-16401804
 ] 

ASF GitHub Bot commented on FLINK-8843:
---

GitHub user GJL opened a pull request:

https://github.com/apache/flink/pull/5707

[FLINK-8843][flip6] Decouple bind REST address from advertised address

## What is the purpose of the change

*The `RestServerEndpoint` is currently bound to the same address which is 
also advertised to the client, namely `RestOptions#REST_ADDRESS`. It would be 
better to start the `RestServerEndpoint` listening on all address by binding to 
`0.0.0.0` by default.*


## Brief change log

  - *By default bind REST server on wildcard address.*
  - *Rename `RestServerEndpoint#getRestAddress` to `getRestBaseUrl`.*


## Verifying this change

This change is already covered by existing tests, such as 
`RestServerEndpointITCase.java`.
This change added tests and can be verified as follows:

  - *Manually deployed Flink Cluster on YARN & Standalone mode.*

## Does this pull request potentially affect one of the following parts:

  - Dependencies (does it add or upgrade a dependency): (yes / **no**)
  - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
  - The serializers: (yes / **no** / don't know)
  - The runtime per-record code paths (performance sensitive): (yes / 
**no** / don't know)
  - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (**yes** / no / don't know)
  - The S3 file system connector: (yes / **no** / don't know)

## Documentation

  - Does this pull request introduce a new feature? (**yes** / no)
  - If yes, how is the feature documented? (not applicable / docs / 
JavaDocs / **not documented**)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/GJL/flink FLINK-8843

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/5707.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #5707


commit 44bacfaba9ddf35f6a74035e3719f34c98513c04
Author: gyao 
Date:   2018-03-16T05:57:24Z

[hotfix][flip6] Only create new terminationFuture if MiniCluster is running

commit 5ef0e81d4476ac2ed8a9b3c513cc5a2458d1bf05
Author: gyao 
Date:   2018-03-15T21:04:58Z

[FLINK-8843][REST] Decouple bind REST address from advertised address

By default bind REST server on wildcard address.
Rename RestServerEndpoint#getRestAddress to getRestBaseUrl.




> Decouple bind REST address from advertised address
> --
>
> Key: FLINK-8843
> URL: https://issues.apache.org/jira/browse/FLINK-8843
> Project: Flink
>  Issue Type: Improvement
>  Components: REST
>Affects Versions: 1.5.0, 1.6.0
>Reporter: Till Rohrmann
>Assignee: Gary Yao
>Priority: Critical
>  Labels: flip-6
> Fix For: 1.5.0
>
>
> The {{RestServerEndpoint}} is currently bound to the same address which is 
> also advertised to the client, namely {{RestOptions#REST_ADDRESS}}. It would 
> be better to start the {{RestServerEndpoint}} listening on all address by 
> binding to {{0.0.0.0}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-8843) Decouple bind REST address from advertised address

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-8843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397324#comment-16397324
 ] 

ASF GitHub Bot commented on FLINK-8843:
---

Github user GJL commented on the issue:

https://github.com/apache/flink/pull/5632
  
I'll verify the changes @yanghua 


> Decouple bind REST address from advertised address
> --
>
> Key: FLINK-8843
> URL: https://issues.apache.org/jira/browse/FLINK-8843
> Project: Flink
>  Issue Type: Improvement
>  Components: REST
>Affects Versions: 1.5.0, 1.6.0
>Reporter: Till Rohrmann
>Assignee: Gary Yao
>Priority: Critical
>  Labels: flip-6
> Fix For: 1.5.0, 1.6.0
>
>
> The {{RestServerEndpoint}} is currently bound to the same address which is 
> also advertised to the client, namely {{RestOptions#REST_ADDRESS}}. It would 
> be better to start the {{RestServerEndpoint}} listening on all address by 
> binding to {{0.0.0.0}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-8843) Decouple bind REST address from advertised address

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-8843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396807#comment-16396807
 ] 

ASF GitHub Bot commented on FLINK-8843:
---

Github user tillrohrmann commented on the issue:

https://github.com/apache/flink/pull/5632
  
Thanks for the PR @yanghua, I'll take a look asap.


> Decouple bind REST address from advertised address
> --
>
> Key: FLINK-8843
> URL: https://issues.apache.org/jira/browse/FLINK-8843
> Project: Flink
>  Issue Type: Improvement
>  Components: REST
>Affects Versions: 1.5.0, 1.6.0
>Reporter: Till Rohrmann
>Assignee: vinoyang
>Priority: Critical
>  Labels: flip-6
> Fix For: 1.5.0, 1.6.0
>
>
> The {{RestServerEndpoint}} is currently bound to the same address which is 
> also advertised to the client, namely {{RestOptions#REST_ADDRESS}}. It would 
> be better to start the {{RestServerEndpoint}} listening on all address by 
> binding to {{0.0.0.0}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-8843) Decouple bind REST address from advertised address

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-8843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396701#comment-16396701
 ] 

ASF GitHub Bot commented on FLINK-8843:
---

Github user yanghua commented on the issue:

https://github.com/apache/flink/pull/5632
  
hi @tillrohrmann I think you should review this PR and add it to 1.5 
version as a hotfix. Because I just download the release-1.5 branch. And 
install it as standalone-session mode. But the general config in 
`flink-conf.yaml` can not let me access the web frontend with the JM server's 
remote IP(I access from remote node's browser), and I run command `netstat -anp 
| grep 8081` shows : 

```
tcp0  0 127.0.0.1:8081  0.0.0.0:*   
LISTEN  130475/java
```

and the log print: 

```
Rest endpoint listening at 127.0.0.:8081
```
and the config item : `jobmanager.web.address` can not fix this problem, 
unless we add the config : 

```
rest.address: 0.0.0.0
```

to override the default `localhost` value

but this config item is not in `flink-conf.yaml`, and user may be not 
familiar with it.

And I think if we do not change this config's default value, it will 
confuse users.



> Decouple bind REST address from advertised address
> --
>
> Key: FLINK-8843
> URL: https://issues.apache.org/jira/browse/FLINK-8843
> Project: Flink
>  Issue Type: Improvement
>  Components: REST
>Affects Versions: 1.5.0, 1.6.0
>Reporter: Till Rohrmann
>Assignee: vinoyang
>Priority: Critical
>  Labels: flip-6
> Fix For: 1.5.0, 1.6.0
>
>
> The {{RestServerEndpoint}} is currently bound to the same address which is 
> also advertised to the client, namely {{RestOptions#REST_ADDRESS}}. It would 
> be better to start the {{RestServerEndpoint}} listening on all address by 
> binding to {{0.0.0.0}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-8843) Decouple bind REST address from advertised address

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-8843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389228#comment-16389228
 ] 

ASF GitHub Bot commented on FLINK-8843:
---

Github user yanghua commented on the issue:

https://github.com/apache/flink/pull/5632
  
hi @zentol , it seems @tillrohrmann has no free time recently. Would you 
please review this?


> Decouple bind REST address from advertised address
> --
>
> Key: FLINK-8843
> URL: https://issues.apache.org/jira/browse/FLINK-8843
> Project: Flink
>  Issue Type: Improvement
>  Components: REST
>Affects Versions: 1.5.0, 1.6.0
>Reporter: Till Rohrmann
>Assignee: vinoyang
>Priority: Critical
>  Labels: flip-6
> Fix For: 1.5.0, 1.6.0
>
>
> The {{RestServerEndpoint}} is currently bound to the same address which is 
> also advertised to the client, namely {{RestOptions#REST_ADDRESS}}. It would 
> be better to start the {{RestServerEndpoint}} listening on all address by 
> binding to {{0.0.0.0}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-8843) Decouple bind REST address from advertised address

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-8843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385510#comment-16385510
 ] 

ASF GitHub Bot commented on FLINK-8843:
---

GitHub user yanghua opened a pull request:

https://github.com/apache/flink/pull/5632

[FLINK-8843][REST] Decouple bind REST address from advertised address

## What is the purpose of the change

*This pull request decouples bind REST address from advertised address*


## Brief change log

  - *Change the default value from dns `localhost` to `0.0.0.0`*

## Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

## Does this pull request potentially affect one of the following parts:

  - Dependencies (does it add or upgrade a dependency): (yes / **no**)
  - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
  - The serializers: (yes / **no** / don't know)
  - The runtime per-record code paths (performance sensitive): (yes / 
**no** / don't know)
  - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
  - The S3 file system connector: (yes / **no** / don't know)

## Documentation

  - Does this pull request introduce a new feature? (yes / **no**)
  - If yes, how is the feature documented? (not applicable / docs / 
JavaDocs / **not documented**)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/yanghua/flink FLINK-8843

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/5632.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #5632


commit 1f31f4cbff82df421fc71fc41198a82ad5f50f6f
Author: vinoyang 
Date:   2018-03-05T02:46:40Z

[FLINK-8843][REST] Decouple bind REST address from advertised address




> Decouple bind REST address from advertised address
> --
>
> Key: FLINK-8843
> URL: https://issues.apache.org/jira/browse/FLINK-8843
> Project: Flink
>  Issue Type: Improvement
>  Components: REST
>Affects Versions: 1.5.0, 1.6.0
>Reporter: Till Rohrmann
>Assignee: vinoyang
>Priority: Critical
>  Labels: flip-6
> Fix For: 1.5.0, 1.6.0
>
>
> The {{RestServerEndpoint}} is currently bound to the same address which is 
> also advertised to the client, namely {{RestOptions#REST_ADDRESS}}. It would 
> be better to start the {{RestServerEndpoint}} listening on all address by 
> binding to {{0.0.0.0}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-8843) Decouple bind REST address from advertised address

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-8843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385509#comment-16385509
 ] 

ASF GitHub Bot commented on FLINK-8843:
---

Github user yanghua closed the pull request at:

https://github.com/apache/flink/pull/5631


> Decouple bind REST address from advertised address
> --
>
> Key: FLINK-8843
> URL: https://issues.apache.org/jira/browse/FLINK-8843
> Project: Flink
>  Issue Type: Improvement
>  Components: REST
>Affects Versions: 1.5.0, 1.6.0
>Reporter: Till Rohrmann
>Assignee: vinoyang
>Priority: Critical
>  Labels: flip-6
> Fix For: 1.5.0, 1.6.0
>
>
> The {{RestServerEndpoint}} is currently bound to the same address which is 
> also advertised to the client, namely {{RestOptions#REST_ADDRESS}}. It would 
> be better to start the {{RestServerEndpoint}} listening on all address by 
> binding to {{0.0.0.0}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-8843) Decouple bind REST address from advertised address

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-8843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385504#comment-16385504
 ] 

ASF GitHub Bot commented on FLINK-8843:
---

GitHub user yanghua opened a pull request:

https://github.com/apache/flink/pull/5631

[FLINK-8843][REST] Decouple bind REST address from advertised address

## What is the purpose of the change

*This pull request decouples bind REST address from advertised address*


## Brief change log

  - *Change the default value from dns `localhost` to `0.0.0.0`*

## Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

## Does this pull request potentially affect one of the following parts:

  - Dependencies (does it add or upgrade a dependency): (yes / **no**)
  - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
  - The serializers: (yes / **no** / don't know)
  - The runtime per-record code paths (performance sensitive): (yes / 
**no** / don't know)
  - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
  - The S3 file system connector: (yes / **no** / don't know)

## Documentation

  - Does this pull request introduce a new feature? (yes / **no**)
  - If yes, how is the feature documented? (not applicable / docs / 
JavaDocs / **not documented**)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/yanghua/flink FLINK-8843

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/5631.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #5631


commit fb15233414fae2793d77296b990b76f224cacf6e
Author: vinoyang 
Date:   2018-03-04T09:01:35Z

[FLINK-8830][YARN] YarnResourceManager throws NullPointerException

commit e9de543ac111d17658ac5aa3ba78e844c17f578c
Author: vinoyang 
Date:   2018-03-05T02:27:13Z

[FLINK-8843][REST] Decouple bind REST address from advertised address




> Decouple bind REST address from advertised address
> --
>
> Key: FLINK-8843
> URL: https://issues.apache.org/jira/browse/FLINK-8843
> Project: Flink
>  Issue Type: Improvement
>  Components: REST
>Affects Versions: 1.5.0, 1.6.0
>Reporter: Till Rohrmann
>Assignee: vinoyang
>Priority: Critical
>  Labels: flip-6
> Fix For: 1.5.0, 1.6.0
>
>
> The {{RestServerEndpoint}} is currently bound to the same address which is 
> also advertised to the client, namely {{RestOptions#REST_ADDRESS}}. It would 
> be better to start the {{RestServerEndpoint}} listening on all address by 
> binding to {{0.0.0.0}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-8843) Decouple bind REST address from advertised address

[vinoyang (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-8843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385484#comment-16385484
 ] 

vinoyang commented on FLINK-8843:
-

Hi [~mingleizhang] thanks. I know about 0.0.0.0 , I just make sure the way of 
fixing this issue.

> Decouple bind REST address from advertised address
> --
>
> Key: FLINK-8843
> URL: https://issues.apache.org/jira/browse/FLINK-8843
> Project: Flink
>  Issue Type: Improvement
>  Components: REST
>Affects Versions: 1.5.0, 1.6.0
>Reporter: Till Rohrmann
>Assignee: vinoyang
>Priority: Critical
>  Labels: flip-6
> Fix For: 1.5.0, 1.6.0
>
>
> The {{RestServerEndpoint}} is currently bound to the same address which is 
> also advertised to the client, namely {{RestOptions#REST_ADDRESS}}. It would 
> be better to start the {{RestServerEndpoint}} listening on all address by 
> binding to {{0.0.0.0}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-8843) Decouple bind REST address from advertised address

[mingleizhang (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-8843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385477#comment-16385477
 ] 

mingleizhang commented on FLINK-8843:
-

Hi, [~yanghua] I think that is what Till meant. {{0.0.0.0}} can listen to any 
ip addresses that your machine support.

> Decouple bind REST address from advertised address
> --
>
> Key: FLINK-8843
> URL: https://issues.apache.org/jira/browse/FLINK-8843
> Project: Flink
>  Issue Type: Improvement
>  Components: REST
>Affects Versions: 1.5.0, 1.6.0
>Reporter: Till Rohrmann
>Assignee: vinoyang
>Priority: Critical
>  Labels: flip-6
> Fix For: 1.5.0, 1.6.0
>
>
> The {{RestServerEndpoint}} is currently bound to the same address which is 
> also advertised to the client, namely {{RestOptions#REST_ADDRESS}}. It would 
> be better to start the {{RestServerEndpoint}} listening on all address by 
> binding to {{0.0.0.0}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-8843) Decouple bind REST address from advertised address

[vinoyang (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-8843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385040#comment-16385040
 ] 

vinoyang commented on FLINK-8843:
-

hi [~till.rohrmann] , you mean we should change the RestOptions#REST_ADDRESS's 
default value (localhost) to 0.0.0.0, right?

> Decouple bind REST address from advertised address
> --
>
> Key: FLINK-8843
> URL: https://issues.apache.org/jira/browse/FLINK-8843
> Project: Flink
>  Issue Type: Improvement
>  Components: REST
>Affects Versions: 1.5.0, 1.6.0
>Reporter: Till Rohrmann
>Assignee: vinoyang
>Priority: Critical
>  Labels: flip-6
> Fix For: 1.5.0, 1.6.0
>
>
> The {{RestServerEndpoint}} is currently bound to the same address which is 
> also advertised to the client, namely {{RestOptions#REST_ADDRESS}}. It would 
> be better to start the {{RestServerEndpoint}} listening on all address by 
> binding to {{0.0.0.0}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)