[jira] [Commented] (FLINK-9040) JobVertex#setMaxParallelism does not validate argument

[Flink Jira Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/FLINK-9040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17329742#comment-17329742
 ] 

Flink Jira Bot commented on FLINK-9040:
---

This issue has been labeled "stale-minor" for 7 days. It is closed now. If you 
are still affected by this or would like to raise the priority of this ticket 
please re-open, removing the label "auto-closed" and raise the ticket priority 
accordingly.

> JobVertex#setMaxParallelism does not validate argument
> --
>
> Key: FLINK-9040
> URL: https://issues.apache.org/jira/browse/FLINK-9040
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / Task
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Priority: Minor
>  Labels: stale-minor
>
> {code}
> /**
> * Sets the maximum parallelism for the task.
> *
> * @param maxParallelism The maximum parallelism to be set. must be between 1 
> and Short.MAX_VALUE.
> */
> public void setMaxParallelism(int maxParallelism) {
>   this.maxParallelism = maxParallelism;
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (FLINK-9040) JobVertex#setMaxParallelism does not validate argument

[Flink Jira Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/FLINK-9040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17321601#comment-17321601
 ] 

Flink Jira Bot commented on FLINK-9040:
---

This issue and all of its Sub-Tasks have not been updated for 180 days. So, it 
has been labeled "stale-minor". If you are still affected by this bug or are 
still interested in this issue, please give an update and remove the label. In 
7 days the issue will be closed automatically.

> JobVertex#setMaxParallelism does not validate argument
> --
>
> Key: FLINK-9040
> URL: https://issues.apache.org/jira/browse/FLINK-9040
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / Task
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Priority: Minor
>  Labels: stale-minor
>
> {code}
> /**
> * Sets the maximum parallelism for the task.
> *
> * @param maxParallelism The maximum parallelism to be set. must be between 1 
> and Short.MAX_VALUE.
> */
> public void setMaxParallelism(int maxParallelism) {
>   this.maxParallelism = maxParallelism;
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (FLINK-9040) JobVertex#setMaxParallelism does not validate argument

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-9040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16441799#comment-16441799
 ] 

ASF GitHub Bot commented on FLINK-9040:
---

Github user sihuazhou commented on the issue:

https://github.com/apache/flink/pull/5825
  
closing this cause I think this maybe a no-issue.


> JobVertex#setMaxParallelism does not validate argument
> --
>
> Key: FLINK-9040
> URL: https://issues.apache.org/jira/browse/FLINK-9040
> Project: Flink
>  Issue Type: Bug
>  Components: Local Runtime
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Assignee: Sihua Zhou
>Priority: Minor
>
> {code}
> /**
> * Sets the maximum parallelism for the task.
> *
> * @param maxParallelism The maximum parallelism to be set. must be between 1 
> and Short.MAX_VALUE.
> */
> public void setMaxParallelism(int maxParallelism) {
>   this.maxParallelism = maxParallelism;
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-9040) JobVertex#setMaxParallelism does not validate argument

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-9040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16441800#comment-16441800
 ] 

ASF GitHub Bot commented on FLINK-9040:
---

Github user sihuazhou closed the pull request at:

https://github.com/apache/flink/pull/5825


> JobVertex#setMaxParallelism does not validate argument
> --
>
> Key: FLINK-9040
> URL: https://issues.apache.org/jira/browse/FLINK-9040
> Project: Flink
>  Issue Type: Bug
>  Components: Local Runtime
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Assignee: Sihua Zhou
>Priority: Minor
>
> {code}
> /**
> * Sets the maximum parallelism for the task.
> *
> * @param maxParallelism The maximum parallelism to be set. must be between 1 
> and Short.MAX_VALUE.
> */
> public void setMaxParallelism(int maxParallelism) {
>   this.maxParallelism = maxParallelism;
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-9040) JobVertex#setMaxParallelism does not validate argument

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-9040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429761#comment-16429761
 ] 

ASF GitHub Bot commented on FLINK-9040:
---

Github user sihuazhou commented on the issue:

https://github.com/apache/flink/pull/5825
  
I only fix the javadoc for `JobVertex#setMaxParallelism()`, because if we 
validate `maxParallism` in that function we will break some current code, and 
I'am not sure whether these code also need to be changed, e.g: 

If the user didn't set the `maxParallelism` for `Transformation`, than the 
default value is -1, and in `StreamJobGraphGenerator#createJobVertex` we use 
the following code to set the `maxParallelism` for `jobVertex`
```java
   jobVertex.setMaxParallelism(streamNode.getMaxParallelism());
```
also, in the constructor of `ExecutionJobVertex`, we use the following code 
to get the default `maxParallelism` value and the `VALUE_NOT_SET` is `-1`.
```java
  final int configuredMaxParallelism = jobVertex.getMaxParallelism();

  this.maxParallelismConfigured = (VALUE_NOT_SET != 
configuredMaxParallelism);
```

@zentol What do you think? if you still think we should validate 
`maxParallism` in `JobVertex#setMaxParallelism()` please let me know.


> JobVertex#setMaxParallelism does not validate argument
> --
>
> Key: FLINK-9040
> URL: https://issues.apache.org/jira/browse/FLINK-9040
> Project: Flink
>  Issue Type: Bug
>  Components: Local Runtime
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Assignee: Sihua Zhou
>Priority: Minor
>
> {code}
> /**
> * Sets the maximum parallelism for the task.
> *
> * @param maxParallelism The maximum parallelism to be set. must be between 1 
> and Short.MAX_VALUE.
> */
> public void setMaxParallelism(int maxParallelism) {
>   this.maxParallelism = maxParallelism;
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-9040) JobVertex#setMaxParallelism does not validate argument

[Sihua Zhou (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-9040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429655#comment-16429655
 ] 

Sihua Zhou commented on FLINK-9040:
---

Hi [~Zentol] I think the javadoc here is also incorrect, the maxParallelism is 
of between {{1 and 

KeyGroupRangeAssignment#UPPER_BOUND_MAX_PARALLELISM (not Short.MAX_VALUE, cause 
KeyGroupRangeAssignment#UPPER_BOUND_MAX_PARALLELISM == Short.MAX_VALUE + 1)}}, 
am I wrong? 

> JobVertex#setMaxParallelism does not validate argument
> --
>
> Key: FLINK-9040
> URL: https://issues.apache.org/jira/browse/FLINK-9040
> Project: Flink
>  Issue Type: Bug
>  Components: Local Runtime
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Assignee: Sihua Zhou
>Priority: Minor
>
> {code}
> /**
> * Sets the maximum parallelism for the task.
> *
> * @param maxParallelism The maximum parallelism to be set. must be between 1 
> and Short.MAX_VALUE.
> */
> public void setMaxParallelism(int maxParallelism) {
>   this.maxParallelism = maxParallelism;
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-9040) JobVertex#setMaxParallelism does not validate argument

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-9040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429385#comment-16429385
 ] 

ASF GitHub Bot commented on FLINK-9040:
---

GitHub user sihuazhou opened a pull request:

https://github.com/apache/flink/pull/5825

[FLINK-9040][local runtime] check maxParallelism in 
JobVertex#setMaxParallelism()

## What is the purpose of the change

this PR performs `maxParallelism` checking in 
`JobVertex#setMaxParallelism()`.

## Brief change log

  - check `maxParallelism` in `JobVertex#setMaxParallelism()`

## Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

## Does this pull request potentially affect one of the following parts:

  - Dependencies (does it add or upgrade a dependency): (no)
  - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
  - The serializers: (no)
  - The runtime per-record code paths (performance sensitive): (no)
  - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  - The S3 file system connector: (no)

## Documentation
no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sihuazhou/flink checkMaxParallelism

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/5825.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #5825


commit 20fbb4aecfb5ff5a40b8be23588eae92fbd2b57a
Author: sihuazhou 
Date:   2018-04-07T14:12:37Z

check maxParallelism in JobVertex#setMaxParallelism().




> JobVertex#setMaxParallelism does not validate argument
> --
>
> Key: FLINK-9040
> URL: https://issues.apache.org/jira/browse/FLINK-9040
> Project: Flink
>  Issue Type: Bug
>  Components: Local Runtime
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Priority: Minor
>
> {code}
> /**
> * Sets the maximum parallelism for the task.
> *
> * @param maxParallelism The maximum parallelism to be set. must be between 1 
> and Short.MAX_VALUE.
> */
> public void setMaxParallelism(int maxParallelism) {
>   this.maxParallelism = maxParallelism;
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-9040) JobVertex#setMaxParallelism does not validate argument

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-9040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429386#comment-16429386
 ] 

ASF GitHub Bot commented on FLINK-9040:
---

Github user sihuazhou commented on the issue:

https://github.com/apache/flink/pull/5825
  
CC:  @zentol 


> JobVertex#setMaxParallelism does not validate argument
> --
>
> Key: FLINK-9040
> URL: https://issues.apache.org/jira/browse/FLINK-9040
> Project: Flink
>  Issue Type: Bug
>  Components: Local Runtime
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Priority: Minor
>
> {code}
> /**
> * Sets the maximum parallelism for the task.
> *
> * @param maxParallelism The maximum parallelism to be set. must be between 1 
> and Short.MAX_VALUE.
> */
> public void setMaxParallelism(int maxParallelism) {
>   this.maxParallelism = maxParallelism;
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-9040) JobVertex#setMaxParallelism does not validate argument

[Sihua Zhou (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-9040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407920#comment-16407920
 ] 

Sihua Zhou commented on FLINK-9040:
---

Hi [~Zentol] there's one thing I want to confirm with you, I found for `stream 
job` the `maximum parallelism` of the JobVertex is passed from 
{{StreamTransformation}} and the `maximum parallelism` has already been 
validated. Does this issue aim for  `batch job`?

> JobVertex#setMaxParallelism does not validate argument
> --
>
> Key: FLINK-9040
> URL: https://issues.apache.org/jira/browse/FLINK-9040
> Project: Flink
>  Issue Type: Bug
>  Components: Local Runtime
>Affects Versions: 1.5.0
>Reporter: Chesnay Schepler
>Assignee: Sihua Zhou
>Priority: Minor
>
> {code}
> /**
> * Sets the maximum parallelism for the task.
> *
> * @param maxParallelism The maximum parallelism to be set. must be between 1 
> and Short.MAX_VALUE.
> */
> public void setMaxParallelism(int maxParallelism) {
>   this.maxParallelism = maxParallelism;
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)