[jira] [Commented] (FLINK-9073) Resume from savepoint end-to-end tests should be extended for different state backends

[Tzu-Li (Gordon) Tai (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-9073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468317#comment-16468317
 ] 

Tzu-Li (Gordon) Tai commented on FLINK-9073:


Merged.

1.6.0: d6d2c36c6f89fa40277db9e6bd84f531c901c353
1.5.0: a0698c3159337f1783d821740f26d43c60bfc74a

> Resume from savepoint end-to-end tests should be extended for different state 
> backends
> --
>
> Key: FLINK-9073
> URL: https://issues.apache.org/jira/browse/FLINK-9073
> Project: Flink
>  Issue Type: Sub-task
>Reporter: Tzu-Li (Gordon) Tai
>Assignee: Tzu-Li (Gordon) Tai
>Priority: Blocker
> Fix For: 1.5.0
>
>
> The resuming from savepoint end-to-end test script, {{test_resume_savepoint}} 
> should be extended for the different state backends.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-9073) Resume from savepoint end-to-end tests should be extended for different state backends

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-9073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468315#comment-16468315
 ] 

ASF GitHub Bot commented on FLINK-9073:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/5926


> Resume from savepoint end-to-end tests should be extended for different state 
> backends
> --
>
> Key: FLINK-9073
> URL: https://issues.apache.org/jira/browse/FLINK-9073
> Project: Flink
>  Issue Type: Sub-task
>Reporter: Tzu-Li (Gordon) Tai
>Assignee: Tzu-Li (Gordon) Tai
>Priority: Blocker
> Fix For: 1.6.0
>
>
> The resuming from savepoint end-to-end test script, {{test_resume_savepoint}} 
> should be extended for the different state backends.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-9073) Resume from savepoint end-to-end tests should be extended for different state backends

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-9073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16466809#comment-16466809
 ] 

ASF GitHub Bot commented on FLINK-9073:
---

Github user tzulitai commented on a diff in the pull request:

https://github.com/apache/flink/pull/5926#discussion_r186608526
  
--- Diff: flink-end-to-end-tests/run-nightly-tests.sh ---
@@ -58,25 +58,97 @@ fi
 
 if [ $EXIT_CODE == 0 ]; then
   printf 
"\n==\n"
-  printf "Running Resuming Savepoint (no parallelism change) end-to-end 
test\n"
+  printf "Running Resuming Savepoint (file, async, no parallelism change) 
end-to-end test\n"
   printf 
"==\n"
-  $END_TO_END_DIR/test-scripts/test_resume_savepoint.sh 2 2
+  STATE_BACKEND_TYPE=file STATE_BACKEND_FILE_ASYNC=true 
$END_TO_END_DIR/test-scripts/test_resume_savepoint.sh 2 2
   EXIT_CODE=$?
 fi
 
 if [ $EXIT_CODE == 0 ]; then
   printf 
"\n==\n"
-  printf "Running Resuming Savepoint (scale up) end-to-end test\n"
+  printf "Running Resuming Savepoint (file, sync, no parallelism change) 
end-to-end test\n"
   printf 
"==\n"
-  $END_TO_END_DIR/test-scripts/test_resume_savepoint.sh 2 4
+  STATE_BACKEND_TYPE=file STATE_BACKEND_FILE_ASYNC=false 
$END_TO_END_DIR/test-scripts/test_resume_savepoint.sh 2 2
   EXIT_CODE=$?
 fi
 
 if [ $EXIT_CODE == 0 ]; then
   printf 
"\n==\n"
-  printf "Running Resuming Savepoint (scale down) end-to-end test\n"
+  printf "Running Resuming Savepoint (file, async, scale up) end-to-end 
test\n"
   printf 
"==\n"
-  $END_TO_END_DIR/test-scripts/test_resume_savepoint.sh 4 2
+  STATE_BACKEND_TYPE=file STATE_BACKEND_FILE_ASYNC=true 
$END_TO_END_DIR/test-scripts/test_resume_savepoint.sh 2 4
+  EXIT_CODE=$?
+fi
+
+if [ $EXIT_CODE == 0 ]; then
+  printf 
"\n==\n"
+  printf "Running Resuming Savepoint (file, sync, scale up) end-to-end 
test\n"
+  printf 
"==\n"
+  STATE_BACKEND_TYPE=file STATE_BACKEND_FILE_ASYNC=false 
$END_TO_END_DIR/test-scripts/test_resume_savepoint.sh 2 4
+  EXIT_CODE=$?
+fi
+
+if [ $EXIT_CODE == 0 ]; then
+  printf 
"\n==\n"
+  printf "Running Resuming Savepoint (file, async, scale down) end-to-end 
test\n"
+  printf 
"==\n"
+  STATE_BACKEND_TYPE=file STATE_BACKEND_FILE_ASYNC=true 
$END_TO_END_DIR/test-scripts/test_resume_savepoint.sh 4 2
+  EXIT_CODE=$?
+fi
+
+if [ $EXIT_CODE == 0 ]; then
+  printf 
"\n==\n"
+  printf "Running Resuming Savepoint (file, sync, scale down) end-to-end 
test\n"
+  printf 
"==\n"
+  STATE_BACKEND_TYPE=file STATE_BACKEND_FILE_ASYNC=false 
$END_TO_END_DIR/test-scripts/test_resume_savepoint.sh 4 2
+  EXIT_CODE=$?
+fi
+
+if [ $EXIT_CODE == 0 ]; then
+  printf 
"\n==\n"
+  printf "Running Resuming Savepoint (rocks, non-incremental, no 
parallelism change) end-to-end test\n"
+  printf 
"==\n"
+  STATE_BACKEND_TYPE=rocks STATE_BACKEND_ROCKS_INCREMENTAL=false 
$END_TO_END_DIR/test-scripts/test_resume_savepoint.sh 2 2
+  EXIT_CODE=$?
+fi
+
+if [ $EXIT_CODE == 0 ]; then
+  printf 
"\n==\n"
+  printf "Running Resuming Savepoint (rocks, incremental, no parallelism 
change) end-to-end test\n"
+  printf 
"==\n"
+  STATE_BACKEND_TYPE=rocks STATE_BACKEND_ROCKS_INCREMENTAL=true 
$END_TO_END_DIR/test-scripts/test_resume_savepoint.sh 2 2
--- End diff --

This makes sense, will address this.


> Resume from savepoint end-to-end tests should be extended for different state 
> backends
> --
>
> 

[jira] [Commented] (FLINK-9073) Resume from savepoint end-to-end tests should be extended for different state backends

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-9073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16466810#comment-16466810
 ] 

ASF GitHub Bot commented on FLINK-9073:
---

Github user tzulitai commented on the issue:

https://github.com/apache/flink/pull/5926
  
Thanks for the review @StefanRRichter! Will address your comment and merge 
this.


> Resume from savepoint end-to-end tests should be extended for different state 
> backends
> --
>
> Key: FLINK-9073
> URL: https://issues.apache.org/jira/browse/FLINK-9073
> Project: Flink
>  Issue Type: Sub-task
>Reporter: Tzu-Li (Gordon) Tai
>Assignee: Tzu-Li (Gordon) Tai
>Priority: Blocker
> Fix For: 1.6.0
>
>
> The resuming from savepoint end-to-end test script, {{test_resume_savepoint}} 
> should be extended for the different state backends.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-9073) Resume from savepoint end-to-end tests should be extended for different state backends

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-9073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465869#comment-16465869
 ] 

ASF GitHub Bot commented on FLINK-9073:
---

Github user StefanRRichter commented on the issue:

https://github.com/apache/flink/pull/5926
  
LGTM  


> Resume from savepoint end-to-end tests should be extended for different state 
> backends
> --
>
> Key: FLINK-9073
> URL: https://issues.apache.org/jira/browse/FLINK-9073
> Project: Flink
>  Issue Type: Sub-task
>Reporter: Tzu-Li (Gordon) Tai
>Assignee: Tzu-Li (Gordon) Tai
>Priority: Blocker
> Fix For: 1.6.0
>
>
> The resuming from savepoint end-to-end test script, {{test_resume_savepoint}} 
> should be extended for the different state backends.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (FLINK-9073) Resume from savepoint end-to-end tests should be extended for different state backends

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-9073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465864#comment-16465864
 ] 

ASF GitHub Bot commented on FLINK-9073:
---

Github user StefanRRichter commented on a diff in the pull request:

https://github.com/apache/flink/pull/5926#discussion_r186412353
  
--- Diff: flink-end-to-end-tests/run-nightly-tests.sh ---
@@ -58,25 +58,97 @@ fi
 
 if [ $EXIT_CODE == 0 ]; then
   printf 
"\n==\n"
-  printf "Running Resuming Savepoint (no parallelism change) end-to-end 
test\n"
+  printf "Running Resuming Savepoint (file, async, no parallelism change) 
end-to-end test\n"
   printf 
"==\n"
-  $END_TO_END_DIR/test-scripts/test_resume_savepoint.sh 2 2
+  STATE_BACKEND_TYPE=file STATE_BACKEND_FILE_ASYNC=true 
$END_TO_END_DIR/test-scripts/test_resume_savepoint.sh 2 2
   EXIT_CODE=$?
 fi
 
 if [ $EXIT_CODE == 0 ]; then
   printf 
"\n==\n"
-  printf "Running Resuming Savepoint (scale up) end-to-end test\n"
+  printf "Running Resuming Savepoint (file, sync, no parallelism change) 
end-to-end test\n"
   printf 
"==\n"
-  $END_TO_END_DIR/test-scripts/test_resume_savepoint.sh 2 4
+  STATE_BACKEND_TYPE=file STATE_BACKEND_FILE_ASYNC=false 
$END_TO_END_DIR/test-scripts/test_resume_savepoint.sh 2 2
   EXIT_CODE=$?
 fi
 
 if [ $EXIT_CODE == 0 ]; then
   printf 
"\n==\n"
-  printf "Running Resuming Savepoint (scale down) end-to-end test\n"
+  printf "Running Resuming Savepoint (file, async, scale up) end-to-end 
test\n"
   printf 
"==\n"
-  $END_TO_END_DIR/test-scripts/test_resume_savepoint.sh 4 2
+  STATE_BACKEND_TYPE=file STATE_BACKEND_FILE_ASYNC=true 
$END_TO_END_DIR/test-scripts/test_resume_savepoint.sh 2 4
+  EXIT_CODE=$?
+fi
+
+if [ $EXIT_CODE == 0 ]; then
+  printf 
"\n==\n"
+  printf "Running Resuming Savepoint (file, sync, scale up) end-to-end 
test\n"
+  printf 
"==\n"
+  STATE_BACKEND_TYPE=file STATE_BACKEND_FILE_ASYNC=false 
$END_TO_END_DIR/test-scripts/test_resume_savepoint.sh 2 4
+  EXIT_CODE=$?
+fi
+
+if [ $EXIT_CODE == 0 ]; then
+  printf 
"\n==\n"
+  printf "Running Resuming Savepoint (file, async, scale down) end-to-end 
test\n"
+  printf 
"==\n"
+  STATE_BACKEND_TYPE=file STATE_BACKEND_FILE_ASYNC=true 
$END_TO_END_DIR/test-scripts/test_resume_savepoint.sh 4 2
+  EXIT_CODE=$?
+fi
+
+if [ $EXIT_CODE == 0 ]; then
+  printf 
"\n==\n"
+  printf "Running Resuming Savepoint (file, sync, scale down) end-to-end 
test\n"
+  printf 
"==\n"
+  STATE_BACKEND_TYPE=file STATE_BACKEND_FILE_ASYNC=false 
$END_TO_END_DIR/test-scripts/test_resume_savepoint.sh 4 2
+  EXIT_CODE=$?
+fi
+
+if [ $EXIT_CODE == 0 ]; then
+  printf 
"\n==\n"
+  printf "Running Resuming Savepoint (rocks, non-incremental, no 
parallelism change) end-to-end test\n"
+  printf 
"==\n"
+  STATE_BACKEND_TYPE=rocks STATE_BACKEND_ROCKS_INCREMENTAL=false 
$END_TO_END_DIR/test-scripts/test_resume_savepoint.sh 2 2
+  EXIT_CODE=$?
+fi
+
+if [ $EXIT_CODE == 0 ]; then
+  printf 
"\n==\n"
+  printf "Running Resuming Savepoint (rocks, incremental, no parallelism 
change) end-to-end test\n"
+  printf 
"==\n"
+  STATE_BACKEND_TYPE=rocks STATE_BACKEND_ROCKS_INCREMENTAL=true 
$END_TO_END_DIR/test-scripts/test_resume_savepoint.sh 2 2
--- End diff --

Taking savepoints is not different between incremental and non-incremental 
RocksDB, so all those incremental tests do essentially the same. While it does 
not hurt to test them in a strict sense, we might save some time by dropping 

[jira] [Commented] (FLINK-9073) Resume from savepoint end-to-end tests should be extended for different state backends

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-9073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456085#comment-16456085
 ] 

ASF GitHub Bot commented on FLINK-9073:
---

GitHub user tzulitai opened a pull request:

https://github.com/apache/flink/pull/5926

[FLINK-9073] [tests] Extend savepoint e2e tests for different state backends

## What is the purpose of the change

This PR is based on the new general purpose DataStream job added in #5925.
Only the last commit is relevant.

This extends the savepoint end-to-end tests to use different state 
backends, as provided by the general purpose DataStream job.

## Brief change log

- In `test_resume_savepoint.sh`, use state backend configuration parameters 
when submitting the general purpose DataStream job.

## Verifying this change

This PR is a modification to an existing end-to-end test.
It can be verified by that test.

## Documentation

  - Does this pull request introduce a new feature? (yes / **no**)
  - If yes, how is the feature documented? (**not applicable** / docs / 
JavaDocs / not documented)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tzulitai/flink FLINK-9073

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/5926.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #5926


commit a936aaa65b6583cabc8c4ae7269a4a55ac48dd84
Author: Stefan Richter 
Date:   2018-03-15T19:20:45Z

[FLINK-8992] [e2e-tests] Initial general purpose DataStream job

commit c7127a9b746c1c51b384fea5050f5a041df30954
Author: Tzu-Li (Gordon) Tai 
Date:   2018-04-25T09:05:24Z

[FLINK-8992] [e2e-tests] Integrate general DataStream test job with project 
structure

This also includes minor cleanup of WIP code in the test job.

commit 253039b49d16f4971f237e6f808080bd7a3599a2
Author: Tzu-Li (Gordon) Tai 
Date:   2018-04-26T09:22:59Z

[FLINK-8992] [e2e-tests] Add Javadocs for DataStreamAllroundTestProgram

commit fa82e2c56025a28cc7238b67b9595aa58690bd09
Author: Tzu-Li (Gordon) Tai 
Date:   2018-04-27T06:44:44Z

[FLINK-8992] [e2e-tests] Ensure exactly-once in general purpose DataStream 
job

commit e71c5374f56a514332dc9a0a5716eddbfb8c6b62
Author: Tzu-Li (Gordon) Tai 
Date:   2018-04-27T07:01:13Z

[FLINK-8992] [e2e-tests] Configurable source throttling for general purpose 
DataStream job

commit 1d4c7bdfbaff45032e3d9c9a1f7da5448ad41951
Author: Tzu-Li (Gordon) Tai 
Date:   2018-04-27T06:46:09Z

[FLINK-8992] [e2e-tests] Let savepoint e2e test use general pupose 
DataStream job

commit d7163520fb62440673c078f23a1cc1eae7ae0ec2
Author: Tzu-Li (Gordon) Tai 
Date:   2018-04-27T07:52:55Z

[FLINK-9093] [e2e-tests] Extend savepoint e2e tests for different state 
backends




> Resume from savepoint end-to-end tests should be extended for different state 
> backends
> --
>
> Key: FLINK-9073
> URL: https://issues.apache.org/jira/browse/FLINK-9073
> Project: Flink
>  Issue Type: Sub-task
>Reporter: Tzu-Li (Gordon) Tai
>Assignee: Tzu-Li (Gordon) Tai
>Priority: Critical
> Fix For: 1.5.0
>
>
> The resuming from savepoint end-to-end test script, {{test_resume_savepoint}} 
> should be extended for the different state backends.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)