[jira] [Commented] (FLINK-9221) Add method SinkFunction[A]#contramap[B](f: B => A): SinkFunction[B]
[
https://issues.apache.org/jira/browse/FLINK-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17329534#comment-17329534
]
Flink Jira Bot commented on FLINK-9221:
---
This issue is assigned but has not received an update in 7 days so it has been
labeled "stale-assigned". If you are still working on the issue, please give an
update and remove the label. If you are no longer working on the issue, please
unassign so someone else may work on it. In 7 days the issue will be
automatically unassigned.
> Add method SinkFunction[A]#contramap[B](f: B => A): SinkFunction[B]
> ---
>
> Key: FLINK-9221
> URL: https://issues.apache.org/jira/browse/FLINK-9221
> Project: Flink
> Issue Type: Task
> Components: API / DataSet, API / DataStream
>Affects Versions: 1.5.0
>Reporter: Josh Lemer
>Assignee: vinoyang
>Priority: Minor
> Labels: flink, stale-assigned, stale-minor
>
> Just like it is very useful to use `DataStream[T]` as a sort of Functor or
> Monad with `map`/`flatMap`/`filter` methods, it would be extremely handy to
> have a `SinkFunction[A]#contramap[B](f: B => A): SinkFunction[B]` on
> `SinkFunctions`, so that you can reuse existing complex sink functions, but
> with a different input type. For example:
> {code}
> val bucketingStringSink: SinkFunction[String] =
> new BucketingSink[String]("...")
> .setBucketer(new DateTimeBucketer("-MM-dd-HHmm")
> val bucketingIntListSink: SinkFunction[List[Int]] =
> bucketingStringSink.contramap[List[Int]](_.mkString(","))
> {code}
> For some more formal motivation behind this,
> https://typelevel.org/cats/typeclasses/contravariant.html is definitely a
> great place to start!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-9221) Add method SinkFunction[A]#contramap[B](f: B => A): SinkFunction[B]
[
https://issues.apache.org/jira/browse/FLINK-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17321593#comment-17321593
]
Flink Jira Bot commented on FLINK-9221:
---
This issue and all of its Sub-Tasks have not been updated for 180 days. So, it
has been labeled "stale-minor". If you are still affected by this bug or are
still interested in this issue, please give an update and remove the label. In
7 days the issue will be closed automatically.
> Add method SinkFunction[A]#contramap[B](f: B => A): SinkFunction[B]
> ---
>
> Key: FLINK-9221
> URL: https://issues.apache.org/jira/browse/FLINK-9221
> Project: Flink
> Issue Type: Task
> Components: API / DataSet, API / DataStream
>Affects Versions: 1.5.0
>Reporter: Josh Lemer
>Assignee: vinoyang
>Priority: Minor
> Labels: flink, stale-minor
>
> Just like it is very useful to use `DataStream[T]` as a sort of Functor or
> Monad with `map`/`flatMap`/`filter` methods, it would be extremely handy to
> have a `SinkFunction[A]#contramap[B](f: B => A): SinkFunction[B]` on
> `SinkFunctions`, so that you can reuse existing complex sink functions, but
> with a different input type. For example:
> {code}
> val bucketingStringSink: SinkFunction[String] =
> new BucketingSink[String]("...")
> .setBucketer(new DateTimeBucketer("-MM-dd-HHmm")
> val bucketingIntListSink: SinkFunction[List[Int]] =
> bucketingStringSink.contramap[List[Int]](_.mkString(","))
> {code}
> For some more formal motivation behind this,
> https://typelevel.org/cats/typeclasses/contravariant.html is definitely a
> great place to start!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-9221) Add method SinkFunction[A]#contramap[B](f: B => A): SinkFunction[B]
[
https://issues.apache.org/jira/browse/FLINK-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16531680#comment-16531680
]
Josh Lemer commented on FLINK-9221:
---
[~yanghua]You may be right. One reason why it may be wrong to put the method on
`SinkFunction` is that the opposite methods (`map`, `flatMap`) are not on
`SourceFunction` or `MapFunction`, but instead are on `DataStream`. However,
there isn't really any other abstraction in flink where contramap can go on,
since there's not an equivalent `DataSink` abstraction like there is in Akka
Streams or similar, so putting it on SinkFunction may be the best option unless
we come up with a proper `DataSink` abstraction.
> Add method SinkFunction[A]#contramap[B](f: B => A): SinkFunction[B]
> ---
>
> Key: FLINK-9221
> URL: https://issues.apache.org/jira/browse/FLINK-9221
> Project: Flink
> Issue Type: Task
> Components: DataSet API, DataStream API
>Affects Versions: 1.5.0
>Reporter: Josh Lemer
>Assignee: vinoyang
>Priority: Minor
> Labels: flink
>
> Just like it is very useful to use `DataStream[T]` as a sort of Functor or
> Monad with `map`/`flatMap`/`filter` methods, it would be extremely handy to
> have a `SinkFunction[A]#contramap[B](f: B => A): SinkFunction[B]` on
> `SinkFunctions`, so that you can reuse existing complex sink functions, but
> with a different input type. For example:
> {code}
> val bucketingStringSink: SinkFunction[String] =
> new BucketingSink[String]("...")
> .setBucketer(new DateTimeBucketer("-MM-dd-HHmm")
> val bucketingIntListSink: SinkFunction[List[Int]] =
> bucketingStringSink.contramap[List[Int]](_.mkString(","))
> {code}
> For some more formal motivation behind this,
> https://typelevel.org/cats/typeclasses/contravariant.html is definitely a
> great place to start!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9221) Add method SinkFunction[A]#contramap[B](f: B => A): SinkFunction[B]
[
https://issues.apache.org/jira/browse/FLINK-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16529020#comment-16529020
]
vinoyang commented on FLINK-9221:
-
[~joshlemer] I think we should not add this method to `SinkFunction` interface,
it seems could be implemented in a util class. What's your opinion?
[~till.rohrmann]
> Add method SinkFunction[A]#contramap[B](f: B => A): SinkFunction[B]
> ---
>
> Key: FLINK-9221
> URL: https://issues.apache.org/jira/browse/FLINK-9221
> Project: Flink
> Issue Type: Task
> Components: DataSet API, DataStream API
>Affects Versions: 1.5.0
>Reporter: Josh Lemer
>Assignee: vinoyang
>Priority: Minor
> Labels: flink
>
> Just like it is very useful to use `DataStream[T]` as a sort of Functor or
> Monad with `map`/`flatMap`/`filter` methods, it would be extremely handy to
> have a `SinkFunction[A]#contramap[B](f: B => A): SinkFunction[B]` on
> `SinkFunctions`, so that you can reuse existing complex sink functions, but
> with a different input type. For example:
> {code}
> val bucketingStringSink: SinkFunction[String] =
> new BucketingSink[String]("...")
> .setBucketer(new DateTimeBucketer("-MM-dd-HHmm")
> val bucketingIntListSink: SinkFunction[List[Int]] =
> bucketingStringSink.contramap[List[Int]](_.mkString(","))
> {code}
> For some more formal motivation behind this,
> https://typelevel.org/cats/typeclasses/contravariant.html is definitely a
> great place to start!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9221) Add method SinkFunction[A]#contramap[B](f: B => A): SinkFunction[B]
[
https://issues.apache.org/jira/browse/FLINK-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16444250#comment-16444250
]
Josh Lemer commented on FLINK-9221:
---
Fixed!
> Add method SinkFunction[A]#contramap[B](f: B => A): SinkFunction[B]
> ---
>
> Key: FLINK-9221
> URL: https://issues.apache.org/jira/browse/FLINK-9221
> Project: Flink
> Issue Type: Task
> Components: DataStream API
>Affects Versions: 1.5.0
>Reporter: Josh Lemer
>Priority: Minor
> Labels: flink
>
> Just like it is very useful to use `DataStream[T]` as a sort of Functor or
> Monad with `map`/`flatMap`/`filter` methods, it would be extremely handy to
> have a `SinkFunction[A]#contramap[B](f: B => A): SinkFunction[B]` on
> `SinkFunctions`, so that you can reuse existing complex sink functions, but
> with a different input type. For example:
> {code}
> val bucketingStringSink: SinkFunction[String] =
> new BucketingSink[String]("...")
> .setBucketer(new DateTimeBucketer("-MM-dd-HHmm")
> val bucketingIntListSink: SinkFunction[List[Int]] =
> bucketingStringSink.contramap[List[Int]](_.mkString(","))
> {code}
> For some more formal motivation behind this,
> https://typelevel.org/cats/typeclasses/contravariant.html is definitely a
> great place to start!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9221) Add method SinkFunction[A]#contramap[B](f: B => A): SinkFunction[B]
[
https://issues.apache.org/jira/browse/FLINK-9221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16444236#comment-16444236
]
Ted Yu commented on FLINK-9221:
---
bq. .setBucketr
Should be {{.setBucketer}}
> Add method SinkFunction[A]#contramap[B](f: B => A): SinkFunction[B]
> ---
>
> Key: FLINK-9221
> URL: https://issues.apache.org/jira/browse/FLINK-9221
> Project: Flink
> Issue Type: Task
>Reporter: Josh Lemer
>Priority: Minor
>
> Just like it is very useful to use `DataStream[T]` as a sort of Functor or
> Monad with `map`/`flatMap`/`filter` methods, it would be extremely handy to
> have a `SinkFunction[A]#contramap[B](f: B => A): SinkFunction[B]` on
> `SinkFunctions`, so that you can reuse existing complex sink functions, but
> with a different input type. For example:
> {code}
> val bucketingStringSink: SinkFunction[String] =
> new BucketingSink[String]("...")
> .setBucketr(new DateTimeBucketer("-MM-dd-HHmm")
> val bucketingIntListSink: SinkFunction[List[Int]] =
> bucketingStringSink.contramap[List[Int]](_.mkString(","))
> {code}
> For some more formal motivation behind this,
> https://typelevel.org/cats/typeclasses/contravariant.html is definitely a
> great place to start!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
