[jira] [Commented] (FLINK-9941) Flush in ScalaCsvOutputFormat before close method
[
https://issues.apache.org/jira/browse/FLINK-9941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913228#comment-16913228
]
Ryan Tao commented on FLINK-9941:
-
[~rmetzger] I have contacted with Jiayi Liao and he confirmed that he closed
this jira by mistake. mind help to review it or specify a reviewer for this pr
above?
> Flush in ScalaCsvOutputFormat before close method
> -
>
> Key: FLINK-9941
> URL: https://issues.apache.org/jira/browse/FLINK-9941
> Project: Flink
> Issue Type: Improvement
> Components: API / Scala
>Affects Versions: 1.5.1, 1.6.4, 1.7.2, 1.8.1
>Reporter: Ryan Tao
>Assignee: Jiayi Liao
>Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Because not every stream's close method will flush, in order to ensure the
> stability of continuous integration, we need to manually call flush() before
> close().
> I noticed that CsvOutputFormat (Java API) has done this. As follows.
> {code:java}
> //CsvOutputFormat
> public void close() throws IOException {
> if (wrt != null) {
> this.wrt.flush();
> this.wrt.close();
> }
> super.close();
> }
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (FLINK-9941) Flush in ScalaCsvOutputFormat before close method
[
https://issues.apache.org/jira/browse/FLINK-9941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909010#comment-16909010
]
Ryan Tao commented on FLINK-9941:
-
maybe mistake, i reopen it. [~rmetzger]
> Flush in ScalaCsvOutputFormat before close method
> -
>
> Key: FLINK-9941
> URL: https://issues.apache.org/jira/browse/FLINK-9941
> Project: Flink
> Issue Type: Improvement
> Components: API / Scala
>Affects Versions: 1.5.1
>Reporter: Ryan Tao
>Assignee: Jiayi Liao
>Priority: Major
> Labels: pull-request-available
>
> Because not every stream's close method will flush, in order to ensure the
> stability of continuous integration, we need to manually call flush() before
> close().
> I noticed that CsvOutputFormat (Java API) has done this. As follows.
> {code:java}
> //CsvOutputFormat
> public void close() throws IOException {
> if (wrt != null) {
> this.wrt.flush();
> this.wrt.close();
> }
> super.close();
> }
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (FLINK-9941) Flush in ScalaCsvOutputFormat before close method
[
https://issues.apache.org/jira/browse/FLINK-9941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909006#comment-16909006
]
Robert Metzger commented on FLINK-9941:
---
[~wind_ljy] why did you close the Jira ticket?
> Flush in ScalaCsvOutputFormat before close method
> -
>
> Key: FLINK-9941
> URL: https://issues.apache.org/jira/browse/FLINK-9941
> Project: Flink
> Issue Type: Improvement
> Components: API / Scala
>Affects Versions: 1.5.1
>Reporter: Ryan Tao
>Assignee: Jiayi Liao
>Priority: Major
> Labels: pull-request-available
>
> Because not every stream's close method will flush, in order to ensure the
> stability of continuous integration, we need to manually call flush() before
> close().
> I noticed that CsvOutputFormat (Java API) has done this. As follows.
> {code:java}
> //CsvOutputFormat
> public void close() throws IOException {
> if (wrt != null) {
> this.wrt.flush();
> this.wrt.close();
> }
> super.close();
> }
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (FLINK-9941) Flush in ScalaCsvOutputFormat before close method
[
https://issues.apache.org/jira/browse/FLINK-9941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577413#comment-16577413
]
ASF GitHub Bot commented on FLINK-9941:
---
buptljy commented on issue #6411: [FLINK-9941][ScalaAPI] Flush in
ScalaCsvOutputFormat before closing to ensure CI stability
URL: https://github.com/apache/flink/pull/6411#issuecomment-412318470
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Flush in ScalaCsvOutputFormat before close method
> -
>
> Key: FLINK-9941
> URL: https://issues.apache.org/jira/browse/FLINK-9941
> Project: Flink
> Issue Type: Improvement
> Components: Scala API
>Affects Versions: 1.5.1
>Reporter: Rann Tao
>Assignee: buptljy
>Priority: Major
> Labels: pull-request-available
>
> Because not every stream's close method will flush, in order to ensure the
> stability of continuous integration, we need to manually call flush() before
> close().
> I noticed that CsvOutputFormat (Java API) has done this. As follows.
> {code:java}
> //CsvOutputFormat
> public void close() throws IOException {
> if (wrt != null) {
> this.wrt.flush();
> this.wrt.close();
> }
> super.close();
> }
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9941) Flush in ScalaCsvOutputFormat before close method
[
https://issues.apache.org/jira/browse/FLINK-9941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555908#comment-16555908
]
ASF GitHub Bot commented on FLINK-9941:
---
yanghua commented on issue #6411: [FLINK-9941][ScalaAPI] Flush in
ScalaCsvOutputFormat before closing to ensure CI stability
URL: https://github.com/apache/flink/pull/6411#issuecomment-407812875
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Flush in ScalaCsvOutputFormat before close method
> -
>
> Key: FLINK-9941
> URL: https://issues.apache.org/jira/browse/FLINK-9941
> Project: Flink
> Issue Type: Improvement
> Components: Scala API
>Affects Versions: 1.5.1
>Reporter: Rann Tao
>Assignee: buptljy
>Priority: Major
> Labels: pull-request-available
>
> Because not every stream's close method will flush, in order to ensure the
> stability of continuous integration, we need to manually call flush() before
> close().
> I noticed that CsvOutputFormat (Java API) has done this. As follows.
> {code:java}
> //CsvOutputFormat
> public void close() throws IOException {
> if (wrt != null) {
> this.wrt.flush();
> this.wrt.close();
> }
> super.close();
> }
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
***UNCHECKED*** [jira] [Commented] (FLINK-9941) Flush in ScalaCsvOutputFormat before close method
[
https://issues.apache.org/jira/browse/FLINK-9941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555290#comment-16555290
]
ASF GitHub Bot commented on FLINK-9941:
---
GitHub user Lemonjing reopened a pull request:
https://github.com/apache/flink/pull/6411
[FLINK-9941][ScalaAPI] Flush in ScalaCsvOutputFormat before closing, to
ensure CI stability
## What is the purpose of the change
This pull request update scala api `ScalaCsvOutputFormat` to increase CI
stability.
## Brief change log
Add flush method before close function in ScalaCsvOutputFormat for scala
API.
## Verifying this change
Add `ScalaCsvOutputFormatTest` and test passed.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
@Public(Evolving): (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no**
/ don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
Does this pull request introduce a new feature? (yes / **no**)
If yes, how is the feature documented? (not applicable / docs / JavaDocs /
**not documented**)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Lemonjing/flink csv-close-hotfix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6411.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6411
commit 95a9b60b1ece7d248755d92868e682c4ee0fd334
Author: lemonjing <932191671@...>
Date: 2018-07-25T07:06:10Z
[FLINK-9941][ScalaAPI] flush in ScalaCsvOutputFormat before closing, to
ensure CI stability
> Flush in ScalaCsvOutputFormat before close method
> -
>
> Key: FLINK-9941
> URL: https://issues.apache.org/jira/browse/FLINK-9941
> Project: Flink
> Issue Type: Improvement
> Components: Scala API
>Affects Versions: 1.5.1
>Reporter: Rannn Tao
>Assignee: buptljy
>Priority: Major
> Labels: pull-request-available
>
> Because not every stream's close method will flush, in order to ensure the
> stability of continuous integration, we need to manually call flush() before
> close().
> I noticed that CsvOutputFormat (Java API) has done this. As follows.
> {code:java}
> //CsvOutputFormat
> public void close() throws IOException {
> if (wrt != null) {
> this.wrt.flush();
> this.wrt.close();
> }
> super.close();
> }
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
***UNCHECKED*** [jira] [Commented] (FLINK-9941) Flush in ScalaCsvOutputFormat before close method
[
https://issues.apache.org/jira/browse/FLINK-9941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555261#comment-16555261
]
ASF GitHub Bot commented on FLINK-9941:
---
Github user Lemonjing closed the pull request at:
https://github.com/apache/flink/pull/6411
> Flush in ScalaCsvOutputFormat before close method
> -
>
> Key: FLINK-9941
> URL: https://issues.apache.org/jira/browse/FLINK-9941
> Project: Flink
> Issue Type: Improvement
> Components: Scala API
>Affects Versions: 1.5.1
>Reporter: Rannn Tao
>Assignee: buptljy
>Priority: Major
> Labels: pull-request-available
>
> Because not every stream's close method will flush, in order to ensure the
> stability of continuous integration, we need to manually call flush() before
> close().
> I noticed that CsvOutputFormat (Java API) has done this. As follows.
> {code:java}
> //CsvOutputFormat
> public void close() throws IOException {
> if (wrt != null) {
> this.wrt.flush();
> this.wrt.close();
> }
> super.close();
> }
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9941) Flush in ScalaCsvOutputFormat before close method
[
https://issues.apache.org/jira/browse/FLINK-9941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555185#comment-16555185
]
ASF GitHub Bot commented on FLINK-9941:
---
Github user buptljy commented on the issue:
https://github.com/apache/flink/pull/6412
Duplicate. Close.
> Flush in ScalaCsvOutputFormat before close method
> -
>
> Key: FLINK-9941
> URL: https://issues.apache.org/jira/browse/FLINK-9941
> Project: Flink
> Issue Type: Improvement
> Components: Scala API
>Affects Versions: 1.5.1
>Reporter: Rannn Tao
>Assignee: buptljy
>Priority: Major
> Labels: pull-request-available
>
> Because not every stream's close method will flush, in order to ensure the
> stability of continuous integration, we need to manually call flush() before
> close().
> I noticed that CsvOutputFormat (Java API) has done this. As follows.
> {code:java}
> //CsvOutputFormat
> public void close() throws IOException {
> if (wrt != null) {
> this.wrt.flush();
> this.wrt.close();
> }
> super.close();
> }
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9941) Flush in ScalaCsvOutputFormat before close method
[
https://issues.apache.org/jira/browse/FLINK-9941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555186#comment-16555186
]
ASF GitHub Bot commented on FLINK-9941:
---
Github user buptljy closed the pull request at:
https://github.com/apache/flink/pull/6412
> Flush in ScalaCsvOutputFormat before close method
> -
>
> Key: FLINK-9941
> URL: https://issues.apache.org/jira/browse/FLINK-9941
> Project: Flink
> Issue Type: Improvement
> Components: Scala API
>Affects Versions: 1.5.1
>Reporter: Rannn Tao
>Assignee: buptljy
>Priority: Major
> Labels: pull-request-available
>
> Because not every stream's close method will flush, in order to ensure the
> stability of continuous integration, we need to manually call flush() before
> close().
> I noticed that CsvOutputFormat (Java API) has done this. As follows.
> {code:java}
> //CsvOutputFormat
> public void close() throws IOException {
> if (wrt != null) {
> this.wrt.flush();
> this.wrt.close();
> }
> super.close();
> }
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9941) Flush in ScalaCsvOutputFormat before close method
[
https://issues.apache.org/jira/browse/FLINK-9941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555183#comment-16555183
]
ASF GitHub Bot commented on FLINK-9941:
---
GitHub user buptljy opened a pull request:
https://github.com/apache/flink/pull/6412
[FLINK-9941] Flush in ScalaCsvOutputFormat before close
## What is the purpose of the change
- Flush in ScalaCsvOutputFormat before close.We've already finished it in
org.apache.flink.api.java.io.CsvOutputFormat.
## Brief change log
- add flush in ScalaCsvOutputFormat before close.
## Verifying this change
- unit tests.
## Does this pull request potentially affect one of the following parts:
- no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/buptljy/flink FLINK-9941
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6412.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6412
commit 636456d2398bef69a805b96dfb0945459cfcfada
Author: wind
Date: 2018-07-25T06:01:36Z
flush ScalaCsvOutputFormat before close
> Flush in ScalaCsvOutputFormat before close method
> -
>
> Key: FLINK-9941
> URL: https://issues.apache.org/jira/browse/FLINK-9941
> Project: Flink
> Issue Type: Improvement
> Components: Scala API
>Affects Versions: 1.5.1
>Reporter: Rannn Tao
>Assignee: buptljy
>Priority: Major
> Labels: pull-request-available
>
> Because not every stream's close method will flush, in order to ensure the
> stability of continuous integration, we need to manually call flush() before
> close().
> I noticed that CsvOutputFormat (Java API) has done this. As follows.
> {code:java}
> //CsvOutputFormat
> public void close() throws IOException {
> if (wrt != null) {
> this.wrt.flush();
> this.wrt.close();
> }
> super.close();
> }
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9941) Flush in ScalaCsvOutputFormat before close method
[
https://issues.apache.org/jira/browse/FLINK-9941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555179#comment-16555179
]
ASF GitHub Bot commented on FLINK-9941:
---
GitHub user Lemonjing opened a pull request:
https://github.com/apache/flink/pull/6411
[FLINK-9941][ScalaAPI] Flush in ScalaCsvOutputFormat before closing, to
ensure CI stability
## What is the purpose of the change
This pull request update scala api `ScalaCsvOutputFormat` to increase CI
stability.
## Brief change log
Add flush method before close function in ScalaCsvOutputFormat for scala
API.
## Verifying this change
This change is already covered by existing tests, such as
ScalarFunctionsTest
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
@Public(Evolving): (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no**
/ don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
Does this pull request introduce a new feature? (yes / **no**)
If yes, how is the feature documented? (not applicable / docs / JavaDocs /
**not documented**)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Lemonjing/flink csv-close-hotfix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6411.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6411
commit 6c6120722eef81c2c275b92a13a5687fef35e7bb
Author: lemonjing <932191671@...>
Date: 2018-07-25T05:46:55Z
[hotfix] Flush in ScalaCsvOutputFormat before closing, to ensure CI
stability
> Flush in ScalaCsvOutputFormat before close method
> -
>
> Key: FLINK-9941
> URL: https://issues.apache.org/jira/browse/FLINK-9941
> Project: Flink
> Issue Type: Improvement
> Components: Scala API
>Affects Versions: 1.5.1
>Reporter: Rannn Tao
>Assignee: buptljy
>Priority: Major
> Labels: pull-request-available
>
> Because not every stream's close method will flush, in order to ensure the
> stability of continuous integration, we need to manually call flush() before
> close().
> I noticed that CsvOutputFormat (Java API) has done this. As follows.
> {code:java}
> //CsvOutputFormat
> public void close() throws IOException {
> if (wrt != null) {
> this.wrt.flush();
> this.wrt.close();
> }
> super.close();
> }
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9941) Flush in ScalaCsvOutputFormat before close method
[
https://issues.apache.org/jira/browse/FLINK-9941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555175#comment-16555175
]
buptljy commented on FLINK-9941:
[~lemonjing] You're right. I'll fix it.
> Flush in ScalaCsvOutputFormat before close method
> -
>
> Key: FLINK-9941
> URL: https://issues.apache.org/jira/browse/FLINK-9941
> Project: Flink
> Issue Type: Improvement
> Components: Scala API
>Affects Versions: 1.5.1
>Reporter: Rannn Tao
>Assignee: buptljy
>Priority: Major
>
> Because not every stream's close method will flush, in order to ensure the
> stability of continuous integration, we need to manually call flush() before
> close().
> I noticed that CsvOutputFormat (Java API) has done this. As follows.
> {code:java}
> //CsvOutputFormat
> public void close() throws IOException {
> if (wrt != null) {
> this.wrt.flush();
> this.wrt.close();
> }
> super.close();
> }
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
