[ 
https://issues.apache.org/jira/browse/FLINK-4879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Metzger resolved FLINK-4879.
-----------------------------------
       Resolution: Fixed
    Fix Version/s:     (was: 1.1.4)
                   1.2.0

Resolved for 1.2 in http://git-wip-us.apache.org/repos/asf/flink/commit/e3324372

> class KafkaTableSource should be public just like KafkaTableSink
> ----------------------------------------------------------------
>
>                 Key: FLINK-4879
>                 URL: https://issues.apache.org/jira/browse/FLINK-4879
>             Project: Flink
>          Issue Type: Bug
>          Components: Kafka Connector, Table API & SQL
>    Affects Versions: 1.1.1, 1.1.3
>            Reporter: yuemeng
>            Priority: Minor
>             Fix For: 1.2.0
>
>         Attachments: 0001-class-KafkaTableSource-should-be-public.patch
>
>
> *class KafkaTableSource should be public just like KafkaTableSink,by 
> default,it's modifier is default ,and we cann't access out of it's package*,
> for example:
>  {code}
> def createKafkaTableSource(
>       topic: String,
>       properties: Properties,
>       deserializationSchema: DeserializationSchema[Row],
>       fieldsNames: Array[String],
>       typeInfo: Array[TypeInformation[_]]): KafkaTableSource = {
>     if (deserializationSchema != null) {
>       new Kafka09TableSource(topic, properties, deserializationSchema, 
> fieldsNames, typeInfo)
>     } else {
>       new Kafka09JsonTableSource(topic, properties, fieldsNames, typeInfo)
>     }
>   }
> {code}
> Because of the class KafkaTableSource modifier is default,we cann't define 
> this function result type with KafkaTableSource ,we must give the specific 
> type.
> if some other kafka source extends KafkaTableSource ,and we don't sure which 
> subclass of KafkaTableSource should be use,how can we specific the type?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to