[jira] [Updated] (FLINK-13880) The behavior of JobExecutionResult.getAccumulatorResult does not match its java doc
[
https://issues.apache.org/jira/browse/FLINK-13880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-13880:
---
Labels: pull-request-available (was: )
> The behavior of JobExecutionResult.getAccumulatorResult does not match its
> java doc
> ---
>
> Key: FLINK-13880
> URL: https://issues.apache.org/jira/browse/FLINK-13880
> Project: Flink
> Issue Type: Bug
> Components: API / Core
>Affects Versions: 1.11.0
>Reporter: Caizhi Weng
>Assignee: Caizhi Weng
>Priority: Major
> Labels: pull-request-available
>
> The java doc of `JobExecutionResult.getAccumulatorResult` states that
> "Returns \{@code null}, if no accumulator with that name was produced", but
> actually an NPE will be triggered if no accumulator with that name is
> produced.
> I'm going to rewrite the `getAccumulatorResult` method to the following:
> {code:java}
> public T getAccumulatorResult(String accumulatorName) {
>OptionalFailure result =
> this.accumulatorResults.get(accumulatorName);
>if (result != null) {
> return (T) result.getUnchecked();
>} else {
> return null;
>}
> }
> {code}
> Please assign this issue to me if this solution is acceptable.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FLINK-13880) The behavior of JobExecutionResult.getAccumulatorResult does not match its java doc
[
https://issues.apache.org/jira/browse/FLINK-13880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caizhi Weng updated FLINK-13880:
Affects Version/s: 1.11.0
> The behavior of JobExecutionResult.getAccumulatorResult does not match its
> java doc
> ---
>
> Key: FLINK-13880
> URL: https://issues.apache.org/jira/browse/FLINK-13880
> Project: Flink
> Issue Type: Bug
> Components: API / Core
>Affects Versions: 1.11.0
>Reporter: Caizhi Weng
>Assignee: Caizhi Weng
>Priority: Minor
>
> The java doc of `JobExecutionResult.getAccumulatorResult` states that
> "Returns \{@code null}, if no accumulator with that name was produced", but
> actually an NPE will be triggered if no accumulator with that name is
> produced.
> I'm going to rewrite the `getAccumulatorResult` method to the following:
> {code:java}
> public T getAccumulatorResult(String accumulatorName) {
>OptionalFailure result =
> this.accumulatorResults.get(accumulatorName);
>if (result != null) {
> return (T) result.getUnchecked();
>} else {
> return null;
>}
> }
> {code}
> Please assign this issue to me if this solution is acceptable.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FLINK-13880) The behavior of JobExecutionResult.getAccumulatorResult does not match its java doc
[
https://issues.apache.org/jira/browse/FLINK-13880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caizhi Weng updated FLINK-13880:
Component/s: (was: Runtime / Coordination)
API / Core
> The behavior of JobExecutionResult.getAccumulatorResult does not match its
> java doc
> ---
>
> Key: FLINK-13880
> URL: https://issues.apache.org/jira/browse/FLINK-13880
> Project: Flink
> Issue Type: Bug
> Components: API / Core
>Reporter: Caizhi Weng
>Assignee: Caizhi Weng
>Priority: Minor
>
> The java doc of `JobExecutionResult.getAccumulatorResult` states that
> "Returns \{@code null}, if no accumulator with that name was produced", but
> actually an NPE will be triggered if no accumulator with that name is
> produced.
> I'm going to rewrite the `getAccumulatorResult` method to the following:
> {code:java}
> public T getAccumulatorResult(String accumulatorName) {
>OptionalFailure result =
> this.accumulatorResults.get(accumulatorName);
>if (result != null) {
> return (T) result.getUnchecked();
>} else {
> return null;
>}
> }
> {code}
> Please assign this issue to me if this solution is acceptable.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FLINK-13880) The behavior of JobExecutionResult.getAccumulatorResult does not match its java doc
[
https://issues.apache.org/jira/browse/FLINK-13880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caizhi Weng updated FLINK-13880:
Priority: Major (was: Minor)
> The behavior of JobExecutionResult.getAccumulatorResult does not match its
> java doc
> ---
>
> Key: FLINK-13880
> URL: https://issues.apache.org/jira/browse/FLINK-13880
> Project: Flink
> Issue Type: Bug
> Components: API / Core
>Affects Versions: 1.11.0
>Reporter: Caizhi Weng
>Assignee: Caizhi Weng
>Priority: Major
>
> The java doc of `JobExecutionResult.getAccumulatorResult` states that
> "Returns \{@code null}, if no accumulator with that name was produced", but
> actually an NPE will be triggered if no accumulator with that name is
> produced.
> I'm going to rewrite the `getAccumulatorResult` method to the following:
> {code:java}
> public T getAccumulatorResult(String accumulatorName) {
>OptionalFailure result =
> this.accumulatorResults.get(accumulatorName);
>if (result != null) {
> return (T) result.getUnchecked();
>} else {
> return null;
>}
> }
> {code}
> Please assign this issue to me if this solution is acceptable.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FLINK-13880) The behavior of JobExecutionResult.getAccumulatorResult does not match its java doc
[
https://issues.apache.org/jira/browse/FLINK-13880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Metzger updated FLINK-13880:
---
Component/s: Runtime / Coordination
> The behavior of JobExecutionResult.getAccumulatorResult does not match its
> java doc
> ---
>
> Key: FLINK-13880
> URL: https://issues.apache.org/jira/browse/FLINK-13880
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Coordination
>Reporter: Caizhi Weng
>Priority: Minor
>
> The java doc of `JobExecutionResult.getAccumulatorResult` states that
> "Returns \{@code null}, if no accumulator with that name was produced", but
> actually an NPE will be triggered if no accumulator with that name is
> produced.
> I'm going to rewrite the `getAccumulatorResult` method to the following:
> {code:java}
> public T getAccumulatorResult(String accumulatorName) {
>OptionalFailure result =
> this.accumulatorResults.get(accumulatorName);
>if (result != null) {
> return (T) result.getUnchecked();
>} else {
> return null;
>}
> }
> {code}
> Please assign this issue to me if this solution is acceptable.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
