[jira] [Updated] (FLINK-34544) Tiered result partition should be released with lock
[ https://issues.apache.org/jira/browse/FLINK-34544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuxin Tan updated FLINK-34544: -- Description: When releasing `TieredResultPartition`, it is not protected by a lock(just like SortMergeResultPartition), then it may throw illegal state exceptions occasionally. We should fix it. (was: When releasing `TieredResultPartition`, it is not protected by a lock(just like SortMergeResultPartition), then it may throw iIlegal state exception occasionally. We should fix it.) > Tiered result partition should be released with lock > > > Key: FLINK-34544 > URL: https://issues.apache.org/jira/browse/FLINK-34544 > Project: Flink > Issue Type: Bug > Components: Runtime / Network >Affects Versions: 1.20.0 >Reporter: Yuxin Tan >Assignee: Yuxin Tan >Priority: Major > Labels: pull-request-available > > When releasing `TieredResultPartition`, it is not protected by a lock(just > like SortMergeResultPartition), then it may throw illegal state exceptions > occasionally. We should fix it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (FLINK-34544) Tiered result partition should be released with lock
[ https://issues.apache.org/jira/browse/FLINK-34544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuxin Tan updated FLINK-34544: -- Description: When releasing `TieredResultPartition`, it is not protected by a lock(just like SortMergeResultPartition), then it may throw iIlegal state exception occasionally. We should fix it. (was: When releasing `TieredResultPartition`, it is not protected by a lock, then it may throw iIlegal state exception occasionally. We should fix it.) > Tiered result partition should be released with lock > > > Key: FLINK-34544 > URL: https://issues.apache.org/jira/browse/FLINK-34544 > Project: Flink > Issue Type: Bug > Components: Runtime / Network >Affects Versions: 1.20.0 >Reporter: Yuxin Tan >Assignee: Yuxin Tan >Priority: Major > Labels: pull-request-available > > When releasing `TieredResultPartition`, it is not protected by a lock(just > like SortMergeResultPartition), then it may throw iIlegal state exception > occasionally. We should fix it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (FLINK-34544) Tiered result partition should be released with lock
[ https://issues.apache.org/jira/browse/FLINK-34544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34544: --- Labels: pull-request-available (was: ) > Tiered result partition should be released with lock > > > Key: FLINK-34544 > URL: https://issues.apache.org/jira/browse/FLINK-34544 > Project: Flink > Issue Type: Bug > Components: Runtime / Network >Affects Versions: 1.20.0 >Reporter: Yuxin Tan >Assignee: Yuxin Tan >Priority: Major > Labels: pull-request-available > > When releasing `TieredResultPartition`, it is not protected by a lock, then > it may throw iIlegal state exception occasionally. We should fix it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (FLINK-34544) Tiered result partition should be released with lock
[ https://issues.apache.org/jira/browse/FLINK-34544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuxin Tan updated FLINK-34544: -- Description: When releasing `TieredResultPartition`, it is not protected by a lock, then it may throw iIlegal state exception occasionally. We should fix it. (was: When releasing `TieredResultPartition`, it is not protected by a lock, then it may thrown iIlegal state exception occasionally. We should fix it.) > Tiered result partition should be released with lock > > > Key: FLINK-34544 > URL: https://issues.apache.org/jira/browse/FLINK-34544 > Project: Flink > Issue Type: Bug > Components: Runtime / Network >Affects Versions: 1.20.0 >Reporter: Yuxin Tan >Assignee: Yuxin Tan >Priority: Major > > When releasing `TieredResultPartition`, it is not protected by a lock, then > it may throw iIlegal state exception occasionally. We should fix it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (FLINK-34544) Tiered result partition should be released with lock
[ https://issues.apache.org/jira/browse/FLINK-34544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuxin Tan updated FLINK-34544: -- Description: When releasing `TieredResultPartition`, it is not protected by a lock, then it may thrown iIlegal state exception occasionally. We should fix it. (was: The `TieredStorageMemoryManagerImpl` has a `numRequestedBuffers` check when releasing resources. However, this check is performed in the task thread, while the buffer recycle may occur in the Netty thread. As a result, it may incorrectly throw an exception when the release is too quick for the vertex, which has almost no data. We should fix it.) > Tiered result partition should be released with lock > > > Key: FLINK-34544 > URL: https://issues.apache.org/jira/browse/FLINK-34544 > Project: Flink > Issue Type: Bug > Components: Runtime / Network >Affects Versions: 1.20.0 >Reporter: Yuxin Tan >Assignee: Yuxin Tan >Priority: Major > > When releasing `TieredResultPartition`, it is not protected by a lock, then > it may thrown iIlegal state exception occasionally. We should fix it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (FLINK-34544) Tiered result partition should be released with lock
[ https://issues.apache.org/jira/browse/FLINK-34544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuxin Tan updated FLINK-34544: -- Summary: Tiered result partition should be released with lock (was: The release check bug in tiered memory manager of hybrid shuffle) > Tiered result partition should be released with lock > > > Key: FLINK-34544 > URL: https://issues.apache.org/jira/browse/FLINK-34544 > Project: Flink > Issue Type: Bug > Components: Runtime / Network >Affects Versions: 1.20.0 >Reporter: Yuxin Tan >Assignee: Yuxin Tan >Priority: Major > > The `TieredStorageMemoryManagerImpl` has a `numRequestedBuffers` check when > releasing resources. However, this check is performed in the task thread, > while the buffer recycle may occur in the Netty thread. As a result, it may > incorrectly throw an exception when the release is too quick for the vertex, > which has almost no data. > We should fix it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
