Eric Shu created GEODE-5382:
-------------------------------

             Summary: Geode TransactionManagerImpl.commit() does not throw 
Exception when notifyAfterCompletion failed
                 Key: GEODE-5382
                 URL: https://issues.apache.org/jira/browse/GEODE-5382
             Project: Geode
          Issue Type: Bug
          Components: transactions
            Reporter: Eric Shu


Currently, commit() method only logs the exception. 
{code:java}
    try {
      ((TransactionImpl) transactionImpl).notifyAfterCompletion(status = 
gtx.getStatus());
    } catch (Exception ge) {
      LogWriterI18n writer = TransactionUtils.getLogWriterI18n();
      if (writer.infoEnabled())
        writer.info(
            
LocalizedStrings.TransactionManagerImpl_EXCEPTION_IN_NOTIFY_AFTER_COMPLETION_DUE_TO__0,
            ge.getMessage(), ge);
    }
{code}

It should throw exception to user application so that application can decide 
whether retry. Currently, data inconsistency could occur but applicate does not 
even notice about it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to