[jira] [Commented] (GEODE-2156) Remove incubating references
[ https://issues.apache.org/jira/browse/GEODE-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15710836#comment-15710836 ] ASF subversion and git services commented on GEODE-2156: Commit 3e84342bdf018253072232d178f28a36f5398dd4 in incubator-geode's branch refs/heads/feature/GEODE-2156 from [~amb] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=3e84342 ] GEODE-2156: Remove incubating references from the website > Remove incubating references > > > Key: GEODE-2156 > URL: https://issues.apache.org/jira/browse/GEODE-2156 > Project: Geode > Issue Type: Task >Reporter: Anthony Baker > Fix For: 1.1.0 > > > With the completion of GEODE-1, we need to update the following: > 1) Project name references no longer need to include "(incubating)" > 2) Project website references should remove ".incubator" > 3) Project email lists should remove ".incubator" > 4) DISCLAIMER no longer applies > 5) Git repo references should remove "incubator-" -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (GEODE-2161) FilterRoutingInfo.FilterInfo.toData does unneeded copying
xiaojian zhou created GEODE-2161:
Summary: FilterRoutingInfo.FilterInfo.toData does unneeded copying
Key: GEODE-2161
URL: https://issues.apache.org/jira/browse/GEODE-2161
Project: Geode
Issue Type: Bug
Reporter: xiaojian zhou
This is #52614
FilterInfo.toData (that was being optimized for murex) does this:
// create a hdos
// write a bunch of stuff to it
byte[] myData = hdos.toByteArray();
DataSerializer.writeByteArray(myData, out);
he toByteArray allocates a new byte array and copies all the data in the hdos
to it.
Then writeByteArray writes it all to "out".
We can do this instead:
if (out instanceof HeapDataOutputStream) {
out.writeAsSerializedByteArray(hdos);
} else {
.. do it the old way
}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (GEODE-2160) gfsh stop server/locator exits with code 0 before server/locator actually stops
[
https://issues.apache.org/jira/browse/GEODE-2160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacob S. Barrett updated GEODE-2160:
Description:
Executing
{code}
gfsh stop server --name=server1
{code}
{{gfsh}} exits, with code 0, prior to the server actually being stopped.
This behavior isn't documented and makes scripting with gfsh difficult. One
can't assume that the server has stopped after gfsh exits. To verify you must
parse the server pid and check the status of the proc.
Simple test:
{code}
gfsh start server --name=s2 && sleep 10 && gfsh stop server --dir=s2; echo $?;
while (kill -0 `cat s2/vf.gf.server.pid`); do date +%s.%N; done
{code}
Starts server, waits 10s, stops server, prints exit code, loops until process
is gone while printing the time since epoch.
was:
Executing
{code}
gfsh stop server --name=server1
{code}
{{gfsh}} exits, with code 0, prior to the server actually being stopped.
Simple test:
{code}
gfsh start server --name=s2 && sleep 10 && gfsh stop server --dir=s2; echo $?;
while (kill -0 `cat s2/vf.gf.server.pid`); do date +%s.%N; done
{code}
Starts server, waits 10s, stops server, prints exit code, loops until process
is gone while printing the time since epoch.
> gfsh stop server/locator exits with code 0 before server/locator actually
> stops
> ---
>
> Key: GEODE-2160
> URL: https://issues.apache.org/jira/browse/GEODE-2160
> Project: Geode
> Issue Type: Bug
>Affects Versions: 1.0.0-incubating
>Reporter: Jacob S. Barrett
>
> Executing
> {code}
> gfsh stop server --name=server1
> {code}
> {{gfsh}} exits, with code 0, prior to the server actually being stopped.
> This behavior isn't documented and makes scripting with gfsh difficult. One
> can't assume that the server has stopped after gfsh exits. To verify you must
> parse the server pid and check the status of the proc.
> Simple test:
> {code}
> gfsh start server --name=s2 && sleep 10 && gfsh stop server --dir=s2; echo
> $?; while (kill -0 `cat s2/vf.gf.server.pid`); do date +%s.%N; done
> {code}
> Starts server, waits 10s, stops server, prints exit code, loops until process
> is gone while printing the time since epoch.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (GEODE-2160) gfsh stop server/locator exits with code 0 before server/locator actually stops
Jacob S. Barrett created GEODE-2160:
---
Summary: gfsh stop server/locator exits with code 0 before
server/locator actually stops
Key: GEODE-2160
URL: https://issues.apache.org/jira/browse/GEODE-2160
Project: Geode
Issue Type: Bug
Reporter: Jacob S. Barrett
Executing
{code}
gfsh stop server --name=server1
{code}
{{gfsh}} exits, with code 0, prior to the server actually being stopped.
Simple test:
{code}
gfsh start server --name=s2 && sleep 10 && gfsh stop server --dir=s2; echo $?;
while (kill -0 `cat s2/vf.gf.server.pid`); do date +%s.%N; done
{code}
Starts server, waits 10s, stops server, prints exit code, loops until process
is gone while printing the time since epoch.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-2157) PutAllPartialResultException does not have a serialVersionUID
[ https://issues.apache.org/jira/browse/GEODE-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15710377#comment-15710377 ] ASF subversion and git services commented on GEODE-2157: Commit 423e04f9d86962cb183b38612b8eb21afe91e1cd in incubator-geode's branch refs/heads/develop from [~upthewaterspout] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=423e04f ] GEODE-2157: Fixing sanctionedSerializables for PutAllPartialResultEx > PutAllPartialResultException does not have a serialVersionUID > - > > Key: GEODE-2157 > URL: https://issues.apache.org/jira/browse/GEODE-2157 > Project: Geode > Issue Type: Bug > Components: serialization >Reporter: Dan Smith >Assignee: Dan Smith > Fix For: 1.1.0 > > > This class is serialized, potentially to members that are running older > versions before package renaming. But it does not have a serial version uid. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (GEODE-2159) add serialVersionUIDs to exception classes not having them
Bruce Schuchardt created GEODE-2159: --- Summary: add serialVersionUIDs to exception classes not having them Key: GEODE-2159 URL: https://issues.apache.org/jira/browse/GEODE-2159 Project: Geode Issue Type: Bug Components: messaging Reporter: Bruce Schuchardt I made a pass through exceptions that are checked for by client caches but recently we found that I missed one. We need to make a pass through all of the exception classes and ensure that they have serialVersionUIDs so that we don't inadvertently make a change that breaks backward compatibility. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (GEODE-2158) Incorrect NOTICE file
Anthony Baker created GEODE-2158:
Summary: Incorrect NOTICE file
Key: GEODE-2158
URL: https://issues.apache.org/jira/browse/GEODE-2158
Project: Geode
Issue Type: Bug
Components: build
Reporter: Anthony Baker
The following subprojects have specific {{NOTICE}} files that should be
included in the jar artifact:
- geode-pulse
- geode-web
- geode-web-api
Starting in 1.0.0-incubating.M3, only the standard source {{NOTICE}} was used.
We should fix the build to make sure the correct file is used.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (GEODE-2146) function "deploy" only requires DATA:MANAGE privilege, but a malicious user can write a function to change the securityManager and then execute anything
[ https://issues.apache.org/jira/browse/GEODE-2146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karen Smoler Miller updated GEODE-2146: --- Component/s: docs > function "deploy" only requires DATA:MANAGE privilege, but a malicious user > can write a function to change the securityManager and then execute anything > - > > Key: GEODE-2146 > URL: https://issues.apache.org/jira/browse/GEODE-2146 > Project: Geode > Issue Type: Improvement > Components: docs, security >Reporter: Jinmei Liao > > A simple function would do the following: > SecurityUtils.setSecurityManager(null); > This would jeopardize all the security checks afterwards and let user do > pretty much everything. > We should either sandbox the function execution or have deploy require ALL > permissions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-2157) PutAllPartialResultException does not have a serialVersionUID
[ https://issues.apache.org/jira/browse/GEODE-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15709960#comment-15709960 ] ASF subversion and git services commented on GEODE-2157: Commit be1d5e31aa0aa41212e269a739cdbeada9e87310 in incubator-geode's branch refs/heads/develop from [~upthewaterspout] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=be1d5e3 ] GEODE-2157: Adding a serialVersionUID to PutAllPartialResultException Adding the serialVersionUID from the old version of this class to PutAllPartialResultException. > PutAllPartialResultException does not have a serialVersionUID > - > > Key: GEODE-2157 > URL: https://issues.apache.org/jira/browse/GEODE-2157 > Project: Geode > Issue Type: Bug > Components: serialization >Reporter: Dan Smith >Assignee: Dan Smith > > This class is serialized, potentially to members that are running older > versions before package renaming. But it does not have a serial version uid. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (GEODE-2143) JSON deserialization fails if a String contains an apostrophe
[
https://issues.apache.org/jira/browse/GEODE-2143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Duling updated GEODE-2143:
Description:
Testing revealed this causes an issue when a String value contains a single
apostrophe in it. For example: {{Customer customer = new Customer(1L, "Galen",
"O'Sullivan", "555-11-");}}
If you create a region and put in a value which is an instance of
org.apache.geode.rest.internal.web.controllers.Customer, then gfsh blows up
when attempting to display the value:
{code}
gfsh>query --query="select * from /customers"
Result : true
startCount : 0
endCount : 20
Rows : 1
Value
---
Error getting bean properties Expected a ',' or '}' at 86 [character 87 line 1]
{code}
It would be good to determine why this occurs to prevent the same error from
arising with user-provided classes.
The error occurs in
was:
Testing revealed this causes an issue when a String value contains a single
apostrophe in it. For example: {{Customer customer = new Customer(1L, "Galen",
"O'Sullivan", "555-11-");}}
If you create a region and put in a value which is an instance of
org.apache.geode.rest.internal.web.controllers.Customer, then gfsh blows up
when attempting to display the value:
{code}
gfsh>query --query="select * from /customers"
Result : true
startCount : 0
endCount : 20
Rows : 1
Value
---
Error getting bean properties Expected a ',' or '}' at 86 [character 87 line 1]
{code}
It would be good to determine why this occurs to prevent the same error from
arising with user-provided classes.
> JSON deserialization fails if a String contains an apostrophe
> -
>
> Key: GEODE-2143
> URL: https://issues.apache.org/jira/browse/GEODE-2143
> Project: Geode
> Issue Type: Bug
> Components: gfsh
>Reporter: Jared Stewart
>Assignee: Kevin Duling
>
> Testing revealed this causes an issue when a String value contains a single
> apostrophe in it. For example: {{Customer customer = new Customer(1L,
> "Galen", "O'Sullivan", "555-11-");}}
> If you create a region and put in a value which is an instance of
> org.apache.geode.rest.internal.web.controllers.Customer, then gfsh blows up
> when attempting to display the value:
> {code}
> gfsh>query --query="select * from /customers"
> Result : true
> startCount : 0
> endCount : 20
> Rows : 1
> Value
> ---
> Error getting bean properties Expected a ',' or '}' at 86 [character 87 line
> 1]
> {code}
> It would be good to determine why this occurs to prevent the same error from
> arising with user-provided classes.
> The error occurs in
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (GEODE-2143) JSON deserialization fails if a String contains an apostrophe
[
https://issues.apache.org/jira/browse/GEODE-2143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Duling updated GEODE-2143:
Summary: JSON deserialization fails if a String contains an apostrophe
(was: JSON deserialization doesn't work for our sample Customer object)
> JSON deserialization fails if a String contains an apostrophe
> -
>
> Key: GEODE-2143
> URL: https://issues.apache.org/jira/browse/GEODE-2143
> Project: Geode
> Issue Type: Bug
> Components: gfsh
>Reporter: Jared Stewart
>Assignee: Kevin Duling
>
> Testing revealed this causes an issue when a String value contains a single
> apostrophe in it. For example: {{Customer customer = new Customer(1L,
> "Galen", "O'Sullivan", "555-11-");}}
> If you create a region and put in a value which is an instance of
> org.apache.geode.rest.internal.web.controllers.Customer, then gfsh blows up
> when attempting to display the value:
> {code}
> gfsh>query --query="select * from /customers"
> Result : true
> startCount : 0
> endCount : 20
> Rows : 1
> Value
> ---
> Error getting bean properties Expected a ',' or '}' at 86 [character 87 line
> 1]
> {code}
> It would be good to determine why this occurs to prevent the same error from
> arising with user-provided classes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (GEODE-2143) JSON deserialization doesn't work for our sample Customer object
[
https://issues.apache.org/jira/browse/GEODE-2143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Duling updated GEODE-2143:
Description:
Testing revealed this causes an issue when a String value contains a single
apostrophe in it. For example: {{Customer customer = new Customer(1L, "Galen",
"O'Sullivan", "555-11-");}}
If you create a region and put in a value which is an instance of
org.apache.geode.rest.internal.web.controllers.Customer, then gfsh blows up
when attempting to display the value:
{code}
gfsh>query --query="select * from /customers"
Result : true
startCount : 0
endCount : 20
Rows : 1
Value
---
Error getting bean properties Expected a ',' or '}' at 86 [character 87 line 1]
{code}
It would be good to determine why this occurs to prevent the same error from
arising with user-provided classes.
was:
If you create a region and put in a value which is an instance of
org.apache.geode.rest.internal.web.controllers.Customer, then gfsh blows up
when attempting to display the value:
{code}
gfsh>query --query="select * from /customers"
Result : true
startCount : 0
endCount : 20
Rows : 1
Value
---
Error getting bean properties Expected a ',' or '}' at 86 [character 87 line 1]
{code}
It would be good to determine why this occurs to prevent the same error from
arising with user-provided classes.
> JSON deserialization doesn't work for our sample Customer object
>
>
> Key: GEODE-2143
> URL: https://issues.apache.org/jira/browse/GEODE-2143
> Project: Geode
> Issue Type: Bug
> Components: gfsh
>Reporter: Jared Stewart
>Assignee: Kevin Duling
>
> Testing revealed this causes an issue when a String value contains a single
> apostrophe in it. For example: {{Customer customer = new Customer(1L,
> "Galen", "O'Sullivan", "555-11-");}}
> If you create a region and put in a value which is an instance of
> org.apache.geode.rest.internal.web.controllers.Customer, then gfsh blows up
> when attempting to display the value:
> {code}
> gfsh>query --query="select * from /customers"
> Result : true
> startCount : 0
> endCount : 20
> Rows : 1
> Value
> ---
> Error getting bean properties Expected a ',' or '}' at 86 [character 87 line
> 1]
> {code}
> It would be good to determine why this occurs to prevent the same error from
> arising with user-provided classes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (GEODE-2157) PutAllPartialResultException does not have a serialVersionUID
[ https://issues.apache.org/jira/browse/GEODE-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Smith reassigned GEODE-2157: Assignee: Dan Smith > PutAllPartialResultException does not have a serialVersionUID > - > > Key: GEODE-2157 > URL: https://issues.apache.org/jira/browse/GEODE-2157 > Project: Geode > Issue Type: Bug > Components: serialization >Reporter: Dan Smith >Assignee: Dan Smith > > This class is serialized, potentially to members that are running older > versions before package renaming. But it does not have a serial version uid. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (GEODE-2157) PutAllPartialResultException does not have a serialVersionUID
[ https://issues.apache.org/jira/browse/GEODE-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Smith updated GEODE-2157: - Component/s: serialization > PutAllPartialResultException does not have a serialVersionUID > - > > Key: GEODE-2157 > URL: https://issues.apache.org/jira/browse/GEODE-2157 > Project: Geode > Issue Type: Bug > Components: serialization >Reporter: Dan Smith >Assignee: Dan Smith > > This class is serialized, potentially to members that are running older > versions before package renaming. But it does not have a serial version uid. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-2157) PutAllPartialResultException does not have a serialVersionUID
[ https://issues.apache.org/jira/browse/GEODE-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15709469#comment-15709469 ] ASF subversion and git services commented on GEODE-2157: Commit cbb113f2a66b1c8d1d5d2ecfd4b4a910e1793861 in incubator-geode's branch refs/heads/feature/GEODE-2157 from [~upthewaterspout] [ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=cbb113f ] GEODE-2157: Adding a serialVersionUID to PutAllPartialResultException Adding the serialVersionUID from the old version of this class to PutAllPartialResultException. > PutAllPartialResultException does not have a serialVersionUID > - > > Key: GEODE-2157 > URL: https://issues.apache.org/jira/browse/GEODE-2157 > Project: Geode > Issue Type: Bug >Reporter: Dan Smith > > This class is serialized, potentially to members that are running older > versions before package renaming. But it does not have a serial version uid. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (GEODE-1927) add support for old GemFire remote sites (WAN)
[ https://issues.apache.org/jira/browse/GEODE-1927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Smith reassigned GEODE-1927: Assignee: Dan Smith > add support for old GemFire remote sites (WAN) > -- > > Key: GEODE-1927 > URL: https://issues.apache.org/jira/browse/GEODE-1927 > Project: Geode > Issue Type: Bug > Components: docs, messaging >Reporter: Bruce Schuchardt >Assignee: Dan Smith > Fix For: 1.0.0-incubating > > > We need to protect the Geode cache from receiving serialized objects from a > remote site that have com.gemstone.gemfire package names. These primarily > include enumeration-type objects like cache.Operation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (GEODE-2011) CI Failure: PdxClientServerDUnitTest.testNonPersistentServerRestartAutoSerializer
[ https://issues.apache.org/jira/browse/GEODE-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hitesh Khamesra closed GEODE-2011. -- > CI Failure: > PdxClientServerDUnitTest.testNonPersistentServerRestartAutoSerializer > - > > Key: GEODE-2011 > URL: https://issues.apache.org/jira/browse/GEODE-2011 > Project: Geode > Issue Type: Bug > Components: serialization >Reporter: Kirk Lund >Assignee: Hitesh Khamesra > Labels: CI, Flaky > > org.apache.geode.pdx.PdxClientServerDUnitTest > > testNonPersistentServerRestartAutoSerializer FAILED > org.apache.geode.test.dunit.RMIException: While invoking > org.apache.geode.pdx.PdxClientServerDUnitTest$12.call in VM 2 running on Host > 5c320afe with 4 VMs > at org.apache.geode.test.dunit.VM.invoke(VM.java:389) > at org.apache.geode.test.dunit.VM.invoke(VM.java:355) > at org.apache.geode.test.dunit.VM.invoke(VM.java:320) > at > org.apache.geode.pdx.PdxClientServerDUnitTest.testNonPersistentServerRestartAutoSerializer(PdxClientServerDUnitTest.java:255) > Caused by: > java.lang.ClassCastException: > org.apache.geode.pdx.PdxClientServerDUnitTest$AutoPdxType1 cannot be cast to > org.apache.geode.pdx.PdxClientServerDUnitTest$AutoPdxType2 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (GEODE-2137) client membership IDs contain 17 bytes of useless information that should be removed
[ https://issues.apache.org/jira/browse/GEODE-2137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruce Schuchardt resolved GEODE-2137. - Resolution: Fixed Fix Version/s: 1.1.0 Note: this change required bumping up the Version in order to not break backward compatibility with 1.0.0. > client membership IDs contain 17 bytes of useless information that should be > removed > > > Key: GEODE-2137 > URL: https://issues.apache.org/jira/browse/GEODE-2137 > Project: Geode > Issue Type: Improvement > Components: client/server >Reporter: Bruce Schuchardt >Assignee: Bruce Schuchardt > Fix For: 1.1.0 > > > Clients use the same membership ID class as servers. Server IDs contain the > UUID needed for some communications. They also carry a byte for > member-weight adjustments. These bytes are not needed in the serialized form > of client membership IDs and should be supressed, saving 17 bytes per > serialized ID. > Server-side version tags and event IDs also do not need these bytes in their > serialized form. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (GEODE-1653) Executing a fire-and-forget function on all servers doesn't actually execute on all servers
[
https://issues.apache.org/jira/browse/GEODE-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15709358#comment-15709358
]
ASF GitHub Bot commented on GEODE-1653:
---
Github user gesterzhou commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/293#discussion_r90296214
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/cache/FireAndForgetFunctionOnAllServersDUnitTest.java
---
@@ -92,22 +90,23 @@ public void testFireAndForgetFunctionOnAllServers() {
// Step 4. Execute the function to put DistributedMemberID into
above created replicated
// region.
- Function function =
- new TestFunction(false,
TestFunction.TEST_FUNCTION_FIREANDFORGET_ONALL_SERVERS);
+ Function function = new FireAndForgetFunctionOnAllServers();
FunctionService.registerFunction(function);
+ PoolImpl pool = (PoolImpl) pool1;
+
+ await().atMost(60, SECONDS)
+ .until(() -> Assert.assertEquals(1,
pool.getCurrentServers().size()));
--- End diff --
The 2 lines should be moved to line 120. Otherwise, I wonder why the test
will pass.
> Executing a fire-and-forget function on all servers doesn't actually execute
> on all servers
> ---
>
> Key: GEODE-1653
> URL: https://issues.apache.org/jira/browse/GEODE-1653
> Project: Geode
> Issue Type: Bug
> Components: functions
>Reporter: Barry Oglesby
>Assignee: Amey Barve
>
> Executing a fire-and-forget function on all servers only executes on the ones
> the client is currently connected to.
> The two {{ExecuteFunctionNoAckOp execute}} methods get the servers to execute
> against using code like:
> {noformat}
> pool.getCurrentServers();
> {noformat}
> This method just gets all the {{EndpointManager's endpointMap's
> ServerLocations}}.
> What should be done is more like what the {{ExecuteFunctionOp execute}}
> methods do:
> {noformat}
> private static List getAllServers(PoolImpl pool) {
> List servers = null;
> if (pool.getLocators() == null || pool.getLocators().isEmpty()) {
> servers = ((ExplicitConnectionSourceImpl)
> pool.getConnectionSource()).getAllServers();
> } else {
> servers = ((AutoConnectionSourceImpl)
> pool.getConnectionSource()).findAllServers(); // n/w call on locator
> }
> return servers;
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (GEODE-1653) Executing a fire-and-forget function on all servers doesn't actually execute on all servers
[
https://issues.apache.org/jira/browse/GEODE-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15709343#comment-15709343
]
ASF GitHub Bot commented on GEODE-1653:
---
Github user gesterzhou commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/293#discussion_r90295325
--- Diff:
geode-core/src/main/java/org/apache/geode/cache/client/internal/ExplicitConnectionSourceImpl.java
---
@@ -257,7 +257,7 @@ public String toString() {
return sb.toString();
}
- ArrayList getAllServers() {
+ public ArrayList getAllServers() {
--- End diff --
Better to add @Override here
> Executing a fire-and-forget function on all servers doesn't actually execute
> on all servers
> ---
>
> Key: GEODE-1653
> URL: https://issues.apache.org/jira/browse/GEODE-1653
> Project: Geode
> Issue Type: Bug
> Components: functions
>Reporter: Barry Oglesby
>Assignee: Amey Barve
>
> Executing a fire-and-forget function on all servers only executes on the ones
> the client is currently connected to.
> The two {{ExecuteFunctionNoAckOp execute}} methods get the servers to execute
> against using code like:
> {noformat}
> pool.getCurrentServers();
> {noformat}
> This method just gets all the {{EndpointManager's endpointMap's
> ServerLocations}}.
> What should be done is more like what the {{ExecuteFunctionOp execute}}
> methods do:
> {noformat}
> private static List getAllServers(PoolImpl pool) {
> List servers = null;
> if (pool.getLocators() == null || pool.getLocators().isEmpty()) {
> servers = ((ExplicitConnectionSourceImpl)
> pool.getConnectionSource()).getAllServers();
> } else {
> servers = ((AutoConnectionSourceImpl)
> pool.getConnectionSource()).findAllServers(); // n/w call on locator
> }
> return servers;
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
