[jira] [Closed] (GEODE-3211) Re-enable inline optimization on Windows Release
[ https://issues.apache.org/jira/browse/GEODE-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacob S. Barrett closed GEODE-3211. --- > Re-enable inline optimization on Windows Release > > > Key: GEODE-3211 > URL: https://issues.apache.org/jira/browse/GEODE-3211 > Project: Geode > Issue Type: Sub-task > Components: native client >Reporter: Ernest Burghardt >Assignee: Jacob S. Barrett > > in file: > C:\geode-native\src\cppcache\src\CMakeLists.txt > # Remove this after fixing static initialization > target_compile_options(apache-geode-static PRIVATE "/Ob0") -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (GEODE-2729) Improve Native Client Stability by removing global variables
[ https://issues.apache.org/jira/browse/GEODE-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacob S. Barrett resolved GEODE-2729. - Resolution: Fixed > Improve Native Client Stability by removing global variables > > > Key: GEODE-2729 > URL: https://issues.apache.org/jira/browse/GEODE-2729 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Addison > > *Context* > Today, the native client uses singleton global variables to manage things > like the cache. These prove troublesome when moving between managed and > unmanaged code. Another benefit of moving away from the globals is improved > unit testing. This will increase the overall testing feedback loop. > *Goal* > Remove these singletons in favor non-global constructors, destructors, etc. > Improved stability when calling functions that move between managed and > unmanaged code. > *Definition of Done* > Remove all integration tests in favor of well encapsulated unit tests. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (GEODE-2729) Improve Native Client Stability by removing global variables
[ https://issues.apache.org/jira/browse/GEODE-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacob S. Barrett closed GEODE-2729. --- > Improve Native Client Stability by removing global variables > > > Key: GEODE-2729 > URL: https://issues.apache.org/jira/browse/GEODE-2729 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Addison > > *Context* > Today, the native client uses singleton global variables to manage things > like the cache. These prove troublesome when moving between managed and > unmanaged code. Another benefit of moving away from the globals is improved > unit testing. This will increase the overall testing feedback loop. > *Goal* > Remove these singletons in favor non-global constructors, destructors, etc. > Improved stability when calling functions that move between managed and > unmanaged code. > *Definition of Done* > Remove all integration tests in favor of well encapsulated unit tests. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (GEODE-3211) Re-enable inline optimization on Windows Release
[ https://issues.apache.org/jira/browse/GEODE-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacob S. Barrett resolved GEODE-3211. - Resolution: Fixed > Re-enable inline optimization on Windows Release > > > Key: GEODE-3211 > URL: https://issues.apache.org/jira/browse/GEODE-3211 > Project: Geode > Issue Type: Sub-task > Components: native client >Reporter: Ernest Burghardt >Assignee: Jacob S. Barrett > > in file: > C:\geode-native\src\cppcache\src\CMakeLists.txt > # Remove this after fixing static initialization > target_compile_options(apache-geode-static PRIVATE "/Ob0") -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-3211) Re-enable inline optimization on Windows Release
[ https://issues.apache.org/jira/browse/GEODE-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124385#comment-16124385 ] ASF subversion and git services commented on GEODE-3211: Commit 8f340e4ddd15de132f042525a566d4e8a73f9e44 in geode-native's branch refs/heads/develop from Jacob Barrett [ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=8f340e4 ] GEODE-3211: Re-enabled inline optimizations on windows. > Re-enable inline optimization on Windows Release > > > Key: GEODE-3211 > URL: https://issues.apache.org/jira/browse/GEODE-3211 > Project: Geode > Issue Type: Sub-task > Components: native client >Reporter: Ernest Burghardt >Assignee: Jacob S. Barrett > > in file: > C:\geode-native\src\cppcache\src\CMakeLists.txt > # Remove this after fixing static initialization > target_compile_options(apache-geode-static PRIVATE "/Ob0") -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (GEODE-3211) Re-enable inline optimization on Windows Release
[ https://issues.apache.org/jira/browse/GEODE-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacob S. Barrett reassigned GEODE-3211: --- Assignee: Jacob S. Barrett > Re-enable inline optimization on Windows Release > > > Key: GEODE-3211 > URL: https://issues.apache.org/jira/browse/GEODE-3211 > Project: Geode > Issue Type: Sub-task > Components: native client >Reporter: Ernest Burghardt >Assignee: Jacob S. Barrett > > in file: > C:\geode-native\src\cppcache\src\CMakeLists.txt > # Remove this after fixing static initialization > target_compile_options(apache-geode-static PRIVATE "/Ob0") -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-3435) Fix serialization test failure for ParallelSnapshotFileMapper
[ https://issues.apache.org/jira/browse/GEODE-3435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124370#comment-16124370 ] ASF GitHub Bot commented on GEODE-3435: --- Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/710 > Fix serialization test failure for ParallelSnapshotFileMapper > - > > Key: GEODE-3435 > URL: https://issues.apache.org/jira/browse/GEODE-3435 > Project: Geode > Issue Type: Bug >Reporter: Nick Reich >Assignee: Nick Reich > Fix For: 1.3.0 > > > ParallelSnapshotFileMapper was not correctly added to > sanctionedSerializables.txt -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-3435) Fix serialization test failure for ParallelSnapshotFileMapper
[ https://issues.apache.org/jira/browse/GEODE-3435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124368#comment-16124368 ] ASF subversion and git services commented on GEODE-3435: Commit 566ff6c70a91e052be558df80b76f2eef611c1c8 in geode's branch refs/heads/develop from [~nreich] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=566ff6c ] GEODE-3435: Fix serialization test failure This closes #710 > Fix serialization test failure for ParallelSnapshotFileMapper > - > > Key: GEODE-3435 > URL: https://issues.apache.org/jira/browse/GEODE-3435 > Project: Geode > Issue Type: Bug >Reporter: Nick Reich >Assignee: Nick Reich > Fix For: 1.3.0 > > > ParallelSnapshotFileMapper was not correctly added to > sanctionedSerializables.txt -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (GEODE-3304) CI failure: LuceneIndexDestroyDUnitTest.verifyDestroySingleIndexWhileDoingPuts fails with RegionDestroyedException
[
https://issues.apache.org/jira/browse/GEODE-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xiaojian zhou updated GEODE-3304:
-
Fix Version/s: 1.3.0
> CI failure:
> LuceneIndexDestroyDUnitTest.verifyDestroySingleIndexWhileDoingPuts fails with
> RegionDestroyedException
> --
>
> Key: GEODE-3304
> URL: https://issues.apache.org/jira/browse/GEODE-3304
> Project: Geode
> Issue Type: Bug
> Components: lucene
>Affects Versions: 1.3.0
>Reporter: Shelley Lynn Hughes-Godfrey
> Fix For: 1.3.0
>
>
> {noformat}
> org.apache.geode.cache.lucene.LuceneIndexDestroyDUnitTest >
> verifyDestroySingleIndexWhileDoingPuts(PARTITION_REDUNDANT) [1] FAILED
> org.apache.geode.InternalGemFireError:
> org.apache.geode.cache.RegionDestroyedException: Partitioned Region @354cb015
> [path='/region'; dataPolicy=PARTITION; prId=239; isDestroyed=false;
> isClosed=false; retryTimeout=360; serialNumber=4204; partition
> attributes=PartitionAttributes@536733386[redundantCopies=1;localMaxMemory=100;totalMaxMemory=2147483647;totalNumBuckets=10;partitionResolver=null;colocatedWith=null;recoveryDelay=-1;startupRecoveryDelay=0;FixedPartitionAttributes=null;partitionListeners=null];
> on VM 172.17.0.8(172):32770], caused by
> org.apache.geode.cache.RegionDestroyedException: Partitioned Region @43ee7285
> [path='/AsyncEventQueue_index#_region_PARALLEL_GATEWAY_SENDER_QUEUE';
> dataPolicy=PARTITION; prId=240; isDestroyed=true; isClosed=false;
> retryTimeout=360; serialNumber=4216; partition
> attributes=PartitionAttributes@1047578025[redundantCopies=1;localMaxMemory=1000;totalMaxMemory=2147483647;totalNumBuckets=10;partitionResolver=null;colocatedWith=/region;recoveryDelay=-1;startupRecoveryDelay=0;FixedPartitionAttributes=null;partitionListeners=null];
> on VM 172.17.0.8(172):32770]
> at org.apache.geode.internal.Assert.throwError(Assert.java:94)
> at org.apache.geode.internal.Assert.fail(Assert.java:68)
> at
> org.apache.geode.cache.lucene.LuceneIndexDestroyDUnitTest.verifyDestroySingleIndexWhileDoingPuts(LuceneIndexDestroyDUnitTest.java:175)
> Caused by:
> org.apache.geode.cache.RegionDestroyedException: Partitioned Region
> @354cb015 [path='/region'; dataPolicy=PARTITION; prId=239; isDestroyed=false;
> isClosed=false; retryTimeout=360; serialNumber=4204; partition
> attributes=PartitionAttributes@536733386[redundantCopies=1;localMaxMemory=100;totalMaxMemory=2147483647;totalNumBuckets=10;partitionResolver=null;colocatedWith=null;recoveryDelay=-1;startupRecoveryDelay=0;FixedPartitionAttributes=null;partitionListeners=null];
> on VM 172.17.0.8(172):32770], caused by
> org.apache.geode.cache.RegionDestroyedException: Partitioned Region @43ee7285
> [path='/AsyncEventQueue_index#_region_PARALLEL_GATEWAY_SENDER_QUEUE';
> dataPolicy=PARTITION; prId=240; isDestroyed=true; isClosed=false;
> retryTimeout=360; serialNumber=4216; partition
> attributes=PartitionAttributes@1047578025[redundantCopies=1;localMaxMemory=1000;totalMaxMemory=2147483647;totalNumBuckets=10;partitionResolver=null;colocatedWith=/region;recoveryDelay=-1;startupRecoveryDelay=0;FixedPartitionAttributes=null;partitionListeners=null];
> on VM 172.17.0.8(172):32770]
> at
> org.apache.geode.internal.cache.PartitionedRegion.virtualPut(PartitionedRegion.java:2036)
> at
> org.apache.geode.internal.cache.LocalRegionDataView.putEntry(LocalRegionDataView.java:151)
> at
> org.apache.geode.internal.cache.LocalRegion.basicPut(LocalRegion.java:5027)
> at
> org.apache.geode.internal.cache.LocalRegion.validatedPut(LocalRegion.java:1580)
> at
> org.apache.geode.internal.cache.LocalRegion.put(LocalRegion.java:1567)
> at
> org.apache.geode.internal.cache.AbstractRegion.put(AbstractRegion.java:325)
> at
> org.apache.geode.cache.lucene.LuceneIndexDestroyDUnitTest.doPutsUntilStopped(LuceneIndexDestroyDUnitTest.java:548)
> at
> org.apache.geode.cache.lucene.LuceneIndexDestroyDUnitTest.lambda$verifyDestroySingleIndexWhileDoingPuts$b814fe7d$1(LuceneIndexDestroyDUnitTest.java:157)
> Caused by:
> org.apache.geode.cache.RegionDestroyedException: Partitioned
> Region @43ee7285
> [path='/AsyncEventQueue_index#_region_PARALLEL_GATEWAY_SENDER_QUEUE';
> dataPolicy=PARTITION; prId=240; isDestroyed=true; isClosed=false;
> retryTimeout=360; serialNumber=4216; partition
> attributes=PartitionAttributes@1047578025[redundantCopies=1;localMaxMemory=1000;totalMaxMemory=2147483647;totalNumBuckets=10;partitionResolver=null;colocatedWith=/region;recoveryDelay=-1;startupRecoveryDelay=0;FixedPartitionAttributes=null;partitionListeners=null];
> on
[jira] [Resolved] (GEODE-3165) Re-organize sources to make integration with IDE that support CMake easier.
[ https://issues.apache.org/jira/browse/GEODE-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacob S. Barrett resolved GEODE-3165. - Resolution: Fixed > Re-organize sources to make integration with IDE that support CMake easier. > --- > > Key: GEODE-3165 > URL: https://issues.apache.org/jira/browse/GEODE-3165 > Project: Geode > Issue Type: Task > Components: docs, native client >Reporter: Jacob S. Barrett >Assignee: Jacob S. Barrett > > Many of the IDE's that support CMake expect that CMakeList.txt be in the root > of the project. I propose moving the contents of src/ to the root, which was > the intent after cleaning out all the legacy cruft in root. > /src/docs -> /docs/api > /src/* -> /root/* > Since this a pretty straight forward move there should not be issues with > merging changes between older branches and develop after this move. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-3435) Fix serialization test failure for ParallelSnapshotFileMapper
[ https://issues.apache.org/jira/browse/GEODE-3435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124334#comment-16124334 ] ASF GitHub Bot commented on GEODE-3435: --- GitHub user nreich opened a pull request: https://github.com/apache/geode/pull/710 GEODE-3435: Fix serialization test failure This pull request it to fix an issue introduced in GEODE-3300 that caused AnalyzeSerializablesJUnitTest to fail. You can merge this pull request into a Git repository by running: $ git pull https://github.com/nreich/geode bug/GEODE-3435 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/710.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #710 commit d70be239bb94c4b8d610367b98deeafc9b224345 Author: Nick Reich Date: 2017-08-12T00:18:40Z GEODE-3435: Fix serialization test failure > Fix serialization test failure for ParallelSnapshotFileMapper > - > > Key: GEODE-3435 > URL: https://issues.apache.org/jira/browse/GEODE-3435 > Project: Geode > Issue Type: Bug >Reporter: Nick Reich >Assignee: Nick Reich > Fix For: 1.3.0 > > > ParallelSnapshotFileMapper was not correctly added to > sanctionedSerializables.txt -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (GEODE-3165) Re-organize sources to make integration with IDE that support CMake easier.
[ https://issues.apache.org/jira/browse/GEODE-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacob S. Barrett closed GEODE-3165. --- > Re-organize sources to make integration with IDE that support CMake easier. > --- > > Key: GEODE-3165 > URL: https://issues.apache.org/jira/browse/GEODE-3165 > Project: Geode > Issue Type: Task > Components: docs, native client >Reporter: Jacob S. Barrett >Assignee: Jacob S. Barrett > > Many of the IDE's that support CMake expect that CMakeList.txt be in the root > of the project. I propose moving the contents of src/ to the root, which was > the intent after cleaning out all the legacy cruft in root. > /src/docs -> /docs/api > /src/* -> /root/* > Since this a pretty straight forward move there should not be issues with > merging changes between older branches and develop after this move. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-3395) Variable-ize product version and name in user guide
[
https://issues.apache.org/jira/browse/GEODE-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124316#comment-16124316
]
ASF subversion and git services commented on GEODE-3395:
Commit 0e6bf546e0e3282b53d90bce4dbe1c0c1be1fa02 in geode's branch
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=0e6bf54 ]
GEODE-3395 Variable-ize product version and name in user guide - Getting Started
> Variable-ize product version and name in user guide
>
>
> Key: GEODE-3395
> URL: https://issues.apache.org/jira/browse/GEODE-3395
> Project: Geode
> Issue Type: New Feature
> Components: docs
>Reporter: Dave Barnes
>Assignee: Dave Barnes
>
> The Guide contains many occurrences of the product version string ("1.2",
> "1.1", and "1.0-incubating" are recent examples) scattered over about 900
> files. It would be a great convenience to those who write and edit these
> files to define the version number symbolically so it could be updated in one
> central location. A template variable in the book's config.yml file would be
> an obvious candidate for the implementation.
> Similarly, it would be handy to provide symbolic identifiers for the product
> name, long and short: "Apache Geode" and "Geode", respectively.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Closed] (GEODE-2739) Identify all globals we want to refactor
[ https://issues.apache.org/jira/browse/GEODE-2739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacob S. Barrett closed GEODE-2739. --- > Identify all globals we want to refactor > > > Key: GEODE-2739 > URL: https://issues.apache.org/jira/browse/GEODE-2739 > Project: Geode > Issue Type: Sub-task > Components: native client >Reporter: Addison > > Create a list of all global singletons. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (GEODE-2740) Refactor cache factory and immediate relationships
[ https://issues.apache.org/jira/browse/GEODE-2740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacob S. Barrett resolved GEODE-2740. - Resolution: Fixed > Refactor cache factory and immediate relationships > -- > > Key: GEODE-2740 > URL: https://issues.apache.org/jira/browse/GEODE-2740 > Project: Geode > Issue Type: Sub-task > Components: native client >Reporter: Addison > > Definition of Done > All existing tests should still pass when refactor is done. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (GEODE-2740) Refactor cache factory and immediate relationships
[ https://issues.apache.org/jira/browse/GEODE-2740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacob S. Barrett closed GEODE-2740. --- > Refactor cache factory and immediate relationships > -- > > Key: GEODE-2740 > URL: https://issues.apache.org/jira/browse/GEODE-2740 > Project: Geode > Issue Type: Sub-task > Components: native client >Reporter: Addison > > Definition of Done > All existing tests should still pass when refactor is done. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-3165) Re-organize sources to make integration with IDE that support CMake easier.
[ https://issues.apache.org/jira/browse/GEODE-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124301#comment-16124301 ] ASF GitHub Bot commented on GEODE-3165: --- Github user asfgit closed the pull request at: https://github.com/apache/geode-native/pull/115 > Re-organize sources to make integration with IDE that support CMake easier. > --- > > Key: GEODE-3165 > URL: https://issues.apache.org/jira/browse/GEODE-3165 > Project: Geode > Issue Type: Task > Components: docs, native client >Reporter: Jacob S. Barrett >Assignee: Jacob S. Barrett > > Many of the IDE's that support CMake expect that CMakeList.txt be in the root > of the project. I propose moving the contents of src/ to the root, which was > the intent after cleaning out all the legacy cruft in root. > /src/docs -> /docs/api > /src/* -> /root/* > Since this a pretty straight forward move there should not be issues with > merging changes between older branches and develop after this move. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-3165) Re-organize sources to make integration with IDE that support CMake easier.
[ https://issues.apache.org/jira/browse/GEODE-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124300#comment-16124300 ] ASF subversion and git services commented on GEODE-3165: Commit 44635ffa95926c9cffecc1dcaac02fb3012d1eef in geode-native's branch refs/heads/develop from Jacob Barrett [ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=44635ff ] GEODE-3165: Fixes Travis CI to build from new source root. > Re-organize sources to make integration with IDE that support CMake easier. > --- > > Key: GEODE-3165 > URL: https://issues.apache.org/jira/browse/GEODE-3165 > Project: Geode > Issue Type: Task > Components: docs, native client >Reporter: Jacob S. Barrett >Assignee: Jacob S. Barrett > > Many of the IDE's that support CMake expect that CMakeList.txt be in the root > of the project. I propose moving the contents of src/ to the root, which was > the intent after cleaning out all the legacy cruft in root. > /src/docs -> /docs/api > /src/* -> /root/* > Since this a pretty straight forward move there should not be issues with > merging changes between older branches and develop after this move. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (GEODE-3435) Fix serialization test failure for ParallelSnapshotFileMapper
[ https://issues.apache.org/jira/browse/GEODE-3435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Reich reassigned GEODE-3435: - Assignee: Nick Reich > Fix serialization test failure for ParallelSnapshotFileMapper > - > > Key: GEODE-3435 > URL: https://issues.apache.org/jira/browse/GEODE-3435 > Project: Geode > Issue Type: Bug >Reporter: Nick Reich >Assignee: Nick Reich > Fix For: 1.3.0 > > > ParallelSnapshotFileMapper was not correctly added to > sanctionedSerializables.txt -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (GEODE-3435) Fix serialization test failure for ParallelSnapshotFileMapper
Nick Reich created GEODE-3435: - Summary: Fix serialization test failure for ParallelSnapshotFileMapper Key: GEODE-3435 URL: https://issues.apache.org/jira/browse/GEODE-3435 Project: Geode Issue Type: Bug Reporter: Nick Reich Fix For: 1.3.0 ParallelSnapshotFileMapper was not correctly added to sanctionedSerializables.txt -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-3427) CI failure in GMSJoinLeaveJUnitTest.testCoordinatorFindRequestSuccess
[ https://issues.apache.org/jira/browse/GEODE-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124264#comment-16124264 ] ASF subversion and git services commented on GEODE-3427: Commit 915568415f0cc642d2bdc364e927ac1c88a2b53f in geode's branch refs/heads/develop from [~bschuchardt] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=9155684 ] GEODE-3427: CI failure in GMSJoinLeaveJUnitTest.testCoordinatorFindRequestSuccess I put this test in the FlakyTest category > CI failure in GMSJoinLeaveJUnitTest.testCoordinatorFindRequestSuccess > - > > Key: GEODE-3427 > URL: https://issues.apache.org/jira/browse/GEODE-3427 > Project: Geode > Issue Type: Bug > Components: membership >Reporter: Bruce Schuchardt > Labels: ci, flaky > > This failed in 7352fcc7e485984b57d72373b468440d09556b5a > org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeaveJUnitTest > > testCoordinatorFindRequestSuccess FAILED > java.lang.AssertionError: Should be able to join > at org.junit.Assert.fail(Assert.java:88) > at org.junit.Assert.assertTrue(Assert.java:41) > at > org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeaveJUnitTest.testCoordinatorFindRequestSuccess(GMSJoinLeaveJUnitTest.java:1243) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-3269) Refactor ShellCommands
[
https://issues.apache.org/jira/browse/GEODE-3269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124253#comment-16124253
]
ASF GitHub Bot commented on GEODE-3269:
---
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/709
GEODE-3269: Refactoring ShellCommands
[View the JIRA ticket
here.](https://issues.apache.org/jira/browse/GEODE-3269)
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [x] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes? (See
[GEODE-1359](https://issues.apache.org/jira/browse/GEODE-1359))
**Testing progress: Precheckin in progress! See eyeh-geode-3269 because I
probably won't be able to**
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/YehEmily/geode GEODE-3269
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/709.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #709
commit 8a06b768b6e928ab3df6ec1ec4c6460141992bec
Author: YehEmily
Date: 2017-08-11T23:17:42Z
GEODE-3269: Refactoring ShellCommands
> Refactor ShellCommands
> --
>
> Key: GEODE-3269
> URL: https://issues.apache.org/jira/browse/GEODE-3269
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{ShellCommands.java}} is a large class that contains multiple commands. Each
> command should be refactored into a separate class, and the methods shared by
> the commands should be refactored into a new and appropriately named class of
> their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (GEODE-3259) Refactor DurableClientCommands
[
https://issues.apache.org/jira/browse/GEODE-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Emily Yeh resolved GEODE-3259.
--
Resolution: Fixed
> Refactor DurableClientCommands
> --
>
> Key: GEODE-3259
> URL: https://issues.apache.org/jira/browse/GEODE-3259
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{DurableClientCommands.java}} is a large class that contains multiple
> commands. Each command should be refactored into a separate class, and the
> methods shared by the commands should be refactored into a new and
> appropriately named class of their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (GEODE-3264) Refactor MemberCommands
[
https://issues.apache.org/jira/browse/GEODE-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Emily Yeh resolved GEODE-3264.
--
Resolution: Fixed
> Refactor MemberCommands
> ---
>
> Key: GEODE-3264
> URL: https://issues.apache.org/jira/browse/GEODE-3264
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{MemberCommands.java}} is a large class that contains multiple commands.
> Each command should be refactored into a separate class, and the methods
> shared by the commands should be refactored into a new and appropriately
> named class of their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (GEODE-3254) Refactor ConfigCommands
[
https://issues.apache.org/jira/browse/GEODE-3254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Emily Yeh resolved GEODE-3254.
--
Resolution: Fixed
> Refactor ConfigCommands
> ---
>
> Key: GEODE-3254
> URL: https://issues.apache.org/jira/browse/GEODE-3254
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{ConfigCommands.java}} is a large class that contains multiple commands.
> Each command should be refactored into a separate class, and the methods
> shared by the commands should be refactored into a new and appropriately
> named class of their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Assigned] (GEODE-3269) Refactor ShellCommands
[
https://issues.apache.org/jira/browse/GEODE-3269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Emily Yeh reassigned GEODE-3269:
Assignee: Emily Yeh
> Refactor ShellCommands
> --
>
> Key: GEODE-3269
> URL: https://issues.apache.org/jira/browse/GEODE-3269
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{ShellCommands.java}} is a large class that contains multiple commands. Each
> command should be refactored into a separate class, and the methods shared by
> the commands should be refactored into a new and appropriately named class of
> their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (GEODE-3254) Refactor ConfigCommands
[
https://issues.apache.org/jira/browse/GEODE-3254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124239#comment-16124239
]
ASF subversion and git services commented on GEODE-3254:
Commit 97c4e9a59f17c7bc914e39dd048b0a4cd96293c4 in geode's branch
refs/heads/develop from YehEmily
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=97c4e9a ]
GEODE-3254: Refactoring ConfigCommands
This closes #665
> Refactor ConfigCommands
> ---
>
> Key: GEODE-3254
> URL: https://issues.apache.org/jira/browse/GEODE-3254
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{ConfigCommands.java}} is a large class that contains multiple commands.
> Each command should be refactored into a separate class, and the methods
> shared by the commands should be refactored into a new and appropriately
> named class of their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (GEODE-3264) Refactor MemberCommands
[
https://issues.apache.org/jira/browse/GEODE-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124244#comment-16124244
]
ASF GitHub Bot commented on GEODE-3264:
---
Github user asfgit closed the pull request at:
https://github.com/apache/geode/pull/692
> Refactor MemberCommands
> ---
>
> Key: GEODE-3264
> URL: https://issues.apache.org/jira/browse/GEODE-3264
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{MemberCommands.java}} is a large class that contains multiple commands.
> Each command should be refactored into a separate class, and the methods
> shared by the commands should be refactored into a new and appropriately
> named class of their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (GEODE-3264) Refactor MemberCommands
[
https://issues.apache.org/jira/browse/GEODE-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124241#comment-16124241
]
ASF subversion and git services commented on GEODE-3264:
Commit d27f8b956de7d9c5d95ebdc68dfc67ee8b2d7b51 in geode's branch
refs/heads/develop from YehEmily
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=d27f8b9 ]
GEODE-3264: Refactoring MemberCommands
This closes #692
> Refactor MemberCommands
> ---
>
> Key: GEODE-3264
> URL: https://issues.apache.org/jira/browse/GEODE-3264
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{MemberCommands.java}} is a large class that contains multiple commands.
> Each command should be refactored into a separate class, and the methods
> shared by the commands should be refactored into a new and appropriately
> named class of their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (GEODE-3254) Refactor ConfigCommands
[
https://issues.apache.org/jira/browse/GEODE-3254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124242#comment-16124242
]
ASF GitHub Bot commented on GEODE-3254:
---
Github user asfgit closed the pull request at:
https://github.com/apache/geode/pull/665
> Refactor ConfigCommands
> ---
>
> Key: GEODE-3254
> URL: https://issues.apache.org/jira/browse/GEODE-3254
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{ConfigCommands.java}} is a large class that contains multiple commands.
> Each command should be refactored into a separate class, and the methods
> shared by the commands should be refactored into a new and appropriately
> named class of their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (GEODE-3259) Refactor DurableClientCommands
[
https://issues.apache.org/jira/browse/GEODE-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124243#comment-16124243
]
ASF GitHub Bot commented on GEODE-3259:
---
Github user asfgit closed the pull request at:
https://github.com/apache/geode/pull/689
> Refactor DurableClientCommands
> --
>
> Key: GEODE-3259
> URL: https://issues.apache.org/jira/browse/GEODE-3259
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{DurableClientCommands.java}} is a large class that contains multiple
> commands. Each command should be refactored into a separate class, and the
> methods shared by the commands should be refactored into a new and
> appropriately named class of their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (GEODE-3259) Refactor DurableClientCommands
[
https://issues.apache.org/jira/browse/GEODE-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124240#comment-16124240
]
ASF subversion and git services commented on GEODE-3259:
Commit 440c87f81fab96f9ce38a2d53ded75e5fe8390d7 in geode's branch
refs/heads/develop from YehEmily
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=440c87f ]
GEODE-3259: Refactoring DurableClientCommands
This closes #689
> Refactor DurableClientCommands
> --
>
> Key: GEODE-3259
> URL: https://issues.apache.org/jira/browse/GEODE-3259
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{DurableClientCommands.java}} is a large class that contains multiple
> commands. Each command should be refactored into a separate class, and the
> methods shared by the commands should be refactored into a new and
> appropriately named class of their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (GEODE-3259) Refactor DurableClientCommands
[
https://issues.apache.org/jira/browse/GEODE-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Emily Yeh resolved GEODE-3259.
--
Resolution: Fixed
> Refactor DurableClientCommands
> --
>
> Key: GEODE-3259
> URL: https://issues.apache.org/jira/browse/GEODE-3259
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{DurableClientCommands.java}} is a large class that contains multiple
> commands. Each command should be refactored into a separate class, and the
> methods shared by the commands should be refactored into a new and
> appropriately named class of their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (GEODE-3403) Modify rolling upgrade test configuration for 1.2.x release
[ https://issues.apache.org/jira/browse/GEODE-3403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruce Schuchardt resolved GEODE-3403. - Resolution: Fixed Fix Version/s: 1.3.0 > Modify rolling upgrade test configuration for 1.2.x release > --- > > Key: GEODE-3403 > URL: https://issues.apache.org/jira/browse/GEODE-3403 > Project: Geode > Issue Type: Task > Components: client/server >Reporter: Brian Baynes >Assignee: Bruce Schuchardt > Fix For: 1.3.0 > > > Modify rolling upgrade test configuration for 1.2.x release. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Reopened] (GEODE-3259) Refactor DurableClientCommands
[
https://issues.apache.org/jira/browse/GEODE-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Emily Yeh reopened GEODE-3259:
--
> Refactor DurableClientCommands
> --
>
> Key: GEODE-3259
> URL: https://issues.apache.org/jira/browse/GEODE-3259
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{DurableClientCommands.java}} is a large class that contains multiple
> commands. Each command should be refactored into a separate class, and the
> methods shared by the commands should be refactored into a new and
> appropriately named class of their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (GEODE-3434) Allow the modules to be interoperable with current and older versions of tomcat 7
[ https://issues.apache.org/jira/browse/GEODE-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Huynh updated GEODE-3434: --- Summary: Allow the modules to be interoperable with current and older versions of tomcat 7 (was: Allow the modules to be interoperable with new tomcat 7 and older versions) > Allow the modules to be interoperable with current and older versions of > tomcat 7 > -- > > Key: GEODE-3434 > URL: https://issues.apache.org/jira/browse/GEODE-3434 > Project: Geode > Issue Type: Bug > Components: http session >Reporter: Jason Huynh >Assignee: Jason Huynh > > There was a change to the attribute field in tomcat (and we made the > necessary changes in geode session modules), but that does not allow our > session modules to work with older versions of tomcat 7. We can probably > modify the classes to allow use with of the session module jars across > different versions of tomcat 7. > We should probably add tests that run against older versions of geode to > allow backwards compatibility between a geode server and a session module jar > from a previous release. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (GEODE-3434) Allow the modules to be interoperable with new tomcat 7 and older versions
Jason Huynh created GEODE-3434: -- Summary: Allow the modules to be interoperable with new tomcat 7 and older versions Key: GEODE-3434 URL: https://issues.apache.org/jira/browse/GEODE-3434 Project: Geode Issue Type: Bug Components: http session Reporter: Jason Huynh There was a change to the attribute field in tomcat (and we made the necessary changes in geode session modules), but that does not allow our session modules to work with older versions of tomcat 7. We can probably modify the classes to allow use with of the session module jars across different versions of tomcat 7. We should probably add tests that run against older versions of geode to allow backwards compatibility between a geode server and a session module jar from a previous release. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (GEODE-3434) Allow the modules to be interoperable with new tomcat 7 and older versions
[ https://issues.apache.org/jira/browse/GEODE-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Huynh reassigned GEODE-3434: -- Assignee: Jason Huynh > Allow the modules to be interoperable with new tomcat 7 and older versions > -- > > Key: GEODE-3434 > URL: https://issues.apache.org/jira/browse/GEODE-3434 > Project: Geode > Issue Type: Bug > Components: http session >Reporter: Jason Huynh >Assignee: Jason Huynh > > There was a change to the attribute field in tomcat (and we made the > necessary changes in geode session modules), but that does not allow our > session modules to work with older versions of tomcat 7. We can probably > modify the classes to allow use with of the session module jars across > different versions of tomcat 7. > We should probably add tests that run against older versions of geode to > allow backwards compatibility between a geode server and a session module jar > from a previous release. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-3403) Modify rolling upgrade test configuration for 1.2.x release
[ https://issues.apache.org/jira/browse/GEODE-3403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124232#comment-16124232 ] ASF subversion and git services commented on GEODE-3403: Commit bdc8de00f1c423aaa27fbb24b16c39e88ad537e0 in geode's branch refs/heads/develop from [~bschuchardt] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=bdc8de0 ] GEODE-3403: Modify rolling upgrade test configurations for 1.2.x release Naba has already added a test120 source set in geode-old-versions. This commit bumps the version of Geode to 1.3.0 so that tests can tell the difference between 1.2.0 and builds based on this commit. > Modify rolling upgrade test configuration for 1.2.x release > --- > > Key: GEODE-3403 > URL: https://issues.apache.org/jira/browse/GEODE-3403 > Project: Geode > Issue Type: Task > Components: client/server >Reporter: Brian Baynes >Assignee: Bruce Schuchardt > > Modify rolling upgrade test configuration for 1.2.x release. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (GEODE-3262) Refactor IndexCommands
[
https://issues.apache.org/jira/browse/GEODE-3262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Emily Yeh resolved GEODE-3262.
--
Resolution: Fixed
> Refactor IndexCommands
> --
>
> Key: GEODE-3262
> URL: https://issues.apache.org/jira/browse/GEODE-3262
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{IndexCommands.java}} is a large class that contains multiple commands. Each
> command should be refactored into a separate class, and the methods shared by
> the commands should be refactored into a new and appropriately named class of
> their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (GEODE-3262) Refactor IndexCommands
[
https://issues.apache.org/jira/browse/GEODE-3262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124230#comment-16124230
]
ASF GitHub Bot commented on GEODE-3262:
---
Github user asfgit closed the pull request at:
https://github.com/apache/geode/pull/690
> Refactor IndexCommands
> --
>
> Key: GEODE-3262
> URL: https://issues.apache.org/jira/browse/GEODE-3262
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{IndexCommands.java}} is a large class that contains multiple commands. Each
> command should be refactored into a separate class, and the methods shared by
> the commands should be refactored into a new and appropriately named class of
> their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (GEODE-3262) Refactor IndexCommands
[
https://issues.apache.org/jira/browse/GEODE-3262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124229#comment-16124229
]
ASF subversion and git services commented on GEODE-3262:
Commit ed293e817e547fb5ecd399bf4ba10d694af51e0a in geode's branch
refs/heads/develop from YehEmily
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=ed293e8 ]
GEODE-3262: Refactoring IndexCommands
This closes #690
> Refactor IndexCommands
> --
>
> Key: GEODE-3262
> URL: https://issues.apache.org/jira/browse/GEODE-3262
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{IndexCommands.java}} is a large class that contains multiple commands. Each
> command should be refactored into a separate class, and the methods shared by
> the commands should be refactored into a new and appropriately named class of
> their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (GEODE-3260) Refactor FunctionCommands
[
https://issues.apache.org/jira/browse/GEODE-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Emily Yeh resolved GEODE-3260.
--
Resolution: Fixed
> Refactor FunctionCommands
> -
>
> Key: GEODE-3260
> URL: https://issues.apache.org/jira/browse/GEODE-3260
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{FunctionCommands.java}} is a large class that contains multiple commands.
> Each command should be refactored into a separate class, and the methods
> shared by the commands should be refactored into a new and appropriately
> named class of their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (GEODE-3260) Refactor FunctionCommands
[
https://issues.apache.org/jira/browse/GEODE-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124227#comment-16124227
]
ASF GitHub Bot commented on GEODE-3260:
---
Github user asfgit closed the pull request at:
https://github.com/apache/geode/pull/691
> Refactor FunctionCommands
> -
>
> Key: GEODE-3260
> URL: https://issues.apache.org/jira/browse/GEODE-3260
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{FunctionCommands.java}} is a large class that contains multiple commands.
> Each command should be refactored into a separate class, and the methods
> shared by the commands should be refactored into a new and appropriately
> named class of their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (GEODE-3260) Refactor FunctionCommands
[
https://issues.apache.org/jira/browse/GEODE-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124226#comment-16124226
]
ASF subversion and git services commented on GEODE-3260:
Commit 90f5440de8ec747f301a309a0a34101e8defcd29 in geode's branch
refs/heads/develop from YehEmily
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=90f5440 ]
GEODE-3260: Refactoring FunctionCommands
This closes #691
> Refactor FunctionCommands
> -
>
> Key: GEODE-3260
> URL: https://issues.apache.org/jira/browse/GEODE-3260
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{FunctionCommands.java}} is a large class that contains multiple commands.
> Each command should be refactored into a separate class, and the methods
> shared by the commands should be refactored into a new and appropriately
> named class of their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (GEODE-3249) Validate internal client/server messages
[ https://issues.apache.org/jira/browse/GEODE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124225#comment-16124225 ] Bruce Schuchardt commented on GEODE-3249: - with the latest changes the test ClientAuthorizationTwoDUnitTest.testAllOpsWithFailover2 is failing. Precheckin is otherwise green. > Validate internal client/server messages > > > Key: GEODE-3249 > URL: https://issues.apache.org/jira/browse/GEODE-3249 > Project: Geode > Issue Type: Bug > Components: messaging >Reporter: Anthony Baker >Assignee: Bruce Schuchardt > Fix For: 1.2.1 > > > Some message types can not be invoked directly by an end user. For > validation purposes, we should treat these messages the same way we treat > normal messages. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (GEODE-3258) Refactor DiskStoreCommands
[
https://issues.apache.org/jira/browse/GEODE-3258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Emily Yeh resolved GEODE-3258.
--
Resolution: Fixed
> Refactor DiskStoreCommands
> --
>
> Key: GEODE-3258
> URL: https://issues.apache.org/jira/browse/GEODE-3258
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{DiskStoreCommands.java}} is a large class that contains multiple commands.
> Each command should be refactored into a separate class, and the methods
> shared by the commands should be refactored into a new and appropriately
> named class of their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (GEODE-3258) Refactor DiskStoreCommands
[
https://issues.apache.org/jira/browse/GEODE-3258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124213#comment-16124213
]
ASF GitHub Bot commented on GEODE-3258:
---
Github user asfgit closed the pull request at:
https://github.com/apache/geode/pull/687
> Refactor DiskStoreCommands
> --
>
> Key: GEODE-3258
> URL: https://issues.apache.org/jira/browse/GEODE-3258
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{DiskStoreCommands.java}} is a large class that contains multiple commands.
> Each command should be refactored into a separate class, and the methods
> shared by the commands should be refactored into a new and appropriately
> named class of their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (GEODE-3258) Refactor DiskStoreCommands
[
https://issues.apache.org/jira/browse/GEODE-3258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124212#comment-16124212
]
ASF subversion and git services commented on GEODE-3258:
Commit 5d6cad7755ec3c4fe931e3d0f8e89fb181038543 in geode's branch
refs/heads/develop from YehEmily
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=5d6cad7 ]
GEODE-3258: Refactoring DiskStoreCommands
This closes #687
> Refactor DiskStoreCommands
> --
>
> Key: GEODE-3258
> URL: https://issues.apache.org/jira/browse/GEODE-3258
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{DiskStoreCommands.java}} is a large class that contains multiple commands.
> Each command should be refactored into a separate class, and the methods
> shared by the commands should be refactored into a new and appropriately
> named class of their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (GEODE-3330) secure ability to register CQ
[ https://issues.apache.org/jira/browse/GEODE-3330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emily Yeh resolved GEODE-3330. -- Resolution: Fixed > secure ability to register CQ > - > > Key: GEODE-3330 > URL: https://issues.apache.org/jira/browse/GEODE-3330 > Project: Geode > Issue Type: Sub-task > Components: docs, security >Reporter: Swapnil Bawaskar > > With integrated security, we require that for registering a CQ user must have > CLUSTER:MANAGE:QUERY permissions. This however, means that a user with > CLUSTER:MANAGE will be able to register a CQ with initial results and be able > to see data. > In order to register a CQ with initial results, we should require that the > user has DATA:READ permission. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (GEODE-3362) Refactor CreateGatewayReceiverCommandDUnitTest to use test rules
[
https://issues.apache.org/jira/browse/GEODE-3362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Emily Yeh reassigned GEODE-3362:
Assignee: (was: Emily Yeh)
> Refactor CreateGatewayReceiverCommandDUnitTest to use test rules
>
>
> Key: GEODE-3362
> URL: https://issues.apache.org/jira/browse/GEODE-3362
> Project: Geode
> Issue Type: Sub-task
> Components: tests
>Reporter: Emily Yeh
>
> {{CreateGatewayReceiverCommandDUnitTest}} is using {{CliCommandTestBase}},
> which is a deprecated class. It should be refactored to use more current test
> rules.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (GEODE-2936) Refactor OrderByComparator's compare method to reduce redundant code
[ https://issues.apache.org/jira/browse/GEODE-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emily Yeh resolved GEODE-2936. -- Resolution: Fixed > Refactor OrderByComparator's compare method to reduce redundant code > > > Key: GEODE-2936 > URL: https://issues.apache.org/jira/browse/GEODE-2936 > Project: Geode > Issue Type: Bug > Components: querying >Reporter: nabarun >Assignee: Emily Yeh > > Issue: > OrderByComparator's compare method has a lot of redundant code. > Solution: > These code sections can be modified to have one method call -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (GEODE-3337) Refactor LauncherLifecycleCommandsDUnitTest to use test rules
[
https://issues.apache.org/jira/browse/GEODE-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Emily Yeh resolved GEODE-3337.
--
Resolution: Fixed
> Refactor LauncherLifecycleCommandsDUnitTest to use test rules
> -
>
> Key: GEODE-3337
> URL: https://issues.apache.org/jira/browse/GEODE-3337
> Project: Geode
> Issue Type: Sub-task
> Components: tests
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{LauncherLifecycleCommandsDUnitTest}} is using {{CliCommandTestBase}}, which
> is a deprecated class. It should be refactored to use more current test rules.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (GEODE-3337) Refactor LauncherLifecycleCommandsDUnitTest to use test rules
[
https://issues.apache.org/jira/browse/GEODE-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124197#comment-16124197
]
ASF GitHub Bot commented on GEODE-3337:
---
Github user asfgit closed the pull request at:
https://github.com/apache/geode/pull/701
> Refactor LauncherLifecycleCommandsDUnitTest to use test rules
> -
>
> Key: GEODE-3337
> URL: https://issues.apache.org/jira/browse/GEODE-3337
> Project: Geode
> Issue Type: Sub-task
> Components: tests
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{LauncherLifecycleCommandsDUnitTest}} is using {{CliCommandTestBase}}, which
> is a deprecated class. It should be refactored to use more current test rules.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (GEODE-3337) Refactor LauncherLifecycleCommandsDUnitTest to use test rules
[
https://issues.apache.org/jira/browse/GEODE-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124196#comment-16124196
]
ASF subversion and git services commented on GEODE-3337:
Commit 210ff9f15460c993f2bf7fd682d50ee65462cd23 in geode's branch
refs/heads/develop from YehEmily
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=210ff9f ]
GEODE-3337: Refactoring LauncherLifecycleCommandsDUnitTest
This closes #701
> Refactor LauncherLifecycleCommandsDUnitTest to use test rules
> -
>
> Key: GEODE-3337
> URL: https://issues.apache.org/jira/browse/GEODE-3337
> Project: Geode
> Issue Type: Sub-task
> Components: tests
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{LauncherLifecycleCommandsDUnitTest}} is using {{CliCommandTestBase}}, which
> is a deprecated class. It should be refactored to use more current test rules.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (GEODE-3265) Refactor MiscellaneousCommands
[
https://issues.apache.org/jira/browse/GEODE-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Emily Yeh resolved GEODE-3265.
--
Resolution: Fixed
> Refactor MiscellaneousCommands
> --
>
> Key: GEODE-3265
> URL: https://issues.apache.org/jira/browse/GEODE-3265
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{MiscellaneousCommands.java}} is a large class that contains multiple
> commands. Each command should be refactored into a separate class, and the
> methods shared by the commands should be refactored into a new and
> appropriately named class of their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (GEODE-3265) Refactor MiscellaneousCommands
[
https://issues.apache.org/jira/browse/GEODE-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124174#comment-16124174
]
ASF GitHub Bot commented on GEODE-3265:
---
Github user asfgit closed the pull request at:
https://github.com/apache/geode/pull/696
> Refactor MiscellaneousCommands
> --
>
> Key: GEODE-3265
> URL: https://issues.apache.org/jira/browse/GEODE-3265
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{MiscellaneousCommands.java}} is a large class that contains multiple
> commands. Each command should be refactored into a separate class, and the
> methods shared by the commands should be refactored into a new and
> appropriately named class of their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (GEODE-3265) Refactor MiscellaneousCommands
[
https://issues.apache.org/jira/browse/GEODE-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124171#comment-16124171
]
ASF subversion and git services commented on GEODE-3265:
Commit 63169699e933f6e0fdd90b95ed039e4e3c92c32c in geode's branch
refs/heads/develop from YehEmily
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=6316969 ]
GEODE-3265: Refactoring MiscellaneousCommands
This closes #696
> Refactor MiscellaneousCommands
> --
>
> Key: GEODE-3265
> URL: https://issues.apache.org/jira/browse/GEODE-3265
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{MiscellaneousCommands.java}} is a large class that contains multiple
> commands. Each command should be refactored into a separate class, and the
> methods shared by the commands should be refactored into a new and
> appropriately named class of their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (GEODE-3433) LuceneEventListener should restore the original pdx serialization flag
Jason Huynh created GEODE-3433:
--
Summary: LuceneEventListener should restore the original pdx
serialization flag
Key: GEODE-3433
URL: https://issues.apache.org/jira/browse/GEODE-3433
Project: Geode
Issue Type: Bug
Components: lucene
Reporter: Jason Huynh
Currently the LuceneEventListener is setting:
{noformat}
DefaultQuery.setPdxReadSerialized(true);
{noformat}
And at the end of processing, it will set it back to false.
{noformat}
finally {
DefaultQuery.setPdxReadSerialized(false);
}
{noformat}
Instead we should probably store the original setting and restore the original
instead of overriding it back to false every time.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Assigned] (GEODE-3330) secure ability to register CQ
[ https://issues.apache.org/jira/browse/GEODE-3330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emily Yeh reassigned GEODE-3330: Assignee: (was: Emily Yeh) > secure ability to register CQ > - > > Key: GEODE-3330 > URL: https://issues.apache.org/jira/browse/GEODE-3330 > Project: Geode > Issue Type: Sub-task > Components: docs, security >Reporter: Swapnil Bawaskar > > With integrated security, we require that for registering a CQ user must have > CLUSTER:MANAGE:QUERY permissions. This however, means that a user with > CLUSTER:MANAGE will be able to register a CQ with initial results and be able > to see data. > In order to register a CQ with initial results, we should require that the > user has DATA:READ permission. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (GEODE-3330) secure ability to register CQ
[ https://issues.apache.org/jira/browse/GEODE-3330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emily Yeh reassigned GEODE-3330: Assignee: Emily Yeh > secure ability to register CQ > - > > Key: GEODE-3330 > URL: https://issues.apache.org/jira/browse/GEODE-3330 > Project: Geode > Issue Type: Sub-task > Components: docs, security >Reporter: Swapnil Bawaskar >Assignee: Emily Yeh > > With integrated security, we require that for registering a CQ user must have > CLUSTER:MANAGE:QUERY permissions. This however, means that a user with > CLUSTER:MANAGE will be able to register a CQ with initial results and be able > to see data. > In order to register a CQ with initial results, we should require that the > user has DATA:READ permission. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (GEODE-3330) secure ability to register CQ
[ https://issues.apache.org/jira/browse/GEODE-3330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emily Yeh reassigned GEODE-3330: Assignee: (was: Emily Yeh) > secure ability to register CQ > - > > Key: GEODE-3330 > URL: https://issues.apache.org/jira/browse/GEODE-3330 > Project: Geode > Issue Type: Sub-task > Components: docs, security >Reporter: Swapnil Bawaskar > > With integrated security, we require that for registering a CQ user must have > CLUSTER:MANAGE:QUERY permissions. This however, means that a user with > CLUSTER:MANAGE will be able to register a CQ with initial results and be able > to see data. > In order to register a CQ with initial results, we should require that the > user has DATA:READ permission. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (GEODE-3230) Delete unused commands in CliStrings
[
https://issues.apache.org/jira/browse/GEODE-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Emily Yeh resolved GEODE-3230.
--
Resolution: Fixed
> Delete unused commands in CliStrings
>
>
> Key: GEODE-3230
> URL: https://issues.apache.org/jira/browse/GEODE-3230
> Project: Geode
> Issue Type: Improvement
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> There are a lot of commands in {{CliStrings}} that aren't used. For example,
> {{start manager}} has a whole set of associated commands -
> {{START_MANAGER__MEMBERNAME}}, {{START_MANAGER__DIR}},
> {{START_MANAGER__CLASSPATH}}, etc.) that don't seem to be used anywhere.
> These commands should be deleted to clean up the code.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (GEODE-3256) Refactor DataCommands
[
https://issues.apache.org/jira/browse/GEODE-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Emily Yeh resolved GEODE-3256.
--
Resolution: Fixed
> Refactor DataCommands
> -
>
> Key: GEODE-3256
> URL: https://issues.apache.org/jira/browse/GEODE-3256
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{DataCommands.java}} is a large class that contains multiple commands. Each
> command should be refactored into a separate class, and the methods shared by
> the commands should be refactored into a new and appropriately named class of
> their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (GEODE-3255) Refactor CreateAlterDestroyRegionCommands
[
https://issues.apache.org/jira/browse/GEODE-3255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Emily Yeh resolved GEODE-3255.
--
Resolution: Fixed
> Refactor CreateAlterDestroyRegionCommands
> -
>
> Key: GEODE-3255
> URL: https://issues.apache.org/jira/browse/GEODE-3255
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{CreateAlterDestroyRegionCommands.java}} is a large class that contains
> multiple commands. Each command should be refactored into a separate class,
> and the methods shared by the commands should be refactored into a new and
> appropriately named class of their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (GEODE-3257) Refactor DeployCommands
[
https://issues.apache.org/jira/browse/GEODE-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Emily Yeh resolved GEODE-3257.
--
Resolution: Fixed
> Refactor DeployCommands
> ---
>
> Key: GEODE-3257
> URL: https://issues.apache.org/jira/browse/GEODE-3257
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{DeployCommands.java}} is a large class that contains multiple commands.
> Each command should be refactored into a separate class, and the methods
> shared by the commands should be refactored into a new and appropriately
> named class of their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (GEODE-3268) Refactor RegionCommands
[
https://issues.apache.org/jira/browse/GEODE-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Emily Yeh resolved GEODE-3268.
--
Resolution: Fixed
> Refactor RegionCommands
> ---
>
> Key: GEODE-3268
> URL: https://issues.apache.org/jira/browse/GEODE-3268
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{RegionCommands.java}} is a large class that contains multiple commands.
> Each command should be refactored into a separate class, and the methods
> shared by the commands should be refactored into a new and appropriately
> named class of their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (GEODE-3266) Refactor PDXCommands
[
https://issues.apache.org/jira/browse/GEODE-3266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Emily Yeh resolved GEODE-3266.
--
Resolution: Fixed
> Refactor PDXCommands
>
>
> Key: GEODE-3266
> URL: https://issues.apache.org/jira/browse/GEODE-3266
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{PDXCommands.java}} is a large class that contains multiple commands. Each
> command should be refactored into a separate class, and the methods shared by
> the commands should be refactored into a new and appropriately named class of
> their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (GEODE-3267) Refactor QueueCommands
[
https://issues.apache.org/jira/browse/GEODE-3267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Emily Yeh resolved GEODE-3267.
--
Resolution: Fixed
> Refactor QueueCommands
> --
>
> Key: GEODE-3267
> URL: https://issues.apache.org/jira/browse/GEODE-3267
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{QueueCommands.java}} is a large class that contains multiple commands. Each
> command should be refactored into a separate class, and the methods shared by
> the commands should be refactored into a new and appropriately named class of
> their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (GEODE-3270) Refactor StatusCommands
[
https://issues.apache.org/jira/browse/GEODE-3270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Emily Yeh resolved GEODE-3270.
--
Resolution: Fixed
> Refactor StatusCommands
> ---
>
> Key: GEODE-3270
> URL: https://issues.apache.org/jira/browse/GEODE-3270
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{StatusCommands.java}} is class that already contains a single command, but
> a better-fitting name for the class is
> {{StatusClusterConfigServiceCommand.java}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (GEODE-3261) Refactor GfshHelpCommands
[
https://issues.apache.org/jira/browse/GEODE-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Emily Yeh resolved GEODE-3261.
--
Resolution: Fixed
> Refactor GfshHelpCommands
> -
>
> Key: GEODE-3261
> URL: https://issues.apache.org/jira/browse/GEODE-3261
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{GfshHelpCommands.java}} is a class that contains multiple commands. Each
> command should be refactored into a separate class, and the methods shared by
> the commands should be refactored into a new and appropriately named class of
> their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (GEODE-3261) Refactor GfshHelpCommands
[
https://issues.apache.org/jira/browse/GEODE-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124156#comment-16124156
]
ASF GitHub Bot commented on GEODE-3261:
---
Github user asfgit closed the pull request at:
https://github.com/apache/geode/pull/685
> Refactor GfshHelpCommands
> -
>
> Key: GEODE-3261
> URL: https://issues.apache.org/jira/browse/GEODE-3261
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{GfshHelpCommands.java}} is a class that contains multiple commands. Each
> command should be refactored into a separate class, and the methods shared by
> the commands should be refactored into a new and appropriately named class of
> their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (GEODE-3261) Refactor GfshHelpCommands
[
https://issues.apache.org/jira/browse/GEODE-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124155#comment-16124155
]
ASF subversion and git services commented on GEODE-3261:
Commit cf91426692349d0c81ce77394935576d9cc336e8 in geode's branch
refs/heads/develop from YehEmily
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=cf91426 ]
GEODE-3261: Refactoring GfshHelpCommands
This closes #685
> Refactor GfshHelpCommands
> -
>
> Key: GEODE-3261
> URL: https://issues.apache.org/jira/browse/GEODE-3261
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{GfshHelpCommands.java}} is a class that contains multiple commands. Each
> command should be refactored into a separate class, and the methods shared by
> the commands should be refactored into a new and appropriately named class of
> their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (GEODE-3267) Refactor QueueCommands
[
https://issues.apache.org/jira/browse/GEODE-3267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124136#comment-16124136
]
ASF GitHub Bot commented on GEODE-3267:
---
Github user asfgit closed the pull request at:
https://github.com/apache/geode/pull/695
> Refactor QueueCommands
> --
>
> Key: GEODE-3267
> URL: https://issues.apache.org/jira/browse/GEODE-3267
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{QueueCommands.java}} is a large class that contains multiple commands. Each
> command should be refactored into a separate class, and the methods shared by
> the commands should be refactored into a new and appropriately named class of
> their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (GEODE-3267) Refactor QueueCommands
[
https://issues.apache.org/jira/browse/GEODE-3267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124134#comment-16124134
]
ASF subversion and git services commented on GEODE-3267:
Commit fd47ed660168864a6f81b2a4cd7dbceebc99a282 in geode's branch
refs/heads/develop from YehEmily
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=fd47ed6 ]
GEODE-3267: Refactoring QueueCommands
This closes #695
> Refactor QueueCommands
> --
>
> Key: GEODE-3267
> URL: https://issues.apache.org/jira/browse/GEODE-3267
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{QueueCommands.java}} is a large class that contains multiple commands. Each
> command should be refactored into a separate class, and the methods shared by
> the commands should be refactored into a new and appropriately named class of
> their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (GEODE-3270) Refactor StatusCommands
[
https://issues.apache.org/jira/browse/GEODE-3270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124113#comment-16124113
]
ASF GitHub Bot commented on GEODE-3270:
---
Github user asfgit closed the pull request at:
https://github.com/apache/geode/pull/694
> Refactor StatusCommands
> ---
>
> Key: GEODE-3270
> URL: https://issues.apache.org/jira/browse/GEODE-3270
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{StatusCommands.java}} is class that already contains a single command, but
> a better-fitting name for the class is
> {{StatusClusterConfigServiceCommand.java}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (GEODE-3270) Refactor StatusCommands
[
https://issues.apache.org/jira/browse/GEODE-3270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124112#comment-16124112
]
ASF subversion and git services commented on GEODE-3270:
Commit 359e3fff6482ecfb375939d387f4dad3a636246b in geode's branch
refs/heads/develop from YehEmily
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=359e3ff ]
GEODE-3270: Refactoring (renaming) StatusCommands
This closes #694
> Refactor StatusCommands
> ---
>
> Key: GEODE-3270
> URL: https://issues.apache.org/jira/browse/GEODE-3270
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{StatusCommands.java}} is class that already contains a single command, but
> a better-fitting name for the class is
> {{StatusClusterConfigServiceCommand.java}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (GEODE-3268) Refactor RegionCommands
[
https://issues.apache.org/jira/browse/GEODE-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124084#comment-16124084
]
ASF GitHub Bot commented on GEODE-3268:
---
Github user asfgit closed the pull request at:
https://github.com/apache/geode/pull/693
> Refactor RegionCommands
> ---
>
> Key: GEODE-3268
> URL: https://issues.apache.org/jira/browse/GEODE-3268
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{RegionCommands.java}} is a large class that contains multiple commands.
> Each command should be refactored into a separate class, and the methods
> shared by the commands should be refactored into a new and appropriately
> named class of their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (GEODE-3267) Refactor QueueCommands
[
https://issues.apache.org/jira/browse/GEODE-3267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124083#comment-16124083
]
ASF subversion and git services commented on GEODE-3267:
Commit 957d583e54dc34c029885f32a54f0b25a3ac1094 in geode's branch
refs/heads/develop from YehEmily
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=957d583 ]
GEODE-3267: Refactoring QueueCommands - updated based on feedback
> Refactor QueueCommands
> --
>
> Key: GEODE-3267
> URL: https://issues.apache.org/jira/browse/GEODE-3267
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{QueueCommands.java}} is a large class that contains multiple commands. Each
> command should be refactored into a separate class, and the methods shared by
> the commands should be refactored into a new and appropriately named class of
> their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (GEODE-3268) Refactor RegionCommands
[
https://issues.apache.org/jira/browse/GEODE-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124082#comment-16124082
]
ASF subversion and git services commented on GEODE-3268:
Commit 64de3b69c2aecb4930bcfd0a1161569b1d5fda89 in geode's branch
refs/heads/develop from YehEmily
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=64de3b6 ]
GEODE-3268: Refactoring RegionCommands
This closes #693
> Refactor RegionCommands
> ---
>
> Key: GEODE-3268
> URL: https://issues.apache.org/jira/browse/GEODE-3268
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{RegionCommands.java}} is a large class that contains multiple commands.
> Each command should be refactored into a separate class, and the methods
> shared by the commands should be refactored into a new and appropriately
> named class of their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Assigned] (GEODE-3429) Deploy does not register Functions whose parent classes live in separate jar files
[
https://issues.apache.org/jira/browse/GEODE-3429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jared Stewart reassigned GEODE-3429:
Assignee: Jared Stewart
> Deploy does not register Functions whose parent classes live in separate jar
> files
> --
>
> Key: GEODE-3429
> URL: https://issues.apache.org/jira/browse/GEODE-3429
> Project: Geode
> Issue Type: Bug
> Components: gfsh, management
>Reporter: Jared Stewart
>Assignee: Jared Stewart
>
> Consider the following scenario:
> Abstract.jar - public abstract class AbstractFunction implements Function
> {...}
> Concrete.jar - public class ConcreteFunction extends AbstractFunction {...}
> When Concrete.jar is deployed, we are not registering ConcreteFunction.
> Everything works as expected if AbstractFunction and ConcreteFunction live in
> the same jar.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (GEODE-2729) Improve Native Client Stability by removing global variables
[ https://issues.apache.org/jira/browse/GEODE-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124046#comment-16124046 ] ASF GitHub Bot commented on GEODE-2729: --- Github user pivotal-jbarrett commented on the issue: https://github.com/apache/geode-native/pull/114 This was merged without auto-close comment. > Improve Native Client Stability by removing global variables > > > Key: GEODE-2729 > URL: https://issues.apache.org/jira/browse/GEODE-2729 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Addison > > *Context* > Today, the native client uses singleton global variables to manage things > like the cache. These prove troublesome when moving between managed and > unmanaged code. Another benefit of moving away from the globals is improved > unit testing. This will increase the overall testing feedback loop. > *Goal* > Remove these singletons in favor non-global constructors, destructors, etc. > Improved stability when calling functions that move between managed and > unmanaged code. > *Definition of Done* > Remove all integration tests in favor of well encapsulated unit tests. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-3266) Refactor PDXCommands
[
https://issues.apache.org/jira/browse/GEODE-3266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124028#comment-16124028
]
ASF GitHub Bot commented on GEODE-3266:
---
Github user asfgit closed the pull request at:
https://github.com/apache/geode/pull/684
> Refactor PDXCommands
>
>
> Key: GEODE-3266
> URL: https://issues.apache.org/jira/browse/GEODE-3266
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{PDXCommands.java}} is a large class that contains multiple commands. Each
> command should be refactored into a separate class, and the methods shared by
> the commands should be refactored into a new and appropriately named class of
> their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (GEODE-3266) Refactor PDXCommands
[
https://issues.apache.org/jira/browse/GEODE-3266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124026#comment-16124026
]
ASF subversion and git services commented on GEODE-3266:
Commit 67185abcdd68b908dea6888cb94286b8aa9ea49f in geode's branch
refs/heads/develop from YehEmily
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=67185ab ]
GEODE-3266: Refactoring PDXCommands
This closes #684
> Refactor PDXCommands
>
>
> Key: GEODE-3266
> URL: https://issues.apache.org/jira/browse/GEODE-3266
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{PDXCommands.java}} is a large class that contains multiple commands. Each
> command should be refactored into a separate class, and the methods shared by
> the commands should be refactored into a new and appropriately named class of
> their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (GEODE-3257) Refactor DeployCommands
[
https://issues.apache.org/jira/browse/GEODE-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124010#comment-16124010
]
ASF GitHub Bot commented on GEODE-3257:
---
Github user asfgit closed the pull request at:
https://github.com/apache/geode/pull/680
> Refactor DeployCommands
> ---
>
> Key: GEODE-3257
> URL: https://issues.apache.org/jira/browse/GEODE-3257
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{DeployCommands.java}} is a large class that contains multiple commands.
> Each command should be refactored into a separate class, and the methods
> shared by the commands should be refactored into a new and appropriately
> named class of their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (GEODE-3257) Refactor DeployCommands
[
https://issues.apache.org/jira/browse/GEODE-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124009#comment-16124009
]
ASF subversion and git services commented on GEODE-3257:
Commit 9d967446a44a78b612f605b6a8f8eedcfc625b3a in geode's branch
refs/heads/develop from YehEmily
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=9d96744 ]
GEODE-3257: Refactoring DeployCommands
This closes #680
> Refactor DeployCommands
> ---
>
> Key: GEODE-3257
> URL: https://issues.apache.org/jira/browse/GEODE-3257
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{DeployCommands.java}} is a large class that contains multiple commands.
> Each command should be refactored into a separate class, and the methods
> shared by the commands should be refactored into a new and appropriately
> named class of their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (GEODE-3256) Refactor DataCommands
[
https://issues.apache.org/jira/browse/GEODE-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123981#comment-16123981
]
ASF GitHub Bot commented on GEODE-3256:
---
Github user YehEmily closed the pull request at:
https://github.com/apache/geode/pull/672
> Refactor DataCommands
> -
>
> Key: GEODE-3256
> URL: https://issues.apache.org/jira/browse/GEODE-3256
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{DataCommands.java}} is a large class that contains multiple commands. Each
> command should be refactored into a separate class, and the methods shared by
> the commands should be refactored into a new and appropriately named class of
> their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (GEODE-3256) Refactor DataCommands
[
https://issues.apache.org/jira/browse/GEODE-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123980#comment-16123980
]
ASF GitHub Bot commented on GEODE-3256:
---
Github user YehEmily commented on the issue:
https://github.com/apache/geode/pull/672
Already merged to develop.
> Refactor DataCommands
> -
>
> Key: GEODE-3256
> URL: https://issues.apache.org/jira/browse/GEODE-3256
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{DataCommands.java}} is a large class that contains multiple commands. Each
> command should be refactored into a separate class, and the methods shared by
> the commands should be refactored into a new and appropriately named class of
> their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (GEODE-3165) Re-organize sources to make integration with IDE that support CMake easier.
[ https://issues.apache.org/jira/browse/GEODE-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123964#comment-16123964 ] ASF GitHub Bot commented on GEODE-3165: --- Github user dgkimura commented on the issue: https://github.com/apache/geode-native/pull/115 @pivotal-jbarrett: Ship-it! > Re-organize sources to make integration with IDE that support CMake easier. > --- > > Key: GEODE-3165 > URL: https://issues.apache.org/jira/browse/GEODE-3165 > Project: Geode > Issue Type: Task > Components: docs, native client >Reporter: Jacob S. Barrett >Assignee: Jacob S. Barrett > > Many of the IDE's that support CMake expect that CMakeList.txt be in the root > of the project. I propose moving the contents of src/ to the root, which was > the intent after cleaning out all the legacy cruft in root. > /src/docs -> /docs/api > /src/* -> /root/* > Since this a pretty straight forward move there should not be issues with > merging changes between older branches and develop after this move. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-3255) Refactor CreateAlterDestroyRegionCommands
[
https://issues.apache.org/jira/browse/GEODE-3255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123961#comment-16123961
]
ASF subversion and git services commented on GEODE-3255:
Commit 756efe77c86bb03ac9984655e7bd040659e85890 in geode's branch
refs/heads/develop from YehEmily
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=756efe7 ]
GEODE-3255: Refactor CreateAlterDestroyRegionCommands and tests
This closes #671
> Refactor CreateAlterDestroyRegionCommands
> -
>
> Key: GEODE-3255
> URL: https://issues.apache.org/jira/browse/GEODE-3255
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{CreateAlterDestroyRegionCommands.java}} is a large class that contains
> multiple commands. Each command should be refactored into a separate class,
> and the methods shared by the commands should be refactored into a new and
> appropriately named class of their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (GEODE-3255) Refactor CreateAlterDestroyRegionCommands
[
https://issues.apache.org/jira/browse/GEODE-3255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123962#comment-16123962
]
ASF GitHub Bot commented on GEODE-3255:
---
Github user asfgit closed the pull request at:
https://github.com/apache/geode/pull/671
> Refactor CreateAlterDestroyRegionCommands
> -
>
> Key: GEODE-3255
> URL: https://issues.apache.org/jira/browse/GEODE-3255
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> {{CreateAlterDestroyRegionCommands.java}} is a large class that contains
> multiple commands. Each command should be refactored into a separate class,
> and the methods shared by the commands should be refactored into a new and
> appropriately named class of their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (GEODE-3165) Re-organize sources to make integration with IDE that support CMake easier.
[ https://issues.apache.org/jira/browse/GEODE-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123936#comment-16123936 ] ASF GitHub Bot commented on GEODE-3165: --- Github user pivotal-jbarrett commented on the issue: https://github.com/apache/geode-native/pull/115 @dgkimura https://issues.apache.org/jira/browse/GEODE-3432 Anything else you don't like? > Re-organize sources to make integration with IDE that support CMake easier. > --- > > Key: GEODE-3165 > URL: https://issues.apache.org/jira/browse/GEODE-3165 > Project: Geode > Issue Type: Task > Components: docs, native client >Reporter: Jacob S. Barrett >Assignee: Jacob S. Barrett > > Many of the IDE's that support CMake expect that CMakeList.txt be in the root > of the project. I propose moving the contents of src/ to the root, which was > the intent after cleaning out all the legacy cruft in root. > /src/docs -> /docs/api > /src/* -> /root/* > Since this a pretty straight forward move there should not be issues with > merging changes between older branches and develop after this move. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (GEODE-3432) Cleanup Find NativeClient CMake modules
Jacob S. Barrett created GEODE-3432: --- Summary: Cleanup Find NativeClient CMake modules Key: GEODE-3432 URL: https://issues.apache.org/jira/browse/GEODE-3432 Project: Geode Issue Type: Task Components: native client Reporter: Jacob S. Barrett There are multiple copies. One appears to just be a copy of CMake's FindJava. Clean these up and put in appropriate locations. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-3165) Re-organize sources to make integration with IDE that support CMake easier.
[ https://issues.apache.org/jira/browse/GEODE-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123925#comment-16123925 ] ASF GitHub Bot commented on GEODE-3165: --- Github user pivotal-jbarrett commented on the issue: https://github.com/apache/geode-native/pull/115 @dgkimura Those files actually need to be redone in a way more closely aligned with other CMake find modules. I would leave them alone for now and fix later. > Re-organize sources to make integration with IDE that support CMake easier. > --- > > Key: GEODE-3165 > URL: https://issues.apache.org/jira/browse/GEODE-3165 > Project: Geode > Issue Type: Task > Components: docs, native client >Reporter: Jacob S. Barrett >Assignee: Jacob S. Barrett > > Many of the IDE's that support CMake expect that CMakeList.txt be in the root > of the project. I propose moving the contents of src/ to the root, which was > the intent after cleaning out all the legacy cruft in root. > /src/docs -> /docs/api > /src/* -> /root/* > Since this a pretty straight forward move there should not be issues with > merging changes between older branches and develop after this move. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-3230) Delete unused commands in CliStrings
[
https://issues.apache.org/jira/browse/GEODE-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123922#comment-16123922
]
ASF GitHub Bot commented on GEODE-3230:
---
Github user asfgit closed the pull request at:
https://github.com/apache/geode/pull/651
> Delete unused commands in CliStrings
>
>
> Key: GEODE-3230
> URL: https://issues.apache.org/jira/browse/GEODE-3230
> Project: Geode
> Issue Type: Improvement
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> There are a lot of commands in {{CliStrings}} that aren't used. For example,
> {{start manager}} has a whole set of associated commands -
> {{START_MANAGER__MEMBERNAME}}, {{START_MANAGER__DIR}},
> {{START_MANAGER__CLASSPATH}}, etc.) that don't seem to be used anywhere.
> These commands should be deleted to clean up the code.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (GEODE-3230) Delete unused commands in CliStrings
[
https://issues.apache.org/jira/browse/GEODE-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123921#comment-16123921
]
ASF subversion and git services commented on GEODE-3230:
Commit a7f29525df2981c1c99abac96ea83cb965295970 in geode's branch
refs/heads/develop from YehEmily
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=a7f2952 ]
GEODE-3230: Cleaning up unused (Cli)Strings
This closes #651
> Delete unused commands in CliStrings
>
>
> Key: GEODE-3230
> URL: https://issues.apache.org/jira/browse/GEODE-3230
> Project: Geode
> Issue Type: Improvement
> Components: gfsh
>Reporter: Emily Yeh
>Assignee: Emily Yeh
>
> There are a lot of commands in {{CliStrings}} that aren't used. For example,
> {{start manager}} has a whole set of associated commands -
> {{START_MANAGER__MEMBERNAME}}, {{START_MANAGER__DIR}},
> {{START_MANAGER__CLASSPATH}}, etc.) that don't seem to be used anywhere.
> These commands should be deleted to clean up the code.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (GEODE-3165) Re-organize sources to make integration with IDE that support CMake easier.
[ https://issues.apache.org/jira/browse/GEODE-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123920#comment-16123920 ] ASF GitHub Bot commented on GEODE-3165: --- Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/115#discussion_r132769880 --- Diff: CMakeLists.txt --- @@ -242,7 +242,7 @@ add_subdirectory(dhimpl) add_subdirectory(sqliteimpl) add_subdirectory(tests) add_subdirectory(templates/security) -add_subdirectory(docs) +add_subdirectory(docs/api) --- End diff -- There are API docs and the manual. > Re-organize sources to make integration with IDE that support CMake easier. > --- > > Key: GEODE-3165 > URL: https://issues.apache.org/jira/browse/GEODE-3165 > Project: Geode > Issue Type: Task > Components: docs, native client >Reporter: Jacob S. Barrett >Assignee: Jacob S. Barrett > > Many of the IDE's that support CMake expect that CMakeList.txt be in the root > of the project. I propose moving the contents of src/ to the root, which was > the intent after cleaning out all the legacy cruft in root. > /src/docs -> /docs/api > /src/* -> /root/* > Since this a pretty straight forward move there should not be issues with > merging changes between older branches and develop after this move. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GEODE-3395) Variable-ize product version and name in user guide
[
https://issues.apache.org/jira/browse/GEODE-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123913#comment-16123913
]
ASF subversion and git services commented on GEODE-3395:
Commit 239efd60f60473d03181ef3e7a7394b0ffae3935 in geode's branch
refs/heads/develop from [~dbarnes97]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=239efd6 ]
GEODE-3395 Variable-ize product version and name in user guide - Top-level
files: about and glossary
> Variable-ize product version and name in user guide
>
>
> Key: GEODE-3395
> URL: https://issues.apache.org/jira/browse/GEODE-3395
> Project: Geode
> Issue Type: New Feature
> Components: docs
>Reporter: Dave Barnes
>Assignee: Dave Barnes
>
> The Guide contains many occurrences of the product version string ("1.2",
> "1.1", and "1.0-incubating" are recent examples) scattered over about 900
> files. It would be a great convenience to those who write and edit these
> files to define the version number symbolically so it could be updated in one
> central location. A template variable in the book's config.yml file would be
> an obvious candidate for the implementation.
> Similarly, it would be handy to provide symbolic identifiers for the product
> name, long and short: "Apache Geode" and "Geode", respectively.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Assigned] (GEODE-3431) user guide: add a few items to host machine requirements
[ https://issues.apache.org/jira/browse/GEODE-3431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dave Barnes reassigned GEODE-3431: -- Assignee: Dave Barnes > user guide: add a few items to host machine requirements > > > Key: GEODE-3431 > URL: https://issues.apache.org/jira/browse/GEODE-3431 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Dave Barnes >Assignee: Dave Barnes >Priority: Minor > > Add the following to the "Host Machine Requirements" page in the user manual: > * An adequate per-user limit on the number of file descriptors; for > Unix/Linux, the recommended soft limit is 8192, and the hard limit is 81920. > * An adequate per-user limit on the number of processes (nprocs); for > Unix/Linux, the recommended soft limit is 501408, with an unlimited hard > limit. > * TCP/IP. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (GEODE-3431) user guide: add a few items to host machine requirements
[ https://issues.apache.org/jira/browse/GEODE-3431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dave Barnes updated GEODE-3431: --- Priority: Minor (was: Major) > user guide: add a few items to host machine requirements > > > Key: GEODE-3431 > URL: https://issues.apache.org/jira/browse/GEODE-3431 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Dave Barnes >Priority: Minor > > Add the following to the "Host Machine Requirements" page in the user manual: > * An adequate per-user limit on the number of file descriptors; for > Unix/Linux, the recommended soft limit is 8192, and the hard limit is 81920. > * An adequate per-user limit on the number of processes (nprocs); for > Unix/Linux, the recommended soft limit is 501408, with an unlimited hard > limit. > * TCP/IP. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
