[jira] [Created] (GEODE-3442) Update ACE to 6.4.4

[Jacob S. Barrett (JIRA)]

Jacob S. Barrett created GEODE-3442:
---

 Summary: Update ACE to 6.4.4
 Key: GEODE-3442
 URL: https://issues.apache.org/jira/browse/GEODE-3442
 Project: Geode
  Issue Type: Task
  Components: native client
Reporter: Jacob S. Barrett


https://github.com/DOCGroup/ACE_TAO/releases/tag/ACE%2BTAO-6_4_4




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3416) Reduce blocking for SocketCloser.asyncClose

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126780#comment-16126780
 ] 

ASF GitHub Bot commented on GEODE-3416:
---

Github user kohlmu-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/702#discussion_r133113689
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/internal/net/SocketCloser.java ---
@@ -96,46 +99,55 @@ public int getMaxThreads() {
 return this.asyncClosePoolMaxThreads;
   }
 
-  private ThreadPoolExecutor getAsyncThreadExecutor(String address) {
-synchronized (asyncCloseExecutors) {
-  ThreadPoolExecutor pool = asyncCloseExecutors.get(address);
-  if (pool == null) {
-final ThreadGroup tg = 
LoggingThreadGroup.createThreadGroup("Socket asyncClose", logger);
-ThreadFactory tf = new ThreadFactory() {
-  public Thread newThread(final Runnable command) {
-Thread thread = new Thread(tg, command);
-thread.setDaemon(true);
-return thread;
-  }
-};
-BlockingQueue workQueue = new 
LinkedBlockingQueue();
-pool = new ThreadPoolExecutor(this.asyncClosePoolMaxThreads, 
this.asyncClosePoolMaxThreads,
-this.asyncClosePoolKeepAliveSeconds, TimeUnit.SECONDS, 
workQueue, tf);
-pool.allowCoreThreadTimeOut(true);
-asyncCloseExecutors.put(address, pool);
+  private ExecutorService getAsyncThreadExecutor(String address) {
+ExecutorService executorService = asyncCloseExecutors.get(address);
+if (executorService == null) {
+  // To be used for pre-1.8 jdk releases.
+  // createThreadPool();
+
+  executorService = 
Executors.newWorkStealingPool(asyncClosePoolMaxThreads);
+
+  ExecutorService previousThreadPoolExecutor =
+  asyncCloseExecutors.putIfAbsent(address, executorService);
+
+  if (previousThreadPoolExecutor != null) {
+executorService.shutdownNow();
+return previousThreadPoolExecutor;
   }
-  return pool;
 }
+return executorService;
+  }
+
+  /**
+   * @deprecated this method is to be used for pre 1.8 jdk.
+   */
+  @Deprecated
+  private void createThreadPool() {
+ExecutorService executorService;
+final ThreadGroup threadGroup =
+LoggingThreadGroup.createThreadGroup("Socket asyncClose", logger);
+ThreadFactory threadFactory = new ThreadFactory() {
+  public Thread newThread(final Runnable command) {
+Thread thread = new Thread(threadGroup, command);
+thread.setDaemon(true);
+return thread;
+  }
+};
+
+executorService = new ThreadPoolExecutor(asyncClosePoolMaxThreads, 
asyncClosePoolMaxThreads,
+asyncCloseWaitTime, asyncCloseWaitUnits, new 
LinkedBlockingQueue<>(), threadFactory);
   }
 
   /**
* Call this method if you know all the resources in the closer for the 
given address are no
* longer needed. Currently a thread pool is kept for each address and 
if you know that an address
* no longer needs its pool then you should call this method.
*/
-  public void releaseResourcesForAddress(String address) {
-synchronized (asyncCloseExecutors) {
-  ThreadPoolExecutor pool = asyncCloseExecutors.get(address);
-  if (pool != null) {
-pool.shutdown();
-asyncCloseExecutors.remove(address);
-  }
-}
-  }
 
-  private boolean isClosed() {
-synchronized (asyncCloseExecutors) {
-  return this.closed;
+  public void releaseResourcesForAddress(String address) {
+ExecutorService executorService = asyncCloseExecutors.remove(address);
+if (executorService != null) {
+  executorService.shutdown();
--- End diff --

given that remove is on the concurrent hashmap, one should only ever get 
into this once. This should not suffer reentrancy problems.


> Reduce blocking for SocketCloser.asyncClose 
> 
>
> Key: GEODE-3416
> URL: https://issues.apache.org/jira/browse/GEODE-3416
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Affects Versions: 1.1.0, 1.1.1, 1.2.0, 1.2.1
>Reporter: Udo Kohlmeyer
>Assignee: Udo Kohlmeyer
> Fix For: 1.3.0
>
>
> In the SocketCloser.asyncClose method, there is a synchronization block 
> around at HashMap. This synchronization will cause an effective 
> single-threaded processing capability when closing sockets. this effect 
> becomes more evident with a high number of clients.



--
This message was sent 

[jira] [Resolved] (GEODE-3300) Complete and expose parallel snapshots feature

[Nick Reich (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nick Reich resolved GEODE-3300.
---
   Resolution: Fixed
Fix Version/s: 1.3.0

> Complete and expose parallel snapshots feature
> --
>
> Key: GEODE-3300
> URL: https://issues.apache.org/jira/browse/GEODE-3300
> Project: Geode
>  Issue Type: Sub-task
>  Components: docs, snapshot
>Reporter: Nick Reich
>Assignee: Nick Reich
> Fix For: 1.3.0
>
>
> The parallel snapshots feature was never fully completed and exposed in the 
> API for snapshots. This is the first step in allowing users to make use of 
> this feature



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3416) Reduce blocking for SocketCloser.asyncClose

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126672#comment-16126672
 ] 

ASF GitHub Bot commented on GEODE-3416:
---

Github user WireBaron commented on a diff in the pull request:

https://github.com/apache/geode/pull/702#discussion_r133094233
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/internal/net/SocketCloser.java ---
@@ -96,46 +99,55 @@ public int getMaxThreads() {
 return this.asyncClosePoolMaxThreads;
   }
 
-  private ThreadPoolExecutor getAsyncThreadExecutor(String address) {
-synchronized (asyncCloseExecutors) {
-  ThreadPoolExecutor pool = asyncCloseExecutors.get(address);
-  if (pool == null) {
-final ThreadGroup tg = 
LoggingThreadGroup.createThreadGroup("Socket asyncClose", logger);
-ThreadFactory tf = new ThreadFactory() {
-  public Thread newThread(final Runnable command) {
-Thread thread = new Thread(tg, command);
-thread.setDaemon(true);
-return thread;
-  }
-};
-BlockingQueue workQueue = new 
LinkedBlockingQueue();
-pool = new ThreadPoolExecutor(this.asyncClosePoolMaxThreads, 
this.asyncClosePoolMaxThreads,
-this.asyncClosePoolKeepAliveSeconds, TimeUnit.SECONDS, 
workQueue, tf);
-pool.allowCoreThreadTimeOut(true);
-asyncCloseExecutors.put(address, pool);
+  private ExecutorService getAsyncThreadExecutor(String address) {
+ExecutorService executorService = asyncCloseExecutors.get(address);
+if (executorService == null) {
+  // To be used for pre-1.8 jdk releases.
+  // createThreadPool();
+
+  executorService = 
Executors.newWorkStealingPool(asyncClosePoolMaxThreads);
+
+  ExecutorService previousThreadPoolExecutor =
+  asyncCloseExecutors.putIfAbsent(address, executorService);
+
+  if (previousThreadPoolExecutor != null) {
+executorService.shutdownNow();
+return previousThreadPoolExecutor;
   }
-  return pool;
 }
+return executorService;
+  }
+
+  /**
+   * @deprecated this method is to be used for pre 1.8 jdk.
+   */
+  @Deprecated
+  private void createThreadPool() {
+ExecutorService executorService;
+final ThreadGroup threadGroup =
+LoggingThreadGroup.createThreadGroup("Socket asyncClose", logger);
+ThreadFactory threadFactory = new ThreadFactory() {
+  public Thread newThread(final Runnable command) {
+Thread thread = new Thread(threadGroup, command);
+thread.setDaemon(true);
+return thread;
+  }
+};
+
+executorService = new ThreadPoolExecutor(asyncClosePoolMaxThreads, 
asyncClosePoolMaxThreads,
+asyncCloseWaitTime, asyncCloseWaitUnits, new 
LinkedBlockingQueue<>(), threadFactory);
   }
 
   /**
* Call this method if you know all the resources in the closer for the 
given address are no
* longer needed. Currently a thread pool is kept for each address and 
if you know that an address
* no longer needs its pool then you should call this method.
*/
-  public void releaseResourcesForAddress(String address) {
-synchronized (asyncCloseExecutors) {
-  ThreadPoolExecutor pool = asyncCloseExecutors.get(address);
-  if (pool != null) {
-pool.shutdown();
-asyncCloseExecutors.remove(address);
-  }
-}
-  }
 
-  private boolean isClosed() {
-synchronized (asyncCloseExecutors) {
-  return this.closed;
+  public void releaseResourcesForAddress(String address) {
+ExecutorService executorService = asyncCloseExecutors.remove(address);
+if (executorService != null) {
+  executorService.shutdown();
--- End diff --

Is this call (excutorService.shutdown) reentrant?


> Reduce blocking for SocketCloser.asyncClose 
> 
>
> Key: GEODE-3416
> URL: https://issues.apache.org/jira/browse/GEODE-3416
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Affects Versions: 1.1.0, 1.1.1, 1.2.0, 1.2.1
>Reporter: Udo Kohlmeyer
>Assignee: Udo Kohlmeyer
> Fix For: 1.3.0
>
>
> In the SocketCloser.asyncClose method, there is a synchronization block 
> around at HashMap. This synchronization will cause an effective 
> single-threaded processing capability when closing sockets. this effect 
> becomes more evident with a high number of clients.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (GEODE-3441) Tomcat8SessionsClientServerDUnitTest uses default port

[Dan Smith (JIRA)]

Dan Smith created GEODE-3441:


 Summary: Tomcat8SessionsClientServerDUnitTest uses default port
 Key: GEODE-3441
 URL: https://issues.apache.org/jira/browse/GEODE-3441
 Project: Geode
  Issue Type: Bug
  Components: http session
Reporter: Dan Smith


The Tomcat8SessionsClientServerDUnitTest client server test recently failed in 
jenkins. It looks like there was already a geode server running on the default 
port.

This test should use a random port for the cache server, not the default port.

With revision 566ff6c70a91e052be558df80b76f2eef611c1c8, from build 922
{noformat}
org.apache.geode.test.dunit.RMIException: While invoking 
org.apache.geode.modules.session.Tomcat8SessionsClientServerDUnitTest$$Lambda$57/1625836960.call
 in VM 1 running on Host asf905.gq1.ygridcore.net with 4 VMs
at org.apache.geode.test.dunit.VM.invoke(VM.java:387)
at org.apache.geode.test.dunit.VM.invoke(VM.java:357)
at org.apache.geode.test.dunit.VM.invoke(VM.java:325)
at 
org.apache.geode.modules.session.Tomcat8SessionsClientServerDUnitTest.setupServer(Tomcat8SessionsClientServerDUnitTest.java:60)
at 
org.apache.geode.modules.session.Tomcat8SessionsClientServerDUnitTest.postSetUp(Tomcat8SessionsClientServerDUnitTest.java:44)
Caused by: java.net.BindException: Failed to create server socket on  
null[40,404]
at 
org.apache.geode.internal.net.SocketCreator.createServerSocket(SocketCreator.java:783)
at 
org.apache.geode.internal.net.SocketCreator.createServerSocket(SocketCreator.java:745)
at 
org.apache.geode.internal.net.SocketCreator.createServerSocket(SocketCreator.java:712)
at 
org.apache.geode.internal.cache.tier.sockets.AcceptorImpl.(AcceptorImpl.java:469)
at 
org.apache.geode.internal.cache.CacheServerImpl.start(CacheServerImpl.java:344)
at 
org.apache.geode.modules.session.Tomcat8SessionsClientServerDUnitTest.lambda$setupServer$f0fd67c5$1(Tomcat8SessionsClientServerDUnitTest.java:65)
Caused by: java.net.BindException: Address already in use (Bind failed)
at java.net.PlainSocketImpl.socketBind(Native Method)
at 
java.net.AbstractPlainSocketImpl.bind(AbstractPlainSocketImpl.java:387)
at java.net.ServerSocket.bind(ServerSocket.java:375)
at 
org.apache.geode.internal.net.SocketCreator.createServerSocket(SocketCreator.java:779)
... 27 more
{noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (GEODE-3402) Mark protocol as experimental

[Udo Kohlmeyer (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Udo Kohlmeyer resolved GEODE-3402.
--
   Resolution: Fixed
 Assignee: Bruce Schuchardt
Fix Version/s: 1.2.1
   1.3.0

> Mark protocol as experimental
> -
>
> Key: GEODE-3402
> URL: https://issues.apache.org/jira/browse/GEODE-3402
> Project: Geode
>  Issue Type: Task
>  Components: client/server
>Reporter: Brian Baynes
>Assignee: Bruce Schuchardt
> Fix For: 1.3.0, 1.2.1
>
>
> Mark new protocol as experimental.  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3402) Mark protocol as experimental

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126652#comment-16126652
 ] 

ASF subversion and git services commented on GEODE-3402:


Commit a600068477bb07abb04206ab9540dfef09e89506 in geode's branch 
refs/heads/develop from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=a600068 ]

GEODE-3402: Mark ProtoBuf interface as experimental. This now closes #698

Signed-off-by: Alexander Murmann 


> Mark protocol as experimental
> -
>
> Key: GEODE-3402
> URL: https://issues.apache.org/jira/browse/GEODE-3402
> Project: Geode
>  Issue Type: Task
>  Components: client/server
>Reporter: Brian Baynes
>
> Mark new protocol as experimental.  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (GEODE-3428) Create new geode-example about putting multiple values at once

[Michael Dodge (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Dodge updated GEODE-3428:
-
Component/s: (was: regions)
 examples

> Create new geode-example about putting multiple values at once
> --
>
> Key: GEODE-3428
> URL: https://issues.apache.org/jira/browse/GEODE-3428
> Project: Geode
>  Issue Type: New Feature
>  Components: examples
>Reporter: Michael Dodge
>Assignee: Michael Dodge
>
> The more examples, the better. . .
> Create an example that demonstrates how to do a put-all.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (GEODE-3440) Create new geode-example about using functions

[Michael Dodge (JIRA)]

Michael Dodge created GEODE-3440:


 Summary: Create new geode-example about using functions
 Key: GEODE-3440
 URL: https://issues.apache.org/jira/browse/GEODE-3440
 Project: Geode
  Issue Type: New Feature
  Components: examples
Reporter: Michael Dodge


The more examples, the better. . .

Create an example that demonstrates how to use a function.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3439) CLI Integration Test ThinClientRegionInterestTestsN fails intermittently

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126610#comment-16126610
 ] 

ASF GitHub Bot commented on GEODE-3439:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/116


> CLI Integration Test ThinClientRegionInterestTestsN fails intermittently
> 
>
> Key: GEODE-3439
> URL: https://issues.apache.org/jira/browse/GEODE-3439
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> CLI integration test ThinClientRegionInterestTestsN fails intermittently with 
> process hang.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3439) CLI Integration Test ThinClientRegionInterestTestsN fails intermittently

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126609#comment-16126609
 ] 

ASF subversion and git services commented on GEODE-3439:


Commit 70d2456b011f52c3c7b77bd362a567d6a0dbfb69 in geode-native's branch 
refs/heads/develop from Jacob Barrett
[ https://git-wip-us.apache.org/repos/asf?p=geode-native.git;h=70d2456 ]

GEODE-3439: Split ThinClientRegionInterestTestsN into mulitple tests to avoid 
random failures.


> CLI Integration Test ThinClientRegionInterestTestsN fails intermittently
> 
>
> Key: GEODE-3439
> URL: https://issues.apache.org/jira/browse/GEODE-3439
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> CLI integration test ThinClientRegionInterestTestsN fails intermittently with 
> process hang.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3439) CLI Integration Test ThinClientRegionInterestTestsN fails intermittently

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126591#comment-16126591
 ] 

ASF GitHub Bot commented on GEODE-3439:
---

GitHub user pivotal-jbarrett opened a pull request:

https://github.com/apache/geode-native/pull/116

GEODE-3439: Split ThinClientRegionInterestTestsN into mulitple tests …

…to avoid random failures.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pivotal-jbarrett/geode-native 
feature/GEODE-3439

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/116.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #116


commit 70d2456b011f52c3c7b77bd362a567d6a0dbfb69
Author: Jacob Barrett 
Date:   2017-08-14T23:04:43Z

GEODE-3439: Split ThinClientRegionInterestTestsN into mulitple tests to 
avoid random failures.




> CLI Integration Test ThinClientRegionInterestTestsN fails intermittently
> 
>
> Key: GEODE-3439
> URL: https://issues.apache.org/jira/browse/GEODE-3439
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> CLI integration test ThinClientRegionInterestTestsN fails intermittently with 
> process hang.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (GEODE-3439) CLI Integration Test ThinClientRegionInterestTestsN fails intermittently

[Jacob S. Barrett (JIRA)]

Jacob S. Barrett created GEODE-3439:
---

 Summary: CLI Integration Test ThinClientRegionInterestTestsN fails 
intermittently
 Key: GEODE-3439
 URL: https://issues.apache.org/jira/browse/GEODE-3439
 Project: Geode
  Issue Type: Bug
  Components: native client
Reporter: Jacob S. Barrett


CLI integration test ThinClientRegionInterestTestsN fails intermittently with 
process hang.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (GEODE-3439) CLI Integration Test ThinClientRegionInterestTestsN fails intermittently

[Jacob S. Barrett (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacob S. Barrett reassigned GEODE-3439:
---

Assignee: Jacob S. Barrett

> CLI Integration Test ThinClientRegionInterestTestsN fails intermittently
> 
>
> Key: GEODE-3439
> URL: https://issues.apache.org/jira/browse/GEODE-3439
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> CLI integration test ThinClientRegionInterestTestsN fails intermittently with 
> process hang.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (GEODE-3393) One-way SSL between client & server is not working

[Udo Kohlmeyer (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Udo Kohlmeyer resolved GEODE-3393.
--
   Resolution: Fixed
Fix Version/s: 1.2.1

> One-way SSL between client & server is not working
> --
>
> Key: GEODE-3393
> URL: https://issues.apache.org/jira/browse/GEODE-3393
> Project: Geode
>  Issue Type: Bug
>  Components: client/server, security
>Reporter: Udo Kohlmeyer
>Assignee: Udo Kohlmeyer
> Fix For: 1.2.1
>
>
> Caused by: java.io.FileNotFoundException: /Users//.keystore (No such file 
> or directory)
>   at java.io.FileInputStream.open(Native Method)
>   at java.io.FileInputStream.(FileInputStream.java:131)
>   at java.io.FileInputStream.(FileInputStream.java:87)
>   at 
> org.apache.geode.internal.net.SocketCreator.getKeyManagers(SocketCreator.java:567)
>   at 
> org.apache.geode.internal.net.SocketCreator.createAndConfigureSSLContext(SocketCreator.java:394)
>   at 
> org.apache.geode.internal.net.SocketCreator.initialize(SocketCreator.java:351)
>   ... 37 more
> locator & server:
> ssl-enabled-components=server,locator
> ssl-require-authentication=false
> ssl-keystore=/Users/./test/keystores/server.jks
> ssl-keystore-password=password
> ssl-truststore=/Users//test/keystores/client.truststore
> ssl-truststore-password=password
> client:
> ssl-enabled-components=server,locator
> ssl-require-authentication=false
> ssl-truststore=/Users//test/keystores/client.truststore
> ssl-truststore-password=password



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3393) One-way SSL between client & server is not working

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126521#comment-16126521
 ] 

ASF subversion and git services commented on GEODE-3393:


Commit 684f85d2881dd1b0b68bc49b303fb45a8b17452d in geode's branch 
refs/heads/develop from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=684f85d ]

GEODE-3393: One-way SSL commit failing with userHome/.keystore not found. This 
now closes #682

Signed-off-by: Galen O'Sullivan 


> One-way SSL between client & server is not working
> --
>
> Key: GEODE-3393
> URL: https://issues.apache.org/jira/browse/GEODE-3393
> Project: Geode
>  Issue Type: Bug
>  Components: client/server, security
>Reporter: Udo Kohlmeyer
>Assignee: Udo Kohlmeyer
>
> Caused by: java.io.FileNotFoundException: /Users//.keystore (No such file 
> or directory)
>   at java.io.FileInputStream.open(Native Method)
>   at java.io.FileInputStream.(FileInputStream.java:131)
>   at java.io.FileInputStream.(FileInputStream.java:87)
>   at 
> org.apache.geode.internal.net.SocketCreator.getKeyManagers(SocketCreator.java:567)
>   at 
> org.apache.geode.internal.net.SocketCreator.createAndConfigureSSLContext(SocketCreator.java:394)
>   at 
> org.apache.geode.internal.net.SocketCreator.initialize(SocketCreator.java:351)
>   ... 37 more
> locator & server:
> ssl-enabled-components=server,locator
> ssl-require-authentication=false
> ssl-keystore=/Users/./test/keystores/server.jks
> ssl-keystore-password=password
> ssl-truststore=/Users//test/keystores/client.truststore
> ssl-truststore-password=password
> client:
> ssl-enabled-components=server,locator
> ssl-require-authentication=false
> ssl-truststore=/Users//test/keystores/client.truststore
> ssl-truststore-password=password



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (GEODE-3438) Collection added to itself

[JC (JIRA)]

JC created GEODE-3438:
-

 Summary: Collection added to itself
 Key: GEODE-3438
 URL: https://issues.apache.org/jira/browse/GEODE-3438
 Project: Geode
  Issue Type: Bug
  Components: core
Reporter: JC


Hi

In a recent github mirror, I've found suspicious code.
Branch: master
Path: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/domain/DurableCqNamesResult.java

{code:java}
...
 27   private List cqNames = new ArrayList();
...
 33   public DurableCqNamesResult(final String memberNameOrId, List 
cqNames) {
 34 super(memberNameOrId);
 35 cqNames.addAll(cqNames);
 36   }
{code}

In Line 35, should `cqNames.addAll' be `this.cqNames.addAll'? This might not be 
an issue, but I wanted to report just in case.

Thanks!



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3434) Allow the modules to be interoperable with current and older versions of tomcat 7

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126243#comment-16126243
 ] 

ASF subversion and git services commented on GEODE-3434:


Commit ae570225ed1d53dafd7450b4b4e399eb073f8442 in geode's branch 
refs/heads/feature/GEODE-3434 from [~huynhja]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=ae57022 ]

GEODE-3434: Modifications based on review comments


> Allow the modules to be interoperable with current and older versions of 
> tomcat 7 
> --
>
> Key: GEODE-3434
> URL: https://issues.apache.org/jira/browse/GEODE-3434
> Project: Geode
>  Issue Type: Bug
>  Components: http session
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> There was a change to the attribute field in tomcat (and we made the 
> necessary changes in geode session modules), but that does not allow our 
> session modules to work with older versions of tomcat 7.  We can probably 
> modify the classes to allow use with of the session module jars across 
> different versions of tomcat 7.
> We should probably add tests that run against older versions of geode to 
> allow backwards compatibility between a geode server and a session module jar 
> from a previous release.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (GEODE-3431) user guide: add a few items to host machine requirements

[Dave Barnes (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Barnes resolved GEODE-3431.

Resolution: Not A Problem

> user guide: add a few items to host machine requirements
> 
>
> Key: GEODE-3431
> URL: https://issues.apache.org/jira/browse/GEODE-3431
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Dave Barnes
>Priority: Minor
>
> Add the following to the "Host Machine Requirements" page in the user manual:
> * An adequate per-user limit on the number of file descriptors; for 
> Unix/Linux, the recommended soft limit is 8192, and the hard limit is 81920.
> * An adequate per-user limit on the number of processes (nprocs); for 
> Unix/Linux, the recommended soft limit is 501408, with an unlimited hard 
> limit.
> * TCP/IP.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3423) Provide support for running parallel docker builds in Jenkins

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126199#comment-16126199
 ] 

ASF subversion and git services commented on GEODE-3423:


Commit 0ab0ad450a9d2a05e77d1b71936bc04c0b9f4a9f in geode's branch 
refs/heads/develop from [~gemzdude]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=0ab0ad4 ]

GEODE-3423: Use openjdk:8 as the base

Signed-off-by: Jens Deppe 


> Provide support for running parallel docker builds in Jenkins
> -
>
> Key: GEODE-3423
> URL: https://issues.apache.org/jira/browse/GEODE-3423
> Project: Geode
>  Issue Type: Improvement
>  Components: build
>Reporter: Jens Deppe
>
> Provide the necessary Dockerfile components to build a docker container which 
> can be used for parallel dunit builds in a jenkins environment.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3434) Allow the modules to be interoperable with current and older versions of tomcat 7

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126046#comment-16126046
 ] 

ASF GitHub Bot commented on GEODE-3434:
---

Github user DivineEnder commented on a diff in the pull request:

https://github.com/apache/geode/pull/712#discussion_r133012057
  
--- Diff: 
geode-assembly/src/test/java/org/apache/geode/session/tests/TomcatInstall.java 
---
@@ -150,6 +166,66 @@ public TomcatInstall(TomcatVersion version, 
ConnectionType connType, String inst
   }
 
   /**
+   * Copies jars specified by {@link #tomcatRequiredJars} from the {@link 
#getModulePath()} and the
+   * specified other directory passed to the function
+   *
+   * @throws IOException if the {@link #getModulePath()}, installation lib 
directory, or extra
+   * directory passed in contain no files.
+   */
+  private void copyTomcatGeodeReqFiles(String moduleJarDir, String 
extraJarsPath)
--- End diff --

Copy stuff in function into other function


> Allow the modules to be interoperable with current and older versions of 
> tomcat 7 
> --
>
> Key: GEODE-3434
> URL: https://issues.apache.org/jira/browse/GEODE-3434
> Project: Geode
>  Issue Type: Bug
>  Components: http session
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> There was a change to the attribute field in tomcat (and we made the 
> necessary changes in geode session modules), but that does not allow our 
> session modules to work with older versions of tomcat 7.  We can probably 
> modify the classes to allow use with of the session module jars across 
> different versions of tomcat 7.
> We should probably add tests that run against older versions of geode to 
> allow backwards compatibility between a geode server and a session module jar 
> from a previous release.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3434) Allow the modules to be interoperable with current and older versions of tomcat 7

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126040#comment-16126040
 ] 

ASF GitHub Bot commented on GEODE-3434:
---

Github user DivineEnder commented on a diff in the pull request:

https://github.com/apache/geode/pull/712#discussion_r133011336
  
--- Diff: 
geode-assembly/src/test/java/org/apache/geode/session/tests/TomcatInstall.java 
---
@@ -131,15 +142,20 @@ public TomcatInstall(TomcatVersion version, 
ConnectionType connType) throws Exce
* within the installation's 'conf' folder, and {@link 
#updateProperties()} to set the jar
* skipping properties needed to speedup container startup.
*/
-  public TomcatInstall(TomcatVersion version, ConnectionType connType, 
String installDir)
-  throws Exception {
+  public TomcatInstall(TomcatVersion version, ConnectionType connType, 
String installDir,
+  String modulesJarLocation, String extraJarsPath) throws Exception {
 // Does download and install from URL
-super(installDir, version.getDownloadURL(), connType, "tomcat");
+super(installDir, version.getDownloadURL(), connType, "tomcat",
--- End diff --

Refactor both "tomcat" and DEFAULT_MODULE_LOCATION pass down/up into other 
constructors


> Allow the modules to be interoperable with current and older versions of 
> tomcat 7 
> --
>
> Key: GEODE-3434
> URL: https://issues.apache.org/jira/browse/GEODE-3434
> Project: Geode
>  Issue Type: Bug
>  Components: http session
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> There was a change to the attribute field in tomcat (and we made the 
> necessary changes in geode session modules), but that does not allow our 
> session modules to work with older versions of tomcat 7.  We can probably 
> modify the classes to allow use with of the session module jars across 
> different versions of tomcat 7.
> We should probably add tests that run against older versions of geode to 
> allow backwards compatibility between a geode server and a session module jar 
> from a previous release.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3434) Allow the modules to be interoperable with current and older versions of tomcat 7

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126037#comment-16126037
 ] 

ASF GitHub Bot commented on GEODE-3434:
---

Github user DivineEnder commented on a diff in the pull request:

https://github.com/apache/geode/pull/712#discussion_r133010884
  
--- Diff: 
geode-assembly/src/test/java/org/apache/geode/session/tests/ServerContainer.java
 ---
@@ -134,6 +134,7 @@ public ServerContainer(ContainerInstall install, File 
containerConfigHome,
 
 // Set cacheXML file
 File installXMLFile = install.getCacheXMLFile();
+String path = logDir.getAbsolutePath() + "/" + 
installXMLFile.getName();
--- End diff --

Probably not needed


> Allow the modules to be interoperable with current and older versions of 
> tomcat 7 
> --
>
> Key: GEODE-3434
> URL: https://issues.apache.org/jira/browse/GEODE-3434
> Project: Geode
>  Issue Type: Bug
>  Components: http session
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> There was a change to the attribute field in tomcat (and we made the 
> necessary changes in geode session modules), but that does not allow our 
> session modules to work with older versions of tomcat 7.  We can probably 
> modify the classes to allow use with of the session module jars across 
> different versions of tomcat 7.
> We should probably add tests that run against older versions of geode to 
> allow backwards compatibility between a geode server and a session module jar 
> from a previous release.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3434) Allow the modules to be interoperable with current and older versions of tomcat 7

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126019#comment-16126019
 ] 

ASF GitHub Bot commented on GEODE-3434:
---

GitHub user jhuynh1 opened a pull request:

https://github.com/apache/geode/pull/712

GEODE-3434: Allow the modules to be interoperable with current and ol…

…der versions of tomcat 7

Modified DeltaSessions to use reflection to handle attributes fields incase 
an earlier tomcat 7 is used
Modified DeltaSession7 and DeltaSession8 to extend from DeltaSession
Added session backward compatibility tests
Modified aseembly build to download old product installs

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to d...@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/geode feature/GEODE-3434

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/712.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #712


commit e9ed8a12f6f8cb9dfeedcec5922069bce2e7b7e3
Author: Jason Huynh 
Date:   2017-08-14T16:02:11Z

GEODE-3434: Allow the modules to be interoperable with current and older 
versions of tomcat 7
Modified DeltaSessions to use reflection to handle attributes fields incase 
an earlier tomcat 7 is used
Modified DeltaSession7 and DeltaSession8 to extend from DeltaSession
Added session backward compatibility tests
Modified aseembly build to download old product installs




> Allow the modules to be interoperable with current and older versions of 
> tomcat 7 
> --
>
> Key: GEODE-3434
> URL: https://issues.apache.org/jira/browse/GEODE-3434
> Project: Geode
>  Issue Type: Bug
>  Components: http session
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> There was a change to the attribute field in tomcat (and we made the 
> necessary changes in geode session modules), but that does not allow our 
> session modules to work with older versions of tomcat 7.  We can probably 
> modify the classes to allow use with of the session module jars across 
> different versions of tomcat 7.
> We should probably add tests that run against older versions of geode to 
> allow backwards compatibility between a geode server and a session module jar 
> from a previous release.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3436) GFSH commands tests are failing after committing refactorings of command classes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126016#comment-16126016
 ] 

ASF GitHub Bot commented on GEODE-3436:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/711


> GFSH commands tests are failing after committing refactorings of command 
> classes
> 
>
> Key: GEODE-3436
> URL: https://issues.apache.org/jira/browse/GEODE-3436
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> {noformat}
> :geode-core:integrationTest
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest > 
> testHelpWithNoInput FAILED
> java.lang.AssertionError: 
> Expected size:<2> but was:<4> in:
> <["help (Available)",
> "Display syntax and usage information for all commands or list all 
> available commands if  isn't specified.",
> "hint (Available)",
> "Provide hints for a topic or list all available topics if "topic" 
> isn't specified."]>
> at 
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHelpWithNoInput(HelperIntegrationTest.java:69)
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest > 
> testHintWithNoInput FAILED
> java.lang.AssertionError: 
> Expected size:<21> but was:<22> in:
> <["Hints are available for the following topics. Use "hint " 
> for a specific hint.",
> "",
> "Client",
> "Cluster Configuration",
> "Configuration",
> "Data",
> "Debug-Utility",
> "Disk Store",
> "Function Execution",
> "GFSH",
> "Geode",
> "Help",
> "JMX",
> "Lifecycle",
> "Locator",
> "Logs",
> "Management-Monitoring",
> "Manager",
> "Region",
> "Server",
> "Statistics",
> "WAN"]>
> at 
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHintWithNoInput(HelperIntegrationTest.java:96)
> org.apache.geode.management.internal.cli.GfshParserConverterTest > 
> testHintConverter FAILED
> java.lang.StringIndexOutOfBoundsException: String index out of range: -1
> at java.lang.String.substring(String.java:1931)
> at 
> org.apache.geode.management.internal.cli.GfshParser.lambda$completeAdvanced$0(GfshParser.java:265)
> at java.util.ArrayList.replaceAll(ArrayList.java:1442)
> at 
> org.apache.geode.management.internal.cli.GfshParser.completeAdvanced(GfshParser.java:264)
> at 
> org.apache.geode.test.dunit.rules.GfshParserRule.complete(GfshParserRule.java:58)
> at 
> org.apache.geode.management.internal.cli.GfshParserConverterTest.testHintConverter(GfshParserConverterTest.java:126)
> org.apache.geode.management.internal.security.CliCommandsSecurityTest > 
> testNoAccess FAILED
> org.assertj.core.api.SoftAssertionError: 
> The following assertion failed:
> 1) [destroy function --id=InterestCalculations] 
> Expecting:
>  <"stranger not authorized for CLUSTER:MANAGE:JAR">
> to contain:
>  <"DATA:MANAGE"> 
> at CliCommandsSecurityTest.testNoAccess(CliCommandsSecurityTest.java:74)
> at 
> org.assertj.core.api.SoftAssertions.assertAll(SoftAssertions.java:134)
> at 
> org.apache.geode.management.internal.security.CliCommandsSecurityTest.testNoAccess(CliCommandsSecurityTest.java:78)
> org.apache.geode.management.internal.security.GfshCommandsSecurityTest > 
> testRegionAReader FAILED
> org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] 
> expected:<[110]> but was:<[415]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)
> at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at 
> org.apache.geode.management.internal.security.GfshCommandsSecurityTest.runCommandsPermittedAndForbiddenBy(GfshCommandsSecurityTest.java:164)
> at 
> org.apache.geode.management.internal.security.GfshCommandsSecurityTest.testRegionAReader(GfshCommandsSecurityTest.java:108)
> org.apache.geode.management.internal.security.GfshCommandsSecurityTest > 
> testRegionAWriter FAILED
> org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] 
> expected:<[110]> but was:<[415]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)
> at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at 
> 

[jira] [Commented] (GEODE-3434) Allow the modules to be interoperable with current and older versions of tomcat 7

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126014#comment-16126014
 ] 

ASF subversion and git services commented on GEODE-3434:


Commit e9ed8a12f6f8cb9dfeedcec5922069bce2e7b7e3 in geode's branch 
refs/heads/feature/GEODE-3434 from [~huynhja]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=e9ed8a1 ]

GEODE-3434: Allow the modules to be interoperable with current and older 
versions of tomcat 7
Modified DeltaSessions to use reflection to handle attributes fields incase an 
earlier tomcat 7 is used
Modified DeltaSession7 and DeltaSession8 to extend from DeltaSession
Added session backward compatibility tests
Modified aseembly build to download old product installs


> Allow the modules to be interoperable with current and older versions of 
> tomcat 7 
> --
>
> Key: GEODE-3434
> URL: https://issues.apache.org/jira/browse/GEODE-3434
> Project: Geode
>  Issue Type: Bug
>  Components: http session
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> There was a change to the attribute field in tomcat (and we made the 
> necessary changes in geode session modules), but that does not allow our 
> session modules to work with older versions of tomcat 7.  We can probably 
> modify the classes to allow use with of the session module jars across 
> different versions of tomcat 7.
> We should probably add tests that run against older versions of geode to 
> allow backwards compatibility between a geode server and a session module jar 
> from a previous release.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3386) Create Error type for KeyedErrorResponse and ErrorResponse

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125956#comment-16125956
 ] 

ASF GitHub Bot commented on GEODE-3386:
---

Github user pivotal-amurmann commented on a diff in the pull request:

https://github.com/apache/geode/pull/700#discussion_r133001811
  
--- Diff: 
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandler.java
 ---
@@ -79,9 +81,10 @@
   private BasicTypes.KeyedErrorResponse 
buildAndLogKeyedError(BasicTypes.Entry entry,
   ProtocolErrorCode errorCode, String message, Exception ex) {
 logger.error(message, ex);
-BasicTypes.ErrorResponse errorResponse = 
BasicTypes.ErrorResponse.newBuilder()
-.setErrorCode(errorCode.codeValue).setMessage(message).build();
-return 
BasicTypes.KeyedErrorResponse.newBuilder().setKey(entry.getKey()).setError(errorResponse)
+
+return 
BasicTypes.KeyedErrorResponse.newBuilder().setKey(entry.getKey())
+.setError(
+
BasicTypes.Error.newBuilder().setErrorCode(errorCode.codeValue).setMessage(message))
--- End diff --

yeah it did 
Tried to reformat it, but it insists on making this bad.




> Create Error type for KeyedErrorResponse and ErrorResponse
> --
>
> Key: GEODE-3386
> URL: https://issues.apache.org/jira/browse/GEODE-3386
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Galen O'Sullivan
>
> For logical separation of the new client API, it will be better to have an 
> Error that is contained by ErrorResponse, rather than having 
> KeyedErrorResponse contain an ErrorResponse.
> In pseudo-protobuf,
> {code}
> PutAllResponse {
>   repeated Entry successes = 1,
>   repeated KeyedErrorResponse errors = 2,
> }
> KeyedErrorResponse {
>   Key,
>   ErrorResponse
> }
> ErrorResponse {
>   string
> }
> {code}
> instead,
> {code}
> KeyedErrorResponse {
>   Key,
>   Error,
> }
> {code}
> and 
> {code}
> ErrorResponse {
> Error
> }
> Error {
> string
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (GEODE-3437) CI failure: ListAndDescribeRegionDUnitTest.listRegions

[Jared Stewart (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jared Stewart updated GEODE-3437:
-
Component/s: tests

> CI failure: ListAndDescribeRegionDUnitTest.listRegions
> --
>
> Key: GEODE-3437
> URL: https://issues.apache.org/jira/browse/GEODE-3437
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, tests
>Reporter: Jared Stewart
>Assignee: Jared Stewart
>
> {noformat}java.lang.AssertionError
>   at org.junit.Assert.fail(Assert.java:86)
>   at org.junit.Assert.assertTrue(Assert.java:41)
>   at org.junit.Assert.assertTrue(Assert.java:52)
>   at 
> org.apache.geode.management.internal.cli.commands.ListAndDescribeRegionDUnitTest.testListRegion(ListAndDescribeRegionDUnitTest.java:206)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
>   at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> 

[jira] [Created] (GEODE-3437) CI failure: ListAndDescribeRegionDUnitTest.listRegions

[Jared Stewart (JIRA)]

Jared Stewart created GEODE-3437:


 Summary: CI failure: ListAndDescribeRegionDUnitTest.listRegions
 Key: GEODE-3437
 URL: https://issues.apache.org/jira/browse/GEODE-3437
 Project: Geode
  Issue Type: Bug
  Components: gfsh
Reporter: Jared Stewart


{noformat}java.lang.AssertionError
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertTrue(Assert.java:52)
at 
org.apache.geode.management.internal.cli.commands.ListAndDescribeRegionDUnitTest.testListRegion(ListAndDescribeRegionDUnitTest.java:206)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at 
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at 
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at 
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at 
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
at 
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
at 
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
at 
org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
at 
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
at 
org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
at 
org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
at 
org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
at 
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
at 
org.gradle.internal.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:377)
at 
org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:54)
at 
org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:40)
at 

[jira] [Assigned] (GEODE-3437) CI failure: ListAndDescribeRegionDUnitTest.listRegions

[Jared Stewart (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jared Stewart reassigned GEODE-3437:


Assignee: Jared Stewart

> CI failure: ListAndDescribeRegionDUnitTest.listRegions
> --
>
> Key: GEODE-3437
> URL: https://issues.apache.org/jira/browse/GEODE-3437
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Reporter: Jared Stewart
>Assignee: Jared Stewart
>
> {noformat}java.lang.AssertionError
>   at org.junit.Assert.fail(Assert.java:86)
>   at org.junit.Assert.assertTrue(Assert.java:41)
>   at org.junit.Assert.assertTrue(Assert.java:52)
>   at 
> org.apache.geode.management.internal.cli.commands.ListAndDescribeRegionDUnitTest.testListRegion(ListAndDescribeRegionDUnitTest.java:206)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
>   at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> 

[jira] [Updated] (GEODE-3184) Clean up session replication testing

[David Anuta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Anuta updated GEODE-3184:
---
Priority: Minor  (was: Major)

> Clean up session replication testing
> 
>
> Key: GEODE-3184
> URL: https://issues.apache.org/jira/browse/GEODE-3184
> Project: Geode
>  Issue Type: Improvement
>  Components: http session
>Reporter: David Anuta
>Priority: Minor
>
> Would be good to review  the code base and make sure methods are properly 
> organized.
> Also, the previous session replication testing is still in place in the 
> extensions folder. This needs to be reviewed and any tests not covered by 
> cargo should be transferred over into the new cargo replication testing. An 
> example of something within this that needs to be cleaned up would be 
> QueryCommand and CommandServlet classes, which are both in the 
> extensions/geode-modules and extensions/session-testing-war projects. the 
> QueryCommand and Command Servlet class within the extensions/geode-modules 
> project could be removed if the previous session tests were all ported to 
> cargo and then removed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (GEODE-3019) Refactor Struct

[Ernest Burghardt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ernest Burghardt resolved GEODE-3019.
-
Resolution: Fixed

> Refactor Struct
> ---
>
> Key: GEODE-3019
> URL: https://issues.apache.org/jira/browse/GEODE-3019
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Jacob S. Barrett
>
> Refactor Struct (geode/Struct.hpp):
> * Replace {{char *}} with {{std::string}}
> * Replace {{m_fieldname}} type with {{std::unordered_map int32_t>}}
> * Add vector for index to field name lookup.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (GEODE-3020) Use standard types in map

[Ernest Burghardt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-3020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ernest Burghardt resolved GEODE-3020.
-
Resolution: Fixed

> Use standard types in map
> -
>
> Key: GEODE-3020
> URL: https://issues.apache.org/jira/browse/GEODE-3020
> Project: Geode
>  Issue Type: New Feature
>  Components: native client
>Reporter: Ernest Burghardt
>
> in Struct.hpp
>   typedef std::unordered_map  dereference_hash,
>  dereference_equal_to>



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3412) Implement a basic authentication mechanism for the new protocol

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125278#comment-16125278
 ] 

ASF GitHub Bot commented on GEODE-3412:
---

Github user galen-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/707#discussion_r132878512
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java
 ---
@@ -72,9 +99,15 @@ public static ServerConnection 
makeServerConnection(Socket s, InternalCache c,
 throw new IOException("Acceptor received unknown communication 
mode: " + communicationMode);
   } else {
 protobufProtocolHandler = findClientProtocolMessageHandler();
-return new GenericProtocolServerConnection(s, c, helper, stats, 
hsTimeout, socketBufferSize,
-communicationModeStr, communicationMode, acceptor, 
protobufProtocolHandler,
-securityService);
+authenticatorClass = findStreamAuthenticator(
+
c.getInternalDistributedSystem().getConfig().getProtobufProtocolAuthenticationMode());
+try {
+  return new GenericProtocolServerConnection(s, c, helper, stats, 
hsTimeout,
+  socketBufferSize, communicationModeStr, communicationMode, 
acceptor,
+  protobufProtocolHandler, securityService, 
authenticatorClass.newInstance());
--- End diff --

We find the class exactly once, and create a new instance per protocol 
instance. We then create an instance per `GenericProtocolServerConnection`. 
This is because the authenticator (unlike the protocol handler) is stateful, so 
we can't share it between connections.


> Implement a basic authentication mechanism for the new protocol
> ---
>
> Key: GEODE-3412
> URL: https://issues.apache.org/jira/browse/GEODE-3412
> Project: Geode
>  Issue Type: New Feature
>  Components: client/server
>Reporter: Brian Rowe
>
> Implement a simple username/password authentication for the new protocol.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3412) Implement a basic authentication mechanism for the new protocol

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125275#comment-16125275
 ] 

ASF GitHub Bot commented on GEODE-3412:
---

Github user galen-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/707#discussion_r132878378
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java
 ---
@@ -63,6 +65,31 @@ private static ClientProtocolMessageHandler 
findClientProtocolMessageHandler() {
 }
   }
 
+  private static Class 
findStreamAuthenticator(
+  String implementationID) {
+if (authenticatorClass != null) {
+  return authenticatorClass;
+}
+
+synchronized (streamAuthenticatorLoadLock) {
--- End diff --

Once `authenticatorClass` is initialized, there will no longer be any 
synchronization necessary in this method. This means that each thread will need 
to synchronize at most once, which means no locking / cache misses.


> Implement a basic authentication mechanism for the new protocol
> ---
>
> Key: GEODE-3412
> URL: https://issues.apache.org/jira/browse/GEODE-3412
> Project: Geode
>  Issue Type: New Feature
>  Components: client/server
>Reporter: Brian Rowe
>
> Implement a simple username/password authentication for the new protocol.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3412) Implement a basic authentication mechanism for the new protocol

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125274#comment-16125274
 ] 

ASF GitHub Bot commented on GEODE-3412:
---

Github user galen-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/707#discussion_r132878110
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionConfig.java
 ---
@@ -2433,6 +2433,25 @@
   String getRedundancyZone();
 
   /**
+   * @since Geode 1.??? TODO FIXME
+   */
+  @ConfigAttribute(type = String.class)
+  String PROTOBUF_PROTOCOL_AUTHENTICATION_MODE_NAME = 
PROTOBUF_PROTOCOL_AUTHENTICATION_MODE;
+  String DEFAULT_PROTOBUF_PROTOCOL_AUTHENTICATION_MODE = "NOOP";
+
+  /**
+   * @since Geode 1.??? TODO FIXME
+   */
+  @ConfigAttributeSetter(name = PROTOBUF_PROTOCOL_AUTHENTICATION_MODE)
+  void setProtobufProtocolAuthenticationMode(String authenticationMode);
+
+  /**
+   * @since Geode 1.??? TODO FIXME
+   */
+  @ConfigAttributeGetter(name = PROTOBUF_PROTOCOL_AUTHENTICATION_MODE)
+  String getProtobufProtocolAuthenticationMode();
+
+  /**
--- End diff --

That's a reasonable choice. Do you think this should be another 
undocumented system property? It might be fine for an alpha, but I don't think 
we should do it for long after that.


> Implement a basic authentication mechanism for the new protocol
> ---
>
> Key: GEODE-3412
> URL: https://issues.apache.org/jira/browse/GEODE-3412
> Project: Geode
>  Issue Type: New Feature
>  Components: client/server
>Reporter: Brian Rowe
>
> Implement a simple username/password authentication for the new protocol.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)