[jira] [Resolved] (GEODE-3567) Exporting configuration from GFSH causes multiple cacheservers to be listed

2017-10-04 Thread Jinmei Liao (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-3567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jinmei Liao resolved GEODE-3567.

   Resolution: Fixed
Fix Version/s: 1.3.0

> Exporting configuration from GFSH causes multiple cacheservers to be listed
> ---
>
> Key: GEODE-3567
> URL: https://issues.apache.org/jira/browse/GEODE-3567
> Project: Geode
>  Issue Type: Bug
>  Components: configuration, gfsh
>Affects Versions: 1.0.0-incubating, 1.1.0, 1.2.0
>Reporter: Udo Kohlmeyer
>Assignee: Jinmei Liao
> Fix For: 1.3.0
>
>
> When running the following steps, ends up causing the `export config` command 
> to list multiple `` entries to be created in the exported 
> `cache.xml`
> {code}
> start locator --name=locator --enable-cluster-configuration=true 
> --J=-Dgemfire.hostname-for-clients=bob
> start server --name=server --use-cluster-configuration=true --server-port=0 
> --hostname-for-clients=bob3
> start server --name=server2 --use-cluster-configuration=true --server-port=0 
> --group=serverGROUP2 --hostname-for-clients=bob2
> export cluster-configuration --zip-file-name=./backup1.zip
> export config --dir=./serversBack1
> stop server --name=server2
> start server --name=server2 --use-cluster-configuration=true --server-port=0 
> --group=serverGROUP2 --hostname-for-clients=bob2
> export config --dir=./serversBack2
> create disk-store --name=diskstore1 --dir=./ds1
> create region --name=TestRegion2 --type=REPLICATE_PERSISTENT_OVERFLOW 
> --disk-store=diskstore1
> create region --name=TestRegion --type=REPLICATE_PERSISTENT_OVERFLOW 
> --disk-store=diskstore1
> create region --name=TestRegion10 --type=REPLICATE --group=serverGROUP2
> export cluster-configuration --zip-file-name=./backup2.zip
> export config --dir=./serversBack3
> stop server --name=server2
> start server --name=server2 --use-cluster-configuration=true --server-port=0 
> --group=serverGROUP2 --hostname-for-clients=bob2
> export config --dir=./serversBack4
> {code}
> Extract from serversBack4 exported cache.xml
> {code}
>  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
> xmlns="http://geode.apache.org/schema/cache; 
> xsi:schemaLocation="http://geode.apache.org/schema/cache 
> http://geode.apache.org/schema/cache/cache-1.0.xsd; version="1.0" 
> is-server="true">
>   
>   
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (GEODE-3567) Exporting configuration from GFSH causes multiple cacheservers to be listed

2017-10-04 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-3567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192467#comment-16192467
 ] 

ASF subversion and git services commented on GEODE-3567:


Commit 080786be95632434955456b499dc224a28636e1b in geode's branch 
refs/heads/develop from [~jinmeiliao]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=080786b ]

GEODE-3567: correctly set the serverPortSetByUser flag


> Exporting configuration from GFSH causes multiple cacheservers to be listed
> ---
>
> Key: GEODE-3567
> URL: https://issues.apache.org/jira/browse/GEODE-3567
> Project: Geode
>  Issue Type: Bug
>  Components: configuration, gfsh
>Affects Versions: 1.0.0-incubating, 1.1.0, 1.2.0
>Reporter: Udo Kohlmeyer
>Assignee: Jinmei Liao
>
> When running the following steps, ends up causing the `export config` command 
> to list multiple `` entries to be created in the exported 
> `cache.xml`
> {code}
> start locator --name=locator --enable-cluster-configuration=true 
> --J=-Dgemfire.hostname-for-clients=bob
> start server --name=server --use-cluster-configuration=true --server-port=0 
> --hostname-for-clients=bob3
> start server --name=server2 --use-cluster-configuration=true --server-port=0 
> --group=serverGROUP2 --hostname-for-clients=bob2
> export cluster-configuration --zip-file-name=./backup1.zip
> export config --dir=./serversBack1
> stop server --name=server2
> start server --name=server2 --use-cluster-configuration=true --server-port=0 
> --group=serverGROUP2 --hostname-for-clients=bob2
> export config --dir=./serversBack2
> create disk-store --name=diskstore1 --dir=./ds1
> create region --name=TestRegion2 --type=REPLICATE_PERSISTENT_OVERFLOW 
> --disk-store=diskstore1
> create region --name=TestRegion --type=REPLICATE_PERSISTENT_OVERFLOW 
> --disk-store=diskstore1
> create region --name=TestRegion10 --type=REPLICATE --group=serverGROUP2
> export cluster-configuration --zip-file-name=./backup2.zip
> export config --dir=./serversBack3
> stop server --name=server2
> start server --name=server2 --use-cluster-configuration=true --server-port=0 
> --group=serverGROUP2 --hostname-for-clients=bob2
> export config --dir=./serversBack4
> {code}
> Extract from serversBack4 exported cache.xml
> {code}
>  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
> xmlns="http://geode.apache.org/schema/cache; 
> xsi:schemaLocation="http://geode.apache.org/schema/cache 
> http://geode.apache.org/schema/cache/cache-1.0.xsd; version="1.0" 
> is-server="true">
>   
>   
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (GEODE-3747) Improve DistributedTest framework with SharedErrorCollector rule

2017-10-04 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-3747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund resolved GEODE-3747.
--
   Resolution: Fixed
Fix Version/s: 1.3.0

> Improve DistributedTest framework with SharedErrorCollector rule
> 
>
> Key: GEODE-3747
> URL: https://issues.apache.org/jira/browse/GEODE-3747
> Project: Geode
>  Issue Type: Improvement
>  Components: tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
> Fix For: 1.3.0
>
>
> Improve the DistributedTest framework with the following changes:
> * SharedErrorCollector to enable asynchronous assertions within every DUnit 
> JVM



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (GEODE-3753) Move CacheRule to dunit.rules package

2017-10-04 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-3753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund reassigned GEODE-3753:


Assignee: Kirk Lund

> Move CacheRule to dunit.rules package
> -
>
> Key: GEODE-3753
> URL: https://issues.apache.org/jira/browse/GEODE-3753
> Project: Geode
>  Issue Type: Improvement
>  Components: tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> Move CacheRule to dunit.rules package. Right now it's by itself in 
> dunit.cache.rules. We should just keep the dunit rules together in one 
> package.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (GEODE-3747) Improve DistributedTest framework with SharedErrorCollector rule

2017-10-04 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-3747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192227#comment-16192227
 ] 

ASF subversion and git services commented on GEODE-3747:


Commit 9f9a58cb88330635f71830f622febdc7c5e7072e in geode's branch 
refs/heads/develop from [~apa...@the9muses.net]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=9f9a58c ]

GEODE-3747: add SharedErrorCollector rule

* use for assertions in callbacks and in multiple JVMs
* minor cleanup of related classes


> Improve DistributedTest framework with SharedErrorCollector rule
> 
>
> Key: GEODE-3747
> URL: https://issues.apache.org/jira/browse/GEODE-3747
> Project: Geode
>  Issue Type: Improvement
>  Components: tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> Improve the DistributedTest framework with the following changes:
> * SharedErrorCollector to enable asynchronous assertions within every DUnit 
> JVM



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (GEODE-3747) Improve DistributedTest framework with SharedErrorCollector rule

2017-10-04 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-3747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund reassigned GEODE-3747:


Assignee: Kirk Lund

> Improve DistributedTest framework with SharedErrorCollector rule
> 
>
> Key: GEODE-3747
> URL: https://issues.apache.org/jira/browse/GEODE-3747
> Project: Geode
>  Issue Type: Improvement
>  Components: tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> Improve the DistributedTest framework with the following changes:
> * SharedErrorCollector to enable asynchronous assertions within every DUnit 
> JVM



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (GEODE-3753) Move CacheRule to dunit.rules package

2017-10-04 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-3753:


 Summary: Move CacheRule to dunit.rules package
 Key: GEODE-3753
 URL: https://issues.apache.org/jira/browse/GEODE-3753
 Project: Geode
  Issue Type: Improvement
  Components: tests
Reporter: Kirk Lund


Move CacheRule to dunit.rules package. Right now it's by itself in 
dunit.cache.rules. We should just keep the dunit rules together in one package.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (GEODE-3752) CI failure: LuceneSearchWithRollingUpgradeDUnit.luceneQueryReturnsCorrectResultsAfterServersRollOverOnPartitionRegion failed with ClassNotFoundException

2017-10-04 Thread Barry Oglesby (JIRA)
Barry Oglesby created GEODE-3752:


 Summary: CI failure: 
LuceneSearchWithRollingUpgradeDUnit.luceneQueryReturnsCorrectResultsAfterServersRollOverOnPartitionRegion
 failed with ClassNotFoundException
 Key: GEODE-3752
 URL: https://issues.apache.org/jira/browse/GEODE-3752
 Project: Geode
  Issue Type: Bug
  Components: lucene
Reporter: Barry Oglesby


{noformat}
org.apache.geode.cache.lucene.LuceneSearchWithRollingUpgradeDUnit > 
luceneQueryReturnsCorrectResultsAfterServersRollOverOnPartitionRegion[0] FAILED
org.apache.geode.test.dunit.RMIException: While invoking 
org.apache.geode.cache.lucene.LuceneSearchWithRollingUpgradeDUnit$6.run in VM 0 
running on Host 22736e3d23d7 with 4 VMs with version 120
at org.apache.geode.test.dunit.VM.execute(VM.java:469)
at org.apache.geode.test.dunit.VM.invoke(VM.java:386)
at org.apache.geode.test.dunit.VM.invoke(VM.java:363)
at org.apache.geode.test.dunit.VM.invoke(VM.java:308)
at 
org.apache.geode.cache.lucene.LuceneSearchWithRollingUpgradeDUnit.invokeRunnableInVMs(LuceneSearchWithRollingUpgradeDUnit.java:560)
at 
org.apache.geode.cache.lucene.LuceneSearchWithRollingUpgradeDUnit.executeLuceneQueryWithServerRollOvers(LuceneSearchWithRollingUpgradeDUnit.java:427)
at 
org.apache.geode.cache.lucene.LuceneSearchWithRollingUpgradeDUnit.luceneQueryReturnsCorrectResultsAfterServersRollOverOnPartitionRegion(LuceneSearchWithRollingUpgradeDUnit.java:132)

Caused by:
java.rmi.UnmarshalException: error unmarshalling return; nested 
exception is: 
java.lang.ClassNotFoundException: 
org.apache.geode.internal.process.ClusterConfigurationNotAvailableException (no 
security manager: RMI class loader disabled)
at sun.rmi.server.UnicastRef.invoke(UnicastRef.java:194)
at 
java.rmi.server.RemoteObjectInvocationHandler.invokeRemoteMethod(RemoteObjectInvocationHandler.java:227)
at 
java.rmi.server.RemoteObjectInvocationHandler.invoke(RemoteObjectInvocationHandler.java:179)
at com.sun.proxy.$Proxy37.executeMethodOnObject(Unknown Source)
at org.apache.geode.test.dunit.VM.execute(VM.java:466)
... 6 more

Caused by:
java.lang.ClassNotFoundException: 
org.apache.geode.internal.process.ClusterConfigurationNotAvailableException (no 
security manager: RMI class loader disabled)
at 
sun.rmi.server.LoaderHandler.loadClass(LoaderHandler.java:396)
at 
sun.rmi.server.LoaderHandler.loadClass(LoaderHandler.java:186)
at 
java.rmi.server.RMIClassLoader$2.loadClass(RMIClassLoader.java:637)
at 
java.rmi.server.RMIClassLoader.loadClass(RMIClassLoader.java:264)
at 
sun.rmi.server.MarshalInputStream.resolveClass(MarshalInputStream.java:219)
at 
java.io.ObjectInputStream.readNonProxyDesc(ObjectInputStream.java:1826)
at 
java.io.ObjectInputStream.readClassDesc(ObjectInputStream.java:1713)
at 
java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:2000)
at 
java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1535)
at 
java.io.ObjectInputStream.defaultReadFields(ObjectInputStream.java:2245)
at 
java.io.ObjectInputStream.defaultReadObject(ObjectInputStream.java:552)
at java.lang.Throwable.readObject(Throwable.java:914)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
java.io.ObjectStreamClass.invokeReadObject(ObjectStreamClass.java:1058)
at 
java.io.ObjectInputStream.readSerialData(ObjectInputStream.java:2136)
at 
java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:2027)
at 
java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1535)
at 
java.io.ObjectInputStream.defaultReadFields(ObjectInputStream.java:2245)
at 
java.io.ObjectInputStream.readSerialData(ObjectInputStream.java:2169)
at 
java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:2027)
at 
java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1535)
at 
java.io.ObjectInputStream.defaultReadFields(ObjectInputStream.java:2245)
at 
java.io.ObjectInputStream.defaultReadObject(ObjectInputStream.java:552)
at java.lang.Throwable.readObject(Throwable.java:914)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

[jira] [Resolved] (GEODE-3695) Remove unused protobuf messages from new protocol

2017-10-04 Thread Brian Baynes (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-3695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brian Baynes resolved GEODE-3695.
-
Resolution: Done

> Remove unused protobuf messages from new protocol
> -
>
> Key: GEODE-3695
> URL: https://issues.apache.org/jira/browse/GEODE-3695
> Project: Geode
>  Issue Type: Task
>  Components: client/server
>Reporter: Brian Baynes
>Assignee: Bruce Schuchardt
>
> In the interest of clarity and to avoid confusion, remove any unused protobuf 
> messages/handlers from the new protocol code (e.g., create/destroy region 
> messages).  We'll add these back as we implement the messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (GEODE-3742) CI failure: DeltaPropagationDUnitTest.testBug40165ClientReconnects FAILED with no queus server is available

2017-10-04 Thread Barry Oglesby (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-3742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192193#comment-16192193
 ] 

Barry Oglesby commented on GEODE-3742:
--

Its possible its not waiting long enough for something on the server, but its 
not clear what that is. Its also possible that there is some interaction 
between the Message Dispatcher thread and the ServerConnection thread that is 
preventing CacheClientProxy from completely pausing.

The 'Unsuccessfully registered' message is coming from CacheClientNotifier 
registerClient.

This message is logged when {{responseByte != 
CommunicationMode.SuccessfulServerToClient.getModeNumber()}}.

Every time that is true, a warning is logged except in one case. That is when 
it can't initialize a CacheClientProxy from that client. In that case, the 
message that is created but not logged is: 'A previous connection attempt from 
this client is still being processed.'

I changed this method to log the warning in the one case it isn't. I also 
changed the 'Unsuccessfully registered' message to include the response code.

This message is also sent back to the client in CacheClientNotifier 
writeMessage. Unfortunately, its ignored on the client.

The CacheClientUpdater constructor is the place that ignores this message. It 
catches and logs several exceptions including ConnectException, SSLException, 
GemFireSecurityException, IOException and ClassNotFoundException.

It doesn't deal with ServerRefusedConnectionException which is the exception 
created in this case.

Instead this exception is handled in QueueManagerImpl initializeQueueConnection 
like:
{noformat}
} catch (Exception e) {
  if (logger.isDebugEnabled()) {
logger.debug("error creating subscription connection to server {}", 
connection.getEndpoint(), e);
  }
}
{noformat}
Basically, the message being returned from the server is lost, so I also added 
a catch block in CacheClientUpdater constructor to log and rethrow the 
ServerRefusedConnectionException which now logs something like:
{noformat}
[warn 2017/10/04 15:45:04.880 PDT  tid=0x1] Cache Client Updater Thread  
on boglesbymac-2(28921):32770 port 29869 (localhost:29869): Caught 
following exception while attempting to create a server-to-client communication 
socket and will exit: 
org.apache.geode.cache.client.ServerRefusedConnectionException: :29869 refused connection: A previous connection attempt from this 
client is still being processed: 
identity(192.168.2.5(28918:loner):52814:275690e9,connection=1,durableAttributes=DurableClientAttributes[id=testBug40165ClientReconnects_client;
 timeout=60])
{noformat}


> CI failure: DeltaPropagationDUnitTest.testBug40165ClientReconnects FAILED 
> with no queus server is available
> ---
>
> Key: GEODE-3742
> URL: https://issues.apache.org/jira/browse/GEODE-3742
> Project: Geode
>  Issue Type: Bug
>  Components: client queues
>Reporter: Hitesh Khamesra
>
> org.apache.geode.internal.cache.DeltaPropagationDUnitTest > 
> testBug40165ClientReconnects FAILED
> org.apache.geode.cache.NoSubscriptionServersAvailableException: 
> org.apache.geode.cache.NoSubscriptionServersAvailableException: Could not 
> initialize a primary queue on startup. No queue servers available.
> at 
> org.apache.geode.cache.client.internal.QueueManagerImpl.getAllConnections(QueueManagerImpl.java:190)
> at 
> org.apache.geode.cache.client.internal.OpExecutorImpl.executeOnQueuesAndReturnPrimaryResult(OpExecutorImpl.java:540)
> at 
> org.apache.geode.cache.client.internal.PoolImpl.executeOnQueuesAndReturnPrimaryResult(PoolImpl.java:842)
> at 
> org.apache.geode.cache.client.internal.RegisterInterestOp.execute(RegisterInterestOp.java:58)
> at 
> org.apache.geode.cache.client.internal.ServerRegionProxy.registerInterest(ServerRegionProxy.java:359)
> at 
> org.apache.geode.internal.cache.LocalRegion.processSingleInterest(LocalRegion.java:3734)
> at 
> org.apache.geode.internal.cache.LocalRegion.registerInterest(LocalRegion.java:3823)
> at 
> org.apache.geode.internal.cache.LocalRegion.registerInterest(LocalRegion.java:3625)
> at 
> org.apache.geode.internal.cache.LocalRegion.registerInterest(LocalRegion.java:3620)
> at 
> org.apache.geode.internal.cache.LocalRegion.registerInterest(LocalRegion.java:3615)
> at 
> org.apache.geode.internal.cache.DeltaPropagationDUnitTest.createDurableCacheClient(DeltaPropagationDUnitTest.java:1372)
> at 
> org.apache.geode.internal.cache.DeltaPropagationDUnitTest.testBug40165ClientReconnects(DeltaPropagationDUnitTest.java:698)
> Caused by:
> org.apache.geode.cache.NoSubscriptionServersAvailableException: Could 
> not initialize a primary queue on 

[jira] [Commented] (GEODE-3742) CI failure: DeltaPropagationDUnitTest.testBug40165ClientReconnects FAILED with no queus server is available

2017-10-04 Thread Barry Oglesby (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-3742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192190#comment-16192190
 ] 

Barry Oglesby commented on GEODE-3742:
--

The successful test logs these messages:

The client Cache Client Updater thread disconnects:
{noformat}
[info 2017/10/04 11:28:48.276 PDT :32770 port 21569> tid=0x5b] GemFireCache[id = 
1896622931; isClosing = true; isShutDownAll = false; created = Wed Oct 04 
11:28:47 PDT 2017; server = false; copyOnRead = false; lockLease = 120; 
lockTimeout = 60]: Now closing.
{noformat}
The server Message Dispatcher thread pauses once:
{noformat}
[vm0] [info 2017/10/04 11:28:48.303 PDT  
tid=0x74] available ids = 102 , isEmptyAckList =true, peekInitialized = true

[vm0] [info 2017/10/04 11:28:48.303 PDT  
tid=0x74] 
CacheClientProxy[identity(192.168.2.5(21844:loner):64929:03b3a5e8,connection=1,durableAttributes=DurableClientAttributes[id=testBug40165ClientReconnects_client;
 timeout=60]); port=64932; primary=true; version=GEODE 1.3.0] : Pausing 
processing
{noformat}
The server ServerConnection thread keeps the CacheClientProxy for 60 seconds 
(this message is not logged in the failed test):
 {noformat}
[vm0] [info 2017/10/04 11:28:48.304 PDT  tid=0x70] CacheClientNotifier: Keeping proxy for durable client named 
testBug40165ClientReconnects_client for 60 seconds 
CacheClientProxy[identity(192.168.2.5(21844:loner):64929:03b3a5e8,connection=1,durableAttributes=DurableClientAttributes[id=testBug40165ClientReconnects_client;
 timeout=60]); port=64932; primary=true; version=GEODE 1.3.0].
{noformat}
The client reconnects successfully:
{noformat}
[vm0] [info 2017/10/04 11:28:53.014 PDT  tid=0x6f] 
CacheClientProxy[identity(192.168.2.5(21844:loner):64934:e9c9a5e8,connection=1,durableAttributes=DurableClientAttributes[id=testBug40165ClientReconnects_client;
 timeout=60]); port=64936; primary=true; version=GEODE 1.3.0]: Cancelling 
expiration task since the client has reconnected.

[info 2017/10/04 11:28:53.015 PDT :32770 port 21569> tid=0x89] Cache Client Updater 
Thread  on boglesbymac-2(21847):32770 port 21569 (localhost:21569) : ready 
to process messages.

[vm0] [info 2017/10/04 11:28:53.027 PDT  tid=0x79] 
CacheClientProxy[identity(192.168.2.5(21844:loner):64934:e9c9a5e8,connection=1,durableAttributes=DurableClientAttributes[id=testBug40165ClientReconnects_client;
 timeout=60]); port=64936; primary=true; version=GEODE 1.3.0] : Resuming 
processing
{noformat}


> CI failure: DeltaPropagationDUnitTest.testBug40165ClientReconnects FAILED 
> with no queus server is available
> ---
>
> Key: GEODE-3742
> URL: https://issues.apache.org/jira/browse/GEODE-3742
> Project: Geode
>  Issue Type: Bug
>  Components: client queues
>Reporter: Hitesh Khamesra
>
> org.apache.geode.internal.cache.DeltaPropagationDUnitTest > 
> testBug40165ClientReconnects FAILED
> org.apache.geode.cache.NoSubscriptionServersAvailableException: 
> org.apache.geode.cache.NoSubscriptionServersAvailableException: Could not 
> initialize a primary queue on startup. No queue servers available.
> at 
> org.apache.geode.cache.client.internal.QueueManagerImpl.getAllConnections(QueueManagerImpl.java:190)
> at 
> org.apache.geode.cache.client.internal.OpExecutorImpl.executeOnQueuesAndReturnPrimaryResult(OpExecutorImpl.java:540)
> at 
> org.apache.geode.cache.client.internal.PoolImpl.executeOnQueuesAndReturnPrimaryResult(PoolImpl.java:842)
> at 
> org.apache.geode.cache.client.internal.RegisterInterestOp.execute(RegisterInterestOp.java:58)
> at 
> org.apache.geode.cache.client.internal.ServerRegionProxy.registerInterest(ServerRegionProxy.java:359)
> at 
> org.apache.geode.internal.cache.LocalRegion.processSingleInterest(LocalRegion.java:3734)
> at 
> org.apache.geode.internal.cache.LocalRegion.registerInterest(LocalRegion.java:3823)
> at 
> org.apache.geode.internal.cache.LocalRegion.registerInterest(LocalRegion.java:3625)
> at 
> org.apache.geode.internal.cache.LocalRegion.registerInterest(LocalRegion.java:3620)
> at 
> org.apache.geode.internal.cache.LocalRegion.registerInterest(LocalRegion.java:3615)
> at 
> org.apache.geode.internal.cache.DeltaPropagationDUnitTest.createDurableCacheClient(DeltaPropagationDUnitTest.java:1372)
> at 
> org.apache.geode.internal.cache.DeltaPropagationDUnitTest.testBug40165ClientReconnects(DeltaPropagationDUnitTest.java:698)
> Caused by:
> org.apache.geode.cache.NoSubscriptionServersAvailableException: Could 
> not initialize a primary queue on startup. No queue servers available.
> at 
> org.apache.geode.cache.client.internal.QueueManagerImpl.initializeConnections(QueueManagerImpl.java:592)
> 

[jira] [Commented] (GEODE-3742) CI failure: DeltaPropagationDUnitTest.testBug40165ClientReconnects FAILED with no queus server is available

2017-10-04 Thread Barry Oglesby (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-3742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192189#comment-16192189
 ] 

Barry Oglesby commented on GEODE-3742:
--

This test passes regularly for me, but the difference in messages logged 
between a successful test and an unsuccessful test is interesting. The failed 
test logs messages that it shouldn't and doesn't log other messages that it 
should.

I'm not sure this is just a timing issue even though the test currently does:
{noformat}
// Step 5
// verifyDurableClientDisconnected();
Thread.sleep(5000);
{noformat}

Here are relevant log messages in the failed test:

The client Cache Client Updater thread disconnects:
{noformat}
[info 2017/10/02 23:54:49.072 UTC :32770 port 22032> tid=0x4d3] GemFireCache[id = 
1517909714; isClosing = true; isShutDownAll = false; created = Mon Oct 02 
23:54:48 UTC 2017; server = false; copyOnRead = false; lockLease = 120; 
lockTimeout = 60]: Now closing.
{noformat}
The server Message Dispatcher thread catches and logs an IOException:
{noformat}
[vm0] [warn 2017/10/02 23:54:49.078 UTC  
tid=0x2d3d] 
CacheClientProxy[identity(172.17.0.2(1:loner):55502:bd7683df,connection=1,durableAttributes=DurableClientAttributes[id=testBug40165ClientReconnects_client;
 timeout=60]); port=55506; primary=true; version=GEODE 1.3.0]: Proxy closing 
due to unexpected reset on socket connection.
{noformat}
The server Message Dispatcher thread attempts to pause twice (the second set of 
messages shouldn't happen):
{noformat}
[vm0] [info 2017/10/02 23:54:49.078 UTC  
tid=0x2d3d] available ids = 102 , isEmptyAckList =true, peekInitialized = true

[vm0] [info 2017/10/02 23:54:49.079 UTC  
tid=0x2d3d] 
CacheClientProxy[identity(172.17.0.2(1:loner):55502:bd7683df,connection=1,durableAttributes=DurableClientAttributes[id=testBug40165ClientReconnects_client;
 timeout=60]); port=55506; primary=true; version=GEODE 1.3.0] : Pausing 
processing

[vm0] [info 2017/10/02 23:54:49.079 UTC  
tid=0x2d3d] available ids = 102 , isEmptyAckList =true, peekInitialized = true

[vm0] [info 2017/10/02 23:54:49.079 UTC  
tid=0x2d3d] 
CacheClientProxy[identity(172.17.0.2(1:loner):55502:bd7683df,connection=1,durableAttributes=DurableClientAttributes[id=testBug40165ClientReconnects_client;
 timeout=60]); port=55506; primary=true; version=GEODE 1.3.0] : Pausing 
processing
{noformat}
The server logs an 'Unsuccessfully registered' message when the client attempts 
to re-connect:
{noformat}
[vm0] [warn 2017/10/02 23:54:53.794 UTC  tid=0x2d39] CacheClientNotifier: Unsuccessfully registered client 
with identifier  
identity(172.17.0.2(1:loner):55872:2b8b83df,connection=1,durableAttributes=DurableClientAttributes[id=testBug40165ClientReconnects_client;
 timeout=60])
{noformat}
The client logs error messages when it can't reconnect:
{noformat}
[error 2017/10/02 23:54:53.794 UTC  tid=0x16] Could not find any 
server to create primary client queue on. Number of excluded servers is 1 and 
exception is no exception.

[error 2017/10/02 23:54:53.795 UTC  tid=0x16] Could not initialize 
a primary queue on startup. No queue servers available.
{noformat}


> CI failure: DeltaPropagationDUnitTest.testBug40165ClientReconnects FAILED 
> with no queus server is available
> ---
>
> Key: GEODE-3742
> URL: https://issues.apache.org/jira/browse/GEODE-3742
> Project: Geode
>  Issue Type: Bug
>  Components: client queues
>Reporter: Hitesh Khamesra
>
> org.apache.geode.internal.cache.DeltaPropagationDUnitTest > 
> testBug40165ClientReconnects FAILED
> org.apache.geode.cache.NoSubscriptionServersAvailableException: 
> org.apache.geode.cache.NoSubscriptionServersAvailableException: Could not 
> initialize a primary queue on startup. No queue servers available.
> at 
> org.apache.geode.cache.client.internal.QueueManagerImpl.getAllConnections(QueueManagerImpl.java:190)
> at 
> org.apache.geode.cache.client.internal.OpExecutorImpl.executeOnQueuesAndReturnPrimaryResult(OpExecutorImpl.java:540)
> at 
> org.apache.geode.cache.client.internal.PoolImpl.executeOnQueuesAndReturnPrimaryResult(PoolImpl.java:842)
> at 
> org.apache.geode.cache.client.internal.RegisterInterestOp.execute(RegisterInterestOp.java:58)
> at 
> org.apache.geode.cache.client.internal.ServerRegionProxy.registerInterest(ServerRegionProxy.java:359)
> at 
> org.apache.geode.internal.cache.LocalRegion.processSingleInterest(LocalRegion.java:3734)
> at 
> org.apache.geode.internal.cache.LocalRegion.registerInterest(LocalRegion.java:3823)
> at 
> org.apache.geode.internal.cache.LocalRegion.registerInterest(LocalRegion.java:3625)
> at 
> org.apache.geode.internal.cache.LocalRegion.registerInterest(LocalRegion.java:3620)
> 

[jira] [Updated] (GEODE-3751) Refactor: ClientProtocolService, ClientStreamProcessor

2017-10-04 Thread Galen O'Sullivan (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-3751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Galen O'Sullivan updated GEODE-3751:

Description: 
The protobuf protocol logic is currently partly in 
{{GenericProtocolServerConnection}}, but authentication shouldn't really be 
assumed if it's a generic connection. Refactoring to a single service, with a 
pipeline that holds handshake/auth/message processing state, will allow us to 
improve authentication/authorization as well as add a handshake with much less 
headache.

This is blocking GEODE-3705 and GEODE-3739.

  was:The protobuf protocol logic is currently partly in 
{{GenericProtocolServerConnection}}, but authentication shouldn't really be 
assumed if it's a generic connection. Refactoring to a single service, with a 
pipeline that holds handshake/auth/message processing state, will allow us to 
improve authentication/authorization as well as add a handshake with much less 
headache.


> Refactor: ClientProtocolService, ClientStreamProcessor
> --
>
> Key: GEODE-3751
> URL: https://issues.apache.org/jira/browse/GEODE-3751
> Project: Geode
>  Issue Type: Improvement
>  Components: client/server
>Reporter: Galen O'Sullivan
>
> The protobuf protocol logic is currently partly in 
> {{GenericProtocolServerConnection}}, but authentication shouldn't really be 
> assumed if it's a generic connection. Refactoring to a single service, with a 
> pipeline that holds handshake/auth/message processing state, will allow us to 
> improve authentication/authorization as well as add a handshake with much 
> less headache.
> This is blocking GEODE-3705 and GEODE-3739.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (GEODE-3733) CI failure: CacheMaxConnectionJUnitTest.testNewProtocolRespectsMaxConnectionLimit_notSelector FAILED

2017-10-04 Thread Udo Kohlmeyer (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Udo Kohlmeyer updated GEODE-3733:
-
Component/s: client/server

> CI failure: 
> CacheMaxConnectionJUnitTest.testNewProtocolRespectsMaxConnectionLimit_notSelector
>  FAILED
> 
>
> Key: GEODE-3733
> URL: https://issues.apache.org/jira/browse/GEODE-3733
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Hitesh Khamesra
>Assignee: Udo Kohlmeyer
>
> org.apache.geode.internal.protocol.acceptance.CacheMaxConnectionJUnitTest > 
> testNewProtocolRespectsMaxConnectionLimit_notSelector FAILED
> java.lang.AssertionError: expected null, but 
> was:
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotNull(Assert.java:755)
> at org.junit.Assert.assertNull(Assert.java:737)
> at org.junit.Assert.assertNull(Assert.java:747)
> at 
> org.apache.geode.internal.protocol.acceptance.CacheMaxConnectionJUnitTest.validateSocketCreationAndDestruction(CacheMaxConnectionJUnitTest.java:206)
> at 
> org.apache.geode.internal.protocol.acceptance.CacheMaxConnectionJUnitTest.testNewProtocolRespectsMaxConnectionLimit(CacheMaxConnectionJUnitTest.java:154)
> at 
> org.apache.geode.internal.protocol.acceptance.CacheMaxConnectionJUnitTest.testNewProtocolRespectsMaxConnectionLimit_notSelector(CacheMaxConnectionJUnitTest.java:123)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (GEODE-3733) CI failure: CacheMaxConnectionJUnitTest.testNewProtocolRespectsMaxConnectionLimit_notSelector FAILED

2017-10-04 Thread Udo Kohlmeyer (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Udo Kohlmeyer reassigned GEODE-3733:


Assignee: Udo Kohlmeyer

> CI failure: 
> CacheMaxConnectionJUnitTest.testNewProtocolRespectsMaxConnectionLimit_notSelector
>  FAILED
> 
>
> Key: GEODE-3733
> URL: https://issues.apache.org/jira/browse/GEODE-3733
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Hitesh Khamesra
>Assignee: Udo Kohlmeyer
>
> org.apache.geode.internal.protocol.acceptance.CacheMaxConnectionJUnitTest > 
> testNewProtocolRespectsMaxConnectionLimit_notSelector FAILED
> java.lang.AssertionError: expected null, but 
> was:
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotNull(Assert.java:755)
> at org.junit.Assert.assertNull(Assert.java:737)
> at org.junit.Assert.assertNull(Assert.java:747)
> at 
> org.apache.geode.internal.protocol.acceptance.CacheMaxConnectionJUnitTest.validateSocketCreationAndDestruction(CacheMaxConnectionJUnitTest.java:206)
> at 
> org.apache.geode.internal.protocol.acceptance.CacheMaxConnectionJUnitTest.testNewProtocolRespectsMaxConnectionLimit(CacheMaxConnectionJUnitTest.java:154)
> at 
> org.apache.geode.internal.protocol.acceptance.CacheMaxConnectionJUnitTest.testNewProtocolRespectsMaxConnectionLimit_notSelector(CacheMaxConnectionJUnitTest.java:123)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (GEODE-3751) Refactor: ClientProtocolService, ClientStreamProcessor

2017-10-04 Thread Galen O'Sullivan (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-3751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Galen O'Sullivan reassigned GEODE-3751:
---

Assignee: Galen O'Sullivan

> Refactor: ClientProtocolService, ClientStreamProcessor
> --
>
> Key: GEODE-3751
> URL: https://issues.apache.org/jira/browse/GEODE-3751
> Project: Geode
>  Issue Type: Improvement
>  Components: client/server
>Reporter: Galen O'Sullivan
>Assignee: Galen O'Sullivan
>
> The protobuf protocol logic is currently partly in 
> {{GenericProtocolServerConnection}}, but authentication shouldn't really be 
> assumed if it's a generic connection. Refactoring to a single service, with a 
> pipeline that holds handshake/auth/message processing state, will allow us to 
> improve authentication/authorization as well as add a handshake with much 
> less headache.
> This is blocking GEODE-3705 and GEODE-3739.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (GEODE-3751) Refactor: ClientProtocolService, ClientStreamProcessor

2017-10-04 Thread Galen O'Sullivan (JIRA)
Galen O'Sullivan created GEODE-3751:
---

 Summary: Refactor: ClientProtocolService, ClientStreamProcessor
 Key: GEODE-3751
 URL: https://issues.apache.org/jira/browse/GEODE-3751
 Project: Geode
  Issue Type: Bug
  Components: client/server
Reporter: Galen O'Sullivan


The protobuf protocol logic is currently partly in 
{{GenericProtocolServerConnection}}, but authentication shouldn't really be 
assumed if it's a generic connection. Refactoring to a single service, with a 
pipeline that holds handshake/auth/message processing state, will allow us to 
improve authentication/authorization as well as add a handshake with much less 
headache.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (GEODE-3542) Show Metrics fails when all parameters are provided

2017-10-04 Thread Jens Deppe (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-3542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jens Deppe reassigned GEODE-3542:
-

Assignee: Jens Deppe  (was: Patrick Rhomberg)

> Show Metrics fails when all parameters are provided
> ---
>
> Key: GEODE-3542
> URL: https://issues.apache.org/jira/browse/GEODE-3542
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Reporter: Patrick Rhomberg
>Assignee: Jens Deppe
> Fix For: 1.3.0
>
>
> The `show metrics` command accepts optional parameters `member`, `port`, and 
> `region`.
> When all three provided, the command returns the error
> {noformat}
> If the --port parameter is specified, then the --member parameter must also 
> be specified.
> {noformat}
> If this is actually an invalid combination of parameters, the reported error 
> should be updated to indicate the true problem.  Otherwise, correct reporting 
> of metrics should occur.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (GEODE-3723) Reconsider using Optional as the parameter for getRequiredPermissions

2017-10-04 Thread Jens Deppe (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-3723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jens Deppe resolved GEODE-3723.
---
Resolution: Fixed

> Reconsider using Optional as the parameter for getRequiredPermissions
> -
>
> Key: GEODE-3723
> URL: https://issues.apache.org/jira/browse/GEODE-3723
> Project: Geode
>  Issue Type: Bug
>  Components: security
>Reporter: Dan Smith
>Assignee: Jens Deppe
> Fix For: 1.3.0
>
>
> The new method on function, getRequiredPermissions takes an Optional 
> as parameter.
> At point point, we added a parameterized type to the function interface 
> (Function). However, if someone tries to implement Function without the 
> type (eg implements Function instead of implemments Function), then 
> they get the below compilation error:
> {noformat}
> Error:(85, 41) java: name clash: 
> getRequiredPermissions(java.util.Optional) in 
> org.apache.geode.cache.lucene.internal.distributed.WaitUntilFlushedFunction 
> and getRequiredPermissions(java.util.Optional) in 
> org.apache.geode.cache.execute.Function have the same erasure, yet neither 
> overrides the other
> {noformat}
> In addition to this annoyance Optional is generally discouraged as a 
> parameter to a method in favor of method overloading. At least my IDE is 
> providing a warning to that effect. Maybe having an overloaded method for 
> getRequiredPermissions would be better?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (GEODE-3723) Reconsider using Optional as the parameter for getRequiredPermissions

2017-10-04 Thread Jens Deppe (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-3723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jens Deppe reassigned GEODE-3723:
-

Assignee: Jens Deppe  (was: Karen Smoler Miller)

> Reconsider using Optional as the parameter for getRequiredPermissions
> -
>
> Key: GEODE-3723
> URL: https://issues.apache.org/jira/browse/GEODE-3723
> Project: Geode
>  Issue Type: Bug
>  Components: security
>Reporter: Dan Smith
>Assignee: Jens Deppe
> Fix For: 1.3.0
>
>
> The new method on function, getRequiredPermissions takes an Optional 
> as parameter.
> At point point, we added a parameterized type to the function interface 
> (Function). However, if someone tries to implement Function without the 
> type (eg implements Function instead of implemments Function), then 
> they get the below compilation error:
> {noformat}
> Error:(85, 41) java: name clash: 
> getRequiredPermissions(java.util.Optional) in 
> org.apache.geode.cache.lucene.internal.distributed.WaitUntilFlushedFunction 
> and getRequiredPermissions(java.util.Optional) in 
> org.apache.geode.cache.execute.Function have the same erasure, yet neither 
> overrides the other
> {noformat}
> In addition to this annoyance Optional is generally discouraged as a 
> parameter to a method in favor of method overloading. At least my IDE is 
> providing a warning to that effect. Maybe having an overloaded method for 
> getRequiredPermissions would be better?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (GEODE-3542) Show Metrics fails when all parameters are provided

2017-10-04 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-3542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192133#comment-16192133
 ] 

ASF subversion and git services commented on GEODE-3542:


Commit a29f5466b736ee0aedd581fb817472d1b68742b2 in geode's branch 
refs/heads/develop from [~jens.deppe]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=a29f546 ]

GEODE-3542: Add null guards in the case of invalid commands

- Prior commits seem to have introduced some instability


> Show Metrics fails when all parameters are provided
> ---
>
> Key: GEODE-3542
> URL: https://issues.apache.org/jira/browse/GEODE-3542
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>
> The `show metrics` command accepts optional parameters `member`, `port`, and 
> `region`.
> When all three provided, the command returns the error
> {noformat}
> If the --port parameter is specified, then the --member parameter must also 
> be specified.
> {noformat}
> If this is actually an invalid combination of parameters, the reported error 
> should be updated to indicate the true problem.  Otherwise, correct reporting 
> of metrics should occur.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (GEODE-3726) Remove "Submit an Issue" from the Geode webpage

2017-10-04 Thread Dave Barnes (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-3726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Barnes resolved GEODE-3726.

   Resolution: Fixed
Fix Version/s: 1.3.0

> Remove "Submit an Issue" from the Geode webpage
> ---
>
> Key: GEODE-3726
> URL: https://issues.apache.org/jira/browse/GEODE-3726
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, web-content
>Reporter: Dave Barnes
>Assignee: Dave Barnes
>Priority: Minor
> Fix For: 1.3.0
>
>
> Based on a discussion on the dev mailing list, consensus is:
> - remove the "Submit an Issue" button on the webpage
> - direct questions to the Users mailing list



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (GEODE-3539) Add more test coverage for p2p commands

2017-10-04 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192127#comment-16192127
 ] 

ASF subversion and git services commented on GEODE-3539:


Commit 739e80d63ced113eda504f2912b854c791a5aa02 in geode's branch 
refs/heads/develop from [~khowe]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=739e80d ]

GEODE-3539: Enhanced test coverage for alter runtime command options


> Add more test coverage for p2p commands
> ---
>
> Key: GEODE-3539
> URL: https://issues.apache.org/jira/browse/GEODE-3539
> Project: Geode
>  Issue Type: Improvement
>  Components: gfsh
>Reporter: Jinmei Liao
>
> Add more command tests that would eventually get rid of the legacy tests.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (GEODE-3539) Add more test coverage for p2p commands

2017-10-04 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192128#comment-16192128
 ] 

ASF subversion and git services commented on GEODE-3539:


Commit 22b02c73e52795ff9175b693a5e3121d0d3618b7 in geode's branch 
refs/heads/develop from [~khowe]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=22b02c7 ]

GEODE-3539: refactored to reduce code duplication


> Add more test coverage for p2p commands
> ---
>
> Key: GEODE-3539
> URL: https://issues.apache.org/jira/browse/GEODE-3539
> Project: Geode
>  Issue Type: Improvement
>  Components: gfsh
>Reporter: Jinmei Liao
>
> Add more command tests that would eventually get rid of the legacy tests.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (GEODE-3726) Remove "Submit an Issue" from the Geode webpage

2017-10-04 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-3726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192125#comment-16192125
 ] 

ASF subversion and git services commented on GEODE-3726:


Commit 5cc4df64c3f1d9b634862bb097567e842ceba22c in geode-site's branch 
refs/heads/asf-site from [~dbarnes97]
[ https://gitbox.apache.org/repos/asf?p=geode-site.git;h=5cc4df6 ]

GEODE-3726: Remove "Submit an Issue" from the Geode webpage


> Remove "Submit an Issue" from the Geode webpage
> ---
>
> Key: GEODE-3726
> URL: https://issues.apache.org/jira/browse/GEODE-3726
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, web-content
>Reporter: Dave Barnes
>Assignee: Dave Barnes
>Priority: Minor
>
> Based on a discussion on the dev mailing list, consensus is:
> - remove the "Submit an Issue" button on the webpage
> - direct questions to the Users mailing list



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (GEODE-3726) Remove "Submit an Issue" from the Geode webpage

2017-10-04 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-3726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192114#comment-16192114
 ] 

ASF subversion and git services commented on GEODE-3726:


Commit ca90c34dad877ee5e30aabc4340049b6e0140498 in geode-site's branch 
refs/heads/master from [~dbarnes97]
[ https://gitbox.apache.org/repos/asf?p=geode-site.git;h=ca90c34 ]

GEODE-3726: Remove "Submit an Issue" from the Geode webpage


> Remove "Submit an Issue" from the Geode webpage
> ---
>
> Key: GEODE-3726
> URL: https://issues.apache.org/jira/browse/GEODE-3726
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, web-content
>Reporter: Dave Barnes
>Assignee: Dave Barnes
>Priority: Minor
>
> Based on a discussion on the dev mailing list, consensus is:
> - remove the "Submit an Issue" button on the webpage
> - direct questions to the Users mailing list



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (GEODE-3703) rename JAR resource to DEPLOY

2017-10-04 Thread Karen Smoler Miller (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-3703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karen Smoler Miller resolved GEODE-3703.

Resolution: Fixed

> rename JAR resource to DEPLOY
> -
>
> Key: GEODE-3703
> URL: https://issues.apache.org/jira/browse/GEODE-3703
> Project: Geode
>  Issue Type: Sub-task
>  Components: docs, security
>Reporter: Swapnil Bawaskar
>Assignee: Karen Smoler Miller
> Fix For: 1.3.0
>
>
> We currently have a JAR resource introduced with finer grained security (not 
> released yet). Since the idea behind this resource is to control who has 
> authorization to deploy jar files to the geode cluster, I think a better name 
> for this resource would be DEPLOY.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (GEODE-3703) rename JAR resource to DEPLOY

2017-10-04 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-3703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192099#comment-16192099
 ] 

ASF subversion and git services commented on GEODE-3703:


Commit fe2e408723c48a7f094a84bc8a2a9cf3e3896f95 in geode's branch 
refs/heads/develop from Karen Miller
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=fe2e408 ]

GEODE-3703 Document JAR resource becomes DEPLOY (#860)



> rename JAR resource to DEPLOY
> -
>
> Key: GEODE-3703
> URL: https://issues.apache.org/jira/browse/GEODE-3703
> Project: Geode
>  Issue Type: Sub-task
>  Components: docs, security
>Reporter: Swapnil Bawaskar
>Assignee: Karen Smoler Miller
> Fix For: 1.3.0
>
>
> We currently have a JAR resource introduced with finer grained security (not 
> released yet). Since the idea behind this resource is to control who has 
> authorization to deploy jar files to the geode cluster, I think a better name 
> for this resource would be DEPLOY.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Reopened] (GEODE-3612) Add gfsh support for GatewayReceiver hostname-for-senders attriibute

2017-10-04 Thread Karen Smoler Miller (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-3612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karen Smoler Miller reopened GEODE-3612:

  Assignee: Karen Smoler Miller  (was: Shelley Lynn Hughes-Godfrey)

Reopening ticket to do documentation for this new gfsh option.

> Add gfsh support for GatewayReceiver hostname-for-senders attriibute
> 
>
> Key: GEODE-3612
> URL: https://issues.apache.org/jira/browse/GEODE-3612
> Project: Geode
>  Issue Type: Bug
>  Components: docs, wan
>Reporter: Barry Oglesby
>Assignee: Karen Smoler Miller
> Fix For: 1.3.0
>
>
> Configuring hostname-for-senders is not supported through gfsh. Support for 
> this attribute needs to be added.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (GEODE-3750) Adding logging of exception messages to InternalDistributedMember in case of reconnect failure

2017-10-04 Thread Udo Kohlmeyer (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-3750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Udo Kohlmeyer resolved GEODE-3750.
--
Resolution: Fixed

> Adding logging of exception messages to InternalDistributedMember in case of 
> reconnect failure
> --
>
> Key: GEODE-3750
> URL: https://issues.apache.org/jira/browse/GEODE-3750
> Project: Geode
>  Issue Type: Bug
>Reporter: Udo Kohlmeyer
>Assignee: Udo Kohlmeyer
>
> The exceptions are swallowed when reconnecting. logging out the exception on 
> warning level if they occur.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (GEODE-3750) Adding logging of exception messages to InternalDistributedMember in case of reconnect failure

2017-10-04 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-3750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192080#comment-16192080
 ] 

ASF subversion and git services commented on GEODE-3750:


Commit bfad65a0c76f2e227a009c0dc28dbbff307e65b7 in geode's branch 
refs/heads/develop from kohlmu-pivotal
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=bfad65a ]

GEODE-3750: Adding exception logging in auto reconnect


> Adding logging of exception messages to InternalDistributedMember in case of 
> reconnect failure
> --
>
> Key: GEODE-3750
> URL: https://issues.apache.org/jira/browse/GEODE-3750
> Project: Geode
>  Issue Type: Bug
>Reporter: Udo Kohlmeyer
>Assignee: Udo Kohlmeyer
>
> The exceptions are swallowed when reconnecting. logging out the exception on 
> warning level if they occur.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (GEODE-3685) MBean wrappers are not always applied correctly

2017-10-04 Thread Jared Stewart (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-3685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jared Stewart resolved GEODE-3685.
--
Resolution: Fixed

> MBean wrappers are not always applied correctly
> ---
>
> Key: GEODE-3685
> URL: https://issues.apache.org/jira/browse/GEODE-3685
> Project: Geode
>  Issue Type: Bug
>  Components: management
>Affects Versions: 1.1.0, 1.1.1, 1.2.0, 1.2.1
>Reporter: Jared Stewart
>Assignee: Jared Stewart
> Fix For: 1.3.0
>
>
> Under certain conditions, MBean wrappers are not applied correctly.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (GEODE-3750) Adding logging of exception messages to InternalDistributedMember in case of reconnect failure

2017-10-04 Thread Udo Kohlmeyer (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-3750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Udo Kohlmeyer reassigned GEODE-3750:


Assignee: Udo Kohlmeyer

> Adding logging of exception messages to InternalDistributedMember in case of 
> reconnect failure
> --
>
> Key: GEODE-3750
> URL: https://issues.apache.org/jira/browse/GEODE-3750
> Project: Geode
>  Issue Type: Bug
>Reporter: Udo Kohlmeyer
>Assignee: Udo Kohlmeyer
>
> The exceptions are swallowed when reconnecting. logging out the exception on 
> warning level if they occur.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (GEODE-3750) Adding logging of exception messages to InternalDistributedMember in case of reconnect failure

2017-10-04 Thread Udo Kohlmeyer (JIRA)
Udo Kohlmeyer created GEODE-3750:


 Summary: Adding logging of exception messages to 
InternalDistributedMember in case of reconnect failure
 Key: GEODE-3750
 URL: https://issues.apache.org/jira/browse/GEODE-3750
 Project: Geode
  Issue Type: Bug
Reporter: Udo Kohlmeyer


The exceptions are swallowed when reconnecting. logging out the exception on 
warning level if they occur.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (GEODE-3685) MBean wrappers are not always applied correctly

2017-10-04 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-3685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192052#comment-16192052
 ] 

ASF subversion and git services commented on GEODE-3685:


Commit db4a493efc09600bf0a9778d5274c09b23b16644 in geode's branch 
refs/heads/develop from [~jstewart]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=db4a493 ]

GEODE-3685: MBean wrappers are properly invoked over http

This closes #838.


> MBean wrappers are not always applied correctly
> ---
>
> Key: GEODE-3685
> URL: https://issues.apache.org/jira/browse/GEODE-3685
> Project: Geode
>  Issue Type: Bug
>  Components: management
>Affects Versions: 1.1.0, 1.1.1, 1.2.0, 1.2.1
>Reporter: Jared Stewart
>Assignee: Jared Stewart
> Fix For: 1.3.0
>
>
> Under certain conditions, MBean wrappers are not applied correctly.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (GEODE-3687) create gateway receiver ignores bind-address setting from gemfire.properties

2017-10-04 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-3687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192044#comment-16192044
 ] 

ASF subversion and git services commented on GEODE-3687:


Commit 0fbca5cf4d3ee4e070e32c377b062001e519ef43 in geode's branch 
refs/heads/feature/GEODE-3687 from [~upthewaterspout]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=0fbca5c ]

GEODE-3687: Adding GatewayReceiver.getHost back

GatewayReceiver is a public method, so we can't just remove it.


> create gateway receiver ignores bind-address setting from gemfire.properties
> 
>
> Key: GEODE-3687
> URL: https://issues.apache.org/jira/browse/GEODE-3687
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Reporter: Shelley Lynn Hughes-Godfrey
>Assignee: Shelley Lynn Hughes-Godfrey
>
> Users report that even with `bind-address` set to the ip in 
> `gemfire.properties`, the receivers are still giving hostnames to the senders 
> instead of ip addresses.
> The GatewayReceiverImpl should not be invoking:
> receiver.setHostnameForClients(host);
> with the local hostname (based on hostname-for-senders and bind-address 
> settings).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (GEODE-3723) Reconsider using Optional as the parameter for getRequiredPermissions

2017-10-04 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-3723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192025#comment-16192025
 ] 

ASF subversion and git services commented on GEODE-3723:


Commit 5e868d38b8091227fc08768d33a017e8d1e72411 in geode's branch 
refs/heads/develop from Karen Miller
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=5e868d3 ]

GEODE-3723 Revise javadoc defn of getRequiredPermissions parameter (#864)



> Reconsider using Optional as the parameter for getRequiredPermissions
> -
>
> Key: GEODE-3723
> URL: https://issues.apache.org/jira/browse/GEODE-3723
> Project: Geode
>  Issue Type: Bug
>  Components: security
>Reporter: Dan Smith
>Assignee: Karen Smoler Miller
> Fix For: 1.3.0
>
>
> The new method on function, getRequiredPermissions takes an Optional 
> as parameter.
> At point point, we added a parameterized type to the function interface 
> (Function). However, if someone tries to implement Function without the 
> type (eg implements Function instead of implemments Function), then 
> they get the below compilation error:
> {noformat}
> Error:(85, 41) java: name clash: 
> getRequiredPermissions(java.util.Optional) in 
> org.apache.geode.cache.lucene.internal.distributed.WaitUntilFlushedFunction 
> and getRequiredPermissions(java.util.Optional) in 
> org.apache.geode.cache.execute.Function have the same erasure, yet neither 
> overrides the other
> {noformat}
> In addition to this annoyance Optional is generally discouraged as a 
> parameter to a method in favor of method overloading. At least my IDE is 
> providing a warning to that effect. Maybe having an overloaded method for 
> getRequiredPermissions would be better?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (GEODE-3247) Improve OQL expression execution

2017-10-04 Thread Diane Hardman (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-3247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Diane Hardman reassigned GEODE-3247:


Assignee: Karen Smoler Miller  (was: Jason Huynh)

> Improve OQL expression execution
> 
>
> Key: GEODE-3247
> URL: https://issues.apache.org/jira/browse/GEODE-3247
> Project: Geode
>  Issue Type: Bug
>  Components: docs, querying
>Reporter: Anthony Baker
>Assignee: Karen Smoler Miller
> Fix For: 1.3.0
>
>
> We should validate an OQL expression before attempting to invoke it to 
> prevent undesirable behavior.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (GEODE-3729) New client protocol should be properly configurable

2017-10-04 Thread Brian Baynes (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-3729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brian Baynes updated GEODE-3729:

Fix Version/s: (was: 1.3.0)

> New client protocol should be properly configurable
> ---
>
> Key: GEODE-3729
> URL: https://issues.apache.org/jira/browse/GEODE-3729
> Project: Geode
>  Issue Type: New Feature
>  Components: client/server
>Reporter: Galen O'Sullivan
>
> The new client protocol currently has two authentication modes: NONE and 
> SIMPLE.
> We should put the configuration for this somewhere that it is not just an 
> isolated query of a system property, and make sure it works with GFSH and 
> gemfire.properties .
> As part of this, we should probably come up with a clever prefix for the "new 
> client protocol" that we can use to prefix properties. Something like 
> {{gemfire.protobuf-protocol}} or {{gemfire.emma}} or {{gemfire.gnpbcpfc}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (GEODE-3731) CI failure: DistributionManagerDUnitTest.testAckSevereAlertThreshold failed with assertion

2017-10-04 Thread Udo Kohlmeyer (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-3731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Udo Kohlmeyer reassigned GEODE-3731:


Assignee: Udo Kohlmeyer

> CI failure: DistributionManagerDUnitTest.testAckSevereAlertThreshold failed 
> with assertion
> --
>
> Key: GEODE-3731
> URL: https://issues.apache.org/jira/browse/GEODE-3731
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Hitesh Khamesra
>Assignee: Udo Kohlmeyer
>
> org.apache.geode.distributed.internal.DistributionManagerDUnitTest > 
> testAckSevereAlertThreshold FAILED
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.distributed.internal.DistributionManagerDUnitTest$2.run in 
> VM 1 running on Host 989f9beaa656 with 4 VMs
> at org.apache.geode.test.dunit.VM.invoke(VM.java:393)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:363)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:308)
> at 
> org.apache.geode.distributed.internal.DistributionManagerDUnitTest.testAckSevereAlertThreshold(DistributionManagerDUnitTest.java:277)
> Caused by:
> java.lang.AssertionError



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (GEODE-3749) CI Failure: DeltaPropagationDUnitTest.testBug40165ClientReconnects

2017-10-04 Thread Udo Kohlmeyer (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-3749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Udo Kohlmeyer resolved GEODE-3749.
--
Resolution: Fixed

> CI Failure: DeltaPropagationDUnitTest.testBug40165ClientReconnects
> --
>
> Key: GEODE-3749
> URL: https://issues.apache.org/jira/browse/GEODE-3749
> Project: Geode
>  Issue Type: Bug
>Reporter: Udo Kohlmeyer
>Assignee: Udo Kohlmeyer
>
> org.apache.geode.internal.cache.DeltaPropagationDUnitTest > 
> testBug40165ClientReconnects FAILED
> org.apache.geode.cache.NoSubscriptionServersAvailableException: 
> org.apache.geode.cache.NoSubscriptionServersAvailableException: Could not 
> initialize a primary queue on startup. No queue servers available.
> at 
> org.apache.geode.cache.client.internal.QueueManagerImpl.getAllConnections(QueueManagerImpl.java:190)
> at 
> org.apache.geode.cache.client.internal.OpExecutorImpl.executeOnQueuesAndReturnPrimaryResult(OpExecutorImpl.java:540)
> at 
> org.apache.geode.cache.client.internal.PoolImpl.executeOnQueuesAndReturnPrimaryResult(PoolImpl.java:842)
> at 
> org.apache.geode.cache.client.internal.RegisterInterestOp.execute(RegisterInterestOp.java:58)
> at 
> org.apache.geode.cache.client.internal.ServerRegionProxy.registerInterest(ServerRegionProxy.java:359)
> at 
> org.apache.geode.internal.cache.LocalRegion.processSingleInterest(LocalRegion.java:3734)
> at 
> org.apache.geode.internal.cache.LocalRegion.registerInterest(LocalRegion.java:3823)
> at 
> org.apache.geode.internal.cache.LocalRegion.registerInterest(LocalRegion.java:3625)
> at 
> org.apache.geode.internal.cache.LocalRegion.registerInterest(LocalRegion.java:3620)
> at 
> org.apache.geode.internal.cache.LocalRegion.registerInterest(LocalRegion.java:3615)
> at 
> org.apache.geode.internal.cache.DeltaPropagationDUnitTest.createDurableCacheClient(DeltaPropagationDUnitTest.java:1372)
> at 
> org.apache.geode.internal.cache.DeltaPropagationDUnitTest.testBug40165ClientReconnects(DeltaPropagationDUnitTest.java:698)
> Caused by:
> org.apache.geode.cache.NoSubscriptionServersAvailableException: Could 
> not initialize a primary queue on startup. No queue servers available.
> at 
> org.apache.geode.cache.client.internal.QueueManagerImpl.initializeConnections(QueueManagerImpl.java:592)
> at 
> org.apache.geode.cache.client.internal.QueueManagerImpl.start(QueueManagerImpl.java:303)
> at 
> org.apache.geode.cache.client.internal.PoolImpl.start(PoolImpl.java:346)
> at 
> org.apache.geode.cache.client.internal.PoolImpl.finishCreate(PoolImpl.java:172)
> at 
> org.apache.geode.cache.client.internal.PoolImpl.create(PoolImpl.java:158)
> at 
> org.apache.geode.internal.cache.PoolFactoryImpl.create(PoolFactoryImpl.java:338)
> at 
> org.apache.geode.internal.cache.DeltaPropagationDUnitTest.createDurableCacheClient(DeltaPropagationDUnitTest.java:1362)
> ... 1 more



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (GEODE-3749) CI Failure: DeltaPropagationDUnitTest.testBug40165ClientReconnects

2017-10-04 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-3749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191984#comment-16191984
 ] 

ASF subversion and git services commented on GEODE-3749:


Commit 77a0c7647ccca101d9375501a6478fd7c77f3269 in geode's branch 
refs/heads/develop from kohlmu-pivotal
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=77a0c76 ]

GEODE-3749: DeltaPropagationDUnitTest.testBug40165ClientReconnects failure


> CI Failure: DeltaPropagationDUnitTest.testBug40165ClientReconnects
> --
>
> Key: GEODE-3749
> URL: https://issues.apache.org/jira/browse/GEODE-3749
> Project: Geode
>  Issue Type: Bug
>Reporter: Udo Kohlmeyer
>Assignee: Udo Kohlmeyer
>
> org.apache.geode.internal.cache.DeltaPropagationDUnitTest > 
> testBug40165ClientReconnects FAILED
> org.apache.geode.cache.NoSubscriptionServersAvailableException: 
> org.apache.geode.cache.NoSubscriptionServersAvailableException: Could not 
> initialize a primary queue on startup. No queue servers available.
> at 
> org.apache.geode.cache.client.internal.QueueManagerImpl.getAllConnections(QueueManagerImpl.java:190)
> at 
> org.apache.geode.cache.client.internal.OpExecutorImpl.executeOnQueuesAndReturnPrimaryResult(OpExecutorImpl.java:540)
> at 
> org.apache.geode.cache.client.internal.PoolImpl.executeOnQueuesAndReturnPrimaryResult(PoolImpl.java:842)
> at 
> org.apache.geode.cache.client.internal.RegisterInterestOp.execute(RegisterInterestOp.java:58)
> at 
> org.apache.geode.cache.client.internal.ServerRegionProxy.registerInterest(ServerRegionProxy.java:359)
> at 
> org.apache.geode.internal.cache.LocalRegion.processSingleInterest(LocalRegion.java:3734)
> at 
> org.apache.geode.internal.cache.LocalRegion.registerInterest(LocalRegion.java:3823)
> at 
> org.apache.geode.internal.cache.LocalRegion.registerInterest(LocalRegion.java:3625)
> at 
> org.apache.geode.internal.cache.LocalRegion.registerInterest(LocalRegion.java:3620)
> at 
> org.apache.geode.internal.cache.LocalRegion.registerInterest(LocalRegion.java:3615)
> at 
> org.apache.geode.internal.cache.DeltaPropagationDUnitTest.createDurableCacheClient(DeltaPropagationDUnitTest.java:1372)
> at 
> org.apache.geode.internal.cache.DeltaPropagationDUnitTest.testBug40165ClientReconnects(DeltaPropagationDUnitTest.java:698)
> Caused by:
> org.apache.geode.cache.NoSubscriptionServersAvailableException: Could 
> not initialize a primary queue on startup. No queue servers available.
> at 
> org.apache.geode.cache.client.internal.QueueManagerImpl.initializeConnections(QueueManagerImpl.java:592)
> at 
> org.apache.geode.cache.client.internal.QueueManagerImpl.start(QueueManagerImpl.java:303)
> at 
> org.apache.geode.cache.client.internal.PoolImpl.start(PoolImpl.java:346)
> at 
> org.apache.geode.cache.client.internal.PoolImpl.finishCreate(PoolImpl.java:172)
> at 
> org.apache.geode.cache.client.internal.PoolImpl.create(PoolImpl.java:158)
> at 
> org.apache.geode.internal.cache.PoolFactoryImpl.create(PoolFactoryImpl.java:338)
> at 
> org.apache.geode.internal.cache.DeltaPropagationDUnitTest.createDurableCacheClient(DeltaPropagationDUnitTest.java:1362)
> ... 1 more



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (GEODE-3749) CI Failure: DeltaPropagationDUnitTest.testBug40165ClientReconnects

2017-10-04 Thread Udo Kohlmeyer (JIRA)
Udo Kohlmeyer created GEODE-3749:


 Summary: CI Failure: 
DeltaPropagationDUnitTest.testBug40165ClientReconnects
 Key: GEODE-3749
 URL: https://issues.apache.org/jira/browse/GEODE-3749
 Project: Geode
  Issue Type: Bug
Reporter: Udo Kohlmeyer


org.apache.geode.internal.cache.DeltaPropagationDUnitTest > 
testBug40165ClientReconnects FAILED
org.apache.geode.cache.NoSubscriptionServersAvailableException: 
org.apache.geode.cache.NoSubscriptionServersAvailableException: Could not 
initialize a primary queue on startup. No queue servers available.
at 
org.apache.geode.cache.client.internal.QueueManagerImpl.getAllConnections(QueueManagerImpl.java:190)
at 
org.apache.geode.cache.client.internal.OpExecutorImpl.executeOnQueuesAndReturnPrimaryResult(OpExecutorImpl.java:540)
at 
org.apache.geode.cache.client.internal.PoolImpl.executeOnQueuesAndReturnPrimaryResult(PoolImpl.java:842)
at 
org.apache.geode.cache.client.internal.RegisterInterestOp.execute(RegisterInterestOp.java:58)
at 
org.apache.geode.cache.client.internal.ServerRegionProxy.registerInterest(ServerRegionProxy.java:359)
at 
org.apache.geode.internal.cache.LocalRegion.processSingleInterest(LocalRegion.java:3734)
at 
org.apache.geode.internal.cache.LocalRegion.registerInterest(LocalRegion.java:3823)
at 
org.apache.geode.internal.cache.LocalRegion.registerInterest(LocalRegion.java:3625)
at 
org.apache.geode.internal.cache.LocalRegion.registerInterest(LocalRegion.java:3620)
at 
org.apache.geode.internal.cache.LocalRegion.registerInterest(LocalRegion.java:3615)
at 
org.apache.geode.internal.cache.DeltaPropagationDUnitTest.createDurableCacheClient(DeltaPropagationDUnitTest.java:1372)
at 
org.apache.geode.internal.cache.DeltaPropagationDUnitTest.testBug40165ClientReconnects(DeltaPropagationDUnitTest.java:698)

Caused by:
org.apache.geode.cache.NoSubscriptionServersAvailableException: Could 
not initialize a primary queue on startup. No queue servers available.
at 
org.apache.geode.cache.client.internal.QueueManagerImpl.initializeConnections(QueueManagerImpl.java:592)
at 
org.apache.geode.cache.client.internal.QueueManagerImpl.start(QueueManagerImpl.java:303)
at 
org.apache.geode.cache.client.internal.PoolImpl.start(PoolImpl.java:346)
at 
org.apache.geode.cache.client.internal.PoolImpl.finishCreate(PoolImpl.java:172)
at 
org.apache.geode.cache.client.internal.PoolImpl.create(PoolImpl.java:158)
at 
org.apache.geode.internal.cache.PoolFactoryImpl.create(PoolFactoryImpl.java:338)
at 
org.apache.geode.internal.cache.DeltaPropagationDUnitTest.createDurableCacheClient(DeltaPropagationDUnitTest.java:1362)
... 1 more



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (GEODE-3749) CI Failure: DeltaPropagationDUnitTest.testBug40165ClientReconnects

2017-10-04 Thread Udo Kohlmeyer (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-3749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Udo Kohlmeyer reassigned GEODE-3749:


Assignee: Udo Kohlmeyer

> CI Failure: DeltaPropagationDUnitTest.testBug40165ClientReconnects
> --
>
> Key: GEODE-3749
> URL: https://issues.apache.org/jira/browse/GEODE-3749
> Project: Geode
>  Issue Type: Bug
>Reporter: Udo Kohlmeyer
>Assignee: Udo Kohlmeyer
>
> org.apache.geode.internal.cache.DeltaPropagationDUnitTest > 
> testBug40165ClientReconnects FAILED
> org.apache.geode.cache.NoSubscriptionServersAvailableException: 
> org.apache.geode.cache.NoSubscriptionServersAvailableException: Could not 
> initialize a primary queue on startup. No queue servers available.
> at 
> org.apache.geode.cache.client.internal.QueueManagerImpl.getAllConnections(QueueManagerImpl.java:190)
> at 
> org.apache.geode.cache.client.internal.OpExecutorImpl.executeOnQueuesAndReturnPrimaryResult(OpExecutorImpl.java:540)
> at 
> org.apache.geode.cache.client.internal.PoolImpl.executeOnQueuesAndReturnPrimaryResult(PoolImpl.java:842)
> at 
> org.apache.geode.cache.client.internal.RegisterInterestOp.execute(RegisterInterestOp.java:58)
> at 
> org.apache.geode.cache.client.internal.ServerRegionProxy.registerInterest(ServerRegionProxy.java:359)
> at 
> org.apache.geode.internal.cache.LocalRegion.processSingleInterest(LocalRegion.java:3734)
> at 
> org.apache.geode.internal.cache.LocalRegion.registerInterest(LocalRegion.java:3823)
> at 
> org.apache.geode.internal.cache.LocalRegion.registerInterest(LocalRegion.java:3625)
> at 
> org.apache.geode.internal.cache.LocalRegion.registerInterest(LocalRegion.java:3620)
> at 
> org.apache.geode.internal.cache.LocalRegion.registerInterest(LocalRegion.java:3615)
> at 
> org.apache.geode.internal.cache.DeltaPropagationDUnitTest.createDurableCacheClient(DeltaPropagationDUnitTest.java:1372)
> at 
> org.apache.geode.internal.cache.DeltaPropagationDUnitTest.testBug40165ClientReconnects(DeltaPropagationDUnitTest.java:698)
> Caused by:
> org.apache.geode.cache.NoSubscriptionServersAvailableException: Could 
> not initialize a primary queue on startup. No queue servers available.
> at 
> org.apache.geode.cache.client.internal.QueueManagerImpl.initializeConnections(QueueManagerImpl.java:592)
> at 
> org.apache.geode.cache.client.internal.QueueManagerImpl.start(QueueManagerImpl.java:303)
> at 
> org.apache.geode.cache.client.internal.PoolImpl.start(PoolImpl.java:346)
> at 
> org.apache.geode.cache.client.internal.PoolImpl.finishCreate(PoolImpl.java:172)
> at 
> org.apache.geode.cache.client.internal.PoolImpl.create(PoolImpl.java:158)
> at 
> org.apache.geode.internal.cache.PoolFactoryImpl.create(PoolFactoryImpl.java:338)
> at 
> org.apache.geode.internal.cache.DeltaPropagationDUnitTest.createDurableCacheClient(DeltaPropagationDUnitTest.java:1362)
> ... 1 more



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (GEODE-3732) CI failure: ClientHealthMonitorJUnitTest.testDeadClientRemovalByServer FAILED

2017-10-04 Thread Udo Kohlmeyer (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-3732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Udo Kohlmeyer reassigned GEODE-3732:


Assignee: Udo Kohlmeyer

> CI failure: ClientHealthMonitorJUnitTest.testDeadClientRemovalByServer FAILED
> -
>
> Key: GEODE-3732
> URL: https://issues.apache.org/jira/browse/GEODE-3732
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Hitesh Khamesra
>Assignee: Udo Kohlmeyer
>
> org.apache.geode.internal.cache.tier.sockets.ClientHealthMonitorJUnitTest > 
> testDeadClientRemovalByServer FAILED
> org.awaitility.core.ConditionTimeoutException: Condition defined as a 
> lambda expression in 
> org.apache.geode.internal.cache.tier.sockets.ClientHealthMonitorJUnitTest 
> that uses org.apache.geode.Statistics Values should be different. Actual: 0 
> within 170 milliseconds.
> at 
> org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:104)
> at 
> org.awaitility.core.AssertionCondition.await(AssertionCondition.java:117)
> at 
> org.awaitility.core.AssertionCondition.await(AssertionCondition.java:32)
> at 
> org.awaitility.core.ConditionFactory.until(ConditionFactory.java:809)
> at 
> org.awaitility.core.ConditionFactory.until(ConditionFactory.java:648)
> at 
> org.apache.geode.internal.cache.tier.sockets.ClientHealthMonitorJUnitTest.waitAndVerify(ClientHealthMonitorJUnitTest.java:255)
> at 
> org.apache.geode.internal.cache.tier.sockets.ClientHealthMonitorJUnitTest.testDeadClientRemovalByServer(ClientHealthMonitorJUnitTest.java:218)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (GEODE-3732) CI failure: ClientHealthMonitorJUnitTest.testDeadClientRemovalByServer FAILED

2017-10-04 Thread Udo Kohlmeyer (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-3732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Udo Kohlmeyer resolved GEODE-3732.
--
Resolution: Fixed

> CI failure: ClientHealthMonitorJUnitTest.testDeadClientRemovalByServer FAILED
> -
>
> Key: GEODE-3732
> URL: https://issues.apache.org/jira/browse/GEODE-3732
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Hitesh Khamesra
>Assignee: Udo Kohlmeyer
>
> org.apache.geode.internal.cache.tier.sockets.ClientHealthMonitorJUnitTest > 
> testDeadClientRemovalByServer FAILED
> org.awaitility.core.ConditionTimeoutException: Condition defined as a 
> lambda expression in 
> org.apache.geode.internal.cache.tier.sockets.ClientHealthMonitorJUnitTest 
> that uses org.apache.geode.Statistics Values should be different. Actual: 0 
> within 170 milliseconds.
> at 
> org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:104)
> at 
> org.awaitility.core.AssertionCondition.await(AssertionCondition.java:117)
> at 
> org.awaitility.core.AssertionCondition.await(AssertionCondition.java:32)
> at 
> org.awaitility.core.ConditionFactory.until(ConditionFactory.java:809)
> at 
> org.awaitility.core.ConditionFactory.until(ConditionFactory.java:648)
> at 
> org.apache.geode.internal.cache.tier.sockets.ClientHealthMonitorJUnitTest.waitAndVerify(ClientHealthMonitorJUnitTest.java:255)
> at 
> org.apache.geode.internal.cache.tier.sockets.ClientHealthMonitorJUnitTest.testDeadClientRemovalByServer(ClientHealthMonitorJUnitTest.java:218)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (GEODE-3621) Revert breaking changes in SecurityManager

2017-10-04 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-3621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191868#comment-16191868
 ] 

ASF subversion and git services commented on GEODE-3621:


Commit 8eeb20117c5255be8023e9181caeec268ad082c8 in geode's branch 
refs/heads/develop from [~jinmeiliao]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=8eeb201 ]

GEODE-3621: revert the change to maintain backward compatibility


> Revert breaking changes in SecurityManager
> --
>
> Key: GEODE-3621
> URL: https://issues.apache.org/jira/browse/GEODE-3621
> Project: Geode
>  Issue Type: Bug
>  Components: security
>Reporter: Jared Stewart
>Assignee: Patrick Rhomberg
> Fix For: 1.3.0
>
>
> This commit introduced breaking changes to the public SecurityManager API: 
> {noformat}
> GEODE-2925: add target for resource operation for finer grained security
> * add finer authorize* call in security service
> * add target to the MXBean authorization check
> * use enum type instead of raw strings for resource/operation
> f541043 Jinmei Liao  on 5/31/17 at 1:50 PM
> committed on 6/12/17 at 11:05 AM
> {noformat}
> Furthermore, using Enum types restricts us from introducing new security 
> Resources and Operations in the future.  We should revert back to using a 
> String-based SecurityManager API to restore backwards compatibility and 
> permit future extensibility. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Comment Edited] (GEODE-3567) Exporting configuration from GFSH causes multiple cacheservers to be listed

2017-10-04 Thread Jinmei Liao (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-3567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191848#comment-16191848
 ] 

Jinmei Liao edited comment on GEODE-3567 at 10/4/17 7:07 PM:
-

use this acceptance test to verify:
{quote}
@Test
  public void name() throws Exception {
File backup = new File(tempFoler.getRoot(), "backup");

GfshExecution execution = GfshScript.of("start locator --name=locator",
"start server --name=server2 --server-port=0 --group=serverGROUP2",

"create region --name=TestRegion10 --type=REPLICATE  
--group=serverGROUP2",
"create region --name=TestRegion2 --type=REPLICATE",
"sleep --time=1",

"stop server --name=server2",
"start server --name=server2 --server-port=0 --group=serverGROUP2",
"export cluster-configuration --zip-file-name=" + new File( backup, 
"cc.zip").getAbsolutePath(),
"export config --dir="+backup.getAbsolutePath()
).withName("test").execute(gfshRule);

File cacheXml = new File( backup, "server2-cache.xml");
List cacheServerLines = Files.lines(cacheXml.toPath())
.filter(line -> line.contains(" line.contains(" Exporting configuration from GFSH causes multiple cacheservers to be listed
> ---
>
> Key: GEODE-3567
> URL: https://issues.apache.org/jira/browse/GEODE-3567
> Project: Geode
>  Issue Type: Bug
>  Components: configuration, gfsh
>Affects Versions: 1.0.0-incubating, 1.1.0, 1.2.0
>Reporter: Udo Kohlmeyer
>Assignee: Jinmei Liao
>
> When running the following steps, ends up causing the `export config` command 
> to list multiple `` entries to be created in the exported 
> `cache.xml`
> {code}
> start locator --name=locator --enable-cluster-configuration=true 
> --J=-Dgemfire.hostname-for-clients=bob
> start server --name=server --use-cluster-configuration=true --server-port=0 
> --hostname-for-clients=bob3
> start server --name=server2 --use-cluster-configuration=true --server-port=0 
> --group=serverGROUP2 --hostname-for-clients=bob2
> export cluster-configuration --zip-file-name=./backup1.zip
> export config --dir=./serversBack1
> stop server --name=server2
> start server --name=server2 --use-cluster-configuration=true --server-port=0 
> --group=serverGROUP2 --hostname-for-clients=bob2
> export config --dir=./serversBack2
> create disk-store --name=diskstore1 --dir=./ds1
> create region --name=TestRegion2 --type=REPLICATE_PERSISTENT_OVERFLOW 
> --disk-store=diskstore1
> create region --name=TestRegion --type=REPLICATE_PERSISTENT_OVERFLOW 
> --disk-store=diskstore1
> create region --name=TestRegion10 --type=REPLICATE --group=serverGROUP2
> export cluster-configuration --zip-file-name=./backup2.zip
> export config --dir=./serversBack3
> stop server --name=server2
> start server --name=server2 --use-cluster-configuration=true --server-port=0 
> --group=serverGROUP2 --hostname-for-clients=bob2
> export config --dir=./serversBack4
> {code}
> Extract from serversBack4 exported cache.xml
> {code}
>  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
> xmlns="http://geode.apache.org/schema/cache; 
> xsi:schemaLocation="http://geode.apache.org/schema/cache 
> http://geode.apache.org/schema/cache/cache-1.0.xsd; version="1.0" 
> is-server="true">
>   
>   
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (GEODE-3567) Exporting configuration from GFSH causes multiple cacheservers to be listed

2017-10-04 Thread Jinmei Liao (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-3567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191848#comment-16191848
 ] 

Jinmei Liao commented on GEODE-3567:


use this acceptance test to verify:

@Test
  public void name() throws Exception {
File backup = new File(tempFoler.getRoot(), "backup");

GfshExecution execution = GfshScript.of("start locator --name=locator",
"start server --name=server2 --server-port=0 --group=serverGROUP2",

"create region --name=TestRegion10 --type=REPLICATE  
--group=serverGROUP2",
"create region --name=TestRegion2 --type=REPLICATE",
"sleep --time=1",

"stop server --name=server2",
"start server --name=server2 --server-port=0 --group=serverGROUP2",
"export cluster-configuration --zip-file-name=" + new File( backup, 
"cc.zip").getAbsolutePath(),
"export config --dir="+backup.getAbsolutePath()
).withName("test").execute(gfshRule);

File cacheXml = new File( backup, "server2-cache.xml");
List cacheServerLines = Files.lines(cacheXml.toPath())
.filter(line -> line.contains(" Exporting configuration from GFSH causes multiple cacheservers to be listed
> ---
>
> Key: GEODE-3567
> URL: https://issues.apache.org/jira/browse/GEODE-3567
> Project: Geode
>  Issue Type: Bug
>  Components: configuration, gfsh
>Affects Versions: 1.0.0-incubating, 1.1.0, 1.2.0
>Reporter: Udo Kohlmeyer
>Assignee: Jinmei Liao
>
> When running the following steps, ends up causing the `export config` command 
> to list multiple `` entries to be created in the exported 
> `cache.xml`
> {code}
> start locator --name=locator --enable-cluster-configuration=true 
> --J=-Dgemfire.hostname-for-clients=bob
> start server --name=server --use-cluster-configuration=true --server-port=0 
> --hostname-for-clients=bob3
> start server --name=server2 --use-cluster-configuration=true --server-port=0 
> --group=serverGROUP2 --hostname-for-clients=bob2
> export cluster-configuration --zip-file-name=./backup1.zip
> export config --dir=./serversBack1
> stop server --name=server2
> start server --name=server2 --use-cluster-configuration=true --server-port=0 
> --group=serverGROUP2 --hostname-for-clients=bob2
> export config --dir=./serversBack2
> create disk-store --name=diskstore1 --dir=./ds1
> create region --name=TestRegion2 --type=REPLICATE_PERSISTENT_OVERFLOW 
> --disk-store=diskstore1
> create region --name=TestRegion --type=REPLICATE_PERSISTENT_OVERFLOW 
> --disk-store=diskstore1
> create region --name=TestRegion10 --type=REPLICATE --group=serverGROUP2
> export cluster-configuration --zip-file-name=./backup2.zip
> export config --dir=./serversBack3
> stop server --name=server2
> start server --name=server2 --use-cluster-configuration=true --server-port=0 
> --group=serverGROUP2 --hostname-for-clients=bob2
> export config --dir=./serversBack4
> {code}
> Extract from serversBack4 exported cache.xml
> {code}
>  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
> xmlns="http://geode.apache.org/schema/cache; 
> xsi:schemaLocation="http://geode.apache.org/schema/cache 
> http://geode.apache.org/schema/cache/cache-1.0.xsd; version="1.0" 
> is-server="true">
>   
>   
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (GEODE-3748) gradle plugin for integration testing geode applications

2017-10-04 Thread Swapnil Bawaskar (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-3748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil Bawaskar updated GEODE-3748:

Issue Type: New Feature  (was: Bug)

> gradle plugin for integration testing geode applications
> 
>
> Key: GEODE-3748
> URL: https://issues.apache.org/jira/browse/GEODE-3748
> Project: Geode
>  Issue Type: New Feature
>  Components: build, gfsh
>Reporter: Swapnil Bawaskar
>
> Moving the GfshRule to geode-junit was a step towards allowing geode 
> applications to write integration tests by spinning up a geode cluster.
> There is still a limitation of requiring geode to be installed locally and 
> GEODE_HOME to be pointing to that direction.
> In order to make integration testing easier in CI environments where geode 
> might not be installed, we should create a gradle plugin that will download, 
> unzip the geode distribution and set GEODE_HOME to point to that location.
> Ideal usage for users should be:
> 1. in your build.gradle file:
> {noformat}
> apply-plugin: 'org.apache.geode.integration-test'
> {noformat}
> 2. Use the GfshRule in their tests.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (GEODE-3747) Improve DistributedTest framework with SharedErrorCollector rule

2017-10-04 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-3747:


 Summary: Improve DistributedTest framework with 
SharedErrorCollector rule
 Key: GEODE-3747
 URL: https://issues.apache.org/jira/browse/GEODE-3747
 Project: Geode
  Issue Type: Improvement
  Components: tests
Reporter: Kirk Lund


Improve the DistributedTest framework with the following changes:
* SharedErrorCollector to enable asynchronous assertions within every DUnit JVM



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (GEODE-3741) Double free in ThinClientRegion::executeFunctionSH

2017-10-04 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-3741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191634#comment-16191634
 ] 

ASF subversion and git services commented on GEODE-3741:


Commit a430a07dd80c30ac548c83d646c2349284e6afdb in geode-native's branch 
refs/heads/develop from [~mhansonp]
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=a430a07 ]

GEODE-3741: Fixed double delete


>  Double free in ThinClientRegion::executeFunctionSH
> ---
>
> Key: GEODE-3741
> URL: https://issues.apache.org/jira/browse/GEODE-3741
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Ernest Burghardt
>
> It is possible to have a double free of workers in this method



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (GEODE-3242) User can add a LuceneSerializer using GFSH

2017-10-04 Thread Dan Smith (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-3242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Smith resolved GEODE-3242.
--
Resolution: Fixed

> User can add a LuceneSerializer using GFSH
> --
>
> Key: GEODE-3242
> URL: https://issues.apache.org/jira/browse/GEODE-3242
> Project: Geode
>  Issue Type: Sub-task
>  Components: docs, lucene
>Reporter: Dan Smith
>
> As a user, I can pass in a LuceneSerializer when creating an index through 
> gfsh.
> Acceptance:
> A user can pass a LuceneSerializer as a parameter when creating a lucene 
> index through gfsh. That serializer is called when entries are added to the 
> region, and the results are what get stored in the lucene index.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (GEODE-3243) LuceneSerializer added through gfsh are persisted in cluster configuration

2017-10-04 Thread Dan Smith (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Smith resolved GEODE-3243.
--
Resolution: Fixed

> LuceneSerializer added through gfsh are persisted in cluster configuration
> --
>
> Key: GEODE-3243
> URL: https://issues.apache.org/jira/browse/GEODE-3243
> Project: Geode
>  Issue Type: Sub-task
>  Components: lucene
>Reporter: Dan Smith
>
> When creating a lucene index in gfsh, if a user configures a lucene 
> serializer on that index, the serializer will be saved in cluster 
> configuration.
> Acceptance:
> After creating an index with a lucene serializer, new members that join the 
> system should pick up the lucene serializer and use it when indexing objects.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (GEODE-3242) User can add a LuceneSerializer using GFSH

2017-10-04 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-3242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191624#comment-16191624
 ] 

ASF subversion and git services commented on GEODE-3242:


Commit 17820305e599b91f362be440e16b5f4726f73a39 in geode's branch 
refs/heads/feature/GEODE-3239 from [~upthewaterspout]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=1782030 ]

GEODE-3242: Adding lucene serializer to describe command

Printing the lucene index's serializer in the output of describe index.


> User can add a LuceneSerializer using GFSH
> --
>
> Key: GEODE-3242
> URL: https://issues.apache.org/jira/browse/GEODE-3242
> Project: Geode
>  Issue Type: Sub-task
>  Components: docs, lucene
>Reporter: Dan Smith
>
> As a user, I can pass in a LuceneSerializer when creating an index through 
> gfsh.
> Acceptance:
> A user can pass a LuceneSerializer as a parameter when creating a lucene 
> index through gfsh. That serializer is called when entries are added to the 
> region, and the results are what get stored in the lucene index.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (GEODE-3746) Refactor FunctionCommandsDUnitTest to use rules instead of CliCommandTestBase

2017-10-04 Thread Jens Deppe (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-3746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jens Deppe reassigned GEODE-3746:
-

Assignee: Jens Deppe

> Refactor FunctionCommandsDUnitTest to use rules instead of CliCommandTestBase
> -
>
> Key: GEODE-3746
> URL: https://issues.apache.org/jira/browse/GEODE-3746
> Project: Geode
>  Issue Type: Improvement
>  Components: functions, gfsh
>Reporter: Jens Deppe
>Assignee: Jens Deppe
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (GEODE-3243) LuceneSerializer added through gfsh are persisted in cluster configuration

2017-10-04 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191623#comment-16191623
 ] 

ASF subversion and git services commented on GEODE-3243:


Commit ef7c2d973399af609fd3d70176ba79ec9b5fd0fb in geode's branch 
refs/heads/feature/GEODE-3239 from [~upthewaterspout]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=ef7c2d9 ]

GEODE-3242, GEODE-3243: Add gfsh support for LuceneSerializer

gfsh create index now supports a LuceneSerializer and the serializer is
persisted in cluster configuration.


> LuceneSerializer added through gfsh are persisted in cluster configuration
> --
>
> Key: GEODE-3243
> URL: https://issues.apache.org/jira/browse/GEODE-3243
> Project: Geode
>  Issue Type: Sub-task
>  Components: lucene
>Reporter: Dan Smith
>
> When creating a lucene index in gfsh, if a user configures a lucene 
> serializer on that index, the serializer will be saved in cluster 
> configuration.
> Acceptance:
> After creating an index with a lucene serializer, new members that join the 
> system should pick up the lucene serializer and use it when indexing objects.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (GEODE-3242) User can add a LuceneSerializer using GFSH

2017-10-04 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-3242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191622#comment-16191622
 ] 

ASF subversion and git services commented on GEODE-3242:


Commit ef7c2d973399af609fd3d70176ba79ec9b5fd0fb in geode's branch 
refs/heads/feature/GEODE-3239 from [~upthewaterspout]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=ef7c2d9 ]

GEODE-3242, GEODE-3243: Add gfsh support for LuceneSerializer

gfsh create index now supports a LuceneSerializer and the serializer is
persisted in cluster configuration.


> User can add a LuceneSerializer using GFSH
> --
>
> Key: GEODE-3242
> URL: https://issues.apache.org/jira/browse/GEODE-3242
> Project: Geode
>  Issue Type: Sub-task
>  Components: docs, lucene
>Reporter: Dan Smith
>
> As a user, I can pass in a LuceneSerializer when creating an index through 
> gfsh.
> Acceptance:
> A user can pass a LuceneSerializer as a parameter when creating a lucene 
> index through gfsh. That serializer is called when entries are added to the 
> region, and the results are what get stored in the lucene index.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (GEODE-3746) Refactor FunctionCommandsDUnitTest to use rules instead of CliCommandTestBase

2017-10-04 Thread Jens Deppe (JIRA)
Jens Deppe created GEODE-3746:
-

 Summary: Refactor FunctionCommandsDUnitTest to use rules instead 
of CliCommandTestBase
 Key: GEODE-3746
 URL: https://issues.apache.org/jira/browse/GEODE-3746
 Project: Geode
  Issue Type: Improvement
  Components: functions, gfsh
Reporter: Jens Deppe






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (GEODE-3745) User Guide: Incomplete diagram, durable client

2017-10-04 Thread Dave Barnes (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-3745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Barnes reassigned GEODE-3745:
--

Assignee: Dave Barnes

> User Guide: Incomplete diagram, durable client
> --
>
> Key: GEODE-3745
> URL: https://issues.apache.org/jira/browse/GEODE-3745
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Dave Barnes
>Priority: Minor
>
> Under "Implementing Durable Client/Server Messaging" there's a diagram that 
> is incomplete due to cropping on the right-hand side. Needs to be restored 
> from source (if one can be found) or redrawn for completeness.
> The image source file is 
> ...geode-docs/images/ClientServerAdvancedTopics-6.gif. Manual page is 
> http://geode.apache.org/docs/guide/12/developing/events/implementing_durable_client_server_messaging.html,
>  under the "Reconnection" heading. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (GEODE-3745) User Guide: Incomplete diagram, durable client

2017-10-04 Thread Dave Barnes (JIRA)
Dave Barnes created GEODE-3745:
--

 Summary: User Guide: Incomplete diagram, durable client
 Key: GEODE-3745
 URL: https://issues.apache.org/jira/browse/GEODE-3745
 Project: Geode
  Issue Type: Bug
  Components: docs
Reporter: Dave Barnes


Under "Implementing Durable Client/Server Messaging" there's a diagram that is 
incomplete due to cropping on the right-hand side. Needs to be restored from 
source (if one can be found) or redrawn for completeness.
The image source file is ...geode-docs/images/ClientServerAdvancedTopics-6.gif. 
Manual page is 
http://geode.apache.org/docs/guide/12/developing/events/implementing_durable_client_server_messaging.html,
 under the "Reconnection" heading. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (GEODE-3745) User Guide: Incomplete diagram, durable client

2017-10-04 Thread Dave Barnes (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-3745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Barnes updated GEODE-3745:
---
Priority: Minor  (was: Major)

> User Guide: Incomplete diagram, durable client
> --
>
> Key: GEODE-3745
> URL: https://issues.apache.org/jira/browse/GEODE-3745
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Dave Barnes
>Priority: Minor
>
> Under "Implementing Durable Client/Server Messaging" there's a diagram that 
> is incomplete due to cropping on the right-hand side. Needs to be restored 
> from source (if one can be found) or redrawn for completeness.
> The image source file is 
> ...geode-docs/images/ClientServerAdvancedTopics-6.gif. Manual page is 
> http://geode.apache.org/docs/guide/12/developing/events/implementing_durable_client_server_messaging.html,
>  under the "Reconnection" heading. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (GEODE-3723) Reconsider using Optional as the parameter for getRequiredPermissions

2017-10-04 Thread Karen Smoler Miller (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-3723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karen Smoler Miller reassigned GEODE-3723:
--

Assignee: Karen Smoler Miller

> Reconsider using Optional as the parameter for getRequiredPermissions
> -
>
> Key: GEODE-3723
> URL: https://issues.apache.org/jira/browse/GEODE-3723
> Project: Geode
>  Issue Type: Bug
>  Components: security
>Reporter: Dan Smith
>Assignee: Karen Smoler Miller
> Fix For: 1.3.0
>
>
> The new method on function, getRequiredPermissions takes an Optional 
> as parameter.
> At point point, we added a parameterized type to the function interface 
> (Function). However, if someone tries to implement Function without the 
> type (eg implements Function instead of implemments Function), then 
> they get the below compilation error:
> {noformat}
> Error:(85, 41) java: name clash: 
> getRequiredPermissions(java.util.Optional) in 
> org.apache.geode.cache.lucene.internal.distributed.WaitUntilFlushedFunction 
> and getRequiredPermissions(java.util.Optional) in 
> org.apache.geode.cache.execute.Function have the same erasure, yet neither 
> overrides the other
> {noformat}
> In addition to this annoyance Optional is generally discouraged as a 
> parameter to a method in favor of method overloading. At least my IDE is 
> providing a warning to that effect. Maybe having an overloaded method for 
> getRequiredPermissions would be better?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (GEODE-3744) Local region on a peer node that does not host the transaction should not involve in the transaction

2017-10-04 Thread Eric Shu (JIRA)
Eric Shu created GEODE-3744:
---

 Summary: Local region on a peer node that does not host the 
transaction should not involve in the transaction
 Key: GEODE-3744
 URL: https://issues.apache.org/jira/browse/GEODE-3744
 Project: Geode
  Issue Type: Bug
  Components: transactions
Reporter: Eric Shu


Currently, if a peer N1 initiate a transaction, and the transaction is hosted 
on another peer N2, it can do operation on a local region within the 
transaction. If the N2 also has a local region has the same name, the 
transaction will forward the operation onto transaction host (N2), Product 
should throw exception if this is situation is detected.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (GEODE-3744) Local region on a peer node that does not host the transaction should not involve in the transaction

2017-10-04 Thread Eric Shu (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-3744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Shu reassigned GEODE-3744:
---

Assignee: Eric Shu

> Local region on a peer node that does not host the transaction should not 
> involve in the transaction
> 
>
> Key: GEODE-3744
> URL: https://issues.apache.org/jira/browse/GEODE-3744
> Project: Geode
>  Issue Type: Bug
>  Components: transactions
>Reporter: Eric Shu
>Assignee: Eric Shu
>
> Currently, if a peer N1 initiate a transaction, and the transaction is hosted 
> on another peer N2, it can do operation on a local region within the 
> transaction. If the N2 also has a local region has the same name, the 
> transaction will forward the operation onto transaction host (N2), Product 
> should throw exception if this is situation is detected.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (GEODE-3712) PartitionedRegionQueryEvaluator should shuffle node list

2017-10-04 Thread Jason Huynh (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-3712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Huynh resolved GEODE-3712.

   Resolution: Fixed
Fix Version/s: 1.3.0

> PartitionedRegionQueryEvaluator should shuffle node list
> 
>
> Key: GEODE-3712
> URL: https://issues.apache.org/jira/browse/GEODE-3712
> Project: Geode
>  Issue Type: Bug
>  Components: querying
>Reporter: Jason Huynh
>Assignee: Jason Huynh
> Fix For: 1.3.0
>
>
> When executing a query from a peer, the peer will retrieve a node list and 
> determine which nodes contain which buckets.  If this node list is ordered, 
> then the same nodes will continue to get hit.
> Instead we should probably shuffle this list to allow different nodes to be 
> queried against.
> This does not affect client/server queries.  Just peer accessors.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (GEODE-3247) Improve OQL expression execution

2017-10-04 Thread Karen Smoler Miller (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-3247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karen Smoler Miller updated GEODE-3247:
---
Component/s: docs

> Improve OQL expression execution
> 
>
> Key: GEODE-3247
> URL: https://issues.apache.org/jira/browse/GEODE-3247
> Project: Geode
>  Issue Type: Bug
>  Components: docs, querying
>Reporter: Anthony Baker
>Assignee: Jason Huynh
> Fix For: 1.3.0
>
>
> We should validate an OQL expression before attempting to invoke it to 
> prevent undesirable behavior.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Reopened] (GEODE-3247) Improve OQL expression execution

2017-10-04 Thread Jason Huynh (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-3247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Huynh reopened GEODE-3247:


Reopening ticket for time being.  I added a system property:
QueryService.allowUntrustedMethodInvocation to allow existing users to get the 
same behavior they have today (if for some reason they were wanting it).  
Setting this flag to true will not restrict method invocations.  Method 
invocations would no longer restricted for data:read permissions.

Docs should have a chance to update the docs to reflect this before closing 
this ticket

> Improve OQL expression execution
> 
>
> Key: GEODE-3247
> URL: https://issues.apache.org/jira/browse/GEODE-3247
> Project: Geode
>  Issue Type: Bug
>  Components: querying
>Reporter: Anthony Baker
>Assignee: Jason Huynh
> Fix For: 1.3.0
>
>
> We should validate an OQL expression before attempting to invoke it to 
> prevent undesirable behavior.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (GEODE-3542) Show Metrics fails when all parameters are provided

2017-10-04 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-3542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191380#comment-16191380
 ] 

ASF subversion and git services commented on GEODE-3542:


Commit 710524ec4a6e8bb8b604f4e0bd0d4f89ff99e7be in geode's branch 
refs/heads/develop from [~jens.deppe]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=710524e ]

Merge pull request #836 from jdeppe-pivotal/feature/GEODE-3542

GEODE-3542: Add descriptive error message for gfsh show metrics

> Show Metrics fails when all parameters are provided
> ---
>
> Key: GEODE-3542
> URL: https://issues.apache.org/jira/browse/GEODE-3542
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>
> The `show metrics` command accepts optional parameters `member`, `port`, and 
> `region`.
> When all three provided, the command returns the error
> {noformat}
> If the --port parameter is specified, then the --member parameter must also 
> be specified.
> {noformat}
> If this is actually an invalid combination of parameters, the reported error 
> should be updated to indicate the true problem.  Otherwise, correct reporting 
> of metrics should occur.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (GEODE-3542) Show Metrics fails when all parameters are provided

2017-10-04 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-3542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191375#comment-16191375
 ] 

ASF subversion and git services commented on GEODE-3542:


Commit a5738310c89e61fb038cc503a7199ab31b1da4cb in geode's branch 
refs/heads/develop from [~jens.deppe]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=a573831 ]

GEODE-3542: Increase await timeout to 2 minutes in case of long GCs on slow 
systems


> Show Metrics fails when all parameters are provided
> ---
>
> Key: GEODE-3542
> URL: https://issues.apache.org/jira/browse/GEODE-3542
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>
> The `show metrics` command accepts optional parameters `member`, `port`, and 
> `region`.
> When all three provided, the command returns the error
> {noformat}
> If the --port parameter is specified, then the --member parameter must also 
> be specified.
> {noformat}
> If this is actually an invalid combination of parameters, the reported error 
> should be updated to indicate the true problem.  Otherwise, correct reporting 
> of metrics should occur.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (GEODE-3542) Show Metrics fails when all parameters are provided

2017-10-04 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-3542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191378#comment-16191378
 ] 

ASF subversion and git services commented on GEODE-3542:


Commit f89649190677eee80e76704f352baba2202af53b in geode's branch 
refs/heads/develop from [~jens.deppe]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=f896491 ]

GEODE-3542: Spotless changes


> Show Metrics fails when all parameters are provided
> ---
>
> Key: GEODE-3542
> URL: https://issues.apache.org/jira/browse/GEODE-3542
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>
> The `show metrics` command accepts optional parameters `member`, `port`, and 
> `region`.
> When all three provided, the command returns the error
> {noformat}
> If the --port parameter is specified, then the --member parameter must also 
> be specified.
> {noformat}
> If this is actually an invalid combination of parameters, the reported error 
> should be updated to indicate the true problem.  Otherwise, correct reporting 
> of metrics should occur.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (GEODE-3542) Show Metrics fails when all parameters are provided

2017-10-04 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-3542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191376#comment-16191376
 ] 

ASF subversion and git services commented on GEODE-3542:


Commit bf7d83c570d274119e9a5ee2eb5f068377094903 in geode's branch 
refs/heads/develop from [~jens.deppe]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=bf7d83c ]

Merge branch 'develop' into feature/GEODE-3542


> Show Metrics fails when all parameters are provided
> ---
>
> Key: GEODE-3542
> URL: https://issues.apache.org/jira/browse/GEODE-3542
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>
> The `show metrics` command accepts optional parameters `member`, `port`, and 
> `region`.
> When all three provided, the command returns the error
> {noformat}
> If the --port parameter is specified, then the --member parameter must also 
> be specified.
> {noformat}
> If this is actually an invalid combination of parameters, the reported error 
> should be updated to indicate the true problem.  Otherwise, correct reporting 
> of metrics should occur.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (GEODE-3542) Show Metrics fails when all parameters are provided

2017-10-04 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-3542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191379#comment-16191379
 ] 

ASF subversion and git services commented on GEODE-3542:


Commit 710524ec4a6e8bb8b604f4e0bd0d4f89ff99e7be in geode's branch 
refs/heads/develop from [~jens.deppe]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=710524e ]

Merge pull request #836 from jdeppe-pivotal/feature/GEODE-3542

GEODE-3542: Add descriptive error message for gfsh show metrics

> Show Metrics fails when all parameters are provided
> ---
>
> Key: GEODE-3542
> URL: https://issues.apache.org/jira/browse/GEODE-3542
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>
> The `show metrics` command accepts optional parameters `member`, `port`, and 
> `region`.
> When all three provided, the command returns the error
> {noformat}
> If the --port parameter is specified, then the --member parameter must also 
> be specified.
> {noformat}
> If this is actually an invalid combination of parameters, the reported error 
> should be updated to indicate the true problem.  Otherwise, correct reporting 
> of metrics should occur.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (GEODE-3542) Show Metrics fails when all parameters are provided

2017-10-04 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-3542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191377#comment-16191377
 ] 

ASF subversion and git services commented on GEODE-3542:


Commit 7018d2db9f539d6af4a439e9f3d4e4ede4d6ea03 in geode's branch 
refs/heads/develop from [~jens.deppe]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=7018d2d ]

GEODE-3542: Refactor test for show metrics command


> Show Metrics fails when all parameters are provided
> ---
>
> Key: GEODE-3542
> URL: https://issues.apache.org/jira/browse/GEODE-3542
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>
> The `show metrics` command accepts optional parameters `member`, `port`, and 
> `region`.
> When all three provided, the command returns the error
> {noformat}
> If the --port parameter is specified, then the --member parameter must also 
> be specified.
> {noformat}
> If this is actually an invalid combination of parameters, the reported error 
> should be updated to indicate the true problem.  Otherwise, correct reporting 
> of metrics should occur.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (GEODE-3542) Show Metrics fails when all parameters are provided

2017-10-04 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-3542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191374#comment-16191374
 ] 

ASF subversion and git services commented on GEODE-3542:


Commit b891fd0a6eb3d3da3dd6cfbc7f2ef1cf294ec002 in geode's branch 
refs/heads/develop from [~jens.deppe]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=b891fd0 ]

GEODE-3542: Add descriptive error message for gfsh show metrics


> Show Metrics fails when all parameters are provided
> ---
>
> Key: GEODE-3542
> URL: https://issues.apache.org/jira/browse/GEODE-3542
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>
> The `show metrics` command accepts optional parameters `member`, `port`, and 
> `region`.
> When all three provided, the command returns the error
> {noformat}
> If the --port parameter is specified, then the --member parameter must also 
> be specified.
> {noformat}
> If this is actually an invalid combination of parameters, the reported error 
> should be updated to indicate the true problem.  Otherwise, correct reporting 
> of metrics should occur.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (GEODE-3723) Reconsider using Optional as the parameter for getRequiredPermissions

2017-10-04 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-3723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191273#comment-16191273
 ] 

ASF subversion and git services commented on GEODE-3723:


Commit fbe8bd689256fd2115fbe90b0d8ce7895a849a3a in geode's branch 
refs/heads/develop from [~jens.deppe]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=fbe8bd6 ]

Merge pull request #857 from jdeppe-pivotal/feature/GEODE-3723

GEODE-3723: Remove Optional from getRequiredPermissions

> Reconsider using Optional as the parameter for getRequiredPermissions
> -
>
> Key: GEODE-3723
> URL: https://issues.apache.org/jira/browse/GEODE-3723
> Project: Geode
>  Issue Type: Bug
>  Components: security
>Reporter: Dan Smith
> Fix For: 1.3.0
>
>
> The new method on function, getRequiredPermissions takes an Optional 
> as parameter.
> At point point, we added a parameterized type to the function interface 
> (Function). However, if someone tries to implement Function without the 
> type (eg implements Function instead of implemments Function), then 
> they get the below compilation error:
> {noformat}
> Error:(85, 41) java: name clash: 
> getRequiredPermissions(java.util.Optional) in 
> org.apache.geode.cache.lucene.internal.distributed.WaitUntilFlushedFunction 
> and getRequiredPermissions(java.util.Optional) in 
> org.apache.geode.cache.execute.Function have the same erasure, yet neither 
> overrides the other
> {noformat}
> In addition to this annoyance Optional is generally discouraged as a 
> parameter to a method in favor of method overloading. At least my IDE is 
> providing a warning to that effect. Maybe having an overloaded method for 
> getRequiredPermissions would be better?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (GEODE-3723) Reconsider using Optional as the parameter for getRequiredPermissions

2017-10-04 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-3723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191271#comment-16191271
 ] 

ASF subversion and git services commented on GEODE-3723:


Commit 1fd61c2ab00542ad98564ab7271794a0141630a5 in geode's branch 
refs/heads/develop from [~jens.deppe]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=1fd61c2 ]

GEODE-3723: Remove Optional from getRequiredPermissions


> Reconsider using Optional as the parameter for getRequiredPermissions
> -
>
> Key: GEODE-3723
> URL: https://issues.apache.org/jira/browse/GEODE-3723
> Project: Geode
>  Issue Type: Bug
>  Components: security
>Reporter: Dan Smith
> Fix For: 1.3.0
>
>
> The new method on function, getRequiredPermissions takes an Optional 
> as parameter.
> At point point, we added a parameterized type to the function interface 
> (Function). However, if someone tries to implement Function without the 
> type (eg implements Function instead of implemments Function), then 
> they get the below compilation error:
> {noformat}
> Error:(85, 41) java: name clash: 
> getRequiredPermissions(java.util.Optional) in 
> org.apache.geode.cache.lucene.internal.distributed.WaitUntilFlushedFunction 
> and getRequiredPermissions(java.util.Optional) in 
> org.apache.geode.cache.execute.Function have the same erasure, yet neither 
> overrides the other
> {noformat}
> In addition to this annoyance Optional is generally discouraged as a 
> parameter to a method in favor of method overloading. At least my IDE is 
> providing a warning to that effect. Maybe having an overloaded method for 
> getRequiredPermissions would be better?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (GEODE-3723) Reconsider using Optional as the parameter for getRequiredPermissions

2017-10-04 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-3723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191272#comment-16191272
 ] 

ASF subversion and git services commented on GEODE-3723:


Commit fbe8bd689256fd2115fbe90b0d8ce7895a849a3a in geode's branch 
refs/heads/develop from [~jens.deppe]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=fbe8bd6 ]

Merge pull request #857 from jdeppe-pivotal/feature/GEODE-3723

GEODE-3723: Remove Optional from getRequiredPermissions

> Reconsider using Optional as the parameter for getRequiredPermissions
> -
>
> Key: GEODE-3723
> URL: https://issues.apache.org/jira/browse/GEODE-3723
> Project: Geode
>  Issue Type: Bug
>  Components: security
>Reporter: Dan Smith
> Fix For: 1.3.0
>
>
> The new method on function, getRequiredPermissions takes an Optional 
> as parameter.
> At point point, we added a parameterized type to the function interface 
> (Function). However, if someone tries to implement Function without the 
> type (eg implements Function instead of implemments Function), then 
> they get the below compilation error:
> {noformat}
> Error:(85, 41) java: name clash: 
> getRequiredPermissions(java.util.Optional) in 
> org.apache.geode.cache.lucene.internal.distributed.WaitUntilFlushedFunction 
> and getRequiredPermissions(java.util.Optional) in 
> org.apache.geode.cache.execute.Function have the same erasure, yet neither 
> overrides the other
> {noformat}
> In addition to this annoyance Optional is generally discouraged as a 
> parameter to a method in favor of method overloading. At least my IDE is 
> providing a warning to that effect. Maybe having an overloaded method for 
> getRequiredPermissions would be better?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)