[jira] [Updated] (GEODE-4781) Categorize Lucene tests
[ https://issues.apache.org/jira/browse/GEODE-4781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-4781: -- Labels: pull-request-available (was: ) > Categorize Lucene tests > --- > > Key: GEODE-4781 > URL: https://issues.apache.org/jira/browse/GEODE-4781 > Project: Geode > Issue Type: Bug > Components: lucene >Reporter: nabarun >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (GEODE-4781) Categorize Lucene tests
nabarun created GEODE-4781: -- Summary: Categorize Lucene tests Key: GEODE-4781 URL: https://issues.apache.org/jira/browse/GEODE-4781 Project: Geode Issue Type: Bug Components: lucene Reporter: nabarun -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GEODE-4777) Add UITest job to concourse develop pipeline
[ https://issues.apache.org/jira/browse/GEODE-4777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-4777: -- Labels: pull-request-available (was: ) > Add UITest job to concourse develop pipeline > > > Key: GEODE-4777 > URL: https://issues.apache.org/jira/browse/GEODE-4777 > Project: Geode > Issue Type: Task > Components: ci, pulse >Reporter: Sai Boorlagadda >Assignee: Sai Boorlagadda >Priority: Major > Labels: pull-request-available > > Add a UITest job to concourse develop pipeline to run `gradlew uiTest` to run > selenium tests as part of the CI pipeline. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GEODE-182) Generate "random" member names if no name is provided
[
https://issues.apache.org/jira/browse/GEODE-182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated GEODE-182:
-
Labels: pull-request-available (was: )
> Generate "random" member names if no name is provided
> -
>
> Key: GEODE-182
> URL: https://issues.apache.org/jira/browse/GEODE-182
> Project: Geode
> Issue Type: New Feature
> Components: configuration
>Reporter: William Markito Oliveira
>Assignee: Kirk Lund
>Priority: Minor
> Labels: pull-request-available
> Fix For: 1.1.0
>
>
> In current cloud and container deployments it's very common to allow the
> infrastructure to just re-execute the same command in order to provision a
> new node for a system.
> Since Geode require unique member names on a system I'm proposing to create
> something similar to what Docker and other projects does and generate
> "random" names on when none are provided.
> Following the Docker implementation, I'd suggest something like:
> * List of adjectives
> * List of gems
> and a combination using _ for example:
> {code}
> clever_alexandrite
> sharp_emerald
> tender_sapphire
> {code}
> Those would be server names when *-name* param is not specified OR if a
> *property file* doesn't have a name as well.
> From the initial list I'm thinking the model would have:
> * Adjectives = 56
> * Names = 70
> * Total names possible = 3920
> Other benefits I can see for non-cloud deployments as well is for example
> setting member ports to 0 and by providing no name, it's also easier to
> create multiple geode nodes on the same physical host without specifying
> names.
> This wouldn't change current naming features and capabilities. I'm not
> planning to implement the feature for locators initially.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (GEODE-4764) NPEs encountered during lucene create index (on existing region)
[
https://issues.apache.org/jira/browse/GEODE-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated GEODE-4764:
--
Labels: pull-request-available (was: )
> NPEs encountered during lucene create index (on existing region)
>
>
> Key: GEODE-4764
> URL: https://issues.apache.org/jira/browse/GEODE-4764
> Project: Geode
> Issue Type: Sub-task
> Components: lucene
>Affects Versions: 1.5.0
>Reporter: Shelley Lynn Hughes-Godfrey
>Assignee: Shelley Lynn Hughes-Godfrey
>Priority: Major
> Labels: pull-request-available
>
> There are currently two potential NPEs in LuceneServiceImpl during index
> creation on an existing region.
> The first occurs when a bucket is moved during indexing:
> {noformat}
> at
> org.apache.geode.cache.lucene.internal.LuceneServiceImpl.createLuceneIndexOnDataRegion(LuceneServiceImpl.java:294)
> at
> org.apache.geode.cache.lucene.internal.LuceneServiceImpl.createIndexOnExistingRegion(LuceneServiceImpl.java:277)
> at
> org.apache.geode.cache.lucene.internal.LuceneServiceImpl.createIndex(LuceneServiceImpl.java:257)
> at
> org.apache.geode.cache.lucene.internal.LuceneServiceImpl.createIndex(LuceneServiceImpl.java:226)
> at
> org.apache.geode.cache.lucene.internal.LuceneIndexFactoryImpl.create(LuceneIndexFactoryImpl.java:70)
> {noformat}
> The second occurs when the LuceneEventListener attempts to process events
> before the Lucene Index has been fully initialized (and userRegion set).
> {noformat}
> at
> org.apache.geode.internal.cache.wan.GatewaySenderEventCallbackDispatcher.dispatchBatch(GatewaySenderEventCallbackDispatcher.java:164)
> at
> org.apache.geode.internal.cache.wan.GatewaySenderEventCallbackDispatcher.dispatchBatch(GatewaySenderEventCallbackDispatcher.java:80)
> at
> org.apache.geode.internal.cache.wan.AbstractGatewaySenderEventProcessor.processQueue(AbstractGatewaySenderEventProcessor.java:610)
> at
> org.apache.geode.internal.cache.wan.AbstractGatewaySenderEventProcessor.run(AbstractGatewaySenderEventProcessor.java:1051)
> Caused by: java.lang.NullPointerException
> at
> org.apache.geode.cache.lucene.internal.AbstractPartitionedRepositoryManager.getRepository(AbstractPartitionedRepositoryManager.java:70)
> at
> org.apache.geode.cache.lucene.internal.LuceneEventListener.process(LuceneEventListener.java:86)
> at
> org.apache.geode.cache.lucene.internal.LuceneEventListener.processEvents(LuceneEventListener.java:63)
> at
> org.apache.geode.internal.cache.wan.GatewaySenderEventCallbackDispatcher.dispatchBatch(GatewaySenderEventCallbackDispatcher.java:154)
> ... 3 more
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (GEODE-4767) [CI Fialure] LuceneIndexMaintenanceIntegrationTest - serializerExceptionShouldNotImpactOtherEvents
[
https://issues.apache.org/jira/browse/GEODE-4767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
nabarun updated GEODE-4767:
---
Fix Version/s: (was: 1.6.0)
> [CI Fialure] LuceneIndexMaintenanceIntegrationTest -
> serializerExceptionShouldNotImpactOtherEvents
> --
>
> Key: GEODE-4767
> URL: https://issues.apache.org/jira/browse/GEODE-4767
> Project: Geode
> Issue Type: Bug
> Components: lucene
>Reporter: nabarun
>Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> *+Test Run+* :
> https://concourse.apachegeode-ci.info/teams/main/pipelines/develop/jobs/IntegrationTest/builds/244
> *+Stacktrace+*:
> {noformat}
> java.lang.AssertionError: expected:<8> but was:<7>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:645)
> at org.junit.Assert.assertEquals(Assert.java:631)
> at
> org.apache.geode.cache.lucene.LuceneIndexMaintenanceIntegrationTest.serializerExceptionShouldNotImpactOtherEvents(LuceneIndexMaintenanceIntegrationTest.java:162)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
> at
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
> at
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
> at
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
> at
> org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
> at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
> at
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
> at
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
> at
>
[jira] [Updated] (GEODE-4780) Categorize CQ tests
[ https://issues.apache.org/jira/browse/GEODE-4780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-4780: -- Labels: pull-request-available (was: ) > Categorize CQ tests > --- > > Key: GEODE-4780 > URL: https://issues.apache.org/jira/browse/GEODE-4780 > Project: Geode > Issue Type: Task > Components: cq >Reporter: Jason Huynh >Assignee: Jason Huynh >Priority: Major > Labels: pull-request-available > > Add a CQTest category and categorize all cq tests -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (GEODE-4780) Categorize CQ tests
Jason Huynh created GEODE-4780: -- Summary: Categorize CQ tests Key: GEODE-4780 URL: https://issues.apache.org/jira/browse/GEODE-4780 Project: Geode Issue Type: Task Components: cq Reporter: Jason Huynh Add a CQTest category and categorize all cq tests -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (GEODE-4780) Categorize CQ tests
[ https://issues.apache.org/jira/browse/GEODE-4780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Huynh reassigned GEODE-4780: -- Assignee: Jason Huynh > Categorize CQ tests > --- > > Key: GEODE-4780 > URL: https://issues.apache.org/jira/browse/GEODE-4780 > Project: Geode > Issue Type: Task > Components: cq >Reporter: Jason Huynh >Assignee: Jason Huynh >Priority: Major > > Add a CQTest category and categorize all cq tests -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (GEODE-3932) create lucene index on existing region should not wait for a query to index data
[ https://issues.apache.org/jira/browse/GEODE-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Huynh resolved GEODE-3932. Resolution: Fixed This was completed with the checkin for GEODE-3928. > create lucene index on existing region should not wait for a query to index > data > > > Key: GEODE-3932 > URL: https://issues.apache.org/jira/browse/GEODE-3932 > Project: Geode > Issue Type: Sub-task > Components: lucene >Reporter: Jason Huynh >Priority: Major > > GEODE-3928 is about making sure that after a lucene index is added to an > existing region, the data in the region is indexed for queries. > This task is clarifying that we should not wait until a query is executed > before indexing the data. The implementation details of GEODE-3928 are vague > about whether the indexing will happen immediately or when a query executes. > Acceptance: > After calling create lucene index on an existing region, indexing should > begin and stats should reflect that data is added to the index. > Implementation Details: > There may be nothing to do here, depending on how GEODE-3928 is implemented. > But if we haven't done anything to eagerly trigger indexing of data, we may > need to add a second function to call computeRepository on all members after > the index is created on all members. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GEODE-4770) Destroying an unstarted GatewayReceiver throws an NPE
[
https://issues.apache.org/jira/browse/GEODE-4770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated GEODE-4770:
--
Labels: pull-request-available (was: )
> Destroying an unstarted GatewayReceiver throws an NPE
> -
>
> Key: GEODE-4770
> URL: https://issues.apache.org/jira/browse/GEODE-4770
> Project: Geode
> Issue Type: Bug
> Components: wan
>Affects Versions: 1.4.0
>Reporter: Kenneth Howe
>Priority: Major
> Labels: pull-request-available
>
> Found while writing tests for a new Gfsh command to destroy a GatewayReceiver:
> Create a GatewayReceiver with manualStart = true
> {{create gateway-receiver --manual-start==true ...}}
> NPE is thrown by the {{destroy()}} in the Function that implements the new
> {{destroy gateway-receiver}} command.
> {code:java}
> if (receiver.isRunning()) {
> receiver.stop();
> }
> receiver.destroy();
> {code}
> NPE is thrown here:
> {code:java|title=GatewayReceiverImpl}
> public void destroy() {
> if (receiver.isRunning()) {
> {code}
> because {{receiver}} is not set until the the GatewayReceiver is started.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (GEODE-4779) Categorize OQL Query and Index Tests
[ https://issues.apache.org/jira/browse/GEODE-4779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-4779: -- Labels: pull-request-available (was: ) > Categorize OQL Query and Index Tests > > > Key: GEODE-4779 > URL: https://issues.apache.org/jira/browse/GEODE-4779 > Project: Geode > Issue Type: Task > Components: querying >Reporter: Jason Huynh >Assignee: Jason Huynh >Priority: Major > Labels: pull-request-available > > Add a new category for tests and mark query and index tests appropriately -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (GEODE-4696) Refactor validateCommandParameters from LuceneServiceImpl
[ https://issues.apache.org/jira/browse/GEODE-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nabarun resolved GEODE-4696. Resolution: Fixed Fix Version/s: 1.6.0 > Refactor validateCommandParameters from LuceneServiceImpl > - > > Key: GEODE-4696 > URL: https://issues.apache.org/jira/browse/GEODE-4696 > Project: Geode > Issue Type: Bug > Components: lucene >Reporter: Jason Huynh >Priority: Minor > Labels: pull-request-available > Fix For: 1.6.0 > > Time Spent: 40m > Remaining Estimate: 0h > > The ValidateCommandParameters enum should probably be pulled out from > LuceneServiceImpl into it's own class and additional unit tests should be > introduced to test various strings against the pattern matching. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (GEODE-4767) [CI Fialure] LuceneIndexMaintenanceIntegrationTest - serializerExceptionShouldNotImpactOtherEvents
[
https://issues.apache.org/jira/browse/GEODE-4767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
nabarun resolved GEODE-4767.
Resolution: Fixed
Fix Version/s: 1.6.0
> [CI Fialure] LuceneIndexMaintenanceIntegrationTest -
> serializerExceptionShouldNotImpactOtherEvents
> --
>
> Key: GEODE-4767
> URL: https://issues.apache.org/jira/browse/GEODE-4767
> Project: Geode
> Issue Type: Bug
> Components: lucene
>Reporter: nabarun
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.6.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> *+Test Run+* :
> https://concourse.apachegeode-ci.info/teams/main/pipelines/develop/jobs/IntegrationTest/builds/244
> *+Stacktrace+*:
> {noformat}
> java.lang.AssertionError: expected:<8> but was:<7>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:645)
> at org.junit.Assert.assertEquals(Assert.java:631)
> at
> org.apache.geode.cache.lucene.LuceneIndexMaintenanceIntegrationTest.serializerExceptionShouldNotImpactOtherEvents(LuceneIndexMaintenanceIntegrationTest.java:162)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
> at
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
> at
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
> at
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
> at
> org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
> at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
> at
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
> at
>
[jira] [Closed] (GEODE-4767) [CI Fialure] LuceneIndexMaintenanceIntegrationTest - serializerExceptionShouldNotImpactOtherEvents
[
https://issues.apache.org/jira/browse/GEODE-4767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
nabarun closed GEODE-4767.
--
> [CI Fialure] LuceneIndexMaintenanceIntegrationTest -
> serializerExceptionShouldNotImpactOtherEvents
> --
>
> Key: GEODE-4767
> URL: https://issues.apache.org/jira/browse/GEODE-4767
> Project: Geode
> Issue Type: Bug
> Components: lucene
>Reporter: nabarun
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.6.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> *+Test Run+* :
> https://concourse.apachegeode-ci.info/teams/main/pipelines/develop/jobs/IntegrationTest/builds/244
> *+Stacktrace+*:
> {noformat}
> java.lang.AssertionError: expected:<8> but was:<7>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:645)
> at org.junit.Assert.assertEquals(Assert.java:631)
> at
> org.apache.geode.cache.lucene.LuceneIndexMaintenanceIntegrationTest.serializerExceptionShouldNotImpactOtherEvents(LuceneIndexMaintenanceIntegrationTest.java:162)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
> at
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
> at
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
> at
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
> at
> org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
> at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
> at
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
> at
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
> at
>
[jira] [Created] (GEODE-4779) Categorize OQL Query and Index Tests
Jason Huynh created GEODE-4779: -- Summary: Categorize OQL Query and Index Tests Key: GEODE-4779 URL: https://issues.apache.org/jira/browse/GEODE-4779 Project: Geode Issue Type: Task Components: querying Reporter: Jason Huynh Add a new category for tests and mark query and index tests appropriately -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (GEODE-4779) Categorize OQL Query and Index Tests
[ https://issues.apache.org/jira/browse/GEODE-4779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Huynh reassigned GEODE-4779: -- Assignee: Jason Huynh > Categorize OQL Query and Index Tests > > > Key: GEODE-4779 > URL: https://issues.apache.org/jira/browse/GEODE-4779 > Project: Geode > Issue Type: Task > Components: querying >Reporter: Jason Huynh >Assignee: Jason Huynh >Priority: Major > > Add a new category for tests and mark query and index tests appropriately -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GEODE-4774) When starting second locator without Security Manager, displaying incorrect status message
[
https://issues.apache.org/jira/browse/GEODE-4774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Barbara Pruijn updated GEODE-4774:
--
Description:
When I start a second locator without a Security Manager, I get the following
output:
{code:java}
Security Manager is enabled - unable to auto-connect. Please use "connect
--locator=10.118.19.11[13489]" to connect Gfsh to the locator.{code}
However, the output should state:
{code:java}
Cluster configuration service is up and running.{code}
How to reproduce:
{code}
start locator --name=locator1
start locator --name=locator2 --port=13489
{code}
was:
When I start a second locator without a Security Manager, I get the following
output:
{code:java}
Security Manager is enabled - unable to auto-connect. Please use "connect
--locator=10.118.19.11[13489]" to connect Gfsh to the locator.{code}
However, the output should state:
{code:java}
Cluster configuration service is up and running.{code}
> When starting second locator without Security Manager, displaying incorrect
> status message
> --
>
> Key: GEODE-4774
> URL: https://issues.apache.org/jira/browse/GEODE-4774
> Project: Geode
> Issue Type: Bug
> Components: gfsh
>Reporter: Barbara Pruijn
>Priority: Major
>
> When I start a second locator without a Security Manager, I get the following
> output:
> {code:java}
> Security Manager is enabled - unable to auto-connect. Please use "connect
> --locator=10.118.19.11[13489]" to connect Gfsh to the locator.{code}
> However, the output should state:
> {code:java}
> Cluster configuration service is up and running.{code}
> How to reproduce:
> {code}
> start locator --name=locator1
> start locator --name=locator2 --port=13489
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (GEODE-4774) When starting second locator without Security Manager, displaying incorrect status message
[
https://issues.apache.org/jira/browse/GEODE-4774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Barbara Pruijn updated GEODE-4774:
--
Component/s: gfsh
> When starting second locator without Security Manager, displaying incorrect
> status message
> --
>
> Key: GEODE-4774
> URL: https://issues.apache.org/jira/browse/GEODE-4774
> Project: Geode
> Issue Type: Bug
> Components: gfsh
>Reporter: Barbara Pruijn
>Priority: Major
>
> When I start a second locator without a Security Manager, I get the following
> output:
> {code:java}
> Security Manager is enabled - unable to auto-connect. Please use "connect
> --locator=10.118.19.11[13489]" to connect Gfsh to the locator.{code}
> However, the output should state:
> {code:java}
> Cluster configuration service is up and running.{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (GEODE-4778) Code clean up and refactoring for Lucene
[ https://issues.apache.org/jira/browse/GEODE-4778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-4778: -- Labels: pull-request-available (was: ) > Code clean up and refactoring for Lucene > > > Key: GEODE-4778 > URL: https://issues.apache.org/jira/browse/GEODE-4778 > Project: Geode > Issue Type: Sub-task > Components: lucene >Reporter: Jason Huynh >Priority: Major > Labels: pull-request-available > > There are various areas that could be cleaned up in the Lucene module. > This ticket is a general ticket to reduce method calls, condense classes and > remove unneeded variables, among other code clarity/clean up tasks -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GEODE-4408) ChacheableKeys.hpp provides incorrect hashcode functions.
[ https://issues.apache.org/jira/browse/GEODE-4408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-4408: -- Labels: pull-request-available (was: ) > ChacheableKeys.hpp provides incorrect hashcode functions. > - > > Key: GEODE-4408 > URL: https://issues.apache.org/jira/browse/GEODE-4408 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Jacob S. Barrett >Priority: Major > Labels: pull-request-available > > ChacheableKeys.hpp provides incorrect hashcode functions returning uint32_t. > Used mostly internally. Consider removing or moving internal. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GEODE-4115) Remove nullability of InternalLocator.myDS
[
https://issues.apache.org/jira/browse/GEODE-4115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated GEODE-4115:
--
Labels: pull-request-available (was: )
> Remove nullability of InternalLocator.myDS
> --
>
> Key: GEODE-4115
> URL: https://issues.apache.org/jira/browse/GEODE-4115
> Project: Geode
> Issue Type: Improvement
> Components: client/server
>Reporter: Galen O'Sullivan
>Assignee: Michael Dodge
>Priority: Major
> Labels: pull-request-available
>
> {code}
> /**
>* The distributed system owned by this locator, if any. Note that if a ds
> already exists because
>* the locator is being colocated in a normal member this field will be
> null.
>*/
> private InternalDistributedSystem myDs;
> {code}
> I don't think that this should be nullable. It makes things more complicated
> -- when we start a colocated locator, the protobuf protocol statistics
> initialization has to check {{InternalDistributedSystem.getAnyInstance()}} to
> get a DS. Can that call be null? I'm not sure.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GEODE-4385) gfsh command to list jndi binding
[
https://issues.apache.org/jira/browse/GEODE-4385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386610#comment-16386610
]
Barbara Pruijn commented on GEODE-4385:
---
The create jndi-binding command will save any jndi config string in the cluster
config. But the parameters passed into the create jndi-binding command may not
result into a jndi-binding that is valid and can be instantiated at run time on
the server members.
Therefore, the list jndi-binding command will only display jndi-bindings that
have been successfully instantiated on the servers.
The help text for the
{code:java}
help list jndi-binding{code}
should have some text explaining that the list jndi-binding command will list
valid and instantiated jndi-bindings.
> gfsh command to list jndi binding
> -
>
> Key: GEODE-4385
> URL: https://issues.apache.org/jira/browse/GEODE-4385
> Project: Geode
> Issue Type: Sub-task
>Reporter: Barbara Pruijn
>Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> In cache.xml user can specify jndi binding like so:
> {code:java}
>
> jdbc-driver-class="org.postgresql.Driver" user-name="gpadmin"
> password="changeme"
> connection-url="jdbc:postgresql://localhost:5432/gemfire_db">
>
>
> {code}
> A user should be able to list a datasource using the gfsh command {{list
> jndi-binding}}
> Then all jndi-binding names will be displayed.
> Please look at Geode's schema for a list of attributes that can be set:
> [https://github.com/apache/geode-site/blob/master/website/content/schema/cache/cache-1.0.xsd#L1331]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (GEODE-4735) All CliUtils functions should take cache as a parameter if it needs one.
[ https://issues.apache.org/jira/browse/GEODE-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jinmei Liao updated GEODE-4735: --- Description: get rid of Cache.getInstance call from CliUtils and GfshCommand. Commands/functions/tests that use CliUtils should supply its own cache when using these functions. Commands's access to cache should be injected when the commands are initialized. was: get rid of Cache.getInstance call from CliUtils. Commands/functions/tests that use CliUtils should supply its own cache when using these functions. Commands's access to cache should be injected when the commands are initialized. > All CliUtils functions should take cache as a parameter if it needs one. > - > > Key: GEODE-4735 > URL: https://issues.apache.org/jira/browse/GEODE-4735 > Project: Geode > Issue Type: Sub-task >Reporter: Patrick Rhomberg >Assignee: Patrick Rhomberg >Priority: Major > Labels: pull-request-available > Time Spent: 1h > Remaining Estimate: 0h > > get rid of Cache.getInstance call from CliUtils and GfshCommand. > Commands/functions/tests that use CliUtils should supply its own cache when > using these functions. > Commands's access to cache should be injected when the commands are > initialized. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (GEODE-4759) Fix typo of getFunctionExcecutor from DistributionManager
[ https://issues.apache.org/jira/browse/GEODE-4759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Huynh resolved GEODE-4759. Resolution: Fixed > Fix typo of getFunctionExcecutor from DistributionManager > - > > Key: GEODE-4759 > URL: https://issues.apache.org/jira/browse/GEODE-4759 > Project: Geode > Issue Type: Bug >Reporter: Jason Huynh >Assignee: Jason Huynh >Priority: Major > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > There is a typo in getFunctionExcecutor. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GEODE-4775) Apply ArgumentRedactor to JVM arguments.
[ https://issues.apache.org/jira/browse/GEODE-4775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-4775: -- Labels: pull-request-available (was: ) > Apply ArgumentRedactor to JVM arguments. > > > Key: GEODE-4775 > URL: https://issues.apache.org/jira/browse/GEODE-4775 > Project: Geode > Issue Type: Improvement >Reporter: Patrick Rhomberg >Assignee: Patrick Rhomberg >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GEODE-4735) All CliUtils functions should take cache as a parameter if it needs one.
[ https://issues.apache.org/jira/browse/GEODE-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jinmei Liao updated GEODE-4735: --- Description: get rid of Cache.getInstance call from CliUtils. Commands/functions/tests that use CliUtils should supply its own cache when using these functions. Commands's access to cache should be injected when the commands are initialized. was: Many of the CliUtil methods, particularly the "find member" methods, are exclusively used and indeed are on-line calls by GfshCommand methods. The implementation of these methods should belong to the class that consumes them. Moreover, it will make testing / mocking much easier. > All CliUtils functions should take cache as a parameter if it needs one. > - > > Key: GEODE-4735 > URL: https://issues.apache.org/jira/browse/GEODE-4735 > Project: Geode > Issue Type: Sub-task >Reporter: Patrick Rhomberg >Assignee: Patrick Rhomberg >Priority: Major > Labels: pull-request-available > Time Spent: 1h > Remaining Estimate: 0h > > get rid of Cache.getInstance call from CliUtils. Commands/functions/tests > that use CliUtils should supply its own cache when using these functions. > Commands's access to cache should be injected when the commands are > initialized. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (GEODE-4777) Add UITest job to concourse develop pipeline
[ https://issues.apache.org/jira/browse/GEODE-4777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sai Boorlagadda reassigned GEODE-4777: -- Assignee: Sai Boorlagadda > Add UITest job to concourse develop pipeline > > > Key: GEODE-4777 > URL: https://issues.apache.org/jira/browse/GEODE-4777 > Project: Geode > Issue Type: Task > Components: ci, pulse >Reporter: Sai Boorlagadda >Assignee: Sai Boorlagadda >Priority: Major > > Add a UITest job to concourse develop pipeline to run `gradlew uiTest` to run > selenium tests as part of the CI pipeline. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GEODE-4735) All CliUtils functions should take cache as a parameter if it needs one.
[ https://issues.apache.org/jira/browse/GEODE-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jinmei Liao updated GEODE-4735: --- Summary: All CliUtils functions should take cache as a parameter if it needs one. (was: Move CliUtil "find member" methods to GfshCommand) > All CliUtils functions should take cache as a parameter if it needs one. > - > > Key: GEODE-4735 > URL: https://issues.apache.org/jira/browse/GEODE-4735 > Project: Geode > Issue Type: Sub-task >Reporter: Patrick Rhomberg >Assignee: Patrick Rhomberg >Priority: Major > Labels: pull-request-available > Time Spent: 1h > Remaining Estimate: 0h > > Many of the CliUtil methods, particularly the "find member" methods, are > exclusively used and indeed are on-line calls by GfshCommand methods. > The implementation of these methods should belong to the class that consumes > them. > Moreover, it will make testing / mocking much easier. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (GEODE-4777) Add UITest job to concourse develop pipeline
Sai Boorlagadda created GEODE-4777: -- Summary: Add UITest job to concourse develop pipeline Key: GEODE-4777 URL: https://issues.apache.org/jira/browse/GEODE-4777 Project: Geode Issue Type: Task Components: ci, pulse Reporter: Sai Boorlagadda Add a UITest job to concourse develop pipeline to run `gradlew uiTest` to run selenium tests as part of the CI pipeline. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (GEODE-4775) Apply ArgumentRedactor to JVM arguments.
[ https://issues.apache.org/jira/browse/GEODE-4775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Rhomberg reassigned GEODE-4775: --- Assignee: Patrick Rhomberg > Apply ArgumentRedactor to JVM arguments. > > > Key: GEODE-4775 > URL: https://issues.apache.org/jira/browse/GEODE-4775 > Project: Geode > Issue Type: Improvement >Reporter: Patrick Rhomberg >Assignee: Patrick Rhomberg >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GEODE-4776) Migrate to chrome driver for Pulse UI Tests
[ https://issues.apache.org/jira/browse/GEODE-4776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-4776: -- Labels: pull-request-available (was: ) > Migrate to chrome driver for Pulse UI Tests > --- > > Key: GEODE-4776 > URL: https://issues.apache.org/jira/browse/GEODE-4776 > Project: Geode > Issue Type: Improvement > Components: pulse >Reporter: Sai Boorlagadda >Assignee: Sai Boorlagadda >Priority: Major > Labels: pull-request-available > > * Migrate to use chrome web driver > * Remove unused mock implementations on Pulse UI tests > * Fix any failing tests -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (GEODE-4776) Migrate to chrome driver for Pulse UI Tests
Sai Boorlagadda created GEODE-4776: -- Summary: Migrate to chrome driver for Pulse UI Tests Key: GEODE-4776 URL: https://issues.apache.org/jira/browse/GEODE-4776 Project: Geode Issue Type: Improvement Components: pulse Reporter: Sai Boorlagadda * Migrate to use chrome web driver * Remove unused mock implementations on Pulse UI tests * Fix any failing tests -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (GEODE-4776) Migrate to chrome driver for Pulse UI Tests
[ https://issues.apache.org/jira/browse/GEODE-4776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sai Boorlagadda reassigned GEODE-4776: -- Assignee: Sai Boorlagadda > Migrate to chrome driver for Pulse UI Tests > --- > > Key: GEODE-4776 > URL: https://issues.apache.org/jira/browse/GEODE-4776 > Project: Geode > Issue Type: Improvement > Components: pulse >Reporter: Sai Boorlagadda >Assignee: Sai Boorlagadda >Priority: Major > > * Migrate to use chrome web driver > * Remove unused mock implementations on Pulse UI tests > * Fix any failing tests -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (GEODE-4775) Apply ArgumentRedactor to JVM arguments.
Patrick Rhomberg created GEODE-4775: --- Summary: Apply ArgumentRedactor to JVM arguments. Key: GEODE-4775 URL: https://issues.apache.org/jira/browse/GEODE-4775 Project: Geode Issue Type: Improvement Reporter: Patrick Rhomberg -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (GEODE-4774) When starting second locator without Security Manager, displaying incorrect status message
Barbara Pruijn created GEODE-4774:
-
Summary: When starting second locator without Security Manager,
displaying incorrect status message
Key: GEODE-4774
URL: https://issues.apache.org/jira/browse/GEODE-4774
Project: Geode
Issue Type: Bug
Reporter: Barbara Pruijn
When I start a second locator without a Security Manager, I get the following
output:
{code:java}
Security Manager is enabled - unable to auto-connect. Please use "connect
--locator=10.118.19.11[13489]" to connect Gfsh to the locator.{code}
However, the output should state:
{code:java}
Cluster configuration service is up and running.{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (GEODE-4570) Remove singleton calls from product code in org.apache.geode.internal.security
[ https://issues.apache.org/jira/browse/GEODE-4570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Barbara Pruijn resolved GEODE-4570. --- Resolution: Fixed > Remove singleton calls from product code in org.apache.geode.internal.security > -- > > Key: GEODE-4570 > URL: https://issues.apache.org/jira/browse/GEODE-4570 > Project: Geode > Issue Type: Sub-task > Components: security >Reporter: Kirk Lund >Priority: Major > Labels: pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > > These product classes in org.apache.geode.internal.security invoke singleton > getters. > GemFireCacheImpl.getInstance(): > * SecurityServiceFactory -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GEODE-2001) Refactor logging tests with a junit rule
[ https://issues.apache.org/jira/browse/GEODE-2001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2001: - Component/s: (was: logging) > Refactor logging tests with a junit rule > > > Key: GEODE-2001 > URL: https://issues.apache.org/jira/browse/GEODE-2001 > Project: Geode > Issue Type: Wish > Components: tests >Reporter: Kirk Lund >Assignee: Kirk Lund >Priority: Minor > > Refactor logging tests with a junit rule > The tests that would benefit the most are: > CustomConfigWithCacheIntegrationTest > CustomConfigWithLogServiceIntegrationTest -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Reopened] (GEODE-2001) Refactor logging tests with a junit rule
[ https://issues.apache.org/jira/browse/GEODE-2001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund reopened GEODE-2001: -- > Refactor logging tests with a junit rule > > > Key: GEODE-2001 > URL: https://issues.apache.org/jira/browse/GEODE-2001 > Project: Geode > Issue Type: Wish > Components: tests >Reporter: Kirk Lund >Assignee: Kirk Lund >Priority: Minor > > Refactor logging tests with a junit rule > The tests that would benefit the most are: > CustomConfigWithCacheIntegrationTest > CustomConfigWithLogServiceIntegrationTest -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (GEODE-4773) We should log sender IP when failing incoming connections
Brian Rowe created GEODE-4773: - Summary: We should log sender IP when failing incoming connections Key: GEODE-4773 URL: https://issues.apache.org/jira/browse/GEODE-4773 Project: Geode Issue Type: New Feature Components: client/server Reporter: Brian Rowe It would be very convenient to have a way to see where invalid connection requests were originating from. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (GEODE-4722) Code Improvement: Refactor CliUtil
[ https://issues.apache.org/jira/browse/GEODE-4722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Rhomberg resolved GEODE-4722. - Resolution: Fixed > Code Improvement: Refactor CliUtil > -- > > Key: GEODE-4722 > URL: https://issues.apache.org/jira/browse/GEODE-4722 > Project: Geode > Issue Type: Improvement >Reporter: Patrick Rhomberg >Assignee: Patrick Rhomberg >Priority: Major > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > This class could use some cleaning. Many methods are unused, some trivially > replaced by Apache Commons libraries. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (GEODE-4733) Replace and remove trivial methods from ObjectUtils
[
https://issues.apache.org/jira/browse/GEODE-4733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrick Rhomberg resolved GEODE-4733.
-
Resolution: Fixed
> Replace and remove trivial methods from ObjectUtils
> ---
>
> Key: GEODE-4733
> URL: https://issues.apache.org/jira/browse/GEODE-4733
> Project: Geode
> Issue Type: Sub-task
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> For instance, {{defaultIfNull(T... values)}} is exclusively called with two
> input parameters, while the method name and signature makes it unclear that
> the second value is meant to be the default value if the first parameter is
> null.
> This method can be cleanly replaced by a ternary {{v1 != null ? v1 : v2}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (GEODE-4662) Protobuf: Add GetEntryCount message
[ https://issues.apache.org/jira/browse/GEODE-4662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Dodge reassigned GEODE-4662: Assignee: Michael Dodge > Protobuf: Add GetEntryCount message > --- > > Key: GEODE-4662 > URL: https://issues.apache.org/jira/browse/GEODE-4662 > Project: Geode > Issue Type: New Feature > Components: client/server >Reporter: Brian Baynes >Assignee: Michael Dodge >Priority: Major > Labels: pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > > As a dev using the new protocol, I need to be able to retrive the entry count > for a given region. > Add GetEntryCount message, returning the count of entries for the provided > region. Return an error if the region does not exist. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GEODE-4427) Cleanup function pointer types in Serializable.hpp
[
https://issues.apache.org/jira/browse/GEODE-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Addison updated GEODE-4427:
---
Description:
This callback should not be in Serializable.hpp or it might not be needed.
{code:java}
typedef void (*CliCallbackMethod)(Cache );{code}
Modernize the below header to used std::function.
This should implement {{std::function}}.
{code:java}
typedef PdxSerializable* (*TypeFactoryMethodPdx)();{code}
was:
This is probably doesn't belong here.
{code:java}
typedef void (*CliCallbackMethod)(Cache );{code}
This should implement {{std::function}}.
{code:java}
typedef PdxSerializable* (*TypeFactoryMethodPdx)();{code}
> Cleanup function pointer types in Serializable.hpp
> --
>
> Key: GEODE-4427
> URL: https://issues.apache.org/jira/browse/GEODE-4427
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Jacob S. Barrett
>Priority: Major
>
> This callback should not be in Serializable.hpp or it might not be needed.
> {code:java}
> typedef void (*CliCallbackMethod)(Cache );{code}
> Modernize the below header to used std::function.
> This should implement {{std::function}}.
> {code:java}
> typedef PdxSerializable* (*TypeFactoryMethodPdx)();{code}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (GEODE-4427) Cleanup function pointer types in Serializable.hpp
[
https://issues.apache.org/jira/browse/GEODE-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Addison updated GEODE-4427:
---
Description:
This callback should not be in Serializable.hpp or it might not be needed. At
the very least, this should be removed from the public API.
{code:java}
typedef void (*CliCallbackMethod)(Cache );{code}
Modernize the below header to used std::function.
This should implement {{std::function}}.
{code:java}
typedef PdxSerializable* (*TypeFactoryMethodPdx)();{code}
was:
This callback should not be in Serializable.hpp or it might not be needed.
{code:java}
typedef void (*CliCallbackMethod)(Cache );{code}
Modernize the below header to used std::function.
This should implement {{std::function}}.
{code:java}
typedef PdxSerializable* (*TypeFactoryMethodPdx)();{code}
> Cleanup function pointer types in Serializable.hpp
> --
>
> Key: GEODE-4427
> URL: https://issues.apache.org/jira/browse/GEODE-4427
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Jacob S. Barrett
>Priority: Major
>
> This callback should not be in Serializable.hpp or it might not be needed.
> At the very least, this should be removed from the public API.
> {code:java}
> typedef void (*CliCallbackMethod)(Cache );{code}
> Modernize the below header to used std::function.
> This should implement {{std::function}}.
> {code:java}
> typedef PdxSerializable* (*TypeFactoryMethodPdx)();{code}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (GEODE-4408) ChacheableKeys.hpp provides incorrect hashcode functions.
[ https://issues.apache.org/jira/browse/GEODE-4408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Addison updated GEODE-4408: --- Issue Type: Improvement (was: Task) > ChacheableKeys.hpp provides incorrect hashcode functions. > - > > Key: GEODE-4408 > URL: https://issues.apache.org/jira/browse/GEODE-4408 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Jacob S. Barrett >Priority: Major > > ChacheableKeys.hpp provides incorrect hashcode functions returning uint32_t. > Used mostly internally. Consider removing or moving internal. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (GEODE-4772) Protobuf: add region clear message/operation
Brian Baynes created GEODE-4772: --- Summary: Protobuf: add region clear message/operation Key: GEODE-4772 URL: https://issues.apache.org/jira/browse/GEODE-4772 Project: Geode Issue Type: New Feature Components: client/server Reporter: Brian Baynes As a dev using the new protocol, I want to be able to clear a region completely. Add a region clear message/operation that clears a replicated region. GEODE-788 will implement .clear for partitioned regions - when that is complete we can add support for clearing PRs. Client should receive error if the region does not exist or the client does not have authorization on the region. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (GEODE-4411) Normalize AttributesFactory to match other factories.
[
https://issues.apache.org/jira/browse/GEODE-4411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacob S. Barrett resolved GEODE-4411.
-
Resolution: Fixed
> Normalize AttributesFactory to match other factories.
> -
>
> Key: GEODE-4411
> URL: https://issues.apache.org/jira/browse/GEODE-4411
> Project: Geode
> Issue Type: Task
> Components: native client
>Reporter: Jacob S. Barrett
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> {{AttributesFactory::createRegionAttributes}} should be renamed to {{create}}
> and should return a value rather than a pointer.
> {{AttributesFactory}} constructor should probably take value of
> {{RegionAttributes}} and not pointer.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GEODE-4730) Remove DLock acquisition timeouts in ClusterConfigurationService.createConfigurationResponse
[ https://issues.apache.org/jira/browse/GEODE-4730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386191#comment-16386191 ] ASF subversion and git services commented on GEODE-4730: Commit e5025d399c56b1f86e36c37638108d27655886af in geode's branch refs/heads/develop from [~jens.deppe] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=e5025d3 ] GEODE-4765: Add retries when retrieving cluster config (#1539) - This helps when a locator is reconnecting to the distributed system and isn't fully ready yet. - During reconnect, pass a fresh cache to the ClusterConfigurationService - this fixes the 'DLock destroyed' issue. - Also fixes GEODE-4730 > Remove DLock acquisition timeouts in > ClusterConfigurationService.createConfigurationResponse > > > Key: GEODE-4730 > URL: https://issues.apache.org/jira/browse/GEODE-4730 > Project: Geode > Issue Type: Improvement > Components: configuration >Reporter: Jens Deppe >Assignee: Jens Deppe >Priority: Major > > Reviewing some of this code with [~upthewaterspout] it seems like it would be > worse if the lock acquisition fails and an empty response is returned vs. a > hang/deadlock happening on server startup. > At least if there's a hang we'd know it as opposed to a server starting up > without any configuration. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-4765) Cluster configuration does not respond after locator reconnects to the distributed system
[
https://issues.apache.org/jira/browse/GEODE-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386190#comment-16386190
]
ASF subversion and git services commented on GEODE-4765:
Commit e5025d399c56b1f86e36c37638108d27655886af in geode's branch
refs/heads/develop from [~jens.deppe]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=e5025d3 ]
GEODE-4765: Add retries when retrieving cluster config (#1539)
- This helps when a locator is reconnecting to the distributed system and isn't
fully ready yet.
- During reconnect, pass a fresh cache to the ClusterConfigurationService -
this fixes the 'DLock destroyed' issue.
- Also fixes GEODE-4730
> Cluster configuration does not respond after locator reconnects to the
> distributed system
> -
>
> Key: GEODE-4765
> URL: https://issues.apache.org/jira/browse/GEODE-4765
> Project: Geode
> Issue Type: Bug
> Components: configuration
>Reporter: Jens Deppe
>Assignee: Jens Deppe
>Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> In the case of a reconnect event, subsequent server requests for the cluster
> configuration fail with the following error:
> {noformat}
> [info 2018/02/22 11:16:15.345 IST locator
> tid=0x94] Received request for configuration : ConfigurationRequest for
> groups :
>cluster[cluster]
> [info 2018/02/22 11:16:15.346 IST locator
> tid=0x94] grantorId=null grantor=null> has been destroyed
> org.apache.geode.distributed.LockServiceDestroyedException:
> grantorId=null grantor=null> has been destroyed
> at
> org.apache.geode.distributed.internal.locks.DLockService.generateLockServiceDestroyedException(DLockService.java:205)
> at
> org.apache.geode.distributed.internal.locks.DLockService.checkDestroyed(DLockService.java:194)
> at
> org.apache.geode.distributed.internal.locks.DLockService.lock(DLockService.java:1242)
> at
> org.apache.geode.distributed.internal.locks.DLockService.lock(DLockService.java:1236)
> at
> org.apache.geode.distributed.internal.locks.DLockService.lock(DLockService.java:1231)
> at
> org.apache.geode.distributed.internal.locks.DLockService.lock(DLockService.java:1227)
> at
> org.apache.geode.distributed.internal.ClusterConfigurationService.createConfigurationResponse(ClusterConfigurationService.java:494)
> at
> org.apache.geode.management.internal.configuration.handlers.ConfigurationRequestHandler.processRequest(ConfigurationRequestHandler.java:51)
> at
> org.apache.geode.distributed.internal.InternalLocator$PrimaryHandler.processRequest(InternalLocator.java:1251)
> at
> org.apache.geode.distributed.internal.tcpserver.TcpServer.lambda$processRequest$0(TcpServer.java:434)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (GEODE-4771) Configuring 'auto-serializable-classes' incorrectly sets 'check-portability' as 'true'
Juan José Ramos Cassella created GEODE-4771:
---
Summary: Configuring 'auto-serializable-classes' incorrectly sets
'check-portability' as 'true'
Key: GEODE-4771
URL: https://issues.apache.org/jira/browse/GEODE-4771
Project: Geode
Issue Type: Bug
Components: gfsh
Reporter: Juan José Ramos Cassella
According to the documentation, the [configure
pdx|https://geode.apache.org/docs/guide/14/tools_modules/gfsh/command-pages/configure.html]
command should set the {{check-portability}} parameter as {{false}} when the
user configures a list of auto serializable classes through the
{{--auto-serializable-classes}} parameter. However, {{check-portability}}
parameter is set as {{true}} by default.
The problematic code is below:
{code:title=ConfigurePDXCommand.java|borderStyle=solid}
@CliCommand(value = CliStrings.CONFIGURE_PDX, help =
CliStrings.CONFIGURE_PDX__HELP)
@CliMetaData(relatedTopic = CliStrings.TOPIC_GEODE_REGION)
@ResourceOperation(resource = ResourcePermission.Resource.CLUSTER, operation =
ResourcePermission.Operation.MANAGE)
public Result configurePDX(
...
@CliOption(key = CliStrings.CONFIGURE_PDX__AUTO__SERIALIZER__CLASSES,
/* auto-serializable-classes */
help = CliStrings.CONFIGURE_PDX__AUTO__SERIALIZER__CLASSES__HELP)
String[] patterns, /* the patterns which are matched against domain class names
to determine whether they should be serialized, serialization done by the
auto-serializer will throw an exception if the object of these classes are not
portable to non-java languages */
@CliOption(key =
CliStrings.CONFIGURE_PDX__PORTABLE__AUTO__SERIALIZER__CLASSES /*
portable-auto-serializable-classes */,
help =
CliStrings.CONFIGURE_PDX__PORTABLE__AUTO__SERIALIZER__CLASSES__HELP) String[]
portablePatterns /* the patterns which are matched against domain class names
to determine whether they should be serialized */) {
...
if (patterns != null) {
ReflectionBasedAutoSerializer nonPortableAutoSerializer
= new ReflectionBasedAutoSerializer(true, patterns);
cache.setPdxSerializer(nonPortableAutoSerializer);
ird.addLine("PDX Serializer : " +
cache.getPdxSerializer().getClass().getName());
ird.addLine("Non portable classes :" +
Arrays.toString(patterns));
}
...
{code}
The help text for parameters {{auto-serializable-classes}} and
{{portable-auto-serializable-classes}} is also wrong, it's clear that they
should be swapped.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (GEODE-4771) Configuring 'auto-serializable-classes' incorrectly sets 'check-portability' as 'true'
[
https://issues.apache.org/jira/browse/GEODE-4771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Juan José Ramos Cassella reassigned GEODE-4771:
---
Assignee: Juan José Ramos Cassella
> Configuring 'auto-serializable-classes' incorrectly sets 'check-portability'
> as 'true'
> --
>
> Key: GEODE-4771
> URL: https://issues.apache.org/jira/browse/GEODE-4771
> Project: Geode
> Issue Type: Bug
> Components: gfsh
>Reporter: Juan José Ramos Cassella
>Assignee: Juan José Ramos Cassella
>Priority: Major
>
> According to the documentation, the [configure
> pdx|https://geode.apache.org/docs/guide/14/tools_modules/gfsh/command-pages/configure.html]
> command should set the {{check-portability}} parameter as {{false}} when the
> user configures a list of auto serializable classes through the
> {{--auto-serializable-classes}} parameter. However, {{check-portability}}
> parameter is set as {{true}} by default.
> The problematic code is below:
>
> {code:title=ConfigurePDXCommand.java|borderStyle=solid}
> @CliCommand(value = CliStrings.CONFIGURE_PDX, help =
> CliStrings.CONFIGURE_PDX__HELP)
> @CliMetaData(relatedTopic = CliStrings.TOPIC_GEODE_REGION)
> @ResourceOperation(resource = ResourcePermission.Resource.CLUSTER, operation
> = ResourcePermission.Operation.MANAGE)
> public Result configurePDX(
> ...
> @CliOption(key = CliStrings.CONFIGURE_PDX__AUTO__SERIALIZER__CLASSES,
> /* auto-serializable-classes */
> help = CliStrings.CONFIGURE_PDX__AUTO__SERIALIZER__CLASSES__HELP)
> String[] patterns, /* the patterns which are matched against domain class
> names to determine whether they should be serialized, serialization done by
> the auto-serializer will throw an exception if the object of these classes
> are not portable to non-java languages */
> @CliOption(key =
> CliStrings.CONFIGURE_PDX__PORTABLE__AUTO__SERIALIZER__CLASSES /*
> portable-auto-serializable-classes */,
> help =
> CliStrings.CONFIGURE_PDX__PORTABLE__AUTO__SERIALIZER__CLASSES__HELP) String[]
> portablePatterns /* the patterns which are matched against domain class names
> to determine whether they should be serialized */) {
> ...
> if (patterns != null) {
> ReflectionBasedAutoSerializer nonPortableAutoSerializer
> = new ReflectionBasedAutoSerializer(true, patterns);
> cache.setPdxSerializer(nonPortableAutoSerializer);
> ird.addLine("PDX Serializer : " +
> cache.getPdxSerializer().getClass().getName());
> ird.addLine("Non portable classes :" +
> Arrays.toString(patterns));
> }
> ...
> {code}
> The help text for parameters {{auto-serializable-classes}} and
> {{portable-auto-serializable-classes}} is also wrong, it's clear that they
> should be swapped.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
