[jira] [Commented] (GEODE-6564) Clearing a replicated region with expiration causes a memory leak

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-6564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170510#comment-17170510
 ] 

ASF subversion and git services commented on GEODE-6564:


Commit f64838f695d56029c0a8b08804f16d5ca9da7156 in geode's branch 
refs/heads/support/1.12 from Darrel Schneider
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=f64838f ]

GEODE-6564: fix entryExpiryTasks leak (#5419)

(cherry picked from commit 53abb22cd295441f8794e15550b72ec81113ec05)


> Clearing a replicated region with expiration causes a memory leak
> -
>
> Key: GEODE-6564
> URL: https://issues.apache.org/jira/browse/GEODE-6564
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Barrett Oglesby
>Assignee: Darrel Schneider
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> Clearing a replicated region with expiration causes a memory leak
> Both the RegionEntries and EntryExpiryTasks are still live after loading 
> entries into the region and then clearing it.
> Server Startup:
> {noformat}
>  num #instances #bytes class name
> --
>  1: 29856 2797840 [C
>  4: 2038 520600 [B
> Total 187711 10089624
> {noformat}
> Load 100 entries with 600k payload (representing a session):
> {noformat}
>  num #instances #bytes class name
> --
>  1: 2496 60666440 [B
>  2: 30157 2828496 [C
>  73: 100 7200 
> org.apache.geode.internal.cache.entries.VersionedStatsRegionEntryHeapStringKey1
>  93: 100 4800 org.apache.geode.internal.cache.EntryExpiryTask
> Total 190737 70240472
> {noformat}
> Clear region:
> {noformat}
>  num #instances #bytes class name
> --
>  1: 2398 60505944 [B
>  2: 30448 2849456 [C
>  74: 100 7200 
> org.apache.geode.internal.cache.entries.VersionedStatsRegionEntryHeapStringKey1
>  100: 100 4800 org.apache.geode.internal.cache.EntryExpiryTask
> Total 192199 70373048
> {noformat}
> Load and clear another 100 entries:
> {noformat}
>  num #instances #bytes class name
> --
>  1: 2503 120511688 [B
>  2: 30506 2854384 [C
>  46: 200 14400 
> org.apache.geode.internal.cache.entries.VersionedStatsRegionEntryHeapStringKey1
>  61: 200 9600 org.apache.geode.internal.cache.EntryExpiryTask
> Total 193272 130421432
> {noformat}
> Load and clear another 100 entries:
> {noformat}
>  num #instances #bytes class name
> --
>  1: 2600 180517240 [B
>  2: 30562 2859584 [C
>  33: 300 21600 
> org.apache.geode.internal.cache.entries.VersionedStatsRegionEntryHeapStringKey1
>  47: 300 14400 org.apache.geode.internal.cache.EntryExpiryTask
> Total 194310 190468176
> {noformat}
> A heap dump shows the VersionedStatsRegionEntryHeapStringKey1 instances are 
> referenced by the DistributedRegion entryExpiryTasks:
> {noformat}
> --> org.apache.geode.internal.cache.DistributedRegion@0x76adbbb88 (816 bytes) 
> (field entryExpiryTasks:)
> --> java.util.concurrent.ConcurrentHashMap@0x76adbc028 (100 bytes) (field 
> table:)
> --> [Ljava.util.concurrent.ConcurrentHashMap$Node;@0x76ee85358 (4112 bytes) 
> (Element 276 of [Ljava.util.concurrent.ConcurrentHashMap$Node;@0x76ee85358:)
> --> java.util.concurrent.ConcurrentHashMap$Node@0x76edc4e20 (44 bytes) (field 
> next:)
> --> java.util.concurrent.ConcurrentHashMap$Node@0x76edc32f0 (44 bytes) (field 
> key:)
> --> 
> org.apache.geode.internal.cache.entries.VersionedStatsRegionEntryHeapStringKey1@0x76edc3210
>  (86 bytes) 
> {noformat}
> LocalRegion.cancelAllEntryExpiryTasks is called when the region is cleared:
> {noformat}
> java.lang.Exception: Stack trace
>  at java.lang.Thread.dumpStack(Thread.java:1333)
>  at 
> org.apache.geode.internal.cache.LocalRegion.cancelAllEntryExpiryTasks(LocalRegion.java:8202)
>  at 
> org.apache.geode.internal.cache.LocalRegion.clearRegionLocally(LocalRegion.java:9094)
>  at 
> org.apache.geode.internal.cache.DistributedRegion.cmnClearRegion(DistributedRegion.java:1962)
>  at 
> org.apache.geode.internal.cache.LocalRegion.basicClear(LocalRegion.java:8998)
>  at 
> org.apache.geode.internal.cache.DistributedRegion.basicClear(DistributedRegion.java:1939)
>  at 
> org.apache.geode.internal.cache.LocalRegion.basicBridgeClear(LocalRegion.java:8988)
>  at 
> org.apache.geode.internal.cache.tier.sockets.command.ClearRegion.cmdExecute(ClearRegion.java:123)
> {noformat}
> But it doesn't clear the entryExpiryTasks map:
> {noformat}
> LocalRegion.clearRegionLocally before cancelAllEntryExpiryTasks 
> entryExpiryTasks=100
> LocalRegion.clearRegionLocally after cancelAllEntryExpiryTasks 
> entryExpiryTasks=100
> {noformat}
> As a test, I added this call to the 

[jira] [Commented] (GEODE-6564) Clearing a replicated region with expiration causes a memory leak

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-6564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170446#comment-17170446
 ] 

ASF subversion and git services commented on GEODE-6564:


Commit 53abb22cd295441f8794e15550b72ec81113ec05 in geode's branch 
refs/heads/develop from Darrel Schneider
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=53abb22 ]

GEODE-6564: fix entryExpiryTasks leak (#5419)



> Clearing a replicated region with expiration causes a memory leak
> -
>
> Key: GEODE-6564
> URL: https://issues.apache.org/jira/browse/GEODE-6564
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Barrett Oglesby
>Assignee: Darrel Schneider
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> Clearing a replicated region with expiration causes a memory leak
> Both the RegionEntries and EntryExpiryTasks are still live after loading 
> entries into the region and then clearing it.
> Server Startup:
> {noformat}
>  num #instances #bytes class name
> --
>  1: 29856 2797840 [C
>  4: 2038 520600 [B
> Total 187711 10089624
> {noformat}
> Load 100 entries with 600k payload (representing a session):
> {noformat}
>  num #instances #bytes class name
> --
>  1: 2496 60666440 [B
>  2: 30157 2828496 [C
>  73: 100 7200 
> org.apache.geode.internal.cache.entries.VersionedStatsRegionEntryHeapStringKey1
>  93: 100 4800 org.apache.geode.internal.cache.EntryExpiryTask
> Total 190737 70240472
> {noformat}
> Clear region:
> {noformat}
>  num #instances #bytes class name
> --
>  1: 2398 60505944 [B
>  2: 30448 2849456 [C
>  74: 100 7200 
> org.apache.geode.internal.cache.entries.VersionedStatsRegionEntryHeapStringKey1
>  100: 100 4800 org.apache.geode.internal.cache.EntryExpiryTask
> Total 192199 70373048
> {noformat}
> Load and clear another 100 entries:
> {noformat}
>  num #instances #bytes class name
> --
>  1: 2503 120511688 [B
>  2: 30506 2854384 [C
>  46: 200 14400 
> org.apache.geode.internal.cache.entries.VersionedStatsRegionEntryHeapStringKey1
>  61: 200 9600 org.apache.geode.internal.cache.EntryExpiryTask
> Total 193272 130421432
> {noformat}
> Load and clear another 100 entries:
> {noformat}
>  num #instances #bytes class name
> --
>  1: 2600 180517240 [B
>  2: 30562 2859584 [C
>  33: 300 21600 
> org.apache.geode.internal.cache.entries.VersionedStatsRegionEntryHeapStringKey1
>  47: 300 14400 org.apache.geode.internal.cache.EntryExpiryTask
> Total 194310 190468176
> {noformat}
> A heap dump shows the VersionedStatsRegionEntryHeapStringKey1 instances are 
> referenced by the DistributedRegion entryExpiryTasks:
> {noformat}
> --> org.apache.geode.internal.cache.DistributedRegion@0x76adbbb88 (816 bytes) 
> (field entryExpiryTasks:)
> --> java.util.concurrent.ConcurrentHashMap@0x76adbc028 (100 bytes) (field 
> table:)
> --> [Ljava.util.concurrent.ConcurrentHashMap$Node;@0x76ee85358 (4112 bytes) 
> (Element 276 of [Ljava.util.concurrent.ConcurrentHashMap$Node;@0x76ee85358:)
> --> java.util.concurrent.ConcurrentHashMap$Node@0x76edc4e20 (44 bytes) (field 
> next:)
> --> java.util.concurrent.ConcurrentHashMap$Node@0x76edc32f0 (44 bytes) (field 
> key:)
> --> 
> org.apache.geode.internal.cache.entries.VersionedStatsRegionEntryHeapStringKey1@0x76edc3210
>  (86 bytes) 
> {noformat}
> LocalRegion.cancelAllEntryExpiryTasks is called when the region is cleared:
> {noformat}
> java.lang.Exception: Stack trace
>  at java.lang.Thread.dumpStack(Thread.java:1333)
>  at 
> org.apache.geode.internal.cache.LocalRegion.cancelAllEntryExpiryTasks(LocalRegion.java:8202)
>  at 
> org.apache.geode.internal.cache.LocalRegion.clearRegionLocally(LocalRegion.java:9094)
>  at 
> org.apache.geode.internal.cache.DistributedRegion.cmnClearRegion(DistributedRegion.java:1962)
>  at 
> org.apache.geode.internal.cache.LocalRegion.basicClear(LocalRegion.java:8998)
>  at 
> org.apache.geode.internal.cache.DistributedRegion.basicClear(DistributedRegion.java:1939)
>  at 
> org.apache.geode.internal.cache.LocalRegion.basicBridgeClear(LocalRegion.java:8988)
>  at 
> org.apache.geode.internal.cache.tier.sockets.command.ClearRegion.cmdExecute(ClearRegion.java:123)
> {noformat}
> But it doesn't clear the entryExpiryTasks map:
> {noformat}
> LocalRegion.clearRegionLocally before cancelAllEntryExpiryTasks 
> entryExpiryTasks=100
> LocalRegion.clearRegionLocally after cancelAllEntryExpiryTasks 
> entryExpiryTasks=100
> {noformat}
> As a test, I added this call to the bottom of the cancelAllEntryExpiryTasks 
> method:
> {noformat}
> 

[jira] [Resolved] (GEODE-6564) Clearing a replicated region with expiration causes a memory leak

2020-08-03 Thread Darrel Schneider (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-6564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider resolved GEODE-6564.
-
Fix Version/s: 1.14.0
   Resolution: Fixed

> Clearing a replicated region with expiration causes a memory leak
> -
>
> Key: GEODE-6564
> URL: https://issues.apache.org/jira/browse/GEODE-6564
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Barrett Oglesby
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> Clearing a replicated region with expiration causes a memory leak
> Both the RegionEntries and EntryExpiryTasks are still live after loading 
> entries into the region and then clearing it.
> Server Startup:
> {noformat}
>  num #instances #bytes class name
> --
>  1: 29856 2797840 [C
>  4: 2038 520600 [B
> Total 187711 10089624
> {noformat}
> Load 100 entries with 600k payload (representing a session):
> {noformat}
>  num #instances #bytes class name
> --
>  1: 2496 60666440 [B
>  2: 30157 2828496 [C
>  73: 100 7200 
> org.apache.geode.internal.cache.entries.VersionedStatsRegionEntryHeapStringKey1
>  93: 100 4800 org.apache.geode.internal.cache.EntryExpiryTask
> Total 190737 70240472
> {noformat}
> Clear region:
> {noformat}
>  num #instances #bytes class name
> --
>  1: 2398 60505944 [B
>  2: 30448 2849456 [C
>  74: 100 7200 
> org.apache.geode.internal.cache.entries.VersionedStatsRegionEntryHeapStringKey1
>  100: 100 4800 org.apache.geode.internal.cache.EntryExpiryTask
> Total 192199 70373048
> {noformat}
> Load and clear another 100 entries:
> {noformat}
>  num #instances #bytes class name
> --
>  1: 2503 120511688 [B
>  2: 30506 2854384 [C
>  46: 200 14400 
> org.apache.geode.internal.cache.entries.VersionedStatsRegionEntryHeapStringKey1
>  61: 200 9600 org.apache.geode.internal.cache.EntryExpiryTask
> Total 193272 130421432
> {noformat}
> Load and clear another 100 entries:
> {noformat}
>  num #instances #bytes class name
> --
>  1: 2600 180517240 [B
>  2: 30562 2859584 [C
>  33: 300 21600 
> org.apache.geode.internal.cache.entries.VersionedStatsRegionEntryHeapStringKey1
>  47: 300 14400 org.apache.geode.internal.cache.EntryExpiryTask
> Total 194310 190468176
> {noformat}
> A heap dump shows the VersionedStatsRegionEntryHeapStringKey1 instances are 
> referenced by the DistributedRegion entryExpiryTasks:
> {noformat}
> --> org.apache.geode.internal.cache.DistributedRegion@0x76adbbb88 (816 bytes) 
> (field entryExpiryTasks:)
> --> java.util.concurrent.ConcurrentHashMap@0x76adbc028 (100 bytes) (field 
> table:)
> --> [Ljava.util.concurrent.ConcurrentHashMap$Node;@0x76ee85358 (4112 bytes) 
> (Element 276 of [Ljava.util.concurrent.ConcurrentHashMap$Node;@0x76ee85358:)
> --> java.util.concurrent.ConcurrentHashMap$Node@0x76edc4e20 (44 bytes) (field 
> next:)
> --> java.util.concurrent.ConcurrentHashMap$Node@0x76edc32f0 (44 bytes) (field 
> key:)
> --> 
> org.apache.geode.internal.cache.entries.VersionedStatsRegionEntryHeapStringKey1@0x76edc3210
>  (86 bytes) 
> {noformat}
> LocalRegion.cancelAllEntryExpiryTasks is called when the region is cleared:
> {noformat}
> java.lang.Exception: Stack trace
>  at java.lang.Thread.dumpStack(Thread.java:1333)
>  at 
> org.apache.geode.internal.cache.LocalRegion.cancelAllEntryExpiryTasks(LocalRegion.java:8202)
>  at 
> org.apache.geode.internal.cache.LocalRegion.clearRegionLocally(LocalRegion.java:9094)
>  at 
> org.apache.geode.internal.cache.DistributedRegion.cmnClearRegion(DistributedRegion.java:1962)
>  at 
> org.apache.geode.internal.cache.LocalRegion.basicClear(LocalRegion.java:8998)
>  at 
> org.apache.geode.internal.cache.DistributedRegion.basicClear(DistributedRegion.java:1939)
>  at 
> org.apache.geode.internal.cache.LocalRegion.basicBridgeClear(LocalRegion.java:8988)
>  at 
> org.apache.geode.internal.cache.tier.sockets.command.ClearRegion.cmdExecute(ClearRegion.java:123)
> {noformat}
> But it doesn't clear the entryExpiryTasks map:
> {noformat}
> LocalRegion.clearRegionLocally before cancelAllEntryExpiryTasks 
> entryExpiryTasks=100
> LocalRegion.clearRegionLocally after cancelAllEntryExpiryTasks 
> entryExpiryTasks=100
> {noformat}
> As a test, I added this call to the bottom of the cancelAllEntryExpiryTasks 
> method:
> {noformat}
> this.entryExpiryTasks.clear();
> {noformat}
> This addressed the leak:
> {noformat}
> Server Startup: Total 182414 9855616
> Load/Clear 1: Total 191049 10315832
> Load/Clear 2: Total 191978 10329664
> Load/Clear 3: Total 192638 10360360
> {noformat}
> As a work-around, a Function that 

[jira] [Assigned] (GEODE-6564) Clearing a replicated region with expiration causes a memory leak

2020-08-03 Thread Darrel Schneider (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-6564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider reassigned GEODE-6564:
---

Assignee: Darrel Schneider

> Clearing a replicated region with expiration causes a memory leak
> -
>
> Key: GEODE-6564
> URL: https://issues.apache.org/jira/browse/GEODE-6564
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Barrett Oglesby
>Assignee: Darrel Schneider
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> Clearing a replicated region with expiration causes a memory leak
> Both the RegionEntries and EntryExpiryTasks are still live after loading 
> entries into the region and then clearing it.
> Server Startup:
> {noformat}
>  num #instances #bytes class name
> --
>  1: 29856 2797840 [C
>  4: 2038 520600 [B
> Total 187711 10089624
> {noformat}
> Load 100 entries with 600k payload (representing a session):
> {noformat}
>  num #instances #bytes class name
> --
>  1: 2496 60666440 [B
>  2: 30157 2828496 [C
>  73: 100 7200 
> org.apache.geode.internal.cache.entries.VersionedStatsRegionEntryHeapStringKey1
>  93: 100 4800 org.apache.geode.internal.cache.EntryExpiryTask
> Total 190737 70240472
> {noformat}
> Clear region:
> {noformat}
>  num #instances #bytes class name
> --
>  1: 2398 60505944 [B
>  2: 30448 2849456 [C
>  74: 100 7200 
> org.apache.geode.internal.cache.entries.VersionedStatsRegionEntryHeapStringKey1
>  100: 100 4800 org.apache.geode.internal.cache.EntryExpiryTask
> Total 192199 70373048
> {noformat}
> Load and clear another 100 entries:
> {noformat}
>  num #instances #bytes class name
> --
>  1: 2503 120511688 [B
>  2: 30506 2854384 [C
>  46: 200 14400 
> org.apache.geode.internal.cache.entries.VersionedStatsRegionEntryHeapStringKey1
>  61: 200 9600 org.apache.geode.internal.cache.EntryExpiryTask
> Total 193272 130421432
> {noformat}
> Load and clear another 100 entries:
> {noformat}
>  num #instances #bytes class name
> --
>  1: 2600 180517240 [B
>  2: 30562 2859584 [C
>  33: 300 21600 
> org.apache.geode.internal.cache.entries.VersionedStatsRegionEntryHeapStringKey1
>  47: 300 14400 org.apache.geode.internal.cache.EntryExpiryTask
> Total 194310 190468176
> {noformat}
> A heap dump shows the VersionedStatsRegionEntryHeapStringKey1 instances are 
> referenced by the DistributedRegion entryExpiryTasks:
> {noformat}
> --> org.apache.geode.internal.cache.DistributedRegion@0x76adbbb88 (816 bytes) 
> (field entryExpiryTasks:)
> --> java.util.concurrent.ConcurrentHashMap@0x76adbc028 (100 bytes) (field 
> table:)
> --> [Ljava.util.concurrent.ConcurrentHashMap$Node;@0x76ee85358 (4112 bytes) 
> (Element 276 of [Ljava.util.concurrent.ConcurrentHashMap$Node;@0x76ee85358:)
> --> java.util.concurrent.ConcurrentHashMap$Node@0x76edc4e20 (44 bytes) (field 
> next:)
> --> java.util.concurrent.ConcurrentHashMap$Node@0x76edc32f0 (44 bytes) (field 
> key:)
> --> 
> org.apache.geode.internal.cache.entries.VersionedStatsRegionEntryHeapStringKey1@0x76edc3210
>  (86 bytes) 
> {noformat}
> LocalRegion.cancelAllEntryExpiryTasks is called when the region is cleared:
> {noformat}
> java.lang.Exception: Stack trace
>  at java.lang.Thread.dumpStack(Thread.java:1333)
>  at 
> org.apache.geode.internal.cache.LocalRegion.cancelAllEntryExpiryTasks(LocalRegion.java:8202)
>  at 
> org.apache.geode.internal.cache.LocalRegion.clearRegionLocally(LocalRegion.java:9094)
>  at 
> org.apache.geode.internal.cache.DistributedRegion.cmnClearRegion(DistributedRegion.java:1962)
>  at 
> org.apache.geode.internal.cache.LocalRegion.basicClear(LocalRegion.java:8998)
>  at 
> org.apache.geode.internal.cache.DistributedRegion.basicClear(DistributedRegion.java:1939)
>  at 
> org.apache.geode.internal.cache.LocalRegion.basicBridgeClear(LocalRegion.java:8988)
>  at 
> org.apache.geode.internal.cache.tier.sockets.command.ClearRegion.cmdExecute(ClearRegion.java:123)
> {noformat}
> But it doesn't clear the entryExpiryTasks map:
> {noformat}
> LocalRegion.clearRegionLocally before cancelAllEntryExpiryTasks 
> entryExpiryTasks=100
> LocalRegion.clearRegionLocally after cancelAllEntryExpiryTasks 
> entryExpiryTasks=100
> {noformat}
> As a test, I added this call to the bottom of the cancelAllEntryExpiryTasks 
> method:
> {noformat}
> this.entryExpiryTasks.clear();
> {noformat}
> This addressed the leak:
> {noformat}
> Server Startup: Total 182414 9855616
> Load/Clear 1: Total 191049 10315832
> Load/Clear 2: Total 191978 10329664
> Load/Clear 3: Total 192638 10360360
> {noformat}
> As a 

[jira] [Commented] (GEODE-6564) Clearing a replicated region with expiration causes a memory leak

2020-08-03 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-6564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170444#comment-17170444
 ] 

ASF GitHub Bot commented on GEODE-6564:
---

dschneider-pivotal merged pull request #5419:
URL: https://github.com/apache/geode/pull/5419


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clearing a replicated region with expiration causes a memory leak
> -
>
> Key: GEODE-6564
> URL: https://issues.apache.org/jira/browse/GEODE-6564
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Barrett Oglesby
>Priority: Major
>  Labels: pull-request-available
>
> Clearing a replicated region with expiration causes a memory leak
> Both the RegionEntries and EntryExpiryTasks are still live after loading 
> entries into the region and then clearing it.
> Server Startup:
> {noformat}
>  num #instances #bytes class name
> --
>  1: 29856 2797840 [C
>  4: 2038 520600 [B
> Total 187711 10089624
> {noformat}
> Load 100 entries with 600k payload (representing a session):
> {noformat}
>  num #instances #bytes class name
> --
>  1: 2496 60666440 [B
>  2: 30157 2828496 [C
>  73: 100 7200 
> org.apache.geode.internal.cache.entries.VersionedStatsRegionEntryHeapStringKey1
>  93: 100 4800 org.apache.geode.internal.cache.EntryExpiryTask
> Total 190737 70240472
> {noformat}
> Clear region:
> {noformat}
>  num #instances #bytes class name
> --
>  1: 2398 60505944 [B
>  2: 30448 2849456 [C
>  74: 100 7200 
> org.apache.geode.internal.cache.entries.VersionedStatsRegionEntryHeapStringKey1
>  100: 100 4800 org.apache.geode.internal.cache.EntryExpiryTask
> Total 192199 70373048
> {noformat}
> Load and clear another 100 entries:
> {noformat}
>  num #instances #bytes class name
> --
>  1: 2503 120511688 [B
>  2: 30506 2854384 [C
>  46: 200 14400 
> org.apache.geode.internal.cache.entries.VersionedStatsRegionEntryHeapStringKey1
>  61: 200 9600 org.apache.geode.internal.cache.EntryExpiryTask
> Total 193272 130421432
> {noformat}
> Load and clear another 100 entries:
> {noformat}
>  num #instances #bytes class name
> --
>  1: 2600 180517240 [B
>  2: 30562 2859584 [C
>  33: 300 21600 
> org.apache.geode.internal.cache.entries.VersionedStatsRegionEntryHeapStringKey1
>  47: 300 14400 org.apache.geode.internal.cache.EntryExpiryTask
> Total 194310 190468176
> {noformat}
> A heap dump shows the VersionedStatsRegionEntryHeapStringKey1 instances are 
> referenced by the DistributedRegion entryExpiryTasks:
> {noformat}
> --> org.apache.geode.internal.cache.DistributedRegion@0x76adbbb88 (816 bytes) 
> (field entryExpiryTasks:)
> --> java.util.concurrent.ConcurrentHashMap@0x76adbc028 (100 bytes) (field 
> table:)
> --> [Ljava.util.concurrent.ConcurrentHashMap$Node;@0x76ee85358 (4112 bytes) 
> (Element 276 of [Ljava.util.concurrent.ConcurrentHashMap$Node;@0x76ee85358:)
> --> java.util.concurrent.ConcurrentHashMap$Node@0x76edc4e20 (44 bytes) (field 
> next:)
> --> java.util.concurrent.ConcurrentHashMap$Node@0x76edc32f0 (44 bytes) (field 
> key:)
> --> 
> org.apache.geode.internal.cache.entries.VersionedStatsRegionEntryHeapStringKey1@0x76edc3210
>  (86 bytes) 
> {noformat}
> LocalRegion.cancelAllEntryExpiryTasks is called when the region is cleared:
> {noformat}
> java.lang.Exception: Stack trace
>  at java.lang.Thread.dumpStack(Thread.java:1333)
>  at 
> org.apache.geode.internal.cache.LocalRegion.cancelAllEntryExpiryTasks(LocalRegion.java:8202)
>  at 
> org.apache.geode.internal.cache.LocalRegion.clearRegionLocally(LocalRegion.java:9094)
>  at 
> org.apache.geode.internal.cache.DistributedRegion.cmnClearRegion(DistributedRegion.java:1962)
>  at 
> org.apache.geode.internal.cache.LocalRegion.basicClear(LocalRegion.java:8998)
>  at 
> org.apache.geode.internal.cache.DistributedRegion.basicClear(DistributedRegion.java:1939)
>  at 
> org.apache.geode.internal.cache.LocalRegion.basicBridgeClear(LocalRegion.java:8988)
>  at 
> org.apache.geode.internal.cache.tier.sockets.command.ClearRegion.cmdExecute(ClearRegion.java:123)
> {noformat}
> But it doesn't clear the entryExpiryTasks map:
> {noformat}
> LocalRegion.clearRegionLocally before cancelAllEntryExpiryTasks 
> entryExpiryTasks=100
> LocalRegion.clearRegionLocally after cancelAllEntryExpiryTasks 
> entryExpiryTasks=100
> {noformat}
> As a test, I added 

[jira] [Updated] (GEODE-8399) extend C++ (boost::asio sockets) PoolFactoryAPI to support SNI proxy

2020-08-03 Thread Blake Bender (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Blake Bender updated GEODE-8399:

Summary: extend C++ (boost::asio sockets) PoolFactoryAPI to support SNI 
proxy  (was: extend PoolFactoryAPI to support SNI proxy)

> extend C++ (boost::asio sockets) PoolFactoryAPI to support SNI proxy
> 
>
> Key: GEODE-8399
> URL: https://issues.apache.org/jira/browse/GEODE-8399
> Project: Geode
>  Issue Type: New Feature
>  Components: native client
>Reporter: Ernest Burghardt
>Priority: Major
>
> cppcache  — on boost::asio



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (GEODE-8398) extend C# (existing, ACE sockets) PoolFactoryAPI to support SNI proxy

2020-08-03 Thread Blake Bender (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Blake Bender updated GEODE-8398:

Summary: extend C# (existing, ACE sockets) PoolFactoryAPI to support SNI 
proxy  (was: extend PoolFactoryAPI to support SNI proxy)

> extend C# (existing, ACE sockets) PoolFactoryAPI to support SNI proxy
> -
>
> Key: GEODE-8398
> URL: https://issues.apache.org/jira/browse/GEODE-8398
> Project: Geode
>  Issue Type: New Feature
>  Components: native client
>Reporter: Ernest Burghardt
>Priority: Major
>
> clicache



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (GEODE-8397) extend C++ (existing, ACE sockets) PoolFactoryAPI to support SNI proxy

2020-08-03 Thread Blake Bender (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Blake Bender updated GEODE-8397:

Summary: extend C++ (existing, ACE sockets) PoolFactoryAPI to support SNI 
proxy  (was: extend PoolFactoryAPI to support SNI proxy)

> extend C++ (existing, ACE sockets) PoolFactoryAPI to support SNI proxy
> --
>
> Key: GEODE-8397
> URL: https://issues.apache.org/jira/browse/GEODE-8397
> Project: Geode
>  Issue Type: New Feature
>  Components: native client
>Reporter: Ernest Burghardt
>Priority: Major
>
> cppcache



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8382) Run Redis tests against Redis API for Geode

2020-08-03 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170433#comment-17170433
 ] 

ASF GitHub Bot commented on GEODE-8382:
---

sabbeyPivotal commented on a change in pull request #5416:
URL: https://github.com/apache/geode/pull/5416#discussion_r464666188



##
File path: ci/scripts/execute_redis_tests.sh
##
@@ -0,0 +1,51 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+cd ..
+git clone --config transfer.fsckObjects=false 
https://github.com/prettyClouds/redis.git
+cd redis
+git checkout tests-geode-redis
+
+JAVA_HOME="/usr/lib/jvm/java-11-openjdk-amd64"  \
+../geode-assembly/build/install/apache-geode/bin/gfsh start server \
+  --J=-Denable-redis-unsupported-commands=true \
+  --name=server1 \
+  --redis-port=6380 \
+  --redis-bind-address=127.0.0.1 \
+  --redis-password=foobar
+
+failCount=0
+
+./runtest --host 127.0.0.1 --port 6380 --single unit/auth
+
+((failCount+=$?))
+
+JAVA_HOME="/usr/lib/jvm/java-11-openjdk-amd64" \

Review comment:
   Just exported the variable and was able to remove this. Thanks for the 
suggestion!





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Run Redis tests against Redis API for Geode
> ---
>
> Key: GEODE-8382
> URL: https://issues.apache.org/jira/browse/GEODE-8382
> Project: Geode
>  Issue Type: New Feature
>  Components: ci, redis
>Reporter: Sarah Abbey
>Priority: Major
>  Labels: pull-request-available
>
> We would like to run Redis's tests against Redis API for Geode.  Tests will 
> run a separate job in the PR and main pipelines.  It has been included in the 
> 'tests' jinja variables.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8382) Run Redis tests against Redis API for Geode

2020-08-03 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170434#comment-17170434
 ] 

ASF GitHub Bot commented on GEODE-8382:
---

sabbeyPivotal commented on a change in pull request #5416:
URL: https://github.com/apache/geode/pull/5416#discussion_r464666362



##
File path: ci/scripts/execute_redis_tests.sh
##
@@ -0,0 +1,51 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+cd ..
+git clone --config transfer.fsckObjects=false 
https://github.com/prettyClouds/redis.git

Review comment:
   Just added a comment.  Let me know if you think it explains the 
situation sufficiently.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Run Redis tests against Redis API for Geode
> ---
>
> Key: GEODE-8382
> URL: https://issues.apache.org/jira/browse/GEODE-8382
> Project: Geode
>  Issue Type: New Feature
>  Components: ci, redis
>Reporter: Sarah Abbey
>Priority: Major
>  Labels: pull-request-available
>
> We would like to run Redis's tests against Redis API for Geode.  Tests will 
> run a separate job in the PR and main pipelines.  It has been included in the 
> 'tests' jinja variables.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (GEODE-8401) User Guide - incorrect method name on "forced disconnect" page

2020-08-03 Thread Dave Barnes (Jira)
Dave Barnes created GEODE-8401:
--

 Summary: User Guide - incorrect method name on "forced disconnect" 
page
 Key: GEODE-8401
 URL: https://issues.apache.org/jira/browse/GEODE-8401
 Project: Geode
  Issue Type: Bug
  Components: docs
Reporter: Dave Barnes


Alert reader Barry Oglesby noticed:

[https://geode.apache.org/docs/guide/112/managing/member-reconnect.html]
 
has:
Cache.waitForReconnect(long, TimeUnit)
It should be:
Cache.waitUntilReconnected(long, TimeUnit)
 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8382) Run Redis tests against Redis API for Geode

2020-08-03 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170432#comment-17170432
 ] 

ASF GitHub Bot commented on GEODE-8382:
---

sabbeyPivotal commented on a change in pull request #5416:
URL: https://github.com/apache/geode/pull/5416#discussion_r464665951



##
File path: ci/scripts/execute_redis_tests.sh
##
@@ -0,0 +1,51 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+cd ..
+git clone --config transfer.fsckObjects=false 
https://github.com/prettyClouds/redis.git
+cd redis
+git checkout tests-geode-redis
+
+JAVA_HOME="/usr/lib/jvm/java-11-openjdk-amd64"  \

Review comment:
   Good call. I just updated it and exported the JAVA_HOME variable, 
definitely check it over and make sure it looks correct.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Run Redis tests against Redis API for Geode
> ---
>
> Key: GEODE-8382
> URL: https://issues.apache.org/jira/browse/GEODE-8382
> Project: Geode
>  Issue Type: New Feature
>  Components: ci, redis
>Reporter: Sarah Abbey
>Priority: Major
>  Labels: pull-request-available
>
> We would like to run Redis's tests against Redis API for Geode.  Tests will 
> run a separate job in the PR and main pipelines.  It has been included in the 
> 'tests' jinja variables.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8382) Run Redis tests against Redis API for Geode

2020-08-03 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170431#comment-17170431
 ] 

ASF GitHub Bot commented on GEODE-8382:
---

sabbeyPivotal commented on a change in pull request #5416:
URL: https://github.com/apache/geode/pull/5416#discussion_r464665517



##
File path: ci/scripts/execute_redis_tests.sh
##
@@ -0,0 +1,51 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+cd ..
+git clone --config transfer.fsckObjects=false 
https://github.com/prettyClouds/redis.git
+cd redis
+git checkout tests-geode-redis
+
+JAVA_HOME="/usr/lib/jvm/java-11-openjdk-amd64"  \
+../geode-assembly/build/install/apache-geode/bin/gfsh start server \
+  --J=-Denable-redis-unsupported-commands=true \
+  --name=server1 \
+  --redis-port=6380 \
+  --redis-bind-address=127.0.0.1 \
+  --redis-password=foobar
+
+failCount=0
+
+./runtest --host 127.0.0.1 --port 6380 --single unit/auth
+
+((failCount+=$?))
+
+JAVA_HOME="/usr/lib/jvm/java-11-openjdk-amd64" \
+../geode-assembly/build/install/apache-geode/bin/gfsh start server \
+  --J=-Denable-redis-unsupported-commands=true \
+  --name=server2 \
+  --server-port=0 \
+  --redis-port=6379 \
+  --redis-bind-address=127.0.0.1
+
+./runtest --host 127.0.0.1 --port 6379 --single unit/type/set --single 
unit/expire
+
+((failCount+=$?))
+
+exit $failCount

Review comment:
   sweet, thanks for double checking!





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Run Redis tests against Redis API for Geode
> ---
>
> Key: GEODE-8382
> URL: https://issues.apache.org/jira/browse/GEODE-8382
> Project: Geode
>  Issue Type: New Feature
>  Components: ci, redis
>Reporter: Sarah Abbey
>Priority: Major
>  Labels: pull-request-available
>
> We would like to run Redis's tests against Redis API for Geode.  Tests will 
> run a separate job in the PR and main pipelines.  It has been included in the 
> 'tests' jinja variables.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8382) Run Redis tests against Redis API for Geode

2020-08-03 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170430#comment-17170430
 ] 

ASF GitHub Bot commented on GEODE-8382:
---

sabbeyPivotal commented on a change in pull request #5416:
URL: https://github.com/apache/geode/pull/5416#discussion_r464665333



##
File path: ci/pipelines/shared/jinja.variables.yml
##
@@ -140,6 +140,19 @@ tests:
   PLATFORM: linux
   RAM: '210'
   name: Upgrade
+- ARTIFACT_SLUG: redistests
+  CALL_STACK_TIMEOUT: '1200'
+  CPUS: '4'
+  DUNIT_PARALLEL_FORKS: '0'
+  EXECUTE_TEST_TIMEOUT: 30m
+  GRADLE_TASK: ':geode-redis:redisAPITest'
+  MAX_IN_FLIGHT: 1
+  ONLY_JDK: 11
+  PARALLEL_DUNIT: 'false'
+  PARALLEL_GRADLE: 'true'
+  PLATFORM: linux
+  RAM: '16'

Review comment:
   just changed it!





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Run Redis tests against Redis API for Geode
> ---
>
> Key: GEODE-8382
> URL: https://issues.apache.org/jira/browse/GEODE-8382
> Project: Geode
>  Issue Type: New Feature
>  Components: ci, redis
>Reporter: Sarah Abbey
>Priority: Major
>  Labels: pull-request-available
>
> We would like to run Redis's tests against Redis API for Geode.  Tests will 
> run a separate job in the PR and main pipelines.  It has been included in the 
> 'tests' jinja variables.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (GEODE-8389) reconnect attempt fails due to distribution configuration validation checks

2020-08-03 Thread Bruce J Schuchardt (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruce J Schuchardt resolved GEODE-8389.
---
Fix Version/s: 1.14.0
   Resolution: Fixed

> reconnect attempt fails due to distribution configuration validation checks
> ---
>
> Key: GEODE-8389
> URL: https://issues.apache.org/jira/browse/GEODE-8389
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Bruce J Schuchardt
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> While tracking down a hang I found this stack trace in distributed unit test 
> output.  I couldn't tell which test it came from, but it should be easy to 
> write a unit test for it.
> Configuration validation should ignore the ds-quorum-checker attribute when 
> doing sameAs comparisons with another configuration.
>  
> {noformat}
> [vm1] [warn 2020/06/16 19:02:34.580 GMT  tid=0x72] Exception 
> occurred while trying to connect the system during reconnect
> [vm1] [warn 2020/06/16 19:02:34.580 GMT  tid=0x72] Exception 
> occurred while trying to connect the system during reconnect
> [vm1] java.lang.IllegalArgumentException: Unknown configuration attribute 
> name ds-quorum-checker. Valid attribute names are: ack-severe-alert-threshold 
> ack-wait-threshold archive-disk-space-limit archive-file-size-limit 
> async-distribution-timeout async-max-queue-size async-queue-timeout 
> bind-address cache-xml-file cluster-configuration-dir cluster-ssl-ciphers 
> cluster-ssl-enabled cluster-ssl-keystore cluster-ssl-keystore-password 
> cluster-ssl-keystore-type cluster-ssl-protocols 
> cluster-ssl-require-authentication cluster-ssl-truststore 
> cluster-ssl-truststore-password conflate-events conserve-sockets 
> delta-propagation deploy-working-dir disable-auto-reconnect disable-jmx 
> disable-tcp distributed-system-id distributed-transactions durable-client-id 
> durable-client-timeout enable-cluster-configuration 
> enable-management-rest-service enable-network-partition-detection 
> enable-time-statistics enforce-unique-host gateway-ssl-ciphers 
> gateway-ssl-enabled gateway-ssl-keystore gateway-ssl-keystore-password 
> gateway-ssl-keystore-type gateway-ssl-protocols 
> gateway-ssl-require-authentication gateway-ssl-truststore 
> gateway-ssl-truststore-password groups http-service-bind-address 
> http-service-port http-service-ssl-ciphers http-service-ssl-enabled 
> http-service-ssl-keystore http-service-ssl-keystore-password 
> http-service-ssl-keystore-type http-service-ssl-protocols 
> http-service-ssl-require-authentication http-service-ssl-truststore 
> http-service-ssl-truststore-password jmx-manager jmx-manager-access-file 
> jmx-manager-bind-address jmx-manager-hostname-for-clients 
> jmx-manager-http-port jmx-manager-password-file jmx-manager-port 
> jmx-manager-ssl-ciphers jmx-manager-ssl-enabled jmx-manager-ssl-keystore 
> jmx-manager-ssl-keystore-password jmx-manager-ssl-keystore-type 
> jmx-manager-ssl-protocols jmx-manager-ssl-require-authentication 
> jmx-manager-ssl-truststore jmx-manager-ssl-truststore-password 
> jmx-manager-start jmx-manager-update-rate load-cluster-configuration-from-dir 
> locator-wait-time locators lock-memory log-disk-space-limit log-file 
> log-file-size-limit log-level max-num-reconnect-tries max-wait-time-reconnect 
> mcast-address mcast-flow-control mcast-port mcast-recv-buffer-size 
> mcast-send-buffer-size mcast-ttl member-timeout membership-port-range 
> memcached-bind-address memcached-port memcached-protocol name 
> off-heap-memory-size redis-bind-address redis-enabled redis-password 
> redis-port redundancy-zone remote-locators remove-unresponsive-client roles 
> security-auth-token-enabled-components security-client-accessor 
> security-client-accessor-pp security-client-auth-init 
> security-client-authenticator security-client-dhalgo security-log-file 
> security-log-level security-manager security-peer-auth-init 
> security-peer-authenticator security-peer-verifymember-timeout 
> security-post-processor security-shiro-init security-udp-dhalgo 
> serializable-object-filter server-bind-address server-ssl-ciphers 
> server-ssl-enabled server-ssl-keystore server-ssl-keystore-password 
> server-ssl-keystore-type server-ssl-protocols 
> server-ssl-require-authentication server-ssl-truststore 
> server-ssl-truststore-password socket-buffer-size socket-lease-time 
> ssl-ciphers ssl-cluster-alias ssl-default-alias ssl-enabled-components 
> ssl-endpoint-identification-enabled ssl-gateway-alias ssl-jmx-alias 
> ssl-keystore ssl-keystore-password ssl-keystore-type ssl-locator-alias 
> ssl-parameter-extension ssl-protocols ssl-require-authentication 
> ssl-server-alias ssl-truststore ssl-truststore-password 

[jira] [Commented] (GEODE-8389) reconnect attempt fails due to distribution configuration validation checks

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170421#comment-17170421
 ] 

ASF subversion and git services commented on GEODE-8389:


Commit 6e07aac5ac7a6c01a75d06d226ab329f92467c63 in geode's branch 
refs/heads/develop from Bruce Schuchardt
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=6e07aac ]

GEODE-8389: reconnect attempt fails due to distribution configuration… (#5413)

* GEODE-8389: reconnect attempt fails due to distribution configuration 
validation checks

disregard internal property names when checking for equality.  These
properties are used to carry information that does not come from
gemfire.properties.

* implementing Rene's idea and fixing unit test & PMD failures

> reconnect attempt fails due to distribution configuration validation checks
> ---
>
> Key: GEODE-8389
> URL: https://issues.apache.org/jira/browse/GEODE-8389
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Bruce J Schuchardt
>Priority: Major
>  Labels: pull-request-available
>
> While tracking down a hang I found this stack trace in distributed unit test 
> output.  I couldn't tell which test it came from, but it should be easy to 
> write a unit test for it.
> Configuration validation should ignore the ds-quorum-checker attribute when 
> doing sameAs comparisons with another configuration.
>  
> {noformat}
> [vm1] [warn 2020/06/16 19:02:34.580 GMT  tid=0x72] Exception 
> occurred while trying to connect the system during reconnect
> [vm1] [warn 2020/06/16 19:02:34.580 GMT  tid=0x72] Exception 
> occurred while trying to connect the system during reconnect
> [vm1] java.lang.IllegalArgumentException: Unknown configuration attribute 
> name ds-quorum-checker. Valid attribute names are: ack-severe-alert-threshold 
> ack-wait-threshold archive-disk-space-limit archive-file-size-limit 
> async-distribution-timeout async-max-queue-size async-queue-timeout 
> bind-address cache-xml-file cluster-configuration-dir cluster-ssl-ciphers 
> cluster-ssl-enabled cluster-ssl-keystore cluster-ssl-keystore-password 
> cluster-ssl-keystore-type cluster-ssl-protocols 
> cluster-ssl-require-authentication cluster-ssl-truststore 
> cluster-ssl-truststore-password conflate-events conserve-sockets 
> delta-propagation deploy-working-dir disable-auto-reconnect disable-jmx 
> disable-tcp distributed-system-id distributed-transactions durable-client-id 
> durable-client-timeout enable-cluster-configuration 
> enable-management-rest-service enable-network-partition-detection 
> enable-time-statistics enforce-unique-host gateway-ssl-ciphers 
> gateway-ssl-enabled gateway-ssl-keystore gateway-ssl-keystore-password 
> gateway-ssl-keystore-type gateway-ssl-protocols 
> gateway-ssl-require-authentication gateway-ssl-truststore 
> gateway-ssl-truststore-password groups http-service-bind-address 
> http-service-port http-service-ssl-ciphers http-service-ssl-enabled 
> http-service-ssl-keystore http-service-ssl-keystore-password 
> http-service-ssl-keystore-type http-service-ssl-protocols 
> http-service-ssl-require-authentication http-service-ssl-truststore 
> http-service-ssl-truststore-password jmx-manager jmx-manager-access-file 
> jmx-manager-bind-address jmx-manager-hostname-for-clients 
> jmx-manager-http-port jmx-manager-password-file jmx-manager-port 
> jmx-manager-ssl-ciphers jmx-manager-ssl-enabled jmx-manager-ssl-keystore 
> jmx-manager-ssl-keystore-password jmx-manager-ssl-keystore-type 
> jmx-manager-ssl-protocols jmx-manager-ssl-require-authentication 
> jmx-manager-ssl-truststore jmx-manager-ssl-truststore-password 
> jmx-manager-start jmx-manager-update-rate load-cluster-configuration-from-dir 
> locator-wait-time locators lock-memory log-disk-space-limit log-file 
> log-file-size-limit log-level max-num-reconnect-tries max-wait-time-reconnect 
> mcast-address mcast-flow-control mcast-port mcast-recv-buffer-size 
> mcast-send-buffer-size mcast-ttl member-timeout membership-port-range 
> memcached-bind-address memcached-port memcached-protocol name 
> off-heap-memory-size redis-bind-address redis-enabled redis-password 
> redis-port redundancy-zone remote-locators remove-unresponsive-client roles 
> security-auth-token-enabled-components security-client-accessor 
> security-client-accessor-pp security-client-auth-init 
> security-client-authenticator security-client-dhalgo security-log-file 
> security-log-level security-manager security-peer-auth-init 
> security-peer-authenticator security-peer-verifymember-timeout 
> security-post-processor security-shiro-init security-udp-dhalgo 
> serializable-object-filter server-bind-address server-ssl-ciphers 
> server-ssl-enabled server-ssl-keystore 

[jira] [Commented] (GEODE-8389) reconnect attempt fails due to distribution configuration validation checks

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170422#comment-17170422
 ] 

ASF subversion and git services commented on GEODE-8389:


Commit 6e07aac5ac7a6c01a75d06d226ab329f92467c63 in geode's branch 
refs/heads/develop from Bruce Schuchardt
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=6e07aac ]

GEODE-8389: reconnect attempt fails due to distribution configuration… (#5413)

* GEODE-8389: reconnect attempt fails due to distribution configuration 
validation checks

disregard internal property names when checking for equality.  These
properties are used to carry information that does not come from
gemfire.properties.

* implementing Rene's idea and fixing unit test & PMD failures

> reconnect attempt fails due to distribution configuration validation checks
> ---
>
> Key: GEODE-8389
> URL: https://issues.apache.org/jira/browse/GEODE-8389
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Bruce J Schuchardt
>Priority: Major
>  Labels: pull-request-available
>
> While tracking down a hang I found this stack trace in distributed unit test 
> output.  I couldn't tell which test it came from, but it should be easy to 
> write a unit test for it.
> Configuration validation should ignore the ds-quorum-checker attribute when 
> doing sameAs comparisons with another configuration.
>  
> {noformat}
> [vm1] [warn 2020/06/16 19:02:34.580 GMT  tid=0x72] Exception 
> occurred while trying to connect the system during reconnect
> [vm1] [warn 2020/06/16 19:02:34.580 GMT  tid=0x72] Exception 
> occurred while trying to connect the system during reconnect
> [vm1] java.lang.IllegalArgumentException: Unknown configuration attribute 
> name ds-quorum-checker. Valid attribute names are: ack-severe-alert-threshold 
> ack-wait-threshold archive-disk-space-limit archive-file-size-limit 
> async-distribution-timeout async-max-queue-size async-queue-timeout 
> bind-address cache-xml-file cluster-configuration-dir cluster-ssl-ciphers 
> cluster-ssl-enabled cluster-ssl-keystore cluster-ssl-keystore-password 
> cluster-ssl-keystore-type cluster-ssl-protocols 
> cluster-ssl-require-authentication cluster-ssl-truststore 
> cluster-ssl-truststore-password conflate-events conserve-sockets 
> delta-propagation deploy-working-dir disable-auto-reconnect disable-jmx 
> disable-tcp distributed-system-id distributed-transactions durable-client-id 
> durable-client-timeout enable-cluster-configuration 
> enable-management-rest-service enable-network-partition-detection 
> enable-time-statistics enforce-unique-host gateway-ssl-ciphers 
> gateway-ssl-enabled gateway-ssl-keystore gateway-ssl-keystore-password 
> gateway-ssl-keystore-type gateway-ssl-protocols 
> gateway-ssl-require-authentication gateway-ssl-truststore 
> gateway-ssl-truststore-password groups http-service-bind-address 
> http-service-port http-service-ssl-ciphers http-service-ssl-enabled 
> http-service-ssl-keystore http-service-ssl-keystore-password 
> http-service-ssl-keystore-type http-service-ssl-protocols 
> http-service-ssl-require-authentication http-service-ssl-truststore 
> http-service-ssl-truststore-password jmx-manager jmx-manager-access-file 
> jmx-manager-bind-address jmx-manager-hostname-for-clients 
> jmx-manager-http-port jmx-manager-password-file jmx-manager-port 
> jmx-manager-ssl-ciphers jmx-manager-ssl-enabled jmx-manager-ssl-keystore 
> jmx-manager-ssl-keystore-password jmx-manager-ssl-keystore-type 
> jmx-manager-ssl-protocols jmx-manager-ssl-require-authentication 
> jmx-manager-ssl-truststore jmx-manager-ssl-truststore-password 
> jmx-manager-start jmx-manager-update-rate load-cluster-configuration-from-dir 
> locator-wait-time locators lock-memory log-disk-space-limit log-file 
> log-file-size-limit log-level max-num-reconnect-tries max-wait-time-reconnect 
> mcast-address mcast-flow-control mcast-port mcast-recv-buffer-size 
> mcast-send-buffer-size mcast-ttl member-timeout membership-port-range 
> memcached-bind-address memcached-port memcached-protocol name 
> off-heap-memory-size redis-bind-address redis-enabled redis-password 
> redis-port redundancy-zone remote-locators remove-unresponsive-client roles 
> security-auth-token-enabled-components security-client-accessor 
> security-client-accessor-pp security-client-auth-init 
> security-client-authenticator security-client-dhalgo security-log-file 
> security-log-level security-manager security-peer-auth-init 
> security-peer-authenticator security-peer-verifymember-timeout 
> security-post-processor security-shiro-init security-udp-dhalgo 
> serializable-object-filter server-bind-address server-ssl-ciphers 
> server-ssl-enabled server-ssl-keystore 

[jira] [Commented] (GEODE-8389) reconnect attempt fails due to distribution configuration validation checks

2020-08-03 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170420#comment-17170420
 ] 

ASF GitHub Bot commented on GEODE-8389:
---

bschuchardt merged pull request #5413:
URL: https://github.com/apache/geode/pull/5413


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> reconnect attempt fails due to distribution configuration validation checks
> ---
>
> Key: GEODE-8389
> URL: https://issues.apache.org/jira/browse/GEODE-8389
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Bruce J Schuchardt
>Priority: Major
>
> While tracking down a hang I found this stack trace in distributed unit test 
> output.  I couldn't tell which test it came from, but it should be easy to 
> write a unit test for it.
> Configuration validation should ignore the ds-quorum-checker attribute when 
> doing sameAs comparisons with another configuration.
>  
> {noformat}
> [vm1] [warn 2020/06/16 19:02:34.580 GMT  tid=0x72] Exception 
> occurred while trying to connect the system during reconnect
> [vm1] [warn 2020/06/16 19:02:34.580 GMT  tid=0x72] Exception 
> occurred while trying to connect the system during reconnect
> [vm1] java.lang.IllegalArgumentException: Unknown configuration attribute 
> name ds-quorum-checker. Valid attribute names are: ack-severe-alert-threshold 
> ack-wait-threshold archive-disk-space-limit archive-file-size-limit 
> async-distribution-timeout async-max-queue-size async-queue-timeout 
> bind-address cache-xml-file cluster-configuration-dir cluster-ssl-ciphers 
> cluster-ssl-enabled cluster-ssl-keystore cluster-ssl-keystore-password 
> cluster-ssl-keystore-type cluster-ssl-protocols 
> cluster-ssl-require-authentication cluster-ssl-truststore 
> cluster-ssl-truststore-password conflate-events conserve-sockets 
> delta-propagation deploy-working-dir disable-auto-reconnect disable-jmx 
> disable-tcp distributed-system-id distributed-transactions durable-client-id 
> durable-client-timeout enable-cluster-configuration 
> enable-management-rest-service enable-network-partition-detection 
> enable-time-statistics enforce-unique-host gateway-ssl-ciphers 
> gateway-ssl-enabled gateway-ssl-keystore gateway-ssl-keystore-password 
> gateway-ssl-keystore-type gateway-ssl-protocols 
> gateway-ssl-require-authentication gateway-ssl-truststore 
> gateway-ssl-truststore-password groups http-service-bind-address 
> http-service-port http-service-ssl-ciphers http-service-ssl-enabled 
> http-service-ssl-keystore http-service-ssl-keystore-password 
> http-service-ssl-keystore-type http-service-ssl-protocols 
> http-service-ssl-require-authentication http-service-ssl-truststore 
> http-service-ssl-truststore-password jmx-manager jmx-manager-access-file 
> jmx-manager-bind-address jmx-manager-hostname-for-clients 
> jmx-manager-http-port jmx-manager-password-file jmx-manager-port 
> jmx-manager-ssl-ciphers jmx-manager-ssl-enabled jmx-manager-ssl-keystore 
> jmx-manager-ssl-keystore-password jmx-manager-ssl-keystore-type 
> jmx-manager-ssl-protocols jmx-manager-ssl-require-authentication 
> jmx-manager-ssl-truststore jmx-manager-ssl-truststore-password 
> jmx-manager-start jmx-manager-update-rate load-cluster-configuration-from-dir 
> locator-wait-time locators lock-memory log-disk-space-limit log-file 
> log-file-size-limit log-level max-num-reconnect-tries max-wait-time-reconnect 
> mcast-address mcast-flow-control mcast-port mcast-recv-buffer-size 
> mcast-send-buffer-size mcast-ttl member-timeout membership-port-range 
> memcached-bind-address memcached-port memcached-protocol name 
> off-heap-memory-size redis-bind-address redis-enabled redis-password 
> redis-port redundancy-zone remote-locators remove-unresponsive-client roles 
> security-auth-token-enabled-components security-client-accessor 
> security-client-accessor-pp security-client-auth-init 
> security-client-authenticator security-client-dhalgo security-log-file 
> security-log-level security-manager security-peer-auth-init 
> security-peer-authenticator security-peer-verifymember-timeout 
> security-post-processor security-shiro-init security-udp-dhalgo 
> serializable-object-filter server-bind-address server-ssl-ciphers 
> server-ssl-enabled server-ssl-keystore server-ssl-keystore-password 
> server-ssl-keystore-type server-ssl-protocols 
> server-ssl-require-authentication server-ssl-truststore 
> server-ssl-truststore-password socket-buffer-size socket-lease-time 
> ssl-ciphers ssl-cluster-alias 

[jira] [Updated] (GEODE-8389) reconnect attempt fails due to distribution configuration validation checks

2020-08-03 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated GEODE-8389:
--
Labels: pull-request-available  (was: )

> reconnect attempt fails due to distribution configuration validation checks
> ---
>
> Key: GEODE-8389
> URL: https://issues.apache.org/jira/browse/GEODE-8389
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Bruce J Schuchardt
>Priority: Major
>  Labels: pull-request-available
>
> While tracking down a hang I found this stack trace in distributed unit test 
> output.  I couldn't tell which test it came from, but it should be easy to 
> write a unit test for it.
> Configuration validation should ignore the ds-quorum-checker attribute when 
> doing sameAs comparisons with another configuration.
>  
> {noformat}
> [vm1] [warn 2020/06/16 19:02:34.580 GMT  tid=0x72] Exception 
> occurred while trying to connect the system during reconnect
> [vm1] [warn 2020/06/16 19:02:34.580 GMT  tid=0x72] Exception 
> occurred while trying to connect the system during reconnect
> [vm1] java.lang.IllegalArgumentException: Unknown configuration attribute 
> name ds-quorum-checker. Valid attribute names are: ack-severe-alert-threshold 
> ack-wait-threshold archive-disk-space-limit archive-file-size-limit 
> async-distribution-timeout async-max-queue-size async-queue-timeout 
> bind-address cache-xml-file cluster-configuration-dir cluster-ssl-ciphers 
> cluster-ssl-enabled cluster-ssl-keystore cluster-ssl-keystore-password 
> cluster-ssl-keystore-type cluster-ssl-protocols 
> cluster-ssl-require-authentication cluster-ssl-truststore 
> cluster-ssl-truststore-password conflate-events conserve-sockets 
> delta-propagation deploy-working-dir disable-auto-reconnect disable-jmx 
> disable-tcp distributed-system-id distributed-transactions durable-client-id 
> durable-client-timeout enable-cluster-configuration 
> enable-management-rest-service enable-network-partition-detection 
> enable-time-statistics enforce-unique-host gateway-ssl-ciphers 
> gateway-ssl-enabled gateway-ssl-keystore gateway-ssl-keystore-password 
> gateway-ssl-keystore-type gateway-ssl-protocols 
> gateway-ssl-require-authentication gateway-ssl-truststore 
> gateway-ssl-truststore-password groups http-service-bind-address 
> http-service-port http-service-ssl-ciphers http-service-ssl-enabled 
> http-service-ssl-keystore http-service-ssl-keystore-password 
> http-service-ssl-keystore-type http-service-ssl-protocols 
> http-service-ssl-require-authentication http-service-ssl-truststore 
> http-service-ssl-truststore-password jmx-manager jmx-manager-access-file 
> jmx-manager-bind-address jmx-manager-hostname-for-clients 
> jmx-manager-http-port jmx-manager-password-file jmx-manager-port 
> jmx-manager-ssl-ciphers jmx-manager-ssl-enabled jmx-manager-ssl-keystore 
> jmx-manager-ssl-keystore-password jmx-manager-ssl-keystore-type 
> jmx-manager-ssl-protocols jmx-manager-ssl-require-authentication 
> jmx-manager-ssl-truststore jmx-manager-ssl-truststore-password 
> jmx-manager-start jmx-manager-update-rate load-cluster-configuration-from-dir 
> locator-wait-time locators lock-memory log-disk-space-limit log-file 
> log-file-size-limit log-level max-num-reconnect-tries max-wait-time-reconnect 
> mcast-address mcast-flow-control mcast-port mcast-recv-buffer-size 
> mcast-send-buffer-size mcast-ttl member-timeout membership-port-range 
> memcached-bind-address memcached-port memcached-protocol name 
> off-heap-memory-size redis-bind-address redis-enabled redis-password 
> redis-port redundancy-zone remote-locators remove-unresponsive-client roles 
> security-auth-token-enabled-components security-client-accessor 
> security-client-accessor-pp security-client-auth-init 
> security-client-authenticator security-client-dhalgo security-log-file 
> security-log-level security-manager security-peer-auth-init 
> security-peer-authenticator security-peer-verifymember-timeout 
> security-post-processor security-shiro-init security-udp-dhalgo 
> serializable-object-filter server-bind-address server-ssl-ciphers 
> server-ssl-enabled server-ssl-keystore server-ssl-keystore-password 
> server-ssl-keystore-type server-ssl-protocols 
> server-ssl-require-authentication server-ssl-truststore 
> server-ssl-truststore-password socket-buffer-size socket-lease-time 
> ssl-ciphers ssl-cluster-alias ssl-default-alias ssl-enabled-components 
> ssl-endpoint-identification-enabled ssl-gateway-alias ssl-jmx-alias 
> ssl-keystore ssl-keystore-password ssl-keystore-type ssl-locator-alias 
> ssl-parameter-extension ssl-protocols ssl-require-authentication 
> ssl-server-alias ssl-truststore ssl-truststore-password ssl-truststore-type 
> ssl-use-default-context ssl-web-alias 

[jira] [Commented] (GEODE-8382) Run Redis tests against Redis API for Geode

2020-08-03 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170418#comment-17170418
 ] 

ASF GitHub Bot commented on GEODE-8382:
---

onichols-pivotal commented on a change in pull request #5416:
URL: https://github.com/apache/geode/pull/5416#discussion_r464647336



##
File path: ci/scripts/execute_redis_tests.sh
##
@@ -0,0 +1,51 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+cd ..
+git clone --config transfer.fsckObjects=false 
https://github.com/prettyClouds/redis.git

Review comment:
   would a comment be appropriate here explaining why a personal fork is 
being used and the plan/timeline for eliminating dependency on a personal fork?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Run Redis tests against Redis API for Geode
> ---
>
> Key: GEODE-8382
> URL: https://issues.apache.org/jira/browse/GEODE-8382
> Project: Geode
>  Issue Type: New Feature
>  Components: ci, redis
>Reporter: Sarah Abbey
>Priority: Major
>  Labels: pull-request-available
>
> We would like to run Redis's tests against Redis API for Geode.  Tests will 
> run a separate job in the PR and main pipelines.  It has been included in the 
> 'tests' jinja variables.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8382) Run Redis tests against Redis API for Geode

2020-08-03 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170417#comment-17170417
 ] 

ASF GitHub Bot commented on GEODE-8382:
---

onichols-pivotal commented on a change in pull request #5416:
URL: https://github.com/apache/geode/pull/5416#discussion_r464646511



##
File path: ci/scripts/execute_redis_tests.sh
##
@@ -0,0 +1,51 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+cd ..
+git clone --config transfer.fsckObjects=false 
https://github.com/prettyClouds/redis.git
+cd redis
+git checkout tests-geode-redis
+
+JAVA_HOME="/usr/lib/jvm/java-11-openjdk-amd64"  \
+../geode-assembly/build/install/apache-geode/bin/gfsh start server \
+  --J=-Denable-redis-unsupported-commands=true \
+  --name=server1 \
+  --redis-port=6380 \
+  --redis-bind-address=127.0.0.1 \
+  --redis-password=foobar
+
+failCount=0
+
+./runtest --host 127.0.0.1 --port 6380 --single unit/auth
+
+((failCount+=$?))
+
+JAVA_HOME="/usr/lib/jvm/java-11-openjdk-amd64" \

Review comment:
   redundant as you have already set JAVA_HOME above





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Run Redis tests against Redis API for Geode
> ---
>
> Key: GEODE-8382
> URL: https://issues.apache.org/jira/browse/GEODE-8382
> Project: Geode
>  Issue Type: New Feature
>  Components: ci, redis
>Reporter: Sarah Abbey
>Priority: Major
>  Labels: pull-request-available
>
> We would like to run Redis's tests against Redis API for Geode.  Tests will 
> run a separate job in the PR and main pipelines.  It has been included in the 
> 'tests' jinja variables.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8382) Run Redis tests against Redis API for Geode

2020-08-03 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170416#comment-17170416
 ] 

ASF GitHub Bot commented on GEODE-8382:
---

onichols-pivotal commented on a change in pull request #5416:
URL: https://github.com/apache/geode/pull/5416#discussion_r464644167



##
File path: ci/scripts/execute_redis_tests.sh
##
@@ -0,0 +1,51 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+cd ..
+git clone --config transfer.fsckObjects=false 
https://github.com/prettyClouds/redis.git
+cd redis
+git checkout tests-geode-redis
+
+JAVA_HOME="/usr/lib/jvm/java-11-openjdk-amd64"  \

Review comment:
   you should not need to hardcode the JDK path.  The JDK you should be 
using is passed to you as `${JAVA_TEST_PATH}` (see ci/scripts/execute_tests.sh)





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Run Redis tests against Redis API for Geode
> ---
>
> Key: GEODE-8382
> URL: https://issues.apache.org/jira/browse/GEODE-8382
> Project: Geode
>  Issue Type: New Feature
>  Components: ci, redis
>Reporter: Sarah Abbey
>Priority: Major
>  Labels: pull-request-available
>
> We would like to run Redis's tests against Redis API for Geode.  Tests will 
> run a separate job in the PR and main pipelines.  It has been included in the 
> 'tests' jinja variables.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-6564) Clearing a replicated region with expiration causes a memory leak

2020-08-03 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-6564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170415#comment-17170415
 ] 

ASF GitHub Bot commented on GEODE-6564:
---

dschneider-pivotal commented on pull request #5419:
URL: https://github.com/apache/geode/pull/5419#issuecomment-668226584


   The dunit failure is the known issue: GEODE-7710



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clearing a replicated region with expiration causes a memory leak
> -
>
> Key: GEODE-6564
> URL: https://issues.apache.org/jira/browse/GEODE-6564
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Barrett Oglesby
>Priority: Major
>  Labels: pull-request-available
>
> Clearing a replicated region with expiration causes a memory leak
> Both the RegionEntries and EntryExpiryTasks are still live after loading 
> entries into the region and then clearing it.
> Server Startup:
> {noformat}
>  num #instances #bytes class name
> --
>  1: 29856 2797840 [C
>  4: 2038 520600 [B
> Total 187711 10089624
> {noformat}
> Load 100 entries with 600k payload (representing a session):
> {noformat}
>  num #instances #bytes class name
> --
>  1: 2496 60666440 [B
>  2: 30157 2828496 [C
>  73: 100 7200 
> org.apache.geode.internal.cache.entries.VersionedStatsRegionEntryHeapStringKey1
>  93: 100 4800 org.apache.geode.internal.cache.EntryExpiryTask
> Total 190737 70240472
> {noformat}
> Clear region:
> {noformat}
>  num #instances #bytes class name
> --
>  1: 2398 60505944 [B
>  2: 30448 2849456 [C
>  74: 100 7200 
> org.apache.geode.internal.cache.entries.VersionedStatsRegionEntryHeapStringKey1
>  100: 100 4800 org.apache.geode.internal.cache.EntryExpiryTask
> Total 192199 70373048
> {noformat}
> Load and clear another 100 entries:
> {noformat}
>  num #instances #bytes class name
> --
>  1: 2503 120511688 [B
>  2: 30506 2854384 [C
>  46: 200 14400 
> org.apache.geode.internal.cache.entries.VersionedStatsRegionEntryHeapStringKey1
>  61: 200 9600 org.apache.geode.internal.cache.EntryExpiryTask
> Total 193272 130421432
> {noformat}
> Load and clear another 100 entries:
> {noformat}
>  num #instances #bytes class name
> --
>  1: 2600 180517240 [B
>  2: 30562 2859584 [C
>  33: 300 21600 
> org.apache.geode.internal.cache.entries.VersionedStatsRegionEntryHeapStringKey1
>  47: 300 14400 org.apache.geode.internal.cache.EntryExpiryTask
> Total 194310 190468176
> {noformat}
> A heap dump shows the VersionedStatsRegionEntryHeapStringKey1 instances are 
> referenced by the DistributedRegion entryExpiryTasks:
> {noformat}
> --> org.apache.geode.internal.cache.DistributedRegion@0x76adbbb88 (816 bytes) 
> (field entryExpiryTasks:)
> --> java.util.concurrent.ConcurrentHashMap@0x76adbc028 (100 bytes) (field 
> table:)
> --> [Ljava.util.concurrent.ConcurrentHashMap$Node;@0x76ee85358 (4112 bytes) 
> (Element 276 of [Ljava.util.concurrent.ConcurrentHashMap$Node;@0x76ee85358:)
> --> java.util.concurrent.ConcurrentHashMap$Node@0x76edc4e20 (44 bytes) (field 
> next:)
> --> java.util.concurrent.ConcurrentHashMap$Node@0x76edc32f0 (44 bytes) (field 
> key:)
> --> 
> org.apache.geode.internal.cache.entries.VersionedStatsRegionEntryHeapStringKey1@0x76edc3210
>  (86 bytes) 
> {noformat}
> LocalRegion.cancelAllEntryExpiryTasks is called when the region is cleared:
> {noformat}
> java.lang.Exception: Stack trace
>  at java.lang.Thread.dumpStack(Thread.java:1333)
>  at 
> org.apache.geode.internal.cache.LocalRegion.cancelAllEntryExpiryTasks(LocalRegion.java:8202)
>  at 
> org.apache.geode.internal.cache.LocalRegion.clearRegionLocally(LocalRegion.java:9094)
>  at 
> org.apache.geode.internal.cache.DistributedRegion.cmnClearRegion(DistributedRegion.java:1962)
>  at 
> org.apache.geode.internal.cache.LocalRegion.basicClear(LocalRegion.java:8998)
>  at 
> org.apache.geode.internal.cache.DistributedRegion.basicClear(DistributedRegion.java:1939)
>  at 
> org.apache.geode.internal.cache.LocalRegion.basicBridgeClear(LocalRegion.java:8988)
>  at 
> org.apache.geode.internal.cache.tier.sockets.command.ClearRegion.cmdExecute(ClearRegion.java:123)
> {noformat}
> But it doesn't clear the entryExpiryTasks map:
> {noformat}
> LocalRegion.clearRegionLocally before cancelAllEntryExpiryTasks 
> entryExpiryTasks=100
> LocalRegion.clearRegionLocally after 

[jira] [Commented] (GEODE-8382) Run Redis tests against Redis API for Geode

2020-08-03 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170413#comment-17170413
 ] 

ASF GitHub Bot commented on GEODE-8382:
---

onichols-pivotal commented on a change in pull request #5416:
URL: https://github.com/apache/geode/pull/5416#discussion_r464644167



##
File path: ci/scripts/execute_redis_tests.sh
##
@@ -0,0 +1,51 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+cd ..
+git clone --config transfer.fsckObjects=false 
https://github.com/prettyClouds/redis.git
+cd redis
+git checkout tests-geode-redis
+
+JAVA_HOME="/usr/lib/jvm/java-11-openjdk-amd64"  \

Review comment:
   rather than hardcoding the JDK path, please use JAVA_HOME at this point, 
as you've already configured `ONLY_JDK: 11` and ci/scripts/execute_tests.sh 
sets up JAVA_HOME for the heavy lifter already





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Run Redis tests against Redis API for Geode
> ---
>
> Key: GEODE-8382
> URL: https://issues.apache.org/jira/browse/GEODE-8382
> Project: Geode
>  Issue Type: New Feature
>  Components: ci, redis
>Reporter: Sarah Abbey
>Priority: Major
>  Labels: pull-request-available
>
> We would like to run Redis's tests against Redis API for Geode.  Tests will 
> run a separate job in the PR and main pipelines.  It has been included in the 
> 'tests' jinja variables.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8382) Run Redis tests against Redis API for Geode

2020-08-03 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170408#comment-17170408
 ] 

ASF GitHub Bot commented on GEODE-8382:
---

rhoughton-pivot commented on a change in pull request #5416:
URL: https://github.com/apache/geode/pull/5416#discussion_r464641006



##
File path: ci/scripts/execute_redis_tests.sh
##
@@ -0,0 +1,51 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+cd ..
+git clone --config transfer.fsckObjects=false 
https://github.com/prettyClouds/redis.git
+cd redis
+git checkout tests-geode-redis
+
+JAVA_HOME="/usr/lib/jvm/java-11-openjdk-amd64"  \
+../geode-assembly/build/install/apache-geode/bin/gfsh start server \
+  --J=-Denable-redis-unsupported-commands=true \
+  --name=server1 \
+  --redis-port=6380 \
+  --redis-bind-address=127.0.0.1 \
+  --redis-password=foobar
+
+failCount=0
+
+./runtest --host 127.0.0.1 --port 6380 --single unit/auth
+
+((failCount+=$?))
+
+JAVA_HOME="/usr/lib/jvm/java-11-openjdk-amd64" \
+../geode-assembly/build/install/apache-geode/bin/gfsh start server \
+  --J=-Denable-redis-unsupported-commands=true \
+  --name=server2 \
+  --server-port=0 \
+  --redis-port=6379 \
+  --redis-bind-address=127.0.0.1
+
+./runtest --host 127.0.0.1 --port 6379 --single unit/type/set --single 
unit/expire
+
+((failCount+=$?))
+
+exit $failCount

Review comment:
   I saw that this does fail-red when the count != 0. Looks good.

##
File path: ci/pipelines/shared/jinja.variables.yml
##
@@ -140,6 +140,19 @@ tests:
   PLATFORM: linux
   RAM: '210'
   name: Upgrade
+- ARTIFACT_SLUG: redistests
+  CALL_STACK_TIMEOUT: '1200'
+  CPUS: '4'
+  DUNIT_PARALLEL_FORKS: '0'
+  EXECUTE_TEST_TIMEOUT: 30m
+  GRADLE_TASK: ':geode-redis:redisAPITest'
+  MAX_IN_FLIGHT: 1
+  ONLY_JDK: 11
+  PARALLEL_DUNIT: 'false'
+  PARALLEL_GRADLE: 'true'
+  PLATFORM: linux
+  RAM: '16'

Review comment:
   I looked at the resource usage for this heavy lifter, and we can safely 
take this down to 8GB ram, easy.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Run Redis tests against Redis API for Geode
> ---
>
> Key: GEODE-8382
> URL: https://issues.apache.org/jira/browse/GEODE-8382
> Project: Geode
>  Issue Type: New Feature
>  Components: ci, redis
>Reporter: Sarah Abbey
>Priority: Major
>  Labels: pull-request-available
>
> We would like to run Redis's tests against Redis API for Geode.  Tests will 
> run a separate job in the PR and main pipelines.  It has been included in the 
> 'tests' jinja variables.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (GEODE-7846) Clear in Partitioned Region should have its own stats

2020-08-03 Thread Benjamin P Ross (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-7846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin P Ross reassigned GEODE-7846:
--

Assignee: Benjamin P Ross

> Clear in Partitioned Region should have its own stats
> -
>
> Key: GEODE-7846
> URL: https://issues.apache.org/jira/browse/GEODE-7846
> Project: Geode
>  Issue Type: Improvement
>  Components: core
>Reporter: Xiaojian Zhou
>Assignee: Benjamin P Ross
>Priority: Major
>  Labels: GeodeCommons, GeodeOperationAPI, pull-request-available
>
> Clear operation in PR should have its own stats: 
> 1) clear operation executed. 
> 2) clear operation failed
> 3) clear messages sends to buckets



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7846) Clear in Partitioned Region should have its own stats

2020-08-03 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170374#comment-17170374
 ] 

ASF GitHub Bot commented on GEODE-7846:
---

BenjaminPerryRoss commented on a change in pull request #5391:
URL: https://github.com/apache/geode/pull/5391#discussion_r464609432



##
File path: 
geode-core/src/main/java/org/apache/geode/internal/cache/CachePerfStats.java
##
@@ -274,7 +278,14 @@
 "Current number of regions configured for reliablity that are missing 
required roles with Limited access";
 final String reliableRegionsMissingNoAccessDesc =
 "Current number of regions configured for reliablity that are missing 
required roles with No access";
-final String clearsDesc = "The total number of times a clear has been done 
on this cache.";
+final String regionClearsDesc =
+"The total number of times a clear has been done on this cache.";
+final String bucketClearsDesc =
+"The total number of times a clear has been done on this region and 
it's bucket regions";
+final String partitionedRegionClearLocalDurationDesc =
+"The time in nanoseconds partitioned region clear has been running for 
the region on this member";

Review comment:
   I actually switched this from the original metric I used to nanoseconds 
because other stats in the file seem to be using them and I wanted to be 
consistent (such as EventQueueThrottleTime or any of the tx lifetime stats in 
that class).





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clear in Partitioned Region should have its own stats
> -
>
> Key: GEODE-7846
> URL: https://issues.apache.org/jira/browse/GEODE-7846
> Project: Geode
>  Issue Type: Improvement
>  Components: core
>Reporter: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeCommons, GeodeOperationAPI, pull-request-available
>
> Clear operation in PR should have its own stats: 
> 1) clear operation executed. 
> 2) clear operation failed
> 3) clear messages sends to buckets



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (GEODE-7671) Partitioned Region clear operations can occur successfully during GII

2020-08-03 Thread Benjamin P Ross (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-7671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin P Ross reassigned GEODE-7671:
--

Assignee: Benjamin P Ross

> Partitioned Region clear operations can occur successfully during GII 
> --
>
> Key: GEODE-7671
> URL: https://issues.apache.org/jira/browse/GEODE-7671
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Benjamin P Ross
>Priority: Major
>  Labels: GeodeCommons
>
> Clear operations are successful when the region is undergoing GII
> Acceptance : 
>  * Passing DUnit tests where clear operations are successful on partitioned 
> region when they are undergoing GII from another member
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.
>  
> analyze if these tests are needed for offheap?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (GEODE-8394) Client sends partial data during retry

2020-08-03 Thread Anilkumar Gingade (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anilkumar Gingade reassigned GEODE-8394:


Assignee: Anilkumar Gingade

> Client sends partial data during retry
> --
>
> Key: GEODE-8394
> URL: https://issues.apache.org/jira/browse/GEODE-8394
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Affects Versions: 1.14.0
>Reporter: Anilkumar Gingade
>Assignee: Anilkumar Gingade
>Priority: Major
>  Labels: GeodeOperationAPI
>
> When executing the command, java client sends the command in the form of 
> message (Parts). If there is a failure during the send, it retries number of 
> times based on the retry-attempt setting.
> If there is a failure in the first attempt due to Exception (IOException, 
> EOFException - read timeout); during the second attempt the client is sending 
> partial data, instead of the complete data.
> This could be reproduced by setting a small read-timeout and large object 
> (Put).
> Because of this, the put from client succeeds by creating partial data on the 
> server cache. Since the data is stored in serialized form, there is no 
> exception thrown during put() operation, giving an impression that put 
> operation is successful. 
> The workaround for now is to have large read-timeout setting; while trying to 
> send a large object.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7846) Clear in Partitioned Region should have its own stats

2020-08-03 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170366#comment-17170366
 ] 

ASF GitHub Bot commented on GEODE-7846:
---

BenjaminPerryRoss commented on a change in pull request #5391:
URL: https://github.com/apache/geode/pull/5391#discussion_r464609432



##
File path: 
geode-core/src/main/java/org/apache/geode/internal/cache/CachePerfStats.java
##
@@ -274,7 +278,14 @@
 "Current number of regions configured for reliablity that are missing 
required roles with Limited access";
 final String reliableRegionsMissingNoAccessDesc =
 "Current number of regions configured for reliablity that are missing 
required roles with No access";
-final String clearsDesc = "The total number of times a clear has been done 
on this cache.";
+final String regionClearsDesc =
+"The total number of times a clear has been done on this cache.";
+final String bucketClearsDesc =
+"The total number of times a clear has been done on this region and 
it's bucket regions";
+final String partitionedRegionClearLocalDurationDesc =
+"The time in nanoseconds partitioned region clear has been running for 
the region on this member";

Review comment:
   I actually switch this from the original metric I used to nanoseconds 
because other stats in the file seem to be using them and I wanted to be 
consistent (such as EventQueueThrottleTime or any of the tx lifetime stats in 
that class).





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clear in Partitioned Region should have its own stats
> -
>
> Key: GEODE-7846
> URL: https://issues.apache.org/jira/browse/GEODE-7846
> Project: Geode
>  Issue Type: Improvement
>  Components: core
>Reporter: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeCommons, GeodeOperationAPI, pull-request-available
>
> Clear operation in PR should have its own stats: 
> 1) clear operation executed. 
> 2) clear operation failed
> 3) clear messages sends to buckets



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (GEODE-8074) Add documentation for PR clear

2020-08-03 Thread Benjamin P Ross (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin P Ross updated GEODE-8074:
---
Description: 
With the addition of the ability to clear a partitioned region we need to add 
documentation for the following:

* new gfsh command 'clear' and modifications made to existing 'remove' command 
(work done on GEODE-7667) 

* changed the clearCount stat in 'cachePerfStats' to regionClearCount and 
bucketClearCount in addition to adding localClearDuration and 
TotalClearDuration stats (work done on GEODE-7846)

* existing documentation for clear to indicate clearing a partitioned region is 
permitted.

  was:
With the addition of the ability to clear a partitioned region we need to add 
documentation for the following:

* new gfsh command 'clear' and modifications made to existing 'remove' command 
(work done on GEODE-7667) 

*changed the clearCount stat in 'cachePerfStats' to regionClearCount and 
bucketClearCount in addition to adding localClearDuration and 
TotalClearDuration stats (work done on GEODE-7846)

*existing documentation for clear to indicate clearing a partitioned region is 
permitted.


> Add documentation for PR clear
> --
>
> Key: GEODE-8074
> URL: https://issues.apache.org/jira/browse/GEODE-8074
> Project: Geode
>  Issue Type: New Feature
>  Components: docs
>Reporter: Benjamin P Ross
>Priority: Major
>
> With the addition of the ability to clear a partitioned region we need to add 
> documentation for the following:
> * new gfsh command 'clear' and modifications made to existing 'remove' 
> command (work done on GEODE-7667) 
> * changed the clearCount stat in 'cachePerfStats' to regionClearCount and 
> bucketClearCount in addition to adding localClearDuration and 
> TotalClearDuration stats (work done on GEODE-7846)
> * existing documentation for clear to indicate clearing a partitioned region 
> is permitted.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (GEODE-8074) Add documentation for PR clear

2020-08-03 Thread Benjamin P Ross (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin P Ross updated GEODE-8074:
---
Description: 
With the addition of the ability to clear a partitioned region we need to add 
documentation for the following:

* new gfsh command 'clear' and modifications made to existing 'remove' command 
(work done on GEODE-7667) 

*changed the clearCount stat in 'cachePerfStats' to regionClearCount and 
bucketClearCount in addition to adding localClearDuration and 
TotalClearDuration stats (work done on GEODE-7846)

*existing documentation for clear to indicate clearing a partitioned region is 
permitted.

  was:
With the addition of the ability to clear a partitioned region we need to add 
documentation for the following:

 - new gfsh command 'clear' and modifications made to existing 'remove' command 
(work done on GEODE-7667) 

 

- changed the clearCount stat in 'cachePerfStats' to regionClearCount and 
bucketClearCount in addition to adding localClearDuration and 
TotalClearDuration stats (work done on GEODE-7846)

 - existing documentation for clear to indicate clearing a partitioned region 
is permitted.


> Add documentation for PR clear
> --
>
> Key: GEODE-8074
> URL: https://issues.apache.org/jira/browse/GEODE-8074
> Project: Geode
>  Issue Type: New Feature
>  Components: docs
>Reporter: Benjamin P Ross
>Priority: Major
>
> With the addition of the ability to clear a partitioned region we need to add 
> documentation for the following:
> * new gfsh command 'clear' and modifications made to existing 'remove' 
> command (work done on GEODE-7667) 
> *changed the clearCount stat in 'cachePerfStats' to regionClearCount and 
> bucketClearCount in addition to adding localClearDuration and 
> TotalClearDuration stats (work done on GEODE-7846)
> *existing documentation for clear to indicate clearing a partitioned region 
> is permitted.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (GEODE-8074) Add documentation for PR clear

2020-08-03 Thread Benjamin P Ross (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin P Ross updated GEODE-8074:
---
Description: 
With the addition of the ability to clear a partitioned region we need to add 
documentation for the following:

 - new gfsh command 'clear' and modifications made to existing 'remove' command 
(work done on GEODE-7667) 

 

- changed the clearCount stat in 'cachePerfStats' to regionClearCount and 
bucketClearCount in addition to adding localClearDuration and 
TotalClearDuration stats (work done on GEODE-7846)

 - existing documentation for clear to indicate clearing a partitioned region 
is permitted.

  was:
With the addition of the ability to clear a partitioned region we need to add 
documentation for the following:

 - new gfsh command 'clear' and modifications made to existing 'remove' command 
(work done on GEODE-7667) 

- changed the clearCount stat in 'cachePerfStats' to regionClearCount and 
bucketClearCount in addition to adding localClearDuration and 
TotalClearDuration stats (work done on GEODE-7846)

 - existing documentation for clear to indicate clearing a partitioned region 
is permitted.


> Add documentation for PR clear
> --
>
> Key: GEODE-8074
> URL: https://issues.apache.org/jira/browse/GEODE-8074
> Project: Geode
>  Issue Type: New Feature
>  Components: docs
>Reporter: Benjamin P Ross
>Priority: Major
>
> With the addition of the ability to clear a partitioned region we need to add 
> documentation for the following:
>  - new gfsh command 'clear' and modifications made to existing 'remove' 
> command (work done on GEODE-7667) 
>  
> - changed the clearCount stat in 'cachePerfStats' to regionClearCount and 
> bucketClearCount in addition to adding localClearDuration and 
> TotalClearDuration stats (work done on GEODE-7846)
>  - existing documentation for clear to indicate clearing a partitioned region 
> is permitted.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (GEODE-8074) Add documentation for PR clear

2020-08-03 Thread Benjamin P Ross (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin P Ross updated GEODE-8074:
---
Description: 
With the addition of the ability to clear a partitioned region we need to add 
documentation for the following:

 - new gfsh command 'clear' and modifications made to existing 'remove' command 
(work done on GEODE-7667) 

- changed the clearCount stat in 'cachePerfStats' to regionClearCount and 
bucketClearCount in addition to adding localClearDuration and 
TotalClearDuration stats (work done on GEODE-7846)

 - existing documentation for clear to indicate clearing a partitioned region 
is permitted.

  was:
With the addition of the ability to clear a partitioned region we need to add 
documentation for the following:

 - new gfsh command 'clear' (work done on GEODE-

 - as well as update existing documentation for existing clear feature and 
'remove' command.


> Add documentation for PR clear
> --
>
> Key: GEODE-8074
> URL: https://issues.apache.org/jira/browse/GEODE-8074
> Project: Geode
>  Issue Type: New Feature
>  Components: docs
>Reporter: Benjamin P Ross
>Priority: Major
>
> With the addition of the ability to clear a partitioned region we need to add 
> documentation for the following:
>  - new gfsh command 'clear' and modifications made to existing 'remove' 
> command (work done on GEODE-7667) 
> - changed the clearCount stat in 'cachePerfStats' to regionClearCount and 
> bucketClearCount in addition to adding localClearDuration and 
> TotalClearDuration stats (work done on GEODE-7846)
>  - existing documentation for clear to indicate clearing a partitioned region 
> is permitted.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (GEODE-8074) Add documentation for PR clear

2020-08-03 Thread Benjamin P Ross (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin P Ross updated GEODE-8074:
---
Description: 
With the addition of the ability to clear a partitioned region we need to add 
documentation for the following:

 - new gfsh command 'clear' (work done on GEODE-

 - as well as update existing documentation for existing clear feature and 
'remove' command.

  was:With the addition of the ability to clear a partitioned region we need to 
add documentation for the new gfsh command 'clear' as well as update existing 
documentation for existing clear feature and 'remove' command.


> Add documentation for PR clear
> --
>
> Key: GEODE-8074
> URL: https://issues.apache.org/jira/browse/GEODE-8074
> Project: Geode
>  Issue Type: New Feature
>  Components: docs
>Reporter: Benjamin P Ross
>Priority: Major
>
> With the addition of the ability to clear a partitioned region we need to add 
> documentation for the following:
>  - new gfsh command 'clear' (work done on GEODE-
>  - as well as update existing documentation for existing clear feature and 
> 'remove' command.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8400) NullPointerException in AbstractCommitSessionValve.commitSession

2020-08-03 Thread Eric Shu (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170335#comment-17170335
 ] 

Eric Shu commented on GEODE-8400:
-

Please also see GEODE-8221, which Jake mentioned it should be addressed.

{code:java}
protected static > void 
commitSession(
  final Request request) {
final Context context = request.getContext();
-->final Manager manager = context.getManager();
{code}
NPE thrown is because context is returned null.

Artifacts can be found in 
http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0255/test-results/distributedTest/1596348822/

http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0255/test-artifacts/1596348822/distributedtestfiles-OpenJDK8-1.14.0-build.0255.tgz


> NullPointerException in AbstractCommitSessionValve.commitSession
> 
>
> Key: GEODE-8400
> URL: https://issues.apache.org/jira/browse/GEODE-8400
> Project: Geode
>  Issue Type: Bug
>  Components: http session
>Reporter: Eric Shu
>Priority: Major
>
> {noformat}
> java.lang.RuntimeException: 
> /home/geode/geode/geode-assembly/build/distributedTest329/cargo_logs/TOMCAT8_client-server_attributesCanBeReplaced_0_d46a2c34-8a55-4c2f-9789-01bd35afb728/container.log
>  contains java.lang.NullPointerException
>   at 
> org.apache.geode.session.tests.LogChecker.checkLogs(LogChecker.java:87)
>   at 
> org.apache.geode.session.tests.LogChecker.checkLogs(LogChecker.java:44)
>   at 
> org.apache.geode.session.tests.CargoTestBase.checkLogs(CargoTestBase.java:412)
>   at 
> org.apache.geode.session.tests.CargoTestBase.attributesCanBeReplaced(CargoTestBase.java:406)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at 
> org.apache.geode.test.junit.rules.DescribedExternalResource$1.evaluate(DescribedExternalResource.java:40)
>   at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
>   at 
> org.apache.geode.test.dunit.rules.ClusterStartupRule$1.evaluate(ClusterStartupRule.java:138)
>   at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> {noformat}
> The NPE occurs here:
> {noformat}
> Aug 02, 2020 4:45:10 AM org.apache.coyote.http11.Http11Processor service
> SEVERE: Error processing request
> java.lang.NullPointerException
>   at 
> org.apache.geode.modules.session.catalina.AbstractCommitSessionValve.commitSession(AbstractCommitSessionValve.java:61)
>   at 
> org.apache.geode.modules.session.catalina.Tomcat8CommitSessionValve.lambda$wrapResponse$0(Tomcat8CommitSessionValve.java:45)
>   at 
> org.apache.geode.modules.session.catalina.Tomcat8CommitSessionOutputBuffer.doWrite(Tomcat8CommitSessionOutputBuffer.java:48)
>   at org.apache.coyote.Response.doWrite(Response.java:600)
>   at 
> org.apache.catalina.connector.OutputBuffer.realWriteBytes(OutputBuffer.java:360)
>   at 
> org.apache.catalina.connector.OutputBuffer.flushByteBuffer(OutputBuffer.java:841)
>   at 
> org.apache.catalina.connector.OutputBuffer.doFlush(OutputBuffer.java:319)
>   at 
> org.apache.catalina.connector.OutputBuffer.close(OutputBuffer.java:272)
>   at 
> 

[jira] [Commented] (GEODE-7846) Clear in Partitioned Region should have its own stats

2020-08-03 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170334#comment-17170334
 ] 

ASF GitHub Bot commented on GEODE-7846:
---

gesterzhou commented on a change in pull request #5391:
URL: https://github.com/apache/geode/pull/5391#discussion_r464583502



##
File path: 
geode-core/src/main/java/org/apache/geode/internal/cache/CachePerfStats.java
##
@@ -274,7 +278,14 @@
 "Current number of regions configured for reliablity that are missing 
required roles with Limited access";
 final String reliableRegionsMissingNoAccessDesc =
 "Current number of regions configured for reliablity that are missing 
required roles with No access";
-final String clearsDesc = "The total number of times a clear has been done 
on this cache.";
+final String regionClearsDesc =
+"The total number of times a clear has been done on this cache.";
+final String bucketClearsDesc =
+"The total number of times a clear has been done on this region and 
it's bucket regions";
+final String partitionedRegionClearLocalDurationDesc =
+"The time in nanoseconds partitioned region clear has been running for 
the region on this member";

Review comment:
   we have to follow other duration stats's timeunit. If other duration 
stats used nanoseconds, we use it too. Otherwise, we should not.  





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clear in Partitioned Region should have its own stats
> -
>
> Key: GEODE-7846
> URL: https://issues.apache.org/jira/browse/GEODE-7846
> Project: Geode
>  Issue Type: Improvement
>  Components: core
>Reporter: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeCommons, GeodeOperationAPI, pull-request-available
>
> Clear operation in PR should have its own stats: 
> 1) clear operation executed. 
> 2) clear operation failed
> 3) clear messages sends to buckets



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (GEODE-8400) NullPointerException in AbstractCommitSessionValve.commitSession

2020-08-03 Thread Eric Shu (Jira)
Eric Shu created GEODE-8400:
---

 Summary: NullPointerException in 
AbstractCommitSessionValve.commitSession
 Key: GEODE-8400
 URL: https://issues.apache.org/jira/browse/GEODE-8400
 Project: Geode
  Issue Type: Bug
  Components: http session
Reporter: Eric Shu


{noformat}
java.lang.RuntimeException: 
/home/geode/geode/geode-assembly/build/distributedTest329/cargo_logs/TOMCAT8_client-server_attributesCanBeReplaced_0_d46a2c34-8a55-4c2f-9789-01bd35afb728/container.log
 contains java.lang.NullPointerException

at 
org.apache.geode.session.tests.LogChecker.checkLogs(LogChecker.java:87)
at 
org.apache.geode.session.tests.LogChecker.checkLogs(LogChecker.java:44)
at 
org.apache.geode.session.tests.CargoTestBase.checkLogs(CargoTestBase.java:412)
at 
org.apache.geode.session.tests.CargoTestBase.attributesCanBeReplaced(CargoTestBase.java:406)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at 
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at 
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at 
org.apache.geode.test.junit.rules.DescribedExternalResource$1.evaluate(DescribedExternalResource.java:40)
at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
at 
org.apache.geode.test.dunit.rules.ClusterStartupRule$1.evaluate(ClusterStartupRule.java:138)
at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
{noformat}

The NPE occurs here:
{noformat}
Aug 02, 2020 4:45:10 AM org.apache.coyote.http11.Http11Processor service
SEVERE: Error processing request
java.lang.NullPointerException
at 
org.apache.geode.modules.session.catalina.AbstractCommitSessionValve.commitSession(AbstractCommitSessionValve.java:61)
at 
org.apache.geode.modules.session.catalina.Tomcat8CommitSessionValve.lambda$wrapResponse$0(Tomcat8CommitSessionValve.java:45)
at 
org.apache.geode.modules.session.catalina.Tomcat8CommitSessionOutputBuffer.doWrite(Tomcat8CommitSessionOutputBuffer.java:48)
at org.apache.coyote.Response.doWrite(Response.java:600)
at 
org.apache.catalina.connector.OutputBuffer.realWriteBytes(OutputBuffer.java:360)
at 
org.apache.catalina.connector.OutputBuffer.flushByteBuffer(OutputBuffer.java:841)
at 
org.apache.catalina.connector.OutputBuffer.doFlush(OutputBuffer.java:319)
at 
org.apache.catalina.connector.OutputBuffer.close(OutputBuffer.java:272)
at 
org.apache.catalina.connector.Response.finishResponse(Response.java:444)
at 
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:374)
at 
org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:609)
at 
org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:65)
at 
org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:810)
at 
org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1623)
at 
org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at 
org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
at java.lang.Thread.run(Thread.java:748)
{noformat}

[jira] [Closed] (GEODE-8391) Skip AvailablePort test assertion if host machine does not support it

2020-08-03 Thread Dale Emery (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dale Emery closed GEODE-8391.
-

> Skip AvailablePort test assertion if host machine does not support it
> -
>
> Key: GEODE-8391
> URL: https://issues.apache.org/jira/browse/GEODE-8391
> Project: Geode
>  Issue Type: Test
>  Components: tests
>Reporter: Dale Emery
>Assignee: Dale Emery
>Priority: Major
>  Labels: GeodeOperationAPI, pull-request-available
> Fix For: 1.14.0
>
>
> One of the assertions in {{AvailablePortJUnitTest.testIsPortAvailable()}} 
> assumes that the {{InetAddress}} for the local host is not a loopback 
> address. Though this assumption holds in our CI containers, it fails on some 
> developer's Macs.
> Change the test to skip this one assertion if the {{InetAddress}} for the 
> local host is a loopback address.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (GEODE-8391) Skip AvailablePort test assertion if host machine does not support it

2020-08-03 Thread Dale Emery (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dale Emery reassigned GEODE-8391:
-

Assignee: Dale Emery

> Skip AvailablePort test assertion if host machine does not support it
> -
>
> Key: GEODE-8391
> URL: https://issues.apache.org/jira/browse/GEODE-8391
> Project: Geode
>  Issue Type: Test
>  Components: tests
>Reporter: Dale Emery
>Assignee: Dale Emery
>Priority: Major
>  Labels: GeodeOperationAPI, pull-request-available
>
> One of the assertions in {{AvailablePortJUnitTest.testIsPortAvailable()}} 
> assumes that the {{InetAddress}} for the local host is not a loopback 
> address. Though this assumption holds in our CI containers, it fails on some 
> developer's Macs.
> Change the test to skip this one assertion if the {{InetAddress}} for the 
> local host is a loopback address.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (GEODE-8391) Skip AvailablePort test assertion if host machine does not support it

2020-08-03 Thread Dale Emery (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dale Emery resolved GEODE-8391.
---
Fix Version/s: 1.14.0
   Resolution: Fixed

> Skip AvailablePort test assertion if host machine does not support it
> -
>
> Key: GEODE-8391
> URL: https://issues.apache.org/jira/browse/GEODE-8391
> Project: Geode
>  Issue Type: Test
>  Components: tests
>Reporter: Dale Emery
>Assignee: Dale Emery
>Priority: Major
>  Labels: GeodeOperationAPI, pull-request-available
> Fix For: 1.14.0
>
>
> One of the assertions in {{AvailablePortJUnitTest.testIsPortAvailable()}} 
> assumes that the {{InetAddress}} for the local host is not a loopback 
> address. Though this assumption holds in our CI containers, it fails on some 
> developer's Macs.
> Change the test to skip this one assertion if the {{InetAddress}} for the 
> local host is a loopback address.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8382) Run Redis tests against Redis API for Geode

2020-08-03 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170331#comment-17170331
 ] 

ASF GitHub Bot commented on GEODE-8382:
---

sabbeyPivotal commented on pull request #5416:
URL: https://github.com/apache/geode/pull/5416#issuecomment-668168119


   @smgoller @rhoughton-pivot @onichols-pivotal @dickcav 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Run Redis tests against Redis API for Geode
> ---
>
> Key: GEODE-8382
> URL: https://issues.apache.org/jira/browse/GEODE-8382
> Project: Geode
>  Issue Type: New Feature
>  Components: ci, redis
>Reporter: Sarah Abbey
>Priority: Major
>  Labels: pull-request-available
>
> We would like to run Redis's tests against Redis API for Geode.  Tests will 
> run a separate job in the PR and main pipelines.  It has been included in the 
> 'tests' jinja variables.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7846) Clear in Partitioned Region should have its own stats

2020-08-03 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170328#comment-17170328
 ] 

ASF GitHub Bot commented on GEODE-7846:
---

gesterzhou commented on a change in pull request #5391:
URL: https://github.com/apache/geode/pull/5391#discussion_r464581367



##
File path: 
geode-core/src/main/java/org/apache/geode/internal/cache/CachePerfStats.java
##
@@ -274,7 +278,14 @@
 "Current number of regions configured for reliablity that are missing 
required roles with Limited access";
 final String reliableRegionsMissingNoAccessDesc =
 "Current number of regions configured for reliablity that are missing 
required roles with No access";
-final String clearsDesc = "The total number of times a clear has been done 
on this cache.";
+final String regionClearsDesc =
+"The total number of times a clear has been done on this cache.";

Review comment:
   on this cache? or on this region?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clear in Partitioned Region should have its own stats
> -
>
> Key: GEODE-7846
> URL: https://issues.apache.org/jira/browse/GEODE-7846
> Project: Geode
>  Issue Type: Improvement
>  Components: core
>Reporter: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeCommons, GeodeOperationAPI, pull-request-available
>
> Clear operation in PR should have its own stats: 
> 1) clear operation executed. 
> 2) clear operation failed
> 3) clear messages sends to buckets



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7667) GFSH commands - uniform gfsh command to clear regions

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170317#comment-17170317
 ] 

ASF subversion and git services commented on GEODE-7667:


Commit 7177dae836a912286fe4f9629c511a7241c33bdf in geode's branch 
refs/heads/feature/GEODE-7665 from Nabarun Nag
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=7177dae ]

GEODE-7667: Fixing test to include PR clear help text.


> GFSH commands - uniform gfsh command to clear regions
> -
>
> Key: GEODE-7667
> URL: https://issues.apache.org/jira/browse/GEODE-7667
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Benjamin P Ross
>Priority: Major
>  Labels: GeodeCommons, docs
>  Time Spent: 5h
>  Remaining Estimate: 0h
>
> * Currently, the gfsh command to clear replicated region is called ‘remove 
> —region=/regionName’.
>  * Replace this command with ‘clear region —region=regionName’
>  * While executing this gfsh command on partitioned regions, this should call 
> the clear() Java API using the gfsh function execution machinery.
>  * Point to note is that this command should take into consideration of the 
> coordinator selection and how this command is distributed to the members
> Acceptance :
>  * There should be ‘clear region —region=/regionName’ gfsh command
>  * The gfsh command must be documented in the Geode User Guide
>  * DUnit tests to verify that command can be executed successfully on 
> PartitionedRegion
>  * Deprecate the remove command, as remove does not mean clear
>  * Unit tests with complete code coverage for the newly written code.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7670) Partitioned Region clear operations can occur during concurrent data operations

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170325#comment-17170325
 ] 

ASF subversion and git services commented on GEODE-7670:


Commit 45b36413bff34878d295544fe682341640207599 in geode's branch 
refs/heads/feature/GEODE-7665 from Juan José Ramos
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=45b3641 ]

GEODE-7670: PR Clear with Concurrent Ops DUnitTests (#4848)

Added distributed tests to verify that the clear operation on
Partitioned Regions works as expected when there are other
concurrent operations happening on the cache (put, putAll, get,
remove, removeAll, members added and members removed).

> Partitioned Region clear operations can occur during concurrent data 
> operations
> ---
>
> Key: GEODE-7670
> URL: https://issues.apache.org/jira/browse/GEODE-7670
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Juan Ramos
>Priority: Major
>  Labels: GeodeCommons, pull-request-available
>  Time Spent: 5.5h
>  Remaining Estimate: 0h
>
> Clear operations are successful when concurrent read/write operations occur. 
> Ensure there are test coverage for this use case and modify the code needed 
> to enable this.
> Acceptance :
>  * Passing DUnit tests where clear operations are successful on partitioned 
> region with 
>  * concurrent puts (writes) and clear op
>  * concurrent gets (reads) and clear op
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170323#comment-17170323
 ] 

ASF subversion and git services commented on GEODE-8334:


Commit 9a67231f5a107cf019af551f5a94d1ce49614d94 in geode's branch 
refs/heads/feature/GEODE-7665 from Xiaojian Zhou
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=9a67231 ]

GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365)


Co-authored-by: Xiaojian Zhou 
Co-authored-by: Anil Gingade 



> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7680) Partitioned region clear operations must be successful while interacting with rebalance

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170326#comment-17170326
 ] 

ASF subversion and git services commented on GEODE-7680:


Commit 0cb20cb322000661a466f9f63cb2c107ca1eb5d4 in geode's branch 
refs/heads/feature/GEODE-7665 from Donal Evans
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=0cb20cb ]

GEODE-7680: PR.clear must be successful when interacting with rebalance (#5095)

- Added DUnit tests to confirm that clear does not interfere with
rebalance or vice versa
- Test when member departs during clear/rebalance
- Test when member joins during clear/rebalance
- Fixed typo in PartitionedRegionClearWithExpirationDUnitTest
- Fixed typo in PartitionedRegion
- Call assignBucketsToPartitions() on leader colocated region during clear
instead of target region

Authored-by: Donal Evans 

> Partitioned region clear operations must be successful while interacting with 
> rebalance 
> 
>
> Key: GEODE-7680
> URL: https://issues.apache.org/jira/browse/GEODE-7680
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Donal Evans
>Priority: Major
>  Labels: GeodeCommons, caching-applications, 
> pull-request-available
> Fix For: 1.14.0
>
>
> Clear operations are successful and while rebalance operations are ongoing.
> Acceptance :
>  * DUnit tests validating the above behavior.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8361) Incorrect Bucket Count Warning Message Shown

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170324#comment-17170324
 ] 

ASF subversion and git services commented on GEODE-8361:


Commit d2a974201e23e0f58e90ca9acfb4b7c1f5b23cfe in geode's branch 
refs/heads/feature/GEODE-7665 from Donal Evans
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=d2a9742 ]

GEODE-8361: Use Set instead of List to track cleared buckets (#5379)

- Refactor PartitionRegionClear to use Set instead of List
- Some other changes to remove warnings/alerts from PartitionedRegionClear and 
PartitionedRegionClearMessage

Authored-by: Donal Evans 

> Incorrect Bucket Count Warning Message Shown
> 
>
> Key: GEODE-8361
> URL: https://issues.apache.org/jira/browse/GEODE-8361
> Project: Geode
>  Issue Type: Sub-task
>  Components: logging
>Reporter: Juan Ramos
>Assignee: Donal Evans
>Priority: Trivial
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> While analysing some failures related to GEODE-7670, I've noticed that 
> sometimes we report an incorrect bucket count within the warning message 
> logged when the clear didn't complete successfully that could confuse our 
> users.
> For this test the partition region always has 13 buckets so, as I user, I 
> would never expect to see a bucket count higher than 13 in my logs (no matter 
> how many redundant copies I have).
> ---
> Below are some examples:
> {noformat}
> [vm1] [warn 2020/07/15 11:56:17.739 GMT RMI TCP 
> Connection(5)-172.17.0.5 tid=0x5f] Unable to clear all the buckets from 
> the partitioned region PartitionedRegion, either data (buckets) moved or 
> member departed. expected to clear number of buckets: 13 actual cleared: 26
> [vm1] [warn 2020/07/15 11:57:48.403 GMT RMI TCP 
> Connection(6)-172.17.0.9 tid=0x10f] Unable to clear all the buckets from 
> the partitioned region PartitionedRegion, either data (buckets) moved or 
> member departed. expected to clear number of buckets: 13 actual cleared: 14
> [vm0] [warn 2020/07/15 12:07:36.227 GMT RMI TCP 
> Connection(32)-172.17.0.25 tid=0x1fe] Unable to clear all the buckets 
> from the partitioned region PartitionedRegion, either data (buckets) moved or 
> member departed. expected to clear number of buckets: 13 actual cleared: 19
> [vm0] [warn 2020/07/15 12:08:56.277 GMT RMI TCP 
> Connection(37)-172.17.0.24 tid=0x2a2] Unable to clear all the buckets 
> from the partitioned region PartitionedRegion, either data (buckets) moved or 
> member departed. expected to clear number of buckets: 13 actual cleared: 16
> {noformat}
> The full set of artefacts and results:
> {noformat}
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=  Test Results URI 
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-4848/test-results/repeatTest/1594816968/
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> Test report artifacts from this job are available at:
> http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-4848/test-artifacts/1594816968/stressnewtestfiles-geode-pr-4848.tgz
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170322#comment-17170322
 ] 

ASF subversion and git services commented on GEODE-8173:


Commit 862cad919fe6abf03d6bfa33900b7a2b7fc9ee30 in geode's branch 
refs/heads/feature/GEODE-7665 from agingade
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=862cad9 ]

GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208)

* GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class.
Co-authored-by: anilkumar gingade 

> Add test coverage for PartitionedRegionClear class
> --
>
> Key: GEODE-8173
> URL: https://issues.apache.org/jira/browse/GEODE-8173
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Anilkumar Gingade
>Priority: Major
>  Labels: GeodeOperationAPI
> Fix For: 1.14.0
>
>
> Add test coverage for PartitionedRegionClear class.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7669) Test coverage for Partitioned Region clear with Overflow enabled

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170320#comment-17170320
 ] 

ASF subversion and git services commented on GEODE-7669:


Commit ddffddc6467d6ba557c5b1c799657a30d1a9c525 in geode's branch 
refs/heads/feature/GEODE-7665 from Jianxia Chen
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=ddffddc ]

GEODE-7669 Test coverage for Partitioned Region clear with Overflow enabled 
(#5189)

Authored-by: Jianxia Chen 


> Test coverage for Partitioned Region clear with Overflow enabled
> 
>
> Key: GEODE-7669
> URL: https://issues.apache.org/jira/browse/GEODE-7669
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Jianxia Chen
>Priority: Major
>  Labels: GeodeCommons, GeodeOperationAPI
>
> Using TDD ensure that clear operations are successful when the partitioned 
> regions have overflow enabled.
> Make the code changes required to enable this.
>  
> Acceptance :
>  * Passing DUnit tests where clear operations are successful on partitioned 
> region with overflow enabled.
>  * Ensure that data has overflown when the clear operation is executed and in 
> the end everything is cleared.
>  * These tests should have redundancy of more than zero 
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.
> Note:
> analyze if these tests are needed for offheap?
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7676) All expiration tasks are cleared after a Partitioned Region is cleared

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170315#comment-17170315
 ] 

ASF subversion and git services commented on GEODE-7676:


Commit 0dcf0ef2b54ddf90e499fcbbee6426077790f07a in geode's branch 
refs/heads/feature/GEODE-7665 from Nabarun Nag
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=0dcf0ef ]

GEODE-7676: Conversion of duration to seconds.


> All expiration tasks are cleared after a Partitioned Region is cleared
> --
>
> Key: GEODE-7676
> URL: https://issues.apache.org/jira/browse/GEODE-7676
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Juan Ramos
>Priority: Major
>  Labels: GeodeCommons, feature/GEODE-7665
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> Clear operations are successful and all the expiration tasks are cleared in 
> the bucket level
> Acceptance :
>  * DUnit tests ensuring that clear operations are successful 
>  * Expiration tasks are cleared.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7678) Partitioned Region clear operations must invoke cache level listeners

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170318#comment-17170318
 ] 

ASF subversion and git services commented on GEODE-7678:


Commit 1ecd10ae09fdbd59de85b95b204c3eb2e920de0b in geode's branch 
refs/heads/feature/GEODE-7665 from agingade
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=1ecd10a ]

GEODE-7678 (2nd PR) - Support for cache-listener and client-notification for 
Partitioned Region Clear operation  (#5124)

* GEODE-7678: Add support for cache listener and client notification for PR 
clear

The changes are made to PR clear messaging and locking mechanism to preserve
cache-listener and client-events ordering during concurrent cache operation
while clear in progress.


> Partitioned Region clear operations must invoke cache level listeners
> -
>
> Key: GEODE-7678
> URL: https://issues.apache.org/jira/browse/GEODE-7678
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Anilkumar Gingade
>Priority: Major
>  Labels: GeodeCommons, GeodeOperationAPI
>
> Clear operations are successful and CacheListener.afterRegionClear(), 
> CacheWriter.beforeRegionClear() are invoked.
>  
> Acceptance :
>  * DUnit tests validating the above behavior.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170321#comment-17170321
 ] 

ASF subversion and git services commented on GEODE-8173:


Commit 862cad919fe6abf03d6bfa33900b7a2b7fc9ee30 in geode's branch 
refs/heads/feature/GEODE-7665 from agingade
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=862cad9 ]

GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208)

* GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class.
Co-authored-by: anilkumar gingade 

> Add test coverage for PartitionedRegionClear class
> --
>
> Key: GEODE-8173
> URL: https://issues.apache.org/jira/browse/GEODE-8173
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Anilkumar Gingade
>Priority: Major
>  Labels: GeodeOperationAPI
> Fix For: 1.14.0
>
>
> Add test coverage for PartitionedRegionClear class.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7894) CustomSSLProviderDistributedTest hostNameIsValidatedWhenUsingDefaultContext fails with suspect uncaught DistributedSystemDisconnectedException

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170316#comment-17170316
 ] 

ASF subversion and git services commented on GEODE-7894:


Commit 16814730977822a903521e2bc89e19206c6d9698 in geode's branch 
refs/heads/feature/GEODE-7665 from Nabarun Nag
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=1681473 ]

GEODE-7894: Moving expiry tasks to AbstractRegion.


> CustomSSLProviderDistributedTest hostNameIsValidatedWhenUsingDefaultContext 
> fails with suspect uncaught DistributedSystemDisconnectedException
> --
>
> Key: GEODE-7894
> URL: https://issues.apache.org/jira/browse/GEODE-7894
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Darrel Schneider
>Assignee: Dan Smith
>Priority: Minor
>  Labels: flakey
> Fix For: 1.13.0
>
>
> See: 
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/1663
> {noformat}
> org.apache.geode.cache.client.internal.CustomSSLProviderDistributedTest > 
> hostNameIsValidatedWhenUsingDefaultContext FAILED
> java.lang.AssertionError: Suspicious strings were written to the log 
> during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in log4j at line 1654
> [fatal 2020/03/19 17:26:01.806 GMT  tid=215] Uncaught 
> exception in thread Thread[unused p2p reader,5,RMI Runtime]
> org.apache.geode.distributed.DistributedSystemDisconnectedException: 
> Distribution manager on 172.17.0.15(server-1:113):41001 started at Thu 
> Mar 19 17:25:57 GMT 2020: Message distribution has terminated
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager$Stopper.generateCancelledException(ClusterDistributionManager.java:2873)
>   at 
> org.apache.geode.internal.tcp.TCPConduit$Stopper.generateCancelledException(TCPConduit.java:1004)
>   at 
> org.apache.geode.CancelCriterion.checkCancelInProgress(CancelCriterion.java:83)
>   at 
> org.apache.geode.internal.tcp.Connection.readMessages(Connection.java:1666)
>   at org.apache.geode.internal.tcp.Connection.run(Connection.java:1446)
>   at java.lang.Thread.run(Thread.java:748)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7678) Partitioned Region clear operations must invoke cache level listeners

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170319#comment-17170319
 ] 

ASF subversion and git services commented on GEODE-7678:


Commit 1ecd10ae09fdbd59de85b95b204c3eb2e920de0b in geode's branch 
refs/heads/feature/GEODE-7665 from agingade
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=1ecd10a ]

GEODE-7678 (2nd PR) - Support for cache-listener and client-notification for 
Partitioned Region Clear operation  (#5124)

* GEODE-7678: Add support for cache listener and client notification for PR 
clear

The changes are made to PR clear messaging and locking mechanism to preserve
cache-listener and client-events ordering during concurrent cache operation
while clear in progress.


> Partitioned Region clear operations must invoke cache level listeners
> -
>
> Key: GEODE-7678
> URL: https://issues.apache.org/jira/browse/GEODE-7678
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Anilkumar Gingade
>Priority: Major
>  Labels: GeodeCommons, GeodeOperationAPI
>
> Clear operations are successful and CacheListener.afterRegionClear(), 
> CacheWriter.beforeRegionClear() are invoked.
>  
> Acceptance :
>  * DUnit tests validating the above behavior.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170310#comment-17170310
 ] 

ASF subversion and git services commented on GEODE-8173:


Commit 862cad919fe6abf03d6bfa33900b7a2b7fc9ee30 in geode's branch 
refs/heads/feature/GEODE-7665 from agingade
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=862cad9 ]

GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208)

* GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class.
Co-authored-by: anilkumar gingade 

> Add test coverage for PartitionedRegionClear class
> --
>
> Key: GEODE-8173
> URL: https://issues.apache.org/jira/browse/GEODE-8173
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Anilkumar Gingade
>Priority: Major
>  Labels: GeodeOperationAPI
> Fix For: 1.14.0
>
>
> Add test coverage for PartitionedRegionClear class.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7894) CustomSSLProviderDistributedTest hostNameIsValidatedWhenUsingDefaultContext fails with suspect uncaught DistributedSystemDisconnectedException

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170304#comment-17170304
 ] 

ASF subversion and git services commented on GEODE-7894:


Commit 16814730977822a903521e2bc89e19206c6d9698 in geode's branch 
refs/heads/feature/GEODE-7665 from Nabarun Nag
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=1681473 ]

GEODE-7894: Moving expiry tasks to AbstractRegion.


> CustomSSLProviderDistributedTest hostNameIsValidatedWhenUsingDefaultContext 
> fails with suspect uncaught DistributedSystemDisconnectedException
> --
>
> Key: GEODE-7894
> URL: https://issues.apache.org/jira/browse/GEODE-7894
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Darrel Schneider
>Assignee: Dan Smith
>Priority: Minor
>  Labels: flakey
> Fix For: 1.13.0
>
>
> See: 
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/1663
> {noformat}
> org.apache.geode.cache.client.internal.CustomSSLProviderDistributedTest > 
> hostNameIsValidatedWhenUsingDefaultContext FAILED
> java.lang.AssertionError: Suspicious strings were written to the log 
> during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in log4j at line 1654
> [fatal 2020/03/19 17:26:01.806 GMT  tid=215] Uncaught 
> exception in thread Thread[unused p2p reader,5,RMI Runtime]
> org.apache.geode.distributed.DistributedSystemDisconnectedException: 
> Distribution manager on 172.17.0.15(server-1:113):41001 started at Thu 
> Mar 19 17:25:57 GMT 2020: Message distribution has terminated
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager$Stopper.generateCancelledException(ClusterDistributionManager.java:2873)
>   at 
> org.apache.geode.internal.tcp.TCPConduit$Stopper.generateCancelledException(TCPConduit.java:1004)
>   at 
> org.apache.geode.CancelCriterion.checkCancelInProgress(CancelCriterion.java:83)
>   at 
> org.apache.geode.internal.tcp.Connection.readMessages(Connection.java:1666)
>   at org.apache.geode.internal.tcp.Connection.run(Connection.java:1446)
>   at java.lang.Thread.run(Thread.java:748)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7676) All expiration tasks are cleared after a Partitioned Region is cleared

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170303#comment-17170303
 ] 

ASF subversion and git services commented on GEODE-7676:


Commit 0dcf0ef2b54ddf90e499fcbbee6426077790f07a in geode's branch 
refs/heads/feature/GEODE-7665 from Nabarun Nag
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=0dcf0ef ]

GEODE-7676: Conversion of duration to seconds.


> All expiration tasks are cleared after a Partitioned Region is cleared
> --
>
> Key: GEODE-7676
> URL: https://issues.apache.org/jira/browse/GEODE-7676
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Juan Ramos
>Priority: Major
>  Labels: GeodeCommons, feature/GEODE-7665
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> Clear operations are successful and all the expiration tasks are cleared in 
> the bucket level
> Acceptance :
>  * DUnit tests ensuring that clear operations are successful 
>  * Expiration tasks are cleared.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7678) Partitioned Region clear operations must invoke cache level listeners

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170306#comment-17170306
 ] 

ASF subversion and git services commented on GEODE-7678:


Commit 1ecd10ae09fdbd59de85b95b204c3eb2e920de0b in geode's branch 
refs/heads/feature/GEODE-7665 from agingade
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=1ecd10a ]

GEODE-7678 (2nd PR) - Support for cache-listener and client-notification for 
Partitioned Region Clear operation  (#5124)

* GEODE-7678: Add support for cache listener and client notification for PR 
clear

The changes are made to PR clear messaging and locking mechanism to preserve
cache-listener and client-events ordering during concurrent cache operation
while clear in progress.


> Partitioned Region clear operations must invoke cache level listeners
> -
>
> Key: GEODE-7678
> URL: https://issues.apache.org/jira/browse/GEODE-7678
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Anilkumar Gingade
>Priority: Major
>  Labels: GeodeCommons, GeodeOperationAPI
>
> Clear operations are successful and CacheListener.afterRegionClear(), 
> CacheWriter.beforeRegionClear() are invoked.
>  
> Acceptance :
>  * DUnit tests validating the above behavior.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7680) Partitioned region clear operations must be successful while interacting with rebalance

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170314#comment-17170314
 ] 

ASF subversion and git services commented on GEODE-7680:


Commit 0cb20cb322000661a466f9f63cb2c107ca1eb5d4 in geode's branch 
refs/heads/feature/GEODE-7665 from Donal Evans
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=0cb20cb ]

GEODE-7680: PR.clear must be successful when interacting with rebalance (#5095)

- Added DUnit tests to confirm that clear does not interfere with
rebalance or vice versa
- Test when member departs during clear/rebalance
- Test when member joins during clear/rebalance
- Fixed typo in PartitionedRegionClearWithExpirationDUnitTest
- Fixed typo in PartitionedRegion
- Call assignBucketsToPartitions() on leader colocated region during clear
instead of target region

Authored-by: Donal Evans 

> Partitioned region clear operations must be successful while interacting with 
> rebalance 
> 
>
> Key: GEODE-7680
> URL: https://issues.apache.org/jira/browse/GEODE-7680
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Donal Evans
>Priority: Major
>  Labels: GeodeCommons, caching-applications, 
> pull-request-available
> Fix For: 1.14.0
>
>
> Clear operations are successful and while rebalance operations are ongoing.
> Acceptance :
>  * DUnit tests validating the above behavior.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8361) Incorrect Bucket Count Warning Message Shown

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170312#comment-17170312
 ] 

ASF subversion and git services commented on GEODE-8361:


Commit d2a974201e23e0f58e90ca9acfb4b7c1f5b23cfe in geode's branch 
refs/heads/feature/GEODE-7665 from Donal Evans
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=d2a9742 ]

GEODE-8361: Use Set instead of List to track cleared buckets (#5379)

- Refactor PartitionRegionClear to use Set instead of List
- Some other changes to remove warnings/alerts from PartitionedRegionClear and 
PartitionedRegionClearMessage

Authored-by: Donal Evans 

> Incorrect Bucket Count Warning Message Shown
> 
>
> Key: GEODE-8361
> URL: https://issues.apache.org/jira/browse/GEODE-8361
> Project: Geode
>  Issue Type: Sub-task
>  Components: logging
>Reporter: Juan Ramos
>Assignee: Donal Evans
>Priority: Trivial
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> While analysing some failures related to GEODE-7670, I've noticed that 
> sometimes we report an incorrect bucket count within the warning message 
> logged when the clear didn't complete successfully that could confuse our 
> users.
> For this test the partition region always has 13 buckets so, as I user, I 
> would never expect to see a bucket count higher than 13 in my logs (no matter 
> how many redundant copies I have).
> ---
> Below are some examples:
> {noformat}
> [vm1] [warn 2020/07/15 11:56:17.739 GMT RMI TCP 
> Connection(5)-172.17.0.5 tid=0x5f] Unable to clear all the buckets from 
> the partitioned region PartitionedRegion, either data (buckets) moved or 
> member departed. expected to clear number of buckets: 13 actual cleared: 26
> [vm1] [warn 2020/07/15 11:57:48.403 GMT RMI TCP 
> Connection(6)-172.17.0.9 tid=0x10f] Unable to clear all the buckets from 
> the partitioned region PartitionedRegion, either data (buckets) moved or 
> member departed. expected to clear number of buckets: 13 actual cleared: 14
> [vm0] [warn 2020/07/15 12:07:36.227 GMT RMI TCP 
> Connection(32)-172.17.0.25 tid=0x1fe] Unable to clear all the buckets 
> from the partitioned region PartitionedRegion, either data (buckets) moved or 
> member departed. expected to clear number of buckets: 13 actual cleared: 19
> [vm0] [warn 2020/07/15 12:08:56.277 GMT RMI TCP 
> Connection(37)-172.17.0.24 tid=0x2a2] Unable to clear all the buckets 
> from the partitioned region PartitionedRegion, either data (buckets) moved or 
> member departed. expected to clear number of buckets: 13 actual cleared: 16
> {noformat}
> The full set of artefacts and results:
> {noformat}
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=  Test Results URI 
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-4848/test-results/repeatTest/1594816968/
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> Test report artifacts from this job are available at:
> http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-4848/test-artifacts/1594816968/stressnewtestfiles-geode-pr-4848.tgz
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170311#comment-17170311
 ] 

ASF subversion and git services commented on GEODE-8334:


Commit 9a67231f5a107cf019af551f5a94d1ce49614d94 in geode's branch 
refs/heads/feature/GEODE-7665 from Xiaojian Zhou
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=9a67231 ]

GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365)


Co-authored-by: Xiaojian Zhou 
Co-authored-by: Anil Gingade 



> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7678) Partitioned Region clear operations must invoke cache level listeners

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170307#comment-17170307
 ] 

ASF subversion and git services commented on GEODE-7678:


Commit 1ecd10ae09fdbd59de85b95b204c3eb2e920de0b in geode's branch 
refs/heads/feature/GEODE-7665 from agingade
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=1ecd10a ]

GEODE-7678 (2nd PR) - Support for cache-listener and client-notification for 
Partitioned Region Clear operation  (#5124)

* GEODE-7678: Add support for cache listener and client notification for PR 
clear

The changes are made to PR clear messaging and locking mechanism to preserve
cache-listener and client-events ordering during concurrent cache operation
while clear in progress.


> Partitioned Region clear operations must invoke cache level listeners
> -
>
> Key: GEODE-7678
> URL: https://issues.apache.org/jira/browse/GEODE-7678
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Anilkumar Gingade
>Priority: Major
>  Labels: GeodeCommons, GeodeOperationAPI
>
> Clear operations are successful and CacheListener.afterRegionClear(), 
> CacheWriter.beforeRegionClear() are invoked.
>  
> Acceptance :
>  * DUnit tests validating the above behavior.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7670) Partitioned Region clear operations can occur during concurrent data operations

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170313#comment-17170313
 ] 

ASF subversion and git services commented on GEODE-7670:


Commit 45b36413bff34878d295544fe682341640207599 in geode's branch 
refs/heads/feature/GEODE-7665 from Juan José Ramos
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=45b3641 ]

GEODE-7670: PR Clear with Concurrent Ops DUnitTests (#4848)

Added distributed tests to verify that the clear operation on
Partitioned Regions works as expected when there are other
concurrent operations happening on the cache (put, putAll, get,
remove, removeAll, members added and members removed).

> Partitioned Region clear operations can occur during concurrent data 
> operations
> ---
>
> Key: GEODE-7670
> URL: https://issues.apache.org/jira/browse/GEODE-7670
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Juan Ramos
>Priority: Major
>  Labels: GeodeCommons, pull-request-available
>  Time Spent: 5.5h
>  Remaining Estimate: 0h
>
> Clear operations are successful when concurrent read/write operations occur. 
> Ensure there are test coverage for this use case and modify the code needed 
> to enable this.
> Acceptance :
>  * Passing DUnit tests where clear operations are successful on partitioned 
> region with 
>  * concurrent puts (writes) and clear op
>  * concurrent gets (reads) and clear op
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170309#comment-17170309
 ] 

ASF subversion and git services commented on GEODE-8173:


Commit 862cad919fe6abf03d6bfa33900b7a2b7fc9ee30 in geode's branch 
refs/heads/feature/GEODE-7665 from agingade
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=862cad9 ]

GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208)

* GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class.
Co-authored-by: anilkumar gingade 

> Add test coverage for PartitionedRegionClear class
> --
>
> Key: GEODE-8173
> URL: https://issues.apache.org/jira/browse/GEODE-8173
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Anilkumar Gingade
>Priority: Major
>  Labels: GeodeOperationAPI
> Fix For: 1.14.0
>
>
> Add test coverage for PartitionedRegionClear class.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7669) Test coverage for Partitioned Region clear with Overflow enabled

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170308#comment-17170308
 ] 

ASF subversion and git services commented on GEODE-7669:


Commit ddffddc6467d6ba557c5b1c799657a30d1a9c525 in geode's branch 
refs/heads/feature/GEODE-7665 from Jianxia Chen
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=ddffddc ]

GEODE-7669 Test coverage for Partitioned Region clear with Overflow enabled 
(#5189)

Authored-by: Jianxia Chen 


> Test coverage for Partitioned Region clear with Overflow enabled
> 
>
> Key: GEODE-7669
> URL: https://issues.apache.org/jira/browse/GEODE-7669
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Jianxia Chen
>Priority: Major
>  Labels: GeodeCommons, GeodeOperationAPI
>
> Using TDD ensure that clear operations are successful when the partitioned 
> regions have overflow enabled.
> Make the code changes required to enable this.
>  
> Acceptance :
>  * Passing DUnit tests where clear operations are successful on partitioned 
> region with overflow enabled.
>  * Ensure that data has overflown when the clear operation is executed and in 
> the end everything is cleared.
>  * These tests should have redundancy of more than zero 
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.
> Note:
> analyze if these tests are needed for offheap?
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7667) GFSH commands - uniform gfsh command to clear regions

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170305#comment-17170305
 ] 

ASF subversion and git services commented on GEODE-7667:


Commit 7177dae836a912286fe4f9629c511a7241c33bdf in geode's branch 
refs/heads/feature/GEODE-7665 from Nabarun Nag
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=7177dae ]

GEODE-7667: Fixing test to include PR clear help text.


> GFSH commands - uniform gfsh command to clear regions
> -
>
> Key: GEODE-7667
> URL: https://issues.apache.org/jira/browse/GEODE-7667
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Benjamin P Ross
>Priority: Major
>  Labels: GeodeCommons, docs
>  Time Spent: 5h
>  Remaining Estimate: 0h
>
> * Currently, the gfsh command to clear replicated region is called ‘remove 
> —region=/regionName’.
>  * Replace this command with ‘clear region —region=regionName’
>  * While executing this gfsh command on partitioned regions, this should call 
> the clear() Java API using the gfsh function execution machinery.
>  * Point to note is that this command should take into consideration of the 
> coordinator selection and how this command is distributed to the members
> Acceptance :
>  * There should be ‘clear region —region=/regionName’ gfsh command
>  * The gfsh command must be documented in the Geode User Guide
>  * DUnit tests to verify that command can be executed successfully on 
> PartitionedRegion
>  * Deprecate the remove command, as remove does not mean clear
>  * Unit tests with complete code coverage for the newly written code.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7670) Partitioned Region clear operations can occur during concurrent data operations

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170301#comment-17170301
 ] 

ASF subversion and git services commented on GEODE-7670:


Commit 45b36413bff34878d295544fe682341640207599 in geode's branch 
refs/heads/feature/GEODE-7665 from Juan José Ramos
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=45b3641 ]

GEODE-7670: PR Clear with Concurrent Ops DUnitTests (#4848)

Added distributed tests to verify that the clear operation on
Partitioned Regions works as expected when there are other
concurrent operations happening on the cache (put, putAll, get,
remove, removeAll, members added and members removed).

> Partitioned Region clear operations can occur during concurrent data 
> operations
> ---
>
> Key: GEODE-7670
> URL: https://issues.apache.org/jira/browse/GEODE-7670
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Juan Ramos
>Priority: Major
>  Labels: GeodeCommons, pull-request-available
>  Time Spent: 5.5h
>  Remaining Estimate: 0h
>
> Clear operations are successful when concurrent read/write operations occur. 
> Ensure there are test coverage for this use case and modify the code needed 
> to enable this.
> Acceptance :
>  * Passing DUnit tests where clear operations are successful on partitioned 
> region with 
>  * concurrent puts (writes) and clear op
>  * concurrent gets (reads) and clear op
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7678) Partitioned Region clear operations must invoke cache level listeners

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170295#comment-17170295
 ] 

ASF subversion and git services commented on GEODE-7678:


Commit 1ecd10ae09fdbd59de85b95b204c3eb2e920de0b in geode's branch 
refs/heads/feature/GEODE-7665 from agingade
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=1ecd10a ]

GEODE-7678 (2nd PR) - Support for cache-listener and client-notification for 
Partitioned Region Clear operation  (#5124)

* GEODE-7678: Add support for cache listener and client notification for PR 
clear

The changes are made to PR clear messaging and locking mechanism to preserve
cache-listener and client-events ordering during concurrent cache operation
while clear in progress.


> Partitioned Region clear operations must invoke cache level listeners
> -
>
> Key: GEODE-7678
> URL: https://issues.apache.org/jira/browse/GEODE-7678
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Anilkumar Gingade
>Priority: Major
>  Labels: GeodeCommons, GeodeOperationAPI
>
> Clear operations are successful and CacheListener.afterRegionClear(), 
> CacheWriter.beforeRegionClear() are invoked.
>  
> Acceptance :
>  * DUnit tests validating the above behavior.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7669) Test coverage for Partitioned Region clear with Overflow enabled

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170296#comment-17170296
 ] 

ASF subversion and git services commented on GEODE-7669:


Commit ddffddc6467d6ba557c5b1c799657a30d1a9c525 in geode's branch 
refs/heads/feature/GEODE-7665 from Jianxia Chen
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=ddffddc ]

GEODE-7669 Test coverage for Partitioned Region clear with Overflow enabled 
(#5189)

Authored-by: Jianxia Chen 


> Test coverage for Partitioned Region clear with Overflow enabled
> 
>
> Key: GEODE-7669
> URL: https://issues.apache.org/jira/browse/GEODE-7669
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Jianxia Chen
>Priority: Major
>  Labels: GeodeCommons, GeodeOperationAPI
>
> Using TDD ensure that clear operations are successful when the partitioned 
> regions have overflow enabled.
> Make the code changes required to enable this.
>  
> Acceptance :
>  * Passing DUnit tests where clear operations are successful on partitioned 
> region with overflow enabled.
>  * Ensure that data has overflown when the clear operation is executed and in 
> the end everything is cleared.
>  * These tests should have redundancy of more than zero 
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.
> Note:
> analyze if these tests are needed for offheap?
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8361) Incorrect Bucket Count Warning Message Shown

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170300#comment-17170300
 ] 

ASF subversion and git services commented on GEODE-8361:


Commit d2a974201e23e0f58e90ca9acfb4b7c1f5b23cfe in geode's branch 
refs/heads/feature/GEODE-7665 from Donal Evans
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=d2a9742 ]

GEODE-8361: Use Set instead of List to track cleared buckets (#5379)

- Refactor PartitionRegionClear to use Set instead of List
- Some other changes to remove warnings/alerts from PartitionedRegionClear and 
PartitionedRegionClearMessage

Authored-by: Donal Evans 

> Incorrect Bucket Count Warning Message Shown
> 
>
> Key: GEODE-8361
> URL: https://issues.apache.org/jira/browse/GEODE-8361
> Project: Geode
>  Issue Type: Sub-task
>  Components: logging
>Reporter: Juan Ramos
>Assignee: Donal Evans
>Priority: Trivial
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> While analysing some failures related to GEODE-7670, I've noticed that 
> sometimes we report an incorrect bucket count within the warning message 
> logged when the clear didn't complete successfully that could confuse our 
> users.
> For this test the partition region always has 13 buckets so, as I user, I 
> would never expect to see a bucket count higher than 13 in my logs (no matter 
> how many redundant copies I have).
> ---
> Below are some examples:
> {noformat}
> [vm1] [warn 2020/07/15 11:56:17.739 GMT RMI TCP 
> Connection(5)-172.17.0.5 tid=0x5f] Unable to clear all the buckets from 
> the partitioned region PartitionedRegion, either data (buckets) moved or 
> member departed. expected to clear number of buckets: 13 actual cleared: 26
> [vm1] [warn 2020/07/15 11:57:48.403 GMT RMI TCP 
> Connection(6)-172.17.0.9 tid=0x10f] Unable to clear all the buckets from 
> the partitioned region PartitionedRegion, either data (buckets) moved or 
> member departed. expected to clear number of buckets: 13 actual cleared: 14
> [vm0] [warn 2020/07/15 12:07:36.227 GMT RMI TCP 
> Connection(32)-172.17.0.25 tid=0x1fe] Unable to clear all the buckets 
> from the partitioned region PartitionedRegion, either data (buckets) moved or 
> member departed. expected to clear number of buckets: 13 actual cleared: 19
> [vm0] [warn 2020/07/15 12:08:56.277 GMT RMI TCP 
> Connection(37)-172.17.0.24 tid=0x2a2] Unable to clear all the buckets 
> from the partitioned region PartitionedRegion, either data (buckets) moved or 
> member departed. expected to clear number of buckets: 13 actual cleared: 16
> {noformat}
> The full set of artefacts and results:
> {noformat}
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=  Test Results URI 
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-4848/test-results/repeatTest/1594816968/
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> Test report artifacts from this job are available at:
> http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-4848/test-artifacts/1594816968/stressnewtestfiles-geode-pr-4848.tgz
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7678) Partitioned Region clear operations must invoke cache level listeners

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170294#comment-17170294
 ] 

ASF subversion and git services commented on GEODE-7678:


Commit 1ecd10ae09fdbd59de85b95b204c3eb2e920de0b in geode's branch 
refs/heads/feature/GEODE-7665 from agingade
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=1ecd10a ]

GEODE-7678 (2nd PR) - Support for cache-listener and client-notification for 
Partitioned Region Clear operation  (#5124)

* GEODE-7678: Add support for cache listener and client notification for PR 
clear

The changes are made to PR clear messaging and locking mechanism to preserve
cache-listener and client-events ordering during concurrent cache operation
while clear in progress.


> Partitioned Region clear operations must invoke cache level listeners
> -
>
> Key: GEODE-7678
> URL: https://issues.apache.org/jira/browse/GEODE-7678
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Anilkumar Gingade
>Priority: Major
>  Labels: GeodeCommons, GeodeOperationAPI
>
> Clear operations are successful and CacheListener.afterRegionClear(), 
> CacheWriter.beforeRegionClear() are invoked.
>  
> Acceptance :
>  * DUnit tests validating the above behavior.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170298#comment-17170298
 ] 

ASF subversion and git services commented on GEODE-8173:


Commit 862cad919fe6abf03d6bfa33900b7a2b7fc9ee30 in geode's branch 
refs/heads/feature/GEODE-7665 from agingade
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=862cad9 ]

GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208)

* GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class.
Co-authored-by: anilkumar gingade 

> Add test coverage for PartitionedRegionClear class
> --
>
> Key: GEODE-8173
> URL: https://issues.apache.org/jira/browse/GEODE-8173
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Anilkumar Gingade
>Priority: Major
>  Labels: GeodeOperationAPI
> Fix For: 1.14.0
>
>
> Add test coverage for PartitionedRegionClear class.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7676) All expiration tasks are cleared after a Partitioned Region is cleared

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170291#comment-17170291
 ] 

ASF subversion and git services commented on GEODE-7676:


Commit 0dcf0ef2b54ddf90e499fcbbee6426077790f07a in geode's branch 
refs/heads/feature/GEODE-7665 from Nabarun Nag
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=0dcf0ef ]

GEODE-7676: Conversion of duration to seconds.


> All expiration tasks are cleared after a Partitioned Region is cleared
> --
>
> Key: GEODE-7676
> URL: https://issues.apache.org/jira/browse/GEODE-7676
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Juan Ramos
>Priority: Major
>  Labels: GeodeCommons, feature/GEODE-7665
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> Clear operations are successful and all the expiration tasks are cleared in 
> the bucket level
> Acceptance :
>  * DUnit tests ensuring that clear operations are successful 
>  * Expiration tasks are cleared.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170297#comment-17170297
 ] 

ASF subversion and git services commented on GEODE-8173:


Commit 862cad919fe6abf03d6bfa33900b7a2b7fc9ee30 in geode's branch 
refs/heads/feature/GEODE-7665 from agingade
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=862cad9 ]

GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208)

* GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class.
Co-authored-by: anilkumar gingade 

> Add test coverage for PartitionedRegionClear class
> --
>
> Key: GEODE-8173
> URL: https://issues.apache.org/jira/browse/GEODE-8173
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Anilkumar Gingade
>Priority: Major
>  Labels: GeodeOperationAPI
> Fix For: 1.14.0
>
>
> Add test coverage for PartitionedRegionClear class.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7667) GFSH commands - uniform gfsh command to clear regions

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170293#comment-17170293
 ] 

ASF subversion and git services commented on GEODE-7667:


Commit 7177dae836a912286fe4f9629c511a7241c33bdf in geode's branch 
refs/heads/feature/GEODE-7665 from Nabarun Nag
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=7177dae ]

GEODE-7667: Fixing test to include PR clear help text.


> GFSH commands - uniform gfsh command to clear regions
> -
>
> Key: GEODE-7667
> URL: https://issues.apache.org/jira/browse/GEODE-7667
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Benjamin P Ross
>Priority: Major
>  Labels: GeodeCommons, docs
>  Time Spent: 5h
>  Remaining Estimate: 0h
>
> * Currently, the gfsh command to clear replicated region is called ‘remove 
> —region=/regionName’.
>  * Replace this command with ‘clear region —region=regionName’
>  * While executing this gfsh command on partitioned regions, this should call 
> the clear() Java API using the gfsh function execution machinery.
>  * Point to note is that this command should take into consideration of the 
> coordinator selection and how this command is distributed to the members
> Acceptance :
>  * There should be ‘clear region —region=/regionName’ gfsh command
>  * The gfsh command must be documented in the Geode User Guide
>  * DUnit tests to verify that command can be executed successfully on 
> PartitionedRegion
>  * Deprecate the remove command, as remove does not mean clear
>  * Unit tests with complete code coverage for the newly written code.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7680) Partitioned region clear operations must be successful while interacting with rebalance

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170302#comment-17170302
 ] 

ASF subversion and git services commented on GEODE-7680:


Commit 0cb20cb322000661a466f9f63cb2c107ca1eb5d4 in geode's branch 
refs/heads/feature/GEODE-7665 from Donal Evans
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=0cb20cb ]

GEODE-7680: PR.clear must be successful when interacting with rebalance (#5095)

- Added DUnit tests to confirm that clear does not interfere with
rebalance or vice versa
- Test when member departs during clear/rebalance
- Test when member joins during clear/rebalance
- Fixed typo in PartitionedRegionClearWithExpirationDUnitTest
- Fixed typo in PartitionedRegion
- Call assignBucketsToPartitions() on leader colocated region during clear
instead of target region

Authored-by: Donal Evans 

> Partitioned region clear operations must be successful while interacting with 
> rebalance 
> 
>
> Key: GEODE-7680
> URL: https://issues.apache.org/jira/browse/GEODE-7680
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Donal Evans
>Priority: Major
>  Labels: GeodeCommons, caching-applications, 
> pull-request-available
> Fix For: 1.14.0
>
>
> Clear operations are successful and while rebalance operations are ongoing.
> Acceptance :
>  * DUnit tests validating the above behavior.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170299#comment-17170299
 ] 

ASF subversion and git services commented on GEODE-8334:


Commit 9a67231f5a107cf019af551f5a94d1ce49614d94 in geode's branch 
refs/heads/feature/GEODE-7665 from Xiaojian Zhou
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=9a67231 ]

GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365)


Co-authored-by: Xiaojian Zhou 
Co-authored-by: Anil Gingade 



> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7894) CustomSSLProviderDistributedTest hostNameIsValidatedWhenUsingDefaultContext fails with suspect uncaught DistributedSystemDisconnectedException

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170292#comment-17170292
 ] 

ASF subversion and git services commented on GEODE-7894:


Commit 16814730977822a903521e2bc89e19206c6d9698 in geode's branch 
refs/heads/feature/GEODE-7665 from Nabarun Nag
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=1681473 ]

GEODE-7894: Moving expiry tasks to AbstractRegion.


> CustomSSLProviderDistributedTest hostNameIsValidatedWhenUsingDefaultContext 
> fails with suspect uncaught DistributedSystemDisconnectedException
> --
>
> Key: GEODE-7894
> URL: https://issues.apache.org/jira/browse/GEODE-7894
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Darrel Schneider
>Assignee: Dan Smith
>Priority: Minor
>  Labels: flakey
> Fix For: 1.13.0
>
>
> See: 
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/1663
> {noformat}
> org.apache.geode.cache.client.internal.CustomSSLProviderDistributedTest > 
> hostNameIsValidatedWhenUsingDefaultContext FAILED
> java.lang.AssertionError: Suspicious strings were written to the log 
> during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in log4j at line 1654
> [fatal 2020/03/19 17:26:01.806 GMT  tid=215] Uncaught 
> exception in thread Thread[unused p2p reader,5,RMI Runtime]
> org.apache.geode.distributed.DistributedSystemDisconnectedException: 
> Distribution manager on 172.17.0.15(server-1:113):41001 started at Thu 
> Mar 19 17:25:57 GMT 2020: Message distribution has terminated
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager$Stopper.generateCancelledException(ClusterDistributionManager.java:2873)
>   at 
> org.apache.geode.internal.tcp.TCPConduit$Stopper.generateCancelledException(TCPConduit.java:1004)
>   at 
> org.apache.geode.CancelCriterion.checkCancelInProgress(CancelCriterion.java:83)
>   at 
> org.apache.geode.internal.tcp.Connection.readMessages(Connection.java:1666)
>   at org.apache.geode.internal.tcp.Connection.run(Connection.java:1446)
>   at java.lang.Thread.run(Thread.java:748)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7670) Partitioned Region clear operations can occur during concurrent data operations

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170288#comment-17170288
 ] 

ASF subversion and git services commented on GEODE-7670:


Commit 45b36413bff34878d295544fe682341640207599 in geode's branch 
refs/heads/feature/GEODE-7665 from Juan José Ramos
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=45b3641 ]

GEODE-7670: PR Clear with Concurrent Ops DUnitTests (#4848)

Added distributed tests to verify that the clear operation on
Partitioned Regions works as expected when there are other
concurrent operations happening on the cache (put, putAll, get,
remove, removeAll, members added and members removed).

> Partitioned Region clear operations can occur during concurrent data 
> operations
> ---
>
> Key: GEODE-7670
> URL: https://issues.apache.org/jira/browse/GEODE-7670
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Juan Ramos
>Priority: Major
>  Labels: GeodeCommons, pull-request-available
>  Time Spent: 5.5h
>  Remaining Estimate: 0h
>
> Clear operations are successful when concurrent read/write operations occur. 
> Ensure there are test coverage for this use case and modify the code needed 
> to enable this.
> Acceptance :
>  * Passing DUnit tests where clear operations are successful on partitioned 
> region with 
>  * concurrent puts (writes) and clear op
>  * concurrent gets (reads) and clear op
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170286#comment-17170286
 ] 

ASF subversion and git services commented on GEODE-8334:


Commit 9a67231f5a107cf019af551f5a94d1ce49614d94 in geode's branch 
refs/heads/feature/GEODE-7665 from Xiaojian Zhou
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=9a67231 ]

GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365)


Co-authored-by: Xiaojian Zhou 
Co-authored-by: Anil Gingade 



> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170284#comment-17170284
 ] 

ASF subversion and git services commented on GEODE-8173:


Commit 862cad919fe6abf03d6bfa33900b7a2b7fc9ee30 in geode's branch 
refs/heads/feature/GEODE-7665 from agingade
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=862cad9 ]

GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208)

* GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class.
Co-authored-by: anilkumar gingade 

> Add test coverage for PartitionedRegionClear class
> --
>
> Key: GEODE-8173
> URL: https://issues.apache.org/jira/browse/GEODE-8173
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Anilkumar Gingade
>Priority: Major
>  Labels: GeodeOperationAPI
> Fix For: 1.14.0
>
>
> Add test coverage for PartitionedRegionClear class.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7667) GFSH commands - uniform gfsh command to clear regions

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170280#comment-17170280
 ] 

ASF subversion and git services commented on GEODE-7667:


Commit 7177dae836a912286fe4f9629c511a7241c33bdf in geode's branch 
refs/heads/feature/GEODE-7665 from Nabarun Nag
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=7177dae ]

GEODE-7667: Fixing test to include PR clear help text.


> GFSH commands - uniform gfsh command to clear regions
> -
>
> Key: GEODE-7667
> URL: https://issues.apache.org/jira/browse/GEODE-7667
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Benjamin P Ross
>Priority: Major
>  Labels: GeodeCommons, docs
>  Time Spent: 5h
>  Remaining Estimate: 0h
>
> * Currently, the gfsh command to clear replicated region is called ‘remove 
> —region=/regionName’.
>  * Replace this command with ‘clear region —region=regionName’
>  * While executing this gfsh command on partitioned regions, this should call 
> the clear() Java API using the gfsh function execution machinery.
>  * Point to note is that this command should take into consideration of the 
> coordinator selection and how this command is distributed to the members
> Acceptance :
>  * There should be ‘clear region —region=/regionName’ gfsh command
>  * The gfsh command must be documented in the Geode User Guide
>  * DUnit tests to verify that command can be executed successfully on 
> PartitionedRegion
>  * Deprecate the remove command, as remove does not mean clear
>  * Unit tests with complete code coverage for the newly written code.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7678) Partitioned Region clear operations must invoke cache level listeners

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170281#comment-17170281
 ] 

ASF subversion and git services commented on GEODE-7678:


Commit 1ecd10ae09fdbd59de85b95b204c3eb2e920de0b in geode's branch 
refs/heads/feature/GEODE-7665 from agingade
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=1ecd10a ]

GEODE-7678 (2nd PR) - Support for cache-listener and client-notification for 
Partitioned Region Clear operation  (#5124)

* GEODE-7678: Add support for cache listener and client notification for PR 
clear

The changes are made to PR clear messaging and locking mechanism to preserve
cache-listener and client-events ordering during concurrent cache operation
while clear in progress.


> Partitioned Region clear operations must invoke cache level listeners
> -
>
> Key: GEODE-7678
> URL: https://issues.apache.org/jira/browse/GEODE-7678
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Anilkumar Gingade
>Priority: Major
>  Labels: GeodeCommons, GeodeOperationAPI
>
> Clear operations are successful and CacheListener.afterRegionClear(), 
> CacheWriter.beforeRegionClear() are invoked.
>  
> Acceptance :
>  * DUnit tests validating the above behavior.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7894) CustomSSLProviderDistributedTest hostNameIsValidatedWhenUsingDefaultContext fails with suspect uncaught DistributedSystemDisconnectedException

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170279#comment-17170279
 ] 

ASF subversion and git services commented on GEODE-7894:


Commit 16814730977822a903521e2bc89e19206c6d9698 in geode's branch 
refs/heads/feature/GEODE-7665 from Nabarun Nag
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=1681473 ]

GEODE-7894: Moving expiry tasks to AbstractRegion.


> CustomSSLProviderDistributedTest hostNameIsValidatedWhenUsingDefaultContext 
> fails with suspect uncaught DistributedSystemDisconnectedException
> --
>
> Key: GEODE-7894
> URL: https://issues.apache.org/jira/browse/GEODE-7894
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Darrel Schneider
>Assignee: Dan Smith
>Priority: Minor
>  Labels: flakey
> Fix For: 1.13.0
>
>
> See: 
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/1663
> {noformat}
> org.apache.geode.cache.client.internal.CustomSSLProviderDistributedTest > 
> hostNameIsValidatedWhenUsingDefaultContext FAILED
> java.lang.AssertionError: Suspicious strings were written to the log 
> during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in log4j at line 1654
> [fatal 2020/03/19 17:26:01.806 GMT  tid=215] Uncaught 
> exception in thread Thread[unused p2p reader,5,RMI Runtime]
> org.apache.geode.distributed.DistributedSystemDisconnectedException: 
> Distribution manager on 172.17.0.15(server-1:113):41001 started at Thu 
> Mar 19 17:25:57 GMT 2020: Message distribution has terminated
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager$Stopper.generateCancelledException(ClusterDistributionManager.java:2873)
>   at 
> org.apache.geode.internal.tcp.TCPConduit$Stopper.generateCancelledException(TCPConduit.java:1004)
>   at 
> org.apache.geode.CancelCriterion.checkCancelInProgress(CancelCriterion.java:83)
>   at 
> org.apache.geode.internal.tcp.Connection.readMessages(Connection.java:1666)
>   at org.apache.geode.internal.tcp.Connection.run(Connection.java:1446)
>   at java.lang.Thread.run(Thread.java:748)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7678) Partitioned Region clear operations must invoke cache level listeners

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170282#comment-17170282
 ] 

ASF subversion and git services commented on GEODE-7678:


Commit 1ecd10ae09fdbd59de85b95b204c3eb2e920de0b in geode's branch 
refs/heads/feature/GEODE-7665 from agingade
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=1ecd10a ]

GEODE-7678 (2nd PR) - Support for cache-listener and client-notification for 
Partitioned Region Clear operation  (#5124)

* GEODE-7678: Add support for cache listener and client notification for PR 
clear

The changes are made to PR clear messaging and locking mechanism to preserve
cache-listener and client-events ordering during concurrent cache operation
while clear in progress.


> Partitioned Region clear operations must invoke cache level listeners
> -
>
> Key: GEODE-7678
> URL: https://issues.apache.org/jira/browse/GEODE-7678
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Anilkumar Gingade
>Priority: Major
>  Labels: GeodeCommons, GeodeOperationAPI
>
> Clear operations are successful and CacheListener.afterRegionClear(), 
> CacheWriter.beforeRegionClear() are invoked.
>  
> Acceptance :
>  * DUnit tests validating the above behavior.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7669) Test coverage for Partitioned Region clear with Overflow enabled

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170283#comment-17170283
 ] 

ASF subversion and git services commented on GEODE-7669:


Commit ddffddc6467d6ba557c5b1c799657a30d1a9c525 in geode's branch 
refs/heads/feature/GEODE-7665 from Jianxia Chen
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=ddffddc ]

GEODE-7669 Test coverage for Partitioned Region clear with Overflow enabled 
(#5189)

Authored-by: Jianxia Chen 


> Test coverage for Partitioned Region clear with Overflow enabled
> 
>
> Key: GEODE-7669
> URL: https://issues.apache.org/jira/browse/GEODE-7669
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Jianxia Chen
>Priority: Major
>  Labels: GeodeCommons, GeodeOperationAPI
>
> Using TDD ensure that clear operations are successful when the partitioned 
> regions have overflow enabled.
> Make the code changes required to enable this.
>  
> Acceptance :
>  * Passing DUnit tests where clear operations are successful on partitioned 
> region with overflow enabled.
>  * Ensure that data has overflown when the clear operation is executed and in 
> the end everything is cleared.
>  * These tests should have redundancy of more than zero 
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.
> Note:
> analyze if these tests are needed for offheap?
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170285#comment-17170285
 ] 

ASF subversion and git services commented on GEODE-8173:


Commit 862cad919fe6abf03d6bfa33900b7a2b7fc9ee30 in geode's branch 
refs/heads/feature/GEODE-7665 from agingade
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=862cad9 ]

GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208)

* GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class.
Co-authored-by: anilkumar gingade 

> Add test coverage for PartitionedRegionClear class
> --
>
> Key: GEODE-8173
> URL: https://issues.apache.org/jira/browse/GEODE-8173
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Anilkumar Gingade
>Priority: Major
>  Labels: GeodeOperationAPI
> Fix For: 1.14.0
>
>
> Add test coverage for PartitionedRegionClear class.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7680) Partitioned region clear operations must be successful while interacting with rebalance

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170289#comment-17170289
 ] 

ASF subversion and git services commented on GEODE-7680:


Commit 0cb20cb322000661a466f9f63cb2c107ca1eb5d4 in geode's branch 
refs/heads/feature/GEODE-7665 from Donal Evans
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=0cb20cb ]

GEODE-7680: PR.clear must be successful when interacting with rebalance (#5095)

- Added DUnit tests to confirm that clear does not interfere with
rebalance or vice versa
- Test when member departs during clear/rebalance
- Test when member joins during clear/rebalance
- Fixed typo in PartitionedRegionClearWithExpirationDUnitTest
- Fixed typo in PartitionedRegion
- Call assignBucketsToPartitions() on leader colocated region during clear
instead of target region

Authored-by: Donal Evans 

> Partitioned region clear operations must be successful while interacting with 
> rebalance 
> 
>
> Key: GEODE-7680
> URL: https://issues.apache.org/jira/browse/GEODE-7680
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Donal Evans
>Priority: Major
>  Labels: GeodeCommons, caching-applications, 
> pull-request-available
> Fix For: 1.14.0
>
>
> Clear operations are successful and while rebalance operations are ongoing.
> Acceptance :
>  * DUnit tests validating the above behavior.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8361) Incorrect Bucket Count Warning Message Shown

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170287#comment-17170287
 ] 

ASF subversion and git services commented on GEODE-8361:


Commit d2a974201e23e0f58e90ca9acfb4b7c1f5b23cfe in geode's branch 
refs/heads/feature/GEODE-7665 from Donal Evans
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=d2a9742 ]

GEODE-8361: Use Set instead of List to track cleared buckets (#5379)

- Refactor PartitionRegionClear to use Set instead of List
- Some other changes to remove warnings/alerts from PartitionedRegionClear and 
PartitionedRegionClearMessage

Authored-by: Donal Evans 

> Incorrect Bucket Count Warning Message Shown
> 
>
> Key: GEODE-8361
> URL: https://issues.apache.org/jira/browse/GEODE-8361
> Project: Geode
>  Issue Type: Sub-task
>  Components: logging
>Reporter: Juan Ramos
>Assignee: Donal Evans
>Priority: Trivial
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> While analysing some failures related to GEODE-7670, I've noticed that 
> sometimes we report an incorrect bucket count within the warning message 
> logged when the clear didn't complete successfully that could confuse our 
> users.
> For this test the partition region always has 13 buckets so, as I user, I 
> would never expect to see a bucket count higher than 13 in my logs (no matter 
> how many redundant copies I have).
> ---
> Below are some examples:
> {noformat}
> [vm1] [warn 2020/07/15 11:56:17.739 GMT RMI TCP 
> Connection(5)-172.17.0.5 tid=0x5f] Unable to clear all the buckets from 
> the partitioned region PartitionedRegion, either data (buckets) moved or 
> member departed. expected to clear number of buckets: 13 actual cleared: 26
> [vm1] [warn 2020/07/15 11:57:48.403 GMT RMI TCP 
> Connection(6)-172.17.0.9 tid=0x10f] Unable to clear all the buckets from 
> the partitioned region PartitionedRegion, either data (buckets) moved or 
> member departed. expected to clear number of buckets: 13 actual cleared: 14
> [vm0] [warn 2020/07/15 12:07:36.227 GMT RMI TCP 
> Connection(32)-172.17.0.25 tid=0x1fe] Unable to clear all the buckets 
> from the partitioned region PartitionedRegion, either data (buckets) moved or 
> member departed. expected to clear number of buckets: 13 actual cleared: 19
> [vm0] [warn 2020/07/15 12:08:56.277 GMT RMI TCP 
> Connection(37)-172.17.0.24 tid=0x2a2] Unable to clear all the buckets 
> from the partitioned region PartitionedRegion, either data (buckets) moved or 
> member departed. expected to clear number of buckets: 13 actual cleared: 16
> {noformat}
> The full set of artefacts and results:
> {noformat}
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=  Test Results URI 
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-4848/test-results/repeatTest/1594816968/
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> Test report artifacts from this job are available at:
> http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-4848/test-artifacts/1594816968/stressnewtestfiles-geode-pr-4848.tgz
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7676) All expiration tasks are cleared after a Partitioned Region is cleared

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170278#comment-17170278
 ] 

ASF subversion and git services commented on GEODE-7676:


Commit 0dcf0ef2b54ddf90e499fcbbee6426077790f07a in geode's branch 
refs/heads/feature/GEODE-7665 from Nabarun Nag
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=0dcf0ef ]

GEODE-7676: Conversion of duration to seconds.


> All expiration tasks are cleared after a Partitioned Region is cleared
> --
>
> Key: GEODE-7676
> URL: https://issues.apache.org/jira/browse/GEODE-7676
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Juan Ramos
>Priority: Major
>  Labels: GeodeCommons, feature/GEODE-7665
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> Clear operations are successful and all the expiration tasks are cleared in 
> the bucket level
> Acceptance :
>  * DUnit tests ensuring that clear operations are successful 
>  * Expiration tasks are cleared.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7678) Partitioned Region clear operations must invoke cache level listeners

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170268#comment-17170268
 ] 

ASF subversion and git services commented on GEODE-7678:


Commit 1ecd10ae09fdbd59de85b95b204c3eb2e920de0b in geode's branch 
refs/heads/feature/GEODE-7665 from agingade
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=1ecd10a ]

GEODE-7678 (2nd PR) - Support for cache-listener and client-notification for 
Partitioned Region Clear operation  (#5124)

* GEODE-7678: Add support for cache listener and client notification for PR 
clear

The changes are made to PR clear messaging and locking mechanism to preserve
cache-listener and client-events ordering during concurrent cache operation
while clear in progress.


> Partitioned Region clear operations must invoke cache level listeners
> -
>
> Key: GEODE-7678
> URL: https://issues.apache.org/jira/browse/GEODE-7678
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Anilkumar Gingade
>Priority: Major
>  Labels: GeodeCommons, GeodeOperationAPI
>
> Clear operations are successful and CacheListener.afterRegionClear(), 
> CacheWriter.beforeRegionClear() are invoked.
>  
> Acceptance :
>  * DUnit tests validating the above behavior.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8361) Incorrect Bucket Count Warning Message Shown

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170274#comment-17170274
 ] 

ASF subversion and git services commented on GEODE-8361:


Commit d2a974201e23e0f58e90ca9acfb4b7c1f5b23cfe in geode's branch 
refs/heads/feature/GEODE-7665 from Donal Evans
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=d2a9742 ]

GEODE-8361: Use Set instead of List to track cleared buckets (#5379)

- Refactor PartitionRegionClear to use Set instead of List
- Some other changes to remove warnings/alerts from PartitionedRegionClear and 
PartitionedRegionClearMessage

Authored-by: Donal Evans 

> Incorrect Bucket Count Warning Message Shown
> 
>
> Key: GEODE-8361
> URL: https://issues.apache.org/jira/browse/GEODE-8361
> Project: Geode
>  Issue Type: Sub-task
>  Components: logging
>Reporter: Juan Ramos
>Assignee: Donal Evans
>Priority: Trivial
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> While analysing some failures related to GEODE-7670, I've noticed that 
> sometimes we report an incorrect bucket count within the warning message 
> logged when the clear didn't complete successfully that could confuse our 
> users.
> For this test the partition region always has 13 buckets so, as I user, I 
> would never expect to see a bucket count higher than 13 in my logs (no matter 
> how many redundant copies I have).
> ---
> Below are some examples:
> {noformat}
> [vm1] [warn 2020/07/15 11:56:17.739 GMT RMI TCP 
> Connection(5)-172.17.0.5 tid=0x5f] Unable to clear all the buckets from 
> the partitioned region PartitionedRegion, either data (buckets) moved or 
> member departed. expected to clear number of buckets: 13 actual cleared: 26
> [vm1] [warn 2020/07/15 11:57:48.403 GMT RMI TCP 
> Connection(6)-172.17.0.9 tid=0x10f] Unable to clear all the buckets from 
> the partitioned region PartitionedRegion, either data (buckets) moved or 
> member departed. expected to clear number of buckets: 13 actual cleared: 14
> [vm0] [warn 2020/07/15 12:07:36.227 GMT RMI TCP 
> Connection(32)-172.17.0.25 tid=0x1fe] Unable to clear all the buckets 
> from the partitioned region PartitionedRegion, either data (buckets) moved or 
> member departed. expected to clear number of buckets: 13 actual cleared: 19
> [vm0] [warn 2020/07/15 12:08:56.277 GMT RMI TCP 
> Connection(37)-172.17.0.24 tid=0x2a2] Unable to clear all the buckets 
> from the partitioned region PartitionedRegion, either data (buckets) moved or 
> member departed. expected to clear number of buckets: 13 actual cleared: 16
> {noformat}
> The full set of artefacts and results:
> {noformat}
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=  Test Results URI 
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-4848/test-results/repeatTest/1594816968/
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> Test report artifacts from this job are available at:
> http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-4848/test-artifacts/1594816968/stressnewtestfiles-geode-pr-4848.tgz
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7894) CustomSSLProviderDistributedTest hostNameIsValidatedWhenUsingDefaultContext fails with suspect uncaught DistributedSystemDisconnectedException

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170266#comment-17170266
 ] 

ASF subversion and git services commented on GEODE-7894:


Commit 16814730977822a903521e2bc89e19206c6d9698 in geode's branch 
refs/heads/feature/GEODE-7665 from Nabarun Nag
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=1681473 ]

GEODE-7894: Moving expiry tasks to AbstractRegion.


> CustomSSLProviderDistributedTest hostNameIsValidatedWhenUsingDefaultContext 
> fails with suspect uncaught DistributedSystemDisconnectedException
> --
>
> Key: GEODE-7894
> URL: https://issues.apache.org/jira/browse/GEODE-7894
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Darrel Schneider
>Assignee: Dan Smith
>Priority: Minor
>  Labels: flakey
> Fix For: 1.13.0
>
>
> See: 
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/1663
> {noformat}
> org.apache.geode.cache.client.internal.CustomSSLProviderDistributedTest > 
> hostNameIsValidatedWhenUsingDefaultContext FAILED
> java.lang.AssertionError: Suspicious strings were written to the log 
> during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in log4j at line 1654
> [fatal 2020/03/19 17:26:01.806 GMT  tid=215] Uncaught 
> exception in thread Thread[unused p2p reader,5,RMI Runtime]
> org.apache.geode.distributed.DistributedSystemDisconnectedException: 
> Distribution manager on 172.17.0.15(server-1:113):41001 started at Thu 
> Mar 19 17:25:57 GMT 2020: Message distribution has terminated
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager$Stopper.generateCancelledException(ClusterDistributionManager.java:2873)
>   at 
> org.apache.geode.internal.tcp.TCPConduit$Stopper.generateCancelledException(TCPConduit.java:1004)
>   at 
> org.apache.geode.CancelCriterion.checkCancelInProgress(CancelCriterion.java:83)
>   at 
> org.apache.geode.internal.tcp.Connection.readMessages(Connection.java:1666)
>   at org.apache.geode.internal.tcp.Connection.run(Connection.java:1446)
>   at java.lang.Thread.run(Thread.java:748)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170271#comment-17170271
 ] 

ASF subversion and git services commented on GEODE-8173:


Commit 862cad919fe6abf03d6bfa33900b7a2b7fc9ee30 in geode's branch 
refs/heads/feature/GEODE-7665 from agingade
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=862cad9 ]

GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208)

* GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class.
Co-authored-by: anilkumar gingade 

> Add test coverage for PartitionedRegionClear class
> --
>
> Key: GEODE-8173
> URL: https://issues.apache.org/jira/browse/GEODE-8173
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Anilkumar Gingade
>Priority: Major
>  Labels: GeodeOperationAPI
> Fix For: 1.14.0
>
>
> Add test coverage for PartitionedRegionClear class.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7667) GFSH commands - uniform gfsh command to clear regions

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170267#comment-17170267
 ] 

ASF subversion and git services commented on GEODE-7667:


Commit 7177dae836a912286fe4f9629c511a7241c33bdf in geode's branch 
refs/heads/feature/GEODE-7665 from Nabarun Nag
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=7177dae ]

GEODE-7667: Fixing test to include PR clear help text.


> GFSH commands - uniform gfsh command to clear regions
> -
>
> Key: GEODE-7667
> URL: https://issues.apache.org/jira/browse/GEODE-7667
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Benjamin P Ross
>Priority: Major
>  Labels: GeodeCommons, docs
>  Time Spent: 5h
>  Remaining Estimate: 0h
>
> * Currently, the gfsh command to clear replicated region is called ‘remove 
> —region=/regionName’.
>  * Replace this command with ‘clear region —region=regionName’
>  * While executing this gfsh command on partitioned regions, this should call 
> the clear() Java API using the gfsh function execution machinery.
>  * Point to note is that this command should take into consideration of the 
> coordinator selection and how this command is distributed to the members
> Acceptance :
>  * There should be ‘clear region —region=/regionName’ gfsh command
>  * The gfsh command must be documented in the Geode User Guide
>  * DUnit tests to verify that command can be executed successfully on 
> PartitionedRegion
>  * Deprecate the remove command, as remove does not mean clear
>  * Unit tests with complete code coverage for the newly written code.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7669) Test coverage for Partitioned Region clear with Overflow enabled

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170270#comment-17170270
 ] 

ASF subversion and git services commented on GEODE-7669:


Commit ddffddc6467d6ba557c5b1c799657a30d1a9c525 in geode's branch 
refs/heads/feature/GEODE-7665 from Jianxia Chen
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=ddffddc ]

GEODE-7669 Test coverage for Partitioned Region clear with Overflow enabled 
(#5189)

Authored-by: Jianxia Chen 


> Test coverage for Partitioned Region clear with Overflow enabled
> 
>
> Key: GEODE-7669
> URL: https://issues.apache.org/jira/browse/GEODE-7669
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Jianxia Chen
>Priority: Major
>  Labels: GeodeCommons, GeodeOperationAPI
>
> Using TDD ensure that clear operations are successful when the partitioned 
> regions have overflow enabled.
> Make the code changes required to enable this.
>  
> Acceptance :
>  * Passing DUnit tests where clear operations are successful on partitioned 
> region with overflow enabled.
>  * Ensure that data has overflown when the clear operation is executed and in 
> the end everything is cleared.
>  * These tests should have redundancy of more than zero 
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.
> Note:
> analyze if these tests are needed for offheap?
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7680) Partitioned region clear operations must be successful while interacting with rebalance

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170276#comment-17170276
 ] 

ASF subversion and git services commented on GEODE-7680:


Commit 0cb20cb322000661a466f9f63cb2c107ca1eb5d4 in geode's branch 
refs/heads/feature/GEODE-7665 from Donal Evans
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=0cb20cb ]

GEODE-7680: PR.clear must be successful when interacting with rebalance (#5095)

- Added DUnit tests to confirm that clear does not interfere with
rebalance or vice versa
- Test when member departs during clear/rebalance
- Test when member joins during clear/rebalance
- Fixed typo in PartitionedRegionClearWithExpirationDUnitTest
- Fixed typo in PartitionedRegion
- Call assignBucketsToPartitions() on leader colocated region during clear
instead of target region

Authored-by: Donal Evans 

> Partitioned region clear operations must be successful while interacting with 
> rebalance 
> 
>
> Key: GEODE-7680
> URL: https://issues.apache.org/jira/browse/GEODE-7680
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Donal Evans
>Priority: Major
>  Labels: GeodeCommons, caching-applications, 
> pull-request-available
> Fix For: 1.14.0
>
>
> Clear operations are successful and while rebalance operations are ongoing.
> Acceptance :
>  * DUnit tests validating the above behavior.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170272#comment-17170272
 ] 

ASF subversion and git services commented on GEODE-8173:


Commit 862cad919fe6abf03d6bfa33900b7a2b7fc9ee30 in geode's branch 
refs/heads/feature/GEODE-7665 from agingade
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=862cad9 ]

GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208)

* GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class.
Co-authored-by: anilkumar gingade 

> Add test coverage for PartitionedRegionClear class
> --
>
> Key: GEODE-8173
> URL: https://issues.apache.org/jira/browse/GEODE-8173
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Anilkumar Gingade
>Priority: Major
>  Labels: GeodeOperationAPI
> Fix For: 1.14.0
>
>
> Add test coverage for PartitionedRegionClear class.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7678) Partitioned Region clear operations must invoke cache level listeners

2020-08-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170269#comment-17170269
 ] 

ASF subversion and git services commented on GEODE-7678:


Commit 1ecd10ae09fdbd59de85b95b204c3eb2e920de0b in geode's branch 
refs/heads/feature/GEODE-7665 from agingade
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=1ecd10a ]

GEODE-7678 (2nd PR) - Support for cache-listener and client-notification for 
Partitioned Region Clear operation  (#5124)

* GEODE-7678: Add support for cache listener and client notification for PR 
clear

The changes are made to PR clear messaging and locking mechanism to preserve
cache-listener and client-events ordering during concurrent cache operation
while clear in progress.


> Partitioned Region clear operations must invoke cache level listeners
> -
>
> Key: GEODE-7678
> URL: https://issues.apache.org/jira/browse/GEODE-7678
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Nabarun Nag
>Assignee: Anilkumar Gingade
>Priority: Major
>  Labels: GeodeCommons, GeodeOperationAPI
>
> Clear operations are successful and CacheListener.afterRegionClear(), 
> CacheWriter.beforeRegionClear() are invoked.
>  
> Acceptance :
>  * DUnit tests validating the above behavior.
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


  1   2   >