[jira] [Commented] (GEODE-7864) Code improvement refactoring
[ https://issues.apache.org/jira/browse/GEODE-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206588#comment-17206588 ] ASF GitHub Bot commented on GEODE-7864: --- lgtm-com[bot] commented on pull request #5582: URL: https://github.com/apache/geode/pull/5582#issuecomment-703032244 This pull request **fixes 108 alerts** when merging 1436671264a36a71b4de1b0f3fd34a8cc703cf2d into ae0d6bcdbc41a364b21bc5c55bd982271ad1284b - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-c92d9dcb9fec27c3227855d6181c7475f1bfa7d7) **fixed alerts:** * 68 for Potential input resource leak * 40 for Potential output resource leak This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Code improvement refactoring > > > Key: GEODE-7864 > URL: https://issues.apache.org/jira/browse/GEODE-7864 > Project: Geode > Issue Type: Improvement >Reporter: Nabarun Nag >Priority: Major > Labels: pull-request-available > Time Spent: 13h 10m > Remaining Estimate: 0h > > This is a placeholder ticket. > * this is used to do refactoring. > * this ticket number is used to number the commit message. > * this ticket will never be closed. > * it will be used to mark improvements like correcting spelling mistakes, > efficient java code, etc. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8536) StackOverflow can occur when Lucene IndexWriter is unable to be created
[
https://issues.apache.org/jira/browse/GEODE-8536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206581#comment-17206581
]
ASF subversion and git services commented on GEODE-8536:
Commit eccd4f0d867579990a6a5de3dc070d45ef8bb8fb in geode's branch
refs/heads/develop from Donal Evans
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=eccd4f0 ]
GEODE-8536: Allow limited retries when creating Lucene IndexWriter (#5553)
Authored-by: Donal Evans
> StackOverflow can occur when Lucene IndexWriter is unable to be created
> ---
>
> Key: GEODE-8536
> URL: https://issues.apache.org/jira/browse/GEODE-8536
> Project: Geode
> Issue Type: Bug
> Components: functions, lucene
>Affects Versions: 1.12.0, 1.13.0, 1.14.0
>Reporter: Donal Evans
>Priority: Major
> Labels: pull-request-available
>
> If, during a call to IndexRepositoryFactory.computeIndexRepository(), an
> IOException is encountered when attempting to construct an IndexWriter, the
> function retry logic will reattempt the execution. This allows transient
> exceptions caused by concurrent modification of the fileAndChunk region to be
> ignored and subsequent executions to succeed (see GEODE-7703). However, if
> the IOException is consistently thrown, the infinitely retrying function can
> cause a StackOverflow:
> {noformat}
> java.lang.StackOverflowError
> at
> org.apache.geode.SystemFailure.startWatchDog(SystemFailure.java:320)
> at
> org.apache.geode.SystemFailure.notifyWatchDog(SystemFailure.java:758)
> at org.apache.geode.SystemFailure.setFailure(SystemFailure.java:813)
> at
> org.apache.geode.SystemFailure.initiateFailure(SystemFailure.java:790)
> at
> org.apache.geode.internal.InternalDataSerializer.invokeToData(InternalDataSerializer.java:2251)
> at
> org.apache.geode.internal.InternalDataSerializer.basicWriteObject(InternalDataSerializer.java:2031)
> at
> org.apache.geode.DataSerializer.writeObject(DataSerializer.java:2839)
> at
> org.apache.geode.internal.cache.partitioned.PartitionedRegionFunctionStreamingMessage.toData(PartitionedRegionFunctionStreamingMessage.java:192)
> at
> org.apache.geode.internal.serialization.internal.DSFIDSerializerImpl.invokeToData(DSFIDSerializerImpl.java:213)
> at
> org.apache.geode.internal.serialization.internal.DSFIDSerializerImpl.write(DSFIDSerializerImpl.java:137)
> at
> org.apache.geode.internal.InternalDataSerializer.writeDSFID(InternalDataSerializer.java:1484)
> at
> org.apache.geode.internal.tcp.MsgStreamer.writeMessage(MsgStreamer.java:247)
> at
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToMany(DirectChannel.java:306)
> at
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToOne(DirectChannel.java:182)
> at
> org.apache.geode.distributed.internal.direct.DirectChannel.send(DirectChannel.java:511)
> at
> org.apache.geode.distributed.internal.DistributionImpl.directChannelSend(DistributionImpl.java:346)
> at
> org.apache.geode.distributed.internal.DistributionImpl.send(DistributionImpl.java:291)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendViaMembershipManager(ClusterDistributionManager.java:2058)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendOutgoing(ClusterDistributionManager.java:1986)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendMessage(ClusterDistributionManager.java:2023)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.putOutgoing(ClusterDistributionManager.java:1083)
> at
> org.apache.geode.internal.cache.execute.PartitionedRegionFunctionResultWaiter.getPartitionedDataFrom(PartitionedRegionFunctionResultWaiter.java:89)
> at
> org.apache.geode.internal.cache.PartitionedRegion.executeOnAllBuckets(PartitionedRegion.java:4079)
> at
> org.apache.geode.internal.cache.PartitionedRegion.executeFunction(PartitionedRegion.java:3583)
> at
> org.apache.geode.internal.cache.execute.PartitionedRegionFunctionExecutor.executeFunction(PartitionedRegionFunctionExecutor.java:220)
> at
> org.apache.geode.internal.cache.execute.AbstractExecution.execute(AbstractExecution.java:376)
> at
> org.apache.geode.internal.cache.execute.AbstractExecution.execute(AbstractExecution.java:359)
> at
> org.apache.geode.internal.cache.execute.LocalResultCollectorImpl.getResultInternal(LocalResultCollectorImpl.java:139)
> at
> org.apache.geode.internal.cache.execute.ResultCollectorHolder.getResult(ResultCollectorHolder.java:53)
> at
>
[jira] [Commented] (GEODE-8536) StackOverflow can occur when Lucene IndexWriter is unable to be created
[
https://issues.apache.org/jira/browse/GEODE-8536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206580#comment-17206580
]
ASF GitHub Bot commented on GEODE-8536:
---
DonalEvans merged pull request #5553:
URL: https://github.com/apache/geode/pull/5553
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> StackOverflow can occur when Lucene IndexWriter is unable to be created
> ---
>
> Key: GEODE-8536
> URL: https://issues.apache.org/jira/browse/GEODE-8536
> Project: Geode
> Issue Type: Bug
> Components: functions, lucene
>Affects Versions: 1.12.0, 1.13.0, 1.14.0
>Reporter: Donal Evans
>Priority: Major
> Labels: pull-request-available
>
> If, during a call to IndexRepositoryFactory.computeIndexRepository(), an
> IOException is encountered when attempting to construct an IndexWriter, the
> function retry logic will reattempt the execution. This allows transient
> exceptions caused by concurrent modification of the fileAndChunk region to be
> ignored and subsequent executions to succeed (see GEODE-7703). However, if
> the IOException is consistently thrown, the infinitely retrying function can
> cause a StackOverflow:
> {noformat}
> java.lang.StackOverflowError
> at
> org.apache.geode.SystemFailure.startWatchDog(SystemFailure.java:320)
> at
> org.apache.geode.SystemFailure.notifyWatchDog(SystemFailure.java:758)
> at org.apache.geode.SystemFailure.setFailure(SystemFailure.java:813)
> at
> org.apache.geode.SystemFailure.initiateFailure(SystemFailure.java:790)
> at
> org.apache.geode.internal.InternalDataSerializer.invokeToData(InternalDataSerializer.java:2251)
> at
> org.apache.geode.internal.InternalDataSerializer.basicWriteObject(InternalDataSerializer.java:2031)
> at
> org.apache.geode.DataSerializer.writeObject(DataSerializer.java:2839)
> at
> org.apache.geode.internal.cache.partitioned.PartitionedRegionFunctionStreamingMessage.toData(PartitionedRegionFunctionStreamingMessage.java:192)
> at
> org.apache.geode.internal.serialization.internal.DSFIDSerializerImpl.invokeToData(DSFIDSerializerImpl.java:213)
> at
> org.apache.geode.internal.serialization.internal.DSFIDSerializerImpl.write(DSFIDSerializerImpl.java:137)
> at
> org.apache.geode.internal.InternalDataSerializer.writeDSFID(InternalDataSerializer.java:1484)
> at
> org.apache.geode.internal.tcp.MsgStreamer.writeMessage(MsgStreamer.java:247)
> at
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToMany(DirectChannel.java:306)
> at
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToOne(DirectChannel.java:182)
> at
> org.apache.geode.distributed.internal.direct.DirectChannel.send(DirectChannel.java:511)
> at
> org.apache.geode.distributed.internal.DistributionImpl.directChannelSend(DistributionImpl.java:346)
> at
> org.apache.geode.distributed.internal.DistributionImpl.send(DistributionImpl.java:291)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendViaMembershipManager(ClusterDistributionManager.java:2058)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendOutgoing(ClusterDistributionManager.java:1986)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendMessage(ClusterDistributionManager.java:2023)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.putOutgoing(ClusterDistributionManager.java:1083)
> at
> org.apache.geode.internal.cache.execute.PartitionedRegionFunctionResultWaiter.getPartitionedDataFrom(PartitionedRegionFunctionResultWaiter.java:89)
> at
> org.apache.geode.internal.cache.PartitionedRegion.executeOnAllBuckets(PartitionedRegion.java:4079)
> at
> org.apache.geode.internal.cache.PartitionedRegion.executeFunction(PartitionedRegion.java:3583)
> at
> org.apache.geode.internal.cache.execute.PartitionedRegionFunctionExecutor.executeFunction(PartitionedRegionFunctionExecutor.java:220)
> at
> org.apache.geode.internal.cache.execute.AbstractExecution.execute(AbstractExecution.java:376)
> at
> org.apache.geode.internal.cache.execute.AbstractExecution.execute(AbstractExecution.java:359)
> at
> org.apache.geode.internal.cache.execute.LocalResultCollectorImpl.getResultInternal(LocalResultCollectorImpl.java:139)
> at
>
[jira] [Commented] (GEODE-8571) Enforce no documentation
[ https://issues.apache.org/jira/browse/GEODE-8571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206569#comment-17206569 ] ASF GitHub Bot commented on GEODE-8571: --- moleske commented on a change in pull request #666: URL: https://github.com/apache/geode-native/pull/666#discussion_r499094966 ## File path: cppcache/include/geode/internal/chrono/duration.hpp ## @@ -145,8 +145,8 @@ inline /** * Converts std::chrono::duration to std::string. * - * @tparam Rep - * @tparam Period + * @tparam Rep the something that reps + * @tparam Period the something else that periods Review comment: I wanted to come back and write something meaningful, but never did. If no one has suggestions I'll just delete the documentation here This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enforce no documentation > > > Key: GEODE-8571 > URL: https://issues.apache.org/jira/browse/GEODE-8571 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Michael Oleske >Priority: Major > Labels: pull-request-available > > Given I compile the code without exempting no-documentation > Then it should compile > Note - was marked as a todo -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8571) Enforce no documentation
[ https://issues.apache.org/jira/browse/GEODE-8571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206568#comment-17206568 ] ASF GitHub Bot commented on GEODE-8571: --- moleske commented on a change in pull request #666: URL: https://github.com/apache/geode-native/pull/666#discussion_r499094822 ## File path: cppcache/src/CqService.hpp ## @@ -211,8 +211,10 @@ class APACHE_GEODE_EXPORT CqService * Invokes the CqListeners for the given CQs. * @param cqs list of cqs with the cq operation from the Server. * @param messageType base operation - * @param key - * @param value + * @param key to invoke listeners with + * @param value to invoke listeners with + * @param deltaValue to invoke listeners with Review comment: `key`, `value`, `deltaValue` are on lines 221-223 right below This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enforce no documentation > > > Key: GEODE-8571 > URL: https://issues.apache.org/jira/browse/GEODE-8571 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Michael Oleske >Priority: Major > Labels: pull-request-available > > Given I compile the code without exempting no-documentation > Then it should compile > Note - was marked as a todo -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8571) Enforce no documentation
[
https://issues.apache.org/jira/browse/GEODE-8571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206567#comment-17206567
]
ASF GitHub Bot commented on GEODE-8571:
---
karensmolermiller commented on a change in pull request #666:
URL: https://github.com/apache/geode-native/pull/666#discussion_r499092657
##
File path: cppcache/include/geode/internal/chrono/duration.hpp
##
@@ -145,8 +145,8 @@ inline
/**
* Converts std::chrono::duration to std::string.
*
- * @tparam Rep
- * @tparam Period
+ * @tparam Rep the something that reps
+ * @tparam Period the something else that periods
Review comment:
Almost a worse definition than not having one at all?
##
File path: cppcache/src/statistics/StatArchiveWriter.hpp
##
@@ -232,9 +232,9 @@ class APACHE_GEODE_EXPORT StatArchiveWriter {
/**
* Opens the statArchiver by opening the file provided as a parameter.
- * @param std::string filename.
+ * @param filename string representation of the file
Review comment:
Better as
* @param filename string representation of the file name
##
File path: cppcache/src/CqService.hpp
##
@@ -211,8 +211,10 @@ class APACHE_GEODE_EXPORT CqService
* Invokes the CqListeners for the given CQs.
* @param cqs list of cqs with the cq operation from the Server.
* @param messageType base operation
- * @param key
- * @param value
+ * @param key to invoke listeners with
+ * @param value to invoke listeners with
+ * @param deltaValue to invoke listeners with
Review comment:
I don't see these parameters in the function header.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Enforce no documentation
>
>
> Key: GEODE-8571
> URL: https://issues.apache.org/jira/browse/GEODE-8571
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Michael Oleske
>Priority: Major
> Labels: pull-request-available
>
> Given I compile the code without exempting no-documentation
> Then it should compile
> Note - was marked as a todo
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-7864) Code improvement refactoring
[ https://issues.apache.org/jira/browse/GEODE-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206562#comment-17206562 ] ASF GitHub Bot commented on GEODE-7864: --- lgtm-com[bot] commented on pull request #5582: URL: https://github.com/apache/geode/pull/5582#issuecomment-703003162 This pull request **fixes 111 alerts** when merging 139a7570d85022ec58dbce02606caeb802224f3c into ae0d6bcdbc41a364b21bc5c55bd982271ad1284b - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-b2a44eb6414d6d56d08eb3e667a62544c7a6a645) **fixed alerts:** * 69 for Potential input resource leak * 42 for Potential output resource leak This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Code improvement refactoring > > > Key: GEODE-7864 > URL: https://issues.apache.org/jira/browse/GEODE-7864 > Project: Geode > Issue Type: Improvement >Reporter: Nabarun Nag >Priority: Major > Labels: pull-request-available > Time Spent: 13h 10m > Remaining Estimate: 0h > > This is a placeholder ticket. > * this is used to do refactoring. > * this ticket number is used to number the commit message. > * this ticket will never be closed. > * it will be used to mark improvements like correcting spelling mistakes, > efficient java code, etc. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8419) SSL/TLS protocol and cipher suite configuration is ignored
[
https://issues.apache.org/jira/browse/GEODE-8419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206556#comment-17206556
]
ASF GitHub Bot commented on GEODE-8419:
---
Bill opened a new pull request #5587:
URL: https://github.com/apache/geode/pull/5587
**Not ready for merge yet.**
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [x] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [x] Have you written or updated unit tests to verify your changes?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> SSL/TLS protocol and cipher suite configuration is ignored
> --
>
> Key: GEODE-8419
> URL: https://issues.apache.org/jira/browse/GEODE-8419
> Project: Geode
> Issue Type: Bug
> Components: client/server, membership, security
>Affects Versions: 1.10.0, 1.11.0, 1.12.0, 1.13.0, 1.14.0
>Reporter: Jacob Barrett
>Assignee: Bruce J Schuchardt
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.14.0
>
>
> Configuring {{ssl-protocols}} or {{ssl-ciphers}} properties, or per-component
> ssl properties, have no effect. Configuring {{ssl-protocols}} may effect the
> {{SSLContext}} selected and limit some of the protocols allowed but does not
> restrict to just the set specified in the property. The {{ssl-ciphers}}
> property does not limit cipher selection at all.
> The result is that all ciphers allowed under the match {{SSLContext}} are
> allowed and negotiated. This can result in an unintended cipher being used in
> SSL/TLS communication.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8419) SSL/TLS protocol and cipher suite configuration is ignored
[
https://issues.apache.org/jira/browse/GEODE-8419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206555#comment-17206555
]
ASF subversion and git services commented on GEODE-8419:
Commit 524dd58ecc6bed33d4b1774b2180a8d47179f638 in geode's branch
refs/heads/feature/GEODE-8419-backport from Bill Burcham
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=524dd58 ]
GEODE-8419: backported forward
> SSL/TLS protocol and cipher suite configuration is ignored
> --
>
> Key: GEODE-8419
> URL: https://issues.apache.org/jira/browse/GEODE-8419
> Project: Geode
> Issue Type: Bug
> Components: client/server, membership, security
>Affects Versions: 1.10.0, 1.11.0, 1.12.0, 1.13.0, 1.14.0
>Reporter: Jacob Barrett
>Assignee: Bruce J Schuchardt
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.14.0
>
>
> Configuring {{ssl-protocols}} or {{ssl-ciphers}} properties, or per-component
> ssl properties, have no effect. Configuring {{ssl-protocols}} may effect the
> {{SSLContext}} selected and limit some of the protocols allowed but does not
> restrict to just the set specified in the property. The {{ssl-ciphers}}
> property does not limit cipher selection at all.
> The result is that all ciphers allowed under the match {{SSLContext}} are
> allowed and negotiated. This can result in an unintended cipher being used in
> SSL/TLS communication.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8550) Integration tests need a version of DistributedReference
[ https://issues.apache.org/jira/browse/GEODE-8550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206545#comment-17206545 ] ASF subversion and git services commented on GEODE-8550: Commit ae0d6bcdbc41a364b21bc5c55bd982271ad1284b in geode's branch refs/heads/develop from Kirk Lund [ https://gitbox.apache.org/repos/asf?p=geode.git;h=ae0d6bc ] GEODE-8550: Rename DistributedCloseableReference (#5579) Rename DistributedReference as DistributedCloseableReference. > Integration tests need a version of DistributedReference > > > Key: GEODE-8550 > URL: https://issues.apache.org/jira/browse/GEODE-8550 > Project: Geode > Issue Type: Wish > Components: tests >Reporter: Kirk Lund >Assignee: Kirk Lund >Priority: Major > Labels: pull-request-available > > Integration tests need a version of DistributedReference. This will allow > both integration and distributed tests to follow a similar approach for > closable resources. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7845) Rollingupgrade should not conflict with the new ClearPRMessage
[
https://issues.apache.org/jira/browse/GEODE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206543#comment-17206543
]
ASF GitHub Bot commented on GEODE-7845:
---
mhansonp commented on a change in pull request #5577:
URL: https://github.com/apache/geode/pull/5577#discussion_r499074405
##
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionClear.java
##
@@ -362,6 +367,10 @@ void doClear(RegionEventImpl regionEvent, boolean
cacheWrite) {
try {
Set bucketsCleared = clearRegion(regionEvent);
+if (!partitionedRegion.allServerVersionsSupportPartitionRegionClear())
{
Review comment:
Good point. We should probably pull it. Look for another checkin that
will have it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Rollingupgrade should not conflict with the new ClearPRMessage
> ---
>
> Key: GEODE-7845
> URL: https://issues.apache.org/jira/browse/GEODE-7845
> Project: Geode
> Issue Type: Improvement
> Components: core
>Reporter: Xiaojian Zhou
>Assignee: Mark Hanson
>Priority: Major
> Labels: GeodeCommons, pull-request-available
>
> PartitionedRegion clear introduced a new ClearPRMessage. In case of doing
> rolling upgrade, the user called PR.clear. The new ClearPRMessage should not
> fail. It should not be sent to the old members.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8550) Integration tests need a version of DistributedReference
[ https://issues.apache.org/jira/browse/GEODE-8550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206544#comment-17206544 ] ASF GitHub Bot commented on GEODE-8550: --- kirklund merged pull request #5579: URL: https://github.com/apache/geode/pull/5579 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Integration tests need a version of DistributedReference > > > Key: GEODE-8550 > URL: https://issues.apache.org/jira/browse/GEODE-8550 > Project: Geode > Issue Type: Wish > Components: tests >Reporter: Kirk Lund >Assignee: Kirk Lund >Priority: Major > Labels: pull-request-available > > Integration tests need a version of DistributedReference. This will allow > both integration and distributed tests to follow a similar approach for > closable resources. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7864) Code improvement refactoring
[ https://issues.apache.org/jira/browse/GEODE-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206538#comment-17206538 ] ASF GitHub Bot commented on GEODE-7864: --- lgtm-com[bot] commented on pull request #5582: URL: https://github.com/apache/geode/pull/5582#issuecomment-702979271 This pull request **fixes 121 alerts** when merging 1f8fab8534cd67fd97f11e241e56728c3d08be54 into 6d58009eb7b391dfbdbe8c673af596ab4da41096 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-def019f3a18ad157106351278a9c1d724f957bd8) **fixed alerts:** * 70 for Potential input resource leak * 51 for Potential output resource leak This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Code improvement refactoring > > > Key: GEODE-7864 > URL: https://issues.apache.org/jira/browse/GEODE-7864 > Project: Geode > Issue Type: Improvement >Reporter: Nabarun Nag >Priority: Major > Labels: pull-request-available > Time Spent: 13h 10m > Remaining Estimate: 0h > > This is a placeholder ticket. > * this is used to do refactoring. > * this ticket number is used to number the commit message. > * this ticket will never be closed. > * it will be used to mark improvements like correcting spelling mistakes, > efficient java code, etc. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8572) LogExporter throws if a directory matches its file selector
[
https://issues.apache.org/jira/browse/GEODE-8572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dale Emery updated GEODE-8572:
--
Labels: GeodeOperationAPI (was: )
> LogExporter throws if a directory matches its file selector
> ---
>
> Key: GEODE-8572
> URL: https://issues.apache.org/jira/browse/GEODE-8572
> Project: Geode
> Issue Type: Bug
> Components: gfsh
>Affects Versions: 1.13.0
>Reporter: Dale Emery
>Priority: Major
> Labels: GeodeOperationAPI
>
> {{LogExporter}} tries to read and export any directory entry whose name is
> accepted by its log file selector predicate. The predicate accepts any entry
> whose name, when converted to lower case, contains ".log". If one of those
> entries is directory, the predicate accepts it anyway. When {{LogExporter}}
> attempts to create a {{FileReader}} read it, the {{FileReader}} constructor
> throws {{FileNotFoundException}}.
> There is a stat file selector predicate that works similarly.
> {{LogExporter}}'s log and stat file selector predicates should accept only
> files, and not directories. And perhaps the should accept only files whose
> names _end_ in the appropriate extension, rather than _containing_ the
> characters. The predicates are defined in {{LogExporter}}'s
> {{findLogFiles()}} and {{findStatFiles()}} methods.
> I discovered this defect by running {{LogExporterIntegrationTest}} on macOS.
> Each test's preparation writes some to-be-exported files into a temporary
> directory that, on macOS, may contain numerous other files and directories.
> One of those directories (e.g.
> /var/folders/yz/6y59fxln38d7lf2jxng1zgg4gn/T/com.apple.LoginUserService),
> which matches the {{LogExporter}}'s predicate.
> These tests should also be changed to write their to-be-exported files to a
> directory that is known to be empty.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (GEODE-8572) LogExporter throws if a directory matches its file selector
Dale Emery created GEODE-8572:
-
Summary: LogExporter throws if a directory matches its file
selector
Key: GEODE-8572
URL: https://issues.apache.org/jira/browse/GEODE-8572
Project: Geode
Issue Type: Bug
Components: gfsh
Affects Versions: 1.13.0
Reporter: Dale Emery
{{LogExporter}} tries to read and export any directory entry whose name is
accepted by its log file selector predicate. The predicate accepts any entry
whose name, when converted to lower case, contains ".log". If one of those
entries is directory, the predicate accepts it anyway. When {{LogExporter}}
attempts to create a {{FileReader}} read it, the {{FileReader}} constructor
throws {{FileNotFoundException}}.
There is a stat file selector predicate that works similarly.
{{LogExporter}}'s log and stat file selector predicates should accept only
files, and not directories. And perhaps the should accept only files whose
names _end_ in the appropriate extension, rather than _containing_ the
characters. The predicates are defined in {{LogExporter}}'s {{findLogFiles()}}
and {{findStatFiles()}} methods.
I discovered this defect by running {{LogExporterIntegrationTest}} on macOS.
Each test's preparation writes some to-be-exported files into a temporary
directory that, on macOS, may contain numerous other files and directories. One
of those directories (e.g.
/var/folders/yz/6y59fxln38d7lf2jxng1zgg4gn/T/com.apple.LoginUserService),
which matches the {{LogExporter}}'s predicate.
These tests should also be changed to write their to-be-exported files to a
directory that is known to be empty.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8566) Redis native tests should not also stand up a Geode server
[
https://issues.apache.org/jira/browse/GEODE-8566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206514#comment-17206514
]
ASF GitHub Bot commented on GEODE-8566:
---
jdeppe-pivotal commented on a change in pull request #5584:
URL: https://github.com/apache/geode/pull/5584#discussion_r499043152
##
File path:
geode-redis/src/acceptanceTest/java/org/apache/geode/redis/internal/executor/key/RenameNativeRedisAcceptanceTest.java
##
@@ -14,30 +14,25 @@
*/
package org.apache.geode.redis.internal.executor.key;
-import java.util.Random;
-
-import org.junit.BeforeClass;
import org.junit.ClassRule;
import org.junit.Ignore;
import org.junit.Test;
-import redis.clients.jedis.Jedis;
import org.apache.geode.NativeRedisTestRule;
-public class RenameNativeRedisAcceptanceTest extends RenameIntegrationTest {
+public class RenameNativeRedisAcceptanceTest extends
AbstractRenameIntegrationTest {
+
@ClassRule
public static NativeRedisTestRule redis = new NativeRedisTestRule();
- @BeforeClass
- public static void setUp() {
-rand = new Random();
-jedis = new Jedis("localhost", redis.getPort(), 1000);
-jedis2 = new Jedis("localhost", redis.getPort(), 1000);
-jedis3 = new Jedis("localhost", redis.getPort(), 1000);
+ @Override
+ public int getPort() {
+return redis.getPort();
}
@Override
@Test
@Ignore("native redis does implement renamenx")
public void renamenxIsUnimplemented() {}
+
Review comment:
I decided to just delete the test. I created a story for us to implement
`RENAMENX`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Redis native tests should not also stand up a Geode server
> --
>
> Key: GEODE-8566
> URL: https://issues.apache.org/jira/browse/GEODE-8566
> Project: Geode
> Issue Type: Test
> Components: redis
>Reporter: Jens Deppe
>Priority: Major
> Labels: pull-request-available
>
> Our native acceptance tests currently extend from the integration tests and
> both classes have a {{@ClassRule}} that results in both a native (container)
> instance and a Geode instance starting up. Mostly not a problem except for
> {{PubSubNativeAcceptanceTest}} which was not testing against native redis.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8566) Redis native tests should not also stand up a Geode server
[
https://issues.apache.org/jira/browse/GEODE-8566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206512#comment-17206512
]
ASF GitHub Bot commented on GEODE-8566:
---
jdeppe-pivotal commented on a change in pull request #5584:
URL: https://github.com/apache/geode/pull/5584#discussion_r499042866
##
File path:
geode-redis/src/integrationTest/java/org/apache/geode/redis/internal/executor/key/AbstractExpireIntegrationTest.java
##
@@ -0,0 +1,339 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+
+package org.apache.geode.redis.internal.executor.key;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
+import redis.clients.jedis.Jedis;
+
+import org.apache.geode.test.dunit.rules.RedisPortSupplier;
+
+public abstract class AbstractExpireIntegrationTest implements
RedisPortSupplier {
+
+ private Jedis jedis;
+ private static int REDIS_CLIENT_TIMEOUT = 1000;
Review comment:
Good idea - since I'm touching a lot of these files already.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Redis native tests should not also stand up a Geode server
> --
>
> Key: GEODE-8566
> URL: https://issues.apache.org/jira/browse/GEODE-8566
> Project: Geode
> Issue Type: Test
> Components: redis
>Reporter: Jens Deppe
>Priority: Major
> Labels: pull-request-available
>
> Our native acceptance tests currently extend from the integration tests and
> both classes have a {{@ClassRule}} that results in both a native (container)
> instance and a Geode instance starting up. Mostly not a problem except for
> {{PubSubNativeAcceptanceTest}} which was not testing against native redis.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8566) Redis native tests should not also stand up a Geode server
[
https://issues.apache.org/jira/browse/GEODE-8566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206510#comment-17206510
]
ASF GitHub Bot commented on GEODE-8566:
---
jdeppe-pivotal commented on a change in pull request #5584:
URL: https://github.com/apache/geode/pull/5584#discussion_r499042492
##
File path:
geode-redis/src/acceptanceTest/java/org/apache/geode/redis/internal/executor/pubsub/PubSubNativeRedisAcceptanceTest.java
##
@@ -15,31 +15,14 @@
package org.apache.geode.redis.internal.executor.pubsub;
-
-
-import org.junit.AfterClass;
-import org.junit.BeforeClass;
import org.junit.ClassRule;
-import redis.clients.jedis.Jedis;
import org.apache.geode.NativeRedisTestRule;
-public class PubSubNativeRedisAcceptanceTest extends PubSubIntegrationTest {
+public class PubSubNativeRedisAcceptanceTest extends
AbstractPubSubIntegrationTest {
@ClassRule
public static NativeRedisTestRule redis = new NativeRedisTestRule();
- @BeforeClass
- public static void setUp() {
-subscriber = new Jedis("localhost", redis.getPort(), JEDIS_TIMEOUT);
-publisher = new Jedis("localhost", redis.getPort(), JEDIS_TIMEOUT);
- }
-
- @AfterClass
- public static void tearDown() {
-subscriber.close();
-publisher.close();
- }
-
public int getPort() {
Review comment:
Yup
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Redis native tests should not also stand up a Geode server
> --
>
> Key: GEODE-8566
> URL: https://issues.apache.org/jira/browse/GEODE-8566
> Project: Geode
> Issue Type: Test
> Components: redis
>Reporter: Jens Deppe
>Priority: Major
> Labels: pull-request-available
>
> Our native acceptance tests currently extend from the integration tests and
> both classes have a {{@ClassRule}} that results in both a native (container)
> instance and a Geode instance starting up. Mostly not a problem except for
> {{PubSubNativeAcceptanceTest}} which was not testing against native redis.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (GEODE-7200) Geode should not try to prefill any declared Pool (e.g. DEFAULT, or otherwise) if a client is running in a local-only capacity
[ https://issues.apache.org/jira/browse/GEODE-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206506#comment-17206506 ] John Blum edited comment on GEODE-7200 at 10/2/20, 8:40 PM: If the client is running completely in LOCAL-only mode, then configuring any connections is a moot point. Having clients run in local-only mode is highly useful for testing purpose, among other things. was (Author: jblum): If the client is running completely in LOCAL-only mode, then configuring any connections is a moot point. > Geode should not try to prefill any declared Pool (e.g. DEFAULT, or > otherwise) if a client is running in a local-only capacity > -- > > Key: GEODE-7200 > URL: https://issues.apache.org/jira/browse/GEODE-7200 > Project: Geode > Issue Type: Bug > Components: client/server >Reporter: John Blum >Priority: Major > Labels: affects-spring > > See https://github.com/spring-projects/spring-boot-data-geode/issues/53 for > more details. > This really client-only and not the traditional client/server topology, which > is a very valid and useful client arrangement. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (GEODE-7200) Geode should not try to prefill any declared Pool (e.g. DEFAULT, or otherwise) if a client is running in a local-only capacity
[ https://issues.apache.org/jira/browse/GEODE-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206506#comment-17206506 ] John Blum edited comment on GEODE-7200 at 10/2/20, 8:40 PM: If the client is running completely in LOCAL-only mode, then configuring any connections is a moot point. Having clients run in local-only mode is highly useful for testing purposes, among other things. was (Author: jblum): If the client is running completely in LOCAL-only mode, then configuring any connections is a moot point. Having clients run in local-only mode is highly useful for testing purpose, among other things. > Geode should not try to prefill any declared Pool (e.g. DEFAULT, or > otherwise) if a client is running in a local-only capacity > -- > > Key: GEODE-7200 > URL: https://issues.apache.org/jira/browse/GEODE-7200 > Project: Geode > Issue Type: Bug > Components: client/server >Reporter: John Blum >Priority: Major > Labels: affects-spring > > See https://github.com/spring-projects/spring-boot-data-geode/issues/53 for > more details. > This really client-only and not the traditional client/server topology, which > is a very valid and useful client arrangement. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7200) Geode should not try to prefill any declared Pool (e.g. DEFAULT, or otherwise) if a client is running in a local-only capacity
[ https://issues.apache.org/jira/browse/GEODE-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206506#comment-17206506 ] John Blum commented on GEODE-7200: -- If the client is running completely in LOCAL-only mode, then configuring any connections is a moot point. > Geode should not try to prefill any declared Pool (e.g. DEFAULT, or > otherwise) if a client is running in a local-only capacity > -- > > Key: GEODE-7200 > URL: https://issues.apache.org/jira/browse/GEODE-7200 > Project: Geode > Issue Type: Bug > Components: client/server >Reporter: John Blum >Priority: Major > Labels: affects-spring > > See https://github.com/spring-projects/spring-boot-data-geode/issues/53 for > more details. > This really client-only and not the traditional client/server topology, which > is a very valid and useful client arrangement. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8519) Geode Native Client user guide: delete unused sources (round 2)
[ https://issues.apache.org/jira/browse/GEODE-8519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dave Barnes updated GEODE-8519: --- Fix Version/s: 1.13.1 1.14.0 > Geode Native Client user guide: delete unused sources (round 2) > --- > > Key: GEODE-8519 > URL: https://issues.apache.org/jira/browse/GEODE-8519 > Project: Geode > Issue Type: Bug > Components: docs, native client >Reporter: Dave Barnes >Assignee: Dave Barnes >Priority: Major > Labels: pull-request-available > Fix For: 1.14.0, 1.13.1 > > > The geode-native docs directory contains unused sources from the > pre-open-source days. The problem is that while they're not linked to the > user guide's T of C, these out-of-date docs are still included in the manual > build (a quirk of the toolset), where they can be accidentally discovered via > web searches. > These unused files need to be identified and deleted. > GEODE-8388 took care of some of these files. There's another group under > 'preserving data' that need to go. The user guide contains two links on the > Continuous Queries page that will need to be removed. > Also, need to remove a link to Durable Client Messaging from the > "Subscription Properties" page. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8553) Reduce ThinClientLocatorHelper lock time
[ https://issues.apache.org/jira/browse/GEODE-8553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206483#comment-17206483 ] ASF GitHub Bot commented on GEODE-8553: --- pdxcodemonkey commented on pull request #660: URL: https://github.com/apache/geode-native/pull/660#issuecomment-702924369 I'm hitting the same test results on a Windows VM, so something major is wrong on that platform. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Reduce ThinClientLocatorHelper lock time > > > Key: GEODE-8553 > URL: https://issues.apache.org/jira/browse/GEODE-8553 > Project: Geode > Issue Type: Improvement > Components: native client >Affects Versions: 1.12.0, 1.13.0 >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: pull-request-available > > During my troublshootings, I've seen that locking m_locatorLock for the whole > scope of the class function members might cause some inter-locks. > Problem here and in many other places of the NC is that networking operations > are performed while a mutex is locked. Therefore if *thread A* takes longer > than expected in performing its network operation, it might block another one > which does not requires any resource of the first *thread A*. Hence, the > inter-lock. > This improvement is the first one of a series regarding to lock scope > reduction when it comes with code regarding networking in NC. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7670) Partitioned Region clear operations can occur during concurrent data operations
[ https://issues.apache.org/jira/browse/GEODE-7670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206478#comment-17206478 ] ASF subversion and git services commented on GEODE-7670: Commit f81724fea2bc28fbdc0503021135082b7a907261 in geode's branch refs/heads/feature/GEODE-7665 from Juan José Ramos [ https://gitbox.apache.org/repos/asf?p=geode.git;h=f81724f ] GEODE-7670: PR Clear with Concurrent Ops DUnitTests (#4848) Added distributed tests to verify that the clear operation on Partitioned Regions works as expected when there are other concurrent operations happening on the cache (put, putAll, get, remove, removeAll, members added and members removed). > Partitioned Region clear operations can occur during concurrent data > operations > --- > > Key: GEODE-7670 > URL: https://issues.apache.org/jira/browse/GEODE-7670 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Juan Ramos >Priority: Major > Labels: GeodeCommons, pull-request-available > Time Spent: 5.5h > Remaining Estimate: 0h > > Clear operations are successful when concurrent read/write operations occur. > Ensure there are test coverage for this use case and modify the code needed > to enable this. > Acceptance : > * Passing DUnit tests where clear operations are successful on partitioned > region with > * concurrent puts (writes) and clear op > * concurrent gets (reads) and clear op > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7680) Partitioned region clear operations must be successful while interacting with rebalance
[ https://issues.apache.org/jira/browse/GEODE-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206479#comment-17206479 ] ASF subversion and git services commented on GEODE-7680: Commit 62701f9c5a22a10dc6d3c0d89ef8ad795999fa0e in geode's branch refs/heads/feature/GEODE-7665 from Donal Evans [ https://gitbox.apache.org/repos/asf?p=geode.git;h=62701f9 ] GEODE-7680: PR.clear must be successful when interacting with rebalance (#5095) - Added DUnit tests to confirm that clear does not interfere with rebalance or vice versa - Test when member departs during clear/rebalance - Test when member joins during clear/rebalance - Fixed typo in PartitionedRegionClearWithExpirationDUnitTest - Fixed typo in PartitionedRegion - Call assignBucketsToPartitions() on leader colocated region during clear instead of target region Authored-by: Donal Evans > Partitioned region clear operations must be successful while interacting with > rebalance > > > Key: GEODE-7680 > URL: https://issues.apache.org/jira/browse/GEODE-7680 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Donal Evans >Priority: Major > Labels: GeodeCommons, caching-applications, > pull-request-available > Fix For: 1.14.0 > > > Clear operations are successful and while rebalance operations are ongoing. > Acceptance : > * DUnit tests validating the above behavior. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8361) Incorrect Bucket Count Warning Message Shown
[
https://issues.apache.org/jira/browse/GEODE-8361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206477#comment-17206477
]
ASF subversion and git services commented on GEODE-8361:
Commit a0c0a68aa894d659d9892a0c61b0909dcee5 in geode's branch
refs/heads/feature/GEODE-7665 from Donal Evans
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=a0c0a68 ]
GEODE-8361: Use Set instead of List to track cleared buckets (#5379)
- Refactor PartitionRegionClear to use Set instead of List
- Some other changes to remove warnings/alerts from PartitionedRegionClear and
PartitionedRegionClearMessage
Authored-by: Donal Evans
> Incorrect Bucket Count Warning Message Shown
>
>
> Key: GEODE-8361
> URL: https://issues.apache.org/jira/browse/GEODE-8361
> Project: Geode
> Issue Type: Sub-task
> Components: logging
>Reporter: Juan Ramos
>Assignee: Donal Evans
>Priority: Trivial
> Labels: pull-request-available
> Fix For: 1.14.0
>
>
> While analysing some failures related to GEODE-7670, I've noticed that
> sometimes we report an incorrect bucket count within the warning message
> logged when the clear didn't complete successfully that could confuse our
> users.
> For this test the partition region always has 13 buckets so, as I user, I
> would never expect to see a bucket count higher than 13 in my logs (no matter
> how many redundant copies I have).
> ---
> Below are some examples:
> {noformat}
> [vm1] [warn 2020/07/15 11:56:17.739 GMT RMI TCP
> Connection(5)-172.17.0.5 tid=0x5f] Unable to clear all the buckets from
> the partitioned region PartitionedRegion, either data (buckets) moved or
> member departed. expected to clear number of buckets: 13 actual cleared: 26
> [vm1] [warn 2020/07/15 11:57:48.403 GMT RMI TCP
> Connection(6)-172.17.0.9 tid=0x10f] Unable to clear all the buckets from
> the partitioned region PartitionedRegion, either data (buckets) moved or
> member departed. expected to clear number of buckets: 13 actual cleared: 14
> [vm0] [warn 2020/07/15 12:07:36.227 GMT RMI TCP
> Connection(32)-172.17.0.25 tid=0x1fe] Unable to clear all the buckets
> from the partitioned region PartitionedRegion, either data (buckets) moved or
> member departed. expected to clear number of buckets: 13 actual cleared: 19
> [vm0] [warn 2020/07/15 12:08:56.277 GMT RMI TCP
> Connection(37)-172.17.0.24 tid=0x2a2] Unable to clear all the buckets
> from the partitioned region PartitionedRegion, either data (buckets) moved or
> member departed. expected to clear number of buckets: 13 actual cleared: 16
> {noformat}
> The full set of artefacts and results:
> {noformat}
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-4848/test-results/repeatTest/1594816968/
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> Test report artifacts from this job are available at:
> http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-4848/test-artifacts/1594816968/stressnewtestfiles-geode-pr-4848.tgz
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-7672) Partitioned Region clear will successfully update the OQL indexes
[ https://issues.apache.org/jira/browse/GEODE-7672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206481#comment-17206481 ] ASF subversion and git services commented on GEODE-7672: Commit c9e4a62f8da2e052c4e3e4dc1e467e00f6b3a4f3 in geode's branch refs/heads/feature/GEODE-7665 from Jinmei Liao [ https://gitbox.apache.org/repos/asf?p=geode.git;h=c9e4a62 ] GEODE-7672: add dunit test to verify OQL index after PR clear. (#5436) * require rvv lock when create index > Partitioned Region clear will successfully update the OQL indexes > - > > Key: GEODE-7672 > URL: https://issues.apache.org/jira/browse/GEODE-7672 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Jianxia Chen >Priority: Major > Labels: GeodeCommons, pull-request-available > > Clear operations are successfully updates the OQL indexes > > Acceptance : > * Passing Dunit tests where OQL queries using indexes return correct results > after the region is cleared > * clear operation and index updates are successful when clear operation is > executed when the puts are occurring which are trying to update the OQL index. > * Unit tests to ensure that index sizes are zero after the region is cleaned > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > > analyze if these tests are needed for offheap? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7846) Clear in Partitioned Region should have its own stats
[ https://issues.apache.org/jira/browse/GEODE-7846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206480#comment-17206480 ] ASF subversion and git services commented on GEODE-7846: Commit b21b29b23f9308970203b8b5517e268e86fbdb36 in geode's branch refs/heads/feature/GEODE-7665 from BenjaminPerryRoss [ https://gitbox.apache.org/repos/asf?p=geode.git;h=b21b29b ] GEODE-7846: Adding Stats for Partitioned Region Clear (#5391) Added stats to CachePerfStats for PR Clear - Changed clears to 'regionClears' and 'bucketClears' to differentiate between the number of times the region was cleared and the number of times a bucket was cleared in a PartitionedRegion - Added Local and Total duration stats to record how long clear has been running for a specific region, as well as how long it was spent clearing any specific member > Clear in Partitioned Region should have its own stats > - > > Key: GEODE-7846 > URL: https://issues.apache.org/jira/browse/GEODE-7846 > Project: Geode > Issue Type: Improvement > Components: core >Reporter: Xiaojian Zhou >Assignee: Benjamin P Ross >Priority: Major > Labels: GeodeCommons, GeodeOperationAPI, pull-request-available > > Clear operation in PR should have its own stats: > 1) clear operation executed. > 2) clear operation failed > 3) clear messages sends to buckets -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class
[ https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206474#comment-17206474 ] ASF subversion and git services commented on GEODE-8173: Commit 271054561dd476578e69e2514fd204b132edb236 in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=2710545 ] GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208) * GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. Co-authored-by: anilkumar gingade > Add test coverage for PartitionedRegionClear class > -- > > Key: GEODE-8173 > URL: https://issues.apache.org/jira/browse/GEODE-8173 > Project: Geode > Issue Type: Bug > Components: regions >Reporter: Anilkumar Gingade >Priority: Major > Labels: GeodeOperationAPI > Fix For: 1.14.0 > > > Add test coverage for PartitionedRegionClear class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7667) GFSH commands - uniform gfsh command to clear regions
[ https://issues.apache.org/jira/browse/GEODE-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206470#comment-17206470 ] ASF subversion and git services commented on GEODE-7667: Commit 86528caca9c04a57a97dbd1b23304395ee59789c in geode's branch refs/heads/feature/GEODE-7665 from Nabarun Nag [ https://gitbox.apache.org/repos/asf?p=geode.git;h=86528ca ] GEODE-7667: Fixing test to include PR clear help text. > GFSH commands - uniform gfsh command to clear regions > - > > Key: GEODE-7667 > URL: https://issues.apache.org/jira/browse/GEODE-7667 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Benjamin P Ross >Priority: Major > Labels: GeodeCommons, docs > Time Spent: 5h > Remaining Estimate: 0h > > * Currently, the gfsh command to clear replicated region is called ‘remove > —region=/regionName’. > * Replace this command with ‘clear region —region=regionName’ > * While executing this gfsh command on partitioned regions, this should call > the clear() Java API using the gfsh function execution machinery. > * Point to note is that this command should take into consideration of the > coordinator selection and how this command is distributed to the members > Acceptance : > * There should be ‘clear region —region=/regionName’ gfsh command > * The gfsh command must be documented in the Geode User Guide > * DUnit tests to verify that command can be executed successfully on > PartitionedRegion > * Deprecate the remove command, as remove does not mean clear > * Unit tests with complete code coverage for the newly written code. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7678) Partitioned Region clear operations must invoke cache level listeners
[ https://issues.apache.org/jira/browse/GEODE-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206471#comment-17206471 ] ASF subversion and git services commented on GEODE-7678: Commit b4ae8f4ecc7bdbbc408896a403c4d485f97c8c8b in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=b4ae8f4 ] GEODE-7678 (2nd PR) - Support for cache-listener and client-notification for Partitioned Region Clear operation (#5124) * GEODE-7678: Add support for cache listener and client notification for PR clear The changes are made to PR clear messaging and locking mechanism to preserve cache-listener and client-events ordering during concurrent cache operation while clear in progress. > Partitioned Region clear operations must invoke cache level listeners > - > > Key: GEODE-7678 > URL: https://issues.apache.org/jira/browse/GEODE-7678 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Anilkumar Gingade >Priority: Major > Labels: GeodeCommons, GeodeOperationAPI > > Clear operations are successful and CacheListener.afterRegionClear(), > CacheWriter.beforeRegionClear() are invoked. > > Acceptance : > * DUnit tests validating the above behavior. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear
[ https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206476#comment-17206476 ] ASF subversion and git services commented on GEODE-8334: Commit eaa1322c769bb236c46330cddce6d06d5f83 in geode's branch refs/heads/feature/GEODE-7665 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=eaa1322 ] GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365) Co-authored-by: Xiaojian Zhou Co-authored-by: Anil Gingade > Primary and secondary bucket data mismatch with concurrent putAll/removeAll > and PR.clear > - > > Key: GEODE-8334 > URL: https://issues.apache.org/jira/browse/GEODE-8334 > Project: Geode > Issue Type: Sub-task > Components: regions >Affects Versions: 1.14.0 >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeOperationAPI > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class
[ https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206475#comment-17206475 ] ASF subversion and git services commented on GEODE-8173: Commit 271054561dd476578e69e2514fd204b132edb236 in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=2710545 ] GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208) * GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. Co-authored-by: anilkumar gingade > Add test coverage for PartitionedRegionClear class > -- > > Key: GEODE-8173 > URL: https://issues.apache.org/jira/browse/GEODE-8173 > Project: Geode > Issue Type: Bug > Components: regions >Reporter: Anilkumar Gingade >Priority: Major > Labels: GeodeOperationAPI > Fix For: 1.14.0 > > > Add test coverage for PartitionedRegionClear class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7669) Test coverage for Partitioned Region clear with Overflow enabled
[ https://issues.apache.org/jira/browse/GEODE-7669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206473#comment-17206473 ] ASF subversion and git services commented on GEODE-7669: Commit 2aa34023d2baa8cf11533d0f5816ba136b84f020 in geode's branch refs/heads/feature/GEODE-7665 from Jianxia Chen [ https://gitbox.apache.org/repos/asf?p=geode.git;h=2aa3402 ] GEODE-7669 Test coverage for Partitioned Region clear with Overflow enabled (#5189) Authored-by: Jianxia Chen > Test coverage for Partitioned Region clear with Overflow enabled > > > Key: GEODE-7669 > URL: https://issues.apache.org/jira/browse/GEODE-7669 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Jianxia Chen >Priority: Major > Labels: GeodeCommons, GeodeOperationAPI > > Using TDD ensure that clear operations are successful when the partitioned > regions have overflow enabled. > Make the code changes required to enable this. > > Acceptance : > * Passing DUnit tests where clear operations are successful on partitioned > region with overflow enabled. > * Ensure that data has overflown when the clear operation is executed and in > the end everything is cleared. > * These tests should have redundancy of more than zero > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > Note: > analyze if these tests are needed for offheap? > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7678) Partitioned Region clear operations must invoke cache level listeners
[ https://issues.apache.org/jira/browse/GEODE-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206472#comment-17206472 ] ASF subversion and git services commented on GEODE-7678: Commit b4ae8f4ecc7bdbbc408896a403c4d485f97c8c8b in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=b4ae8f4 ] GEODE-7678 (2nd PR) - Support for cache-listener and client-notification for Partitioned Region Clear operation (#5124) * GEODE-7678: Add support for cache listener and client notification for PR clear The changes are made to PR clear messaging and locking mechanism to preserve cache-listener and client-events ordering during concurrent cache operation while clear in progress. > Partitioned Region clear operations must invoke cache level listeners > - > > Key: GEODE-7678 > URL: https://issues.apache.org/jira/browse/GEODE-7678 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Anilkumar Gingade >Priority: Major > Labels: GeodeCommons, GeodeOperationAPI > > Clear operations are successful and CacheListener.afterRegionClear(), > CacheWriter.beforeRegionClear() are invoked. > > Acceptance : > * DUnit tests validating the above behavior. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class
[ https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206462#comment-17206462 ] ASF subversion and git services commented on GEODE-8173: Commit 271054561dd476578e69e2514fd204b132edb236 in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=2710545 ] GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208) * GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. Co-authored-by: anilkumar gingade > Add test coverage for PartitionedRegionClear class > -- > > Key: GEODE-8173 > URL: https://issues.apache.org/jira/browse/GEODE-8173 > Project: Geode > Issue Type: Bug > Components: regions >Reporter: Anilkumar Gingade >Priority: Major > Labels: GeodeOperationAPI > Fix For: 1.14.0 > > > Add test coverage for PartitionedRegionClear class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7678) Partitioned Region clear operations must invoke cache level listeners
[ https://issues.apache.org/jira/browse/GEODE-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206459#comment-17206459 ] ASF subversion and git services commented on GEODE-7678: Commit b4ae8f4ecc7bdbbc408896a403c4d485f97c8c8b in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=b4ae8f4 ] GEODE-7678 (2nd PR) - Support for cache-listener and client-notification for Partitioned Region Clear operation (#5124) * GEODE-7678: Add support for cache listener and client notification for PR clear The changes are made to PR clear messaging and locking mechanism to preserve cache-listener and client-events ordering during concurrent cache operation while clear in progress. > Partitioned Region clear operations must invoke cache level listeners > - > > Key: GEODE-7678 > URL: https://issues.apache.org/jira/browse/GEODE-7678 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Anilkumar Gingade >Priority: Major > Labels: GeodeCommons, GeodeOperationAPI > > Clear operations are successful and CacheListener.afterRegionClear(), > CacheWriter.beforeRegionClear() are invoked. > > Acceptance : > * DUnit tests validating the above behavior. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7678) Partitioned Region clear operations must invoke cache level listeners
[ https://issues.apache.org/jira/browse/GEODE-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206458#comment-17206458 ] ASF subversion and git services commented on GEODE-7678: Commit b4ae8f4ecc7bdbbc408896a403c4d485f97c8c8b in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=b4ae8f4 ] GEODE-7678 (2nd PR) - Support for cache-listener and client-notification for Partitioned Region Clear operation (#5124) * GEODE-7678: Add support for cache listener and client notification for PR clear The changes are made to PR clear messaging and locking mechanism to preserve cache-listener and client-events ordering during concurrent cache operation while clear in progress. > Partitioned Region clear operations must invoke cache level listeners > - > > Key: GEODE-7678 > URL: https://issues.apache.org/jira/browse/GEODE-7678 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Anilkumar Gingade >Priority: Major > Labels: GeodeCommons, GeodeOperationAPI > > Clear operations are successful and CacheListener.afterRegionClear(), > CacheWriter.beforeRegionClear() are invoked. > > Acceptance : > * DUnit tests validating the above behavior. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class
[ https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206461#comment-17206461 ] ASF subversion and git services commented on GEODE-8173: Commit 271054561dd476578e69e2514fd204b132edb236 in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=2710545 ] GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208) * GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. Co-authored-by: anilkumar gingade > Add test coverage for PartitionedRegionClear class > -- > > Key: GEODE-8173 > URL: https://issues.apache.org/jira/browse/GEODE-8173 > Project: Geode > Issue Type: Bug > Components: regions >Reporter: Anilkumar Gingade >Priority: Major > Labels: GeodeOperationAPI > Fix For: 1.14.0 > > > Add test coverage for PartitionedRegionClear class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7667) GFSH commands - uniform gfsh command to clear regions
[ https://issues.apache.org/jira/browse/GEODE-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206457#comment-17206457 ] ASF subversion and git services commented on GEODE-7667: Commit 86528caca9c04a57a97dbd1b23304395ee59789c in geode's branch refs/heads/feature/GEODE-7665 from Nabarun Nag [ https://gitbox.apache.org/repos/asf?p=geode.git;h=86528ca ] GEODE-7667: Fixing test to include PR clear help text. > GFSH commands - uniform gfsh command to clear regions > - > > Key: GEODE-7667 > URL: https://issues.apache.org/jira/browse/GEODE-7667 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Benjamin P Ross >Priority: Major > Labels: GeodeCommons, docs > Time Spent: 5h > Remaining Estimate: 0h > > * Currently, the gfsh command to clear replicated region is called ‘remove > —region=/regionName’. > * Replace this command with ‘clear region —region=regionName’ > * While executing this gfsh command on partitioned regions, this should call > the clear() Java API using the gfsh function execution machinery. > * Point to note is that this command should take into consideration of the > coordinator selection and how this command is distributed to the members > Acceptance : > * There should be ‘clear region —region=/regionName’ gfsh command > * The gfsh command must be documented in the Geode User Guide > * DUnit tests to verify that command can be executed successfully on > PartitionedRegion > * Deprecate the remove command, as remove does not mean clear > * Unit tests with complete code coverage for the newly written code. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7846) Clear in Partitioned Region should have its own stats
[ https://issues.apache.org/jira/browse/GEODE-7846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206467#comment-17206467 ] ASF subversion and git services commented on GEODE-7846: Commit b21b29b23f9308970203b8b5517e268e86fbdb36 in geode's branch refs/heads/feature/GEODE-7665 from BenjaminPerryRoss [ https://gitbox.apache.org/repos/asf?p=geode.git;h=b21b29b ] GEODE-7846: Adding Stats for Partitioned Region Clear (#5391) Added stats to CachePerfStats for PR Clear - Changed clears to 'regionClears' and 'bucketClears' to differentiate between the number of times the region was cleared and the number of times a bucket was cleared in a PartitionedRegion - Added Local and Total duration stats to record how long clear has been running for a specific region, as well as how long it was spent clearing any specific member > Clear in Partitioned Region should have its own stats > - > > Key: GEODE-7846 > URL: https://issues.apache.org/jira/browse/GEODE-7846 > Project: Geode > Issue Type: Improvement > Components: core >Reporter: Xiaojian Zhou >Assignee: Benjamin P Ross >Priority: Major > Labels: GeodeCommons, GeodeOperationAPI, pull-request-available > > Clear operation in PR should have its own stats: > 1) clear operation executed. > 2) clear operation failed > 3) clear messages sends to buckets -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7680) Partitioned region clear operations must be successful while interacting with rebalance
[ https://issues.apache.org/jira/browse/GEODE-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206466#comment-17206466 ] ASF subversion and git services commented on GEODE-7680: Commit 62701f9c5a22a10dc6d3c0d89ef8ad795999fa0e in geode's branch refs/heads/feature/GEODE-7665 from Donal Evans [ https://gitbox.apache.org/repos/asf?p=geode.git;h=62701f9 ] GEODE-7680: PR.clear must be successful when interacting with rebalance (#5095) - Added DUnit tests to confirm that clear does not interfere with rebalance or vice versa - Test when member departs during clear/rebalance - Test when member joins during clear/rebalance - Fixed typo in PartitionedRegionClearWithExpirationDUnitTest - Fixed typo in PartitionedRegion - Call assignBucketsToPartitions() on leader colocated region during clear instead of target region Authored-by: Donal Evans > Partitioned region clear operations must be successful while interacting with > rebalance > > > Key: GEODE-7680 > URL: https://issues.apache.org/jira/browse/GEODE-7680 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Donal Evans >Priority: Major > Labels: GeodeCommons, caching-applications, > pull-request-available > Fix For: 1.14.0 > > > Clear operations are successful and while rebalance operations are ongoing. > Acceptance : > * DUnit tests validating the above behavior. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8361) Incorrect Bucket Count Warning Message Shown
[
https://issues.apache.org/jira/browse/GEODE-8361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206464#comment-17206464
]
ASF subversion and git services commented on GEODE-8361:
Commit a0c0a68aa894d659d9892a0c61b0909dcee5 in geode's branch
refs/heads/feature/GEODE-7665 from Donal Evans
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=a0c0a68 ]
GEODE-8361: Use Set instead of List to track cleared buckets (#5379)
- Refactor PartitionRegionClear to use Set instead of List
- Some other changes to remove warnings/alerts from PartitionedRegionClear and
PartitionedRegionClearMessage
Authored-by: Donal Evans
> Incorrect Bucket Count Warning Message Shown
>
>
> Key: GEODE-8361
> URL: https://issues.apache.org/jira/browse/GEODE-8361
> Project: Geode
> Issue Type: Sub-task
> Components: logging
>Reporter: Juan Ramos
>Assignee: Donal Evans
>Priority: Trivial
> Labels: pull-request-available
> Fix For: 1.14.0
>
>
> While analysing some failures related to GEODE-7670, I've noticed that
> sometimes we report an incorrect bucket count within the warning message
> logged when the clear didn't complete successfully that could confuse our
> users.
> For this test the partition region always has 13 buckets so, as I user, I
> would never expect to see a bucket count higher than 13 in my logs (no matter
> how many redundant copies I have).
> ---
> Below are some examples:
> {noformat}
> [vm1] [warn 2020/07/15 11:56:17.739 GMT RMI TCP
> Connection(5)-172.17.0.5 tid=0x5f] Unable to clear all the buckets from
> the partitioned region PartitionedRegion, either data (buckets) moved or
> member departed. expected to clear number of buckets: 13 actual cleared: 26
> [vm1] [warn 2020/07/15 11:57:48.403 GMT RMI TCP
> Connection(6)-172.17.0.9 tid=0x10f] Unable to clear all the buckets from
> the partitioned region PartitionedRegion, either data (buckets) moved or
> member departed. expected to clear number of buckets: 13 actual cleared: 14
> [vm0] [warn 2020/07/15 12:07:36.227 GMT RMI TCP
> Connection(32)-172.17.0.25 tid=0x1fe] Unable to clear all the buckets
> from the partitioned region PartitionedRegion, either data (buckets) moved or
> member departed. expected to clear number of buckets: 13 actual cleared: 19
> [vm0] [warn 2020/07/15 12:08:56.277 GMT RMI TCP
> Connection(37)-172.17.0.24 tid=0x2a2] Unable to clear all the buckets
> from the partitioned region PartitionedRegion, either data (buckets) moved or
> member departed. expected to clear number of buckets: 13 actual cleared: 16
> {noformat}
> The full set of artefacts and results:
> {noformat}
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-4848/test-results/repeatTest/1594816968/
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> Test report artifacts from this job are available at:
> http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-4848/test-artifacts/1594816968/stressnewtestfiles-geode-pr-4848.tgz
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear
[ https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206463#comment-17206463 ] ASF subversion and git services commented on GEODE-8334: Commit eaa1322c769bb236c46330cddce6d06d5f83 in geode's branch refs/heads/feature/GEODE-7665 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=eaa1322 ] GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365) Co-authored-by: Xiaojian Zhou Co-authored-by: Anil Gingade > Primary and secondary bucket data mismatch with concurrent putAll/removeAll > and PR.clear > - > > Key: GEODE-8334 > URL: https://issues.apache.org/jira/browse/GEODE-8334 > Project: Geode > Issue Type: Sub-task > Components: regions >Affects Versions: 1.14.0 >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeOperationAPI > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7672) Partitioned Region clear will successfully update the OQL indexes
[ https://issues.apache.org/jira/browse/GEODE-7672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206468#comment-17206468 ] ASF subversion and git services commented on GEODE-7672: Commit c9e4a62f8da2e052c4e3e4dc1e467e00f6b3a4f3 in geode's branch refs/heads/feature/GEODE-7665 from Jinmei Liao [ https://gitbox.apache.org/repos/asf?p=geode.git;h=c9e4a62 ] GEODE-7672: add dunit test to verify OQL index after PR clear. (#5436) * require rvv lock when create index > Partitioned Region clear will successfully update the OQL indexes > - > > Key: GEODE-7672 > URL: https://issues.apache.org/jira/browse/GEODE-7672 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Jianxia Chen >Priority: Major > Labels: GeodeCommons, pull-request-available > > Clear operations are successfully updates the OQL indexes > > Acceptance : > * Passing Dunit tests where OQL queries using indexes return correct results > after the region is cleared > * clear operation and index updates are successful when clear operation is > executed when the puts are occurring which are trying to update the OQL index. > * Unit tests to ensure that index sizes are zero after the region is cleaned > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > > analyze if these tests are needed for offheap? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7669) Test coverage for Partitioned Region clear with Overflow enabled
[ https://issues.apache.org/jira/browse/GEODE-7669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206460#comment-17206460 ] ASF subversion and git services commented on GEODE-7669: Commit 2aa34023d2baa8cf11533d0f5816ba136b84f020 in geode's branch refs/heads/feature/GEODE-7665 from Jianxia Chen [ https://gitbox.apache.org/repos/asf?p=geode.git;h=2aa3402 ] GEODE-7669 Test coverage for Partitioned Region clear with Overflow enabled (#5189) Authored-by: Jianxia Chen > Test coverage for Partitioned Region clear with Overflow enabled > > > Key: GEODE-7669 > URL: https://issues.apache.org/jira/browse/GEODE-7669 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Jianxia Chen >Priority: Major > Labels: GeodeCommons, GeodeOperationAPI > > Using TDD ensure that clear operations are successful when the partitioned > regions have overflow enabled. > Make the code changes required to enable this. > > Acceptance : > * Passing DUnit tests where clear operations are successful on partitioned > region with overflow enabled. > * Ensure that data has overflown when the clear operation is executed and in > the end everything is cleared. > * These tests should have redundancy of more than zero > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > Note: > analyze if these tests are needed for offheap? > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7670) Partitioned Region clear operations can occur during concurrent data operations
[ https://issues.apache.org/jira/browse/GEODE-7670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206465#comment-17206465 ] ASF subversion and git services commented on GEODE-7670: Commit f81724fea2bc28fbdc0503021135082b7a907261 in geode's branch refs/heads/feature/GEODE-7665 from Juan José Ramos [ https://gitbox.apache.org/repos/asf?p=geode.git;h=f81724f ] GEODE-7670: PR Clear with Concurrent Ops DUnitTests (#4848) Added distributed tests to verify that the clear operation on Partitioned Regions works as expected when there are other concurrent operations happening on the cache (put, putAll, get, remove, removeAll, members added and members removed). > Partitioned Region clear operations can occur during concurrent data > operations > --- > > Key: GEODE-7670 > URL: https://issues.apache.org/jira/browse/GEODE-7670 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Juan Ramos >Priority: Major > Labels: GeodeCommons, pull-request-available > Time Spent: 5.5h > Remaining Estimate: 0h > > Clear operations are successful when concurrent read/write operations occur. > Ensure there are test coverage for this use case and modify the code needed > to enable this. > Acceptance : > * Passing DUnit tests where clear operations are successful on partitioned > region with > * concurrent puts (writes) and clear op > * concurrent gets (reads) and clear op > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7672) Partitioned Region clear will successfully update the OQL indexes
[ https://issues.apache.org/jira/browse/GEODE-7672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206455#comment-17206455 ] ASF subversion and git services commented on GEODE-7672: Commit c9e4a62f8da2e052c4e3e4dc1e467e00f6b3a4f3 in geode's branch refs/heads/feature/GEODE-7665 from Jinmei Liao [ https://gitbox.apache.org/repos/asf?p=geode.git;h=c9e4a62 ] GEODE-7672: add dunit test to verify OQL index after PR clear. (#5436) * require rvv lock when create index > Partitioned Region clear will successfully update the OQL indexes > - > > Key: GEODE-7672 > URL: https://issues.apache.org/jira/browse/GEODE-7672 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Jianxia Chen >Priority: Major > Labels: GeodeCommons, pull-request-available > > Clear operations are successfully updates the OQL indexes > > Acceptance : > * Passing Dunit tests where OQL queries using indexes return correct results > after the region is cleared > * clear operation and index updates are successful when clear operation is > executed when the puts are occurring which are trying to update the OQL index. > * Unit tests to ensure that index sizes are zero after the region is cleaned > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > > analyze if these tests are needed for offheap? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7846) Clear in Partitioned Region should have its own stats
[ https://issues.apache.org/jira/browse/GEODE-7846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206454#comment-17206454 ] ASF subversion and git services commented on GEODE-7846: Commit b21b29b23f9308970203b8b5517e268e86fbdb36 in geode's branch refs/heads/feature/GEODE-7665 from BenjaminPerryRoss [ https://gitbox.apache.org/repos/asf?p=geode.git;h=b21b29b ] GEODE-7846: Adding Stats for Partitioned Region Clear (#5391) Added stats to CachePerfStats for PR Clear - Changed clears to 'regionClears' and 'bucketClears' to differentiate between the number of times the region was cleared and the number of times a bucket was cleared in a PartitionedRegion - Added Local and Total duration stats to record how long clear has been running for a specific region, as well as how long it was spent clearing any specific member > Clear in Partitioned Region should have its own stats > - > > Key: GEODE-7846 > URL: https://issues.apache.org/jira/browse/GEODE-7846 > Project: Geode > Issue Type: Improvement > Components: core >Reporter: Xiaojian Zhou >Assignee: Benjamin P Ross >Priority: Major > Labels: GeodeCommons, GeodeOperationAPI, pull-request-available > > Clear operation in PR should have its own stats: > 1) clear operation executed. > 2) clear operation failed > 3) clear messages sends to buckets -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7680) Partitioned region clear operations must be successful while interacting with rebalance
[ https://issues.apache.org/jira/browse/GEODE-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206453#comment-17206453 ] ASF subversion and git services commented on GEODE-7680: Commit 62701f9c5a22a10dc6d3c0d89ef8ad795999fa0e in geode's branch refs/heads/feature/GEODE-7665 from Donal Evans [ https://gitbox.apache.org/repos/asf?p=geode.git;h=62701f9 ] GEODE-7680: PR.clear must be successful when interacting with rebalance (#5095) - Added DUnit tests to confirm that clear does not interfere with rebalance or vice versa - Test when member departs during clear/rebalance - Test when member joins during clear/rebalance - Fixed typo in PartitionedRegionClearWithExpirationDUnitTest - Fixed typo in PartitionedRegion - Call assignBucketsToPartitions() on leader colocated region during clear instead of target region Authored-by: Donal Evans > Partitioned region clear operations must be successful while interacting with > rebalance > > > Key: GEODE-7680 > URL: https://issues.apache.org/jira/browse/GEODE-7680 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Donal Evans >Priority: Major > Labels: GeodeCommons, caching-applications, > pull-request-available > Fix For: 1.14.0 > > > Clear operations are successful and while rebalance operations are ongoing. > Acceptance : > * DUnit tests validating the above behavior. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class
[ https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206448#comment-17206448 ] ASF subversion and git services commented on GEODE-8173: Commit 271054561dd476578e69e2514fd204b132edb236 in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=2710545 ] GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208) * GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. Co-authored-by: anilkumar gingade > Add test coverage for PartitionedRegionClear class > -- > > Key: GEODE-8173 > URL: https://issues.apache.org/jira/browse/GEODE-8173 > Project: Geode > Issue Type: Bug > Components: regions >Reporter: Anilkumar Gingade >Priority: Major > Labels: GeodeOperationAPI > Fix For: 1.14.0 > > > Add test coverage for PartitionedRegionClear class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear
[ https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206450#comment-17206450 ] ASF subversion and git services commented on GEODE-8334: Commit eaa1322c769bb236c46330cddce6d06d5f83 in geode's branch refs/heads/feature/GEODE-7665 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=eaa1322 ] GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365) Co-authored-by: Xiaojian Zhou Co-authored-by: Anil Gingade > Primary and secondary bucket data mismatch with concurrent putAll/removeAll > and PR.clear > - > > Key: GEODE-8334 > URL: https://issues.apache.org/jira/browse/GEODE-8334 > Project: Geode > Issue Type: Sub-task > Components: regions >Affects Versions: 1.14.0 >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeOperationAPI > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7678) Partitioned Region clear operations must invoke cache level listeners
[ https://issues.apache.org/jira/browse/GEODE-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206445#comment-17206445 ] ASF subversion and git services commented on GEODE-7678: Commit b4ae8f4ecc7bdbbc408896a403c4d485f97c8c8b in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=b4ae8f4 ] GEODE-7678 (2nd PR) - Support for cache-listener and client-notification for Partitioned Region Clear operation (#5124) * GEODE-7678: Add support for cache listener and client notification for PR clear The changes are made to PR clear messaging and locking mechanism to preserve cache-listener and client-events ordering during concurrent cache operation while clear in progress. > Partitioned Region clear operations must invoke cache level listeners > - > > Key: GEODE-7678 > URL: https://issues.apache.org/jira/browse/GEODE-7678 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Anilkumar Gingade >Priority: Major > Labels: GeodeCommons, GeodeOperationAPI > > Clear operations are successful and CacheListener.afterRegionClear(), > CacheWriter.beforeRegionClear() are invoked. > > Acceptance : > * DUnit tests validating the above behavior. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class
[ https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206449#comment-17206449 ] ASF subversion and git services commented on GEODE-8173: Commit 271054561dd476578e69e2514fd204b132edb236 in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=2710545 ] GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208) * GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. Co-authored-by: anilkumar gingade > Add test coverage for PartitionedRegionClear class > -- > > Key: GEODE-8173 > URL: https://issues.apache.org/jira/browse/GEODE-8173 > Project: Geode > Issue Type: Bug > Components: regions >Reporter: Anilkumar Gingade >Priority: Major > Labels: GeodeOperationAPI > Fix For: 1.14.0 > > > Add test coverage for PartitionedRegionClear class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7670) Partitioned Region clear operations can occur during concurrent data operations
[ https://issues.apache.org/jira/browse/GEODE-7670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206452#comment-17206452 ] ASF subversion and git services commented on GEODE-7670: Commit f81724fea2bc28fbdc0503021135082b7a907261 in geode's branch refs/heads/feature/GEODE-7665 from Juan José Ramos [ https://gitbox.apache.org/repos/asf?p=geode.git;h=f81724f ] GEODE-7670: PR Clear with Concurrent Ops DUnitTests (#4848) Added distributed tests to verify that the clear operation on Partitioned Regions works as expected when there are other concurrent operations happening on the cache (put, putAll, get, remove, removeAll, members added and members removed). > Partitioned Region clear operations can occur during concurrent data > operations > --- > > Key: GEODE-7670 > URL: https://issues.apache.org/jira/browse/GEODE-7670 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Juan Ramos >Priority: Major > Labels: GeodeCommons, pull-request-available > Time Spent: 5.5h > Remaining Estimate: 0h > > Clear operations are successful when concurrent read/write operations occur. > Ensure there are test coverage for this use case and modify the code needed > to enable this. > Acceptance : > * Passing DUnit tests where clear operations are successful on partitioned > region with > * concurrent puts (writes) and clear op > * concurrent gets (reads) and clear op > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8361) Incorrect Bucket Count Warning Message Shown
[
https://issues.apache.org/jira/browse/GEODE-8361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206451#comment-17206451
]
ASF subversion and git services commented on GEODE-8361:
Commit a0c0a68aa894d659d9892a0c61b0909dcee5 in geode's branch
refs/heads/feature/GEODE-7665 from Donal Evans
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=a0c0a68 ]
GEODE-8361: Use Set instead of List to track cleared buckets (#5379)
- Refactor PartitionRegionClear to use Set instead of List
- Some other changes to remove warnings/alerts from PartitionedRegionClear and
PartitionedRegionClearMessage
Authored-by: Donal Evans
> Incorrect Bucket Count Warning Message Shown
>
>
> Key: GEODE-8361
> URL: https://issues.apache.org/jira/browse/GEODE-8361
> Project: Geode
> Issue Type: Sub-task
> Components: logging
>Reporter: Juan Ramos
>Assignee: Donal Evans
>Priority: Trivial
> Labels: pull-request-available
> Fix For: 1.14.0
>
>
> While analysing some failures related to GEODE-7670, I've noticed that
> sometimes we report an incorrect bucket count within the warning message
> logged when the clear didn't complete successfully that could confuse our
> users.
> For this test the partition region always has 13 buckets so, as I user, I
> would never expect to see a bucket count higher than 13 in my logs (no matter
> how many redundant copies I have).
> ---
> Below are some examples:
> {noformat}
> [vm1] [warn 2020/07/15 11:56:17.739 GMT RMI TCP
> Connection(5)-172.17.0.5 tid=0x5f] Unable to clear all the buckets from
> the partitioned region PartitionedRegion, either data (buckets) moved or
> member departed. expected to clear number of buckets: 13 actual cleared: 26
> [vm1] [warn 2020/07/15 11:57:48.403 GMT RMI TCP
> Connection(6)-172.17.0.9 tid=0x10f] Unable to clear all the buckets from
> the partitioned region PartitionedRegion, either data (buckets) moved or
> member departed. expected to clear number of buckets: 13 actual cleared: 14
> [vm0] [warn 2020/07/15 12:07:36.227 GMT RMI TCP
> Connection(32)-172.17.0.25 tid=0x1fe] Unable to clear all the buckets
> from the partitioned region PartitionedRegion, either data (buckets) moved or
> member departed. expected to clear number of buckets: 13 actual cleared: 19
> [vm0] [warn 2020/07/15 12:08:56.277 GMT RMI TCP
> Connection(37)-172.17.0.24 tid=0x2a2] Unable to clear all the buckets
> from the partitioned region PartitionedRegion, either data (buckets) moved or
> member departed. expected to clear number of buckets: 13 actual cleared: 16
> {noformat}
> The full set of artefacts and results:
> {noformat}
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-4848/test-results/repeatTest/1594816968/
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> Test report artifacts from this job are available at:
> http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-4848/test-artifacts/1594816968/stressnewtestfiles-geode-pr-4848.tgz
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-7669) Test coverage for Partitioned Region clear with Overflow enabled
[ https://issues.apache.org/jira/browse/GEODE-7669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206447#comment-17206447 ] ASF subversion and git services commented on GEODE-7669: Commit 2aa34023d2baa8cf11533d0f5816ba136b84f020 in geode's branch refs/heads/feature/GEODE-7665 from Jianxia Chen [ https://gitbox.apache.org/repos/asf?p=geode.git;h=2aa3402 ] GEODE-7669 Test coverage for Partitioned Region clear with Overflow enabled (#5189) Authored-by: Jianxia Chen > Test coverage for Partitioned Region clear with Overflow enabled > > > Key: GEODE-7669 > URL: https://issues.apache.org/jira/browse/GEODE-7669 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Jianxia Chen >Priority: Major > Labels: GeodeCommons, GeodeOperationAPI > > Using TDD ensure that clear operations are successful when the partitioned > regions have overflow enabled. > Make the code changes required to enable this. > > Acceptance : > * Passing DUnit tests where clear operations are successful on partitioned > region with overflow enabled. > * Ensure that data has overflown when the clear operation is executed and in > the end everything is cleared. > * These tests should have redundancy of more than zero > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > Note: > analyze if these tests are needed for offheap? > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7678) Partitioned Region clear operations must invoke cache level listeners
[ https://issues.apache.org/jira/browse/GEODE-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206446#comment-17206446 ] ASF subversion and git services commented on GEODE-7678: Commit b4ae8f4ecc7bdbbc408896a403c4d485f97c8c8b in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=b4ae8f4 ] GEODE-7678 (2nd PR) - Support for cache-listener and client-notification for Partitioned Region Clear operation (#5124) * GEODE-7678: Add support for cache listener and client notification for PR clear The changes are made to PR clear messaging and locking mechanism to preserve cache-listener and client-events ordering during concurrent cache operation while clear in progress. > Partitioned Region clear operations must invoke cache level listeners > - > > Key: GEODE-7678 > URL: https://issues.apache.org/jira/browse/GEODE-7678 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Anilkumar Gingade >Priority: Major > Labels: GeodeCommons, GeodeOperationAPI > > Clear operations are successful and CacheListener.afterRegionClear(), > CacheWriter.beforeRegionClear() are invoked. > > Acceptance : > * DUnit tests validating the above behavior. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7667) GFSH commands - uniform gfsh command to clear regions
[ https://issues.apache.org/jira/browse/GEODE-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206444#comment-17206444 ] ASF subversion and git services commented on GEODE-7667: Commit 86528caca9c04a57a97dbd1b23304395ee59789c in geode's branch refs/heads/feature/GEODE-7665 from Nabarun Nag [ https://gitbox.apache.org/repos/asf?p=geode.git;h=86528ca ] GEODE-7667: Fixing test to include PR clear help text. > GFSH commands - uniform gfsh command to clear regions > - > > Key: GEODE-7667 > URL: https://issues.apache.org/jira/browse/GEODE-7667 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Benjamin P Ross >Priority: Major > Labels: GeodeCommons, docs > Time Spent: 5h > Remaining Estimate: 0h > > * Currently, the gfsh command to clear replicated region is called ‘remove > —region=/regionName’. > * Replace this command with ‘clear region —region=regionName’ > * While executing this gfsh command on partitioned regions, this should call > the clear() Java API using the gfsh function execution machinery. > * Point to note is that this command should take into consideration of the > coordinator selection and how this command is distributed to the members > Acceptance : > * There should be ‘clear region —region=/regionName’ gfsh command > * The gfsh command must be documented in the Geode User Guide > * DUnit tests to verify that command can be executed successfully on > PartitionedRegion > * Deprecate the remove command, as remove does not mean clear > * Unit tests with complete code coverage for the newly written code. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7846) Clear in Partitioned Region should have its own stats
[ https://issues.apache.org/jira/browse/GEODE-7846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206442#comment-17206442 ] ASF subversion and git services commented on GEODE-7846: Commit b21b29b23f9308970203b8b5517e268e86fbdb36 in geode's branch refs/heads/feature/GEODE-7665 from BenjaminPerryRoss [ https://gitbox.apache.org/repos/asf?p=geode.git;h=b21b29b ] GEODE-7846: Adding Stats for Partitioned Region Clear (#5391) Added stats to CachePerfStats for PR Clear - Changed clears to 'regionClears' and 'bucketClears' to differentiate between the number of times the region was cleared and the number of times a bucket was cleared in a PartitionedRegion - Added Local and Total duration stats to record how long clear has been running for a specific region, as well as how long it was spent clearing any specific member > Clear in Partitioned Region should have its own stats > - > > Key: GEODE-7846 > URL: https://issues.apache.org/jira/browse/GEODE-7846 > Project: Geode > Issue Type: Improvement > Components: core >Reporter: Xiaojian Zhou >Assignee: Benjamin P Ross >Priority: Major > Labels: GeodeCommons, GeodeOperationAPI, pull-request-available > > Clear operation in PR should have its own stats: > 1) clear operation executed. > 2) clear operation failed > 3) clear messages sends to buckets -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7672) Partitioned Region clear will successfully update the OQL indexes
[ https://issues.apache.org/jira/browse/GEODE-7672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206443#comment-17206443 ] ASF subversion and git services commented on GEODE-7672: Commit c9e4a62f8da2e052c4e3e4dc1e467e00f6b3a4f3 in geode's branch refs/heads/feature/GEODE-7665 from Jinmei Liao [ https://gitbox.apache.org/repos/asf?p=geode.git;h=c9e4a62 ] GEODE-7672: add dunit test to verify OQL index after PR clear. (#5436) * require rvv lock when create index > Partitioned Region clear will successfully update the OQL indexes > - > > Key: GEODE-7672 > URL: https://issues.apache.org/jira/browse/GEODE-7672 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Jianxia Chen >Priority: Major > Labels: GeodeCommons, pull-request-available > > Clear operations are successfully updates the OQL indexes > > Acceptance : > * Passing Dunit tests where OQL queries using indexes return correct results > after the region is cleared > * clear operation and index updates are successful when clear operation is > executed when the puts are occurring which are trying to update the OQL index. > * Unit tests to ensure that index sizes are zero after the region is cleaned > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > > analyze if these tests are needed for offheap? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7678) Partitioned Region clear operations must invoke cache level listeners
[ https://issues.apache.org/jira/browse/GEODE-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206433#comment-17206433 ] ASF subversion and git services commented on GEODE-7678: Commit b4ae8f4ecc7bdbbc408896a403c4d485f97c8c8b in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=b4ae8f4 ] GEODE-7678 (2nd PR) - Support for cache-listener and client-notification for Partitioned Region Clear operation (#5124) * GEODE-7678: Add support for cache listener and client notification for PR clear The changes are made to PR clear messaging and locking mechanism to preserve cache-listener and client-events ordering during concurrent cache operation while clear in progress. > Partitioned Region clear operations must invoke cache level listeners > - > > Key: GEODE-7678 > URL: https://issues.apache.org/jira/browse/GEODE-7678 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Anilkumar Gingade >Priority: Major > Labels: GeodeCommons, GeodeOperationAPI > > Clear operations are successful and CacheListener.afterRegionClear(), > CacheWriter.beforeRegionClear() are invoked. > > Acceptance : > * DUnit tests validating the above behavior. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class
[ https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206435#comment-17206435 ] ASF subversion and git services commented on GEODE-8173: Commit 271054561dd476578e69e2514fd204b132edb236 in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=2710545 ] GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208) * GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. Co-authored-by: anilkumar gingade > Add test coverage for PartitionedRegionClear class > -- > > Key: GEODE-8173 > URL: https://issues.apache.org/jira/browse/GEODE-8173 > Project: Geode > Issue Type: Bug > Components: regions >Reporter: Anilkumar Gingade >Priority: Major > Labels: GeodeOperationAPI > Fix For: 1.14.0 > > > Add test coverage for PartitionedRegionClear class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7667) GFSH commands - uniform gfsh command to clear regions
[ https://issues.apache.org/jira/browse/GEODE-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206431#comment-17206431 ] ASF subversion and git services commented on GEODE-7667: Commit 86528caca9c04a57a97dbd1b23304395ee59789c in geode's branch refs/heads/feature/GEODE-7665 from Nabarun Nag [ https://gitbox.apache.org/repos/asf?p=geode.git;h=86528ca ] GEODE-7667: Fixing test to include PR clear help text. > GFSH commands - uniform gfsh command to clear regions > - > > Key: GEODE-7667 > URL: https://issues.apache.org/jira/browse/GEODE-7667 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Benjamin P Ross >Priority: Major > Labels: GeodeCommons, docs > Time Spent: 5h > Remaining Estimate: 0h > > * Currently, the gfsh command to clear replicated region is called ‘remove > —region=/regionName’. > * Replace this command with ‘clear region —region=regionName’ > * While executing this gfsh command on partitioned regions, this should call > the clear() Java API using the gfsh function execution machinery. > * Point to note is that this command should take into consideration of the > coordinator selection and how this command is distributed to the members > Acceptance : > * There should be ‘clear region —region=/regionName’ gfsh command > * The gfsh command must be documented in the Geode User Guide > * DUnit tests to verify that command can be executed successfully on > PartitionedRegion > * Deprecate the remove command, as remove does not mean clear > * Unit tests with complete code coverage for the newly written code. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7670) Partitioned Region clear operations can occur during concurrent data operations
[ https://issues.apache.org/jira/browse/GEODE-7670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206440#comment-17206440 ] ASF subversion and git services commented on GEODE-7670: Commit f81724fea2bc28fbdc0503021135082b7a907261 in geode's branch refs/heads/feature/GEODE-7665 from Juan José Ramos [ https://gitbox.apache.org/repos/asf?p=geode.git;h=f81724f ] GEODE-7670: PR Clear with Concurrent Ops DUnitTests (#4848) Added distributed tests to verify that the clear operation on Partitioned Regions works as expected when there are other concurrent operations happening on the cache (put, putAll, get, remove, removeAll, members added and members removed). > Partitioned Region clear operations can occur during concurrent data > operations > --- > > Key: GEODE-7670 > URL: https://issues.apache.org/jira/browse/GEODE-7670 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Juan Ramos >Priority: Major > Labels: GeodeCommons, pull-request-available > Time Spent: 5.5h > Remaining Estimate: 0h > > Clear operations are successful when concurrent read/write operations occur. > Ensure there are test coverage for this use case and modify the code needed > to enable this. > Acceptance : > * Passing DUnit tests where clear operations are successful on partitioned > region with > * concurrent puts (writes) and clear op > * concurrent gets (reads) and clear op > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear
[ https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206438#comment-17206438 ] ASF subversion and git services commented on GEODE-8334: Commit eaa1322c769bb236c46330cddce6d06d5f83 in geode's branch refs/heads/feature/GEODE-7665 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=eaa1322 ] GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365) Co-authored-by: Xiaojian Zhou Co-authored-by: Anil Gingade > Primary and secondary bucket data mismatch with concurrent putAll/removeAll > and PR.clear > - > > Key: GEODE-8334 > URL: https://issues.apache.org/jira/browse/GEODE-8334 > Project: Geode > Issue Type: Sub-task > Components: regions >Affects Versions: 1.14.0 >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeOperationAPI > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8361) Incorrect Bucket Count Warning Message Shown
[
https://issues.apache.org/jira/browse/GEODE-8361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206439#comment-17206439
]
ASF subversion and git services commented on GEODE-8361:
Commit a0c0a68aa894d659d9892a0c61b0909dcee5 in geode's branch
refs/heads/feature/GEODE-7665 from Donal Evans
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=a0c0a68 ]
GEODE-8361: Use Set instead of List to track cleared buckets (#5379)
- Refactor PartitionRegionClear to use Set instead of List
- Some other changes to remove warnings/alerts from PartitionedRegionClear and
PartitionedRegionClearMessage
Authored-by: Donal Evans
> Incorrect Bucket Count Warning Message Shown
>
>
> Key: GEODE-8361
> URL: https://issues.apache.org/jira/browse/GEODE-8361
> Project: Geode
> Issue Type: Sub-task
> Components: logging
>Reporter: Juan Ramos
>Assignee: Donal Evans
>Priority: Trivial
> Labels: pull-request-available
> Fix For: 1.14.0
>
>
> While analysing some failures related to GEODE-7670, I've noticed that
> sometimes we report an incorrect bucket count within the warning message
> logged when the clear didn't complete successfully that could confuse our
> users.
> For this test the partition region always has 13 buckets so, as I user, I
> would never expect to see a bucket count higher than 13 in my logs (no matter
> how many redundant copies I have).
> ---
> Below are some examples:
> {noformat}
> [vm1] [warn 2020/07/15 11:56:17.739 GMT RMI TCP
> Connection(5)-172.17.0.5 tid=0x5f] Unable to clear all the buckets from
> the partitioned region PartitionedRegion, either data (buckets) moved or
> member departed. expected to clear number of buckets: 13 actual cleared: 26
> [vm1] [warn 2020/07/15 11:57:48.403 GMT RMI TCP
> Connection(6)-172.17.0.9 tid=0x10f] Unable to clear all the buckets from
> the partitioned region PartitionedRegion, either data (buckets) moved or
> member departed. expected to clear number of buckets: 13 actual cleared: 14
> [vm0] [warn 2020/07/15 12:07:36.227 GMT RMI TCP
> Connection(32)-172.17.0.25 tid=0x1fe] Unable to clear all the buckets
> from the partitioned region PartitionedRegion, either data (buckets) moved or
> member departed. expected to clear number of buckets: 13 actual cleared: 19
> [vm0] [warn 2020/07/15 12:08:56.277 GMT RMI TCP
> Connection(37)-172.17.0.24 tid=0x2a2] Unable to clear all the buckets
> from the partitioned region PartitionedRegion, either data (buckets) moved or
> member departed. expected to clear number of buckets: 13 actual cleared: 16
> {noformat}
> The full set of artefacts and results:
> {noformat}
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-4848/test-results/repeatTest/1594816968/
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> Test report artifacts from this job are available at:
> http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-4848/test-artifacts/1594816968/stressnewtestfiles-geode-pr-4848.tgz
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8536) StackOverflow can occur when Lucene IndexWriter is unable to be created
[
https://issues.apache.org/jira/browse/GEODE-8536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206437#comment-17206437
]
ASF GitHub Bot commented on GEODE-8536:
---
DonalEvans commented on a change in pull request #5553:
URL: https://github.com/apache/geode/pull/5553#discussion_r499011949
##
File path:
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/IndexRepositoryFactory.java
##
@@ -44,6 +44,7 @@
private static final Logger logger = LogService.getLogger();
public static final String FILE_REGION_LOCK_FOR_BUCKET_ID =
"FileRegionLockForBucketId:";
public static final String APACHE_GEODE_INDEX_COMPLETE =
"APACHE_GEODE_INDEX_COMPLETE";
+ protected static final int GET_INDEX_WRITER_MAX_ATTEMPTS = 10;
Review comment:
As I understand it, the timing window to hit the IOException is quite
small and difficult to hit, since this problem only shows up in about 1 in 1000
runs of the test I used to diagnose the issue. If the fileAndChunkRegion was
unavailable for a long period of time, I would expect to see this issue
reproduce more often. After running some experiments, I was able to increase
the number of retries to 200 without any noticeable negative effects, which
would increase the time window during which IOExceptions would have to be
consistently encountered and an exception thrown to 1 second, which should help
reduce the chances of encountering it. However, I don't think it's possible to
know for certain how long the fileAndChunkRegion might be unavailable, since
that could change based on the operation being used on it, the size of the
region, current system resources etc.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> StackOverflow can occur when Lucene IndexWriter is unable to be created
> ---
>
> Key: GEODE-8536
> URL: https://issues.apache.org/jira/browse/GEODE-8536
> Project: Geode
> Issue Type: Bug
> Components: functions, lucene
>Affects Versions: 1.12.0, 1.13.0, 1.14.0
>Reporter: Donal Evans
>Priority: Major
> Labels: pull-request-available
>
> If, during a call to IndexRepositoryFactory.computeIndexRepository(), an
> IOException is encountered when attempting to construct an IndexWriter, the
> function retry logic will reattempt the execution. This allows transient
> exceptions caused by concurrent modification of the fileAndChunk region to be
> ignored and subsequent executions to succeed (see GEODE-7703). However, if
> the IOException is consistently thrown, the infinitely retrying function can
> cause a StackOverflow:
> {noformat}
> java.lang.StackOverflowError
> at
> org.apache.geode.SystemFailure.startWatchDog(SystemFailure.java:320)
> at
> org.apache.geode.SystemFailure.notifyWatchDog(SystemFailure.java:758)
> at org.apache.geode.SystemFailure.setFailure(SystemFailure.java:813)
> at
> org.apache.geode.SystemFailure.initiateFailure(SystemFailure.java:790)
> at
> org.apache.geode.internal.InternalDataSerializer.invokeToData(InternalDataSerializer.java:2251)
> at
> org.apache.geode.internal.InternalDataSerializer.basicWriteObject(InternalDataSerializer.java:2031)
> at
> org.apache.geode.DataSerializer.writeObject(DataSerializer.java:2839)
> at
> org.apache.geode.internal.cache.partitioned.PartitionedRegionFunctionStreamingMessage.toData(PartitionedRegionFunctionStreamingMessage.java:192)
> at
> org.apache.geode.internal.serialization.internal.DSFIDSerializerImpl.invokeToData(DSFIDSerializerImpl.java:213)
> at
> org.apache.geode.internal.serialization.internal.DSFIDSerializerImpl.write(DSFIDSerializerImpl.java:137)
> at
> org.apache.geode.internal.InternalDataSerializer.writeDSFID(InternalDataSerializer.java:1484)
> at
> org.apache.geode.internal.tcp.MsgStreamer.writeMessage(MsgStreamer.java:247)
> at
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToMany(DirectChannel.java:306)
> at
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToOne(DirectChannel.java:182)
> at
> org.apache.geode.distributed.internal.direct.DirectChannel.send(DirectChannel.java:511)
> at
> org.apache.geode.distributed.internal.DistributionImpl.directChannelSend(DistributionImpl.java:346)
> at
> org.apache.geode.distributed.internal.DistributionImpl.send(DistributionImpl.java:291)
> at
>
[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class
[ https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206436#comment-17206436 ] ASF subversion and git services commented on GEODE-8173: Commit 271054561dd476578e69e2514fd204b132edb236 in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=2710545 ] GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208) * GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. Co-authored-by: anilkumar gingade > Add test coverage for PartitionedRegionClear class > -- > > Key: GEODE-8173 > URL: https://issues.apache.org/jira/browse/GEODE-8173 > Project: Geode > Issue Type: Bug > Components: regions >Reporter: Anilkumar Gingade >Priority: Major > Labels: GeodeOperationAPI > Fix For: 1.14.0 > > > Add test coverage for PartitionedRegionClear class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7680) Partitioned region clear operations must be successful while interacting with rebalance
[ https://issues.apache.org/jira/browse/GEODE-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206441#comment-17206441 ] ASF subversion and git services commented on GEODE-7680: Commit 62701f9c5a22a10dc6d3c0d89ef8ad795999fa0e in geode's branch refs/heads/feature/GEODE-7665 from Donal Evans [ https://gitbox.apache.org/repos/asf?p=geode.git;h=62701f9 ] GEODE-7680: PR.clear must be successful when interacting with rebalance (#5095) - Added DUnit tests to confirm that clear does not interfere with rebalance or vice versa - Test when member departs during clear/rebalance - Test when member joins during clear/rebalance - Fixed typo in PartitionedRegionClearWithExpirationDUnitTest - Fixed typo in PartitionedRegion - Call assignBucketsToPartitions() on leader colocated region during clear instead of target region Authored-by: Donal Evans > Partitioned region clear operations must be successful while interacting with > rebalance > > > Key: GEODE-7680 > URL: https://issues.apache.org/jira/browse/GEODE-7680 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Donal Evans >Priority: Major > Labels: GeodeCommons, caching-applications, > pull-request-available > Fix For: 1.14.0 > > > Clear operations are successful and while rebalance operations are ongoing. > Acceptance : > * DUnit tests validating the above behavior. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7678) Partitioned Region clear operations must invoke cache level listeners
[ https://issues.apache.org/jira/browse/GEODE-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206432#comment-17206432 ] ASF subversion and git services commented on GEODE-7678: Commit b4ae8f4ecc7bdbbc408896a403c4d485f97c8c8b in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=b4ae8f4 ] GEODE-7678 (2nd PR) - Support for cache-listener and client-notification for Partitioned Region Clear operation (#5124) * GEODE-7678: Add support for cache listener and client notification for PR clear The changes are made to PR clear messaging and locking mechanism to preserve cache-listener and client-events ordering during concurrent cache operation while clear in progress. > Partitioned Region clear operations must invoke cache level listeners > - > > Key: GEODE-7678 > URL: https://issues.apache.org/jira/browse/GEODE-7678 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Anilkumar Gingade >Priority: Major > Labels: GeodeCommons, GeodeOperationAPI > > Clear operations are successful and CacheListener.afterRegionClear(), > CacheWriter.beforeRegionClear() are invoked. > > Acceptance : > * DUnit tests validating the above behavior. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7669) Test coverage for Partitioned Region clear with Overflow enabled
[ https://issues.apache.org/jira/browse/GEODE-7669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206434#comment-17206434 ] ASF subversion and git services commented on GEODE-7669: Commit 2aa34023d2baa8cf11533d0f5816ba136b84f020 in geode's branch refs/heads/feature/GEODE-7665 from Jianxia Chen [ https://gitbox.apache.org/repos/asf?p=geode.git;h=2aa3402 ] GEODE-7669 Test coverage for Partitioned Region clear with Overflow enabled (#5189) Authored-by: Jianxia Chen > Test coverage for Partitioned Region clear with Overflow enabled > > > Key: GEODE-7669 > URL: https://issues.apache.org/jira/browse/GEODE-7669 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Jianxia Chen >Priority: Major > Labels: GeodeCommons, GeodeOperationAPI > > Using TDD ensure that clear operations are successful when the partitioned > regions have overflow enabled. > Make the code changes required to enable this. > > Acceptance : > * Passing DUnit tests where clear operations are successful on partitioned > region with overflow enabled. > * Ensure that data has overflown when the clear operation is executed and in > the end everything is cleared. > * These tests should have redundancy of more than zero > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > Note: > analyze if these tests are needed for offheap? > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7846) Clear in Partitioned Region should have its own stats
[ https://issues.apache.org/jira/browse/GEODE-7846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206429#comment-17206429 ] ASF subversion and git services commented on GEODE-7846: Commit b21b29b23f9308970203b8b5517e268e86fbdb36 in geode's branch refs/heads/feature/GEODE-7665 from BenjaminPerryRoss [ https://gitbox.apache.org/repos/asf?p=geode.git;h=b21b29b ] GEODE-7846: Adding Stats for Partitioned Region Clear (#5391) Added stats to CachePerfStats for PR Clear - Changed clears to 'regionClears' and 'bucketClears' to differentiate between the number of times the region was cleared and the number of times a bucket was cleared in a PartitionedRegion - Added Local and Total duration stats to record how long clear has been running for a specific region, as well as how long it was spent clearing any specific member > Clear in Partitioned Region should have its own stats > - > > Key: GEODE-7846 > URL: https://issues.apache.org/jira/browse/GEODE-7846 > Project: Geode > Issue Type: Improvement > Components: core >Reporter: Xiaojian Zhou >Assignee: Benjamin P Ross >Priority: Major > Labels: GeodeCommons, GeodeOperationAPI, pull-request-available > > Clear operation in PR should have its own stats: > 1) clear operation executed. > 2) clear operation failed > 3) clear messages sends to buckets -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7667) GFSH commands - uniform gfsh command to clear regions
[ https://issues.apache.org/jira/browse/GEODE-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206419#comment-17206419 ] ASF subversion and git services commented on GEODE-7667: Commit 86528caca9c04a57a97dbd1b23304395ee59789c in geode's branch refs/heads/feature/GEODE-7665 from Nabarun Nag [ https://gitbox.apache.org/repos/asf?p=geode.git;h=86528ca ] GEODE-7667: Fixing test to include PR clear help text. > GFSH commands - uniform gfsh command to clear regions > - > > Key: GEODE-7667 > URL: https://issues.apache.org/jira/browse/GEODE-7667 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Benjamin P Ross >Priority: Major > Labels: GeodeCommons, docs > Time Spent: 5h > Remaining Estimate: 0h > > * Currently, the gfsh command to clear replicated region is called ‘remove > —region=/regionName’. > * Replace this command with ‘clear region —region=regionName’ > * While executing this gfsh command on partitioned regions, this should call > the clear() Java API using the gfsh function execution machinery. > * Point to note is that this command should take into consideration of the > coordinator selection and how this command is distributed to the members > Acceptance : > * There should be ‘clear region —region=/regionName’ gfsh command > * The gfsh command must be documented in the Geode User Guide > * DUnit tests to verify that command can be executed successfully on > PartitionedRegion > * Deprecate the remove command, as remove does not mean clear > * Unit tests with complete code coverage for the newly written code. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7680) Partitioned region clear operations must be successful while interacting with rebalance
[ https://issues.apache.org/jira/browse/GEODE-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206428#comment-17206428 ] ASF subversion and git services commented on GEODE-7680: Commit 62701f9c5a22a10dc6d3c0d89ef8ad795999fa0e in geode's branch refs/heads/feature/GEODE-7665 from Donal Evans [ https://gitbox.apache.org/repos/asf?p=geode.git;h=62701f9 ] GEODE-7680: PR.clear must be successful when interacting with rebalance (#5095) - Added DUnit tests to confirm that clear does not interfere with rebalance or vice versa - Test when member departs during clear/rebalance - Test when member joins during clear/rebalance - Fixed typo in PartitionedRegionClearWithExpirationDUnitTest - Fixed typo in PartitionedRegion - Call assignBucketsToPartitions() on leader colocated region during clear instead of target region Authored-by: Donal Evans > Partitioned region clear operations must be successful while interacting with > rebalance > > > Key: GEODE-7680 > URL: https://issues.apache.org/jira/browse/GEODE-7680 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Donal Evans >Priority: Major > Labels: GeodeCommons, caching-applications, > pull-request-available > Fix For: 1.14.0 > > > Clear operations are successful and while rebalance operations are ongoing. > Acceptance : > * DUnit tests validating the above behavior. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear
[ https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206425#comment-17206425 ] ASF subversion and git services commented on GEODE-8334: Commit eaa1322c769bb236c46330cddce6d06d5f83 in geode's branch refs/heads/feature/GEODE-7665 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=eaa1322 ] GEODE-8334: PR.clear should sync with putAll or removeAll on rvvLock (#5365) Co-authored-by: Xiaojian Zhou Co-authored-by: Anil Gingade > Primary and secondary bucket data mismatch with concurrent putAll/removeAll > and PR.clear > - > > Key: GEODE-8334 > URL: https://issues.apache.org/jira/browse/GEODE-8334 > Project: Geode > Issue Type: Sub-task > Components: regions >Affects Versions: 1.14.0 >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeOperationAPI > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8361) Incorrect Bucket Count Warning Message Shown
[
https://issues.apache.org/jira/browse/GEODE-8361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206426#comment-17206426
]
ASF subversion and git services commented on GEODE-8361:
Commit a0c0a68aa894d659d9892a0c61b0909dcee5 in geode's branch
refs/heads/feature/GEODE-7665 from Donal Evans
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=a0c0a68 ]
GEODE-8361: Use Set instead of List to track cleared buckets (#5379)
- Refactor PartitionRegionClear to use Set instead of List
- Some other changes to remove warnings/alerts from PartitionedRegionClear and
PartitionedRegionClearMessage
Authored-by: Donal Evans
> Incorrect Bucket Count Warning Message Shown
>
>
> Key: GEODE-8361
> URL: https://issues.apache.org/jira/browse/GEODE-8361
> Project: Geode
> Issue Type: Sub-task
> Components: logging
>Reporter: Juan Ramos
>Assignee: Donal Evans
>Priority: Trivial
> Labels: pull-request-available
> Fix For: 1.14.0
>
>
> While analysing some failures related to GEODE-7670, I've noticed that
> sometimes we report an incorrect bucket count within the warning message
> logged when the clear didn't complete successfully that could confuse our
> users.
> For this test the partition region always has 13 buckets so, as I user, I
> would never expect to see a bucket count higher than 13 in my logs (no matter
> how many redundant copies I have).
> ---
> Below are some examples:
> {noformat}
> [vm1] [warn 2020/07/15 11:56:17.739 GMT RMI TCP
> Connection(5)-172.17.0.5 tid=0x5f] Unable to clear all the buckets from
> the partitioned region PartitionedRegion, either data (buckets) moved or
> member departed. expected to clear number of buckets: 13 actual cleared: 26
> [vm1] [warn 2020/07/15 11:57:48.403 GMT RMI TCP
> Connection(6)-172.17.0.9 tid=0x10f] Unable to clear all the buckets from
> the partitioned region PartitionedRegion, either data (buckets) moved or
> member departed. expected to clear number of buckets: 13 actual cleared: 14
> [vm0] [warn 2020/07/15 12:07:36.227 GMT RMI TCP
> Connection(32)-172.17.0.25 tid=0x1fe] Unable to clear all the buckets
> from the partitioned region PartitionedRegion, either data (buckets) moved or
> member departed. expected to clear number of buckets: 13 actual cleared: 19
> [vm0] [warn 2020/07/15 12:08:56.277 GMT RMI TCP
> Connection(37)-172.17.0.24 tid=0x2a2] Unable to clear all the buckets
> from the partitioned region PartitionedRegion, either data (buckets) moved or
> member departed. expected to clear number of buckets: 13 actual cleared: 16
> {noformat}
> The full set of artefacts and results:
> {noformat}
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-4848/test-results/repeatTest/1594816968/
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> Test report artifacts from this job are available at:
> http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-4848/test-artifacts/1594816968/stressnewtestfiles-geode-pr-4848.tgz
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class
[ https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206423#comment-17206423 ] ASF subversion and git services commented on GEODE-8173: Commit 271054561dd476578e69e2514fd204b132edb236 in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=2710545 ] GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208) * GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. Co-authored-by: anilkumar gingade > Add test coverage for PartitionedRegionClear class > -- > > Key: GEODE-8173 > URL: https://issues.apache.org/jira/browse/GEODE-8173 > Project: Geode > Issue Type: Bug > Components: regions >Reporter: Anilkumar Gingade >Priority: Major > Labels: GeodeOperationAPI > Fix For: 1.14.0 > > > Add test coverage for PartitionedRegionClear class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7678) Partitioned Region clear operations must invoke cache level listeners
[ https://issues.apache.org/jira/browse/GEODE-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206421#comment-17206421 ] ASF subversion and git services commented on GEODE-7678: Commit b4ae8f4ecc7bdbbc408896a403c4d485f97c8c8b in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=b4ae8f4 ] GEODE-7678 (2nd PR) - Support for cache-listener and client-notification for Partitioned Region Clear operation (#5124) * GEODE-7678: Add support for cache listener and client notification for PR clear The changes are made to PR clear messaging and locking mechanism to preserve cache-listener and client-events ordering during concurrent cache operation while clear in progress. > Partitioned Region clear operations must invoke cache level listeners > - > > Key: GEODE-7678 > URL: https://issues.apache.org/jira/browse/GEODE-7678 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Anilkumar Gingade >Priority: Major > Labels: GeodeCommons, GeodeOperationAPI > > Clear operations are successful and CacheListener.afterRegionClear(), > CacheWriter.beforeRegionClear() are invoked. > > Acceptance : > * DUnit tests validating the above behavior. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7670) Partitioned Region clear operations can occur during concurrent data operations
[ https://issues.apache.org/jira/browse/GEODE-7670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206427#comment-17206427 ] ASF subversion and git services commented on GEODE-7670: Commit f81724fea2bc28fbdc0503021135082b7a907261 in geode's branch refs/heads/feature/GEODE-7665 from Juan José Ramos [ https://gitbox.apache.org/repos/asf?p=geode.git;h=f81724f ] GEODE-7670: PR Clear with Concurrent Ops DUnitTests (#4848) Added distributed tests to verify that the clear operation on Partitioned Regions works as expected when there are other concurrent operations happening on the cache (put, putAll, get, remove, removeAll, members added and members removed). > Partitioned Region clear operations can occur during concurrent data > operations > --- > > Key: GEODE-7670 > URL: https://issues.apache.org/jira/browse/GEODE-7670 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Juan Ramos >Priority: Major > Labels: GeodeCommons, pull-request-available > Time Spent: 5.5h > Remaining Estimate: 0h > > Clear operations are successful when concurrent read/write operations occur. > Ensure there are test coverage for this use case and modify the code needed > to enable this. > Acceptance : > * Passing DUnit tests where clear operations are successful on partitioned > region with > * concurrent puts (writes) and clear op > * concurrent gets (reads) and clear op > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7678) Partitioned Region clear operations must invoke cache level listeners
[ https://issues.apache.org/jira/browse/GEODE-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206420#comment-17206420 ] ASF subversion and git services commented on GEODE-7678: Commit b4ae8f4ecc7bdbbc408896a403c4d485f97c8c8b in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=b4ae8f4 ] GEODE-7678 (2nd PR) - Support for cache-listener and client-notification for Partitioned Region Clear operation (#5124) * GEODE-7678: Add support for cache listener and client notification for PR clear The changes are made to PR clear messaging and locking mechanism to preserve cache-listener and client-events ordering during concurrent cache operation while clear in progress. > Partitioned Region clear operations must invoke cache level listeners > - > > Key: GEODE-7678 > URL: https://issues.apache.org/jira/browse/GEODE-7678 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Anilkumar Gingade >Priority: Major > Labels: GeodeCommons, GeodeOperationAPI > > Clear operations are successful and CacheListener.afterRegionClear(), > CacheWriter.beforeRegionClear() are invoked. > > Acceptance : > * DUnit tests validating the above behavior. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7669) Test coverage for Partitioned Region clear with Overflow enabled
[ https://issues.apache.org/jira/browse/GEODE-7669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206422#comment-17206422 ] ASF subversion and git services commented on GEODE-7669: Commit 2aa34023d2baa8cf11533d0f5816ba136b84f020 in geode's branch refs/heads/feature/GEODE-7665 from Jianxia Chen [ https://gitbox.apache.org/repos/asf?p=geode.git;h=2aa3402 ] GEODE-7669 Test coverage for Partitioned Region clear with Overflow enabled (#5189) Authored-by: Jianxia Chen > Test coverage for Partitioned Region clear with Overflow enabled > > > Key: GEODE-7669 > URL: https://issues.apache.org/jira/browse/GEODE-7669 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Jianxia Chen >Priority: Major > Labels: GeodeCommons, GeodeOperationAPI > > Using TDD ensure that clear operations are successful when the partitioned > regions have overflow enabled. > Make the code changes required to enable this. > > Acceptance : > * Passing DUnit tests where clear operations are successful on partitioned > region with overflow enabled. > * Ensure that data has overflown when the clear operation is executed and in > the end everything is cleared. > * These tests should have redundancy of more than zero > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > Note: > analyze if these tests are needed for offheap? > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class
[ https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206424#comment-17206424 ] ASF subversion and git services commented on GEODE-8173: Commit 271054561dd476578e69e2514fd204b132edb236 in geode's branch refs/heads/feature/GEODE-7665 from agingade [ https://gitbox.apache.org/repos/asf?p=geode.git;h=2710545 ] GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. (#5208) * GEODE-8173: Add unit test (coverage) for PartitionedRegionClear class. Co-authored-by: anilkumar gingade > Add test coverage for PartitionedRegionClear class > -- > > Key: GEODE-8173 > URL: https://issues.apache.org/jira/browse/GEODE-8173 > Project: Geode > Issue Type: Bug > Components: regions >Reporter: Anilkumar Gingade >Priority: Major > Labels: GeodeOperationAPI > Fix For: 1.14.0 > > > Add test coverage for PartitionedRegionClear class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7672) Partitioned Region clear will successfully update the OQL indexes
[ https://issues.apache.org/jira/browse/GEODE-7672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206430#comment-17206430 ] ASF subversion and git services commented on GEODE-7672: Commit c9e4a62f8da2e052c4e3e4dc1e467e00f6b3a4f3 in geode's branch refs/heads/feature/GEODE-7665 from Jinmei Liao [ https://gitbox.apache.org/repos/asf?p=geode.git;h=c9e4a62 ] GEODE-7672: add dunit test to verify OQL index after PR clear. (#5436) * require rvv lock when create index > Partitioned Region clear will successfully update the OQL indexes > - > > Key: GEODE-7672 > URL: https://issues.apache.org/jira/browse/GEODE-7672 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Jianxia Chen >Priority: Major > Labels: GeodeCommons, pull-request-available > > Clear operations are successfully updates the OQL indexes > > Acceptance : > * Passing Dunit tests where OQL queries using indexes return correct results > after the region is cleared > * clear operation and index updates are successful when clear operation is > executed when the puts are occurring which are trying to update the OQL index. > * Unit tests to ensure that index sizes are zero after the region is cleaned > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > > analyze if these tests are needed for offheap? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7845) Rollingupgrade should not conflict with the new ClearPRMessage
[
https://issues.apache.org/jira/browse/GEODE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206399#comment-17206399
]
ASF GitHub Bot commented on GEODE-7845:
---
mhansonp commented on a change in pull request #5577:
URL: https://github.com/apache/geode/pull/5577#discussion_r498987724
##
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegion.java
##
@@ -5328,6 +5328,22 @@ public int getTotalNumberOfBuckets() {
return this.totalNumberOfBuckets;
}
+ /**
+ * This method returns a boolean to indicate if all server versions support
Partition Region clear
+ */
+ public boolean allServerVersionsSupportPartitionRegionClear() {
+for (int i = 0; i < getTotalNumberOfBuckets(); i++) {
Review comment:
In my experience the whole region.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Rollingupgrade should not conflict with the new ClearPRMessage
> ---
>
> Key: GEODE-7845
> URL: https://issues.apache.org/jira/browse/GEODE-7845
> Project: Geode
> Issue Type: Improvement
> Components: core
>Reporter: Xiaojian Zhou
>Assignee: Mark Hanson
>Priority: Major
> Labels: GeodeCommons, pull-request-available
>
> PartitionedRegion clear introduced a new ClearPRMessage. In case of doing
> rolling upgrade, the user called PR.clear. The new ClearPRMessage should not
> fail. It should not be sent to the old members.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-7845) Rollingupgrade should not conflict with the new ClearPRMessage
[
https://issues.apache.org/jira/browse/GEODE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206397#comment-17206397
]
ASF GitHub Bot commented on GEODE-7845:
---
jinmeiliao commented on a change in pull request #5577:
URL: https://github.com/apache/geode/pull/5577#discussion_r498981996
##
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegion.java
##
@@ -5328,6 +5328,22 @@ public int getTotalNumberOfBuckets() {
return this.totalNumberOfBuckets;
}
+ /**
+ * This method returns a boolean to indicate if all server versions support
Partition Region clear
+ */
+ public boolean allServerVersionsSupportPartitionRegionClear() {
+for (int i = 0; i < getTotalNumberOfBuckets(); i++) {
Review comment:
I am not very familiar with how PR is implemented, but is
`getTotalNumberOfBuckets` returns the bucket counts for this server only or for
the entire region?
##
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionClear.java
##
@@ -362,6 +367,10 @@ void doClear(RegionEventImpl regionEvent, boolean
cacheWrite) {
try {
Set bucketsCleared = clearRegion(regionEvent);
+if (!partitionedRegion.allServerVersionsSupportPartitionRegionClear())
{
Review comment:
why are we doing the check here again? I though we only need to check it
before we send out the message.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Rollingupgrade should not conflict with the new ClearPRMessage
> ---
>
> Key: GEODE-7845
> URL: https://issues.apache.org/jira/browse/GEODE-7845
> Project: Geode
> Issue Type: Improvement
> Components: core
>Reporter: Xiaojian Zhou
>Assignee: Mark Hanson
>Priority: Major
> Labels: GeodeCommons, pull-request-available
>
> PartitionedRegion clear introduced a new ClearPRMessage. In case of doing
> rolling upgrade, the user called PR.clear. The new ClearPRMessage should not
> fail. It should not be sent to the old members.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8553) Reduce ThinClientLocatorHelper lock time
[ https://issues.apache.org/jira/browse/GEODE-8553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206388#comment-17206388 ] ASF GitHub Bot commented on GEODE-8553: --- pdxcodemonkey commented on pull request #660: URL: https://github.com/apache/geode-native/pull/660#issuecomment-702881347 I'm running tests on a Windows EC2 instance to confirm it's a real thing and not just a hiccup in our infrastructure. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Reduce ThinClientLocatorHelper lock time > > > Key: GEODE-8553 > URL: https://issues.apache.org/jira/browse/GEODE-8553 > Project: Geode > Issue Type: Improvement > Components: native client >Affects Versions: 1.12.0, 1.13.0 >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: pull-request-available > > During my troublshootings, I've seen that locking m_locatorLock for the whole > scope of the class function members might cause some inter-locks. > Problem here and in many other places of the NC is that networking operations > are performed while a mutex is locked. Therefore if *thread A* takes longer > than expected in performing its network operation, it might block another one > which does not requires any resource of the first *thread A*. Hence, the > inter-lock. > This improvement is the first one of a series regarding to lock scope > reduction when it comes with code regarding networking in NC. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8553) Reduce ThinClientLocatorHelper lock time
[ https://issues.apache.org/jira/browse/GEODE-8553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206387#comment-17206387 ] ASF GitHub Bot commented on GEODE-8553: --- gaussianrecurrence commented on pull request #660: URL: https://github.com/apache/geode-native/pull/660#issuecomment-702877590 Oh my... let me see if I can set up an environment in Windows and run all the tests. Sorry for the inconviniences :S This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Reduce ThinClientLocatorHelper lock time > > > Key: GEODE-8553 > URL: https://issues.apache.org/jira/browse/GEODE-8553 > Project: Geode > Issue Type: Improvement > Components: native client >Affects Versions: 1.12.0, 1.13.0 >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: pull-request-available > > During my troublshootings, I've seen that locking m_locatorLock for the whole > scope of the class function members might cause some inter-locks. > Problem here and in many other places of the NC is that networking operations > are performed while a mutex is locked. Therefore if *thread A* takes longer > than expected in performing its network operation, it might block another one > which does not requires any resource of the first *thread A*. Hence, the > inter-lock. > This improvement is the first one of a series regarding to lock scope > reduction when it comes with code regarding networking in NC. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8553) Reduce ThinClientLocatorHelper lock time
[ https://issues.apache.org/jira/browse/GEODE-8553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206384#comment-17206384 ] ASF GitHub Bot commented on GEODE-8553: --- pdxcodemonkey commented on pull request #660: URL: https://github.com/apache/geode-native/pull/660#issuecomment-702875371 @gaussianrecurrence Yes we have a CI pipeline for all the builds/tests, we're working out how to donate and make it public. In the meantime, we run all incoming PR branches through it to avoid unpleasant surprises. I'm now seeing a ton of test failures on Windows: 18% tests passed, 86 tests failed out of 105 Label Time Summary: FLAKY = 0.00 sec*proc (42 tests) OMITTED= 0.00 sec*proc (20 tests) QUICK = 60.32 sec*proc (15 tests) STABLE = 13222.11 sec*proc (105 tests) Total Test time (real) = 3604.23 sec The following tests did not run: 7 - testFwPerf (Disabled) 11 - testOverflowPutGetSqLite (Disabled) 22 - testThinClientAfterRegionLive (Disabled) 25 - testThinClientCacheables (Disabled) 31 - testThinClientCq (Disabled) 33 - testThinClientCqDurable (Disabled) 34 - testThinClientCqFailover (Disabled) 35 - testThinClientCqHAFailover (Disabled) 44 - testThinClientDurableConnect (Disabled) 47 - testThinClientDurableDisconnectNormal (Disabled) 48 - testThinClientDurableDisconnectTimeout (Disabled) 49 - testThinClientDurableFailoverClientClosedNoRedundancy (Disabled) 51 - testThinClientDurableFailoverClientNotClosedRedundancy (Disabled) 54 - testThinClientDurableKeepAliveFalseTimeout (Disabled) 55 - testThinClientDurableKeepAliveTrueNormal (Disabled) 57 - testThinClientDurableReconnect (Disabled) 58 - testThinClientFailover (Disabled) 59 - testThinClientFailover2 (Disabled) 61 - testThinClientFailoverInterest (Disabled) 62 - testThinClientFailoverInterest2 (Disabled) 64 - testThinClientFailoverRegex (Disabled) 65 - testThinClientFixedPartitionResolver (Disabled) 66 - testThinClientGatewayTest (Disabled) 68 - testThinClientHADistOps (Disabled) 69 - testThinClientHAEventIDMap (Disabled) 70 - testThinClientHAFailover (Disabled) 71 - testThinClientHAFailoverRegex (Disabled) 72 - testThinClientHAMixedRedundancy (Disabled) 74 - testThinClientHAQueryFailover (Disabled) 86 - testThinClientLRUExpiration (Disabled) 87 - testThinClientLargePutAllWithCallBackArg (Disabled) 95 - testThinClientLocatorFailover (Disabled) 96 - testThinClientMultiDS (Disabled) 100 - testThinClientPRPutAllFailover (Disabled) 101 - testThinClientPRSingleHop (Disabled) 103 - testThinClientPartitionResolver (Disabled) 104 - testThinClientPdxDeltaWithNotification (Disabled) 109 - testThinClientPdxTests (Disabled) 110 - testThinClientPoolAttrTest (Disabled) 114 - testThinClientPoolLocator (Disabled) 115 - testThinClientPoolRedundancy (Disabled) 117 - testThinClientPoolServer (Disabled) 118 - testThinClientPutAll (Disabled) 119 - testThinClientPutAllPRSingleHop (Disabled) 122 - testThinClientPutAllWithCallBackArgWithoutConcurrency (Disabled) 124 - testThinClientPutWithDelta (Disabled) 135 - testThinClientRemoteQueryTimeout (Disabled) 140 - testThinClientRemoveOps (Disabled) 141 - testThinClientSecurityAuthentication (Disabled) 142 - testThinClientSecurityAuthenticationMU (Disabled) 144 - testThinClientSecurityAuthorization (Disabled) 145 - testThinClientSecurityAuthorizationMU (Disabled) 146 - testThinClientSecurityCQAuthorizationMU (Disabled) 147 - testThinClientSecurityDurableCQAuthorizationMU (Disabled) 149 - testThinClientSecurityPostAuthorization (Disabled) 150 - testThinClientTXFailover (Disabled) 151 - testThinClientTicket303 (Disabled) 152 - testThinClientTicket304 (Disabled) 154 - testThinClientTracking (Disabled) 157 - testThinClientTransactionsXA (Disabled) 162 - testThinClientWriterException (Disabled) 163 - testTimedSemaphore (Disabled) The following tests FAILED: 1 - testCacheless (Timeout) 12 - testPdxMetadataCheckTest (Failed) 14 - testRegionAccessThreadSafe (Failed) 18 - testSerialization (Failed) 23 - testThinClientBigValue (Failed) 24 - testThinClientCacheableStringArray (Failed) 26 - testThinClientCacheablesLimits (Failed) 27 - testThinClientCallbackArg (Failed) 28 - testThinClientClearRegion (Failed) 29 - testThinClientConflation (Failed) 30 - testThinClientContainsKeyOnServer
[jira] [Updated] (GEODE-8571) Enforce no documentation
[ https://issues.apache.org/jira/browse/GEODE-8571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-8571: -- Labels: pull-request-available (was: ) > Enforce no documentation > > > Key: GEODE-8571 > URL: https://issues.apache.org/jira/browse/GEODE-8571 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Michael Oleske >Priority: Major > Labels: pull-request-available > > Given I compile the code without exempting no-documentation > Then it should compile > Note - was marked as a todo -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8571) Enforce no documentation
[ https://issues.apache.org/jira/browse/GEODE-8571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206380#comment-17206380 ] ASF GitHub Bot commented on GEODE-8571: --- moleske opened a new pull request #666: URL: https://github.com/apache/geode-native/pull/666 Authored-by: M. Oleske Ran on [Windows](https://github.com/moleske/geode-native/actions/runs/280909801) (Visual Studio 2017 and some on Visual Studio 2019) and [Ubuntu](https://github.com/moleske/geode-native/actions/runs/280909802) (16.04 and 18.04) This does not fix content or incorrectness in the docs, I need some feedback/help on that. I also made some questionable decisions, see if you can find them! Since this is going to be mostly grammar/spell check/making sure they're not lying, it is probably easier just to push your suggestions directly if you have access (box is checked for allow edits by maintainers) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enforce no documentation > > > Key: GEODE-8571 > URL: https://issues.apache.org/jira/browse/GEODE-8571 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Michael Oleske >Priority: Major > > Given I compile the code without exempting no-documentation > Then it should compile > Note - was marked as a todo -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-8571) Enforce no documentation
Michael Oleske created GEODE-8571: - Summary: Enforce no documentation Key: GEODE-8571 URL: https://issues.apache.org/jira/browse/GEODE-8571 Project: Geode Issue Type: Improvement Components: native client Reporter: Michael Oleske Given I compile the code without exempting no-documentation Then it should compile Note - was marked as a todo -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8495) Make DUnit launch members in non-conflicting directories [PERMANENT]
[ https://issues.apache.org/jira/browse/GEODE-8495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206296#comment-17206296 ] ASF subversion and git services commented on GEODE-8495: Commit 6d58009eb7b391dfbdbe8c673af596ab4da41096 in geode's branch refs/heads/develop from Dale Emery [ https://gitbox.apache.org/repos/asf?p=geode.git;h=6d58009 ] GEODE-8495: Make tests honor default disk dir property (#5586) The testClientSubscriptionQueueUsingDefaultDS() test in CacheXml66DUnitTest and its subclasses assumed that the system’s default disk directory is the JVM’s current working directory. This change removes that assumption by making the tests honor the defaultDiskDirs system property. Authored-by: Dale Emery > Make DUnit launch members in non-conflicting directories [PERMANENT] > > > Key: GEODE-8495 > URL: https://issues.apache.org/jira/browse/GEODE-8495 > Project: Geode > Issue Type: Test > Components: tests >Reporter: Dale Emery >Assignee: Dale Emery >Priority: Major > Labels: GeodeOperationAPI, pull-request-available > > Currently several features of the DUnit framework prevent tests being run in > parallel outside of a docker container: > 1. The DUnitLauncher launches child VMs in subdirectories with standard names > (e.g. vm0, vm1, ...) in the test JVM's working directory. If multiple tests > run in parallel, the child VMs created by each test share these directories. > 2. LocatorStarterRule and ServerStarterRule launch locators and servers in > the test JVM, directly in the test JVM's working directory. If multiple tests > run in parallel, the members started by these rules share these directories. > Each member expects to be the only thing running in its working directory. > When members from different tests share directories, they become confused and > fail. > To allow running tests in parallel outside of docker containers, fix these > and other directory conflict problems. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8495) Make DUnit launch members in non-conflicting directories [PERMANENT]
[ https://issues.apache.org/jira/browse/GEODE-8495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206297#comment-17206297 ] ASF subversion and git services commented on GEODE-8495: Commit 6d58009eb7b391dfbdbe8c673af596ab4da41096 in geode's branch refs/heads/develop from Dale Emery [ https://gitbox.apache.org/repos/asf?p=geode.git;h=6d58009 ] GEODE-8495: Make tests honor default disk dir property (#5586) The testClientSubscriptionQueueUsingDefaultDS() test in CacheXml66DUnitTest and its subclasses assumed that the system’s default disk directory is the JVM’s current working directory. This change removes that assumption by making the tests honor the defaultDiskDirs system property. Authored-by: Dale Emery > Make DUnit launch members in non-conflicting directories [PERMANENT] > > > Key: GEODE-8495 > URL: https://issues.apache.org/jira/browse/GEODE-8495 > Project: Geode > Issue Type: Test > Components: tests >Reporter: Dale Emery >Assignee: Dale Emery >Priority: Major > Labels: GeodeOperationAPI, pull-request-available > > Currently several features of the DUnit framework prevent tests being run in > parallel outside of a docker container: > 1. The DUnitLauncher launches child VMs in subdirectories with standard names > (e.g. vm0, vm1, ...) in the test JVM's working directory. If multiple tests > run in parallel, the child VMs created by each test share these directories. > 2. LocatorStarterRule and ServerStarterRule launch locators and servers in > the test JVM, directly in the test JVM's working directory. If multiple tests > run in parallel, the members started by these rules share these directories. > Each member expects to be the only thing running in its working directory. > When members from different tests share directories, they become confused and > fail. > To allow running tests in parallel outside of docker containers, fix these > and other directory conflict problems. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8495) Make DUnit launch members in non-conflicting directories [PERMANENT]
[ https://issues.apache.org/jira/browse/GEODE-8495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206295#comment-17206295 ] ASF GitHub Bot commented on GEODE-8495: --- demery-pivotal merged pull request #5586: URL: https://github.com/apache/geode/pull/5586 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Make DUnit launch members in non-conflicting directories [PERMANENT] > > > Key: GEODE-8495 > URL: https://issues.apache.org/jira/browse/GEODE-8495 > Project: Geode > Issue Type: Test > Components: tests >Reporter: Dale Emery >Assignee: Dale Emery >Priority: Major > Labels: GeodeOperationAPI, pull-request-available > > Currently several features of the DUnit framework prevent tests being run in > parallel outside of a docker container: > 1. The DUnitLauncher launches child VMs in subdirectories with standard names > (e.g. vm0, vm1, ...) in the test JVM's working directory. If multiple tests > run in parallel, the child VMs created by each test share these directories. > 2. LocatorStarterRule and ServerStarterRule launch locators and servers in > the test JVM, directly in the test JVM's working directory. If multiple tests > run in parallel, the members started by these rules share these directories. > Each member expects to be the only thing running in its working directory. > When members from different tests share directories, they become confused and > fail. > To allow running tests in parallel outside of docker containers, fix these > and other directory conflict problems. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8553) Reduce ThinClientLocatorHelper lock time
[
https://issues.apache.org/jira/browse/GEODE-8553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206286#comment-17206286
]
ASF GitHub Bot commented on GEODE-8553:
---
gaussianrecurrence commented on a change in pull request #660:
URL: https://github.com/apache/geode-native/pull/660#discussion_r498903573
##
File path: cppcache/src/ThinClientLocatorHelper.hpp
##
@@ -42,38 +43,95 @@ class Connector;
class ThinClientLocatorHelper {
public:
- ThinClientLocatorHelper(const std::vector& locatorAddresses,
+ ThinClientLocatorHelper(const ThinClientLocatorHelper&) = delete;
+ ThinClientLocatorHelper& operator=(const ThinClientLocatorHelper&) = delete;
+
+ ThinClientLocatorHelper(const std::vector& locators,
const ThinClientPoolDM* poolDM);
- ThinClientLocatorHelper(const std::vector& locatorAddresses,
+ ThinClientLocatorHelper(const std::vector& locators,
const std::string& sniProxyHost, int sniProxyPort,
const ThinClientPoolDM* poolDM);
GfErrType getEndpointForNewFwdConn(
ServerLocation& outEndpoint, std::string& additionalLoc,
const std::set& exclEndPts,
const std::string& serverGrp = "",
- const TcrConnection* currentServer = nullptr);
+ const TcrConnection* currentServer = nullptr) const;
GfErrType getEndpointForNewCallBackConn(
ClientProxyMembershipID& memId, std::list& outEndpoint,
std::string& additionalLoc, int redundancy,
- const std::set& exclEndPts, const std::string&
serverGrp);
+ const std::set& exclEndPts,
+ const std::string& serverGrp) const;
GfErrType getAllServers(
std::vector >& servers,
- const std::string& serverGrp);
- int32_t getCurLocatorsNum() {
-return static_cast(m_locHostPort.size());
+ const std::string& serverGrp) const;
+ int32_t getCurLocatorsNum() const {
+return static_cast(locators_.size());
}
GfErrType updateLocators(const std::string& serverGrp = "");
private:
- Connector* createConnection(Connector*& conn, const char* hostname,
- int32_t port,
- std::chrono::microseconds waitSeconds,
- int32_t maxBuffSizePool = 0);
- std::mutex m_locatorLock;
- std::vector m_locHostPort;
+ /**
+ * Auxiliary types
+ */
+
+ class ConnectionWrapper {
+ private:
+Connector* conn_;
+
+ public:
+ConnectionWrapper(const ConnectionWrapper&) = delete;
+ConnectionWrapper& operator=(const ConnectionWrapper&) = delete;
+
+explicit ConnectionWrapper(Connector* conn) : conn_(conn) {}
+ConnectionWrapper(ConnectionWrapper&& other)
+: conn_(std::move(other.conn_)) {}
+
+~ConnectionWrapper();
+
+Connector* operator->() { return conn_; }
+ };
+
+ /**
+ * Returns the number of connections retries per request
+ * @return Number of connection retries towards locators
+ */
+ int getConnRetries() const;
Review comment:
Indeed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Reduce ThinClientLocatorHelper lock time
>
>
> Key: GEODE-8553
> URL: https://issues.apache.org/jira/browse/GEODE-8553
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Affects Versions: 1.12.0, 1.13.0
>Reporter: Mario Salazar de Torres
>Assignee: Mario Salazar de Torres
>Priority: Major
> Labels: pull-request-available
>
> During my troublshootings, I've seen that locking m_locatorLock for the whole
> scope of the class function members might cause some inter-locks.
> Problem here and in many other places of the NC is that networking operations
> are performed while a mutex is locked. Therefore if *thread A* takes longer
> than expected in performing its network operation, it might block another one
> which does not requires any resource of the first *thread A*. Hence, the
> inter-lock.
> This improvement is the first one of a series regarding to lock scope
> reduction when it comes with code regarding networking in NC.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8553) Reduce ThinClientLocatorHelper lock time
[
https://issues.apache.org/jira/browse/GEODE-8553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206285#comment-17206285
]
ASF GitHub Bot commented on GEODE-8553:
---
gaussianrecurrence commented on a change in pull request #660:
URL: https://github.com/apache/geode-native/pull/660#discussion_r498903370
##
File path: cppcache/src/ThinClientLocatorHelper.hpp
##
@@ -42,38 +43,95 @@ class Connector;
class ThinClientLocatorHelper {
public:
- ThinClientLocatorHelper(const std::vector& locatorAddresses,
+ ThinClientLocatorHelper(const ThinClientLocatorHelper&) = delete;
+ ThinClientLocatorHelper& operator=(const ThinClientLocatorHelper&) = delete;
+
+ ThinClientLocatorHelper(const std::vector& locators,
const ThinClientPoolDM* poolDM);
- ThinClientLocatorHelper(const std::vector& locatorAddresses,
+ ThinClientLocatorHelper(const std::vector& locators,
const std::string& sniProxyHost, int sniProxyPort,
const ThinClientPoolDM* poolDM);
GfErrType getEndpointForNewFwdConn(
ServerLocation& outEndpoint, std::string& additionalLoc,
const std::set& exclEndPts,
const std::string& serverGrp = "",
- const TcrConnection* currentServer = nullptr);
+ const TcrConnection* currentServer = nullptr) const;
GfErrType getEndpointForNewCallBackConn(
ClientProxyMembershipID& memId, std::list& outEndpoint,
std::string& additionalLoc, int redundancy,
- const std::set& exclEndPts, const std::string&
serverGrp);
+ const std::set& exclEndPts,
+ const std::string& serverGrp) const;
GfErrType getAllServers(
std::vector >& servers,
- const std::string& serverGrp);
- int32_t getCurLocatorsNum() {
-return static_cast(m_locHostPort.size());
+ const std::string& serverGrp) const;
+ int32_t getCurLocatorsNum() const {
Review comment:
Sure. Makes total sense
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Reduce ThinClientLocatorHelper lock time
>
>
> Key: GEODE-8553
> URL: https://issues.apache.org/jira/browse/GEODE-8553
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Affects Versions: 1.12.0, 1.13.0
>Reporter: Mario Salazar de Torres
>Assignee: Mario Salazar de Torres
>Priority: Major
> Labels: pull-request-available
>
> During my troublshootings, I've seen that locking m_locatorLock for the whole
> scope of the class function members might cause some inter-locks.
> Problem here and in many other places of the NC is that networking operations
> are performed while a mutex is locked. Therefore if *thread A* takes longer
> than expected in performing its network operation, it might block another one
> which does not requires any resource of the first *thread A*. Hence, the
> inter-lock.
> This improvement is the first one of a series regarding to lock scope
> reduction when it comes with code regarding networking in NC.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8553) Reduce ThinClientLocatorHelper lock time
[
https://issues.apache.org/jira/browse/GEODE-8553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206277#comment-17206277
]
ASF GitHub Bot commented on GEODE-8553:
---
pivotal-jbarrett commented on a change in pull request #660:
URL: https://github.com/apache/geode-native/pull/660#discussion_r498901186
##
File path: cppcache/src/ThinClientLocatorHelper.hpp
##
@@ -42,38 +43,95 @@ class Connector;
class ThinClientLocatorHelper {
public:
- ThinClientLocatorHelper(const std::vector& locatorAddresses,
+ ThinClientLocatorHelper(const ThinClientLocatorHelper&) = delete;
+ ThinClientLocatorHelper& operator=(const ThinClientLocatorHelper&) = delete;
+
+ ThinClientLocatorHelper(const std::vector& locators,
const ThinClientPoolDM* poolDM);
- ThinClientLocatorHelper(const std::vector& locatorAddresses,
+ ThinClientLocatorHelper(const std::vector& locators,
const std::string& sniProxyHost, int sniProxyPort,
const ThinClientPoolDM* poolDM);
GfErrType getEndpointForNewFwdConn(
ServerLocation& outEndpoint, std::string& additionalLoc,
const std::set& exclEndPts,
const std::string& serverGrp = "",
- const TcrConnection* currentServer = nullptr);
+ const TcrConnection* currentServer = nullptr) const;
GfErrType getEndpointForNewCallBackConn(
ClientProxyMembershipID& memId, std::list& outEndpoint,
std::string& additionalLoc, int redundancy,
- const std::set& exclEndPts, const std::string&
serverGrp);
+ const std::set& exclEndPts,
+ const std::string& serverGrp) const;
GfErrType getAllServers(
std::vector >& servers,
- const std::string& serverGrp);
- int32_t getCurLocatorsNum() {
-return static_cast(m_locHostPort.size());
+ const std::string& serverGrp) const;
+ int32_t getCurLocatorsNum() const {
+return static_cast(locators_.size());
}
GfErrType updateLocators(const std::string& serverGrp = "");
private:
- Connector* createConnection(Connector*& conn, const char* hostname,
- int32_t port,
- std::chrono::microseconds waitSeconds,
- int32_t maxBuffSizePool = 0);
- std::mutex m_locatorLock;
- std::vector m_locHostPort;
+ /**
+ * Auxiliary types
+ */
+
+ class ConnectionWrapper {
+ private:
+Connector* conn_;
+
+ public:
+ConnectionWrapper(const ConnectionWrapper&) = delete;
+ConnectionWrapper& operator=(const ConnectionWrapper&) = delete;
+
+explicit ConnectionWrapper(Connector* conn) : conn_(conn) {}
+ConnectionWrapper(ConnectionWrapper&& other)
+: conn_(std::move(other.conn_)) {}
+
+~ConnectionWrapper();
+
+Connector* operator->() { return conn_; }
+ };
+
+ /**
+ * Returns the number of connections retries per request
+ * @return Number of connection retries towards locators
+ */
+ int getConnRetries() const;
Review comment:
Can we have negative retries? Seems like a good place for `size_t` or
some other `uintX_t`.
##
File path: cppcache/src/ThinClientLocatorHelper.hpp
##
@@ -42,38 +43,95 @@ class Connector;
class ThinClientLocatorHelper {
public:
- ThinClientLocatorHelper(const std::vector& locatorAddresses,
+ ThinClientLocatorHelper(const ThinClientLocatorHelper&) = delete;
+ ThinClientLocatorHelper& operator=(const ThinClientLocatorHelper&) = delete;
+
+ ThinClientLocatorHelper(const std::vector& locators,
const ThinClientPoolDM* poolDM);
- ThinClientLocatorHelper(const std::vector& locatorAddresses,
+ ThinClientLocatorHelper(const std::vector& locators,
const std::string& sniProxyHost, int sniProxyPort,
const ThinClientPoolDM* poolDM);
GfErrType getEndpointForNewFwdConn(
ServerLocation& outEndpoint, std::string& additionalLoc,
const std::set& exclEndPts,
const std::string& serverGrp = "",
- const TcrConnection* currentServer = nullptr);
+ const TcrConnection* currentServer = nullptr) const;
GfErrType getEndpointForNewCallBackConn(
ClientProxyMembershipID& memId, std::list& outEndpoint,
std::string& additionalLoc, int redundancy,
- const std::set& exclEndPts, const std::string&
serverGrp);
+ const std::set& exclEndPts,
+ const std::string& serverGrp) const;
GfErrType getAllServers(
std::vector >& servers,
- const std::string& serverGrp);
- int32_t getCurLocatorsNum() {
-return static_cast(m_locHostPort.size());
+ const std::string& serverGrp) const;
+ int32_t getCurLocatorsNum() const {
Review comment:
We should just change the signature to return `size_t`, this `int32_t`
is just old code hanging around.
This is
[jira] [Resolved] (GEODE-8519) Geode Native Client user guide: delete unused sources (round 2)
[ https://issues.apache.org/jira/browse/GEODE-8519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender resolved GEODE-8519. - Resolution: Fixed > Geode Native Client user guide: delete unused sources (round 2) > --- > > Key: GEODE-8519 > URL: https://issues.apache.org/jira/browse/GEODE-8519 > Project: Geode > Issue Type: Bug > Components: docs, native client >Reporter: Dave Barnes >Assignee: Dave Barnes >Priority: Major > Labels: pull-request-available > > The geode-native docs directory contains unused sources from the > pre-open-source days. The problem is that while they're not linked to the > user guide's T of C, these out-of-date docs are still included in the manual > build (a quirk of the toolset), where they can be accidentally discovered via > web searches. > These unused files need to be identified and deleted. > GEODE-8388 took care of some of these files. There's another group under > 'preserving data' that need to go. The user guide contains two links on the > Continuous Queries page that will need to be removed. > Also, need to remove a link to Durable Client Messaging from the > "Subscription Properties" page. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (GEODE-8519) Geode Native Client user guide: delete unused sources (round 2)
[ https://issues.apache.org/jira/browse/GEODE-8519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender closed GEODE-8519. --- > Geode Native Client user guide: delete unused sources (round 2) > --- > > Key: GEODE-8519 > URL: https://issues.apache.org/jira/browse/GEODE-8519 > Project: Geode > Issue Type: Bug > Components: docs, native client >Reporter: Dave Barnes >Assignee: Dave Barnes >Priority: Major > Labels: pull-request-available > > The geode-native docs directory contains unused sources from the > pre-open-source days. The problem is that while they're not linked to the > user guide's T of C, these out-of-date docs are still included in the manual > build (a quirk of the toolset), where they can be accidentally discovered via > web searches. > These unused files need to be identified and deleted. > GEODE-8388 took care of some of these files. There's another group under > 'preserving data' that need to go. The user guide contains two links on the > Continuous Queries page that will need to be removed. > Also, need to remove a link to Durable Client Messaging from the > "Subscription Properties" page. -- This message was sent by Atlassian Jira (v8.3.4#803005)
