[jira] [Commented] (GEODE-8838) Provide some ability to launch ChildVM with specific port for RemoteDUnitVM stub

2021-01-18 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267655#comment-17267655
 ] 

ASF subversion and git services commented on GEODE-8838:


Commit c34d5c2db23c17c196bd86502e281df820a3d9fa in geode's branch 
refs/heads/develop from Jens Deppe
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=c34d5c2 ]

GEODE-8838: Provide some ability to launch ChildVM with specific port for 
RemoteDUnitVM stub (#5909)

- This change is intended to address an issue with port bind conflicts
  specifically when VMs are restarted. Thus this change only specifies a
  specific port when bouncing a VM. In this case we use a RMI port
  outside the usual range of ephemeral ports for MacOS (49152–65535) and
  Linux (32768-60999).
- We typically try and use ephemeral ports everywhere. However,
  sometimes an ephemeral port created during a prior start needs to be
  used as a fixed port on subsequent bounces. In this case, ephemeral
  ports that are allocated early may end up conflicting with these fixed
  ports.
- Remove various unused methods related to bounce()ing VMs.


> Provide some ability to launch ChildVM with specific port for RemoteDUnitVM 
> stub
> 
>
> Key: GEODE-8838
> URL: https://issues.apache.org/jira/browse/GEODE-8838
> Project: Geode
>  Issue Type: Test
>  Components: tests
>Reporter: Jens Deppe
>Priority: Major
>  Labels: pull-request-available
>
> This change is intended to address an issue with port bind conflicts
>  specifically when VMs are restarted. Thus this change only specifies a
>  specific port when bouncing a VM. In this case we use a RMI port
>  outside the usual range of ephemeral ports for MacOS (49152–65535) and
>  Linux (32768-60999).
> We typically try and use ephemeral ports everywhere. However,
>  sometimes an ephemeral port created during a prior start needs to be
>  used as a fixed port on subsequent bounces. In this case, ephemeral
>  ports that are allocated early may end up conflicting with these fixed
>  ports.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8838) Provide some ability to launch ChildVM with specific port for RemoteDUnitVM stub

2021-01-18 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267652#comment-17267652
 ] 

ASF GitHub Bot commented on GEODE-8838:
---

jdeppe-pivotal merged pull request #5909:
URL: https://github.com/apache/geode/pull/5909


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Provide some ability to launch ChildVM with specific port for RemoteDUnitVM 
> stub
> 
>
> Key: GEODE-8838
> URL: https://issues.apache.org/jira/browse/GEODE-8838
> Project: Geode
>  Issue Type: Test
>  Components: tests
>Reporter: Jens Deppe
>Priority: Major
>  Labels: pull-request-available
>
> This change is intended to address an issue with port bind conflicts
>  specifically when VMs are restarted. Thus this change only specifies a
>  specific port when bouncing a VM. In this case we use a RMI port
>  outside the usual range of ephemeral ports for MacOS (49152–65535) and
>  Linux (32768-60999).
> We typically try and use ephemeral ports everywhere. However,
>  sometimes an ephemeral port created during a prior start needs to be
>  used as a fixed port on subsequent bounces. In this case, ephemeral
>  ports that are allocated early may end up conflicting with these fixed
>  ports.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8496) bump dependencies for 1.14

2021-01-18 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267643#comment-17267643
 ] 

ASF GitHub Bot commented on GEODE-8496:
---

onichols-pivotal opened a new pull request #5919:
URL: https://github.com/apache/geode/pull/5919


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> bump dependencies for 1.14
> --
>
> Key: GEODE-8496
> URL: https://issues.apache.org/jira/browse/GEODE-8496
> Project: Geode
>  Issue Type: Improvement
>  Components: build
>Reporter: Owen Nichols
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> now is a good time in the lull between 1.13 and 1.14 to roll 3rd party 
> libraries to latest versions wherever possible.  Doing this proactively helps 
> us stay ahead of CVEs and keep up with bugfixes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8562) Add a new serialization test and example that uses a class for the key

2021-01-18 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267589#comment-17267589
 ] 

ASF GitHub Bot commented on GEODE-8562:
---

lgtm-com[bot] commented on pull request #725:
URL: https://github.com/apache/geode-native/pull/725#issuecomment-762546481


   This pull request **introduces 1 alert** when merging 
db24dbd4abe66e151eb13d5495c5bd9e99fc8a91 into 
ec823095d0efe74e025d773b7bffefadc9261f70 - [view on 
LGTM.com](https://lgtm.com/projects/g/apache/geode-native/rev/pr-d2d78abaa1fd1c6289e6c364c2d3c96c0b77f75b)
   
   **new alerts:**
   
   * 1 for Dereferenced variable may be null



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add a new serialization test and example that uses a class for the key
> --
>
> Key: GEODE-8562
> URL: https://issues.apache.org/jira/browse/GEODE-8562
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Michael Martell
>Priority: Major
>  Labels: pull-request-available
>
> There appears to be no native client tests that use a class for the key.
> A new DataSerializable test should be added (new framework of course) that 
> uses a class that implements DataSerializable for both the key and the value. 
> Also, the test should be added for both C++ and .NET.
> Also update the existing put/get examples to include using a class as the 
> key. Note, this will require Java code that instantiates the key class.
> Notes:
>  * 
>  Using a class as a key requires the equivalent Java class to be deployed, as 
> well as an Instantiator for that class to be executed by the server on 
> startup. An example of this is the 
> QueryTest::DataSerializableQueryHaveCorrectValues which uses Position.cs and 
> Position.java.
>  * In this existing test, Position.java needs to be deployed and instantiated 
> because the test executes queries. In this new test, we need to deploy and 
> instantiate the java code for the key class because it's a key not a value.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8562) Add a new serialization test and example that uses a class for the key

2021-01-18 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267583#comment-17267583
 ] 

ASF GitHub Bot commented on GEODE-8562:
---

mmartell opened a new pull request #725:
URL: https://github.com/apache/geode-native/pull/725


   This adds a new C# example that illustrates how to use a class as a key.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add a new serialization test and example that uses a class for the key
> --
>
> Key: GEODE-8562
> URL: https://issues.apache.org/jira/browse/GEODE-8562
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Michael Martell
>Priority: Major
>  Labels: pull-request-available
>
> There appears to be no native client tests that use a class for the key.
> A new DataSerializable test should be added (new framework of course) that 
> uses a class that implements DataSerializable for both the key and the value. 
> Also, the test should be added for both C++ and .NET.
> Also update the existing put/get examples to include using a class as the 
> key. Note, this will require Java code that instantiates the key class.
> Notes:
>  * 
>  Using a class as a key requires the equivalent Java class to be deployed, as 
> well as an Instantiator for that class to be executed by the server on 
> startup. An example of this is the 
> QueryTest::DataSerializableQueryHaveCorrectValues which uses Position.cs and 
> Position.java.
>  * In this existing test, Position.java needs to be deployed and instantiated 
> because the test executes queries. In this new test, we need to deploy and 
> instantiate the java code for the key class because it's a key not a value.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8834) redis testing fails due to image pull failure

2021-01-18 Thread Geode Integration (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267574#comment-17267574
 ] 

Geode Integration commented on GEODE-8834:
--

Seen in [UpgradeTestOpenJDK8 
#692|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/UpgradeTestOpenJDK8/builds/692]
 ... see [test 
results|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0616/test-results/upgradeTest/1610943813/]
 or download 
[artifacts|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0616/test-artifacts/1610943813/upgradetestfiles-OpenJDK8-1.14.0-build.0616.tgz].

> redis testing fails due to image pull failure
> -
>
> Key: GEODE-8834
> URL: https://issues.apache.org/jira/browse/GEODE-8834
> Project: Geode
>  Issue Type: Bug
>  Components: ci
>Affects Versions: 1.12.0, 1.13.0, 1.13.1
>Reporter: Sean Goller
>Assignee: Sean Goller
>Priority: Major
>
> Redis testing uses quay.io/testingcontaiiners/ryuk:0.2.3. When acceptanceTest 
> tries to pull this image, it fails for some reason. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8834) redis testing fails due to image pull failure

2021-01-18 Thread Geode Integration (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267573#comment-17267573
 ] 

Geode Integration commented on GEODE-8834:
--

Seen in [UpgradeTestOpenJDK8 
#693|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/UpgradeTestOpenJDK8/builds/693]
 ... see [test 
results|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0616/test-results/upgradeTest/1610959194/]
 or download 
[artifacts|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0616/test-artifacts/1610959194/upgradetestfiles-OpenJDK8-1.14.0-build.0616.tgz].

> redis testing fails due to image pull failure
> -
>
> Key: GEODE-8834
> URL: https://issues.apache.org/jira/browse/GEODE-8834
> Project: Geode
>  Issue Type: Bug
>  Components: ci
>Affects Versions: 1.12.0, 1.13.0, 1.13.1
>Reporter: Sean Goller
>Assignee: Sean Goller
>Priority: Major
>
> Redis testing uses quay.io/testingcontaiiners/ryuk:0.2.3. When acceptanceTest 
> tries to pull this image, it fails for some reason. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8834) redis testing fails due to image pull failure

2021-01-18 Thread Geode Integration (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267572#comment-17267572
 ] 

Geode Integration commented on GEODE-8834:
--

Seen in [IntegrationTestOpenJDK8 
#687|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/IntegrationTestOpenJDK8/builds/687]
 ... see [test 
results|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0617/test-results/integrationTest/1610976787/]
 or download 
[artifacts|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0617/test-artifacts/1610976787/integrationtestfiles-OpenJDK8-1.14.0-build.0617.tgz].

> redis testing fails due to image pull failure
> -
>
> Key: GEODE-8834
> URL: https://issues.apache.org/jira/browse/GEODE-8834
> Project: Geode
>  Issue Type: Bug
>  Components: ci
>Affects Versions: 1.12.0, 1.13.0, 1.13.1
>Reporter: Sean Goller
>Assignee: Sean Goller
>Priority: Major
>
> Redis testing uses quay.io/testingcontaiiners/ryuk:0.2.3. When acceptanceTest 
> tries to pull this image, it fails for some reason. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8834) redis testing fails due to image pull failure

2021-01-18 Thread Geode Integration (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267571#comment-17267571
 ] 

Geode Integration commented on GEODE-8834:
--

Seen in [UpgradeTestOpenJDK11 
#696|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/UpgradeTestOpenJDK11/builds/696]
 ... see [test 
results|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0617/test-results/upgradeTest/1610979916/]
 or download 
[artifacts|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0617/test-artifacts/1610979916/upgradetestfiles-OpenJDK11-1.14.0-build.0617.tgz].

> redis testing fails due to image pull failure
> -
>
> Key: GEODE-8834
> URL: https://issues.apache.org/jira/browse/GEODE-8834
> Project: Geode
>  Issue Type: Bug
>  Components: ci
>Affects Versions: 1.12.0, 1.13.0, 1.13.1
>Reporter: Sean Goller
>Assignee: Sean Goller
>Priority: Major
>
> Redis testing uses quay.io/testingcontaiiners/ryuk:0.2.3. When acceptanceTest 
> tries to pull this image, it fails for some reason. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8834) redis testing fails due to image pull failure

2021-01-18 Thread Geode Integration (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267570#comment-17267570
 ] 

Geode Integration commented on GEODE-8834:
--

Seen in [UpgradeTestOpenJDK8 
#694|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/UpgradeTestOpenJDK8/builds/694]
 ... see [test 
results|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0617/test-results/upgradeTest/1610980051/]
 or download 
[artifacts|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0617/test-artifacts/1610980051/upgradetestfiles-OpenJDK8-1.14.0-build.0617.tgz].

> redis testing fails due to image pull failure
> -
>
> Key: GEODE-8834
> URL: https://issues.apache.org/jira/browse/GEODE-8834
> Project: Geode
>  Issue Type: Bug
>  Components: ci
>Affects Versions: 1.12.0, 1.13.0, 1.13.1
>Reporter: Sean Goller
>Priority: Major
>
> Redis testing uses quay.io/testingcontaiiners/ryuk:0.2.3. When acceptanceTest 
> tries to pull this image, it fails for some reason. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (GEODE-8834) redis testing fails due to image pull failure

2021-01-18 Thread Xiaojian Zhou (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xiaojian Zhou reassigned GEODE-8834:


Assignee: Sean Goller

> redis testing fails due to image pull failure
> -
>
> Key: GEODE-8834
> URL: https://issues.apache.org/jira/browse/GEODE-8834
> Project: Geode
>  Issue Type: Bug
>  Components: ci
>Affects Versions: 1.12.0, 1.13.0, 1.13.1
>Reporter: Sean Goller
>Assignee: Sean Goller
>Priority: Major
>
> Redis testing uses quay.io/testingcontaiiners/ryuk:0.2.3. When acceptanceTest 
> tries to pull this image, it fails for some reason. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear

2021-01-18 Thread Xiaojian Zhou (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267569#comment-17267569
 ] 

Xiaojian Zhou commented on GEODE-8334:
--

Sean's merge belongs to GEODE-8834. 

> Primary and secondary bucket data mismatch with concurrent putAll/removeAll 
> and PR.clear 
> -
>
> Key: GEODE-8334
> URL: https://issues.apache.org/jira/browse/GEODE-8334
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI, pull-request-available
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8837) Establish GFE_82 as the oldest supported client version.

2021-01-18 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267568#comment-17267568
 ] 

ASF GitHub Bot commented on GEODE-8837:
---

lgtm-com[bot] commented on pull request #5905:
URL: https://github.com/apache/geode/pull/5905#issuecomment-762516462


   This pull request **fixes 4 alerts** when merging 
a81c23ae4b4c686332a57e44699224faf33feb43 into 
3927ba9eeed5bee7e7639f926b48409c4b6dd3a7 - [view on 
LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-37f1733e3910192be3f38db87991d979ed2a6b3a)
   
   **fixed alerts:**
   
   * 4 for Dereferenced variable may be null



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Establish GFE_82 as the oldest supported client version.
> 
>
> Key: GEODE-8837
> URL: https://issues.apache.org/jira/browse/GEODE-8837
> Project: Geode
>  Issue Type: Improvement
>  Components: client/server, core, cq, functions
>Reporter: Jacob Barrett
>Priority: Major
>  Labels: pull-request-available
>
> Remove support for versions older than GFE_82 in backwards compatibility 
> checks and command tables.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8837) Establish GFE_82 as the oldest supported client version.

2021-01-18 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267536#comment-17267536
 ] 

ASF GitHub Bot commented on GEODE-8837:
---

lgtm-com[bot] commented on pull request #5905:
URL: https://github.com/apache/geode/pull/5905#issuecomment-762474943


   This pull request **fixes 4 alerts** when merging 
01370eaf78db9e08ece730454bec25ea157d602f into 
3927ba9eeed5bee7e7639f926b48409c4b6dd3a7 - [view on 
LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-23fae8f674f95faf2f82bd2ad2d216aa8496d43e)
   
   **fixed alerts:**
   
   * 4 for Dereferenced variable may be null



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Establish GFE_82 as the oldest supported client version.
> 
>
> Key: GEODE-8837
> URL: https://issues.apache.org/jira/browse/GEODE-8837
> Project: Geode
>  Issue Type: Improvement
>  Components: client/server, core, cq, functions
>Reporter: Jacob Barrett
>Priority: Major
>  Labels: pull-request-available
>
> Remove support for versions older than GFE_82 in backwards compatibility 
> checks and command tables.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8845) Add Missing public Declarations for .NET Cacheables

2021-01-18 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267495#comment-17267495
 ] 

ASF GitHub Bot commented on GEODE-8845:
---

codecov-io commented on pull request #724:
URL: https://github.com/apache/geode-native/pull/724#issuecomment-762443413


   # [Codecov](https://codecov.io/gh/apache/geode-native/pull/724?src=pr=h1) 
Report
   > Merging 
[#724](https://codecov.io/gh/apache/geode-native/pull/724?src=pr=desc) 
(e40034c) into 
[develop](https://codecov.io/gh/apache/geode-native/commit/c1886061ff94e328d4675206b34c3a4868510600?el=desc)
 (c188606) will **decrease** coverage by `0.09%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/geode-native/pull/724/graphs/tree.svg?width=650=150=pr=plpAqoqGag)](https://codecov.io/gh/apache/geode-native/pull/724?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   develop #724  +/-   ##
   ===
   - Coverage74.08%   73.99%   -0.10% 
   ===
 Files  645  645  
 Lines5085850858  
   ===
   - Hits 3768037634  -46 
   - Misses   1317813224  +46 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/geode-native/pull/724?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[cppcache/src/ReadWriteLock.cpp](https://codecov.io/gh/apache/geode-native/pull/724/diff?src=pr=tree#diff-Y3BwY2FjaGUvc3JjL1JlYWRXcml0ZUxvY2suY3Bw)
 | `81.25% <0.00%> (-18.75%)` | :arrow_down: |
   | 
[cppcache/src/TcrEndpoint.cpp](https://codecov.io/gh/apache/geode-native/pull/724/diff?src=pr=tree#diff-Y3BwY2FjaGUvc3JjL1RjckVuZHBvaW50LmNwcA==)
 | `54.36% <0.00%> (-2.82%)` | :arrow_down: |
   | 
[cppcache/src/TcrConnection.cpp](https://codecov.io/gh/apache/geode-native/pull/724/diff?src=pr=tree#diff-Y3BwY2FjaGUvc3JjL1RjckNvbm5lY3Rpb24uY3Bw)
 | `71.11% <0.00%> (-1.67%)` | :arrow_down: |
   | 
[cppcache/src/ThinClientLocatorHelper.cpp](https://codecov.io/gh/apache/geode-native/pull/724/diff?src=pr=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRMb2NhdG9ySGVscGVyLmNwcA==)
 | `92.14% <0.00%> (-0.72%)` | :arrow_down: |
   | 
[cppcache/src/ClientMetadata.cpp](https://codecov.io/gh/apache/geode-native/pull/724/diff?src=pr=tree#diff-Y3BwY2FjaGUvc3JjL0NsaWVudE1ldGFkYXRhLmNwcA==)
 | `65.16% <0.00%> (-0.57%)` | :arrow_down: |
   | 
[cppcache/src/ThinClientRedundancyManager.cpp](https://codecov.io/gh/apache/geode-native/pull/724/diff?src=pr=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRSZWR1bmRhbmN5TWFuYWdlci5jcHA=)
 | `75.27% <0.00%> (-0.47%)` | :arrow_down: |
   | 
[cppcache/src/ClientMetadataService.cpp](https://codecov.io/gh/apache/geode-native/pull/724/diff?src=pr=tree#diff-Y3BwY2FjaGUvc3JjL0NsaWVudE1ldGFkYXRhU2VydmljZS5jcHA=)
 | `62.24% <0.00%> (-0.46%)` | :arrow_down: |
   | 
[cppcache/src/ThinClientPoolDM.cpp](https://codecov.io/gh/apache/geode-native/pull/724/diff?src=pr=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRQb29sRE0uY3Bw)
 | `76.31% <0.00%> (-0.43%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/geode-native/pull/724?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/geode-native/pull/724?src=pr=footer). 
Last update 
[c188606...e40034c](https://codecov.io/gh/apache/geode-native/pull/724?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add Missing public Declarations for .NET Cacheables
> ---
>
> Key: GEODE-8845
> URL: https://issues.apache.org/jira/browse/GEODE-8845
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Michael Martell
>Priority: Minor
>  Labels: pull-request-available
>
> The .NET APIs provide Cacheable types (e.g. CacheableString) for the standard 
> .NET types. However, several of them are missing the public declarations, 
> making them inaccessible. 
> These classes provide a hashCode() function that matches the corresponding 
> hashCode on the server side. It would be nice to be able to leverage these 
> functions when using these types in a key class. I discovered this when 
> 

[jira] [Commented] (GEODE-8845) Add Missing public Declarations for .NET Cacheables

2021-01-18 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267461#comment-17267461
 ] 

ASF GitHub Bot commented on GEODE-8845:
---

mmartell opened a new pull request #724:
URL: https://github.com/apache/geode-native/pull/724


   Several of the provided .NET Cacheable types were missing the public 
attribute. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add Missing public Declarations for .NET Cacheables
> ---
>
> Key: GEODE-8845
> URL: https://issues.apache.org/jira/browse/GEODE-8845
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Michael Martell
>Priority: Minor
>
> The .NET APIs provide Cacheable types (e.g. CacheableString) for the standard 
> .NET types. However, several of them are missing the public declarations, 
> making them inaccessible. 
> These classes provide a hashCode() function that matches the corresponding 
> hashCode on the server side. It would be nice to be able to leverage these 
> functions when using these types in a key class. I discovered this when 
> implementing a new ClassAsKey example.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (GEODE-8845) Add Missing public Declarations for .NET Cacheables

2021-01-18 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated GEODE-8845:
--
Labels: pull-request-available  (was: )

> Add Missing public Declarations for .NET Cacheables
> ---
>
> Key: GEODE-8845
> URL: https://issues.apache.org/jira/browse/GEODE-8845
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Michael Martell
>Priority: Minor
>  Labels: pull-request-available
>
> The .NET APIs provide Cacheable types (e.g. CacheableString) for the standard 
> .NET types. However, several of them are missing the public declarations, 
> making them inaccessible. 
> These classes provide a hashCode() function that matches the corresponding 
> hashCode on the server side. It would be nice to be able to leverage these 
> functions when using these types in a key class. I discovered this when 
> implementing a new ClassAsKey example.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (GEODE-8845) Add Missing public Declarations for .NET Cacheables

2021-01-18 Thread Michael Martell (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Martell updated GEODE-8845:
---
Priority: Minor  (was: Major)

> Add Missing public Declarations for .NET Cacheables
> ---
>
> Key: GEODE-8845
> URL: https://issues.apache.org/jira/browse/GEODE-8845
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Michael Martell
>Priority: Minor
>
> The .NET APIs provide Cacheable types (e.g. CacheableString) for the standard 
> .NET types. However, several of them are missing the public declarations, 
> making them inaccessible. 
> These classes provide a hashCode() function that matches the corresponding 
> hashCode on the server side. It would be nice to be able to leverage these 
> functions when using these types in a key class. I discovered this when 
> implementing a new ClassAsKey example.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (GEODE-8845) Add Missing public Declarations for .NET Cacheables

2021-01-18 Thread Michael Martell (Jira)
Michael Martell created GEODE-8845:
--

 Summary: Add Missing public Declarations for .NET Cacheables
 Key: GEODE-8845
 URL: https://issues.apache.org/jira/browse/GEODE-8845
 Project: Geode
  Issue Type: Bug
  Components: native client
Reporter: Michael Martell


The .NET APIs provide Cacheable types (e.g. CacheableString) for the standard 
.NET types. However, several of them are missing the public declarations, 
making them inaccessible. 

These classes provide a hashCode() function that matches the corresponding 
hashCode on the server side. It would be nice to be able to leverage these 
functions when using these types in a key class. I discovered this when 
implementing a new ClassAsKey example.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8837) Establish GFE_82 as the oldest supported client version.

2021-01-18 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267438#comment-17267438
 ] 

ASF GitHub Bot commented on GEODE-8837:
---

lgtm-com[bot] commented on pull request #5905:
URL: https://github.com/apache/geode/pull/5905#issuecomment-762395380


   This pull request **fixes 4 alerts** when merging 
0bd64f688ae323e52c959a9ebd98f5d78a5309f0 into 
3927ba9eeed5bee7e7639f926b48409c4b6dd3a7 - [view on 
LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-19b365e842535380660a00110ab8f690ba69eb15)
   
   **fixed alerts:**
   
   * 4 for Dereferenced variable may be null



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Establish GFE_82 as the oldest supported client version.
> 
>
> Key: GEODE-8837
> URL: https://issues.apache.org/jira/browse/GEODE-8837
> Project: Geode
>  Issue Type: Improvement
>  Components: client/server, core, cq, functions
>Reporter: Jacob Barrett
>Priority: Major
>  Labels: pull-request-available
>
> Remove support for versions older than GFE_82 in backwards compatibility 
> checks and command tables.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8202) New option for serial gw sender threads start when receivers share ip and port

2021-01-18 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267256#comment-17267256
 ] 

ASF subversion and git services commented on GEODE-8202:


Commit 3927ba9eeed5bee7e7639f926b48409c4b6dd3a7 in geode's branch 
refs/heads/develop from Alberto Bustamante Reyes
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=3927ba9 ]

GEODE-8202: Two-step serial gw sender threads start (#5900)

* GEODE-8202: Two-step serial gw sender threads start

> New option for serial gw sender threads start when receivers share ip and port
> --
>
> Key: GEODE-8202
> URL: https://issues.apache.org/jira/browse/GEODE-8202
> Project: Geode
>  Issue Type: Improvement
>Reporter: Alberto Bustamante Reyes
>Assignee: Alberto Bustamante Reyes
>Priority: Major
>  Labels: pull-request-available
>
> RFC: 
> [https://cwiki.apache.org/confluence/display/GEODE/New+option+for+serial+gw+sender+dispatcher+threads+start|https://cwiki.apache.org/confluence/display/GEODE/New+option+for+serial+gw+sender+dispatcher+threads+start]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8202) New option for serial gw sender threads start when receivers share ip and port

2021-01-18 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267257#comment-17267257
 ] 

ASF subversion and git services commented on GEODE-8202:


Commit 3927ba9eeed5bee7e7639f926b48409c4b6dd3a7 in geode's branch 
refs/heads/develop from Alberto Bustamante Reyes
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=3927ba9 ]

GEODE-8202: Two-step serial gw sender threads start (#5900)

* GEODE-8202: Two-step serial gw sender threads start

> New option for serial gw sender threads start when receivers share ip and port
> --
>
> Key: GEODE-8202
> URL: https://issues.apache.org/jira/browse/GEODE-8202
> Project: Geode
>  Issue Type: Improvement
>Reporter: Alberto Bustamante Reyes
>Assignee: Alberto Bustamante Reyes
>Priority: Major
>  Labels: pull-request-available
>
> RFC: 
> [https://cwiki.apache.org/confluence/display/GEODE/New+option+for+serial+gw+sender+dispatcher+threads+start|https://cwiki.apache.org/confluence/display/GEODE/New+option+for+serial+gw+sender+dispatcher+threads+start]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8202) New option for serial gw sender threads start when receivers share ip and port

2021-01-18 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267255#comment-17267255
 ] 

ASF GitHub Bot commented on GEODE-8202:
---

mkevo merged pull request #5900:
URL: https://github.com/apache/geode/pull/5900


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> New option for serial gw sender threads start when receivers share ip and port
> --
>
> Key: GEODE-8202
> URL: https://issues.apache.org/jira/browse/GEODE-8202
> Project: Geode
>  Issue Type: Improvement
>Reporter: Alberto Bustamante Reyes
>Assignee: Alberto Bustamante Reyes
>Priority: Major
>  Labels: pull-request-available
>
> RFC: 
> [https://cwiki.apache.org/confluence/display/GEODE/New+option+for+serial+gw+sender+dispatcher+threads+start|https://cwiki.apache.org/confluence/display/GEODE/New+option+for+serial+gw+sender+dispatcher+threads+start]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)