[ https://issues.apache.org/jira/browse/GEODE-3077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Galen O'Sullivan resolved GEODE-3077. ------------------------------------- Resolution: Duplicate Fix Version/s: 1.3.0 > Client connection counts should be accurate > ------------------------------------------- > > Key: GEODE-3077 > URL: https://issues.apache.org/jira/browse/GEODE-3077 > Project: Geode > Issue Type: Sub-task > Components: client/server > Reporter: Galen O'Sullivan > Fix For: 1.3.0 > > > As a dev user of Geode, I want to be able to look at connection counts and > know they are reliable (no matter if I'm using the new client/server protocol > or the old). Revisit connection-counting-related methods and ensure the > counting mechanism is accurate. > Specifically: > Have a look at where and how the following three functions are used: > {code} > public void incClientServerCnxCount() { > this.clientServerCnxCount.incrementAndGet(); > } > public void decClientServerCnxCount() { > this.clientServerCnxCount.decrementAndGet(); > } > public int getClientServerCnxCount() { > return this.clientServerCnxCount.get(); > } > {code} > These are tracking client-server connections. Extract these into common code > in {{ServerConnection}} that both {{NewClientServerConnection}} and > {{LegacyServerConnection}} can use, and make sure that counts are correct in > both creation and cleanup situations. Write some tests to verify. > Note: client counts look to be tracked separately from connection counts; the > old protocol can have multiple connections per client. We're interested with > the connection count in this ticket. -- This message was sent by Atlassian JIRA (v6.4.14#64029)