[jira] [Updated] (GEODE-10328) Cache close with partitioned regions does not close all the region's statistics
[ https://issues.apache.org/jira/browse/GEODE-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Darrel Schneider updated GEODE-10328: - Fix Version/s: 1.15.0 > Cache close with partitioned regions does not close all the region's > statistics > --- > > Key: GEODE-10328 > URL: https://issues.apache.org/jira/browse/GEODE-10328 > Project: Geode > Issue Type: Bug > Components: core >Reporter: Darrel Schneider >Assignee: Darrel Schneider >Priority: Major > Labels: pull-request-available > Fix For: 1.15.0, 1.16.0 > > > I noticed when looking at hprof memory dumps of a JVM whose cache had been > closed that something was keeping the PartitionedRegion instances from being > garbage collected. It turns out that the region's RegionPerfStats instance > was not closed. Other stats for the region were closed but not the one owned > by PartitionedRegionDataStore's bucketStats instance variable. This > indicates that the PartitionedRegionDataStore.cleanUp method is not being > called. > It looks like the bug is in: PartitionedRegion.postDestroyRegion. It has a > code path that handles Operation.CACHE_CLOSE and Operation.FORCED_DISCONNECT > without calling "closePartitionedRegion" which invokes "dataStore.cleanup". > This buggy code path has its reasons for not calling closePartitionedRegion. > To fix this bug it would be easy and safe to have this code path call > dataStore.getCachePerfStats().close() -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (GEODE-10328) Cache close with partitioned regions does not close all the region's statistics
[ https://issues.apache.org/jira/browse/GEODE-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-10328: --- Labels: pull-request-available (was: ) > Cache close with partitioned regions does not close all the region's > statistics > --- > > Key: GEODE-10328 > URL: https://issues.apache.org/jira/browse/GEODE-10328 > Project: Geode > Issue Type: Bug > Components: core >Reporter: Darrel Schneider >Assignee: Darrel Schneider >Priority: Major > Labels: pull-request-available > > I noticed when looking at hprof memory dumps of a JVM whose cache had been > closed that something was keeping the PartitionedRegion instances from being > garbage collected. It turns out that the region's RegionPerfStats instance > was not closed. Other stats for the region were closed but not the one owned > by PartitionedRegionDataStore's bucketStats instance variable. This > indicates that the PartitionedRegionDataStore.cleanUp method is not being > called. > It looks like the bug is in: PartitionedRegion.postDestroyRegion. It has a > code path that handles Operation.CACHE_CLOSE and Operation.FORCED_DISCONNECT > without calling "closePartitionedRegion" which invokes "dataStore.cleanup". > This buggy code path has its reasons for not calling closePartitionedRegion. > To fix this bug it would be easy and safe to have this code path call > dataStore.getCachePerfStats().close() -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (GEODE-10328) Cache close with partitioned regions does not close all the region's statistics
[ https://issues.apache.org/jira/browse/GEODE-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Darrel Schneider updated GEODE-10328: - Labels: (was: needsTriage) > Cache close with partitioned regions does not close all the region's > statistics > --- > > Key: GEODE-10328 > URL: https://issues.apache.org/jira/browse/GEODE-10328 > Project: Geode > Issue Type: Bug > Components: core >Reporter: Darrel Schneider >Assignee: Darrel Schneider >Priority: Major > > I noticed when looking at hprof memory dumps of a JVM whose cache had been > closed that something was keeping the PartitionedRegion instances from being > garbage collected. It turns out that the region's RegionPerfStats instance > was not closed. Other stats for the region were closed but not the one owned > by PartitionedRegionDataStore's bucketStats instance variable. This > indicates that the PartitionedRegionDataStore.cleanUp method is not being > called. > It looks like the bug is in: PartitionedRegion.postDestroyRegion. It has a > code path that handles Operation.CACHE_CLOSE and Operation.FORCED_DISCONNECT > without calling "closePartitionedRegion" which invokes "dataStore.cleanup". > This buggy code path has its reasons for not calling closePartitionedRegion. > To fix this bug it would be easy and safe to have this code path call > dataStore.getCachePerfStats().close() -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (GEODE-10328) Cache close with partitioned regions does not close all the region's statistics
[ https://issues.apache.org/jira/browse/GEODE-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Murmann updated GEODE-10328: -- Labels: needsTriage (was: ) > Cache close with partitioned regions does not close all the region's > statistics > --- > > Key: GEODE-10328 > URL: https://issues.apache.org/jira/browse/GEODE-10328 > Project: Geode > Issue Type: Bug > Components: core >Reporter: Darrel Schneider >Priority: Major > Labels: needsTriage > > I noticed when looking at hprof memory dumps of a JVM whose cache had been > closed that something was keeping the PartitionedRegion instances from being > garbage collected. It turns out that the region's RegionPerfStats instance > was not closed. Other stats for the region were closed but not the one owned > by PartitionedRegionDataStore's bucketStats instance variable. This > indicates that the PartitionedRegionDataStore.cleanUp method is not being > called. > It looks like the bug is in: PartitionedRegion.postDestroyRegion. It has a > code path that handles Operation.CACHE_CLOSE and Operation.FORCED_DISCONNECT > without calling "closePartitionedRegion" which invokes "dataStore.cleanup". > This buggy code path has its reasons for not calling closePartitionedRegion. > To fix this bug it would be easy and safe to have this code path call > dataStore.getCachePerfStats().close() -- This message was sent by Atlassian Jira (v8.20.7#820007)
