[jira] [Updated] (GEODE-4115) Remove nullability of InternalLocator.myDS

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated GEODE-4115:
--
Labels: pull-request-available  (was: )

> Remove nullability of InternalLocator.myDS
> --
>
> Key: GEODE-4115
> URL: https://issues.apache.org/jira/browse/GEODE-4115
> Project: Geode
>  Issue Type: Improvement
>  Components: client/server
>Reporter: Galen O'Sullivan
>Assignee: Michael Dodge
>Priority: Major
>  Labels: pull-request-available
>
> {code}
>   /**
>* The distributed system owned by this locator, if any. Note that if a ds 
> already exists because
>* the locator is being colocated in a normal member this field will be 
> null.
>*/
>   private InternalDistributedSystem myDs;
> {code}
> I don't think that this should be nullable. It makes things more complicated 
> -- when we start a colocated locator, the protobuf protocol statistics 
> initialization has to check {{InternalDistributedSystem.getAnyInstance()}} to 
> get a DS. Can that call be null? I'm not sure.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (GEODE-4115) Remove nullability of InternalLocator.myDS

[Galen O'Sullivan (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-4115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Galen O'Sullivan updated GEODE-4115:

Issue Type: Improvement  (was: Bug)

> Remove nullability of InternalLocator.myDS
> --
>
> Key: GEODE-4115
> URL: https://issues.apache.org/jira/browse/GEODE-4115
> Project: Geode
>  Issue Type: Improvement
>  Components: client/server
>Reporter: Galen O'Sullivan
>
> {code}
>   /**
>* The distributed system owned by this locator, if any. Note that if a ds 
> already exists because
>* the locator is being colocated in a normal member this field will be 
> null.
>*/
>   private InternalDistributedSystem myDs;
> {code}
> I don't think that this should be nullable. It makes things more complicated 
> -- when we start a colocated locator, the protobuf protocol statistics 
> initialization has to check {{InternalDistributedSystem.getAnyInstance()}} to 
> get a DS. Can that call be null? I'm not sure.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)