[GitHub] incubator-hawq issue #1226: HAWQ-1447. Fix ranger build failure

2017-06-07 Thread stanlyxiang
Github user stanlyxiang commented on the issue: https://github.com/apache/incubator-hawq/pull/1226 I tested on my rhel7. After build rps rpm, there are 2 commands after the rpm generate. ` [INFO] + cd

[GitHub] incubator-hawq issue #1226: HAWQ-1447. Fix ranger build failure

2017-06-07 Thread linwen
Github user linwen commented on the issue: https://github.com/apache/incubator-hawq/pull/1226 I don't think it is a good way to explicitly copy jar files in Makefile, it should be done in mvn building file. So Xiang, would you like to make sure if this failure still exist? --- If

[GitHub] incubator-hawq issue #1246: HAWQ-1475. Add LICENSE, NOTICE, and DISCLAIMER f...

2017-06-07 Thread huor
Github user huor commented on the issue: https://github.com/apache/incubator-hawq/pull/1246 @edespino, closing the PR. Thanks for the notification. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] incubator-hawq pull request #1246: HAWQ-1475. Add LICENSE, NOTICE, and DISCL...

2017-06-07 Thread huor
Github user huor closed the pull request at: https://github.com/apache/incubator-hawq/pull/1246 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] incubator-hawq issue #1251: HAWQ-1480 - Added feature for packing a core fil...

2017-06-07 Thread outofmem0ry
Github user outofmem0ry commented on the issue: https://github.com/apache/incubator-hawq/pull/1251 @dyozie correct, it is not documented in greenplum. @edespino - Totally agree with your point. Keeping that in mind, earlier, I suggested documenting it under

[GitHub] incubator-hawq issue #1251: HAWQ-1480 - Added feature for packing a core fil...

2017-06-07 Thread edespino
Github user edespino commented on the issue: https://github.com/apache/incubator-hawq/pull/1251 I'm thinking from the perspective of an Apache developer. They shouldn't have to go to external corporate documentation sets or knowledge bases

[GitHub] incubator-hawq issue #1251: HAWQ-1480 - Added feature for packing a core fil...

2017-06-07 Thread dyozie
Github user dyozie commented on the issue: https://github.com/apache/incubator-hawq/pull/1251 I doesn't look like Greenplum documents packcore either. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-hawq issue #1246: HAWQ-1475. Add LICENSE, NOTICE, and DISCLAIMER f...

2017-06-07 Thread edespino
Github user edespino commented on the issue: https://github.com/apache/incubator-hawq/pull/1246 @huor - As this has been committed, can you please close this PR now? Thanks buddy. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-hawq issue #1227: HAWQ-1448. Fixed postmaster process hung at recv...

2017-06-07 Thread edespino
Github user edespino commented on the issue: https://github.com/apache/incubator-hawq/pull/1227 @liming01 - What is the status of this PR? It's been idle for over a month. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] incubator-hawq issue #1226: HAWQ-1447. Fix ranger build failure

2017-06-07 Thread edespino
Github user edespino commented on the issue: https://github.com/apache/incubator-hawq/pull/1226 @stanlyxiang - What is the status of this PR? It's been idle for over a month. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-hawq issue #1251: HAWQ-1480 - Added feature for packing a core fil...

2017-06-07 Thread edespino
Github user edespino commented on the issue: https://github.com/apache/incubator-hawq/pull/1251 @outofmem0ry - It might be helpful to check with David Yozie (@dyozie) to see if we can get this into the public HAWQ user/admin documentation. --- If your project is set up for it, you

[GitHub] incubator-hawq issue #1251: HAWQ-1480 - Added feature for packing a core fil...

2017-06-07 Thread edespino
Github user edespino commented on the issue: https://github.com/apache/incubator-hawq/pull/1251 @outofmem0ry - Thanks for addressing the issues. FYI: It is helpful to push the changes to your repo:branch (outofmem0ry:feature-packcore) that this PR is based on so we can see that the

[GitHub] incubator-hawq issue #1251: HAWQ-1480 - Added feature for packing a core fil...

2017-06-07 Thread outofmem0ry
Github user outofmem0ry commented on the issue: https://github.com/apache/incubator-hawq/pull/1251 @edespino @vVineet @linwen - Thank you for the reviews and comments. I have incorporated the changes and removed the copyright for now. @linwen What kind of documentation do you

[GitHub] incubator-hawq issue #1251: HAWQ-1480 - Added feature for packing a core fil...

2017-06-07 Thread linwen
Github user linwen commented on the issue: https://github.com/apache/incubator-hawq/pull/1251 Ed, I agree with you on adding documentation for this utility. I have some concern on adding a test case, is it a little bit strange to have a core dump file in source repository(maybe two,

[GitHub] incubator-hawq issue #1251: HAWQ-1480 - Added feature for packing a core fil...

2017-06-07 Thread edespino
Github user edespino commented on the issue: https://github.com/apache/incubator-hawq/pull/1251 Additionally, is a test being added to validate the functionality of packcore? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-hawq issue #1251: HAWQ-1480 - Added feature for packing a core fil...

2017-06-07 Thread edespino
Github user edespino commented on the issue: https://github.com/apache/incubator-hawq/pull/1251 Aside from the two misspellings identified and the pending determination to keep or remove the "Copyright Pivotal 2014" string, this PR looks good. I have run the packcore against a HAWQ

[GitHub] incubator-hawq pull request #1251: HAWQ-1480 - Added feature for packing a c...

2017-06-07 Thread edespino
Github user edespino commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1251#discussion_r120542807 --- Diff: tools/sbin/packcore --- @@ -0,0 +1,262 @@ +#!/bin/env python +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] incubator-hawq pull request #1251: HAWQ-1480 - Added feature for packing a c...

2017-06-07 Thread edespino
Github user edespino commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1251#discussion_r120542744 --- Diff: tools/sbin/packcore --- @@ -0,0 +1,262 @@ +#!/bin/env python +# Licensed to the Apache Software Foundation (ASF) under one +#