[GitHub] incubator-hawq pull request #1344: PXF Ignite plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1344#discussion_r171145415 --- Diff: pxf/pxf-ignite/src/test/java/org/apache/hawq/pxf/plugins/ignite/IgniteAccessorTest.java --- @@ -0,0 +1,130 @@ +package

[GitHub] incubator-hawq pull request #1344: PXF Ignite plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1344#discussion_r171132308 --- Diff: pxf/pxf-ignite/src/main/java/org/apache/hawq/pxf/plugins/ignite/IgnitePartitionFragmenter.java --- @@ -0,0 +1,384 @@ +package

[GitHub] incubator-hawq pull request #1344: PXF Ignite plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1344#discussion_r171133073 --- Diff: pxf/pxf-ignite/src/test/java/org/apache/hawq/pxf/plugins/ignite/IgnitePartitionFragmenterTest.java --- @@ -0,0 +1,268 @@ +package

[GitHub] incubator-hawq pull request #1344: PXF Ignite plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1344#discussion_r171144921 --- Diff: pxf/pxf-ignite/src/test/java/org/apache/hawq/pxf/plugins/ignite/SqlBuilderTest.java --- @@ -0,0 +1,173 @@ +package

[GitHub] incubator-hawq pull request #1344: PXF Ignite plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1344#discussion_r171129868 --- Diff: pxf/pxf-ignite/src/main/java/org/apache/hawq/pxf/plugins/ignite/IgnitePartitionFragmenter.java --- @@ -0,0 +1,384 @@ +package

[GitHub] incubator-hawq pull request #1344: PXF Ignite plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1344#discussion_r171133652 --- Diff: pxf/pxf-ignite/src/test/java/org/apache/hawq/pxf/plugins/ignite/IgnitePartitionFragmenterTest.java --- @@ -0,0 +1,268 @@ +package

[GitHub] incubator-hawq pull request #1344: PXF Ignite plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1344#discussion_r171130514 --- Diff: pxf/pxf-ignite/src/main/java/org/apache/hawq/pxf/plugins/ignite/IgnitePartitionFragmenter.java --- @@ -0,0 +1,384 @@ +package

[GitHub] incubator-hawq pull request #1344: PXF Ignite plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1344#discussion_r171131203 --- Diff: pxf/pxf-ignite/src/main/java/org/apache/hawq/pxf/plugins/ignite/IgnitePartitionFragmenter.java --- @@ -0,0 +1,384 @@ +package

[GitHub] incubator-hawq pull request #1344: PXF Ignite plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1344#discussion_r171145340 --- Diff: pxf/pxf-ignite/src/test/java/org/apache/hawq/pxf/plugins/ignite/IgniteAccessorTest.java --- @@ -0,0 +1,130 @@ +package

[GitHub] incubator-hawq pull request #1344: PXF Ignite plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1344#discussion_r171130229 --- Diff: pxf/pxf-ignite/src/main/java/org/apache/hawq/pxf/plugins/ignite/IgnitePartitionFragmenter.java --- @@ -0,0 +1,384 @@ +package

[GitHub] incubator-hawq pull request #1344: PXF Ignite plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1344#discussion_r171129628 --- Diff: pxf/pxf-ignite/src/main/java/org/apache/hawq/pxf/plugins/ignite/IgnitePartitionFragmenter.java --- @@ -0,0 +1,384 @@ +package

[GitHub] incubator-hawq pull request #1344: PXF Ignite plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1344#discussion_r171130678 --- Diff: pxf/pxf-ignite/src/main/java/org/apache/hawq/pxf/plugins/ignite/IgnitePartitionFragmenter.java --- @@ -0,0 +1,384 @@ +package

[GitHub] incubator-hawq pull request #1344: PXF Ignite plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1344#discussion_r171129783 --- Diff: pxf/pxf-ignite/src/main/java/org/apache/hawq/pxf/plugins/ignite/IgnitePartitionFragmenter.java --- @@ -0,0 +1,384 @@ +package

[GitHub] incubator-hawq pull request #1344: PXF Ignite plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1344#discussion_r171131448 --- Diff: pxf/pxf-ignite/src/main/java/org/apache/hawq/pxf/plugins/ignite/IgniteAccessor.java --- @@ -0,0 +1,502 @@ +package

[GitHub] incubator-hawq pull request #1344: PXF Ignite plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1344#discussion_r171132977 --- Diff: pxf/pxf-ignite/src/test/java/org/apache/hawq/pxf/plugins/ignite/IgnitePartitionFragmenterTest.java --- @@ -0,0 +1,268 @@ +package

[GitHub] incubator-hawq pull request #1344: PXF Ignite plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1344#discussion_r171130804 --- Diff: pxf/pxf-ignite/src/main/java/org/apache/hawq/pxf/plugins/ignite/IgnitePartitionFragmenter.java --- @@ -0,0 +1,384 @@ +package

[GitHub] incubator-hawq pull request #1344: PXF Ignite plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1344#discussion_r171118261 --- Diff: pxf/pxf-ignite/src/main/java/org/apache/hawq/pxf/plugins/ignite/IgniteResolver.java --- @@ -0,0 +1,173 @@ +package

[GitHub] incubator-hawq pull request #1344: PXF Ignite plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1344#discussion_r171116876 --- Diff: pxf/pxf-ignite/src/main/java/org/apache/hawq/pxf/plugins/ignite/IgnitePlugin.java --- @@ -0,0 +1,90 @@ +package

[GitHub] incubator-hawq pull request #1344: PXF Ignite plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1344#discussion_r171116788 --- Diff: pxf/pxf-ignite/src/main/java/org/apache/hawq/pxf/plugins/ignite/IgniteResolver.java --- @@ -0,0 +1,173 @@ +package

[GitHub] incubator-hawq pull request #1344: PXF Ignite plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1344#discussion_r171118770 --- Diff: pxf/pxf-ignite/src/main/java/org/apache/hawq/pxf/plugins/ignite/WhereSQLBuilder.java --- @@ -0,0 +1,140 @@ +package

[GitHub] incubator-hawq pull request #1344: PXF Ignite plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1344#discussion_r171117617 --- Diff: pxf/pxf-ignite/src/main/java/org/apache/hawq/pxf/plugins/ignite/IgniteResolver.java --- @@ -0,0 +1,173 @@ +package

[GitHub] incubator-hawq pull request #1344: PXF Ignite plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1344#discussion_r171118390 --- Diff: pxf/pxf-ignite/src/main/java/org/apache/hawq/pxf/plugins/ignite/WhereSQLBuilder.java --- @@ -0,0 +1,140 @@ +package

[GitHub] incubator-hawq pull request #1344: PXF Ignite plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1344#discussion_r171117000 --- Diff: pxf/pxf-ignite/src/main/java/org/apache/hawq/pxf/plugins/ignite/IgniteResolver.java --- @@ -0,0 +1,173 @@ +package

[GitHub] incubator-hawq pull request #1344: PXF Ignite plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1344#discussion_r171117399 --- Diff: pxf/pxf-ignite/src/main/java/org/apache/hawq/pxf/plugins/ignite/IgniteResolver.java --- @@ -0,0 +1,173 @@ +package

[GitHub] incubator-hawq pull request #1344: PXF Ignite plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1344#discussion_r171077045 --- Diff: pxf/pxf-ignite/src/main/java/org/apache/hawq/pxf/plugins/ignite/IgniteAccessor.java --- @@ -0,0 +1,502 @@ +package

[GitHub] incubator-hawq pull request #1344: PXF Ignite plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1344#discussion_r171081924 --- Diff: pxf/pxf-ignite/src/main/java/org/apache/hawq/pxf/plugins/ignite/IgniteAccessor.java --- @@ -0,0 +1,502 @@ +package

[GitHub] incubator-hawq pull request #1344: PXF Ignite plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1344#discussion_r171079170 --- Diff: pxf/pxf-ignite/src/main/java/org/apache/hawq/pxf/plugins/ignite/IgniteAccessor.java --- @@ -0,0 +1,502 @@ +package

[GitHub] incubator-hawq pull request #1344: PXF Ignite plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1344#discussion_r171072088 --- Diff: pxf/pxf-ignite/README.md --- @@ -0,0 +1,67 @@ +# Accessing Ignite database using PXF + +The PXF Ignite plug-in enables to access

[GitHub] incubator-hawq pull request #1344: PXF Ignite plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1344#discussion_r171073052 --- Diff: pxf/pxf-ignite/README.md --- @@ -0,0 +1,67 @@ +# Accessing Ignite database using PXF + +The PXF Ignite plug-in enables to access

[GitHub] incubator-hawq pull request #1344: PXF Ignite plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1344#discussion_r171074788 --- Diff: pxf/pxf-ignite/src/main/java/org/apache/hawq/pxf/plugins/ignite/IgnitePlugin.java --- @@ -0,0 +1,90 @@ +package

[GitHub] incubator-hawq issue #1002: HAWQ-1130. Draft implementation.

Github user hornn commented on the issue: https://github.com/apache/incubator-hawq/pull/1002 Also forgot to mention - I think there are unittests around this code. You might need to revise them, I am not sure. --- If your project is set up for it, you can reply to this email

[GitHub] incubator-hawq issue #1002: HAWQ-1130. Draft implementation.

Github user hornn commented on the issue: https://github.com/apache/incubator-hawq/pull/1002 @sansanichfb - did you compare performance before and after the change? IIRC this function is used internally every time an hcatalog object is created, so it should be fast. After

[GitHub] incubator-hawq pull request #1002: HAWQ-1130. Draft implementation.

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1002#discussion_r86455407 --- Diff: src/backend/access/transam/varsup.c --- @@ -474,73 +479,53 @@ ResetExternalObjectId(void) /* * master_highest_used_oid

[GitHub] incubator-hawq pull request #1002: HAWQ-1130. Draft implementation.

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1002#discussion_r86451395 --- Diff: src/backend/access/transam/varsup.c --- @@ -474,73 +479,53 @@ ResetExternalObjectId(void) /* * master_highest_used_oid

[GitHub] incubator-hawq pull request #1002: HAWQ-1130. Draft implementation.

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1002#discussion_r86447937 --- Diff: src/backend/access/transam/varsup.c --- @@ -474,73 +479,53 @@ ResetExternalObjectId(void) /* * master_highest_used_oid

[GitHub] incubator-hawq pull request #972: HAWQ-1108 Add JDBC PXF Plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/972#discussion_r85678810 --- Diff: pxf/pxf-jdbc/src/test/java/org/apache/hawq/pxf/plugins/jdbc/JdbcMySqlExtensionTest.java --- @@ -0,0 +1,303 @@ +package

[GitHub] incubator-hawq pull request #972: HAWQ-1108 Add JDBC PXF Plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/972#discussion_r85678674 --- Diff: pxf/pxf-jdbc/src/test/java/org/apache/hawq/pxf/plugins/jdbc/JdbcFilterBuilderTest.java --- @@ -0,0 +1,81 @@ +package

[GitHub] incubator-hawq pull request #972: HAWQ-1108 Add JDBC PXF Plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/972#discussion_r85678564 --- Diff: pxf/pxf-jdbc/src/main/java/org/apache/hawq/pxf/plugins/jdbc/JdbcPartitionFragmenter.java --- @@ -0,0 +1,284 @@ +package

[GitHub] incubator-hawq pull request #972: HAWQ-1108 Add JDBC PXF Plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/972#discussion_r85476012 --- Diff: pxf/pxf-jdbc/src/main/java/org/apache/hawq/pxf/plugins/jdbc/JdbcPartitionFragmenter.java --- @@ -0,0 +1,284 @@ +package

[GitHub] incubator-hawq pull request #972: HAWQ-1108 Add JDBC PXF Plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/972#discussion_r85476340 --- Diff: pxf/pxf-jdbc/src/main/java/org/apache/hawq/pxf/plugins/jdbc/JdbcPartitionFragmenter.java --- @@ -0,0 +1,284 @@ +package

[GitHub] incubator-hawq pull request #972: HAWQ-1108 Add JDBC PXF Plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/972#discussion_r85473708 --- Diff: pxf/pxf-jdbc/src/test/resources/core-site.xml --- @@ -0,0 +1,28 @@ + --- End diff -- The test/resource directory contains

[GitHub] incubator-hawq pull request #972: HAWQ-1108 Add JDBC PXF Plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/972#discussion_r85473491 --- Diff: pxf/pxf-jdbc/src/test/java/org/apache/hawq/pxf/plugins/jdbc/JdbcPartitionFragmenterTest.java --- @@ -0,0 +1,208 @@ +package

[GitHub] incubator-hawq pull request #972: HAWQ-1108 Add JDBC PXF Plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/972#discussion_r85473433 --- Diff: pxf/pxf-jdbc/src/test/java/org/apache/hawq/pxf/plugins/jdbc/JdbcMySqlExtensionTest.java --- @@ -0,0 +1,303 @@ +package

[GitHub] incubator-hawq pull request #972: HAWQ-1108 Add JDBC PXF Plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/972#discussion_r85473415 --- Diff: pxf/pxf-jdbc/src/test/java/org/apache/hawq/pxf/plugins/jdbc/JdbcMySqlExtensionTest.java --- @@ -0,0 +1,303 @@ +package

[GitHub] incubator-hawq pull request #972: HAWQ-1108 Add JDBC PXF Plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/972#discussion_r85473219 --- Diff: pxf/pxf-jdbc/src/test/java/org/apache/hawq/pxf/plugins/jdbc/JdbcFilterBuilderTest.java --- @@ -0,0 +1,81 @@ +package

[GitHub] incubator-hawq pull request #972: HAWQ-1108 Add JDBC PXF Plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/972#discussion_r85472961 --- Diff: pxf/pxf-jdbc/src/test/java/org/apache/hawq/pxf/plugins/jdbc/JdbcFilterBuilderTest.java --- @@ -0,0 +1,81 @@ +package

[GitHub] incubator-hawq pull request #972: HAWQ-1108 Add JDBC PXF Plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/972#discussion_r85472352 --- Diff: pxf/pxf-jdbc/src/main/java/org/apache/hawq/pxf/plugins/jdbc/utils/DbProduct.java --- @@ -0,0 +1,51 @@ +package

[GitHub] incubator-hawq pull request #972: HAWQ-1108 Add JDBC PXF Plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/972#discussion_r85472163 --- Diff: pxf/pxf-jdbc/src/main/java/org/apache/hawq/pxf/plugins/jdbc/WhereSQLBuilder.java --- @@ -0,0 +1,140 @@ +package

[GitHub] incubator-hawq pull request #972: HAWQ-1108 Add JDBC PXF Plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/972#discussion_r85471996 --- Diff: pxf/pxf-jdbc/src/main/java/org/apache/hawq/pxf/plugins/jdbc/JdbcReadResolver.java --- @@ -0,0 +1,116 @@ +package

[GitHub] incubator-hawq pull request #972: HAWQ-1108 Add JDBC PXF Plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/972#discussion_r85471780 --- Diff: pxf/pxf-jdbc/src/main/java/org/apache/hawq/pxf/plugins/jdbc/JdbcPlugin.java --- @@ -0,0 +1,114 @@ +package

[GitHub] incubator-hawq pull request #972: HAWQ-1108 Add JDBC PXF Plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/972#discussion_r85471415 --- Diff: pxf/pxf-jdbc/src/main/java/org/apache/hawq/pxf/plugins/jdbc/JdbcPartitionFragmenter.java --- @@ -0,0 +1,284 @@ +package

[GitHub] incubator-hawq pull request #972: HAWQ-1108 Add JDBC PXF Plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/972#discussion_r85471130 --- Diff: pxf/pxf-jdbc/src/main/java/org/apache/hawq/pxf/plugins/jdbc/JdbcPartitionFragmenter.java --- @@ -0,0 +1,284 @@ +package

[GitHub] incubator-hawq pull request #972: HAWQ-1108 Add JDBC PXF Plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/972#discussion_r85470831 --- Diff: pxf/pxf-jdbc/src/main/java/org/apache/hawq/pxf/plugins/jdbc/JdbcPartitionFragmenter.java --- @@ -0,0 +1,284 @@ +package

[GitHub] incubator-hawq pull request #972: HAWQ-1108 Add JDBC PXF Plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/972#discussion_r85470541 --- Diff: pxf/pxf-jdbc/src/main/java/org/apache/hawq/pxf/plugins/jdbc/JdbcPartitionFragmenter.java --- @@ -0,0 +1,284 @@ +package

[GitHub] incubator-hawq pull request #972: HAWQ-1108 Add JDBC PXF Plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/972#discussion_r85470195 --- Diff: pxf/pxf-jdbc/src/main/java/org/apache/hawq/pxf/plugins/jdbc/JdbcPartitionFragmenter.java --- @@ -0,0 +1,284 @@ +package

[GitHub] incubator-hawq pull request #972: HAWQ-1108 Add JDBC PXF Plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/972#discussion_r85470171 --- Diff: pxf/pxf-jdbc/src/main/java/org/apache/hawq/pxf/plugins/jdbc/JdbcPartitionFragmenter.java --- @@ -0,0 +1,284 @@ +package

[GitHub] incubator-hawq pull request #972: HAWQ-1108 Add JDBC PXF Plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/972#discussion_r85470036 --- Diff: pxf/pxf-jdbc/src/main/java/org/apache/hawq/pxf/plugins/jdbc/JdbcFilterBuilder.java --- @@ -0,0 +1,145 @@ +package

[GitHub] incubator-hawq pull request #972: HAWQ-1108 Add JDBC PXF Plugin

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/972#discussion_r85469744 --- Diff: pxf/pxf-jdbc/src/main/java/org/apache/hawq/pxf/plugins/jdbc/JdbcFilterBuilder.java --- @@ -0,0 +1,145 @@ +package

[GitHub] incubator-hawq pull request #837: HAWQ-779 support pxf filter pushdwon at th...

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/837#discussion_r78508860 --- Diff: src/backend/optimizer/plan/createplan.c --- @@ -1144,9 +1144,15 @@ static char** create_pxf_plan(char **segdb_file_map, RelOptInfo *rel, int