[GitHub] incubator-hawq pull request #1259: HAWQ-1489. Add LICENSE, DISCLAIMER and NO...

2017-06-22 Thread rvs
Github user rvs commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1259#discussion_r123663702 --- Diff: pxf/resources/META-INF/LICENSE --- @@ -0,0 +1,380 @@ + Apache License

[GitHub] incubator-hawq issue #1246: HAWQ-1475. Add LICENSE, NOTICE, and DISCLAIMER f...

2017-05-31 Thread rvs
Github user rvs commented on the issue: https://github.com/apache/incubator-hawq/pull/1246 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hawq issue #1246: HAWQ-1475. Add LICENSE, NOTICE, and DISCLAIMER f...

2017-05-30 Thread rvs
Github user rvs commented on the issue: https://github.com/apache/incubator-hawq/pull/1246 I guess my point is -- this still doesn't address the Java side of things. Do you plan to do it in a separate PR? --- If your project is set up for it, you can reply to this email and have

[GitHub] incubator-hawq issue #1246: HAWQ-1475. Add LICENSE, NOTICE, and DISCLAIMER f...

2017-05-28 Thread rvs
Github user rvs commented on the issue: https://github.com/apache/incubator-hawq/pull/1246 @huor I'm a bit confused -- it appears that both LICENSE and NOTICE files you added are copies of what already exists in the repo. For the binary distribution we need a much more expanded set

[GitHub] incubator-hawq pull request #993: HAWQ-1134. Add Bigtop layout specific pxf-...

2016-11-01 Thread rvs
GitHub user rvs opened a pull request: https://github.com/apache/incubator-hawq/pull/993 HAWQ-1134. Add Bigtop layout specific pxf-private classpath You can merge this pull request into a Git repository by running: $ git pull https://github.com/rvs/incubator-hawq HAWQ-1134

[GitHub] incubator-hawq pull request #788: HAWQ-915. RAT is failing on the latest mas...

2016-07-12 Thread rvs
Github user rvs commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/788#discussion_r70544736 --- Diff: pom.xml --- @@ -112,6 +130,10 @@ however it is tricky to maintain headers in them --> depends/liby

[GitHub] incubator-hawq pull request #788: HAWQ-915. RAT is failing on the latest mas...

2016-07-12 Thread rvs
Github user rvs commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/788#discussion_r70544691 --- Diff: pom.xml --- @@ -37,14 +37,32 @@ tools/bin/src/stream

[GitHub] incubator-hawq pull request #788: HAWQ-915. RAT is failing on the latest mas...

2016-07-12 Thread rvs
Github user rvs commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/788#discussion_r70544706 --- Diff: pom.xml --- @@ -37,14 +37,32 @@ tools/bin/src/stream

[GitHub] incubator-hawq pull request #788: HAWQ-915. RAT is failing on the latest mas...

2016-07-12 Thread rvs
Github user rvs commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/788#discussion_r70544564 --- Diff: pom.xml --- @@ -37,14 +37,32 @@ tools/bin/src/stream

[GitHub] incubator-hawq pull request #788: HAWQ-915. RAT is failing on the latest mas...

2016-07-12 Thread rvs
Github user rvs commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/788#discussion_r70544439 --- Diff: pom.xml --- @@ -37,14 +37,32 @@ tools/bin/src/stream

[GitHub] incubator-hawq pull request #788: HAWQ-915. RAT is failing on the latest mas...

2016-07-12 Thread rvs
Github user rvs commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/788#discussion_r70544327 --- Diff: pom.xml --- @@ -37,14 +37,32 @@ tools/bin/src/stream

[GitHub] incubator-hawq pull request #788: HAWQ-915. RAT is failing on the latest mas...

2016-07-12 Thread rvs
Github user rvs commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/788#discussion_r70544369 --- Diff: pom.xml --- @@ -37,14 +37,32 @@ tools/bin/src/stream

[GitHub] incubator-hawq issue #737: HAWQ-849. Remove apache orc codebase from hawq

2016-06-22 Thread rvs
Github user rvs commented on the issue: https://github.com/apache/incubator-hawq/pull/737 @xunzhang happy to help and thanks for the patience! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-hawq issue #701: HAWQ 795,796,797

2016-06-16 Thread rvs
Github user rvs commented on the issue: https://github.com/apache/incubator-hawq/pull/701 This is a discussion that belongs on the mailing list. Please do follow up. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-hawq issue #701: HAWQ 795,796,797

2016-06-16 Thread rvs
Github user rvs commented on the issue: https://github.com/apache/incubator-hawq/pull/701 Where was it communicated? I saw no email exchange on the dev@hawq mailing list. Also, please follow with tour comments on the dev@hawq mailing list thread that I started. It would

[GitHub] incubator-hawq issue #701: HAWQ 795,796,797

2016-06-16 Thread rvs
Github user rvs commented on the issue: https://github.com/apache/incubator-hawq/pull/701 As it appears to be a complete fork of the ORC codebase (do correct me if I'm wrong). I'm very much -1 on this. Please see the email thread on dev@hawq because I think we may need to back it out