[GitHub] incubator-hawq issue #1292: HAWQ-1532. recognize timezone 'CST' correctly in...

2017-12-07 Thread radarwave
Github user radarwave commented on the issue: https://github.com/apache/incubator-hawq/pull/1292 Already merged, please close this PR. Thanks. ---

[GitHub] incubator-hawq issue #1292: HAWQ-1532. recognize timezone 'CST' correctly in...

2017-11-30 Thread radarwave
Github user radarwave commented on the issue: https://github.com/apache/incubator-hawq/pull/1292 @kuien This PR passed all the tests in my environment. +1 ---

[GitHub] incubator-hawq issue #1292: HAWQ-1532. recognize timezone 'CST' correctly in...

2017-11-30 Thread kuien
Github user kuien commented on the issue: https://github.com/apache/incubator-hawq/pull/1292 I force to update the commit message body, because the commit id from PG upstream is not correct, should be: > > commit 5b89473d870dc2a9fec0926c5afccf53042dbb0a > Author: Tom

[GitHub] incubator-hawq issue #1292: HAWQ-1532. recognize timezone 'CST' correctly in...

2017-11-30 Thread radarwave
Github user radarwave commented on the issue: https://github.com/apache/incubator-hawq/pull/1292 Thanks @kuien . I will test your PR in my environment since you are seeing some environment issues in HAWQ-1558. ---

[GitHub] incubator-hawq issue #1292: HAWQ-1532. recognize timezone 'CST' correctly in...

2017-11-30 Thread kuien
Github user kuien commented on the issue: https://github.com/apache/incubator-hawq/pull/1292 @xunzhang @radarwave @linwen please have a look, now this PR is not naked with tests on, LOL Besides, I find the ```./feature-test ``` has a small issue and I record it in https://iss

[GitHub] incubator-hawq issue #1292: HAWQ-1532. recognize timezone 'CST' correctly in...

2017-11-29 Thread kuien
Github user kuien commented on the issue: https://github.com/apache/incubator-hawq/pull/1292 @radarwave give me more time on it ... It is not easy for an Internet-engineer to prepare sufficent tests, :( ---

[GitHub] incubator-hawq issue #1292: HAWQ-1532. recognize timezone 'CST' correctly in...

2017-11-14 Thread radarwave
Github user radarwave commented on the issue: https://github.com/apache/incubator-hawq/pull/1292 @kuien Do you need any help to go through the test processes? I think at least we need this PR pass the current feature tests, then you can decide if a new test is needed for this

[GitHub] incubator-hawq issue #1292: HAWQ-1532. recognize timezone 'CST' correctly in...

2017-10-22 Thread radarwave
Github user radarwave commented on the issue: https://github.com/apache/incubator-hawq/pull/1292 @kuien Please refer to the README of feature test to add your test: https://github.com/apache/incubator-hawq/tree/master/src/test/feature And you can run all the feature te

[GitHub] incubator-hawq issue #1292: HAWQ-1532. recognize timezone 'CST' correctly in...

2017-10-19 Thread xunzhang
Github user xunzhang commented on the issue: https://github.com/apache/incubator-hawq/pull/1292 ``` cd $CODE_BASE make feature-test cd src/test/feature ./feature-test ``` ---

[GitHub] incubator-hawq issue #1292: HAWQ-1532. recognize timezone 'CST' correctly in...

2017-10-19 Thread kuien
Github user kuien commented on the issue: https://github.com/apache/incubator-hawq/pull/1292 @radarwave good question, I may need to add the tests as well. ---

[GitHub] incubator-hawq issue #1292: HAWQ-1532. recognize timezone 'CST' correctly in...

2017-10-19 Thread radarwave
Github user radarwave commented on the issue: https://github.com/apache/incubator-hawq/pull/1292 @kuien Have you ran and passed HAWQ feature tests for this fix? Thanks. ---

[GitHub] incubator-hawq issue #1292: HAWQ-1532. recognize timezone 'CST' correctly in...

2017-10-19 Thread kuien
Github user kuien commented on the issue: https://github.com/apache/incubator-hawq/pull/1292 On my redhat 7 server, it works like following: psql (8.2.15) Type "help" for help. postgres=# show timezone_abbreviations; timezone_abbreviations -