[GitHub] incubator-hawq pull request #968: HAWQ 1116

Github user shivzone closed the pull request at: https://github.com/apache/incubator-hawq/pull/968 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-hawq pull request #968: HAWQ 1116

Github user sansanichfb commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/968#discussion_r84521841 --- Diff: src/backend/access/external/pxffilters.c --- @@ -406,6 +406,29 @@ pxf_serialize_filter_list(List *expressionItems)

[GitHub] incubator-hawq pull request #968: HAWQ 1116

Github user sansanichfb commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/968#discussion_r84389149 --- Diff: src/backend/access/external/pxffilters.c --- @@ -406,6 +406,16 @@ pxf_serialize_filter_list(List *expressionItems)

[GitHub] incubator-hawq pull request #968: HAWQ 1116

Github user sansanichfb commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/968#discussion_r84389764 --- Diff: src/backend/access/external/test/pxffilters_test.c --- @@ -323,10 +323,32 @@ OpExpr* build_op_expr(void* left, void* right, int op)

[GitHub] incubator-hawq pull request #968: HAWQ 1116

Github user denalex commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/968#discussion_r84383699 --- Diff: src/backend/access/external/pxffilters.c --- @@ -406,6 +406,22 @@ pxf_serialize_filter_list(List *expressionItems)

[GitHub] incubator-hawq pull request #968: HAWQ 1116

Github user shivzone commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/968#discussion_r84387054 --- Diff: src/backend/access/external/pxffilters.c --- @@ -406,6 +406,22 @@ pxf_serialize_filter_list(List *expressionItems)

[GitHub] incubator-hawq pull request #968: HAWQ 1116

Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/968#discussion_r84334739 --- Diff: src/backend/access/external/pxffilters.c --- @@ -406,6 +406,22 @@ pxf_serialize_filter_list(List *expressionItems)

[GitHub] incubator-hawq pull request #968: HAWQ 1116

Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/968#discussion_r84333580 --- Diff: src/backend/access/external/test/pxffilters_test.c --- @@ -507,6 +542,23 @@ void test__pxf_serialize_filter_list__oneFilter(void **state)

[GitHub] incubator-hawq pull request #968: HAWQ 1116

Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/968#discussion_r8414 --- Diff: src/backend/access/external/test/pxffilters_test.c --- @@ -323,6 +323,30 @@ OpExpr* build_op_expr(void* left, void* right, int op)

[GitHub] incubator-hawq pull request #968: HAWQ 1116

GitHub user shivzone opened a pull request: https://github.com/apache/incubator-hawq/pull/968 HAWQ 1116 You can merge this pull request into a Git repository by running: $ git pull https://github.com/shivzone/incubator-hawq HAWQ-1116 Alternatively you can review and apply