[jira] [Closed] (HAWQ-1320) Remove PXF version references from the code repo
[ https://issues.apache.org/jira/browse/HAWQ-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shivram Mani closed HAWQ-1320. -- Resolution: Fixed > Remove PXF version references from the code repo > > > Key: HAWQ-1320 > URL: https://issues.apache.org/jira/browse/HAWQ-1320 > Project: Apache HAWQ > Issue Type: Task > Components: PXF >Reporter: Vineet Goel >Assignee: Shivram Mani > Fix For: 2.1.0.0-incubating > > > Currently, the PXF version is statically defined in the codebase in > gradle.properties file. It would be better to pass these version strings > dynamically while running make. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] incubator-hawq pull request #1114: HAWQ-1320. Remove reference to PXF rpm ve...
Github user shivzone commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1114#discussion_r100632037 --- Diff: pxf/Makefile --- @@ -38,6 +38,10 @@ ifneq "$(VENDOR)" "" BUILD_PARAMS+= -Pvendor="$(VENDOR)" endif +ifneq "$(PXF_VERSION)" "" --- End diff -- Not really. We should still be able to run simple dev builds which don't require PXF version --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1114: HAWQ-1320. Remove reference to PXF rpm ve...
Github user sansanichfb commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1114#discussion_r100628050 --- Diff: pxf/Makefile --- @@ -38,6 +38,10 @@ ifneq "$(VENDOR)" "" BUILD_PARAMS+= -Pvendor="$(VENDOR)" endif +ifneq "$(PXF_VERSION)" "" --- End diff -- Shouldn't we fail if there is no value for PXF_VERSION available? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1114: HAWQ-1320. Remove reference to PXF rpm ve...
Github user shivzone commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1114#discussion_r100616374 --- Diff: pxf/Makefile --- @@ -38,6 +38,10 @@ ifneq "$(VENDOR)" "" BUILD_PARAMS+= -Pvendor="$(VENDOR)" endif +ifneq "$(PXF_VERSION)" "" +BUILD_PARAMSi+= -Pversion="$(PXF_VERSION)" --- End diff -- good catch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (HAWQ-1322) Change RPM name for RPS to hawq-ranger-plugin
Alexander Denissov created HAWQ-1322: Summary: Change RPM name for RPS to hawq-ranger-plugin Key: HAWQ-1322 URL: https://issues.apache.org/jira/browse/HAWQ-1322 Project: Apache HAWQ Issue Type: Sub-task Reporter: Alexander Denissov Assignee: Ed Espino Change RPM name for RPS to hawq-ranger-plugin_X_Y_Z_W where the later suffix is a version number, same as main hawq version number. This will be a versioned RPM to along with the main hawq versioned RPM. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (HAWQ-1322) Change RPM name for RPS to hawq-ranger-plugin
[ https://issues.apache.org/jira/browse/HAWQ-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Denissov reassigned HAWQ-1322: Assignee: Alexander Denissov (was: Ed Espino) > Change RPM name for RPS to hawq-ranger-plugin > - > > Key: HAWQ-1322 > URL: https://issues.apache.org/jira/browse/HAWQ-1322 > Project: Apache HAWQ > Issue Type: Sub-task > Components: Security >Reporter: Alexander Denissov >Assignee: Alexander Denissov > Fix For: backlog > > > Change RPM name for RPS to hawq-ranger-plugin_X_Y_Z_W where the later suffix > is a version number, same as main hawq version number. This will be a > versioned RPM to along with the main hawq versioned RPM. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] incubator-hawq issue #1114: HAWQ-1320. Remove reference to PXF rpm version i...
Github user ljainpivotalio commented on the issue: https://github.com/apache/incubator-hawq/pull/1114 Please feel free to merge when done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1114: HAWQ-1320. Remove reference to PXF rpm ve...
Github user ljainpivotalio commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1114#discussion_r100613055 --- Diff: pxf/Makefile --- @@ -38,6 +38,10 @@ ifneq "$(VENDOR)" "" BUILD_PARAMS+= -Pvendor="$(VENDOR)" endif +ifneq "$(PXF_VERSION)" "" +BUILD_PARAMSi+= -Pversion="$(PXF_VERSION)" --- End diff -- There is an extra i after BUILD_PARAMS. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1114: HAWQ-1320. Remove reference to PXF rpm ve...
GitHub user shivzone opened a pull request: https://github.com/apache/incubator-hawq/pull/1114 HAWQ-1320. Remove reference to PXF rpm version in source You can merge this pull request into a Git repository by running: $ git pull https://github.com/shivzone/incubator-hawq HAWQ-1320 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/1114.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1114 commit 7a3def8e7e3cfed2af93cff178469f886a7a56f2 Author: shivzoneDate: 2017-02-10T19:26:01Z HAWQ-1320. Remove reference to PXF rpm version in source --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Assigned] (HAWQ-1320) Remove PXF version references from the code repo
[ https://issues.apache.org/jira/browse/HAWQ-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shivram Mani reassigned HAWQ-1320: -- Assignee: Shivram Mani (was: Ed Espino) > Remove PXF version references from the code repo > > > Key: HAWQ-1320 > URL: https://issues.apache.org/jira/browse/HAWQ-1320 > Project: Apache HAWQ > Issue Type: Task > Components: PXF >Reporter: Vineet Goel >Assignee: Shivram Mani > Fix For: 2.1.0.0-incubating > > > Currently, the PXF version is statically defined in the codebase in > gradle.properties file. It would be better to pass these version strings > dynamically while running make. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] incubator-hawq issue #1111: HAWQ-1319. Expand pom.xml file for src/test dire...
Github user huor commented on the issue: https://github.com/apache/incubator-hawq/pull/ @edespino, the source file in feature suite should be included in pom. Please create another jira to add the license header for the source file once the pom is updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---