[GitHub] incubator-hawq issue #1250: Hawq 1477. Ranger-plugin connect to Ranger admin...

[interma]

Github user interma commented on the issue:

https://github.com/apache/incubator-hawq/pull/1250
  
Merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1250: Hawq 1477. Ranger-plugin connect to Range...

[interma]

Github user interma closed the pull request at:

https://github.com/apache/incubator-hawq/pull/1250


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1251: HAWQ-1480 - Added feature for packing a c...

[vVineet]

Github user vVineet commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1251#discussion_r120539594
  
--- Diff: tools/sbin/packcore ---
@@ -0,0 +1,262 @@
+#!/bin/env python
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+# 
+#   http://www.apache.org/licenses/LICENSE-2.0
+# 
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# Copyright Pivotal 2014
--- End diff --

We need to remove Pivotal copyright since we are contributing this code in 
Apache and doing so under Apache license.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1251: HAWQ-1480 - Added feature for packing a c...

[linwen]

Github user linwen commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1251#discussion_r120526700
  
--- Diff: tools/sbin/packcore ---
@@ -0,0 +1,262 @@
+#!/bin/env python
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+# 
+#   http://www.apache.org/licenses/LICENSE-2.0
+# 
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# Copyright Pivotal 2014
--- End diff --

I think it is better to remove it, also the ""Copyright Pivotal" in 
hawqstandbywatch.py. How do you think of this Roman? @rvs Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #1250: Hawq 1477. Ranger-plugin connect to Ranger admin...

[zhangh43]

Github user zhangh43 commented on the issue:

https://github.com/apache/incubator-hawq/pull/1250
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #1250: Hawq 1477. Ranger-plugin connect to Ranger admin...

[interma]

Github user interma commented on the issue:

https://github.com/apache/incubator-hawq/pull/1250
  
fixed all comments issues.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (HAWQ-1482) Support open-ended RANGE for PXF JDBC Plugin

[Lav Jain (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HAWQ-1482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lav Jain updated HAWQ-1482:
---
Summary: Support open-ended RANGE for PXF JDBC Plugin  (was: Support open 
ended RANGE for PXF JDBC Plugin)

> Support open-ended RANGE for PXF JDBC Plugin
> 
>
> Key: HAWQ-1482
> URL: https://issues.apache.org/jira/browse/HAWQ-1482
> Project: Apache HAWQ
>  Issue Type: Improvement
>  Components: PXF
>Reporter: Lav Jain
>Assignee: Vineet Goel
>
> According to the original doc, the RANGE end_value can be empty if the 
> column_type is int and RANGE can be empty if the column_type is enum.
> However, this has not been implemented in the code as of yet.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HAWQ-1461) Improve partition parameters validation for PXF-JDBC plugin

[Lav Jain (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16039754#comment-16039754
 ] 

Lav Jain commented on HAWQ-1461:


Created JIRA "Support open-ended RANGE for PXF JDBC Plugin" (HAWQ-1482) as 
RANGE parameter is not working as expected.

> Improve partition parameters validation for PXF-JDBC plugin
> ---
>
> Key: HAWQ-1461
> URL: https://issues.apache.org/jira/browse/HAWQ-1461
> Project: Apache HAWQ
>  Issue Type: Improvement
>  Components: PXF
>Reporter: Oleksandr Diachenko
>Assignee: Lav Jain
>
> h3. User didn't pass interval type:
> {code}
> CREATE EXTERNAL TABLE pxf_jdbc_multiple_fragments_by_date (t1text, t2
> text, num1  int, dub1  double precision, dec1  numeric, tm timestamp, r real, 
> bg bigint, b boolean, tn smallint, sml smallint, dt date, vc1 varchar(5), c1 
> char(3), bin bytea) LOCATION 
> (E'pxf://127.0.0.1:51200/hawq_types?PROFILE=Jdbc_DRIVER=org.postgresql.Driver_URL=jdbc:postgresql:pxfautomation//localhost:5432_BY=dt:date=2015-03-06:2015-03-20=1=adiachenko')
>  FORMAT 'CUSTOM' (formatter='pxfwritable_import');
> {code}
> Actual behavior:
> {code}
> select * from pxf_jdbc_multiple_fragments_by_date;
> ERROR:  remote component error (500) from '127.0.0.1:51200':  type  Exception 
> report   message   description   The server encountered an internal error 
> that prevented it from fulfilling this request.exception   
> java.lang.NullPointerException (libchurl.c:897)
> {code}
> h3. User didn't pass interval:
> {code}
> CREATE EXTERNAL TABLE pxf_jdbc_multiple_fragments_by_date (t1text, t2
> text, num1  int, dub1  double precision, dec1  numeric, tm timestamp, r real, 
> bg bigint, b boolean, tn smallint, sml smallint, dt date, vc1 varchar(5), c1 
> char(3), bin bytea) LOCATION 
> (E'pxf://127.0.0.1:51200/hawq_types?PROFILE=Jdbc_DRIVER=org.postgresql.Driver_URL=jdbc:postgresql:pxfautomation//localhost:5432_BY=dt:date=2015-03-06:2015-03-20=adiachenko')
>  FORMAT 'CUSTOM' (formatter='pxfwritable_import');
> {code}
> Actual behavior:
> {code}
> ERROR:  remote component error (500) from '127.0.0.1:51200':  type  Exception 
> report   message   description   The server encountered an internal error 
> that prevented it from fulfilling this request.exception   
> java.lang.NullPointerException (libchurl.c:897)
> {code}
> h3. User didn't pass the upper boundary of a range:
> {code}
> CREATE EXTERNAL TABLE pxf_jdbc_multiple_fragments_by_date (t1text, t2
> text, num1  int, dub1  double precision, dec1  numeric, tm timestamp, r real, 
> bg bigint, b boolean, tn smallint, sml smallint, dt date, vc1 varchar(5), c1 
> char(3), bin bytea) LOCATION 
> (E'pxf://127.0.0.1:51200/hawq_types?PROFILE=Jdbc_DRIVER=org.postgresql.Driver_URL=jdbc:postgresql:pxfautomation//localhost:5432_BY=dt:date=2015-03-06:=1:DAY=adiachenko')
>  FORMAT 'CUSTOM' (formatter='pxfwritable_import');
> {code}
> Actual behavior:
> {code}
> select * from pxf_jdbc_multiple_fragments_by_date;
> ERROR:  remote component error (500) from '127.0.0.1:51200':  type  Exception 
> report   message   java.lang.Exception: 
> java.lang.ArrayIndexOutOfBoundsException: 1description   The server 
> encountered an internal error that prevented it from fulfilling this request. 
>exception   javax.servlet.ServletException: java.lang.Exception: 
> java.lang.ArrayIndexOutOfBoundsException: 1 (libchurl.c:897)
> {code}
> h3. User didn't pass range:
> {code}
> CREATE EXTERNAL TABLE pxf_jdbc_multiple_fragments_by_date (t1text, t2
> text, num1  int, dub1  double precision, dec1  numeric, tm timestamp, r real, 
> bg bigint, b boolean, tn smallint, sml smallint, dt date, vc1 varchar(5), c1 
> char(3), bin bytea) LOCATION 
> (E'pxf://127.0.0.1:51200/hawq_types?PROFILE=Jdbc_DRIVER=org.postgresql.Driver_URL=jdbc:postgresql:pxfautomation//localhost:5432_BY=dt:date=1:DAY=adiachenko')
>  FORMAT 'CUSTOM' (formatter='pxfwritable_import');
> {code}
> Actual behavior:
> {code}
> select * from pxf_jdbc_multiple_fragments_by_date;
> ERROR:  remote component error (500) from '127.0.0.1:51200':  type  Exception 
> report   message   java.lang.Exception: java.lang.NullPointerException
> description   The server encountered an internal error that prevented it from 
> fulfilling this request.exception   javax.servlet.ServletException: 
> java.lang.Exception: java.lang.NullPointerException (libchurl.c:897)
> {code}
> Expected behavior fro all cases: user-friendly meaningful message, hinting to 
> a user which parameter is missing/incorrect.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HAWQ-1481) Travis CI build fails the Maven 3.0.0 check

[Ed Espino (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16039750#comment-16039750
 ] 

Ed Espino commented on HAWQ-1481:
-

Code merged to master.  We have green Travis CI builds again: 
https://travis-ci.org/apache/incubator-hawq/builds/240133714

> Travis CI build fails the Maven 3.0.0 check
> ---
>
> Key: HAWQ-1481
> URL: https://issues.apache.org/jira/browse/HAWQ-1481
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Build
>Reporter: Ed Espino
>Assignee: Ed Espino
> Fix For: 2.3.0.0-incubating
>
>
> Travis CI uses Apache Maven 3.5.0 and the minimum 3.0.0 version check is 
> failing. This causes the build to fail. Here is the failure.
> {code}
> ***
> ERROR: `mvn' is missing on your system.
> ***
> make[2]: *** [hawq-mapreduce-tool/target/hawq-mapreduce-tool-1.1.0.jar] Error 
> 1
> make[1]: *** [all] Error 2
> make: *** [all] Error 2
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Closed] (HAWQ-1481) Travis CI build fails the Maven 3.0.0 check

[Ed Espino (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HAWQ-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ed Espino closed HAWQ-1481.
---
Resolution: Fixed

> Travis CI build fails the Maven 3.0.0 check
> ---
>
> Key: HAWQ-1481
> URL: https://issues.apache.org/jira/browse/HAWQ-1481
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Build
>Reporter: Ed Espino
>Assignee: Ed Espino
> Fix For: 2.3.0.0-incubating
>
>
> Travis CI uses Apache Maven 3.5.0 and the minimum 3.0.0 version check is 
> failing. This causes the build to fail. Here is the failure.
> {code}
> ***
> ERROR: `mvn' is missing on your system.
> ***
> make[2]: *** [hawq-mapreduce-tool/target/hawq-mapreduce-tool-1.1.0.jar] Error 
> 1
> make[1]: *** [all] Error 2
> make: *** [all] Error 2
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (HAWQ-1482) Support open ended RANGE for PXF JDBC Plugin

[Lav Jain (JIRA)]

Lav Jain created HAWQ-1482:
--

 Summary: Support open ended RANGE for PXF JDBC Plugin
 Key: HAWQ-1482
 URL: https://issues.apache.org/jira/browse/HAWQ-1482
 Project: Apache HAWQ
  Issue Type: Improvement
  Components: PXF
Reporter: Lav Jain
Assignee: Vineet Goel


According to the original doc, the RANGE end_value can be empty if the 
column_type is int and RANGE can be empty if the column_type is enum.

However, this has not been implemented in the code as of yet.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] incubator-hawq pull request #1252: HAWQ-1481. Rework Maven "3" major version...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-hawq/pull/1252


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1251: HAWQ-1480 - Added feature for packing a c...

[outofmem0ry]

Github user outofmem0ry commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1251#discussion_r120470730
  
--- Diff: tools/sbin/packcore ---
@@ -0,0 +1,262 @@
+#!/bin/env python
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+# 
+#   http://www.apache.org/licenses/LICENSE-2.0
+# 
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# Copyright Pivotal 2014
--- End diff --

@linwen It was in the original code repo I merged it from. Wanted to keep 
it there for reference/credits. Something similar to what is done here- 
incubator-hawq/tools/sbin/hawqstandbywatch.py

Let me know if it is feasible removing copyright from merged code. I can 
update my branch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #1252: HAWQ-1481. Rework Maven "3" major version check.

[edespino]

Github user edespino commented on the issue:

https://github.com/apache/incubator-hawq/pull/1252
  
FYI: I have successfully built HAWQ (including executing "configure") on 
Centos 6 & 7, SLES 11 and macOS environments.  As you will see, the Travis CI 
build check is also passing with this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1250: Hawq 1477. Ranger-plugin connect to Range...

[interma]

Github user interma commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1250#discussion_r120286370
  
--- Diff: 
ranger-plugin/service/src/main/java/org/apache/hawq/ranger/authorization/RangerHawqPluginResource.java
 ---
@@ -45,8 +47,43 @@
 /**
  * Constructor. Creates a new instance of the resource that uses 
RangerHawqAuthorizer.
  */
-public RangerHawqPluginResource() {
+public RangerHawqPluginResource()
+{
+// set UserGroupInformation under kerberos authentication
+if (Utils.getAuth().equals("kerberos"))
+{
+Configuration conf = new Configuration();
+conf.set("hadoop.security.authentication", "kerberos");
+UserGroupInformation.setConfiguration(conf);
+
+String prin = Utils.getPrincipal();
+String keytab = Utils.getKeytab();
+
+if ( !prin.equals("") && !keytab.equals("") )
+{
+try
+{
+UserGroupInformation.loginUserFromKeytab(prin, keytab);
+}
+catch (Exception e)
+{
+LOG.warn(String.format("loginUserFromKeytab failed, 
user[%s], keytab[%s]", prin, keytab));
+}
+}
+}
+
+try
+{
+UserGroupInformation user = 
UserGroupInformation.getLoginUser();
+LOG.info(String.format("login user: %s", user));
+}
+catch (Exception e)
+{
+LOG.warn("get login user failed");
--- End diff --

Two reasons:
1. Abort immediately may be not appropriate, sometimes it can run happily 
in below code (e.g. set simple auth and get login_user() failed by some 
reasons, but will call a no-secure webservice later)
2. Another small reason: this code locates in a constructor, I didn't find 
a easy way to deal with exception... 

So I just leave it as it is, it will fail in the first place which need 
auth in the below code (I tested, it usually prints a warning message contains 
"HTTP 401/403" in the log, looks well).



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #1252: HAWQ-1481. Rework Maven "3" major version check.

[radarwave]

Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1252
  
LGTM. +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #1252: HAWQ-1481. Rework Maven "3" major version check.

[edespino]

Github user edespino commented on the issue:

https://github.com/apache/incubator-hawq/pull/1252
  
Reviewer request: @radarwave & @lavjain


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1251: HAWQ-1480 - Added feature for packing a c...

[linwen]

Github user linwen commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1251#discussion_r120278044
  
--- Diff: tools/sbin/packcore ---
@@ -0,0 +1,262 @@
+#!/bin/env python
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+# 
+#   http://www.apache.org/licenses/LICENSE-2.0
+# 
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# Copyright Pivotal 2014
--- End diff --

I don't suggest add "Copyright Pivotal 2014" here, since hawq is under 
Apache license. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (HAWQ-1481) Travis CI build fails the Maven 3.0.0 check

[Ed Espino (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16038285#comment-16038285
 ] 

Ed Espino commented on HAWQ-1481:
-

Additional information: The following is seen in the Travis CI execution of the 
"configure" command:

{code}
checking for mvn... /usr/local/bin/mvn
configure: using Apache Maven 3.5.0
configure: WARNING:
*** The installed version of Maven, /usr/local/bin/mvn, is too old to use with 
HAWQ.
*** Maven version 3.0.0 or later is required, but this is Apache Maven 3.5.0.
configure: WARNING:
*** Without Maven you will not be able to build HAWQ with Mapreduce
*** InputFormat/OutputFormat support.
{code}

> Travis CI build fails the Maven 3.0.0 check
> ---
>
> Key: HAWQ-1481
> URL: https://issues.apache.org/jira/browse/HAWQ-1481
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Build
>Reporter: Ed Espino
>Assignee: Ed Espino
> Fix For: 2.3.0.0-incubating
>
>
> Travis CI uses Apache Maven 3.5.0 and the minimum 3.0.0 version check is 
> failing. This causes the build to fail. Here is the failure.
> {code}
> ***
> ERROR: `mvn' is missing on your system.
> ***
> make[2]: *** [hawq-mapreduce-tool/target/hawq-mapreduce-tool-1.1.0.jar] Error 
> 1
> make[1]: *** [all] Error 2
> make: *** [all] Error 2
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] incubator-hawq pull request #1252: HAWQ-1481. Rework Maven "3" major version...

[edespino]

GitHub user edespino opened a pull request:

https://github.com/apache/incubator-hawq/pull/1252

HAWQ-1481. Rework Maven "3" major version check.

The Travis CI build is failing as the Apache Maven 3.5.0 check fails to 
match the "3" major version check.  This PR simplifies the check.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/edespino/incubator-hawq HAWQ-1481

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/1252.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1252


commit 3b55bfd67956ca71f5605ebfdabfa30a04868728
Author: Ed Espino 
Date:   2017-06-06T06:49:56Z

HAWQ-1481. Rework Maven "3" major version check.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Assigned] (HAWQ-1481) Travis CI build fails the Maven 3.0.0 check

[Ed Espino (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HAWQ-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ed Espino reassigned HAWQ-1481:
---

Assignee: Ed Espino  (was: Radar Lei)

> Travis CI build fails the Maven 3.0.0 check
> ---
>
> Key: HAWQ-1481
> URL: https://issues.apache.org/jira/browse/HAWQ-1481
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Build
>Reporter: Ed Espino
>Assignee: Ed Espino
> Fix For: 2.3.0.0-incubating
>
>
> Travis CI uses Apache Maven 3.5.0 and the minimum 3.0.0 version check is 
> failing. This causes the build to fail. Here is the failure.
> {code}
> ***
> ERROR: `mvn' is missing on your system.
> ***
> make[2]: *** [hawq-mapreduce-tool/target/hawq-mapreduce-tool-1.1.0.jar] Error 
> 1
> make[1]: *** [all] Error 2
> make: *** [all] Error 2
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (HAWQ-1481) Travis CI build fails the Maven 3.0.0 check

[Ed Espino (JIRA)]

Ed Espino created HAWQ-1481:
---

 Summary: Travis CI build fails the Maven 3.0.0 check
 Key: HAWQ-1481
 URL: https://issues.apache.org/jira/browse/HAWQ-1481
 Project: Apache HAWQ
  Issue Type: Bug
  Components: Build
Reporter: Ed Espino
Assignee: Radar Lei
 Fix For: 2.3.0.0-incubating


Travis CI uses Apache Maven 3.5.0 and the minimum 3.0.0 version check is 
failing. This causes the build to fail. Here is the failure.

{code}
***
ERROR: `mvn' is missing on your system.
***
make[2]: *** [hawq-mapreduce-tool/target/hawq-mapreduce-tool-1.1.0.jar] Error 1
make[1]: *** [all] Error 2
make: *** [all] Error 2
{code}




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] incubator-hawq pull request #1250: Hawq 1477. Ranger-plugin connect to Range...

[stanlyxiang]

Github user stanlyxiang commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1250#discussion_r120274829
  
--- Diff: 
ranger-plugin/service/src/main/java/org/apache/hawq/ranger/authorization/RangerHawqPluginResource.java
 ---
@@ -45,8 +47,43 @@
 /**
  * Constructor. Creates a new instance of the resource that uses 
RangerHawqAuthorizer.
  */
-public RangerHawqPluginResource() {
+public RangerHawqPluginResource()
+{
+// set UserGroupInformation under kerberos authentication
+if (Utils.getAuth().equals("kerberos"))
+{
+Configuration conf = new Configuration();
+conf.set("hadoop.security.authentication", "kerberos");
+UserGroupInformation.setConfiguration(conf);
+
+String prin = Utils.getPrincipal();
+String keytab = Utils.getKeytab();
+
+if ( !prin.equals("") && !keytab.equals("") )
+{
+try
+{
+UserGroupInformation.loginUserFromKeytab(prin, keytab);
+}
+catch (Exception e)
+{
+LOG.warn(String.format("loginUserFromKeytab failed, 
user[%s], keytab[%s]", prin, keytab));
+}
+}
+}
+
+try
+{
+UserGroupInformation user = 
UserGroupInformation.getLoginUser();
+LOG.info(String.format("login user: %s", user));
+}
+catch (Exception e)
+{
+LOG.warn("get login user failed");
--- End diff --

So if it usually fail in the below code due to try use simple auth user to 
login a kerberized service, why do we let it go failure and why don't we abort 
here ? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1250: Hawq 1477. Ranger-plugin connect to Range...

[interma]

Github user interma commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1250#discussion_r120274725
  
--- Diff: 
ranger-plugin/service/src/main/java/org/apache/hawq/ranger/authorization/RangerHawqPluginResource.java
 ---
@@ -45,8 +47,43 @@
 /**
  * Constructor. Creates a new instance of the resource that uses 
RangerHawqAuthorizer.
  */
-public RangerHawqPluginResource() {
+public RangerHawqPluginResource()
+{
+// set UserGroupInformation under kerberos authentication
+if (Utils.getAuth().equals("kerberos"))
--- End diff --

Yes, but I think use 
`org.apache.hadoop.security.UserGroupInformation.AuthenticationMethod` is 
better:
```
  public static enum AuthenticationMethod {
// currently we support only one auth per method, but eventually a 
// subtype is needed to differentiate, ex. if digest is token or ldap
SIMPLE(AuthMethod.SIMPLE,
HadoopConfiguration.SIMPLE_CONFIG_NAME),
KERBEROS(AuthMethod.KERBEROS,
HadoopConfiguration.USER_KERBEROS_CONFIG_NAME),
TOKEN(AuthMethod.TOKEN),
CERTIFICATE(null),
KERBEROS_SSL(null),
PROXY(null);
```
Let's refactor it in future, keep it as it is now. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1250: Hawq 1477. Ranger-plugin connect to Range...

[interma]

Github user interma commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1250#discussion_r120274082
  
--- Diff: 
ranger-plugin/service/src/main/java/org/apache/hawq/ranger/authorization/RangerHawqPluginResource.java
 ---
@@ -45,8 +47,43 @@
 /**
  * Constructor. Creates a new instance of the resource that uses 
RangerHawqAuthorizer.
  */
-public RangerHawqPluginResource() {
+public RangerHawqPluginResource()
+{
+// set UserGroupInformation under kerberos authentication
+if (Utils.getAuth().equals("kerberos"))
+{
+Configuration conf = new Configuration();
+conf.set("hadoop.security.authentication", "kerberos");
+UserGroupInformation.setConfiguration(conf);
+
+String prin = Utils.getPrincipal();
+String keytab = Utils.getKeytab();
+
+if ( !prin.equals("") && !keytab.equals("") )
+{
+try
+{
+UserGroupInformation.loginUserFromKeytab(prin, keytab);
+}
+catch (Exception e)
+{
+LOG.warn(String.format("loginUserFromKeytab failed, 
user[%s], keytab[%s]", prin, keytab));
+}
+}
+}
+
+try
+{
+UserGroupInformation user = 
UserGroupInformation.getLoginUser();
+LOG.info(String.format("login user: %s", user));
+}
+catch (Exception e)
+{
+LOG.warn("get login user failed");
--- End diff --

Yes, if login failed here, it just uses the simple auth method(e.g. 
gpadmin), but it usually fail in the below code (try use simple auth user to 
login a kerberized sevice). 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1250: Hawq 1477. Ranger-plugin connect to Range...

[interma]

Github user interma commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1250#discussion_r120273701
  
--- Diff: 
ranger-plugin/service/src/main/java/org/apache/hawq/ranger/authorization/RangerHawqPluginResource.java
 ---
@@ -45,8 +47,43 @@
 /**
  * Constructor. Creates a new instance of the resource that uses 
RangerHawqAuthorizer.
  */
-public RangerHawqPluginResource() {
+public RangerHawqPluginResource()
+{
+// set UserGroupInformation under kerberos authentication
+if (Utils.getAuth().equals("kerberos"))
+{
+Configuration conf = new Configuration();
+conf.set("hadoop.security.authentication", "kerberos");
+UserGroupInformation.setConfiguration(conf);
+
+String prin = Utils.getPrincipal();
+String keytab = Utils.getKeytab();
+
+if ( !prin.equals("") && !keytab.equals("") )
+{
+try
+{
+UserGroupInformation.loginUserFromKeytab(prin, keytab);
+}
+catch (Exception e)
+{
+LOG.warn(String.format("loginUserFromKeytab failed, 
user[%s], keytab[%s]", prin, keytab));
+}
+}
+}
--- End diff --

It uses the kinit credential cache to when auth method set to 
authentication and two of them are empty. 
So it's ok here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1250: Hawq 1477. Ranger-plugin connect to Range...

[interma]

Github user interma commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1250#discussion_r120273006
  
--- Diff: 
ranger-plugin/service/src/main/java/org/apache/hawq/ranger/authorization/RangerHawqPluginResource.java
 ---
@@ -45,8 +47,43 @@
 /**
  * Constructor. Creates a new instance of the resource that uses 
RangerHawqAuthorizer.
  */
-public RangerHawqPluginResource() {
+public RangerHawqPluginResource()
+{
+// set UserGroupInformation under kerberos authentication
+if (Utils.getAuth().equals("kerberos"))
+{
+Configuration conf = new Configuration();
+conf.set("hadoop.security.authentication", "kerberos");
+UserGroupInformation.setConfiguration(conf);
+
+String prin = Utils.getPrincipal();
+String keytab = Utils.getKeytab();
+
+if ( !prin.equals("") && !keytab.equals("") )
+{
+try
+{
+UserGroupInformation.loginUserFromKeytab(prin, keytab);
+}
+catch (Exception e)
+{
+LOG.warn(String.format("loginUserFromKeytab failed, 
user[%s], keytab[%s]", prin, keytab));
+}
+}
+}
+
+try
+{
+UserGroupInformation user = 
UserGroupInformation.getLoginUser();
+LOG.info(String.format("login user: %s", user));
+}
+catch (Exception e)
+{
+LOG.warn("get login user failed");
--- End diff --

Thanks, I will fix them!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---