[GitHub] incubator-hawq pull request #1361: HAWQ-1612. Implement vectorized aggregate...

[interma]

Github user interma commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1361#discussion_r187231278
  
--- Diff: contrib/vexecutor/vexecutor.c ---
@@ -117,7 +122,7 @@ static void backportTupleDescriptor(PlanState* 
ps,TupleDesc td)
tuple = caql_getnext(pcqCtx);
 
if (!HeapTupleIsValid(tuple))
-   elog(ERROR, "cache lookup failed for type %u", 
oidtypeid);
+   continue;
--- End diff --

Why use `continue` instead of `elog ERROR` here?


---

[GitHub] incubator-hawq pull request #1361: HAWQ-1612. Implement vectorized aggregate...

[interma]

Github user interma commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1361#discussion_r187230968
  
--- Diff: contrib/vexecutor/vagg.h ---
@@ -0,0 +1,94 @@
+#ifndef VAGG_H
+#define VAGG_H
+
+#include "executor/execHHashagg.h"
+
+/* batch hashagg group linklist header */
+typedef struct GroupData {
+   HashAggEntry *entry;// pointer to agg_hash_entry
+   int idx;// pointer to idx_list
--- End diff --

Refine my poor comments:
1. use /**/ instead //.
2. unify the ident.



---

[GitHub] incubator-hawq pull request #1361: HAWQ-1612. Implement vectorized aggregate...

[interma]

Github user interma commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1361#discussion_r187231898
  
--- Diff: contrib/vexecutor/vagg.h ---
@@ -0,0 +1,94 @@
+#ifndef VAGG_H
+#define VAGG_H
+
+#include "executor/execHHashagg.h"
+
+/* batch hashagg group linklist header */
+typedef struct GroupData {
+   HashAggEntry *entry;// pointer to agg_hash_entry
+   int idx;// pointer to idx_list
+} GroupData;
+
+/* batch hashagg group data */
+typedef struct BatchAggGroupData{
+   GroupData   group_header[1024]; //group linklist header
--- End diff --

1024, use a macro is better.


---

[jira] [Assigned] (HAWQ-1608) Implement Printing Runtime Filter Information For "explain" and "explain analyze"

[Lin Wen (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HAWQ-1608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lin Wen reassigned HAWQ-1608:
-

Assignee: Lin Wen  (was: Lei Chang)

> Implement Printing Runtime Filter Information For "explain" and "explain 
> analyze"
> -
>
> Key: HAWQ-1608
> URL: https://issues.apache.org/jira/browse/HAWQ-1608
> Project: Apache HAWQ
>  Issue Type: Sub-task
>  Components: Planner, Query Execution
>Reporter: Lin Wen
>Assignee: Lin Wen
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (HAWQ-1607) Implement Applying Bloom filter During Scan outer table

[Lin Wen (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HAWQ-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lin Wen resolved HAWQ-1607.
---
   Resolution: Fixed
Fix Version/s: 2.3.0.0-incubating

> Implement Applying Bloom filter During Scan outer table
> ---
>
> Key: HAWQ-1607
> URL: https://issues.apache.org/jira/browse/HAWQ-1607
> Project: Apache HAWQ
>  Issue Type: Sub-task
>  Components: Optimizer, Query Execution
>Reporter: Lin Wen
>Assignee: Lin Wen
>Priority: Major
> Fix For: 2.3.0.0-incubating
>
>
> This subtask will implement
>  # Pass down Bloom filter structure to outer table scan;
>  # Check if the tuple from outer table is found in Bloom filter structure.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] incubator-hawq pull request #1360: HAWQ-1607. This commit implements applyin...

[linwen]

Github user linwen closed the pull request at:

https://github.com/apache/incubator-hawq/pull/1360


---

[GitHub] incubator-hawq issue #1360: HAWQ-1607. This commit implements applying Bloom...

[linwen]

Github user linwen commented on the issue:

https://github.com/apache/incubator-hawq/pull/1360
  
merged into master.


---

[GitHub] incubator-hawq pull request #1362: HAWQ-1613. Create Date based Vectorized t...

[weinan003]

GitHub user weinan003 opened a pull request:

https://github.com/apache/incubator-hawq/pull/1362

HAWQ-1613. Create Date based Vectorized type and relevant expression



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/weinan003/incubator-hawq newtype

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/1362.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1362


commit de32bc2f264d2084d4399b3054ce2e59aaca40d3
Author: Weinan Wang 
Date:   2018-05-08T05:01:19Z

create vdate type for VE




---

[jira] [Assigned] (HAWQ-1613) Create Date based Vectorized type and relevant expression

[WANG Weinan (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HAWQ-1613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

WANG Weinan reassigned HAWQ-1613:
-

Assignee: WANG Weinan  (was: Lei Chang)

> Create Date based Vectorized type and relevant expression 
> --
>
> Key: HAWQ-1613
> URL: https://issues.apache.org/jira/browse/HAWQ-1613
> Project: Apache HAWQ
>  Issue Type: Sub-task
>  Components: Query Execution
>Reporter: WANG Weinan
>Assignee: WANG Weinan
>Priority: Major
> Fix For: backlog
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (HAWQ-1613) Create Date based Vectorized type and relevant expression

[WANG Weinan (JIRA)]

WANG Weinan created HAWQ-1613:
-

 Summary: Create Date based Vectorized type and relevant expression 
 Key: HAWQ-1613
 URL: https://issues.apache.org/jira/browse/HAWQ-1613
 Project: Apache HAWQ
  Issue Type: Sub-task
  Components: Query Execution
Reporter: WANG Weinan
Assignee: Lei Chang
 Fix For: backlog






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] incubator-hawq issue #1315: HAWQ-1556. enable ALTER SCHEMA RENAME/OWNER

[radarwave]

Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1315
  
Seems alter schema is disabled with intentional.

Anyone knows the background why we disabled it?


---