[GitHub] incubator-hawq issue #1377: HAWQ-1627. Support setting the max protocol mess...
Github user amyrazz44 commented on the issue: https://github.com/apache/incubator-hawq/pull/1377 LGTM +1 ---
[GitHub] incubator-hawq issue #1376: [RFC] Changed libhdfs3 to be ABI compatible with...
Github user amyrazz44 commented on the issue: https://github.com/apache/incubator-hawq/pull/1376 Please create [Apache HAWQ JIRA](https://issues.apache.org/jira/projects/HAWQ/summary) for your commit and add the corresponding test for your code changes. Thanks. ---
[GitHub] incubator-hawq issue #1371: HAWQ-1620. Push down target list information(pi_...
Github user amyrazz44 commented on the issue: https://github.com/apache/incubator-hawq/pull/1371 LGTM +1 ---
[GitHub] incubator-hawq issue #1349: HAWQ-1598. Vectorized Scan Node Framework initia...
Github user amyrazz44 commented on the issue: https://github.com/apache/incubator-hawq/pull/1349 LGTM +1 ---
[GitHub] incubator-hawq issue #1308: HAWQ-1530. Illegally killing a JDBC select query...
Github user amyrazz44 commented on the issue: https://github.com/apache/incubator-hawq/pull/1308 LGTM +1 ---
[GitHub] incubator-hawq pull request #1288: HAWQ-1518. Add a UDF for showing whether ...
Github user amyrazz44 closed the pull request at: https://github.com/apache/incubator-hawq/pull/1288 ---
[GitHub] incubator-hawq issue #1288: HAWQ-1518. Add a UDF for showing whether the dat...
Github user amyrazz44 commented on the issue: https://github.com/apache/incubator-hawq/pull/1288 @wengyanqing @interma Pls feel free to review this pr. Thank you. ---
[GitHub] incubator-hawq pull request #1288: HAWQ-1518. Add a UDF for showing whether ...
GitHub user amyrazz44 opened a pull request: https://github.com/apache/incubator-hawq/pull/1288 HAWQ-1518. Add a UDF for showing whether the data directory is an encryption zone. You can merge this pull request into a Git repository by running: $ git pull https://github.com/amyrazz44/incubator-hawq TDEUDF Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/1288.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1288 commit 25d176bb19f049d36a97c691fb1ede5308a86ea1 Author: amyrazz44 <a...@pivotal.io> Date: 2017-09-14T10:18:03Z HAWQ-1518. Add a UDF for showing whether the data directory is an encryption zone. ---
[GitHub] incubator-hawq pull request #1243: HAWQ-1458. Fix share input scan bug for w...
Github user amyrazz44 closed the pull request at: https://github.com/apache/incubator-hawq/pull/1243 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1279: HAWQ-1310. Reformat resource_negotiator()...
Github user amyrazz44 closed the pull request at: https://github.com/apache/incubator-hawq/pull/1279 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1280: HAWQ-1510. Add TDE-related functionality into ha...
Github user amyrazz44 commented on the issue: https://github.com/apache/incubator-hawq/pull/1280 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1280: HAWQ-1510. Add TDE-related functionality ...
Github user amyrazz44 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1280#discussion_r132901535
--- Diff: src/bin/gpcheckhdfs/gpcheckhdfs.c ---
@@ -110,6 +114,12 @@ int main(int argc, char * argv[]) {
krb_keytabfile = argv[5];
}
+//get tde key name param
+for (int i = 1; i < argc; i++) {
+if (strcmp(argv[i], "--with-tde") == 0 && i+1 < argc)
+tde_keyname = argv[i+1];
--- End diff --
Add some comments in code about this will be better.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1279: HAWQ-1310. Reformat resource_negotiator()...
GitHub user amyrazz44 opened a pull request: https://github.com/apache/incubator-hawq/pull/1279 HAWQ-1310. Reformat resource_negotiator(). @jiny2 @linwen pls feel free to review this pull request, thank you. You can merge this pull request into a Git repository by running: $ git pull https://github.com/amyrazz44/incubator-hawq RM Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/1279.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1279 commit 2d98f0b3ae013a76a28f4c045a9e719eb1276d2e Author: amyrazz44 <a...@pivotal.io> Date: 2017-08-09T02:57:14Z HAWQ-1310. Reformat resource_negotiator(). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1275: HAWQ-1333. Change access mode of source f...
Github user amyrazz44 closed the pull request at: https://github.com/apache/incubator-hawq/pull/1275 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1276: HAWQ-1511. Add TDE-related properties int...
GitHub user amyrazz44 opened a pull request: https://github.com/apache/incubator-hawq/pull/1276 HAWQ-1511. Add TDE-related properties into hdfs-client.xml @wengyanqing @interma pls feel free to review this pull request, thank you. You can merge this pull request into a Git repository by running: $ git pull https://github.com/amyrazz44/incubator-hawq TDEConf Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/1276.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1276 commit c0cd47c3d00b76209aa1587771e2f493ed99fa65 Author: amyrazz44 <a...@pivotal.io> Date: 2017-08-09T06:10:20Z HAWQ-1511. Add TDE-related properties into hdfs-client.xml --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1274: HAWQ-1509. Support TDE read function.
Github user amyrazz44 closed the pull request at: https://github.com/apache/incubator-hawq/pull/1274 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1275: HAWQ-1333. Change access mode of source f...
GitHub user amyrazz44 opened a pull request: https://github.com/apache/incubator-hawq/pull/1275 HAWQ-1333. Change access mode of source files for HAWQ. @radarwave @linwen feel free to review this pr, thank you so much. You can merge this pull request into a Git repository by running: $ git pull https://github.com/amyrazz44/incubator-hawq fixAccessMode Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/1275.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1275 commit 685d58af6dbaeb024840c6d3ffa75a2af00a85b9 Author: amyrazz44 <a...@pivotal.io> Date: 2017-08-07T10:13:57Z HAWQ-1333. Change access mode of source files for HAWQ. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1274: HAWQ-1509. Support TDE read function.
Github user amyrazz44 commented on the issue: https://github.com/apache/incubator-hawq/pull/1274 @wengyanqing @linwen feel free to review this pr, thank you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1274: HAWQ-1509. Support TDE read function.
GitHub user amyrazz44 opened a pull request: https://github.com/apache/incubator-hawq/pull/1274 HAWQ-1509. Support TDE read function. You can merge this pull request into a Git repository by running: $ git pull https://github.com/amyrazz44/incubator-hawq TDEReadPart Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/1274.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1274 commit 90f1c4ded4321adfa98a691a0b1b47f727316738 Author: amyrazz44 <a...@pivotal.io> Date: 2017-08-07T04:53:36Z HAWQ-1509. Support TDE read function. commit 45ddd1f471bceae25a9f16d2f38442e4898344c9 Author: interma <inte...@outlook.com> Date: 2017-08-07T05:44:45Z HAWQ-1509. Add TDE read test cases. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1273: HAWQ-1502. Add verification to support TD...
GitHub user amyrazz44 opened a pull request: https://github.com/apache/incubator-hawq/pull/1273 HAWQ-1502. Add verification to support TDE write function. You can merge this pull request into a Git repository by running: $ git pull https://github.com/amyrazz44/incubator-hawq TDEWritePart Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/1273.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1273 commit 212b791ede9e7a409f1871805f3dbff306d7fb9b Author: amyrazz44 <a...@pivotal.io> Date: 2017-07-31T09:45:30Z HAWQ-1502. Add verification to support TDE write function. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1265: HAWQ-1500. HAWQ-1501. HAWQ-1502. Support ...
Github user amyrazz44 closed the pull request at: https://github.com/apache/incubator-hawq/pull/1265 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1265: HAWQ-1500. HAWQ-1501. HAWQ-1502. Support TDE wri...
Github user amyrazz44 commented on the issue: https://github.com/apache/incubator-hawq/pull/1265 Only support TDE write function on single data node. Will support multiple data nodes in the next pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1265: HAWQ-1500. HAWQ-1501. HAWQ-1502. Support ...
GitHub user amyrazz44 opened a pull request: https://github.com/apache/incubator-hawq/pull/1265 HAWQ-1500. HAWQ-1501. HAWQ-1502. Support TDE write function. You can merge this pull request into a Git repository by running: $ git pull https://github.com/amyrazz44/incubator-hawq TDEWrite Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/1265.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1265 commit 1c41023612b799afa95f4408f0b20c516c19a791 Author: amyrazz44 <a...@pivotal.io> Date: 2017-07-11T07:43:18Z HAWQ-1500. Support TDE by adding a common class HttpClient to get response from KMS. commit 5d3b0ad6e974ccb693735342181c4c6939b13603 Author: amyrazz44 <a...@pivotal.io> Date: 2017-07-11T07:51:32Z HAWQ-1501. Support TDE by adding KmsClientProvider class to interact with KMS server. commit a2c62c5c11b9e05b8c37360d23965d5d18c34e73 Author: amyrazz44 <a...@pivotal.io> Date: 2017-07-11T07:57:26Z HAWQ-1502. Support TDE write function. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1265: HAWQ-1500. HAWQ-1501. HAWQ-1502. Support TDE wri...
Github user amyrazz44 commented on the issue: https://github.com/apache/incubator-hawq/pull/1265 @linwen @interma Please feel free to review this pr. Thank you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1243: HAWQ-1458. Fix share input scan bug for w...
Github user amyrazz44 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1243#discussion_r118670052
--- Diff: src/backend/executor/nodeShareInputScan.c ---
@@ -793,15 +877,72 @@ shareinput_reader_waitready(int share_id,
PlanGenerator planGen)
}
else if(n==0)
{
- elog(DEBUG1, "SISC READER (shareid=%d, slice=%d): Wait
ready time out once",
- share_id, currentSliceId);
+ file_exists = access(writer_lock_file, F_OK);
+ if(file_exists != 0)
+ {
+ elog(DEBUG3, "Wait lock file for writer time
out interval is %d", timeout_interval);
+ if(timeout_interval >=
share_input_scan_wait_lockfile_timeout || flag == true) //If lock file never
exists or disappeared, reader will no longer waiting for writer
+ {
+ elog(LOG, "SISC READER (shareid=%d,
slice=%d): Wait ready time out and break",
+ share_id, currentSliceId);
+ pfree(writer_lock_file);
+ break;
+ }
+ timeout_interval += tval.tv_sec;
+ }
+ else
+ {
+ elog(LOG, "writer lock file of
shareinput_reader_waitready() is %s", writer_lock_file);
+ flag = true;
+ fd_lock = open(writer_lock_file, O_RDONLY);
+ if(fd_lock < 0)
+ {
+ elog(DEBUG3, "Open writer's lock file
%s failed!, error number is %d", writer_lock_file, errno);
+ }
+ lock = flock(fd_lock, LOCK_EX | LOCK_NB);
+ if(lock == -1)
+ {
+ elog(DEBUG3, "Lock writer's lock file
%s failed!, error number is %d", writer_lock_file, errno);
+ }
+ else if(lock == 0)
+ {
+ /*
+* There is one situation to consider
about.
+* Writer need a time interval to lock
the lock file after the lock file has been created.
+* So, if reader lock the lock file
ahead of writer, we should unlock it.
+* If reader lock the lock file after
writer, it means that writer process has abort.
+* We should break the loop to make
sure reader no longer wait for writer.
+*/
+ if(lock_count == 0)
+ {
+ lock = flock(fd_lock, LOCK_UN);
+ lock_count++;
--- End diff --
Because writer needs a time interval to lock the lock file. During the time
interval, if reader lock the lock file ahead of writer , reader should unlock
the lock file. In the code logic, lock_count==0 indicates the above logic.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1243: HAWQ-1458. Fix share input scan bug for w...
Github user amyrazz44 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1243#discussion_r118668389
--- Diff: src/backend/executor/nodeShareInputScan.c ---
@@ -793,15 +877,72 @@ shareinput_reader_waitready(int share_id,
PlanGenerator planGen)
}
else if(n==0)
{
- elog(DEBUG1, "SISC READER (shareid=%d, slice=%d): Wait
ready time out once",
- share_id, currentSliceId);
+ file_exists = access(writer_lock_file, F_OK);
+ if(file_exists != 0)
+ {
+ elog(DEBUG3, "Wait lock file for writer time
out interval is %d", timeout_interval);
+ if(timeout_interval >=
share_input_scan_wait_lockfile_timeout || flag == true) //If lock file never
exists or disappeared, reader will no longer waiting for writer
+ {
+ elog(LOG, "SISC READER (shareid=%d,
slice=%d): Wait ready time out and break",
+ share_id, currentSliceId);
+ pfree(writer_lock_file);
+ break;
+ }
+ timeout_interval += tval.tv_sec;
+ }
+ else
+ {
+ elog(LOG, "writer lock file of
shareinput_reader_waitready() is %s", writer_lock_file);
+ flag = true;
+ fd_lock = open(writer_lock_file, O_RDONLY);
+ if(fd_lock < 0)
+ {
+ elog(DEBUG3, "Open writer's lock file
%s failed!, error number is %d", writer_lock_file, errno);
--- End diff --
Writer needs time to create the lock file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1243: HAWQ-1458. Fix share input scan bug for w...
Github user amyrazz44 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1243#discussion_r118668142
--- Diff: src/backend/executor/nodeShareInputScan.c ---
@@ -793,15 +877,72 @@ shareinput_reader_waitready(int share_id,
PlanGenerator planGen)
}
else if(n==0)
{
- elog(DEBUG1, "SISC READER (shareid=%d, slice=%d): Wait
ready time out once",
- share_id, currentSliceId);
+ file_exists = access(writer_lock_file, F_OK);
+ if(file_exists != 0)
+ {
+ elog(DEBUG3, "Wait lock file for writer time
out interval is %d", timeout_interval);
+ if(timeout_interval >=
share_input_scan_wait_lockfile_timeout || flag == true) //If lock file never
exists or disappeared, reader will no longer waiting for writer
+ {
+ elog(LOG, "SISC READER (shareid=%d,
slice=%d): Wait ready time out and break",
+ share_id, currentSliceId);
+ pfree(writer_lock_file);
+ break;
+ }
+ timeout_interval += tval.tv_sec;
+ }
+ else
+ {
+ elog(LOG, "writer lock file of
shareinput_reader_waitready() is %s", writer_lock_file);
+ flag = true;
+ fd_lock = open(writer_lock_file, O_RDONLY);
+ if(fd_lock < 0)
+ {
+ elog(DEBUG3, "Open writer's lock file
%s failed!, error number is %d", writer_lock_file, errno);
--- End diff --
Reader try to lock the lock file which writer created until locked the lock
file successfully which means that writer process quits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1243: fix share input scan bug for writer part
Github user amyrazz44 commented on the issue: https://github.com/apache/incubator-hawq/pull/1243 @jiny2 @huor @paul-guo- , pls feel free to review this pr. thank you --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1243: fix share input scan bug for writer part
GitHub user amyrazz44 opened a pull request: https://github.com/apache/incubator-hawq/pull/1243 fix share input scan bug for writer part Using flock tmp file with unblock way to resolve this hung bug. The details are as below: For writer : Writer will create a tmp file and flock it once writer has created all the tuples before make the corresponding fifo. For reader : When select time out, reader will check the tmp file. If the tmp file never appear, reader will wait 5 minutes. After 5 minutes, reader will quit. If the tmp file exists, Reader will try to flock the tmp file which created by writer with unblock way. So if writer process quit, reader will flock the tmp file successfully, then reader will know there is something wrong with writer and will quit either. The reader wait for writer part will in the next pr. You can merge this pull request into a Git repository by running: $ git pull https://github.com/amyrazz44/incubator-hawq SISCWrtier Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/1243.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1243 commit 0583ba0c5b71deee198fae734fc76277ab2a5982 Author: amyrazz44 <a...@pivotal.io> Date: 2017-05-08T09:27:07Z fix share input scan bug for writer part --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1236: HAWQ-1457. Shared memory for SegmentStatus and M...
Github user amyrazz44 commented on the issue: https://github.com/apache/incubator-hawq/pull/1236 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1192: HAWQ-1412. Fix inconsistent json file for catalo...
Github user amyrazz44 commented on the issue: https://github.com/apache/incubator-hawq/pull/1192 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1190: HAWQ-1411. Fix inconsistent json file for catalo...
Github user amyrazz44 commented on the issue: https://github.com/apache/incubator-hawq/pull/1190 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1170: HAWQ-1371. Fix QE process hang in shared ...
Github user amyrazz44 closed the pull request at: https://github.com/apache/incubator-hawq/pull/1170 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1170: HAWQ-1371. Fix QE process hang in shared input s...
Github user amyrazz44 commented on the issue: https://github.com/apache/incubator-hawq/pull/1170 @huor @liming01 , please feel free to review, thank you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1157: HAWQ-1371. Fix QE process hang in shared ...
Github user amyrazz44 closed the pull request at: https://github.com/apache/incubator-hawq/pull/1157 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1157: HAWQ-1371. Fix QE process hang in shared input s...
Github user amyrazz44 commented on the issue: https://github.com/apache/incubator-hawq/pull/1157 Please refer to https://github.com/apache/incubator-hawq/pull/1170 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1170: HAWQ-1371. Fix QE process hang in shared ...
GitHub user amyrazz44 opened a pull request: https://github.com/apache/incubator-hawq/pull/1170 HAWQ-1371. Fix QE process hang in shared input scan. You can merge this pull request into a Git repository by running: $ git pull https://github.com/amyrazz44/incubator-hawq sisc Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/1170.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1170 commit fbf170f629c69eca4de48eb90fd3575ff6f036e8 Author: amyrazz44 <a...@pivotal.io> Date: 2017-03-07T08:02:39Z Revert "HAWQ-1342. Fixed QE process hang in shared input scan on segment node" The fix introduce hang regression in shared input scan query as described in HAWQ-1371 commit 1bab521a4f5aa63bf375f3c85851b1a8a6993db0 Author: amyrazz44 <a...@pivotal.io> Date: 2017-03-07T08:22:18Z HAWQ-1371. Fix QE process hang in shared input scan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1159: HAWQ-1359. Add additional policy for select view...
Github user amyrazz44 commented on the issue: https://github.com/apache/incubator-hawq/pull/1159 LGTMï¼1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1157: HAWQ-1371. Fix QE process hang in shared ...
GitHub user amyrazz44 opened a pull request: https://github.com/apache/incubator-hawq/pull/1157 HAWQ-1371. Fix QE process hang in shared input scan node You can merge this pull request into a Git repository by running: $ git pull https://github.com/amyrazz44/incubator-hawq ShareinputScan Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/1157.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1157 commit aa11788b0899bcc7a94dcf4380751e40e546a92e Author: amyrazz44 <a...@pivotal.io> Date: 2017-03-01T08:10:59Z HAWQ-1371. Fix QE process hang in shared input scan node --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1136: HAWQ-1348. Some hawq utility helps should say de...
Github user amyrazz44 commented on the issue: https://github.com/apache/incubator-hawq/pull/1136 looks good to me +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #:
Github user amyrazz44 commented on the pull request: https://github.com/apache/incubator-hawq/commit/b3cf1a29f7f97cd81f3c7f741a3f11c0b7f68d71#commitcomment-20989377 looks good to me +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1134: HAWQ-1345. Fixed relfile path bug: catalog and h...
Github user amyrazz44 commented on the issue: https://github.com/apache/incubator-hawq/pull/1134 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1128: HAWQ-1338. Fixed writer process doesn't exit nic...
Github user amyrazz44 commented on the issue: https://github.com/apache/incubator-hawq/pull/1128 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1125: HAWQ-1315. Function validateResourcePoolS...
Github user amyrazz44 closed the pull request at: https://github.com/apache/incubator-hawq/pull/1125 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1125: HAWQ-1315. Function validateResourcePoolStatus()...
Github user amyrazz44 commented on the issue: https://github.com/apache/incubator-hawq/pull/1125 @jiny2 @stanlyxiang pls feel free to review this pull request, thank you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1125: HAWQ-1315. Function validateResourcePoolS...
GitHub user amyrazz44 opened a pull request: https://github.com/apache/incubator-hawq/pull/1125 HAWQ-1315. Function validateResourcePoolStatus() in resourcepool.c is logging the wrong information You can merge this pull request into a Git repository by running: $ git pull https://github.com/amyrazz44/incubator-hawq resourcePool Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/1125.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1125 commit 44abc82bc90bad4db34472898c7c6d4dce7ca0ce Author: amyrazz44 <a...@pivotal.io> Date: 2017-02-15T05:32:13Z HAWQ-1315. Function validateResourcePoolStatus() in resourcepool.c is logging the wrong information --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1121: HAWQ-1323. Fix access mode of files in ad...
Github user amyrazz44 closed the pull request at: https://github.com/apache/incubator-hawq/pull/1121 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1121: HAWQ-1323. Fix access mode of files in adding li...
Github user amyrazz44 commented on the issue: https://github.com/apache/incubator-hawq/pull/1121 Will fix access mode of *.cpp and *.c files in the other commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1121: HAWQ-1323. Fix access mode of files in adding li...
Github user amyrazz44 commented on the issue: https://github.com/apache/incubator-hawq/pull/1121 @huor @paul-guo- please help review this pr, thank you --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1121: HAWQ-1323. Fix access mode of files in ad...
GitHub user amyrazz44 opened a pull request: https://github.com/apache/incubator-hawq/pull/1121 HAWQ-1323. Fix access mode of files in adding license header added to each source file in test directory You can merge this pull request into a Git repository by running: $ git pull https://github.com/amyrazz44/incubator-hawq access Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/1121.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1121 commit 4e139764f036f8b75ff08584c75e24eaf1fde157 Author: amyrazz44 <a...@pivotal.io> Date: 2017-02-14T09:00:37Z HAWQ-1323. Fix access mode of files in adding license header added to each source file in test directory --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1116: HAWQ-1323. Add license header added to each sour...
Github user amyrazz44 commented on the issue: https://github.com/apache/incubator-hawq/pull/1116 @huor @paul-guo- @linwen please help review this pull request. thank you --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1116: HAWQ-1323. Add license header added to ea...
GitHub user amyrazz44 opened a pull request: https://github.com/apache/incubator-hawq/pull/1116 HAWQ-1323. Add license header added to each source file in test directory You can merge this pull request into a Git repository by running: $ git pull https://github.com/amyrazz44/incubator-hawq License Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/1116.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1116 commit 418726453b705a2762ca6b8c384660e5a4a7d8be Author: amyrazz44 <a...@pivotal.io> Date: 2017-02-14T02:08:03Z HAWQ-1323. Add license header added to each source file in test directory commit df7c51e306bebc44bc550a159e7b63c13a0529c4 Author: amyrazz44 <a...@pivotal.io> Date: 2017-02-14T02:46:29Z HAWQ-1323. Add license header added to each source file in test directory commit fd663500671b8629b17d65063787a0ebd02cb813 Author: amyrazz44 <a...@pivotal.io> Date: 2017-02-14T02:54:13Z HAWQ-1323. Add license header added to each source file in test directory --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1108: HAWQ-1317. Port "Fix some regex issues wi...
Github user amyrazz44 closed the pull request at: https://github.com/apache/incubator-hawq/pull/1108 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1108: HAWQ-1317. Port "Fix some regex issues with out-...
Github user amyrazz44 commented on the issue: https://github.com/apache/incubator-hawq/pull/1108 We just port part of this pg bug fix for now which is fix out-of-range characters part, about the cancel_requested part, we will port in the future. Because postgres 9.6 adds some extra functions in regex code, e.g. cancel_requested logic. And this pg bug fix includes cancel_requested code. So, need more efforts to investigate whether we should add extra functions to regex code in the other commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1093: HAWQ-1193. Add createEncryption, getEZFor...
Github user amyrazz44 closed the pull request at: https://github.com/apache/incubator-hawq/pull/1093 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1093: HAWQ-1193. Add createEncryption, getEZFor...
Github user amyrazz44 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1093#discussion_r96570395
--- Diff: depends/libhdfs3/src/client/FileEncryptionInfo.h ---
@@ -0,0 +1,93 @@
+/
+ * 2014 -
+ * open source under Apache License Version 2.0
+ /
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#ifndef _HDFS_LIBHDFS3_CLIENT_FILEENCRYPTIONINFO_H_
+#define _HDFS_LIBHDFS3_CLIENT_FILEENCRYPTIONINFO_H_
+
+#include
+
+namespace Hdfs {
+
+class FileEncryptionInfo {
+public:
+FileEncryptionInfo() :
+ cryptoProtocolVersion(0), suite(0){
+}
+
+int getSuite() const {
+return suite;
+}
+
+void setSuite(int suite) {
+this->suite = suite;
+}
+
+int getCryptoProtocolVersion() const {
+return cryptoProtocolVersion;
+}
+
+void setCryptoProtocolVersion(int cryptoProtocolVersion) {
+this->cryptoProtocolVersion = cryptoProtocolVersion;
+}
+
+const char * getKey() const{
+return key.c_str();
--- End diff --
According to libhdfs3 coding format, all the related class choose char *
instead of sting as the data type. In the meanwhile,
ConstructHdfsEncryptionFileInfo() will call Strdup() to memcpy char * in
Hdfs.cpp. So, will use char * data type. Thank you, interma.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1093: HAWQ-1193. Add createEncryption, getEZForPath, l...
Github user amyrazz44 commented on the issue: https://github.com/apache/incubator-hawq/pull/1093 @wangzw @xunzhang @interma Please help review this pull request, thank you so much. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1014: HAWQ-858. Fix parser to understand case /...
Github user amyrazz44 closed the pull request at: https://github.com/apache/incubator-hawq/pull/1014 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1014: HAWQ-858. Fix parser to understand case /...
Github user amyrazz44 commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1014#discussion_r91430078 --- Diff: src/test/feature/query/test_parser.cpp --- @@ -0,0 +1,34 @@ +#include +#include +#include +#include +#include +#include +#include +#include +#include + --- End diff -- Will test this, thank you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1018: HAWQ-1162. Resource manager does not refe...
GitHub user amyrazz44 opened a pull request: https://github.com/apache/incubator-hawq/pull/1018 HAWQ-1162. Resource manager does not reference dynamic minimum water ⦠â¦level of each segment when it times out YARN containers You can merge this pull request into a Git repository by running: $ git pull https://github.com/amyrazz44/incubator-hawq resourcePool Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/1018.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1018 commit d8d597499af46300e35590f18a65910df8a62fed Author: amyrazz44 <a...@pivotal.io> Date: 2016-11-20T11:39:17Z HAWQ-1162. Resource manager does not reference dynamic minimum water level of each segment when it times out YARN containers --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1014: HAWQ-858. Fix parser to understand case / when e...
Github user amyrazz44 commented on the issue: https://github.com/apache/incubator-hawq/pull/1014 @huor @paul-guo- Please review the pull request . Thank you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1014: HAWQ-858. Fix parser to understand case /...
GitHub user amyrazz44 opened a pull request: https://github.com/apache/incubator-hawq/pull/1014 HAWQ-858. Fix parser to understand case / when expression in group by You can merge this pull request into a Git repository by running: $ git pull https://github.com/amyrazz44/incubator-hawq parserTest Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/1014.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1014 commit d5efb6be4508f13c9f238fc53a31cc1a800044a5 Author: amyrazz44 <a...@pivotal.io> Date: 2016-11-15T07:43:38Z HAWQ-858. Fix parser to understand case / when expression in group by --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #982: HAWQ-1126. Disable feature test case of Ex...
Github user amyrazz44 closed the pull request at: https://github.com/apache/incubator-hawq/pull/982 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1007: HAWQ-1148. Update gtest-parallel to make ...
Github user amyrazz44 closed the pull request at: https://github.com/apache/incubator-hawq/pull/1007 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1007: HAWQ-1148. Update gtest-parallel to make ...
Github user amyrazz44 commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1007#discussion_r87372883 --- Diff: src/test/feature/schedule.txt --- @@ -0,0 +1,6 @@ +#PARALLEL=* are the parallel tests to run, optional but should not be empty +#SERIAL=* are the serial tests to run, optional but should not be empty +#you can have several PARALLEL or SRRIAL + +PARALLEL=TestErrorTable.*:TestExternalTable.*:TestPreparedStatement.*:TestUDF.*:TestAOSnappy.*:TestAlterOwner.*:TestAlterTable.*:TestCreateTable.*:TestGuc.*:TestType.*:TestDatabase.*:TestParquet.*:TestPartition.*:TestSubplan.*:TestAggregate.*:TestCreateTypeComposite.*:TestGpDistRandom.*:TestInformationSchema.*:TestQueryInsert.*:TestQueryNestedCaseNull.*:TestQueryPolymorphism.*:TestQueryPortal.*:TestQueryPrepare.*:TestRowTypes.*:TestQuerySequence.*:TestCommonLib.*:TestToast.*:TestTransaction.*:TestCommand.*:TestCopy.*:TestExternalTable.TestExternalTableAll --- End diff -- @paul-guo- If users want to add new cases temporary , schedule file contains the test cases in hawq-ci will be easily changed to run test case. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1007: HAWQ-1148. Update gtest-parallel to make ...
Github user amyrazz44 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1007#discussion_r87323443
--- Diff: src/test/feature/gtest-parallel ---
@@ -285,41 +354,42 @@ else:
save_file = os.path.join(os.path.expanduser("~"), ".gtest-parallel-times")
times = TestTimes(save_file)
tests = []
+#pull all the tests into test_map dict, in order to mark the failed test
in FAILED log
+test_map = {}
+# mark the end of paralell test id by parallel_id
+parallel_id = 0
+
for test_binary in binaries:
command = [test_binary]
if options.gtest_also_run_disabled_tests:
command += ['--gtest_also_run_disabled_tests']
-
list_command = list(command)
+
+ if options.gtest_schedule != '' and options.gtest_filter != '':
+sys.exit("Option input failure : gtest_schedule and gtest_filter can
not use in the same time: \n")
+
+ if options.gtest_schedule != '':
+(pcount, filter_test) = get_schedule(options.gtest_schedule)
+for i in range(0, len(filter_test)):
--- End diff --
Will consider your suggestion in the future, while in this script this way
will be more suitable due to the deal with test_map.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1007: HAWQ-1148. Update gtest-parallel to make ...
Github user amyrazz44 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1007#discussion_r87322601
--- Diff: src/test/feature/gtest-parallel ---
@@ -234,6 +234,71 @@ class TestTimes(object):
except IOError:
pass # ignore errors---saving the times isn't that important
+
+def get_schedule(schedule_file):
+ "read schedule file from --gtest_schedule option"
+ try:
+file = open(schedule_file, 'r')
+ except (EOFError, IOError):
+sys.exit("Read file error")
+
+ filter_test = []
+ ptest = []
+ stest = []
--- End diff --
Will consider , thank you
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1007: HAWQ-1148. Update gtest-parallel to make ...
Github user amyrazz44 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1007#discussion_r87322394
--- Diff: src/test/feature/gtest-parallel ---
@@ -170,7 +170,7 @@ class FilterFormat:
self.out.permanent_line("FAILED TESTS (%d/%d):"
% (len(self.failures), self.total_tests))
for (binary, test) in self.failures:
-self.out.permanent_line(" " + binary + ": " + test)
+self.out.permanent_line(" " + binary + ": " + test + " [" +
test_map[test] + "]")
--- End diff --
Just to keep consistence with the origin code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1007: HAWQ-1148. Update gtest-parallel to make ...
Github user amyrazz44 commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1007#discussion_r87322353 --- Diff: src/test/feature/gtest-parallel --- @@ -234,6 +234,71 @@ class TestTimes(object): except IOError: pass # ignore errors---saving the times isn't that important + +def get_schedule(schedule_file): + "read schedule file from --gtest_schedule option" + try: +file = open(schedule_file, 'r') --- End diff -- Will refine this, thank you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1007: HAWQ-1148. Update gtest-parallel to make ...
Github user amyrazz44 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1007#discussion_r87322273
--- Diff: src/test/feature/gtest-parallel ---
@@ -234,6 +234,71 @@ class TestTimes(object):
except IOError:
pass # ignore errors---saving the times isn't that important
+
+def get_schedule(schedule_file):
+ "read schedule file from --gtest_schedule option"
+ try:
+file = open(schedule_file, 'r')
+ except (EOFError, IOError):
+sys.exit("Read file error")
+
+ filter_test = []
+ ptest = []
+ stest = []
+
+ for line in file.readlines():
--- End diff --
Will consider this, thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1007: HAWQ-1148. Update gtest-parallel to make sure te...
Github user amyrazz44 commented on the issue: https://github.com/apache/incubator-hawq/pull/1007 @paul-guo- @xunzhang pls review this pr , thank you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #1007: HAWQ-1148. Update gtest-parallel to make ...
GitHub user amyrazz44 opened a pull request: https://github.com/apache/incubator-hawq/pull/1007 HAWQ-1148. Update gtest-parallel to make sure test case can run in bo⦠â¦th parallel way and serial way Signed-off-by: wengyanqing <wengyanq...@gmail.com> You can merge this pull request into a Git repository by running: $ git pull https://github.com/amyrazz44/incubator-hawq scheduleTest Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/1007.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1007 commit 1a5b421917efd9e3f89093647a5ce365e4b0c852 Author: amyrazz44 <a...@pivotal.io> Date: 2016-11-08T08:03:55Z HAWQ-1148. Update gtest-parallel to make sure test case can run in both parallel way and serial way Signed-off-by: wengyanqing <wengyanq...@gmail.com> --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #999: HAWQ-1140. Parallelize test cases for hawqregiste...
Github user amyrazz44 commented on the issue: https://github.com/apache/incubator-hawq/pull/999 LGTM ï¼1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #995: HAWQ-1139. Fix TestCreateTableInherits bug in the...
Github user amyrazz44 commented on the issue: https://github.com/apache/incubator-hawq/pull/995 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #984: HAWQ-955. Add runnable scripts for feature...
GitHub user amyrazz44 opened a pull request: https://github.com/apache/incubator-hawq/pull/984 HAWQ-955. Add runnable scripts for feature test running in parallel. You can merge this pull request into a Git repository by running: $ git pull https://github.com/amyrazz44/incubator-hawq HAWQ-955 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/984.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #984 commit a76c3988bff8e816ca6150efd090c2e0d068677a Author: xunzhang <xunzhang...@gmail.com> Date: 2016-09-12T05:36:12Z HAWQ-955. Add runnable scripts for feature test running in parallel. commit d7a528d2a2c8a5f331e8e4ea5553d31578696678 Author: amyrazz44 <a...@pivotal.io> Date: 2016-10-28T08:44:36Z HAWQ-955. Add runnable scripts for feature test running in parallel. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #982: HAWQ-1126. Disable feature test case of Ex...
GitHub user amyrazz44 opened a pull request: https://github.com/apache/incubator-hawq/pull/982 HAWQ-1126. Disable feature test case of ExternalTable temporarily You can merge this pull request into a Git repository by running: $ git pull https://github.com/amyrazz44/incubator-hawq featureTest Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/982.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #982 commit 534af7e77ac26e46644cad95fe7011afa25e7d9d Author: amyrazz44 <a...@pivotal.io> Date: 2016-10-28T03:27:58Z HAWQ-1126. Disable feature test case of ExternalTable temporarily --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #891: HAWQ-960. Remove the file BUILD_INSTRUCTIO...
Github user amyrazz44 closed the pull request at: https://github.com/apache/incubator-hawq/pull/891 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq pull request #891: HAWQ-960. Remove the file BUILD_INSTRUCTIO...
GitHub user amyrazz44 opened a pull request: https://github.com/apache/incubator-hawq/pull/891 HAWQ-960. Remove the file BUILD_INSTRUCTIONS.md and move the content â¦in it to README.md. You can merge this pull request into a Git repository by running: $ git pull https://github.com/amyrazz44/incubator-hawq HAWQ-960aa Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-hawq/pull/891.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #891 commit ebc3e52d393e678484d43aed5a0157a1fd1feace Author: amyrazz44 <a...@pivotal.io> Date: 2016-09-07T03:01:33Z HAWQ-960. Remove the file BUILD_INSTRUCTIONS.md and move the content in it to README.md. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
