Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1377
+1
---
Github user linwen commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1377#discussion_r196996343
--- Diff: depends/libhdfs3/src/rpc/RpcChannel.cpp ---
@@ -768,7 +771,15 @@ void RpcChannelImpl::readOneResponse(bool writeLock
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1372
+1
---
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1373
+1
---
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1371
merged to master.
---
Github user linwen closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1371
---
GitHub user linwen opened a pull request:
https://github.com/apache/incubator-hawq/pull/1371
HAWQ-1620. Push down target list information(pi_targetlist in structure
ProjectionInfo)
HAWQ-1620. Push down target list information(pi_targetlist in structure
ProjectionInfo) to scan when
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1368
merged.
---
Github user linwen closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1368
---
GitHub user linwen opened a pull request:
https://github.com/apache/incubator-hawq/pull/1368
HAWQ-1616. Fix the wrong result of hash join when enable Bloom filter.
The projection information of join keys hasn't been pushed down to parquet
scan correctly. It causes computing a wrong
GitHub user linwen opened a pull request:
https://github.com/apache/incubator-hawq/pull/1366
HAWQ-1615. Fix accessing invalid memory when run a hash-join query with
Bloomfilter enable.
The BloomFilter structure in RuntimeFilterState should be allocated,
instead of using
GitHub user linwen opened a pull request:
https://github.com/apache/incubator-hawq/pull/1363
HAWQ-1608. Implement Printing Runtime Filter Information For "explain
analyze"
Implement Printing Runtime Filter Information For "explain analyze"
Change GUC hawq_
Github user linwen closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1360
---
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1360
merged into master.
---
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1360
This commit doesn't contain test cases, test cases will be added with
HAWQ-1608. After finish HAWQ-1608, users can use "explain analyze" statement to
know if the Bloom filt
GitHub user linwen opened a pull request:
https://github.com/apache/incubator-hawq/pull/1360
HAWQ-1607. This commit implements applying Bloom filter during Scan outer
table
1. Pash down Bloom filter structure to outer table scan(only support
parquet);
2. Check if the tuple
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1356
+1
---
GitHub user linwen opened a pull request:
https://github.com/apache/incubator-hawq/pull/1355
HAWQ-1606. Fix "make unittest-check" error and set GUC error.
Please review, thanks!
You can merge this pull request into a Git repository by running:
$ git pull https://
Github user linwen closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1354
---
GitHub user linwen opened a pull request:
https://github.com/apache/incubator-hawq/pull/1354
HAWQ-1606. Implement Deciding to Create Bloom Filter During Query Plan And
Create Bloom filter For Inner Table
This commit implements deciding to create Bloom Filter during query plan
Github user linwen closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1352
---
GitHub user linwen opened a pull request:
https://github.com/apache/incubator-hawq/pull/1352
HAWQ-1604. Add A New GUC hawq_hashjoin_bloomfilter
HAWQ-1604. Add A New GUC hawq_hashjoin_bloomfilter to indicate if use Bloom
filter for hash join.
Remove gp_hashjoin_bloomfilter
Github user linwen commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1350#discussion_r178483664
--- Diff: contrib/vexecutor/vcheck.h ---
@@ -27,6 +27,8 @@ typedef struct vFuncMap
Oid ntype;
vheader* (* vtbuild)(int n
Github user linwen commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1350#discussion_r178483630
--- Diff: contrib/vexecutor/parquet_reader.c ---
@@ -0,0 +1,194 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user linwen commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1350#discussion_r178483636
--- Diff: contrib/vexecutor/parquet_reader.c ---
@@ -0,0 +1,194 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user linwen commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1350#discussion_r178484042
--- Diff: contrib/vexecutor/parquet_reader.c ---
@@ -0,0 +1,194 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user linwen commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1350#discussion_r178483643
--- Diff: contrib/vexecutor/parquet_reader.c ---
@@ -0,0 +1,194 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user linwen commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1350#discussion_r178483689
--- Diff: contrib/vexecutor/vcheck.h ---
@@ -37,6 +39,7 @@ typedef struct VectorizedState
{
bool vectorized;
PlanState *parent
Github user linwen commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1350#discussion_r178483545
--- Diff: contrib/vexecutor/ao_reader.c ---
@@ -0,0 +1,78 @@
+#include "ao_reader.h"
+#include "tuplebatch.h"
+#in
Github user linwen commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1350#discussion_r178483577
--- Diff: contrib/vexecutor/ao_reader.c ---
@@ -0,0 +1,78 @@
+#include "ao_reader.h"
+#include "tuplebatch.h"
+#in
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1346
+1
---
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1331
LGTM.
---
Github user linwen commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1307#discussion_r150475805
--- Diff: src/backend/cdb/cdbcat.c ---
@@ -296,7 +296,7 @@ GpPolicyStore(Oid tbloid, const GpPolicy *policy)
/*
* Sets the policy
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1308
+1
---
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1290
LGTM, +1
---
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1285
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user linwen commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1282#discussion_r136239626
--- Diff: src/bin/gpcheckhdfs/gpcheckhdfs.c ---
@@ -271,6 +273,21 @@ int testHdfsConnect(hdfsFS * fsptr, const char * host,
int iPort
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1243
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1278
Please see the comments.
The change LGTM. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user linwen commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1278#discussion_r132620396
--- Diff: src/backend/storage/file/fd.c ---
@@ -2403,8 +2479,22 @@ HdfsGetConnection(const char * path
Github user linwen commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1279#discussion_r132612133
--- Diff: src/backend/optimizer/plan/planner.c ---
@@ -438,256 +438,224 @@ PlannedStmt *refineCachedPlan(PlannedStmt *
plannedstmt
Github user linwen commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1279#discussion_r132612181
--- Diff: src/backend/optimizer/plan/planner.c ---
@@ -438,256 +438,224 @@ PlannedStmt *refineCachedPlan(PlannedStmt *
plannedstmt
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1275
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1274
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user linwen commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1273#discussion_r130778902
--- Diff: depends/libhdfs3/test/function/TestCInterface.cpp ---
@@ -369,29 +448,154 @@ TEST(TestCInterfaceTDE,
TestAppendWithTDELargeFiles_Success
Github user linwen commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1265#discussion_r127118606
--- Diff: depends/libhdfs3/src/client/CryptoCodec.cpp ---
@@ -0,0 +1,163
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1265
Please unify the indent. We should avoid use both "space" and "tab" for
indent in one source file.
---
If your project is set up for it, you can reply to this email
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1254
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1262
This PR has been merged into master. Please close it. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1262
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user linwen commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1262#discussion_r125064275
--- Diff:
ranger-plugin/admin-plugin/src/main/java/org/apache/hawq/ranger/service/HawqClient.java
---
@@ -74,7 +72,7 @@
private static
Github user linwen commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1262#discussion_r125064432
--- Diff:
ranger-plugin/admin-plugin/src/main/java/org/apache/hawq/ranger/service/HawqClient.java
---
@@ -90,6 +88,8 @@
public HawqClient
GitHub user linwen opened a pull request:
https://github.com/apache/incubator-hawq/pull/1258
HAWQ-1458. The maximum value of guc share_input_scan_wait_lockfile_timeout
should be greater than the default value.
fix a bug which cause HAWQ debug version failed in initializing.
You
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1257
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1256
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1254
Shubham, I think what you've done in this PR is to add a command for hawq,
which can reload GUC configs without restarting the system. Currently, this is
done by this command "hawq
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1251
Shubham, this PR has been merged into master. Would you please close it?
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1251
merged, this pr can be closed now. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1251
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1226
I don't think it is a good way to explicitly copy jar files in Makefile, it
should be done in mvn building file. So Xiang, would you like to make sure if
this failure still exist
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1251
Ed, I agree with you on adding documentation for this utility. I have some
concern on adding a test case, is it a little bit strange to have a core dump
file in source repository(maybe two
Github user linwen commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1251#discussion_r120526700
--- Diff: tools/sbin/packcore ---
@@ -0,0 +1,262 @@
+#!/bin/env python
+# Licensed to the Apache Software Foundation (ASF) under one
Github user linwen commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1251#discussion_r120278044
--- Diff: tools/sbin/packcore ---
@@ -0,0 +1,262 @@
+#!/bin/env python
+# Licensed to the Apache Software Foundation (ASF) under one
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1244
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user linwen closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1242
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user linwen commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1242#discussion_r116961874
--- Diff: src/backend/libpq/rangerrest.c ---
@@ -453,23 +453,30 @@ static int call_ranger_rest(CURL_HANDLE curl_handle,
const char* request
Github user linwen closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1241
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user linwen commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1241#discussion_r116679611
--- Diff: src/backend/libpq/rangerrest.c ---
@@ -464,6 +466,11 @@ static int call_ranger_rest(CURL_HANDLE curl_handle,
const char* request
GitHub user linwen opened a pull request:
https://github.com/apache/incubator-hawq/pull/1241
HAWQ-1436. Print a message to command line if hawq switches from standby
RPS to master RPS
This improvement happens in such case: hawq master is talking with standby
RPS, when master's RPS
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1235
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1238
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1234
Fix and merge into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user linwen closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1234
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user linwen commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1235#discussion_r115417102
--- Diff: ranger-plugin/scripts/enable-ranger-plugin.sh ---
@@ -104,8 +157,20 @@ function get_hawq_password() {
done
Github user linwen commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1235#discussion_r115417172
--- Diff: ranger-plugin/scripts/enable-ranger-plugin.sh ---
@@ -237,9 +307,14 @@ main() {
if [[ $# -lt 1 ]]; then
usage
fi
Github user linwen commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1235#discussion_r115417038
--- Diff: ranger-plugin/scripts/enable-ranger-plugin.sh ---
@@ -70,14 +70,47 @@ function get_ranger_password() {
done
}
+# get
GitHub user linwen opened a pull request:
https://github.com/apache/incubator-hawq/pull/1234
HAWQ-1436. Implement ranger pulgin service High Availability.
1. master will the connect to standby RPS for policy search if RPS on
master failed;
2. if master has been talking
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1233
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1229
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1231
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1228
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1220
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1219
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1219
Does this fix mean only percentage format of MEMORY_CLUSTER_LIMIT and
CORE_CLUSTER_LIMIT are supported in ALTER RESOURCE QUEUE DDL?
---
If your project is set up for it, you can reply
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1201
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1194
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user linwen commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1194#discussion_r108129930
--- Diff: src/test/feature/Ranger/test_ranger.cpp ---
@@ -314,6 +314,35 @@ TEST_F(TestHawqRanger, ResourceIncludeATest
Github user linwen commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1194#discussion_r108130047
--- Diff: src/test/feature/Ranger/test_ranger.cpp ---
@@ -314,6 +314,35 @@ TEST_F(TestHawqRanger, ResourceIncludeATest
Github user linwen closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1180
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user linwen closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1174
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user linwen opened a pull request:
https://github.com/apache/incubator-hawq/pull/1174
HAWQ-1359. Remove getRangerHost() function from ranger test,
still use environment variable to specify the Ranger Admin.
Please review, thanks!
You can merge this pull request
Github user linwen closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1171
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user linwen commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1171#discussion_r106084037
--- Diff: src/test/feature/Ranger/test_ranger.cpp ---
@@ -24,19 +24,34 @@
#include "lib/command.h"
#include &quo
Github user linwen commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1171#discussion_r106080149
--- Diff: src/test/feature/lib/sql_util.cpp ---
@@ -224,7 +225,9 @@ const string SQLUtility::generateSQLFile(const string
, bool usingDefaul
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1172
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1171
It has passed jenkins and travis check, I think it can pass license check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user linwen commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1172#discussion_r105848316
--- Diff: tools/bin/hawq_ctl ---
@@ -835,6 +835,8 @@ class HawqStop:
acl_type = rows.next()[1]
conn.close
Github user linwen commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1172#discussion_r105848224
--- Diff: tools/bin/hawq_ctl ---
@@ -835,6 +835,8 @@ class HawqStop:
acl_type = rows.next()[1]
conn.close
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1171
This file already has license header.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user linwen opened a pull request:
https://github.com/apache/incubator-hawq/pull/1171
HAWQ-1359. Add test cases for Ranger support, combinations of differeâ¦
Please review, thanks!
You can merge this pull request into a Git repository by running:
$ git pull https
1 - 100 of 238 matches
Mail list logo
