Github user interma commented on the issue:
https://github.com/apache/incubator-hawq/pull/1376
@superbobry
Merged, please close this PR, thanks.
---
Github user interma commented on the issue:
https://github.com/apache/incubator-hawq/pull/1376
@wangzw thanks!
---
Github user superbobry commented on the issue:
https://github.com/apache/incubator-hawq/pull/1376
I'd appreciate if you guys could also have a look at my question in the
JIRA ticket on the inefficiency of hdfsPread.
---
Github user interma commented on the issue:
https://github.com/apache/incubator-hawq/pull/1376
@superbobry all tests passed, cool!
@amyrazz44 @wengyanqing for another +1.
Thanks.
---
Github user interma commented on the issue:
https://github.com/apache/incubator-hawq/pull/1376
@superbobry
Code review is ok, I need to do more tests to verify your modification.
I will @ you if all tests pass (or provide failure massages so that you can
fix them), I
Github user superbobry commented on the issue:
https://github.com/apache/incubator-hawq/pull/1376
@interma this is OK with me. Do you think the PR is good to merge?
---
Github user interma commented on the issue:
https://github.com/apache/incubator-hawq/pull/1376
@superbobry
As I known, no/not many person declare that they depend on libhdfs3. In the
past, they just make a copy into their repo if need it (not a good things, but
understandable,
Github user superbobry commented on the issue:
https://github.com/apache/incubator-hawq/pull/1376
Hi @interma, thank you for the review.
Regarding hdfsFlush: what I meant was how to proceed with making its
behaviour compatible with libhdfs, i.e. removing the H part from the
Github user interma commented on the issue:
https://github.com/apache/incubator-hawq/pull/1376
@superbobry Thanks for your PR and sorry for response late.
* hdfsPread, LGTM, thanks for your tests.
* hdfsSync, LGTM
Looks you just added a new `hdfsHSync()` function and
Github user superbobry commented on the issue:
https://github.com/apache/incubator-hawq/pull/1376
@amyrazz44, @wangzw thanks for the feedback! Could you kindly comment on my
concern regarding the behaviour of `hdfsSync`?
---
10 matches
Mail list logo
