Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1180#discussion_r107157220
--- Diff: src/backend/catalog/aclchk.c ---
@@ -2335,19 +2335,25 @@ char *getClassNameFromOid(Oid object_oid)
" WHERE oid = :1",
ObjectIdGetDatum(object_oid)));
if (schema_name_oid == InvalidOid)
- elog(ERROR, "oid [%u] not found in table pg_class", object_oid);
+elog(ERROR, "oid [%u] not found in table pg_class", object_oid);
char* schema_name= caql_getcstring(
NULL,
cql("select nspname from pg_namespace "
-" WHERE oid = :1",
-ObjectIdGetDatum(schema_name_oid)));
+ " WHERE oid = :1",
+ ObjectIdGetDatum(schema_name_oid)));
if (schema_name == NULL)
elog(ERROR, "oid [%u] not found in table pg_namespace", object_oid);
- char* database_name = get_database_name(MyDatabaseId);
+ Oid dboid = InvalidOid;
--- End diff --
Could you extract this code graph as a separate function, so that there
won't be duplicated code? Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
