[GitHub] incubator-hawq pull request #837: HAWQ-779 support pxf filter pushdwon at th...

Github user jiadexin closed the pull request at: https://github.com/apache/incubator-hawq/pull/837 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-hawq pull request #837: HAWQ-779 support pxf filter pushdwon at th...

Github user jiadexin commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/837#discussion_r79295676 --- Diff: src/backend/optimizer/plan/createplan.c --- @@ -1144,9 +1144,15 @@ static char** create_pxf_plan(char **segdb_file_map, RelOptInfo *rel,

[GitHub] incubator-hawq pull request #837: HAWQ-779 support pxf filter pushdwon at th...

Github user jiadexin commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/837#discussion_r79295630 --- Diff: src/backend/optimizer/plan/createplan.c --- @@ -1144,9 +1144,15 @@ static char** create_pxf_plan(char **segdb_file_map, RelOptInfo *rel,

[GitHub] incubator-hawq pull request #837: HAWQ-779 support pxf filter pushdwon at th...

Github user hornn commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/837#discussion_r78508860 --- Diff: src/backend/optimizer/plan/createplan.c --- @@ -1144,9 +1144,15 @@ static char** create_pxf_plan(char **segdb_file_map, RelOptInfo *rel, int

[GitHub] incubator-hawq pull request #837: HAWQ-779 support pxf filter pushdwon at th...

Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/837#discussion_r77047594 --- Diff: pxf/pxf-hbase/src/main/java/org/apache/hawq/pxf/plugins/hbase/HBaseFilterBuilder.java --- @@ -165,6 +165,14 @@ private Filter

[GitHub] incubator-hawq pull request #837: HAWQ-779 support pxf filter pushdwon at th...

Github user jiadexin commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/837#discussion_r76547017 --- Diff: pxf/pxf-hbase/src/main/java/org/apache/hawq/pxf/plugins/hbase/HBaseFilterBuilder.java --- @@ -165,6 +165,14 @@ private Filter

[GitHub] incubator-hawq pull request #837: HAWQ-779 support pxf filter pushdwon at th...

Github user jiadexin commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/837#discussion_r76546715 --- Diff: pxf/pxf-api/src/test/java/org/apache/hawq/pxf/api/FilterParserTest.java --- @@ -215,6 +215,10 @@ public void parseColumnOnLeft() throws

[GitHub] incubator-hawq pull request #837: HAWQ-779 support pxf filter pushdwon at th...

Github user hsyuan commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/837#discussion_r76479540 --- Diff: pxf/pxf-hbase/src/main/java/org/apache/hawq/pxf/plugins/hbase/HBaseFilterBuilder.java --- @@ -165,6 +165,14 @@ private Filter

[GitHub] incubator-hawq pull request #837: HAWQ-779 support pxf filter pushdwon at th...

Github user GodenYao commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/837#discussion_r76469613 --- Diff: pxf/pxf-hbase/src/main/java/org/apache/hawq/pxf/plugins/hbase/HBaseFilterBuilder.java --- @@ -165,6 +165,14 @@ private Filter

[GitHub] incubator-hawq pull request #837: HAWQ-779 support pxf filter pushdwon at th...

Github user hsyuan commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/837#discussion_r76370526 --- Diff: pxf/pxf-api/src/test/java/org/apache/hawq/pxf/api/FilterParserTest.java --- @@ -215,6 +215,10 @@ public void parseColumnOnLeft() throws

[GitHub] incubator-hawq pull request #837: HAWQ-779 support pxf filter pushdwon at th...

Github user jiadexin commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/837#discussion_r76368428 --- Diff: src/backend/optimizer/plan/createplan.c --- @@ -1146,7 +1146,7 @@ static char** create_pxf_plan(char **segdb_file_map, RelOptInfo *rel,

[GitHub] incubator-hawq pull request #837: HAWQ-779 support pxf filter pushdwon at th...

Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/837#discussion_r76098154 --- Diff: src/backend/optimizer/plan/createplan.c --- @@ -1146,7 +1146,7 @@ static char** create_pxf_plan(char **segdb_file_map, RelOptInfo *rel,

[GitHub] incubator-hawq pull request #837: HAWQ-779 support pxf filter pushdwon at th...

Github user jiadexin commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/837#discussion_r74380940 --- Diff: src/backend/access/external/test/pxffilters_test.c --- @@ -61,7 +62,7 @@ test__supported_filter_type(void **state) /* go over

[GitHub] incubator-hawq pull request #837: HAWQ-779 support pxf filter pushdwon at th...

Github user kavinderd commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/837#discussion_r74286229 --- Diff: src/backend/access/external/test/pxffilters_test.c --- @@ -61,7 +62,7 @@ test__supported_filter_type(void **state) /* go

[GitHub] incubator-hawq pull request #837: HAWQ-779 support pxf filter pushdwon at th...

GitHub user jiadexin opened a pull request: https://github.com/apache/incubator-hawq/pull/837 HAWQ-779 support pxf filter pushdwon at the 'CREATE PLAN' stage ,and … 1.support pxf filter pushdwon at the 'CREATE PLAN' stage -- src/backend/optimizer/plan/createplan.c 2.Due to