[jira] [Commented] (HAWQ-716) Support code coverage build and report in hawq Makefile
[ https://issues.apache.org/jira/browse/HAWQ-716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15739125#comment-15739125 ] hongwu commented on HAWQ-716: - [~huor] > Support code coverage build and report in hawq Makefile > --- > > Key: HAWQ-716 > URL: https://issues.apache.org/jira/browse/HAWQ-716 > Project: Apache HAWQ > Issue Type: Improvement > Components: Build >Affects Versions: 2.0.0.0-incubating >Reporter: Ruilong Huo >Assignee: Ruilong Huo > Fix For: 2.0.0.0-incubating > > > We need to support code coverage build and report in hawq Makefile. The scope > include: > 1. Build hawq/libhdfs3/libyarn binaries with code coverage enabled > 2. Generate unified code coverage report for hawq/libhdfs3/libyarn -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HAWQ-716) Support code coverage build and report in hawq Makefile
[ https://issues.apache.org/jira/browse/HAWQ-716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15739122#comment-15739122 ] hongwu commented on HAWQ-716: - Hi [~ruilong], does the "Test HAWQ" section in this link(https://cwiki.apache.org/confluence/display/HAWQ/Build+and+Install) still work? > Support code coverage build and report in hawq Makefile > --- > > Key: HAWQ-716 > URL: https://issues.apache.org/jira/browse/HAWQ-716 > Project: Apache HAWQ > Issue Type: Improvement > Components: Build >Affects Versions: 2.0.0.0-incubating >Reporter: Ruilong Huo >Assignee: Ruilong Huo > Fix For: 2.0.0.0-incubating > > > We need to support code coverage build and report in hawq Makefile. The scope > include: > 1. Build hawq/libhdfs3/libyarn binaries with code coverage enabled > 2. Generate unified code coverage report for hawq/libhdfs3/libyarn -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HAWQ-716) Support code coverage build and report in hawq Makefile
[ https://issues.apache.org/jira/browse/HAWQ-716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15277541#comment-15277541 ] ASF GitHub Bot commented on HAWQ-716: - Github user huor closed the pull request at: https://github.com/apache/incubator-hawq/pull/636 > Support code coverage build and report in hawq Makefile > --- > > Key: HAWQ-716 > URL: https://issues.apache.org/jira/browse/HAWQ-716 > Project: Apache HAWQ > Issue Type: Improvement > Components: Build >Reporter: Ruilong Huo >Assignee: Ruilong Huo > > We need to support code coverage build and report in hawq Makefile. The scope > include: > 1. Build hawq/libhdfs3/libyarn binaries with code coverage enabled > 2. Generate unified code coverage report for hawq/libhdfs3/libyarn -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HAWQ-716) Support code coverage build and report in hawq Makefile
[ https://issues.apache.org/jira/browse/HAWQ-716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15275895#comment-15275895 ] ASF GitHub Bot commented on HAWQ-716: - Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/636#discussion_r62446449 --- Diff: src/bin/gpfdist/Makefile --- @@ -22,7 +22,8 @@ include $(top_builddir)/src/Makefile.global LIBS := -levent -lyaml -lz -lbz2 -lssl -lcrypto ifeq ($(BUILD_TYPE), gcov) -LIBS := -lgcov $(LIBS) +LIBS := -lgcov $(LIBS) --- End diff -- The indent of LIBS is correct since it is consistent with CFLAGS in next line. > Support code coverage build and report in hawq Makefile > --- > > Key: HAWQ-716 > URL: https://issues.apache.org/jira/browse/HAWQ-716 > Project: Apache HAWQ > Issue Type: Improvement > Components: Build >Reporter: Ruilong Huo >Assignee: Ruilong Huo > > We need to support code coverage build and report in hawq Makefile. The scope > include: > 1. Build hawq/libhdfs3/libyarn binaries with code coverage enabled > 2. Generate unified code coverage report for hawq/libhdfs3/libyarn -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HAWQ-716) Support code coverage build and report in hawq Makefile
[ https://issues.apache.org/jira/browse/HAWQ-716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15275893#comment-15275893 ] ASF GitHub Bot commented on HAWQ-716: - Github user xunzhang commented on the pull request: https://github.com/apache/incubator-hawq/pull/636#issuecomment-217767172 LGTM > Support code coverage build and report in hawq Makefile > --- > > Key: HAWQ-716 > URL: https://issues.apache.org/jira/browse/HAWQ-716 > Project: Apache HAWQ > Issue Type: Improvement > Components: Build >Reporter: Ruilong Huo >Assignee: Ruilong Huo > > We need to support code coverage build and report in hawq Makefile. The scope > include: > 1. Build hawq/libhdfs3/libyarn binaries with code coverage enabled > 2. Generate unified code coverage report for hawq/libhdfs3/libyarn -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HAWQ-716) Support code coverage build and report in hawq Makefile
[ https://issues.apache.org/jira/browse/HAWQ-716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15275889#comment-15275889 ] ASF GitHub Bot commented on HAWQ-716: - Github user xunzhang commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/636#discussion_r62446101 --- Diff: src/bin/gpfdist/Makefile --- @@ -22,7 +22,8 @@ include $(top_builddir)/src/Makefile.global LIBS := -levent -lyaml -lz -lbz2 -lssl -lcrypto ifeq ($(BUILD_TYPE), gcov) -LIBS := -lgcov $(LIBS) +LIBS := -lgcov $(LIBS) --- End diff -- indent > Support code coverage build and report in hawq Makefile > --- > > Key: HAWQ-716 > URL: https://issues.apache.org/jira/browse/HAWQ-716 > Project: Apache HAWQ > Issue Type: Improvement > Components: Build >Reporter: Ruilong Huo >Assignee: Ruilong Huo > > We need to support code coverage build and report in hawq Makefile. The scope > include: > 1. Build hawq/libhdfs3/libyarn binaries with code coverage enabled > 2. Generate unified code coverage report for hawq/libhdfs3/libyarn -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HAWQ-716) Support code coverage build and report in hawq Makefile
[ https://issues.apache.org/jira/browse/HAWQ-716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15271804#comment-15271804 ] ASF GitHub Bot commented on HAWQ-716: - Github user huor commented on the pull request: https://github.com/apache/incubator-hawq/pull/636#issuecomment-217060325 @paul-guo-, please find my comments below: 1. it now uses lcov, gcov, genhtml directory instead of using the absolute path, assuming they are system search path 2. lcov, gcov, genhtml are checked in configure already > Support code coverage build and report in hawq Makefile > --- > > Key: HAWQ-716 > URL: https://issues.apache.org/jira/browse/HAWQ-716 > Project: Apache HAWQ > Issue Type: Improvement > Components: Build >Reporter: Ruilong Huo >Assignee: Ruilong Huo > > We need to support code coverage build and report in hawq Makefile. The scope > include: > 1. Build hawq/libhdfs3/libyarn binaries with code coverage enabled > 2. Generate unified code coverage report for hawq/libhdfs3/libyarn -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HAWQ-716) Support code coverage build and report in hawq Makefile
[ https://issues.apache.org/jira/browse/HAWQ-716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270420#comment-15270420 ] ASF GitHub Bot commented on HAWQ-716: - Github user paul-guo- commented on the pull request: https://github.com/apache/incubator-hawq/pull/636#issuecomment-216817192 1) You might want to avoid using the absolute path of lcov, etc. (users could install them anywhere). 2) Does the code check whether lcov packages have been installed at the configure stage? > Support code coverage build and report in hawq Makefile > --- > > Key: HAWQ-716 > URL: https://issues.apache.org/jira/browse/HAWQ-716 > Project: Apache HAWQ > Issue Type: Improvement > Components: Build >Reporter: Ruilong Huo >Assignee: Ruilong Huo > > We need to support code coverage build and report in hawq Makefile. The scope > include: > 1. Build hawq/libhdfs3/libyarn binaries with code coverage enabled > 2. Generate unified code coverage report for hawq/libhdfs3/libyarn -- This message was sent by Atlassian JIRA (v6.3.4#6332)
