[
https://issues.apache.org/jira/browse/HAWQ-1184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hongwu updated HAWQ-1184:
-------------------------
Issue Type: Sub-task (was: Improvement)
Parent: HAWQ-1181
> Fix risky "-Wshift-negative-value, -Wparentheses-equality,
> -Wtautological-compare" types of compile warnings under osx
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: HAWQ-1184
> URL: https://issues.apache.org/jira/browse/HAWQ-1184
> Project: Apache HAWQ
> Issue Type: Sub-task
> Components: Build
> Reporter: hongwu
> Assignee: hongwu
> Fix For: 2.0.1.0-incubating
>
>
> http://pastebin.com/DwGqcxr8
> {code}
> url.c:1564:69: warning: shifting a negative signed value is undefined
> [-Wshift-negative-value]
> pstate->cur_lineno = line_number ? line_number - 1 :
> (int64) - 1 << 63;
>
> ~~~~~~~~~~~ ^
> heap.c:1615:19: warning: equality comparison with extraneous parentheses
> [-Wparentheses-equality]
> if ((relstorage == RELSTORAGE_PARQUET))
> ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
> planner.c:679:26: warning: equality comparison with extraneous parentheses
> [-Wparentheses-equality]
> if ((resourceLife == QRL_ONCE)) {
> ~~~~~~~~~~~~~^~~~~~~~~~~
> ./regc_locale.c:358:12: warning: comparison of unsigned expression >= 0 is
> always true [-Wtautological-compare]
> return (c >= 0 && c <= UCHAR_MAX && isdigit((unsigned char) c));
> ~ ^ ~
> ./regc_locale.c:364:12: warning: comparison of unsigned expression >= 0 is
> always true [-Wtautological-compare]
> return (c >= 0 && c <= UCHAR_MAX && isalpha((unsigned char) c));
> ~ ^ ~
> ./regc_locale.c:370:12: warning: comparison of unsigned expression >= 0 is
> always true [-Wtautological-compare]
> return (c >= 0 && c <= UCHAR_MAX && isalnum((unsigned char) c));
> ~ ^ ~
> ./regc_locale.c:376:12: warning: comparison of unsigned expression >= 0 is
> always true [-Wtautological-compare]
> return (c >= 0 && c <= UCHAR_MAX && isupper((unsigned char) c));
> ~ ^ ~
> ./regc_locale.c:382:12: warning: comparison of unsigned expression >= 0 is
> always true [-Wtautological-compare]
> return (c >= 0 && c <= UCHAR_MAX && islower((unsigned char) c));
> ~ ^ ~
> ./regc_locale.c:388:12: warning: comparison of unsigned expression >= 0 is
> always true [-Wtautological-compare]
> return (c >= 0 && c <= UCHAR_MAX && isgraph((unsigned char) c));
> ~ ^ ~
> ./regc_locale.c:394:12: warning: comparison of unsigned expression >= 0 is
> always true [-Wtautological-compare]
> return (c >= 0 && c <= UCHAR_MAX && isprint((unsigned char) c));
> ~ ^ ~
> ./regc_locale.c:400:12: warning: comparison of unsigned expression >= 0 is
> always true [-Wtautological-compare]
> return (c >= 0 && c <= UCHAR_MAX && ispunct((unsigned char) c));
> ~ ^ ~
> ./regc_locale.c:406:12: warning: comparison of unsigned expression >= 0 is
> always true [-Wtautological-compare]
> return (c >= 0 && c <= UCHAR_MAX && isspace((unsigned char) c));
> ~ ^ ~
> ./regc_locale.c:412:8: warning: comparison of unsigned expression >= 0 is
> always true [-Wtautological-compare]
> if (c >= 0 && c <= UCHAR_MAX)
> ~ ^ ~
> ./regc_locale.c:420:8: warning: comparison of unsigned expression >= 0 is
> always true [-Wtautological-compare]
> if (c >= 0 && c <= UCHAR_MAX)
> ~ ^ ~
> 11 warnings generated.
> fe-exec.c:2389:13: warning: comparison of unsigned enum expression < 0 is
> always false [-Wtautological-compare]
> if (status < 0 || status >= sizeof pgresStatus / sizeof
> pgresStatus[0])
> ~~~~~~ ^ ~
> /Users/wuhong/Desktop/2016-Pivotal/Code/github/incubator-hawq/src/bin/gpfdist/src/gpfdist/gpfdist.c:2515:41:
> warning: comparison of unsigned expression >= 0 is always true
> [-Wtautological-compare]
> if (r->in.davailable - buf_space_left >= 0)
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
> pg_filesystem.c:387:11: warning: comparison of unsigned enum expression < 0
> is always false [-Wtautological-compare]
> if(ftype < 0 || ftype >= FSYS_FUNC_TOTALNUM)
> ~~~~~ ^ ~
> pg_filesystem.c:397:11: warning: comparison of unsigned enum expression < 0
> is always false [-Wtautological-compare]
> if(ftype < 0 || ftype >= FSYS_FUNC_TOTALNUM)
> ~~~~~ ^ ~
> 2 warnings generated.
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
