[jira] [Commented] (HBASE-3963) Schedule all log-spliiting at startup all at once

2011-06-10 Thread mingjian (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13047045#comment-13047045 ] mingjian commented on HBASE-3963: - I passed all the tests.Is there any test failed for

[jira] [Commented] (HBASE-3892) Table can't disable

2011-06-10 Thread gaojinchao (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13047117#comment-13047117 ] gaojinchao commented on HBASE-3892: --- It didn't reproduce. So, My guess J-D is right.

[jira] [Commented] (HBASE-3976) Disable Block Cache On Compactions

2011-06-10 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13047162#comment-13047162 ] Andrew Purtell commented on HBASE-3976: --- +1 Except I don't think it needs be

[jira] [Commented] (HBASE-3962) HConnectionManager.getConnection(HBaseConfiguration) returns new connection in default HTable constructor

2011-06-10 Thread Philippe (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13047262#comment-13047262 ] Philippe commented on HBASE-3962: - Hi, Thank you very much for your message. I did check

[jira] [Commented] (HBASE-3976) Disable Block Cache On Compactions

2011-06-10 Thread Jean-Daniel Cryans (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13047304#comment-13047304 ] Jean-Daniel Cryans commented on HBASE-3976: --- I can't believe we're block caching

[jira] [Resolved] (HBASE-2714) Remove Guava as a client dependency

2011-06-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-2714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack resolved HBASE-2714. -- Resolution: Duplicate Resolving as duplicate. Nicolas fixed this over in another issue (I know its working

[jira] [Commented] (HBASE-3484) Replace memstore's ConcurrentSkipListMap with our own implementation

2011-06-10 Thread Joe Pallas (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13047342#comment-13047342 ] Joe Pallas commented on HBASE-3484: --- I think the performance issue I mentioned above may

[jira] [Assigned] (HBASE-3723) Major compact should be done when there is only one storefile and some keyvalue is outdated.

2011-06-10 Thread Jean-Daniel Cryans (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Daniel Cryans reassigned HBASE-3723: - Assignee: zhoushuaifeng Major compact should be done when there is only one

[jira] [Commented] (HBASE-3855) Performance degradation of memstore because reseek is linear

2011-06-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13047383#comment-13047383 ] stack commented on HBASE-3855: -- Committed to branch and Andrew's suggestion. Performance

[jira] [Updated] (HBASE-3976) Disable Block Cache On Compactions

2011-06-10 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-3976: -- Attachment: HBASE-3976-unconditional.patch Disable Block Cache On Compactions

[jira] [Updated] (HBASE-3977) assembly is creating a dir instead a tar.gz

2011-06-10 Thread Alejandro Abdelnur (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alejandro Abdelnur updated HBASE-3977: -- Attachment: HBASE-3977.patch assembly is creating a dir instead a tar.gz

[jira] [Updated] (HBASE-3977) assembly is creating a dir instead a tar.gz

2011-06-10 Thread Alejandro Abdelnur (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alejandro Abdelnur updated HBASE-3977: -- Status: Patch Available (was: Open) assembly is creating a dir instead a tar.gz

[jira] [Commented] (HBASE-3962) HConnectionManager.getConnection(HBaseConfiguration) returns new connection in default HTable constructor

2011-06-10 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13047441#comment-13047441 ] Ted Yu commented on HBASE-3962: --- For a, I don't think there is performance impact. Once 0.92

[jira] [Updated] (HBASE-3977) assembly is creating a dir instead a tar.gz

2011-06-10 Thread Alejandro Abdelnur (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alejandro Abdelnur updated HBASE-3977: -- Status: Open (was: Patch Available) todd, you are right!!! assembly is creating a

[jira] [Commented] (HBASE-3977) assembly is creating a dir instead a tar.gz

2011-06-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13047449#comment-13047449 ] stack commented on HBASE-3977: -- I noticed it before commit and tried it to make sure it still

[jira] [Resolved] (HBASE-3977) assembly is creating a dir instead a tar.gz

2011-06-10 Thread Alejandro Abdelnur (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alejandro Abdelnur resolved HBASE-3977. --- Resolution: Invalid (short term memory not working) Todd is correct, the TAR is

[jira] [Created] (HBASE-3978) rowlock lease renew doesn't work when custom coprocessor/RegionObserver indicates to bypass default action

2011-06-10 Thread Ming Ma (JIRA)
rowlock lease renew doesn't work when custom coprocessor/RegionObserver indicates to bypass default action -- Key: HBASE-3978 URL:

[jira] [Created] (HBASE-3979) Trivial fixes in code, document

2011-06-10 Thread Ming Ma (JIRA)
Trivial fixes in code, document --- Key: HBASE-3979 URL: https://issues.apache.org/jira/browse/HBASE-3979 Project: HBase Issue Type: Bug Reporter: Ming Ma Assignee: Ming Ma

[jira] [Resolved] (HBASE-3892) Table can't disable

2011-06-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack resolved HBASE-3892. -- Resolution: Fixed Hadoop Flags: [Reviewed] Applied to branch. I talked to J-D and we need to be able to

[jira] [Commented] (HBASE-451) Remove HTableDescriptor from HRegionInfo

2011-06-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13047493#comment-13047493 ] stack commented on HBASE-451: - These failed for me Subbu: Running

[jira] [Updated] (HBASE-3979) Trivial fixes in code, document

2011-06-10 Thread Ming Ma (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ming Ma updated HBASE-3979: --- Attachment: HBASE-3979-trunk.patch Here is the fix. Trivial fixes in code, document

[jira] [Resolved] (HBASE-3979) Trivial fixes in code, document

2011-06-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack resolved HBASE-3979. -- Resolution: Fixed Fix Version/s: 0.92.0 Hadoop Flags: [Reviewed] Committed to TRUNK. Thank you

[jira] [Commented] (HBASE-3978) rowlock lease renew doesn't work when custom coprocessor/RegionObserver indicates to bypass default action

2011-06-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13047500#comment-13047500 ] stack commented on HBASE-3978: -- You have a patch Ming? rowlock lease renew doesn't work

[jira] [Commented] (HBASE-3963) Schedule all log-spliiting at startup all at once

2011-06-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13047502#comment-13047502 ] stack commented on HBASE-3963: -- I tried to apply your patch but it failed. Can you recut it

[jira] [Updated] (HBASE-24) Scaling: Too many open file handles to datanodes

2011-06-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-24?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-24: --- Fix Version/s: (was: 0.92.0) Moving out of 0.92.0. Scaling: Too many open file handles to datanodes

[jira] [Updated] (HBASE-2231) Compaction events should be written to HLog

2011-06-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-2231: - Status: Patch Available (was: Open) Marking patch available Compaction events should be written to HLog

[jira] [Updated] (HBASE-2042) ChecksumException generates thousands of open sockets

2011-06-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-2042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-2042: - Fix Version/s: (was: 0.92.0) Moving out of 0.92. Have not seen this in a long time. ChecksumException

[jira] [Updated] (HBASE-3484) Replace memstore's ConcurrentSkipListMap with our own implementation

2011-06-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-3484: - Fix Version/s: (was: 0.92.0) Moving out of 0.92. Don't see it happening in time. Replace memstore's

[jira] [Updated] (HBASE-2704) Cleanup HColumnDescriptor

2011-06-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-2704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-2704: - Fix Version/s: (was: 0.92.0) Moving out of 0.92.0 Cleanup HColumnDescriptor -

[jira] [Commented] (HBASE-2000) Coprocessors

2011-06-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13047639#comment-13047639 ] stack commented on HBASE-2000: -- Andrew, can we close this issue now? Coprocessors

[jira] [Commented] (HBASE-2000) Coprocessors

2011-06-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13047641#comment-13047641 ] stack commented on HBASE-2000: -- Or maybe we can't because some of the issues remain undone?

[jira] [Resolved] (HBASE-3642) Web UI should be available during startup

2011-06-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack resolved HBASE-3642. -- Resolution: Fixed Assignee: Todd Lipcon I tried it. Indeed the UI is up if no meta regions assigned or

[jira] [Updated] (HBASE-3642) Web UI should be available during startup

2011-06-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-3642: - Attachment: Screen shot 2011-06-10 at 3.45.58 PM.png Web UI should be available during startup

[jira] [Updated] (HBASE-3948) Improve split/compact result page for RegionServer status page

2011-06-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-3948: - Priority: Blocker (was: Minor) Fix Version/s: 0.92.0 Improve split/compact result page for

[jira] [Updated] (HBASE-3940) HBase daemons should log version info at startup and possibly periodically

2011-06-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-3940: - Priority: Blocker (was: Minor) Fix Version/s: 0.92.0 Making this a blocker. Helps all of us in our

[jira] [Commented] (HBASE-3894) Thread contention over row locks set monitor

2011-06-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13047765#comment-13047765 ] stack commented on HBASE-3894: -- Applied to branch too.. Thread contention over row locks

[jira] [Updated] (HBASE-3929) Add option to HFile tool to produce basic stats

2011-06-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-3929: - Fix Version/s: 0.92.0 Add option to HFile tool to produce basic stats

[jira] [Updated] (HBASE-3939) Some crossports of Hadoop IPC fixes

2011-06-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-3939: - Fix Version/s: 0.92.0 Some crossports of Hadoop IPC fixes ---

[jira] [Resolved] (HBASE-3923) HBASE-1502 Broke Shell's status 'simple' and 'detailed'

2011-06-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack resolved HBASE-3923. -- Resolution: Fixed Fix Version/s: 0.92.0 Assignee: Lars George Hadoop Flags: [Reviewed]

[jira] [Updated] (HBASE-3807) Fix units in RS UI metrics

2011-06-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-3807: - Fix Version/s: 0.92.0 Fix units in RS UI metrics -- Key: HBASE-3807

[jira] [Updated] (HBASE-3891) TaskMonitor is used wrong in some places

2011-06-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-3891: - Fix Version/s: 0.92.0 TaskMonitor is used wrong in some places

[jira] [Updated] (HBASE-3890) Scheduled tasks in distributed log splitting not in sync with ZK

2011-06-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-3890: - Fix Version/s: 0.92.0 Scheduled tasks in distributed log splitting not in sync with ZK

[jira] [Commented] (HBASE-3974) Client: Ability to Discard Bad HTable Puts

2011-06-10 Thread Dave Latham (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13047773#comment-13047773 ] Dave Latham commented on HBASE-3974: Thanks for taking on this issue, Nicolas. I

[jira] [Updated] (HBASE-3577) enables Thrift client to get the Region location

2011-06-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-3577: - Fix Version/s: 0.92.0 Pulling in again; has a patch available. enables Thrift client to get the Region

[jira] [Updated] (HBASE-3581) hbase rpc should send size of response

2011-06-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-3581: - Priority: Critical (was: Major) Fix Version/s: 0.92.0 hbase rpc should send size of response

[jira] [Updated] (HBASE-3534) Action should not store or serialize regionName

2011-06-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-3534: - Fix Version/s: 0.92.0 Small fix we should do while RPC version is changing. Bringing back in. Action should

[jira] [Updated] (HBASE-3507) requests count per HRegion and rebalance command

2011-06-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-3507: - Fix Version/s: 0.92.0 Bringing back in; give it another review before punting. requests count per HRegion and

[jira] [Updated] (HBASE-3978) rowlock lease renew doesn't work when custom coprocessor/RegionObserver indicates to bypass default action

2011-06-10 Thread Ming Ma (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ming Ma updated HBASE-3978: --- Attachment: HBASE-3978-TRUNK.patch rowlock lease renew doesn't work when custom coprocessor/RegionObserver

[jira] [Commented] (HBASE-3978) rowlock lease renew doesn't work when custom coprocessor/RegionObserver indicates to bypass default action

2011-06-10 Thread Ming Ma (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13047779#comment-13047779 ] Ming Ma commented on HBASE-3978: Stack, here is the fix. Please review. Thanks. rowlock

[jira] [Updated] (HBASE-3065) Retry all 'retryable' zk operations; e.g. connection loss

2011-06-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-3065: - Priority: Critical (was: Major) Fix Version/s: 0.92.0 Bringing back in. Try and hack this patch into

[jira] [Commented] (HBASE-3976) Disable Block Cache On Compactions

2011-06-10 Thread Nicolas Spiegelberg (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13047783#comment-13047783 ] Nicolas Spiegelberg commented on HBASE-3976: I don't think this patch is doing

[jira] [Updated] (HBASE-3981) CheckAndPut doesn't work when value == null

2011-06-10 Thread Ming Ma (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ming Ma updated HBASE-3981: --- Summary: CheckAndPut doesn't work when value == null (was: CheckAndPut doesn't work with when value ==

[jira] [Commented] (HBASE-451) Remove HTableDescriptor from HRegionInfo

2011-06-10 Thread Subbu M Iyer (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13047816#comment-13047816 ] Subbu M Iyer commented on HBASE-451: Stack: I ran both these tests on my local version

[jira] [Updated] (HBASE-3976) Disable Block Cache On Compactions

2011-06-10 Thread Karthick Sankarachary (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karthick Sankarachary updated HBASE-3976: - Attachment: HBASE-3976-V3.patch Disable Block Cache On Compactions

[jira] [Commented] (HBASE-3976) Disable Block Cache On Compactions

2011-06-10 Thread Karthick Sankarachary (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13047823#comment-13047823 ] Karthick Sankarachary commented on HBASE-3976: -- My bad. We do want to be able

[jira] [Updated] (HBASE-3976) Disable Block Cache On Compactions

2011-06-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-3976: - Assignee: Nicolas Spiegelberg (was: Karthick Sankarachary) Assigning Nicolas for review. Punt to me N if you

[jira] [Commented] (HBASE-451) Remove HTableDescriptor from HRegionInfo

2011-06-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13047840#comment-13047840 ] stack commented on HBASE-451: - They pass for you? If so, lets commit and figure it out later?

[jira] [Commented] (HBASE-3981) CheckAndPut doesn't work when value == null

2011-06-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13047841#comment-13047841 ] stack commented on HBASE-3981: -- Ming. Do a search. I think Lars George pointed this out in

[jira] [Resolved] (HBASE-3981) CheckAndPut doesn't work when value == null

2011-06-10 Thread Ming Ma (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ming Ma resolved HBASE-3981. Resolution: Duplicate Hadoop Flags: [Reviewed] CheckAndPut doesn't work when value == null