[
https://issues.apache.org/jira/browse/HBASE-18068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16019157#comment-16019157
]
Appy commented on HBASE-18068:
--
I triggered QA run manually.
> Fix flaky test TestAsyncSnapshotAdminApi
>
[
https://issues.apache.org/jira/browse/HBASE-18060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16019151#comment-16019151
]
Andrew Purtell commented on HBASE-18060:
I believe LongAdder and Striped64 are from the public
[
https://issues.apache.org/jira/browse/HBASE-18084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16019142#comment-16019142
]
Yu Li commented on HBASE-18084:
---
Checked UT and found below case in error:
{noformat}
Tests in error:
[
https://issues.apache.org/jira/browse/HBASE-17738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16019141#comment-16019141
]
ramkrishna.s.vasudevan commented on HBASE-17738:
[~anoopsamjohn], Stack
Ping for reviews.
[
https://issues.apache.org/jira/browse/HBASE-18010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16019138#comment-16019138
]
ramkrishna.s.vasudevan commented on HBASE-18010:
bq.As our mapping is from Cell to Cell
[
https://issues.apache.org/jira/browse/HBASE-17924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16019135#comment-16019135
]
stack commented on HBASE-17924:
---
I like [~jerryhe]'s question. Not sure how sort makes a difference
[
https://issues.apache.org/jira/browse/HBASE-18068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16019131#comment-16019131
]
Guanghao Zhang commented on HBASE-18068:
+1. Wait the hadoop QA result. I can't change the status
[
https://issues.apache.org/jira/browse/HBASE-18008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16019110#comment-16019110
]
Chia-Ping Tsai commented on HBASE-18008:
[~stack] Would you please review this if you have free
[
https://issues.apache.org/jira/browse/HBASE-18069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16019108#comment-16019108
]
Chia-Ping Tsai commented on HBASE-18069:
LGTM. +1
> Fix flaky test
>
[
https://issues.apache.org/jira/browse/HBASE-18008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated HBASE-18008:
---
Status: Patch Available (was: Open)
> Any HColumnDescriptor we give out should be immutable
[
https://issues.apache.org/jira/browse/HBASE-18008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated HBASE-18008:
---
Attachment: HBASE-18008.v2.patch
02 --
# Failed test has passed locally.
# rebase for
[
https://issues.apache.org/jira/browse/HBASE-18069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16019104#comment-16019104
]
Guanghao Zhang commented on HBASE-18069:
Sorry, my fault. The code didn't sink schema change to
[
https://issues.apache.org/jira/browse/HBASE-18008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated HBASE-18008:
---
Status: Open (was: Patch Available)
> Any HColumnDescriptor we give out should be immutable
[
https://issues.apache.org/jira/browse/HBASE-18069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guanghao Zhang updated HBASE-18069:
---
Status: Patch Available (was: Open)
> Fix flaky test
>
[
https://issues.apache.org/jira/browse/HBASE-18069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guanghao Zhang updated HBASE-18069:
---
Attachment: HBASE-18069.patch
> Fix flaky test
>
[
https://issues.apache.org/jira/browse/HBASE-18075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16019100#comment-16019100
]
Chia-Ping Tsai commented on HBASE-18075:
{code:title=TableName.java}
/**
* Valid namespace
[
https://issues.apache.org/jira/browse/HBASE-18075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josh Elser updated HBASE-18075:
---
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
[
https://issues.apache.org/jira/browse/HBASE-18067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josh Elser updated HBASE-18067:
---
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
[
https://issues.apache.org/jira/browse/HBASE-18067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16019082#comment-16019082
]
Hadoop QA commented on HBASE-18067:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guanghao Zhang updated HBASE-15616:
---
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Allow null qualifier
[
https://issues.apache.org/jira/browse/HBASE-18075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16019076#comment-16019076
]
Hadoop QA commented on HBASE-18075:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-18072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16019062#comment-16019062
]
Allan Yang commented on HBASE-18072:
I agree that we should have a checksum of the whole RPC
[
https://issues.apache.org/jira/browse/HBASE-18067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16019023#comment-16019023
]
Hadoop QA commented on HBASE-18067:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josh Elser updated HBASE-18075:
---
Attachment: HBASE-18075.003.patch
.003 Removes the explicit ZK disallowed character range as it's
[
https://issues.apache.org/jira/browse/HBASE-18075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16019020#comment-16019020
]
Josh Elser commented on HBASE-18075:
{code}
public static void main(String[] args) throws Exception
[
https://issues.apache.org/jira/browse/HBASE-18067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16019018#comment-16019018
]
Josh Elser commented on HBASE-18067:
Thanks, Devaraj and Stephen!
I re-kicked QA since it missed my
[
https://issues.apache.org/jira/browse/HBASE-17924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018986#comment-16018986
]
Andrew Purtell edited comment on HBASE-17924 at 5/21/17 9:40 PM:
-
Without
[
https://issues.apache.org/jira/browse/HBASE-17924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018986#comment-16018986
]
Andrew Purtell commented on HBASE-17924:
We acquire row locks in order. Sorting the row order
[
https://issues.apache.org/jira/browse/HBASE-18081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018972#comment-16018972
]
Hudson commented on HBASE-18081:
SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #3052 (See
[
https://issues.apache.org/jira/browse/HBASE-17924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018966#comment-16018966
]
Jerry He commented on HBASE-17924:
--
Thinking a little more. It is not clear how the ordering will help
[
https://issues.apache.org/jira/browse/HBASE-18056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018964#comment-16018964
]
Anastasia Braginsky commented on HBASE-18056:
-
Dear [~anoop.hbase],
I would like to deeply
[
https://issues.apache.org/jira/browse/HBASE-18056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018956#comment-16018956
]
Edward Bortnikov commented on HBASE-18056:
--
Friends,
I'm having a hard time understanding why
[
https://issues.apache.org/jira/browse/HBASE-18056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018926#comment-16018926
]
Anoop Sam John commented on HBASE-18056:
Is this committed already?
1. I have raised a concern
[
https://issues.apache.org/jira/browse/HBASE-18081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018917#comment-16018917
]
Hudson commented on HBASE-18081:
SUCCESS: Integrated in Jenkins build HBase-1.3-JDK8 #180 (See
[
https://issues.apache.org/jira/browse/HBASE-18081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018913#comment-16018913
]
Hudson commented on HBASE-18081:
SUCCESS: Integrated in Jenkins build HBase-1.2-JDK8 #132 (See
[
https://issues.apache.org/jira/browse/HBASE-18081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018911#comment-16018911
]
Hudson commented on HBASE-18081:
SUCCESS: Integrated in Jenkins build HBase-1.2-JDK7 #137 (See
[
https://issues.apache.org/jira/browse/HBASE-18008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018910#comment-16018910
]
Hadoop QA commented on HBASE-18008:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018905#comment-16018905
]
Hudson commented on HBASE-18081:
FAILURE: Integrated in Jenkins build HBase-1.3-JDK7 #166 (See
[
https://issues.apache.org/jira/browse/HBASE-18081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018902#comment-16018902
]
Hudson commented on HBASE-18081:
FAILURE: Integrated in Jenkins build HBase-1.4 #741 (See
[
https://issues.apache.org/jira/browse/HBASE-18081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018900#comment-16018900
]
Hudson commented on HBASE-18081:
SUCCESS: Integrated in Jenkins build HBase-1.1-JDK8 #1955 (See
[
https://issues.apache.org/jira/browse/HBASE-18081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018901#comment-16018901
]
Hudson commented on HBASE-18081:
SUCCESS: Integrated in Jenkins build HBase-1.1-JDK7 #1872 (See
[
https://issues.apache.org/jira/browse/HBASE-18056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018881#comment-16018881
]
Hudson commented on HBASE-18056:
SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #3051 (See
[
https://issues.apache.org/jira/browse/HBASE-18035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018870#comment-16018870
]
Hudson commented on HBASE-18035:
SUCCESS: Integrated in Jenkins build HBase-1.4 #740 (See
[
https://issues.apache.org/jira/browse/HBASE-17997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018868#comment-16018868
]
Xiang Li commented on HBASE-17997:
--
Hi Ted, thanks for the explanation! I see jruby-complete 1.6.8 jar
[
https://issues.apache.org/jira/browse/HBASE-18081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018863#comment-16018863
]
Hudson commented on HBASE-18081:
SUCCESS: Integrated in Jenkins build HBase-1.2-IT #871 (See
[
https://issues.apache.org/jira/browse/HBASE-18081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018860#comment-16018860
]
Hudson commented on HBASE-18081:
SUCCESS: Integrated in Jenkins build HBase-1.3-IT #48 (See
[
https://issues.apache.org/jira/browse/HBASE-18085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018841#comment-16018841
]
Hadoop QA commented on HBASE-18085:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-18081:
--
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
[
https://issues.apache.org/jira/browse/HBASE-18083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018838#comment-16018838
]
huaxiang sun commented on HBASE-18083:
--
Thanks [~carp84]. I believe it is HADOOP-2232.
{bq}
Pretty
[
https://issues.apache.org/jira/browse/HBASE-18089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
huaxiang sun reassigned HBASE-18089:
Assignee: huaxiang sun
> TestScannerHeartbeatMessages fails in branch-1
>
[
https://issues.apache.org/jira/browse/HBASE-18035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018835#comment-16018835
]
Ted Yu commented on HBASE-18035:
You're welcome to take it.
> Meta replica does not give any
[
https://issues.apache.org/jira/browse/HBASE-18089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-18089:
---
Attachment: test-heartbeat-6860.out
> TestScannerHeartbeatMessages fails in branch-1
>
[
https://issues.apache.org/jira/browse/HBASE-18035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018833#comment-16018833
]
huaxiang sun commented on HBASE-18035:
--
Thanks [~te...@apache.org]! I was looking at the failed
[
https://issues.apache.org/jira/browse/HBASE-18035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-18035:
---
Resolution: Fixed
Hadoop Flags: Reviewed
Fix Version/s: 1.4.0
Status: Resolved (was:
[
https://issues.apache.org/jira/browse/HBASE-18035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018831#comment-16018831
]
Ted Yu commented on HBASE-18035:
Logged HBASE-18089 for flaky TestScannerHeartbeatMessages
> Meta
[
https://issues.apache.org/jira/browse/HBASE-18089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-18089:
---
Summary: TestScannerHeartbeatMessages fails in branch-1 (was: HBASE-16051
fails in branch-1)
>
Ted Yu created HBASE-18089:
--
Summary: HBASE-16051 fails in branch-1
Key: HBASE-18089
URL: https://issues.apache.org/jira/browse/HBASE-18089
Project: HBase
Issue Type: Test
Reporter: Ted
[
https://issues.apache.org/jira/browse/HBASE-18035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018827#comment-16018827
]
huaxiang sun commented on HBASE-18035:
--
The findBug warning is about the following line of code, it
[
https://issues.apache.org/jira/browse/HBASE-18084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018826#comment-16018826
]
Ted Yu commented on HBASE-18084:
We can get this in first and evaluate my suggestion in another JIRA.
>
[
https://issues.apache.org/jira/browse/HBASE-18085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018824#comment-16018824
]
Ted Yu commented on HBASE-18085:
Using untimed tryLock is fine.
> Prevent parallel purge in ObjectPool
>
[
https://issues.apache.org/jira/browse/HBASE-18085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018809#comment-16018809
]
Anoop Sam John commented on HBASE-18085:
Any chance for a micro benchmark tests Yu? Appreciate
[
https://issues.apache.org/jira/browse/HBASE-18056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018807#comment-16018807
]
Anoop Sam John commented on HBASE-18056:
This patch changes the threshold to 1 (default value)
[
https://issues.apache.org/jira/browse/HBASE-18081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018805#comment-16018805
]
Anoop Sam John commented on HBASE-18081:
Yes as said by Duo.. We always had an assumption that
[
https://issues.apache.org/jira/browse/HBASE-18085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yu Li updated HBASE-18085:
--
Status: Patch Available (was: Open)
Submit current patch for HadoopQA to check
> Prevent parallel purge in
[
https://issues.apache.org/jira/browse/HBASE-18008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018802#comment-16018802
]
Chia-Ping Tsai edited comment on HBASE-18008 at 5/21/17 12:43 PM:
--
v1 --
[
https://issues.apache.org/jira/browse/HBASE-18084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018801#comment-16018801
]
Yu Li edited comment on HBASE-18084 at 5/21/17 12:41 PM:
-
bq. if the initial
[
https://issues.apache.org/jira/browse/HBASE-18008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated HBASE-18008:
---
Status: Patch Available (was: Open)
> Any HColumnDescriptor we give out should be immutable
[
https://issues.apache.org/jira/browse/HBASE-18008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated HBASE-18008:
---
Attachment: HBASE-18008.v1.patch
v1 --
# fix the findbugs and javadoc
# is pushed into
[
https://issues.apache.org/jira/browse/HBASE-18084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018801#comment-16018801
]
Yu Li commented on HBASE-18084:
---
bq. if the initial batch contains large directory
But what if not sir?
[
https://issues.apache.org/jira/browse/HBASE-18008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated HBASE-18008:
---
Status: Open (was: Patch Available)
> Any HColumnDescriptor we give out should be immutable
[
https://issues.apache.org/jira/browse/HBASE-18066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018800#comment-16018800
]
Duo Zhang commented on HBASE-18066:
---
Yeah I know that we use this method to locate region in meta when
[
https://issues.apache.org/jira/browse/HBASE-18081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018797#comment-16018797
]
Duo Zhang commented on HBASE-18081:
---
[~stack] We always use the dataLengthBuffer to read the first 4
[
https://issues.apache.org/jira/browse/HBASE-18085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018784#comment-16018784
]
Yu Li commented on HBASE-18085:
---
bq. It will succeed if the lock is available even if other threads are
[
https://issues.apache.org/jira/browse/HBASE-18084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018780#comment-16018780
]
Hadoop QA commented on HBASE-18084:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018772#comment-16018772
]
Anastasia Braginsky commented on HBASE-18010:
-
If we are already talking about... I wonder
[
https://issues.apache.org/jira/browse/HBASE-18010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018771#comment-16018771
]
Anastasia Braginsky commented on HBASE-18010:
-
Thank you guys for your great explanations!
[
https://issues.apache.org/jira/browse/HBASE-18056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018768#comment-16018768
]
Eshcar Hillel commented on HBASE-18056:
---
I think we are missing the point here.
The original need
[
https://issues.apache.org/jira/browse/HBASE-18085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018762#comment-16018762
]
Ted Yu commented on HBASE-18085:
>From
[
https://issues.apache.org/jira/browse/HBASE-18084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018759#comment-16018759
]
Ted Yu edited comment on HBASE-18084 at 5/21/17 8:46 AM:
-
bq. the cleaning time
[
https://issues.apache.org/jira/browse/HBASE-18084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018759#comment-16018759
]
Ted Yu commented on HBASE-18084:
bq. the cleaning time is way more long than getting space and sorting.
[
https://issues.apache.org/jira/browse/HBASE-18084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018758#comment-16018758
]
Yu Li commented on HBASE-18084:
---
bq. It is fine to clean small directory in thread 2 at the beginning
[
https://issues.apache.org/jira/browse/HBASE-18085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yu Li updated HBASE-18085:
--
Attachment: HBASE-18085.patch
> Prevent parallel purge in ObjectPool
>
>
[
https://issues.apache.org/jira/browse/HBASE-18084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018745#comment-16018745
]
Ted Yu edited comment on HBASE-18084 at 5/21/17 8:20 AM:
-
bq. the
[
https://issues.apache.org/jira/browse/HBASE-18084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018745#comment-16018745
]
Ted Yu commented on HBASE-18084:
bq. the fs.getContentSummary call is time consuming if there're many
[
https://issues.apache.org/jira/browse/HBASE-18084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yu Li updated HBASE-18084:
--
Attachment: HBASE-18084.v2.patch
Update patch to address review comments.
> Improve CleanerChore to clean
[
https://issues.apache.org/jira/browse/HBASE-18084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018729#comment-16018729
]
Yu Li commented on HBASE-18084:
---
bq. 'else' can be omitted since return is called in the previous if block.
[
https://issues.apache.org/jira/browse/HBASE-18085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018726#comment-16018726
]
Yu Li edited comment on HBASE-18085 at 5/21/17 7:39 AM:
bq. As per impl, we
[
https://issues.apache.org/jira/browse/HBASE-18085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018726#comment-16018726
]
Yu Li commented on HBASE-18085:
---
bq. As per impl, we should need a boolean state indicating the status of
[
https://issues.apache.org/jira/browse/HBASE-17924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018713#comment-16018713
]
Allan Yang commented on HBASE-17924:
{quote}
Thanks for pointing me here from HBASE-18074 Allan Yang.
89 matches
Mail list logo