[jira] [Commented] (HBASE-23313) [hbck2] setRegionState should update Master in-memory state too

2020-06-03 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125566#comment-17125566 ] Duo Zhang commented on HBASE-23313: --- For RegionInfo, the regionName and encodedName should be

[GitHub] [hbase] Apache-HBase commented on pull request #1814: HBASE-20904 Prometheus /metrics http endpoint for monitoring

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1814: URL: https://github.com/apache/hbase/pull/1814#issuecomment-638611816 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1814: HBASE-20904 Prometheus /metrics http endpoint for monitoring

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1814: URL: https://github.com/apache/hbase/pull/1814#issuecomment-638610040 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1814: HBASE-20904 Prometheus /metrics http endpoint for monitoring

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1814: URL: https://github.com/apache/hbase/pull/1814#issuecomment-638607456 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1802: HBASE-24444 Should shutdown mini cluster after class in TestMetaAssignmentWithStopMaster

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1802: URL: https://github.com/apache/hbase/pull/1802#issuecomment-638602336 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] mmpataki commented on pull request #1814: HBASE-20904 Prometheus /metrics http endpoint for monitoring

2020-06-03 Thread GitBox
mmpataki commented on pull request #1814: URL: https://github.com/apache/hbase/pull/1814#issuecomment-638600476 @saintstack I have made the changes, could you please review them. This is an automated message from the Apache

[GitHub] [hbase] Apache-HBase commented on pull request #1802: HBASE-24444 Should shutdown mini cluster after class in TestMetaAssignmentWithStopMaster

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1802: URL: https://github.com/apache/hbase/pull/1802#issuecomment-638600634 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1722: HBASE-24359 Optionally ignore edits for deleted CFs for replication

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1722: URL: https://github.com/apache/hbase/pull/1722#issuecomment-638599687 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Comment Edited] (HBASE-23313) [hbck2] setRegionState should update Master in-memory state too

2020-06-03 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125534#comment-17125534 ] Michael Stack edited comment on HBASE-23313 at 6/4/20, 4:36 AM: I made

[jira] [Commented] (HBASE-23313) [hbck2] setRegionState should update Master in-memory state too

2020-06-03 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125534#comment-17125534 ] Michael Stack commented on HBASE-23313: --- I made remark in PR on this new field. Thought it

[jira] [Commented] (HBASE-24205) Create metric to know the number of reads that happens from memstore

2020-06-03 Thread ramkrishna.s.vasudevan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125533#comment-17125533 ] ramkrishna.s.vasudevan commented on HBASE-24205: bq.Will make it awkward summing by

[jira] [Commented] (HBASE-24205) Create metric to know the number of reads that happens from memstore

2020-06-03 Thread ramkrishna.s.vasudevan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125532#comment-17125532 ] ramkrishna.s.vasudevan commented on HBASE-24205: bq.Aggregated at region level means it

[jira] [Commented] (HBASE-24500) The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange

2020-06-03 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125531#comment-17125531 ] Duo Zhang commented on HBASE-24500: --- Revert from branch-2.3+. Will open a new PR once the question on

[jira] [Commented] (HBASE-23313) [hbck2] setRegionState should update Master in-memory state too

2020-06-03 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125530#comment-17125530 ] Duo Zhang commented on HBASE-23313: --- Could someone explain a bit about the newly added

[jira] [Commented] (HBASE-24500) The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange

2020-06-03 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125526#comment-17125526 ] Duo Zhang commented on HBASE-24500: --- Oh shit, seems we use the ProtobufUtil.toProtoRegionInfo in

[jira] [Updated] (HBASE-24500) The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange

2020-06-03 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24500: -- Priority: Blocker (was: Critical) > The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is

[jira] [Commented] (HBASE-24500) The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange

2020-06-03 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125523#comment-17125523 ] Duo Zhang commented on HBASE-24500: --- oh, wait a minute, we do not have encoded name for RegionInfo

[jira] [Updated] (HBASE-24038) Add a metric to show the locality of ssd in table.jsp

2020-06-03 Thread Zheng Wang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Wang updated HBASE-24038: --- Attachment: HBASE-24038-screenshot.png > Add a metric to show the locality of ssd in table.jsp >

[GitHub] [hbase] bsglz commented on pull request #1337: HBASE-24038 Add a metric to show the locality of ssd in table.jsp

2020-06-03 Thread GitBox
bsglz commented on pull request #1337: URL: https://github.com/apache/hbase/pull/1337#issuecomment-638587744 Posted a screenshot. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hbase] Apache9 commented on pull request #1774: HBASE-24389 Introduce new master rpc methods to locate meta region through root region

2020-06-03 Thread GitBox
Apache9 commented on pull request #1774: URL: https://github.com/apache/hbase/pull/1774#issuecomment-638580779 @saintstack Any other concerns on the patch here? Thanks. This is an automated message from the Apache Git

[GitHub] [hbase] Apache9 merged pull request #1840: HBASE-24500 The behavior of RegionInfoBuilder.newBuilder(RegionInfo) …

2020-06-03 Thread GitBox
Apache9 merged pull request #1840: URL: https://github.com/apache/hbase/pull/1840 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache9 commented on pull request #1826: HBASE-24438 Don't update TaskMonitor when deserializing ServerCrashProcedure

2020-06-03 Thread GitBox
Apache9 commented on pull request #1826: URL: https://github.com/apache/hbase/pull/1826#issuecomment-638573746 > Maybe an alternative would be to improve the message in tasks and explicitly say "noticed an SCP, waiting for processing". Don't know if such verbosity would be useful though?

[GitHub] [hbase] Apache-HBase commented on pull request #1722: HBASE-24359 Optionally ignore edits for deleted CFs for replication

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1722: URL: https://github.com/apache/hbase/pull/1722#issuecomment-638569340 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1802: HBASE-24444 Should shutdown mini cluster after class in TestMetaAssignmentWithStopMaster

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1802: URL: https://github.com/apache/hbase/pull/1802#issuecomment-638565490 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] bsglz commented on pull request #1837: HBASE-24496 The tab of Base Stats not actived by default in table.jsp

2020-06-03 Thread GitBox
bsglz commented on pull request #1837: URL: https://github.com/apache/hbase/pull/1837#issuecomment-638557813 > Please either add a test or post a screenshot at the jira. The patch LGTM. Posted two screenshots at the jira. Thanks.

[jira] [Updated] (HBASE-24496) The tab of Base Stats not actived by default in table.jsp

2020-06-03 Thread Zheng Wang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Wang updated HBASE-24496: --- Attachment: HBASE-24496-afterpatch.png HBASE-24496-beforepatch.png > The tab of

[GitHub] [hbase] bsglz commented on pull request #1337: HBASE-24038 Add a metric to show the locality of ssd in table.jsp

2020-06-03 Thread GitBox
bsglz commented on pull request #1337: URL: https://github.com/apache/hbase/pull/1337#issuecomment-638549983 The mvninstall failture ofmaster seems not related to this PR. This is an automated message from the Apache Git

[GitHub] [hbase] Apache-HBase commented on pull request #1749: HBASE-24367 ScheduledChore log elapsed timespan in a human-friendly format

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1749: URL: https://github.com/apache/hbase/pull/1749#issuecomment-638545825 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] Apache-HBase commented on pull request #1749: HBASE-24367 ScheduledChore log elapsed timespan in a human-friendly format

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1749: URL: https://github.com/apache/hbase/pull/1749#issuecomment-638543615 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] Apache-HBase commented on pull request #1749: HBASE-24367 ScheduledChore log elapsed timespan in a human-friendly format

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1749: URL: https://github.com/apache/hbase/pull/1749#issuecomment-638543364 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24412) Canary support check only one column family per RegionTask

2020-06-03 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125445#comment-17125445 ] Hudson commented on HBASE-24412: Results for branch branch-2 [build #2689 on

[jira] [Commented] (HBASE-21406) "status 'replication'" should not show SINK if the cluster does not act as sink

2020-06-03 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125447#comment-17125447 ] Hudson commented on HBASE-21406: Results for branch branch-2 [build #2689 on

[jira] [Commented] (HBASE-24309) Avoid introducing log4j and slf4j-log4j dependencies for modules other than hbase-assembly

2020-06-03 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125448#comment-17125448 ] Hudson commented on HBASE-24309: Results for branch branch-2 [build #2689 on

[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping

2020-06-03 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125446#comment-17125446 ] Hudson commented on HBASE-24492: Results for branch branch-2 [build #2689 on

[jira] [Resolved] (HBASE-24501) Backport to branch-1 HBASE-15785 Unnecessary lock in ByteBufferArray

2020-06-03 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang resolved HBASE-24501. Fix Version/s: 1.7.0 Resolution: Fixed Pushed to branch-1. Thanks [~tangtianhang] 

[GitHub] [hbase] infraio merged pull request #1842: HBASE-24501 Backport to branch-1 HBASE-15785 Unnecessary lock in Byte…

2020-06-03 Thread GitBox
infraio merged pull request #1842: URL: https://github.com/apache/hbase/pull/1842 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] timoha commented on pull request #1826: HBASE-24438 Don't update TaskMonitor when deserializing ServerCrashProcedure

2020-06-03 Thread GitBox
timoha commented on pull request #1826: URL: https://github.com/apache/hbase/pull/1826#issuecomment-638533674 That's a good point @Apache9, I guess it would add sort of "continuity" to show that the task is still ongoing during master failover in case the procedure hasn't actually

[GitHub] [hbase] Apache9 edited a comment on pull request #1826: HBASE-24438 Don't update TaskMonitor when deserializing ServerCrashProcedure

2020-06-03 Thread GitBox
Apache9 edited a comment on pull request #1826: URL: https://github.com/apache/hbase/pull/1826#issuecomment-638530854 And I got the reason why there is a currentRunningState field. We will call setNextState after scheduling sub procedures, so when updating progress, if we just use the

[GitHub] [hbase] Apache9 commented on pull request #1826: HBASE-24438 Don't update TaskMonitor when deserializing ServerCrashProcedure

2020-06-03 Thread GitBox
Apache9 commented on pull request #1826: URL: https://github.com/apache/hbase/pull/1826#issuecomment-638530854 And I got the reason why there is a currentRunningState field. We will call setNextState after scheduling sub procedures, so when updating progress, if we just use the recorded

[GitHub] [hbase] Apache9 commented on pull request #1826: HBASE-24438 Don't update TaskMonitor when deserializing ServerCrashProcedure

2020-06-03 Thread GitBox
Apache9 commented on pull request #1826: URL: https://github.com/apache/hbase/pull/1826#issuecomment-638527858 > Thanks for suggestion @Apache9, but I don't think that's going to work for the case of state being `SERVER_CRASH_FINISH`. With such code change, `executeFromState` will end up

[jira] [Updated] (HBASE-21905) TestFIFOCompactionPolicy is flaky

2020-06-03 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada updated HBASE-21905: - Fix Version/s: 2.4.0 3.0.0-alpha-1 Resolution: Fixed

[GitHub] [hbase] Apache-HBase commented on pull request #1833: Backport "HBASE-24418 Consolidate Normalizer implementations" to branch-2

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1833: URL: https://github.com/apache/hbase/pull/1833#issuecomment-638522363 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] ndimiduk commented on a change in pull request #1844: HBASE-23997 Consider JDK11 in our support matrix

2020-06-03 Thread GitBox
ndimiduk commented on a change in pull request #1844: URL: https://github.com/apache/hbase/pull/1844#discussion_r434920380 ## File path: src/main/asciidoc/_chapters/configuration.adoc ## @@ -97,55 +97,76 @@ This section lists required services and some required system

[GitHub] [hbase] ndimiduk commented on a change in pull request #1844: HBASE-23997 Consider JDK11 in our support matrix

2020-06-03 Thread GitBox
ndimiduk commented on a change in pull request #1844: URL: https://github.com/apache/hbase/pull/1844#discussion_r434919844 ## File path: src/main/asciidoc/_chapters/configuration.adoc ## @@ -97,55 +97,76 @@ This section lists required services and some required system

[jira] [Updated] (HBASE-24418) Consolidate Normalizer implementations

2020-06-03 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-24418: - Release Note: This change extends the Normalizer with a handful of new configurations. The

[GitHub] [hbase] clarax commented on pull request #1843: HBASE-24268 REST and Thrift server do not handle the "doAs" parameter case insensitively

2020-06-03 Thread GitBox
clarax commented on pull request #1843: URL: https://github.com/apache/hbase/pull/1843#issuecomment-638518587 It is great that you are tackling this. Could you please add a test in the PR or a screenshot at the lira for validation? Otherwise LGTM

[jira] [Resolved] (HBASE-24418) Consolidate Normalizer implementations

2020-06-03 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-24418. -- Resolution: Fixed > Consolidate Normalizer implementations >

[jira] [Updated] (HBASE-24418) Consolidate Normalizer implementations

2020-06-03 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-24418: - Fix Version/s: 3.0.0-alpha-1 > Consolidate Normalizer implementations >

[jira] [Updated] (HBASE-24418) Consolidate Normalizer implementations

2020-06-03 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-24418: - Priority: Major (was: Blocker) > Consolidate Normalizer implementations >

[GitHub] [hbase] ndimiduk merged pull request #1834: Backport "HBASE-24418 Consolidate Normalizer implementations" to branch-2.3

2020-06-03 Thread GitBox
ndimiduk merged pull request #1834: URL: https://github.com/apache/hbase/pull/1834 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] ndimiduk merged pull request #1833: Backport "HBASE-24418 Consolidate Normalizer implementations" to branch-2

2020-06-03 Thread GitBox
ndimiduk merged pull request #1833: URL: https://github.com/apache/hbase/pull/1833 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] joshelser commented on pull request #1847: HBASE-24280 ADDENDUM branch on CHANGE_TARGET instead of BRANCH_NAME

2020-06-03 Thread GitBox
joshelser commented on pull request #1847: URL: https://github.com/apache/hbase/pull/1847#issuecomment-638516756 Thanks Nick! This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Resolved] (HBASE-24280) Hadoop2 and Hadoop3 profiles being activated simultaneously causing test failures

2020-06-03 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-24280. -- Resolution: Fixed Pushed addendum to branch-2 and branch-2.3. > Hadoop2 and Hadoop3 profiles

[GitHub] [hbase] z-york commented on pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…

2020-06-03 Thread GitBox
z-york commented on pull request #1791: URL: https://github.com/apache/hbase/pull/1791#issuecomment-638516415 Looks good to me. Thanks for the changes. Let's wait to see if @ndimiduk has any further comments. This is an

[GitHub] [hbase] ndimiduk merged pull request #1848: Backport "HBASE-24309 ADDENDUM remove redundant dependency" to branch-2.3

2020-06-03 Thread GitBox
ndimiduk merged pull request #1848: URL: https://github.com/apache/hbase/pull/1848 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] clarax commented on pull request #1819: HBASE-24478 The regionInfo parameter for MasterProcedureScheduler#wai…

2020-06-03 Thread GitBox
clarax commented on pull request #1819: URL: https://github.com/apache/hbase/pull/1819#issuecomment-638516537 You are right since regionInfo is an HBase entity. This is an automated message from the Apache Git Service. To

[GitHub] [hbase] ndimiduk opened a new pull request #1849: Revert inadvertent merge commit and re-apply HBASE-24280 ADDENDUM to branch-2

2020-06-03 Thread GitBox
ndimiduk opened a new pull request #1849: URL: https://github.com/apache/hbase/pull/1849 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] ndimiduk merged pull request #1849: Revert inadvertent merge commit and re-apply HBASE-24280 ADDENDUM to branch-2

2020-06-03 Thread GitBox
ndimiduk merged pull request #1849: URL: https://github.com/apache/hbase/pull/1849 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] z-york commented on a change in pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…

2020-06-03 Thread GitBox
z-york commented on a change in pull request #1791: URL: https://github.com/apache/hbase/pull/1791#discussion_r434912178 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotDescriptionUtils.java ## @@ -383,25 +385,38 @@ public static

[GitHub] [hbase] ndimiduk opened a new pull request #1848: Backport "HBASE-24309 ADDENDUM remove redundant dependency" to branch-2.3

2020-06-03 Thread GitBox
ndimiduk opened a new pull request #1848: URL: https://github.com/apache/hbase/pull/1848 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] ndimiduk commented on pull request #1847: HBASE-24280 ADDENDUM branch on CHANGE_TARGET instead of BRANCH_NAME

2020-06-03 Thread GitBox
ndimiduk commented on pull request #1847: URL: https://github.com/apache/hbase/pull/1847#issuecomment-638513526 wtf GitHub made a merge commit? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] bharathv merged pull request #1829: HBASE-21905: [FIFOCompaction] Don't compact already inflight store files

2020-06-03 Thread GitBox
bharathv merged pull request #1829: URL: https://github.com/apache/hbase/pull/1829 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] ndimiduk merged pull request #1847: HBASE-24280 ADDENDUM branch on CHANGE_TARGET instead of BRANCH_NAME

2020-06-03 Thread GitBox
ndimiduk merged pull request #1847: URL: https://github.com/apache/hbase/pull/1847 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] ndimiduk commented on pull request #1847: HBASE-24280 ADDENDUM branch on CHANGE_TARGET instead of BRANCH_NAME

2020-06-03 Thread GitBox
ndimiduk commented on pull request #1847: URL: https://github.com/apache/hbase/pull/1847#issuecomment-638510142 JDK11 Hadoop3 passed over on my PR. Merging this. This is an automated message from the Apache Git Service. To

[GitHub] [hbase] Apache-HBase commented on pull request #1833: Backport "HBASE-24418 Consolidate Normalizer implementations" to branch-2

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1833: URL: https://github.com/apache/hbase/pull/1833#issuecomment-638504153 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1791: URL: https://github.com/apache/hbase/pull/1791#issuecomment-638501372 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1818: HBASE-24456 : Create ImmutableScan and use it for CustomizedScanInfoBuilder

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1818: URL: https://github.com/apache/hbase/pull/1818#issuecomment-638497943 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-23963) Split TestFromClientSide; it takes too long to complete timing out

2020-06-03 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125365#comment-17125365 ] Hudson commented on HBASE-23963: Results for branch branch-2.2 [build #884 on

[jira] [Commented] (HBASE-24412) Canary support check only one column family per RegionTask

2020-06-03 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125363#comment-17125363 ] Hudson commented on HBASE-24412: Results for branch branch-2.2 [build #884 on

[jira] [Commented] (HBASE-24467) Backport HBASE-23963: Split TestFromClientSide; it takes too long to complete timing out

2020-06-03 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125364#comment-17125364 ] Hudson commented on HBASE-24467: Results for branch branch-2.2 [build #884 on

[GitHub] [hbase] Apache-HBase commented on pull request #1818: HBASE-24456 : Create ImmutableScan and use it for CustomizedScanInfoBuilder

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1818: URL: https://github.com/apache/hbase/pull/1818#issuecomment-638494590 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1834: Backport "HBASE-24418 Consolidate Normalizer implementations" to branch-2.3

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1834: URL: https://github.com/apache/hbase/pull/1834#issuecomment-638475141 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1791: URL: https://github.com/apache/hbase/pull/1791#issuecomment-638474023 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Comment Edited] (HBASE-24010) HBase shell list_peers command is displayed incorrectly

2020-06-03 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125292#comment-17125292 ] Michael Stack edited comment on HBASE-24010 at 6/3/20, 8:42 PM: If of

[jira] [Comment Edited] (HBASE-24010) HBase shell list_peers command is displayed incorrectly

2020-06-03 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125292#comment-17125292 ] Michael Stack edited comment on HBASE-24010 at 6/3/20, 8:41 PM: If of

[jira] [Commented] (HBASE-13583) AOT compile our JRuby

2020-06-03 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-13583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125300#comment-17125300 ] Nick Dimiduk commented on HBASE-13583: -- bq. which means we'll get neither startup speedup or java

[jira] [Commented] (HBASE-13583) AOT compile our JRuby

2020-06-03 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-13583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125299#comment-17125299 ] Nick Dimiduk commented on HBASE-13583: -- Not sure if it helps here, but looks like there's a tool

[jira] [Comment Edited] (HBASE-24010) HBase shell list_peers command is displayed incorrectly

2020-06-03 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125292#comment-17125292 ] Michael Stack edited comment on HBASE-24010 at 6/3/20, 8:28 PM: If of

[jira] [Commented] (HBASE-24010) HBase shell list_peers command is displayed incorrectly

2020-06-03 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125292#comment-17125292 ] Michael Stack commented on HBASE-24010: --- If of use, here is how it used look in old days when you

[GitHub] [hbase] Apache-HBase commented on pull request #1833: Backport "HBASE-24418 Consolidate Normalizer implementations" to branch-2

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1833: URL: https://github.com/apache/hbase/pull/1833#issuecomment-638431632 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1840: HBASE-24500 The behavior of RegionInfoBuilder.newBuilder(RegionInfo) …

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1840: URL: https://github.com/apache/hbase/pull/1840#issuecomment-638427495 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1840: HBASE-24500 The behavior of RegionInfoBuilder.newBuilder(RegionInfo) …

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1840: URL: https://github.com/apache/hbase/pull/1840#issuecomment-638424719 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] virajjasani commented on a change in pull request #1844: HBASE-23997 Consider JDK11 in our support matrix

2020-06-03 Thread GitBox
virajjasani commented on a change in pull request #1844: URL: https://github.com/apache/hbase/pull/1844#discussion_r434805966 ## File path: src/main/asciidoc/_chapters/configuration.adoc ## @@ -97,55 +97,76 @@ This section lists required services and some required system

[GitHub] [hbase] virajjasani commented on a change in pull request #1844: HBASE-23997 Consider JDK11 in our support matrix

2020-06-03 Thread GitBox
virajjasani commented on a change in pull request #1844: URL: https://github.com/apache/hbase/pull/1844#discussion_r434805966 ## File path: src/main/asciidoc/_chapters/configuration.adoc ## @@ -97,55 +97,76 @@ This section lists required services and some required system

[GitHub] [hbase] virajjasani commented on a change in pull request #1844: HBASE-23997 Consider JDK11 in our support matrix

2020-06-03 Thread GitBox
virajjasani commented on a change in pull request #1844: URL: https://github.com/apache/hbase/pull/1844#discussion_r434805966 ## File path: src/main/asciidoc/_chapters/configuration.adoc ## @@ -97,55 +97,76 @@ This section lists required services and some required system

[GitHub] [hbase] virajjasani commented on a change in pull request #1844: HBASE-23997 Consider JDK11 in our support matrix

2020-06-03 Thread GitBox
virajjasani commented on a change in pull request #1844: URL: https://github.com/apache/hbase/pull/1844#discussion_r434805966 ## File path: src/main/asciidoc/_chapters/configuration.adoc ## @@ -97,55 +97,76 @@ This section lists required services and some required system

[jira] [Commented] (HBASE-24255) GCRegionProcedure doesn't assign region from RegionServer leading to orphans

2020-06-03 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125257#comment-17125257 ] Huaxiang Sun commented on HBASE-24255: -- My comments regarding with merge is wrong (merge is done

[GitHub] [hbase] virajjasani commented on a change in pull request #1844: HBASE-23997 Consider JDK11 in our support matrix

2020-06-03 Thread GitBox
virajjasani commented on a change in pull request #1844: URL: https://github.com/apache/hbase/pull/1844#discussion_r434793703 ## File path: src/main/asciidoc/_chapters/configuration.adoc ## @@ -97,55 +97,76 @@ This section lists required services and some required system

[GitHub] [hbase] Apache-HBase commented on pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1791: URL: https://github.com/apache/hbase/pull/1791#issuecomment-638411813 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] huaxiangsun commented on pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…

2020-06-03 Thread GitBox
huaxiangsun commented on pull request #1791: URL: https://github.com/apache/hbase/pull/1791#issuecomment-638405644 @z-york I uploaded a new patch which addresses some of your comments, put up explain for rest of your comments. Please let me know if there is anything missing, thanks.

[GitHub] [hbase] Apache-HBase commented on pull request #1818: HBASE-24456 : Create ImmutableScan and use it for CustomizedScanInfoBuilder

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1818: URL: https://github.com/apache/hbase/pull/1818#issuecomment-638395777 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24205) Create metric to know the number of reads that happens from memstore

2020-06-03 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125220#comment-17125220 ] Anoop Sam John commented on HBASE-24205: Aggregated at region level means it will consider all

[GitHub] [hbase] ndimiduk commented on pull request #1847: HBASE-24280 ADDENDUM branch on CHANGE_TARGET instead of BRANCH_NAME

2020-06-03 Thread GitBox
ndimiduk commented on pull request #1847: URL: https://github.com/apache/hbase/pull/1847#issuecomment-638385363 Testing with #1833 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hbase] huaxiangsun commented on a change in pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…

2020-06-03 Thread GitBox
huaxiangsun commented on a change in pull request #1791: URL: https://github.com/apache/hbase/pull/1791#discussion_r434772239 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotHFileCleaner.java ## @@ -93,12 +94,17 @@ public void

[GitHub] [hbase] huaxiangsun commented on a change in pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…

2020-06-03 Thread GitBox
huaxiangsun commented on a change in pull request #1791: URL: https://github.com/apache/hbase/pull/1791#discussion_r434769865 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotDescriptionUtils.java ## @@ -383,25 +385,38 @@ public static

[GitHub] [hbase] saintstack commented on a change in pull request #1825: HBASE-24189 WALSplit recreates region dirs for deleted table with rec…

2020-06-03 Thread GitBox
saintstack commented on a change in pull request #1825: URL: https://github.com/apache/hbase/pull/1825#discussion_r434763752 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java ## @@ -285,23 +286,35 @@ boolean splitLogFile(FileStatus logfile,

[GitHub] [hbase] Apache-HBase commented on pull request #1847: HBASE-24280 ADDENDUM branch on CHANGE_TARGET instead of BRANCH_NAME

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1847: URL: https://github.com/apache/hbase/pull/1847#issuecomment-638372347 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #1847: HBASE-24280 ADDENDUM branch on CHANGE_TARGET instead of BRANCH_NAME

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1847: URL: https://github.com/apache/hbase/pull/1847#issuecomment-638371496 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1847: HBASE-24280 ADDENDUM branch on CHANGE_TARGET instead of BRANCH_NAME

2020-06-03 Thread GitBox
Apache-HBase commented on pull request #1847: URL: https://github.com/apache/hbase/pull/1847#issuecomment-638371296 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] virajjasani commented on a change in pull request #1818: HBASE-24456 : Create ImmutableScan and use it for CustomizedScanInfoBuilder

2020-06-03 Thread GitBox
virajjasani commented on a change in pull request #1818: URL: https://github.com/apache/hbase/pull/1818#discussion_r434758421 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ImmutableScan.java ## @@ -0,0 +1,543 @@ +/* + * + * Licensed to the Apache

  1   2   3   >