[GitHub] [hbase] bsglz commented on pull request #1337: HBASE-24038 Add a metric to show the locality of ssd in table.jsp

bsglz commented on pull request #1337: URL: https://github.com/apache/hbase/pull/1337#issuecomment-638122516 @wchevreuil Sorry for the delay, since it remove the checkbox and use tabs in latest version, i add a new tab named Localities, including two metrics Locality and LocalityForSsd.

[GitHub] [hbase] infraio commented on a change in pull request #1840: HBASE-24500 The behavior of RegionInfoBuilder.newBuilder(RegionInfo) …

infraio commented on a change in pull request #1840: URL: https://github.com/apache/hbase/pull/1840#discussion_r434471121 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionInfoBuilder.java ## @@ -302,30 +283,28 @@ public void

[GitHub] [hbase] Apache-HBase commented on pull request #1743: HBASE-24403 FsDelegationToken Should Cache Token After Acquired A New One

Apache-HBase commented on pull request #1743: URL: https://github.com/apache/hbase/pull/1743#issuecomment-638106437 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-23296) Add CompositeBucketCache to support tiered BC

[ https://issues.apache.org/jira/browse/HBASE-23296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124834#comment-17124834 ] Anoop Sam John commented on HBASE-23296: The way we can introduce that can be this way (I

[GitHub] [hbase] Apache9 commented on a change in pull request #1840: HBASE-24500 The behavior of RegionInfoBuilder.newBuilder(RegionInfo) …

Apache9 commented on a change in pull request #1840: URL: https://github.com/apache/hbase/pull/1840#discussion_r434450351 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java ## @@ -3355,8 +3354,10 @@ public static String

[GitHub] [hbase] Apache9 commented on a change in pull request #1840: HBASE-24500 The behavior of RegionInfoBuilder.newBuilder(RegionInfo) …

Apache9 commented on a change in pull request #1840: URL: https://github.com/apache/hbase/pull/1840#discussion_r434450669 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionInfoBuilder.java ## @@ -302,30 +283,28 @@ public void

[GitHub] [hbase] Apache-HBase commented on pull request #1841: HBASE-24208 Remove RS entry from zk draining servers node after RS been stopped

Apache-HBase commented on pull request #1841: URL: https://github.com/apache/hbase/pull/1841#issuecomment-638091249 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1764: HBASE-24420 Avoid Meaningless Retry Attempts in Unrecoverable Failure

Apache-HBase commented on pull request #1764: URL: https://github.com/apache/hbase/pull/1764#issuecomment-638083491 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1840: HBASE-24500 The behavior of RegionInfoBuilder.newBuilder(RegionInfo) …

Apache-HBase commented on pull request #1840: URL: https://github.com/apache/hbase/pull/1840#issuecomment-638076577 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] infraio commented on a change in pull request #1840: HBASE-24500 The behavior of RegionInfoBuilder.newBuilder(RegionInfo) …

infraio commented on a change in pull request #1840: URL: https://github.com/apache/hbase/pull/1840#discussion_r434428788 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java ## @@ -3355,8 +3354,10 @@ public static String

[GitHub] [hbase] Apache-HBase commented on pull request #1830: HBASE-24491 Remove HRegionInfo

Apache-HBase commented on pull request #1830: URL: https://github.com/apache/hbase/pull/1830#issuecomment-638074898 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] gkanade opened a new pull request #1841: HBASE-24208 Remove RS entry from zk draining servers node after RS been stopped

gkanade opened a new pull request #1841: URL: https://github.com/apache/hbase/pull/1841 removed RS entry from zk draining server znode on RS stopped This is an automated message from the Apache Git Service. To respond to the

[jira] [Updated] (HBASE-21406) "status 'replication'" should not show SINK if the cluster does not act as sink

[ https://issues.apache.org/jira/browse/HBASE-21406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-21406: - Fix Version/s: 2.4.0 > "status 'replication'" should not show SINK if the

[jira] [Updated] (HBASE-21406) "status 'replication'" should not show SINK if the cluster does not act as sink

[ https://issues.apache.org/jira/browse/HBASE-21406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-21406: - Affects Version/s: 2.4.0 2.3.0

[GitHub] [hbase] virajjasani commented on a change in pull request #1839: HBASE-24497: Close one off connections in RawSyncHBaseAdmin.

virajjasani commented on a change in pull request #1839: URL: https://github.com/apache/hbase/pull/1839#discussion_r434406124 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java ## @@ -3521,20 +3522,33 @@ private void

[jira] [Updated] (HBASE-24500) The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange

[ https://issues.apache.org/jira/browse/HBASE-24500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24500: -- Fix Version/s: 2.2.6 2.3.0 3.0.0-alpha-1 > The behavior of

[GitHub] [hbase] Apache9 opened a new pull request #1840: HBASE-24500 The behavior of RegionInfoBuilder.newBuilder(RegionInfo) …

Apache9 opened a new pull request #1840: URL: https://github.com/apache/hbase/pull/1840 …is strange This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hbase] bsglz edited a comment on pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…

bsglz edited a comment on pull request #1737: URL: https://github.com/apache/hbase/pull/1737#issuecomment-638046560 @saintstack @Apache9 Help to review it if you have time, Thanks. This is an automated message from the

[GitHub] [hbase] bsglz commented on pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…

bsglz commented on pull request #1737: URL: https://github.com/apache/hbase/pull/1737#issuecomment-638046560 @saintstack @Apache9 Help review if you have time, Thanks. This is an automated message from the Apache Git

[GitHub] [hbase] Apache-HBase commented on pull request #1743: HBASE-24403 FsDelegationToken Should Cache Token After Acquired A New One

Apache-HBase commented on pull request #1743: URL: https://github.com/apache/hbase/pull/1743#issuecomment-638046066 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] virajjasani commented on a change in pull request #1839: HBASE-24497: Close one off connections in RawSyncHBaseAdmin.

virajjasani commented on a change in pull request #1839: URL: https://github.com/apache/hbase/pull/1839#discussion_r434395602 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java ## @@ -3521,20 +3522,33 @@ private void

[GitHub] [hbase] Apache-HBase commented on pull request #1764: HBASE-24420 Avoid Meaningless Retry Attempts in Unrecoverable Failure

Apache-HBase commented on pull request #1764: URL: https://github.com/apache/hbase/pull/1764#issuecomment-638043811 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping

[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124743#comment-17124743 ] Viraj Jasani commented on HBASE-24492: -- Let's wait for [~stack]'s confirmation. So far, pushed to

[GitHub] [hbase] virajjasani merged pull request #1831: HBASE-24492 : Remove infinite loop from ProtobufLogReader#readNext

virajjasani merged pull request #1831: URL: https://github.com/apache/hbase/pull/1831 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] ramkrish86 commented on a change in pull request #1552: HBASE-24205 Create metric to know the number of reads that happens fr…

ramkrish86 commented on a change in pull request #1552: URL: https://github.com/apache/hbase/pull/1552#discussion_r434376478 ## File path: hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsStoreAggregateSource.java ## @@ -0,0 +1,60 @@ +/** + *

[GitHub] [hbase] Apache-HBase commented on pull request #1837: HBASE-24496 The tab of Base Stats not actived by default in table.jsp

Apache-HBase commented on pull request #1837: URL: https://github.com/apache/hbase/pull/1837#issuecomment-638023212 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] ramkrish86 commented on a change in pull request #1552: HBASE-24205 Create metric to know the number of reads that happens fr…

ramkrish86 commented on a change in pull request #1552: URL: https://github.com/apache/hbase/pull/1552#discussion_r434369134 ## File path: hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsStoreAggregateSource.java ## @@ -0,0 +1,60 @@ +/** + *

[jira] [Commented] (HBASE-23296) Add CompositeBucketCache to support tiered BC

[ https://issues.apache.org/jira/browse/HBASE-23296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124700#comment-17124700 ] Guanghao Zhang commented on HBASE-23296: {quote}Do you mean BucketCache with heap ioEngine?

[jira] [Commented] (HBASE-24347) Hadoop2 profiles are both active when pre-commit PR builds run

[ https://issues.apache.org/jira/browse/HBASE-24347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124709#comment-17124709 ] Guanghao Zhang commented on HBASE-24347: {quote}I think much of the CI refactoring I did to

[jira] [Assigned] (HBASE-24500) The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange

[ https://issues.apache.org/jira/browse/HBASE-24500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-24500: - Assignee: Duo Zhang > The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange >

[jira] [Work started] (HBASE-24500) The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange

[ https://issues.apache.org/jira/browse/HBASE-24500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-24500 started by Duo Zhang. - > The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange >

[jira] [Updated] (HBASE-24500) The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange

[ https://issues.apache.org/jira/browse/HBASE-24500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24500: -- Priority: Critical (was: Major) > The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is

[jira] [Created] (HBASE-24500) The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange

Duo Zhang created HBASE-24500: - Summary: The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange Key: HBASE-24500 URL: https://issues.apache.org/jira/browse/HBASE-24500 Project: HBase

[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping

[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124695#comment-17124695 ] Viraj Jasani commented on HBASE-24492: -- Thanks [~zhangduo] Exactly the loop is useless and

[jira] [Updated] (HBASE-24500) The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange

[ https://issues.apache.org/jira/browse/HBASE-24500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24500: -- Component/s: read replicas Client > The behavior of

[jira] [Updated] (HBASE-24492) ProtobufLogReader.readNext does not need looping

[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24492: -- Component/s: wal Replication > ProtobufLogReader.readNext does not need looping >

[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping

[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124691#comment-17124691 ] Duo Zhang commented on HBASE-24492: --- OK, checked the code, there is a 'return true' at the last of the

[GitHub] [hbase] Apache9 commented on pull request #1830: HBASE-24491 Remove HRegionInfo

Apache9 commented on pull request #1830: URL: https://github.com/apache/hbase/pull/1830#issuecomment-638006266 The failed UT is caused by a serious problem of our RegionInfo related API. Let me open a new issue for fixing it.

[jira] [Comment Edited] (HBASE-24492) ProtobufLogReader.readNext does not need looping

[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124667#comment-17124667 ] Viraj Jasani edited comment on HBASE-24492 at 6/3/20, 7:09 AM: ---

[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping

[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124667#comment-17124667 ] Viraj Jasani commented on HBASE-24492: -- [~zhangduo] The issue is not visible at production level.

[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping

[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124664#comment-17124664 ] Duo Zhang commented on HBASE-24492: --- Do you hit this in real production? Or can you reproduce the

[GitHub] [hbase] Apache9 commented on a change in pull request #1839: HBASE-24497: Close one off connections in RawSyncHBaseAdmin.

Apache9 commented on a change in pull request #1839: URL: https://github.com/apache/hbase/pull/1839#discussion_r434343419 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java ## @@ -3521,20 +3522,33 @@ private void

[GitHub] [hbase] Apache9 commented on pull request #1838: HBASE-24498: Include jetty-schemas so that xml parsing does not need …

Apache9 commented on pull request #1838: URL: https://github.com/apache/hbase/pull/1838#issuecomment-637992660 It will be good if we do not need to go to sun/oracle urls. Mind explaining a bit about how adding a dependency could solve the problem? And seems the build is failing?

[GitHub] [hbase] Apache-HBase commented on pull request #1830: HBASE-24491 Remove HRegionInfo

Apache-HBase commented on pull request #1830: URL: https://github.com/apache/hbase/pull/1830#issuecomment-637991532 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24456) Immutable Scan as unmodifiable subclass or wrapper of Scan

[ https://issues.apache.org/jira/browse/HBASE-24456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124644#comment-17124644 ] Viraj Jasani commented on HBASE-24456: -- [~ndimiduk] ACK and agree on keeping it till branch-2. >

[jira] [Updated] (HBASE-24496) The tab of Base Stats not actived by default in table.jsp

[ https://issues.apache.org/jira/browse/HBASE-24496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Wang updated HBASE-24496: --- Summary: The tab of Base Stats not actived by default in table.jsp (was: The tag of Base Stats not

[jira] [Resolved] (HBASE-24467) Backport HBASE-23963: Split TestFromClientSide; it takes too long to complete timing out

[ https://issues.apache.org/jira/browse/HBASE-24467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang resolved HBASE-24467. Resolution: Fixed Merged to branch-2.2. Thanks [~zhangduo] [~stack] for reviewing. >

[jira] [Updated] (HBASE-24467) Backport HBASE-23963: Split TestFromClientSide; it takes too long to complete timing out

[ https://issues.apache.org/jira/browse/HBASE-24467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-24467: --- Fix Version/s: 2.2.6 > Backport HBASE-23963: Split TestFromClientSide; it takes too long to

[GitHub] [hbase] infraio merged pull request #1805: HBASE-24467 Backport HBASE-23963: Split TestFromClientSide; it takes …

infraio merged pull request #1805: URL: https://github.com/apache/hbase/pull/1805 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #1837: HBASE-24496 The tag of Base Stats not actived by default in table.jsp

Apache-HBase commented on pull request #1837: URL: https://github.com/apache/hbase/pull/1837#issuecomment-637983439 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24499) Use a client property for SaslConnection MAX_ATTEMPTS (currently hardcoded to 5)

[ https://issues.apache.org/jira/browse/HBASE-24499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124640#comment-17124640 ] Viraj Jasani commented on HBASE-24499: -- [~rvaleti] ACK. Agree, this should be configurable. > Use

[jira] [Updated] (HBASE-24499) Use a client property for SaslConnection MAX_ATTEMPTS (currently hardcoded to 5)

[ https://issues.apache.org/jira/browse/HBASE-24499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-24499: - Fix Version/s: (was: 1.3.7) 1.7.0 > Use a client property for

[GitHub] [hbase] Apache-HBase commented on pull request #1764: HBASE-24420 Avoid Meaningless Retry Attempts in Unrecoverable Failure

Apache-HBase commented on pull request #1764: URL: https://github.com/apache/hbase/pull/1764#issuecomment-637980870 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Comment Edited] (HBASE-24492) ProtobufLogReader.readNext does not need looping

[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124619#comment-17124619 ] Viraj Jasani edited comment on HBASE-24492 at 6/3/20, 6:17 AM: --- [~stack] 

[GitHub] [hbase] Apache-HBase commented on pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…

Apache-HBase commented on pull request #1791: URL: https://github.com/apache/hbase/pull/1791#issuecomment-637979510 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24499) Use a client property for SaslConnection MAX_ATTEMPTS (currently hardcoded to 5)

[ https://issues.apache.org/jira/browse/HBASE-24499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124636#comment-17124636 ] Ravi Kishore Valeti commented on HBASE-24499: - [~vjasani] [~apurt...@yahoo.com]. > Use a

[GitHub] [hbase] Apache-HBase commented on pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…

Apache-HBase commented on pull request #1791: URL: https://github.com/apache/hbase/pull/1791#issuecomment-637976835 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1743: HBASE-24403 FsDelegationToken Should Cache Token After Acquired A New One

Apache-HBase commented on pull request #1743: URL: https://github.com/apache/hbase/pull/1743#issuecomment-637975698 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1743: HBASE-24403 FsDelegationToken Should Cache Token After Acquired A New One

Apache-HBase commented on pull request #1743: URL: https://github.com/apache/hbase/pull/1743#issuecomment-637975313 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

<    1   2   3