[GitHub] [hbase] Apache-HBase commented on pull request #2031: HBASE-24431 RSGroupInfo add configuration map to store something extra

2020-07-07 Thread GitBox
Apache-HBase commented on pull request #2031: URL: https://github.com/apache/hbase/pull/2031#issuecomment-655297477 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2020: HBASE-24682 Refactor ReplicationSource#addHFileRefs method: move it t…

2020-07-07 Thread GitBox
Apache-HBase commented on pull request #2020: URL: https://github.com/apache/hbase/pull/2020#issuecomment-655297174 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2020: HBASE-24682 Refactor ReplicationSource#addHFileRefs method: move it t…

2020-07-07 Thread GitBox
Apache-HBase commented on pull request #2020: URL: https://github.com/apache/hbase/pull/2020#issuecomment-655275577 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2031: HBASE-24431 RSGroupInfo add configuration map to store something extra

2020-07-07 Thread GitBox
Apache-HBase commented on pull request #2031: URL: https://github.com/apache/hbase/pull/2031#issuecomment-655275478 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2034: Backport "HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length. (#1970)" to branch-2

2020-07-07 Thread GitBox
Apache-HBase commented on pull request #2034: URL: https://github.com/apache/hbase/pull/2034#issuecomment-655271781 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2011: HBASE-24664 Some changing of split region by overall region size rath…

2020-07-07 Thread GitBox
Apache-HBase commented on pull request #2011: URL: https://github.com/apache/hbase/pull/2011#issuecomment-655260383 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Comment Edited] (HBASE-24578) [WAL] Add a parameter to config RingBufferEventHandler's SyncFuture count

2020-07-07 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153187#comment-17153187 ] Reid Chan edited comment on HBASE-24578 at 7/8/20, 3:18 AM: Can you provide

[jira] [Commented] (HBASE-24578) [WAL] Add a parameter to config RingBufferEventHandler's SyncFuture count

2020-07-07 Thread wenfeiyi666 (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153192#comment-17153192 ] wenfeiyi666 commented on HBASE-24578: - ok > [WAL] Add a parameter to config

[jira] [Commented] (HBASE-24693) regioninfo#isLast() has a logic error

2020-07-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153190#comment-17153190 ] Duo Zhang commented on HBASE-24693: --- Actually EMPTY_START_ROW and EMPTY_STOP_ROW is the same... So

[jira] [Updated] (HBASE-24693) regioninfo#isLast() has a logic error

2020-07-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24693: -- Priority: Minor (was: Major) > regioninfo#isLast() has a logic error >

[jira] [Commented] (HBASE-24578) [WAL] Add a parameter to config RingBufferEventHandler's SyncFuture count

2020-07-07 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153187#comment-17153187 ] Reid Chan commented on HBASE-24578: --- Can you provide batch for branch-1 and branch-2 as well?

[jira] [Created] (HBASE-24693) regioninfo#isLast() has a logic error

2020-07-07 Thread Bo Cui (Jira)
Bo Cui created HBASE-24693: -- Summary: regioninfo#isLast() has a logic error Key: HBASE-24693 URL: https://issues.apache.org/jira/browse/HBASE-24693 Project: HBase Issue Type: Bug Affects

[GitHub] [hbase] Apache-HBase commented on pull request #2031: HBASE-24431 RSGroupInfo add configuration map to store something extra

2020-07-07 Thread GitBox
Apache-HBase commented on pull request #2031: URL: https://github.com/apache/hbase/pull/2031#issuecomment-655240688 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] WenFeiYi commented on a change in pull request #1962: HBASE-24615 MutableRangeHistogram#updateSnapshotRangeMetrics doesn't calculate the distribution for last bucket.

2020-07-07 Thread GitBox
WenFeiYi commented on a change in pull request #1962: URL: https://github.com/apache/hbase/pull/1962#discussion_r451243720 ## File path: hbase-hadoop-compat/src/test/java/org/apache/hadoop/metrics2/impl/TestMutableRangeHistogram.java ## @@ -0,0 +1,66 @@ +package

[GitHub] [hbase] Apache-HBase commented on pull request #2020: HBASE-24682 Refactor ReplicationSource#addHFileRefs method: move it t…

2020-07-07 Thread GitBox
Apache-HBase commented on pull request #2020: URL: https://github.com/apache/hbase/pull/2020#issuecomment-655237970 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] ddupg commented on pull request #2031: HBASE-24431 RSGroupInfo add configuration map to store something extra

2020-07-07 Thread GitBox
ddupg commented on pull request #2031: URL: https://github.com/apache/hbase/pull/2031#issuecomment-655226713 > +1. @ddupg Please fix the checkstyle warnings. Thanks. Thanks for @infraio reviewing. I've fixed the checkstyle warning.

[GitHub] [hbase] d-c-manning commented on a change in pull request #1962: HBASE-24615 MutableRangeHistogram#updateSnapshotRangeMetrics doesn't calculate the distribution for last bucket.

2020-07-07 Thread GitBox
d-c-manning commented on a change in pull request #1962: URL: https://github.com/apache/hbase/pull/1962#discussion_r451224609 ## File path: hbase-hadoop-compat/src/test/java/org/apache/hadoop/metrics2/impl/TestMutableRangeHistogram.java ## @@ -0,0 +1,66 @@ +package

[jira] [Commented] (HBASE-23994) Add WebUI to Canary

2020-07-07 Thread Zhuoyue Huang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153155#comment-17153155 ] Zhuoyue Huang commented on HBASE-23994: --- By the way, I think WebUI shouldn't show up unless

[GitHub] [hbase] Apache-HBase commented on pull request #2006: HBASE-24632 Enable procedure-based log splitting as default in hbase3

2020-07-07 Thread GitBox
Apache-HBase commented on pull request #2006: URL: https://github.com/apache/hbase/pull/2006#issuecomment-655213062 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-23994) Add WebUI to Canary

2020-07-07 Thread Zhuoyue Huang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153153#comment-17153153 ] Zhuoyue Huang commented on HBASE-23994: --- [~stack] Thank you! Please flip default to off > Add

[jira] [Commented] (HBASE-23994) Add WebUI to Canary

2020-07-07 Thread Zhuoyue Huang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153152#comment-17153152 ] Zhuoyue Huang commented on HBASE-23994: --- With this {code:java}

[GitHub] [hbase] Apache-HBase commented on pull request #2006: HBASE-24632 Enable procedure-based log splitting as default in hbase3

2020-07-07 Thread GitBox
Apache-HBase commented on pull request #2006: URL: https://github.com/apache/hbase/pull/2006#issuecomment-655211843 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-23994) Add WebUI to Canary

2020-07-07 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153150#comment-17153150 ] Michael Stack commented on HBASE-23994: --- No worries [~GeorryHuang] . If you busy, no problem. Just

[GitHub] [hbase] Apache-HBase commented on pull request #2006: HBASE-24632 Enable procedure-based log splitting as default in hbase3

2020-07-07 Thread GitBox
Apache-HBase commented on pull request #2006: URL: https://github.com/apache/hbase/pull/2006#issuecomment-655211049 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] saintstack commented on a change in pull request #2006: HBASE-24632 Enable procedure-based log splitting as default in hbase3

2020-07-07 Thread GitBox
saintstack commented on a change in pull request #2006: URL: https://github.com/apache/hbase/pull/2006#discussion_r451216866 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterWalManager.java ## @@ -360,11 +372,13 @@ public void splitLog(final Set

[jira] [Commented] (HBASE-23994) Add WebUI to Canary

2020-07-07 Thread Zhuoyue Huang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153144#comment-17153144 ] Zhuoyue Huang commented on HBASE-23994: --- [~stack] Sorry to keep you waiting, I forgot to reply to

[jira] [Commented] (HBASE-24625) AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.

2020-07-07 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153140#comment-17153140 ] Hudson commented on HBASE-24625: Results for branch branch-2.2 [build #908 on

[jira] [Updated] (HBASE-24650) Change the return types of the new checkAndMutate methods introduced in HBASE-8458

2020-07-07 Thread Toshihiro Suzuki (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toshihiro Suzuki updated HBASE-24650: - Release Note: HBASE-24650 introduced CheckAndMutateResult class and changed the return

[jira] [Resolved] (HBASE-24650) Change the return types of the new checkAndMutate methods introduced in HBASE-8458

2020-07-07 Thread Toshihiro Suzuki (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toshihiro Suzuki resolved HBASE-24650. -- Hadoop Flags: Incompatible change,Reviewed Release Note: This changed the return

[jira] [Commented] (HBASE-24650) Change the return types of the new checkAndMutate methods introduced in HBASE-8458

2020-07-07 Thread Toshihiro Suzuki (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153124#comment-17153124 ] Toshihiro Suzuki commented on HBASE-24650: -- Pushed to master and branch-2. Thank you for

[GitHub] [hbase] brfrn169 merged pull request #2033: HBASE-24650 Change the return types of the new checkAndMutate methods…

2020-07-07 Thread GitBox
brfrn169 merged pull request #2033: URL: https://github.com/apache/hbase/pull/2033 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] huaxiangsun commented on a change in pull request #1986: HBASE-24581 Skip compaction request/check for replica regions at the …

2020-07-07 Thread GitBox
huaxiangsun commented on a change in pull request #1986: URL: https://github.com/apache/hbase/pull/1986#discussion_r451179756 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestRegionReplicaSplit.java ## @@ -109,11 +112,16 @@ public void

[GitHub] [hbase] Apache-HBase commented on pull request #2034: Backport "HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length. (#1970)" to branch-2

2020-07-07 Thread GitBox
Apache-HBase commented on pull request #2034: URL: https://github.com/apache/hbase/pull/2034#issuecomment-655147081 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2034: Backport "HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length. (#1970)" to branch-2

2020-07-07 Thread GitBox
Apache-HBase commented on pull request #2034: URL: https://github.com/apache/hbase/pull/2034#issuecomment-655138232 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-24687) MobFileCleanerChore uses a new Connection for each table each time it runs

2020-07-07 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-24687: Summary: MobFileCleanerChore uses a new Connection for each table each time it runs (was: New

[jira] [Commented] (HBASE-24625) AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.

2020-07-07 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153099#comment-17153099 ] Hudson commented on HBASE-24625: Results for branch branch-2 [build #2738 on

[jira] [Commented] (HBASE-24686) [LOG] Log improvement in Connection#close

2020-07-07 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153100#comment-17153100 ] Sean Busbey commented on HBASE-24686: - Better logging here especially including who called close

[jira] [Commented] (HBASE-24672) HBase Shell Commands Survey

2020-07-07 Thread Elliot Miller (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153068#comment-17153068 ] Elliot Miller commented on HBASE-24672: --- I created a spreadsheet with the results of my survey. It

[GitHub] [hbase] clarax commented on a change in pull request #1986: HBASE-24581 Skip compaction request/check for replica regions at the …

2020-07-07 Thread GitBox
clarax commented on a change in pull request #1986: URL: https://github.com/apache/hbase/pull/1986#discussion_r451072656 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestRegionReplicaSplit.java ## @@ -109,11 +112,16 @@ public void

[GitHub] [hbase] Apache-HBase commented on pull request #2032: HBASE-24404 Support flush a single column family of region

2020-07-07 Thread GitBox
Apache-HBase commented on pull request #2032: URL: https://github.com/apache/hbase/pull/2032#issuecomment-655090931 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2032: HBASE-24404 Support flush a single column family of region

2020-07-07 Thread GitBox
Apache-HBase commented on pull request #2032: URL: https://github.com/apache/hbase/pull/2032#issuecomment-655090760 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24692) WebUI header bar overlaps page content when window is too narrow

2020-07-07 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153057#comment-17153057 ] Nick Dimiduk commented on HBASE-24692: -- !24692-ex1.png! !24692-ex2.png! !24692-ex3.png! > WebUI

[jira] [Updated] (HBASE-24692) WebUI header bar overlaps page content when window is too narrow

2020-07-07 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-24692: - Attachment: 24692-ex3.png 24692-ex2.png 24692-ex1.png > WebUI

[jira] [Commented] (HBASE-24692) WebUI header bar overlaps page content when window is too narrow

2020-07-07 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153055#comment-17153055 ] Nick Dimiduk commented on HBASE-24692: -- Resizing the page to be more and more narrow demonstrates

[jira] [Created] (HBASE-24692) WebUI header bar overlaps page content when window is too narrow

2020-07-07 Thread Nick Dimiduk (Jira)
Nick Dimiduk created HBASE-24692: Summary: WebUI header bar overlaps page content when window is too narrow Key: HBASE-24692 URL: https://issues.apache.org/jira/browse/HBASE-24692 Project: HBase

[GitHub] [hbase] Apache-HBase commented on pull request #2033: HBASE-24650 Change the return types of the new checkAndMutate methods…

2020-07-07 Thread GitBox
Apache-HBase commented on pull request #2033: URL: https://github.com/apache/hbase/pull/2033#issuecomment-655079661 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2033: HBASE-24650 Change the return types of the new checkAndMutate methods…

2020-07-07 Thread GitBox
Apache-HBase commented on pull request #2033: URL: https://github.com/apache/hbase/pull/2033#issuecomment-655046372 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] catalin-luca commented on a change in pull request #2002: HBASE-24541 Add support to run LoadIncrementalHFiles in a distributed manner

2020-07-07 Thread GitBox
catalin-luca commented on a change in pull request #2002: URL: https://github.com/apache/hbase/pull/2002#discussion_r451051976 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFilesJob.java ## @@ -0,0 +1,348 @@ +/** + * Licensed to

[GitHub] [hbase] catalin-luca commented on a change in pull request #2002: HBASE-24541 Add support to run LoadIncrementalHFiles in a distributed manner

2020-07-07 Thread GitBox
catalin-luca commented on a change in pull request #2002: URL: https://github.com/apache/hbase/pull/2002#discussion_r451051217 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFilesJob.java ## @@ -0,0 +1,348 @@ +/** + * Licensed to

[GitHub] [hbase] Apache-HBase commented on pull request #2034: Backport "HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length. (#1970)" to branch-2

2020-07-07 Thread GitBox
Apache-HBase commented on pull request #2034: URL: https://github.com/apache/hbase/pull/2034#issuecomment-655032727 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] catalin-luca commented on pull request #2002: HBASE-24541 Add support to run LoadIncrementalHFiles in a distributed manner

2020-07-07 Thread GitBox
catalin-luca commented on pull request #2002: URL: https://github.com/apache/hbase/pull/2002#issuecomment-655025128 > Can you point out where you see this in LoadIncrementalHFiles and how this current proposal avoid that, since it basically call LoadIncrementalHFiles.doBulkloadFromQueue

[GitHub] [hbase] Apache-HBase commented on pull request #2032: HBASE-24404 Support flush a single column family of region

2020-07-07 Thread GitBox
Apache-HBase commented on pull request #2032: URL: https://github.com/apache/hbase/pull/2032#issuecomment-655021639 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2034: Backport "HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length. (#1970)" to branch-2

2020-07-07 Thread GitBox
Apache-HBase commented on pull request #2034: URL: https://github.com/apache/hbase/pull/2034#issuecomment-655009745 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] ndimiduk closed pull request #2028: Backport "HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length. (#1970)" to branch-2.3

2020-07-07 Thread GitBox
ndimiduk closed pull request #2028: URL: https://github.com/apache/hbase/pull/2028 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] ndimiduk commented on pull request #2028: Backport "HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length. (#1970)" to branch-2.3

2020-07-07 Thread GitBox
ndimiduk commented on pull request #2028: URL: https://github.com/apache/hbase/pull/2028#issuecomment-655000575 Superseded by #2034 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hbase] huaxiangsun merged pull request #2029: HBASE-24688 AssignRegionHandler uses EventType.M_RS_CLOSE_META instea…

2020-07-07 Thread GitBox
huaxiangsun merged pull request #2029: URL: https://github.com/apache/hbase/pull/2029 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] huaxiangsun commented on pull request #2029: HBASE-24688 AssignRegionHandler uses EventType.M_RS_CLOSE_META instea…

2020-07-07 Thread GitBox
huaxiangsun commented on pull request #2029: URL: https://github.com/apache/hbase/pull/2029#issuecomment-654994877 The test failure TestBucketCache seems flaky, a local run of the test passed. This is an automated message

[jira] [Commented] (HBASE-21220) Port HBASE-20636 (Introduce two bloom filter type : ROWPREFIX and ROWPREFIX_DELIMITED) to branch-1

2020-07-07 Thread Alex Batyrshin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152895#comment-17152895 ] Alex Batyrshin commented on HBASE-21220: Any idea why patch was not back ported to branch-1? >

[GitHub] [hbase] Apache-HBase commented on pull request #2032: HBASE-24404 Support flush a single column family of region

2020-07-07 Thread GitBox
Apache-HBase commented on pull request #2032: URL: https://github.com/apache/hbase/pull/2032#issuecomment-654989586 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2032: HBASE-24404 Support flush a single column family of region

2020-07-07 Thread GitBox
Apache-HBase commented on pull request #2032: URL: https://github.com/apache/hbase/pull/2032#issuecomment-654989251 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2033: HBASE-24650 Change the return types of the new checkAndMutate methods…

2020-07-07 Thread GitBox
Apache-HBase commented on pull request #2033: URL: https://github.com/apache/hbase/pull/2033#issuecomment-654983369 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2011: HBASE-24664 Some changing of split region by overall region size rath…

2020-07-07 Thread GitBox
Apache-HBase commented on pull request #2011: URL: https://github.com/apache/hbase/pull/2011#issuecomment-654981402 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase-native-client] bharathv edited a comment on pull request #10: HBASE-24642: Apache Yetus test-patch integration.

2020-07-07 Thread GitBox
bharathv edited a comment on pull request #10: URL: https://github.com/apache/hbase-native-client/pull/10#issuecomment-654970367 Anyone has some free cycles to take a look at this patch? It should be fairly straight forward with some basic understanding of Yetus. There are some minor

[GitHub] [hbase-native-client] bharathv commented on pull request #10: HBASE-24642: Apache Yetus test-patch integration.

2020-07-07 Thread GitBox
bharathv commented on pull request #10: URL: https://github.com/apache/hbase-native-client/pull/10#issuecomment-654970367 Anyone has some free cycles to take a look at this patch? It should be fairly straight forward with some basic understanding of Yetus. There are some minor quirks

[GitHub] [hbase] Apache-HBase commented on pull request #2011: HBASE-24664 Some changing of split region by overall region size rath…

2020-07-07 Thread GitBox
Apache-HBase commented on pull request #2011: URL: https://github.com/apache/hbase/pull/2011#issuecomment-654960264 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2011: HBASE-24664 Some changing of split region by overall region size rath…

2020-07-07 Thread GitBox
Apache-HBase commented on pull request #2011: URL: https://github.com/apache/hbase/pull/2011#issuecomment-654955872 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Comment Edited] (HBASE-23994) Add WebUI to Canary

2020-07-07 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152836#comment-17152836 ] Michael Stack edited comment on HBASE-23994 at 7/7/20, 3:49 PM: Any luck

[jira] [Commented] (HBASE-23994) Add WebUI to Canary

2020-07-07 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152836#comment-17152836 ] Michael Stack commented on HBASE-23994: --- Any luck [~GeorryHuang] ? Perhaps webui should default

[GitHub] [hbase] Apache-HBase commented on pull request #2033: HBASE-24650 Change the return types of the new checkAndMutate methods…

2020-07-07 Thread GitBox
Apache-HBase commented on pull request #2033: URL: https://github.com/apache/hbase/pull/2033#issuecomment-654950795 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2033: HBASE-24650 Change the return types of the new checkAndMutate methods…

2020-07-07 Thread GitBox
Apache-HBase commented on pull request #2033: URL: https://github.com/apache/hbase/pull/2033#issuecomment-654917289 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24685) MultiAction and FailureInfo should be removed

2020-07-07 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152795#comment-17152795 ] Hudson commented on HBASE-24685: Results for branch master [build #1779 on

[jira] [Commented] (HBASE-24650) Change the return types of the new checkAndMutate methods introduced in HBASE-8458

2020-07-07 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152796#comment-17152796 ] Hudson commented on HBASE-24650: Results for branch master [build #1779 on

[GitHub] [hbase] Apache-HBase commented on pull request #2032: HBASE-24404 Support flush a single column family of region

2020-07-07 Thread GitBox
Apache-HBase commented on pull request #2032: URL: https://github.com/apache/hbase/pull/2032#issuecomment-654913657 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24625) AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.

2020-07-07 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152788#comment-17152788 ] chenglei commented on HBASE-24625: -- [~zhangduo], the PR for branch-2 is

[jira] [Commented] (HBASE-24541) Add support to run LoadIncrementalHFiles in a distributed manner

2020-07-07 Thread Constantin-Catalin Luca (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152778#comment-17152778 ] Constantin-Catalin Luca commented on HBASE-24541: - Ok, I will submit a PR for master as

[GitHub] [hbase] Apache-HBase commented on pull request #2011: HBASE-24664 Some changing of split region by overall region size rath…

2020-07-07 Thread GitBox
Apache-HBase commented on pull request #2011: URL: https://github.com/apache/hbase/pull/2011#issuecomment-654889648 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2034: Backport "HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length. (#1970)" to branch-2

2020-07-07 Thread GitBox
Apache-HBase commented on pull request #2034: URL: https://github.com/apache/hbase/pull/2034#issuecomment-654888610 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase-native-client] phrocker commented on pull request #6: HBASE-23105: Download lib double conversion, fizz, update folly

2020-07-07 Thread GitBox
phrocker commented on pull request #6: URL: https://github.com/apache/hbase-native-client/pull/6#issuecomment-654886206 > Had a chance to apply your patch locally and try it out, running into this weird linker issue. > > >

[GitHub] [hbase] Apache-HBase commented on pull request #2011: HBASE-24664 Some changing of split region by overall region size rath…

2020-07-07 Thread GitBox
Apache-HBase commented on pull request #2011: URL: https://github.com/apache/hbase/pull/2011#issuecomment-654880233 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2011: HBASE-24664 Some changing of split region by overall region size rath…

2020-07-07 Thread GitBox
Apache-HBase commented on pull request #2011: URL: https://github.com/apache/hbase/pull/2011#issuecomment-654873701 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2032: HBASE-24404 Support flush a single column family of region

2020-07-07 Thread GitBox
Apache-HBase commented on pull request #2032: URL: https://github.com/apache/hbase/pull/2032#issuecomment-654870422 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] comnetwork opened a new pull request #2034: HBASE-24625

2020-07-07 Thread GitBox
comnetwork opened a new pull request #2034: URL: https://github.com/apache/hbase/pull/2034 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hbase] bsglz commented on a change in pull request #2011: HBASE-24664 Some changing of split region by overall region size rath…

2020-07-07 Thread GitBox
bsglz commented on a change in pull request #2011: URL: https://github.com/apache/hbase/pull/2011#discussion_r450846252 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ConstantSizeRegionSplitPolicy.java ## @@ -94,4 +94,33 @@ long

[GitHub] [hbase] bsglz commented on a change in pull request #2011: HBASE-24664 Some changing of split region by overall region size rath…

2020-07-07 Thread GitBox
bsglz commented on a change in pull request #2011: URL: https://github.com/apache/hbase/pull/2011#discussion_r450842948 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ConstantSizeRegionSplitPolicy.java ## @@ -68,22 +76,14 @@ protected void

[GitHub] [hbase] bsglz commented on a change in pull request #2011: HBASE-24664 Some changing of split region by overall region size rath…

2020-07-07 Thread GitBox
bsglz commented on a change in pull request #2011: URL: https://github.com/apache/hbase/pull/2011#discussion_r450842948 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ConstantSizeRegionSplitPolicy.java ## @@ -68,22 +76,14 @@ protected void

[GitHub] [hbase] bsglz commented on a change in pull request #2011: HBASE-24664 Some changing of split region by overall region size rath…

2020-07-07 Thread GitBox
bsglz commented on a change in pull request #2011: URL: https://github.com/apache/hbase/pull/2011#discussion_r450842948 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ConstantSizeRegionSplitPolicy.java ## @@ -68,22 +76,14 @@ protected void

[GitHub] [hbase] nyl3532016 commented on a change in pull request #2017: HBASE-24669 Logging of ppid should be consistent across all occurrences

2020-07-07 Thread GitBox
nyl3532016 commented on a change in pull request #2017: URL: https://github.com/apache/hbase/pull/2017#discussion_r450832798 ## File path: hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/ProcedureExecutor.java ## @@ -1842,7 +1842,7 @@ private void

[GitHub] [hbase] Apache-HBase commented on pull request #2033: HBASE-24650 Change the return types of the new checkAndMutate methods…

2020-07-07 Thread GitBox
Apache-HBase commented on pull request #2033: URL: https://github.com/apache/hbase/pull/2033#issuecomment-654828162 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2032: HBASE-24404 Support flush a single column family of region

2020-07-07 Thread GitBox
Apache-HBase commented on pull request #2032: URL: https://github.com/apache/hbase/pull/2032#issuecomment-654821894 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] bsglz edited a comment on pull request #2032: HBASE-24404 Support flush a single column family of region

2020-07-07 Thread GitBox
bsglz edited a comment on pull request #2032: URL: https://github.com/apache/hbase/pull/2032#issuecomment-654811904 > Looks a great additional function. How about also allow for flushing a specific column family among all regions within a table? It could be another jira/PR if you feel

[jira] [Resolved] (HBASE-24691) Fix flaky TestWALEntryStream

2020-07-07 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang resolved HBASE-24691. Resolution: Duplicate Resolved as duplicate. > Fix flaky TestWALEntryStream >

[GitHub] [hbase] bsglz commented on pull request #2032: HBASE-24404 Support flush a single column family of region

2020-07-07 Thread GitBox
bsglz commented on pull request #2032: URL: https://github.com/apache/hbase/pull/2032#issuecomment-654811904 > Looks a great additional function. How about also allow for flushing a specific column family among all regions within a table? It could be another jira/PR if you feel better to

[jira] [Updated] (HBASE-24665) all wal of RegionGroupingProvider together roll

2020-07-07 Thread wenfeiyi666 (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wenfeiyi666 updated HBASE-24665: Description: when use multiwal, any a wal request roll, all wal will be together roll. (was:

[GitHub] [hbase] brfrn169 opened a new pull request #2033: HBASE-24650 Change the return types of the new checkAndMutate methods…

2020-07-07 Thread GitBox
brfrn169 opened a new pull request #2033: URL: https://github.com/apache/hbase/pull/2033 … introduced in HBASE-8458 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] Apache-HBase commented on pull request #1962: HBASE-24615 MutableRangeHistogram#updateSnapshotRangeMetrics doesn't calculate the distribution for last bucket.

2020-07-07 Thread GitBox
Apache-HBase commented on pull request #1962: URL: https://github.com/apache/hbase/pull/1962#issuecomment-654788359 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1962: HBASE-24615 MutableRangeHistogram#updateSnapshotRangeMetrics doesn't calculate the distribution for last bucket.

2020-07-07 Thread GitBox
Apache-HBase commented on pull request #1962: URL: https://github.com/apache/hbase/pull/1962#issuecomment-654784499 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1962: HBASE-24615 MutableRangeHistogram#updateSnapshotRangeMetrics doesn't calculate the distribution for last bucket.

2020-07-07 Thread GitBox
Apache-HBase commented on pull request #1962: URL: https://github.com/apache/hbase/pull/1962#issuecomment-654782822 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] WenFeiYi edited a comment on pull request #1962: HBASE-24615 MutableRangeHistogram#updateSnapshotRangeMetrics doesn't calculate the distribution for last bucket.

2020-07-07 Thread GitBox
WenFeiYi edited a comment on pull request #1962: URL: https://github.com/apache/hbase/pull/1962#issuecomment-654773013 @shahrs87 I push a test case, but can't success. I think FastLongHistogram exists bug, cause result of MutableRangeHistogram#updateSnapshotRangeMetrics is Incorrect.

[jira] [Commented] (HBASE-17945) Procedure V2: Add new Snapshot metrics to Snapshot procedure

2020-07-07 Thread Junhong Xu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-17945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152655#comment-17152655 ] Junhong Xu commented on HBASE-17945: Do you mind my taking over this issue? [~uagashe] > Procedure

[GitHub] [hbase] WenFeiYi commented on pull request #1962: HBASE-24615 MutableRangeHistogram#updateSnapshotRangeMetrics doesn't calculate the distribution for last bucket.

2020-07-07 Thread GitBox
WenFeiYi commented on pull request #1962: URL: https://github.com/apache/hbase/pull/1962#issuecomment-654773013 I commit a test case, but can't success. I think FastLongHistogram exists bug, cause result of MutableRangeHistogram#updateSnapshotRangeMetrics is Incorrect.

  1   2   >