[GitHub] [hbase] Apache-HBase commented on pull request #2430: HBASE-25074 Refactor ReplicationSinkManager: reduce code and make it …

2020-09-21 Thread GitBox
Apache-HBase commented on pull request #2430: URL: https://github.com/apache/hbase/pull/2430#issuecomment-696519731 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2436: HBASE-25080 Should not use AssignmentManager to test whether a table …

2020-09-21 Thread GitBox
Apache-HBase commented on pull request #2436: URL: https://github.com/apache/hbase/pull/2436#issuecomment-696518423 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2436: HBASE-25080 Should not use AssignmentManager to test whether a table …

2020-09-21 Thread GitBox
Apache-HBase commented on pull request #2436: URL: https://github.com/apache/hbase/pull/2436#issuecomment-696512867 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache9 merged pull request #2392: HBASE-25013 Avoid reset the backup master root cache every time when …

2020-09-21 Thread GitBox
Apache9 merged pull request #2392: URL: https://github.com/apache/hbase/pull/2392 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache9 commented on a change in pull request #2326: HBASE-24967 The table.jsp cost long time to load if the table include…

2020-09-21 Thread GitBox
Apache9 commented on a change in pull request #2326: URL: https://github.com/apache/hbase/pull/2326#discussion_r492013532 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java ## @@ -1741,9 +1741,10 @@ RegionLoad

[GitHub] [hbase] Apache-HBase commented on pull request #2436: HBASE-25080 Should not use AssignmentManager to test whether a table …

2020-09-21 Thread GitBox
Apache-HBase commented on pull request #2436: URL: https://github.com/apache/hbase/pull/2436#issuecomment-696483579 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] nyl3532016 opened a new pull request #2437: HBASE-25053 WAL replay should ignore 0-length files

2020-09-21 Thread GitBox
nyl3532016 opened a new pull request #2437: URL: https://github.com/apache/hbase/pull/2437 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hbase] HorizonNet merged pull request #2429: HBASE-25072 Remove the unnecessary System.out.println in MasterRegistry

2020-09-21 Thread GitBox
HorizonNet merged pull request #2429: URL: https://github.com/apache/hbase/pull/2429 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] Apache-HBase commented on pull request #2435: HBASE-25067 Edit of log messages around async WAL Replication; checks…

2020-09-21 Thread GitBox
Apache-HBase commented on pull request #2435: URL: https://github.com/apache/hbase/pull/2435#issuecomment-696335843 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] Apache-HBase commented on pull request #2397: HBASE-24999 Master manages ReplicationServers

2020-09-21 Thread GitBox
Apache-HBase commented on pull request #2397: URL: https://github.com/apache/hbase/pull/2397#issuecomment-695898785 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] Apache-HBase commented on pull request #2392: HBASE-25013 Avoid reset the backup master root cache every time when …

2020-09-21 Thread GitBox
Apache-HBase commented on pull request #2392: URL: https://github.com/apache/hbase/pull/2392#issuecomment-695775924 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] Apache-HBase commented on pull request #2312: HBASE-23935 : Backport HBASE-22978(with sub-tasks), HBASE-24718, HBASE-24528 to branch-1

2020-09-21 Thread GitBox
Apache-HBase commented on pull request #2312: URL: https://github.com/apache/hbase/pull/2312#issuecomment-695781306 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] Apache-HBase commented on pull request #2437: HBASE-25053 WAL replay should ignore 0-length files

2020-09-21 Thread GitBox
Apache-HBase commented on pull request #2437: URL: https://github.com/apache/hbase/pull/2437#issuecomment-696496119 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] saintstack commented on pull request #2421: HBASE-25067 Edit of log messages around async WAL Replication; checks…

2020-09-21 Thread GitBox
saintstack commented on pull request #2421: URL: https://github.com/apache/hbase/pull/2421#issuecomment-696234867 Was going to merge tomorrow unless objection; minor log edits. This is an automated message from the Apache

[GitHub] [hbase] HorizonNet merged pull request #2432: HBASE-25076 fix typo in MasterRegion java doc

2020-09-21 Thread GitBox
HorizonNet merged pull request #2432: URL: https://github.com/apache/hbase/pull/2432 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] saintstack closed pull request #2424: HBASE-25068 Pass WALFactory to Replication so it knows of all WALProv…

2020-09-21 Thread GitBox
saintstack closed pull request #2424: URL: https://github.com/apache/hbase/pull/2424 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] virajjasani commented on pull request #2426: HBASE-25070 : With new generic API getLogEntries, cleaning up unused RPC APIs

2020-09-21 Thread GitBox
virajjasani commented on pull request #2426: URL: https://github.com/apache/hbase/pull/2426#issuecomment-695942482 > Remove public API? When this API was added? Not exactly public API, it's RPC APIs. New RPC API was added as part of HBASE-24528 and is applicable to 2.4+ only.

[GitHub] [hbase] Apache9 commented on a change in pull request #2430: HBASE-25074 Refactor ReplicationSinkManager: reduce code and make it …

2020-09-21 Thread GitBox
Apache9 commented on a change in pull request #2430: URL: https://github.com/apache/hbase/pull/2430#discussion_r491910669 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/HBaseReplicationEndpoint.java ## @@ -63,7 +121,7 @@ protected synchronized

[GitHub] [hbase] Apache-HBase commented on pull request #2434: HBASE-25068 Pass WALFactory to Replication so it knows of all WALProv…

2020-09-21 Thread GitBox
Apache-HBase commented on pull request #2434: URL: https://github.com/apache/hbase/pull/2434#issuecomment-696304786 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] HorizonNet merged pull request #2431: HBASE-25075 Fix typo in ReplicationProtobufUtil

2020-09-21 Thread GitBox
HorizonNet merged pull request #2431: URL: https://github.com/apache/hbase/pull/2431 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] virajjasani commented on pull request #2299: HBASE-24620 : Add a ClusterManager which submits command to ZooKeeper and its Agent which picks and execute those Commands.

2020-09-21 Thread GitBox
virajjasani commented on pull request #2299: URL: https://github.com/apache/hbase/pull/2299#issuecomment-695803576 Let me re-build. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hbase] Apache-HBase commented on pull request #2432: HBASE-25076 fix typo in MasterRegion java doc

2020-09-21 Thread GitBox
Apache-HBase commented on pull request #2432: URL: https://github.com/apache/hbase/pull/2432#issuecomment-696064247 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] Apache-HBase commented on pull request #2353: HBASE-24981 Enable table replication fails from 1.x to 2.x if table a…

2020-09-21 Thread GitBox
Apache-HBase commented on pull request #2353: URL: https://github.com/apache/hbase/pull/2353#issuecomment-696388232 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] infraio commented on pull request #2430: HBASE-25074 Refactor ReplicationSinkManager: reduce code and make it …

2020-09-21 Thread GitBox
infraio commented on pull request #2430: URL: https://github.com/apache/hbase/pull/2430#issuecomment-696021721 > I think the logic is still there so we'd better keep the tests? Yes. Let me add them back. This is an

[GitHub] [hbase] infraio merged pull request #2418: HBASE-24976 Printing the swallowed exception

2020-09-21 Thread GitBox
infraio merged pull request #2418: URL: https://github.com/apache/hbase/pull/2418 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] saintstack commented on pull request #2413: Add a new ReplicationSource for hbase:meta WAL files. The new

2020-09-21 Thread GitBox
saintstack commented on pull request #2413: URL: https://github.com/apache/hbase/pull/2413#issuecomment-696233115 Let me try what you suggest. Will be back. This is an automated message from the Apache Git Service. To

[GitHub] [hbase] virajjasani edited a comment on pull request #2426: HBASE-25070 : With new generic API getLogEntries, cleaning up unused RPC APIs

2020-09-21 Thread GitBox
virajjasani edited a comment on pull request #2426: URL: https://github.com/apache/hbase/pull/2426#issuecomment-695942482 > Remove public API? When this API was added? Not exactly public API, it's our internal RPC API. New RPC API was added as part of HBASE-24528 and is applicable

[GitHub] [hbase] Apache-HBase commented on pull request #2431: HBASE-25075 Fix typo in ReplicationProtobufUtil

2020-09-21 Thread GitBox
Apache-HBase commented on pull request #2431: URL: https://github.com/apache/hbase/pull/2431#issuecomment-696042374 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] Apache-HBase commented on pull request #2299: HBASE-24620 : Add a ClusterManager which submits command to ZooKeeper and its Agent which picks and execute those Commands.

2020-09-21 Thread GitBox
Apache-HBase commented on pull request #2299: URL: https://github.com/apache/hbase/pull/2299#issuecomment-695803812 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] ddupg commented on a change in pull request #2397: HBASE-24999 Master manages ReplicationServers

2020-09-21 Thread GitBox
ddupg commented on a change in pull request #2397: URL: https://github.com/apache/hbase/pull/2397#discussion_r491778751 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/ReplicationServerManager.java ## @@ -0,0 +1,208 @@ +/* + * Licensed to the Apache

[GitHub] [hbase] bsglz commented on a change in pull request #2326: HBASE-24967 The table.jsp cost long time to load if the table include…

2020-09-21 Thread GitBox
bsglz commented on a change in pull request #2326: URL: https://github.com/apache/hbase/pull/2326#discussion_r492441835 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java ## @@ -1741,9 +1741,10 @@ RegionLoad createRegionLoad(final

[GitHub] [hbase] wchevreuil commented on a change in pull request #2430: HBASE-25074 Refactor ReplicationSinkManager: reduce code and make it …

2020-09-21 Thread GitBox
wchevreuil commented on a change in pull request #2430: URL: https://github.com/apache/hbase/pull/2430#discussion_r491893347 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/HBaseReplicationEndpoint.java ## @@ -63,7 +121,7 @@ protected synchronized

[GitHub] [hbase] saintstack commented on pull request #2424: HBASE-25068 Pass WALFactory to Replication so it knows of all WALProv…

2020-09-21 Thread GitBox
saintstack commented on pull request #2424: URL: https://github.com/apache/hbase/pull/2424#issuecomment-696284917 Closing in favor of #2434 which goes against master branch. This is an automated message from the Apache Git

[GitHub] [hbase] Apache-HBase commented on pull request #2430: HBASE-25074 Refactor ReplicationSinkManager: reduce code and make it …

2020-09-21 Thread GitBox
Apache-HBase commented on pull request #2430: URL: https://github.com/apache/hbase/pull/2430#issuecomment-695997746 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] ndimiduk commented on a change in pull request #2014: HBASE-24673 TransitionRegionStateProcedure of non-meta regions should…

2020-09-21 Thread GitBox
ndimiduk commented on a change in pull request #2014: URL: https://github.com/apache/hbase/pull/2014#discussion_r492290457 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/TransitRegionStateProcedure.java ## @@ -200,14 +200,21 @@ private void

[GitHub] [hbase] infraio commented on a change in pull request #2430: HBASE-25074 Refactor ReplicationSinkManager: reduce code and make it …

2020-09-21 Thread GitBox
infraio commented on a change in pull request #2430: URL: https://github.com/apache/hbase/pull/2430#discussion_r491929256 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/HBaseReplicationEndpoint.java ## @@ -63,7 +121,7 @@ protected synchronized

[GitHub] [hbase] infraio commented on a change in pull request #2397: HBASE-24999 Master manages ReplicationServers

2020-09-21 Thread GitBox
infraio commented on a change in pull request #2397: URL: https://github.com/apache/hbase/pull/2397#discussion_r491866551 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/ReplicationServerManager.java ## @@ -0,0 +1,208 @@ +/* + * Licensed to the Apache

[GitHub] [hbase] Apache9 commented on pull request #2430: HBASE-25074 Refactor ReplicationSinkManager: reduce code and make it …

2020-09-21 Thread GitBox
Apache9 commented on pull request #2430: URL: https://github.com/apache/hbase/pull/2430#issuecomment-695985606 I think the logic is still there so we'd better keep the tests? This is an automated message from the Apache Git

[GitHub] [hbase] Apache9 commented on pull request #2392: HBASE-25013 Avoid reset the backup master root cache every time when …

2020-09-21 Thread GitBox
Apache9 commented on pull request #2392: URL: https://github.com/apache/hbase/pull/2392#issuecomment-695784031 OK, the failed UTs are not related to this PR. They are flaky all the time on the branch. Will keep an eye on them and address them later.

[GitHub] [hbase] Apache-HBase commented on pull request #2433: HBASE-25077: hbck.jsp page loading fails, logs NPE in master log.

2020-09-21 Thread GitBox
Apache-HBase commented on pull request #2433: URL: https://github.com/apache/hbase/pull/2433#issuecomment-696198711 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] Apache-HBase commented on pull request #2429: HBASE-25072 Remove the unnecessary System.out.println in MasterRegistry

2020-09-21 Thread GitBox
Apache-HBase commented on pull request #2429: URL: https://github.com/apache/hbase/pull/2429#issuecomment-695785337 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] Apache-HBase commented on pull request #2014: HBASE-24673 TransitionRegionStateProcedure of non-meta regions should…

2020-09-21 Thread GitBox
Apache-HBase commented on pull request #2014: URL: https://github.com/apache/hbase/pull/2014#issuecomment-696315779 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (HBASE-24802) Please fix CVEs by removing reference to htrace-core4

2020-09-21 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199742#comment-17199742 ] Sean Busbey commented on HBASE-24802: - [~Esalnikov] I believe the analogous Hadoop jira is

[GitHub] [hbase] bsglz commented on a change in pull request #2326: HBASE-24967 The table.jsp cost long time to load if the table include…

2020-09-21 Thread GitBox
bsglz commented on a change in pull request #2326: URL: https://github.com/apache/hbase/pull/2326#discussion_r492449116 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionState.java ## @@ -164,10 +166,10 @@ private void

[GitHub] [hbase] Apache9 commented on a change in pull request #2326: HBASE-24967 The table.jsp cost long time to load if the table include…

2020-09-21 Thread GitBox
Apache9 commented on a change in pull request #2326: URL: https://github.com/apache/hbase/pull/2326#discussion_r492448370 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -3907,4 +3909,51 @@ public MetaRegionLocationCache

[GitHub] [hbase] bsglz commented on a change in pull request #2326: HBASE-24967 The table.jsp cost long time to load if the table include…

2020-09-21 Thread GitBox
bsglz commented on a change in pull request #2326: URL: https://github.com/apache/hbase/pull/2326#discussion_r492448187 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/RegionMetricsBuilder.java ## @@ -263,6 +268,10 @@ public RegionMetricsBuilder

[GitHub] [hbase] bsglz commented on a change in pull request #2326: HBASE-24967 The table.jsp cost long time to load if the table include…

2020-09-21 Thread GitBox
bsglz commented on a change in pull request #2326: URL: https://github.com/apache/hbase/pull/2326#discussion_r492447792 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -3907,4 +3909,51 @@ public MetaRegionLocationCache

[GitHub] [hbase] Apache-HBase commented on pull request #2430: HBASE-25074 Refactor ReplicationSinkManager: reduce code and make it …

2020-09-21 Thread GitBox
Apache-HBase commented on pull request #2430: URL: https://github.com/apache/hbase/pull/2430#issuecomment-696477637 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache9 opened a new pull request #2436: HBASE-25080 Should not use AssignmentManager to test whether a table …

2020-09-21 Thread GitBox
Apache9 opened a new pull request #2436: URL: https://github.com/apache/hbase/pull/2436 …is enabled or not This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hbase] bsglz commented on a change in pull request #2326: HBASE-24967 The table.jsp cost long time to load if the table include…

2020-09-21 Thread GitBox
bsglz commented on a change in pull request #2326: URL: https://github.com/apache/hbase/pull/2326#discussion_r492441835 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java ## @@ -1741,9 +1741,10 @@ RegionLoad createRegionLoad(final

[jira] [Created] (HBASE-25080) Should not use AssignmentManager to test whether a table is enabled or not

2020-09-21 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-25080: - Summary: Should not use AssignmentManager to test whether a table is enabled or not Key: HBASE-25080 URL: https://issues.apache.org/jira/browse/HBASE-25080 Project: HBase

[jira] [Work started] (HBASE-25080) Should not use AssignmentManager to test whether a table is enabled or not

2020-09-21 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25080 started by Duo Zhang. - > Should not use AssignmentManager to test whether a table is enabled or not >

[GitHub] [hbase] Apache-HBase commented on pull request #2434: HBASE-25068 Pass WALFactory to Replication so it knows of all WALProv…

2020-09-21 Thread GitBox
Apache-HBase commented on pull request #2434: URL: https://github.com/apache/hbase/pull/2434#issuecomment-696411343 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2435: HBASE-25067 Edit of log messages around async WAL Replication; checks…

2020-09-21 Thread GitBox
Apache-HBase commented on pull request #2435: URL: https://github.com/apache/hbase/pull/2435#issuecomment-696409394 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2435: HBASE-25067 Edit of log messages around async WAL Replication; checks…

2020-09-21 Thread GitBox
Apache-HBase commented on pull request #2435: URL: https://github.com/apache/hbase/pull/2435#issuecomment-696402037 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2353: HBASE-24981 Enable table replication fails from 1.x to 2.x if table a…

2020-09-21 Thread GitBox
Apache-HBase commented on pull request #2353: URL: https://github.com/apache/hbase/pull/2353#issuecomment-696393105 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Created] (HBASE-25079) Upgrade Bootstrap to 3.3.7

2020-09-21 Thread Andrew Kyle Purtell (Jira)
Andrew Kyle Purtell created HBASE-25079: --- Summary: Upgrade Bootstrap to 3.3.7 Key: HBASE-25079 URL: https://issues.apache.org/jira/browse/HBASE-25079 Project: HBase Issue Type:

[GitHub] [hbase] Apache-HBase commented on pull request #2353: HBASE-24981 Enable table replication fails from 1.x to 2.x if table a…

2020-09-21 Thread GitBox
Apache-HBase commented on pull request #2353: URL: https://github.com/apache/hbase/pull/2353#issuecomment-696389670 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2353: HBASE-24981 Enable table replication fails from 1.x to 2.x if table a…

2020-09-21 Thread GitBox
Apache-HBase commented on pull request #2353: URL: https://github.com/apache/hbase/pull/2353#issuecomment-696388232 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2434: HBASE-25068 Pass WALFactory to Replication so it knows of all WALProv…

2020-09-21 Thread GitBox
Apache-HBase commented on pull request #2434: URL: https://github.com/apache/hbase/pull/2434#issuecomment-696375809 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24976) REST Server failes to start without any error message

2020-09-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199659#comment-17199659 ] Hudson commented on HBASE-24976: Results for branch branch-2.2 [build #67 on

[GitHub] [hbase] Apache-HBase commented on pull request #2435: HBASE-25067 Edit of log messages around async WAL Replication; checks…

2020-09-21 Thread GitBox
Apache-HBase commented on pull request #2435: URL: https://github.com/apache/hbase/pull/2435#issuecomment-696335843 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2433: HBASE-25077: hbck.jsp page loading fails, logs NPE in master log.

2020-09-21 Thread GitBox
Apache-HBase commented on pull request #2433: URL: https://github.com/apache/hbase/pull/2433#issuecomment-696335303 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2014: HBASE-24673 TransitionRegionStateProcedure of non-meta regions should…

2020-09-21 Thread GitBox
Apache-HBase commented on pull request #2014: URL: https://github.com/apache/hbase/pull/2014#issuecomment-696318668 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m

[GitHub] [hbase] Apache-HBase commented on pull request #2014: HBASE-24673 TransitionRegionStateProcedure of non-meta regions should…

2020-09-21 Thread GitBox
Apache-HBase commented on pull request #2014: URL: https://github.com/apache/hbase/pull/2014#issuecomment-696318477 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] ndimiduk commented on a change in pull request #2014: HBASE-24673 TransitionRegionStateProcedure of non-meta regions should…

2020-09-21 Thread GitBox
ndimiduk commented on a change in pull request #2014: URL: https://github.com/apache/hbase/pull/2014#discussion_r492290457 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/TransitRegionStateProcedure.java ## @@ -200,14 +200,21 @@ private void

[GitHub] [hbase] Apache-HBase commented on pull request #2014: HBASE-24673 TransitionRegionStateProcedure of non-meta regions should…

2020-09-21 Thread GitBox
Apache-HBase commented on pull request #2014: URL: https://github.com/apache/hbase/pull/2014#issuecomment-696315779 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25067) Edit of log messages around async WAL Replication; checkstyle fixes; and a bugfix

2020-09-21 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199610#comment-17199610 ] Michael Stack commented on HBASE-25067: --- Added patch for Master branch too PR2435. Its a bit

[GitHub] [hbase] saintstack opened a new pull request #2435: HBASE-25067 Edit of log messages around async WAL Replication; checks…

2020-09-21 Thread GitBox
saintstack opened a new pull request #2435: URL: https://github.com/apache/hbase/pull/2435 …tyle fixes; and a bugfix Editing logging around region replicas: shortening and adding context. Checkstyle fixes in edited files while I was in there.

[GitHub] [hbase] Apache-HBase commented on pull request #2434: HBASE-25068 Pass WALFactory to Replication so it knows of all WALProv…

2020-09-21 Thread GitBox
Apache-HBase commented on pull request #2434: URL: https://github.com/apache/hbase/pull/2434#issuecomment-696304786 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-25078) QuotaRefresherChore doesn't update QuotaCache for user effectively

2020-09-21 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pankaj Kumar updated HBASE-25078: - Summary: QuotaRefresherChore doesn't update QuotaCache for user effectively (was:

[jira] [Assigned] (HBASE-25078) QuotaRefresherChore doesn't update the User RPC Throttle quota effectively

2020-09-21 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pankaj Kumar reassigned HBASE-25078: Assignee: Pankaj Kumar > QuotaRefresherChore doesn't update the User RPC Throttle quota

[jira] [Created] (HBASE-25078) QuotaRefresherChore doesn't update the User RPC Throttle quota effectively

2020-09-21 Thread Pankaj Kumar (Jira)
Pankaj Kumar created HBASE-25078: Summary: QuotaRefresherChore doesn't update the User RPC Throttle quota effectively Key: HBASE-25078 URL: https://issues.apache.org/jira/browse/HBASE-25078 Project:

[GitHub] [hbase] saintstack commented on pull request #2424: HBASE-25068 Pass WALFactory to Replication so it knows of all WALProv…

2020-09-21 Thread GitBox
saintstack commented on pull request #2424: URL: https://github.com/apache/hbase/pull/2424#issuecomment-696284917 Closing in favor of #2434 which goes against master branch. This is an automated message from the Apache Git

[GitHub] [hbase] saintstack closed pull request #2424: HBASE-25068 Pass WALFactory to Replication so it knows of all WALProv…

2020-09-21 Thread GitBox
saintstack closed pull request #2424: URL: https://github.com/apache/hbase/pull/2424 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] saintstack opened a new pull request #2434: HBASE-25068 Pass WALFactory to Replication so it knows of all WALProv…

2020-09-21 Thread GitBox
saintstack opened a new pull request #2434: URL: https://github.com/apache/hbase/pull/2434 …iders, not just default/user-space Pass WALFactory to Replication instead of WALProvider. WALFactory has all WALProviders in it, not just the user-space WALProvider. Do this so

[GitHub] [hbase] Apache-HBase commented on pull request #2433: HBASE-25077: hbck.jsp page loading fails, logs NPE in master log.

2020-09-21 Thread GitBox
Apache-HBase commented on pull request #2433: URL: https://github.com/apache/hbase/pull/2433#issuecomment-696279231 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Resolved] (HBASE-25076) fix typo in MasterRegion java doc

2020-09-21 Thread Jan Hentschel (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel resolved HBASE-25076. --- Fix Version/s: 3.0.0-alpha-1 Hadoop Flags: Reviewed Resolution: Fixed Pushed to

[GitHub] [hbase] HorizonNet merged pull request #2432: HBASE-25076 fix typo in MasterRegion java doc

2020-09-21 Thread GitBox
HorizonNet merged pull request #2432: URL: https://github.com/apache/hbase/pull/2432 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Resolved] (HBASE-25075) Fix typo in ReplicationProtobufUtil

2020-09-21 Thread Jan Hentschel (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel resolved HBASE-25075. --- Fix Version/s: 3.0.0-alpha-1 Hadoop Flags: Reviewed Resolution: Fixed Pushed to

[GitHub] [hbase] HorizonNet merged pull request #2431: HBASE-25075 Fix typo in ReplicationProtobufUtil

2020-09-21 Thread GitBox
HorizonNet merged pull request #2431: URL: https://github.com/apache/hbase/pull/2431 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] saintstack commented on pull request #2421: HBASE-25067 Edit of log messages around async WAL Replication; checks…

2020-09-21 Thread GitBox
saintstack commented on pull request #2421: URL: https://github.com/apache/hbase/pull/2421#issuecomment-696234867 Was going to merge tomorrow unless objection; minor log edits. This is an automated message from the Apache

[GitHub] [hbase] saintstack commented on pull request #2413: Add a new ReplicationSource for hbase:meta WAL files. The new

2020-09-21 Thread GitBox
saintstack commented on pull request #2413: URL: https://github.com/apache/hbase/pull/2413#issuecomment-696233115 Let me try what you suggest. Will be back. This is an automated message from the Apache Git Service. To

[GitHub] [hbase] Apache-HBase commented on pull request #2430: HBASE-25074 Refactor ReplicationSinkManager: reduce code and make it …

2020-09-21 Thread GitBox
Apache-HBase commented on pull request #2430: URL: https://github.com/apache/hbase/pull/2430#issuecomment-696220118 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-24976) REST Server failes to start without any error message

2020-09-21 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-24976: - Fix Version/s: 2.2.7 2.4.0 2.3.3

[GitHub] [hbase] Apache-HBase commented on pull request #2432: HBASE-25076 fix typo in MasterRegion java doc

2020-09-21 Thread GitBox
Apache-HBase commented on pull request #2432: URL: https://github.com/apache/hbase/pull/2432#issuecomment-696201684 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 12m

[GitHub] [hbase] Apache-HBase commented on pull request #2433: HBASE-25077: hbck.jsp page loading fails, logs NPE in master log.

2020-09-21 Thread GitBox
Apache-HBase commented on pull request #2433: URL: https://github.com/apache/hbase/pull/2433#issuecomment-696198711 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] arshadmohammad opened a new pull request #2433: HBASE-25077: hbck.jsp page loading fails, logs NPE in master log.

2020-09-21 Thread GitBox
arshadmohammad opened a new pull request #2433: URL: https://github.com/apache/hbase/pull/2433 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Updated] (HBASE-25077) hbck.jsp page loading fails, logs NPE in master log.

2020-09-21 Thread Mohammad Arshad (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohammad Arshad updated HBASE-25077: Summary: hbck.jsp page loading fails, logs NPE in master log. (was: [HBCK2]hbck.jsp page

[jira] [Updated] (HBASE-25077) [HBCK2]hbck.jsp page loading fails, logs NPE in master log.

2020-09-21 Thread Mohammad Arshad (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohammad Arshad updated HBASE-25077: Component/s: hbck > [HBCK2]hbck.jsp page loading fails, logs NPE in master log. >

[jira] [Commented] (HBASE-25077) [HBCK2]hbck.jsp page loading fails, logs NPE in master log.

2020-09-21 Thread Mohammad Arshad (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199419#comment-17199419 ] Mohammad Arshad commented on HBASE-25077: - Seems problem is originating from

[jira] [Updated] (HBASE-25077) [HBCK2]hbck.jsp page loading fails, logs NPE in master log.

2020-09-21 Thread Ajeet Rai (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajeet Rai updated HBASE-25077: -- Description: While testing with large data, it is observed that some time hbck page was not

[jira] [Assigned] (HBASE-25077) [HBCK2]hbck.jsp page loading fails, logs NPE in master log.

2020-09-21 Thread Mohammad Arshad (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohammad Arshad reassigned HBASE-25077: --- Assignee: Mohammad Arshad > [HBCK2]hbck.jsp page loading fails, logs NPE in master

[jira] [Updated] (HBASE-25077) [HBCK2]hbck.jsp page loading fails, logs NPE in master log.

2020-09-21 Thread Ajeet Rai (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajeet Rai updated HBASE-25077: -- Description: While testing with large data, it is observed that some time hbck page was not

[jira] [Created] (HBASE-25077) [HBCK2]hbck.jsp page loading fails, logs NPE in master log.

2020-09-21 Thread Ajeet Rai (Jira)
Ajeet Rai created HBASE-25077: - Summary: [HBCK2]hbck.jsp page loading fails, logs NPE in master log. Key: HBASE-25077 URL: https://issues.apache.org/jira/browse/HBASE-25077 Project: HBase Issue

[GitHub] [hbase] Apache-HBase commented on pull request #2432: HBASE-25076 fix typo in MasterRegion java doc

2020-09-21 Thread GitBox
Apache-HBase commented on pull request #2432: URL: https://github.com/apache/hbase/pull/2432#issuecomment-696144026 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2431: HBASE-25075 Fix typo in ReplicationProtobufUtil

2020-09-21 Thread GitBox
Apache-HBase commented on pull request #2431: URL: https://github.com/apache/hbase/pull/2431#issuecomment-696141832 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] Apache-HBase commented on pull request #2431: HBASE-25075 Fix typo in ReplicationProtobufUtil

2020-09-21 Thread GitBox
Apache-HBase commented on pull request #2431: URL: https://github.com/apache/hbase/pull/2431#issuecomment-696114791 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24620) Add a ClusterManager which submits command to ZooKeeper and its Agent which picks and execute those Commands.

2020-09-21 Thread Lokesh Khurana (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199385#comment-17199385 ] Lokesh Khurana commented on HBASE-24620: [~zhangduo] for RPC we would have to make Agents as

[jira] [Commented] (HBASE-24976) REST Server failes to start without any error message

2020-09-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199370#comment-17199370 ] Hudson commented on HBASE-24976: Results for branch master [build #58 on

  1   2   >