[GitHub] [hbase] Apache-HBase commented on pull request #2892: HBASE-25484 Add trace support for WAL sync

Apache-HBase commented on pull request #2892: URL: https://github.com/apache/hbase/pull/2892#issuecomment-762036397 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2882: HBASE-25507 Leak of ESTABLISHED sockets when compaction encountered "…

Apache-HBase commented on pull request #2882: URL: https://github.com/apache/hbase/pull/2882#issuecomment-762033529 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2882: HBASE-25507 Leak of ESTABLISHED sockets when compaction encountered "…

Apache-HBase commented on pull request #2882: URL: https://github.com/apache/hbase/pull/2882#issuecomment-762029615 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] Apache-HBase commented on pull request #2890: HBASE-25509 ChoreService.cancelChore will not call ScheduledChore.cle…

Apache-HBase commented on pull request #2890: URL: https://github.com/apache/hbase/pull/2890#issuecomment-761984063 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2890: HBASE-25509 ChoreService.cancelChore will not call ScheduledChore.cle…

Apache-HBase commented on pull request #2890: URL: https://github.com/apache/hbase/pull/2890#issuecomment-761981101 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2882: HBASE-25507 Leak of ESTABLISHED sockets when compaction encountered "…

Apache-HBase commented on pull request #2882: URL: https://github.com/apache/hbase/pull/2882#issuecomment-761978242 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] ramkrish86 commented on a change in pull request #2882: HBASE-25507 Leak of ESTABLISHED sockets when compaction encountered "…

ramkrish86 commented on a change in pull request #2882: URL: https://github.com/apache/hbase/pull/2882#discussion_r559308038 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java ## @@ -345,7 +345,18 @@ private

[GitHub] [hbase] sunhelly commented on pull request #2882: HBASE-25507 Leak of ESTABLISHED sockets when compaction encountered "…

sunhelly commented on pull request #2882: URL: https://github.com/apache/hbase/pull/2882#issuecomment-761966447 getScannersForCompaction close scanners when it encounters exception, so let createFileScanners outside the try/finally.

[GitHub] [hbase] Apache-HBase commented on pull request #2892: HBASE-25484 Add trace support for WAL sync

Apache-HBase commented on pull request #2892: URL: https://github.com/apache/hbase/pull/2892#issuecomment-761959454 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2892: HBASE-25484 Add trace support for WAL sync

Apache-HBase commented on pull request #2892: URL: https://github.com/apache/hbase/pull/2892#issuecomment-761959220 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2892: HBASE-25484 Add trace support for WAL sync

Apache-HBase commented on pull request #2892: URL: https://github.com/apache/hbase/pull/2892#issuecomment-761958775 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-25453) Add trace support for scan operation

[ https://issues.apache.org/jira/browse/HBASE-25453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25453: -- Component/s: tracing scan > Add trace support for scan operation >

[jira] [Commented] (HBASE-25453) Add trace support for scan operation

[ https://issues.apache.org/jira/browse/HBASE-25453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266991#comment-17266991 ] Duo Zhang commented on HBASE-25453: --- For now, I do not have a clear idea in mind on how to deal with

[jira] [Resolved] (HBASE-23898) Add trace support for simple apis in async client

[ https://issues.apache.org/jira/browse/HBASE-23898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-23898. --- Fix Version/s: HBASE-22120 Hadoop Flags: Reviewed Resolution: Fixed > Add trace support

[jira] [Work started] (HBASE-25484) Add trace support for WAL sync

[ https://issues.apache.org/jira/browse/HBASE-25484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25484 started by Duo Zhang. - > Add trace support for WAL sync > -- > >

[jira] [Assigned] (HBASE-25484) Add trace support for WAL sync

[ https://issues.apache.org/jira/browse/HBASE-25484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-25484: - Assignee: Duo Zhang > Add trace support for WAL sync > -- > >

[GitHub] [hbase] Apache9 opened a new pull request #2892: HBASE-25484 Add trace support for WAL sync

Apache9 opened a new pull request #2892: URL: https://github.com/apache/hbase/pull/2892 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (HBASE-25512) May throw StringIndexOutOfBoundsException when construct illegal tablename error

[ https://issues.apache.org/jira/browse/HBASE-25512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhuobin zheng updated HBASE-25512: -- Fix Version/s: 2.5.0 1.7.0 3.0.0-alpha-1 > May throw

[GitHub] [hbase] Apache-HBase commented on pull request #2890: HBASE-25509 ChoreService.cancelChore will not call ScheduledChore.cle…

Apache-HBase commented on pull request #2890: URL: https://github.com/apache/hbase/pull/2890#issuecomment-761949719 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Assigned] (HBASE-25512) May throw StringIndexOutOfBoundsException when construct illegal tablename error

[ https://issues.apache.org/jira/browse/HBASE-25512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhuobin zheng reassigned HBASE-25512: - Assignee: zhuobin zheng > May throw StringIndexOutOfBoundsException when construct

[jira] [Updated] (HBASE-25484) Add trace support for WAL sync

[ https://issues.apache.org/jira/browse/HBASE-25484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25484: -- Component/s: wal tracing > Add trace support for WAL sync >

[jira] [Commented] (HBASE-25510) Optimize TableName.valueOf from O(n) to O(1). We can get benefits when the number of tables in the cluster is greater than dozens

[ https://issues.apache.org/jira/browse/HBASE-25510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266971#comment-17266971 ] zhuobin zheng commented on HBASE-25510: --- Thanks for your watching [~vjasani] . 1.  I used JMH to

[jira] [Updated] (HBASE-25510) Optimize TableName.valueOf from O(n) to O(1). We can get benefits when the number of tables in the cluster is greater than dozens

[ https://issues.apache.org/jira/browse/HBASE-25510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhuobin zheng updated HBASE-25510: -- Attachment: (was: TestTableNameJMH.java) > Optimize TableName.valueOf from O(n) to O(1).

[jira] [Updated] (HBASE-25510) Optimize TableName.valueOf from O(n) to O(1). We can get benefits when the number of tables in the cluster is greater than dozens

[ https://issues.apache.org/jira/browse/HBASE-25510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhuobin zheng updated HBASE-25510: -- Attachment: TestTableNameJMH.java > Optimize TableName.valueOf from O(n) to O(1). We can get

[jira] [Updated] (HBASE-25510) Optimize TableName.valueOf from O(n) to O(1). We can get benefits when the number of tables in the cluster is greater than dozens

[ https://issues.apache.org/jira/browse/HBASE-25510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhuobin zheng updated HBASE-25510: -- Attachment: optimiz_benchmark_fix > Optimize TableName.valueOf from O(n) to O(1). We can get

[jira] [Resolved] (HBASE-25455) Add trace support for HRegion read/write operation

[ https://issues.apache.org/jira/browse/HBASE-25455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-25455. --- Fix Version/s: HBASE-22120 Hadoop Flags: Reviewed Resolution: Fixed Merged to branch

[GitHub] [hbase] Apache9 merged pull request #2861: HBASE-25455 Add trace support for HRegion read/write operation

Apache9 merged pull request #2861: URL: https://github.com/apache/hbase/pull/2861 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (HBASE-25475) Improve unit test for HBASE-25445 : SplitWALRemoteProcedure failed to archive split WAL

[ https://issues.apache.org/jira/browse/HBASE-25475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266961#comment-17266961 ] Hudson commented on HBASE-25475: Results for branch branch-2.4 [build #36 on

[jira] [Updated] (HBASE-25510) Optimize TableName.valueOf from O(n) to O(1). We can get benefits when the number of tables in the cluster is greater than dozens

[ https://issues.apache.org/jira/browse/HBASE-25510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhuobin zheng updated HBASE-25510: -- Attachment: TestTableNameJMH.java > Optimize TableName.valueOf from O(n) to O(1). We can get

[GitHub] [hbase] ZhaoBQ commented on pull request #2887: HBASE-25513 When the table is turned on normalize, the first region may not be merged even the size is 0

ZhaoBQ commented on pull request #2887: URL: https://github.com/apache/hbase/pull/2887#issuecomment-761912388 Thanks for review @virajjasani This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (HBASE-25475) Improve unit test for HBASE-25445 : SplitWALRemoteProcedure failed to archive split WAL

[ https://issues.apache.org/jira/browse/HBASE-25475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266942#comment-17266942 ] Hudson commented on HBASE-25475: Results for branch branch-2.2 [build #157 on

[GitHub] [hbase] virajjasani commented on pull request #2887: HBASE-25513 When the table is turned on normalize, the first region may not be merged even the size is 0

virajjasani commented on pull request #2887: URL: https://github.com/apache/hbase/pull/2887#issuecomment-761845843 The changes sound reasonable. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] virajjasani commented on a change in pull request #2887: HBASE-25513 When the table is turned on normalize, the first region may not be merged even the size is 0

virajjasani commented on a change in pull request #2887: URL: https://github.com/apache/hbase/pull/2887#discussion_r559210103 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/normalizer/TestSimpleRegionNormalizer.java ## @@ -448,6 +448,38 @@ public void

[jira] [Updated] (HBASE-25517) Reduce race conditions between balanceRSGroup and balance() cluster, and support concurrently balance RSGroups

[ https://issues.apache.org/jira/browse/HBASE-25517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaolin Ha updated HBASE-25517: --- Description: When we call balanceRSGroup(), it waits for the lock of balancer, which may be

[jira] [Created] (HBASE-25518) Support dividing child regions to different region servers

Xiaolin Ha created HBASE-25518: -- Summary: Support dividing child regions to different region servers Key: HBASE-25518 URL: https://issues.apache.org/jira/browse/HBASE-25518 Project: HBase Issue

[jira] [Created] (HBASE-25517) Reduce race conditions between balanceRSGroup and balance() cluster, and support concurrently balance RSGroups

Xiaolin Ha created HBASE-25517: -- Summary: Reduce race conditions between balanceRSGroup and balance() cluster, and support concurrently balance RSGroups Key: HBASE-25517 URL:

[GitHub] [hbase] joshelser commented on a change in pull request #2237: HBASE-24833: Bootstrap should not delete the META table directory if …

joshelser commented on a change in pull request #2237: URL: https://github.com/apache/hbase/pull/2237#discussion_r559183840 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/InitMetaProcedure.java ## @@ -166,4 +170,35 @@ protected void

[jira] [Updated] (HBASE-25507) Leak of ESTABLISHED sockets when compaction encountered "java.io.IOException: Invalid HFile block magic"

[ https://issues.apache.org/jira/browse/HBASE-25507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaolin Ha updated HBASE-25507: --- Description: Recently, we found socket leaks on our production cluster. The leaked sockets are in 

[jira] [Updated] (HBASE-25507) Leak of ESTABLISHED sockets when compaction encountered "java.io.IOException: Invalid HFile block magic"

[ https://issues.apache.org/jira/browse/HBASE-25507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaolin Ha updated HBASE-25507: --- Description: Recently, we found socket leaks on our production cluster. The leaked sockets are in 

[jira] [Commented] (HBASE-25478) Implement retries when enabling tables in TestRegionReplicaReplicationEndpoint

[ https://issues.apache.org/jira/browse/HBASE-25478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266775#comment-17266775 ] Hudson commented on HBASE-25478: Results for branch master [build #188 on

[GitHub] [hbase] Apache9 commented on a change in pull request #2868: HBASE-25368 Filter out more invalid encoded name in isEncodedRegionNa…

Apache9 commented on a change in pull request #2868: URL: https://github.com/apache/hbase/pull/2868#discussion_r559170729 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin1.java ## @@ -99,6 +99,25 @@ public void

[jira] [Resolved] (HBASE-25475) Improve unit test for HBASE-25445 : SplitWALRemoteProcedure failed to archive split WAL

[ https://issues.apache.org/jira/browse/HBASE-25475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-25475. -- Resolution: Fixed > Improve unit test for HBASE-25445 : SplitWALRemoteProcedure failed to

[jira] [Commented] (HBASE-25475) Improve unit test for HBASE-25445 : SplitWALRemoteProcedure failed to archive split WAL

[ https://issues.apache.org/jira/browse/HBASE-25475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266749#comment-17266749 ] Viraj Jasani commented on HBASE-25475: -- This does not affect 2.4.1 RC as 2.4 test is stable without

[jira] [Reopened] (HBASE-25475) Improve unit test for HBASE-25445 : SplitWALRemoteProcedure failed to archive split WAL

[ https://issues.apache.org/jira/browse/HBASE-25475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reopened HBASE-25475: -- Reopening for Addendum > Improve unit test for HBASE-25445 : SplitWALRemoteProcedure failed to

[GitHub] [hbase] virajjasani merged pull request #2891: HBASE-25475: Unset zk based wal splitting explicitly in tests

virajjasani merged pull request #2891: URL: https://github.com/apache/hbase/pull/2891 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] virajjasani commented on pull request #2891: HBASE-25475: Unset zk based wal splitting explicitly in tests

virajjasani commented on pull request #2891: URL: https://github.com/apache/hbase/pull/2891#issuecomment-761771447 Oh I see. Makes sense. This is an automated message from the Apache Git Service. To respond to the message,