[GitHub] [hbase] Apache-HBase commented on pull request #3279: HBASE-25888 Backup tests are categorically flakey

2021-05-21 Thread GitBox
Apache-HBase commented on pull request #3279: URL: https://github.com/apache/hbase/pull/3279#issuecomment-846349115 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3279: HBASE-25888 Backup tests are categorically flakey

2021-05-21 Thread GitBox
Apache-HBase commented on pull request #3279: URL: https://github.com/apache/hbase/pull/3279#issuecomment-846348993 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3279: HBASE-25888 Backup tests are categorically flakey

2021-05-21 Thread GitBox
Apache-HBase commented on pull request #3279: URL: https://github.com/apache/hbase/pull/3279#issuecomment-846348666 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] rda3mon commented on a change in pull request #3279: HBASE-25888 Backup tests are categorically flakey

2021-05-21 Thread GitBox
rda3mon commented on a change in pull request #3279: URL: https://github.com/apache/hbase/pull/3279#discussion_r637350077 ## File path: hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/mapreduce/MapReduceBackupMergeJob.java ## @@ -240,13 +240,13 @@ protected void

[jira] [Commented] (HBASE-25848) Add flexibility to backup replication in case replication filter throws an exception

2021-05-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17349596#comment-17349596 ] Hudson commented on HBASE-25848: Results for branch master [build #299 on

[jira] [Updated] (HBASE-25892) 'False' should be 'True' in auditlog of listLabels

2021-05-21 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25892: -- Component/s: security logging > 'False' should be 'True' in auditlog of listLabels >

[GitHub] [hbase] Apache9 merged pull request #3273: HBASE-25892: 'False' should be 'True' in auditlog of listLabels

2021-05-21 Thread GitBox
Apache9 merged pull request #3273: URL: https://github.com/apache/hbase/pull/3273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Assigned] (HBASE-25892) 'False' should be 'True' in auditlog of listLabels

2021-05-21 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-25892: - Assignee: xiqing > 'False' should be 'True' in auditlog of listLabels >

[jira] [Updated] (HBASE-25817) Memory leak from thrift server hashMap

2021-05-21 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25817: -- Hadoop Flags: Reviewed Resolution: Fixed Status: Resolved (was: Patch Available)

[jira] [Assigned] (HBASE-25817) Memory leak from thrift server hashMap

2021-05-21 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-25817: - Assignee: yeonsuk Choi > Memory leak from thrift server hashMap >

[jira] [Updated] (HBASE-25817) Memory leak from thrift server hashMap

2021-05-21 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25817: -- Fix Version/s: 2.4.4 2.3.6 2.5.0 > Memory leak from thrift

[GitHub] [hbase] Apache9 commented on a change in pull request #3279: HBASE-25888 Backup tests are categorically flakey

2021-05-21 Thread GitBox
Apache9 commented on a change in pull request #3279: URL: https://github.com/apache/hbase/pull/3279#discussion_r637343817 ## File path: hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/mapreduce/MapReduceBackupMergeJob.java ## @@ -240,13 +240,13 @@ protected void

[GitHub] [hbase] Apache-HBase commented on pull request #3279: HBASE-25888 Backup tests are categorically flakey

2021-05-21 Thread GitBox
Apache-HBase commented on pull request #3279: URL: https://github.com/apache/hbase/pull/3279#issuecomment-846338760 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3279: HBASE-25888 Backup tests are categorically flakey

2021-05-21 Thread GitBox
Apache-HBase commented on pull request #3279: URL: https://github.com/apache/hbase/pull/3279#issuecomment-846338582 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3279: HBASE-25888 Backup tests are categorically flakey

2021-05-21 Thread GitBox
Apache-HBase commented on pull request #3279: URL: https://github.com/apache/hbase/pull/3279#issuecomment-846338159 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] youhailang removed a comment on pull request #3286: HBASE-25901 Replication maybe lose data when the regionserver is restarted.

2021-05-21 Thread GitBox
youhailang removed a comment on pull request #3286: URL: https://github.com/apache/hbase/pull/3286#issuecomment-846334241 > To align with master, we'd better just use put instead of computeIfAbsent. > > Notice that, in our current implementation, it is impossible for us to find out

[GitHub] [hbase] youhailang commented on pull request #3286: HBASE-25901 Replication maybe lose data when the regionserver is restarted.

2021-05-21 Thread GitBox
youhailang commented on pull request #3286: URL: https://github.com/apache/hbase/pull/3286#issuecomment-846334241 > To align with master, we'd better just use put instead of computeIfAbsent. > > Notice that, in our current implementation, it is impossible for us to find out the

[GitHub] [hbase] rda3mon commented on a change in pull request #3279: HBASE-25888 Backup tests are categorically flakey

2021-05-21 Thread GitBox
rda3mon commented on a change in pull request #3279: URL: https://github.com/apache/hbase/pull/3279#discussion_r637339567 ## File path: hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/mapreduce/MapReduceBackupMergeJob.java ## @@ -240,7 +240,7 @@ protected void

[GitHub] [hbase] youhailang edited a comment on pull request #3286: HBASE-25901 Replication maybe lose data when the regionserver is restarted.

2021-05-21 Thread GitBox
youhailang edited a comment on pull request #3286: URL: https://github.com/apache/hbase/pull/3286#issuecomment-846332088 When `hbase.wal.provider` is set to multiwal and `hbase.wal.regiongrouping.numgroups` default to 2, two different logPrefixs will be put to the queues at the same

[GitHub] [hbase] youhailang commented on pull request #3286: HBASE-25901 Replication maybe lose data when the regionserver is restarted.

2021-05-21 Thread GitBox
youhailang commented on pull request #3286: URL: https://github.com/apache/hbase/pull/3286#issuecomment-846332088 When `hbase.wal.provider` is set to multiwal and `hbase.wal.regiongrouping.numgroups` default to 2, at least two different logPrefixs will be put to the queues at the same

[GitHub] [hbase] Apache9 merged pull request #3257: HBASE-25817 Use GuavaCache in thrift server hashmap

2021-05-21 Thread GitBox
Apache9 merged pull request #3257: URL: https://github.com/apache/hbase/pull/3257 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Resolved] (HBASE-12341) Overhaul logging; log4j2, machine-readable, etc.

2021-05-21 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-12341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-12341. --- Resolution: Fixed All sub tasks have been resolved, so resolve. As different sub tasks has

[jira] [Updated] (HBASE-12341) Overhaul logging; log4j2, machine-readable, etc.

2021-05-21 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-12341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-12341: -- Component/s: logging > Overhaul logging; log4j2, machine-readable, etc. >

[jira] [Resolved] (HBASE-19587) [sfl4j] " Class path contains multiple SLF4J binding" complaint

2021-05-21 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-19587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-19587. --- Resolution: Not A Problem Resolve as 'Not A Problem'. We have exclude all the slf4j-log4j12

[jira] [Resolved] (HBASE-25848) Add flexibility to backup replication in case replication filter throws an exception

2021-05-21 Thread Sandeep Pal (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandeep Pal resolved HBASE-25848. - Resolution: Fixed > Add flexibility to backup replication in case replication filter throws an

[jira] [Updated] (HBASE-25848) Add flexibility to backup replication in case replication filter throws an exception

2021-05-21 Thread Sandeep Pal (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandeep Pal updated HBASE-25848: Fix Version/s: 1.8.0 1.7.0 > Add flexibility to backup replication in case

[GitHub] [hbase] xcangCRM merged pull request #3291: [Backport]HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-21 Thread GitBox
xcangCRM merged pull request #3291: URL: https://github.com/apache/hbase/pull/3291 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [hbase] Apache-HBase commented on pull request #3264: HBASE-25887 Wait for appendExecutor to shutdown running tasks

2021-05-21 Thread GitBox
Apache-HBase commented on pull request #3264: URL: https://github.com/apache/hbase/pull/3264#issuecomment-846316816 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3291: [Backport]HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-21 Thread GitBox
Apache-HBase commented on pull request #3291: URL: https://github.com/apache/hbase/pull/3291#issuecomment-846314416 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 24m

[GitHub] [hbase] Apache-HBase commented on pull request #3264: HBASE-25887 Wait for appendExecutor to shutdown running tasks

2021-05-21 Thread GitBox
Apache-HBase commented on pull request #3264: URL: https://github.com/apache/hbase/pull/3264#issuecomment-846250404 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25865) Visualize current state of region assignment

2021-05-21 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17349473#comment-17349473 ] Bharath Vissapragada commented on HBASE-25865: -- Sure, let me apply the patch locally and

[jira] [Commented] (HBASE-25865) Visualize current state of region assignment

2021-05-21 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17349466#comment-17349466 ] Nick Dimiduk commented on HBASE-25865: -- [~bharathv] I'm still working on getting a screenshot

[jira] [Updated] (HBASE-25848) Add flexibility to backup replication in case replication filter throws an exception

2021-05-21 Thread Sandeep Pal (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandeep Pal updated HBASE-25848: Affects Version/s: (was: 2.0.0) 1.8.0 2.6.7 >

[jira] [Updated] (HBASE-25848) Add flexibility to backup replication in case replication filter throws an exception

2021-05-21 Thread Sandeep Pal (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandeep Pal updated HBASE-25848: Affects Version/s: (was: 2.6.7) 2.0.0 > Add flexibility to backup

[jira] [Updated] (HBASE-25848) Add flexibility to backup replication in case replication filter throws an exception

2021-05-21 Thread Sandeep Pal (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandeep Pal updated HBASE-25848: Fix Version/s: 2.3.5.1 2.4.4 2.3.6

[GitHub] [hbase] sandeepvinayak opened a new pull request #3291: HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-21 Thread GitBox
sandeepvinayak opened a new pull request #3291: URL: https://github.com/apache/hbase/pull/3291 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[jira] [Updated] (HBASE-25869) WAL value compression

2021-05-21 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25869: Hadoop Flags: Reviewed Release Note: WAL storage can be expensive, especially

[GitHub] [hbase] xcangCRM merged pull request #3288: [Backport]HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-21 Thread GitBox
xcangCRM merged pull request #3288: URL: https://github.com/apache/hbase/pull/3288 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [hbase] xcangCRM merged pull request #3289: [Backport]HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-21 Thread GitBox
xcangCRM merged pull request #3289: URL: https://github.com/apache/hbase/pull/3289 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [hbase] Apache-HBase commented on pull request #3274: HBASE-25873 Refactor and cleanup the code for CostFunction

2021-05-21 Thread GitBox
Apache-HBase commented on pull request #3274: URL: https://github.com/apache/hbase/pull/3274#issuecomment-846147567 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Comment Edited] (HBASE-25869) WAL value compression

2021-05-21 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342054#comment-17342054 ] Andrew Kyle Purtell edited comment on HBASE-25869 at 5/21/21, 6:09 PM:

[GitHub] [hbase] Apache-HBase commented on pull request #3274: HBASE-25873 Refactor and cleanup the code for CostFunction

2021-05-21 Thread GitBox
Apache-HBase commented on pull request #3274: URL: https://github.com/apache/hbase/pull/3274#issuecomment-846143388 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] apurtell merged pull request #3244: HBASE-25869 WAL value compression

2021-05-21 Thread GitBox
apurtell merged pull request #3244: URL: https://github.com/apache/hbase/pull/3244 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Updated] (HBASE-25887) Corrupt wal while region server is aborting.

2021-05-21 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada updated HBASE-25887: - Affects Version/s: (was: 2.5.0) (was:

[jira] [Updated] (HBASE-25887) Corrupt wal while region server is aborting.

2021-05-21 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada updated HBASE-25887: - Fix Version/s: (was: 2.4.4) (was: 2.3.6)

[GitHub] [hbase] shahrs87 commented on pull request #3264: HBASE-25887 Wait for appendExecutor to shutdown running tasks

2021-05-21 Thread GitBox
shahrs87 commented on pull request #3264: URL: https://github.com/apache/hbase/pull/3264#issuecomment-846140711 Ran all the failing tests locally. ``` [INFO] --- [INFO] T E S T S [INFO]

[jira] [Resolved] (HBASE-25827) Per Cell TTL tags get duplicated with increments causing tags length overflow

2021-05-21 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-25827. -- Fix Version/s: 2.4.4 2.5.0 3.0.0-alpha-1 Hadoop

[jira] [Commented] (HBASE-25827) Per Cell TTL tags get duplicated with increments causing tags length overflow

2021-05-21 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17349404#comment-17349404 ] Viraj Jasani commented on HBASE-25827: -- [~shahrs87] [~mohamed.meeran] If you want the patch in

[GitHub] [hbase] virajjasani merged pull request #3290: HBASE-25827 Per Cell TTL tags get duplicated with increments causing tags length overflow

2021-05-21 Thread GitBox
virajjasani merged pull request #3290: URL: https://github.com/apache/hbase/pull/3290 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Commented] (HBASE-25032) Do not assign regions to region server which has not called regionServerReport yet

2021-05-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17349400#comment-17349400 ] Hudson commented on HBASE-25032: Results for branch branch-2 [build #256 on

[jira] [Commented] (HBASE-25897) TestRetainAssignmentOnRestart is flaky after HBASE-25032

2021-05-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17349399#comment-17349399 ] Hudson commented on HBASE-25897: Results for branch branch-2 [build #256 on

[GitHub] [hbase] virajjasani merged pull request #3210: HBASE-25827 Per Cell TTL tags get duplicated with increments causing tags length overflow

2021-05-21 Thread GitBox
virajjasani merged pull request #3210: URL: https://github.com/apache/hbase/pull/3210 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Commented] (HBASE-25682) Add a new command to update the configuration of all RSs in a RSGroup

2021-05-21 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17349396#comment-17349396 ] Pankaj Kumar commented on HBASE-25682: -- Pushed to master and branch-2. Thanks [~DeanZ] for the

[GitHub] [hbase] Apache-HBase commented on pull request #3264: HBASE-25887 Wait for appendExecutor to shutdown running tasks

2021-05-21 Thread GitBox
Apache-HBase commented on pull request #3264: URL: https://github.com/apache/hbase/pull/3264#issuecomment-846117159 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 15m

[jira] [Resolved] (HBASE-25682) Add a new command to update the configuration of all RSs in a RSGroup

2021-05-21 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pankaj Kumar resolved HBASE-25682. -- Fix Version/s: 2.5.0 3.0.0-alpha-1 Release Note: Added

[GitHub] [hbase] pankaj72981 merged pull request #3106: HBASE-25682 Add a new command to update the configuration of all RSs in a RSGroup for branch-2

2021-05-21 Thread GitBox
pankaj72981 merged pull request #3106: URL: https://github.com/apache/hbase/pull/3106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] pankaj72981 merged pull request #3080: HBASE-25682 Add a new command to update the configuration of all RSs in a RSGroup

2021-05-21 Thread GitBox
pankaj72981 merged pull request #3080: URL: https://github.com/apache/hbase/pull/3080 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] shahrs87 edited a comment on pull request #3264: HBASE-25887 Wait for appendExecutor to shutdown running tasks

2021-05-21 Thread GitBox
shahrs87 edited a comment on pull request #3264: URL: https://github.com/apache/hbase/pull/3264#issuecomment-845963153 > Ok, after reading some disruptor code and it's shutdown routine, I think the issue is something else here. Agree with @bharathv that the bug lies in appending

[jira] [Commented] (HBASE-25827) Per Cell TTL tags get duplicated with increments causing tags length overflow

2021-05-21 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17349366#comment-17349366 ] Rushabh Shah commented on HBASE-25827: -- [~mohamed.meeran] Here is the PR:

[GitHub] [hbase] Apache-HBase commented on pull request #3290: HBASE-25827 Per Cell TTL tags get duplicated with increments causing tags length overflow

2021-05-21 Thread GitBox
Apache-HBase commented on pull request #3290: URL: https://github.com/apache/hbase/pull/3290#issuecomment-846076712 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25827) Per Cell TTL tags get duplicated with increments causing tags length overflow

2021-05-21 Thread Mohamed Mohideen Meeran (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17349360#comment-17349360 ] Mohamed Mohideen Meeran commented on HBASE-25827: - Hi Rushabh Shah, Any update on the

[GitHub] [hbase] Apache-HBase commented on pull request #3274: HBASE-25873 Refactor and cleanup the code for CostFunction

2021-05-21 Thread GitBox
Apache-HBase commented on pull request #3274: URL: https://github.com/apache/hbase/pull/3274#issuecomment-846068573 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3290: HBASE-25827 Per Cell TTL tags get duplicated with increments causing tags length overflow

2021-05-21 Thread GitBox
Apache-HBase commented on pull request #3290: URL: https://github.com/apache/hbase/pull/3290#issuecomment-846058127 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache9 commented on a change in pull request #3140: HBASE-25720 Sync WAL stuck when prepare flush cache will prevent flus…

2021-05-21 Thread GitBox
Apache9 commented on a change in pull request #3140: URL: https://github.com/apache/hbase/pull/3140#discussion_r637022472 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -2846,7 +2846,13 @@ protected PrepareFlushResult

[GitHub] [hbase] Apache-HBase commented on pull request #3210: HBASE-25827 Per Cell TTL tags get duplicated with increments causing tags length overflow

2021-05-21 Thread GitBox
Apache-HBase commented on pull request #3210: URL: https://github.com/apache/hbase/pull/3210#issuecomment-846042644 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3210: HBASE-25827 Per Cell TTL tags get duplicated with increments causing tags length overflow

2021-05-21 Thread GitBox
Apache-HBase commented on pull request #3210: URL: https://github.com/apache/hbase/pull/3210#issuecomment-846041390 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-25901) Replication maybe lose data when the regionserver is restarted.

2021-05-21 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25901: -- Component/s: wal > Replication maybe lose data when the regionserver is restarted. >

[jira] [Assigned] (HBASE-25901) Replication maybe lose data when the regionserver is restarted.

2021-05-21 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-25901: - Assignee: youhailang > Replication maybe lose data when the regionserver is restarted. >

[jira] [Updated] (HBASE-25901) Replication maybe lose data when the regionserver is restarted.

2021-05-21 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25901: -- Fix Version/s: 2.3.6 > Replication maybe lose data when the regionserver is restarted. >

[GitHub] [hbase] Apache9 commented on pull request #3286: Fix concurrent puts to queues.

2021-05-21 Thread GitBox
Apache9 commented on pull request #3286: URL: https://github.com/apache/hbase/pull/3286#issuecomment-846034847 To align with master, we'd better just use put instead of computeIfAbsent. Notice that, in our current implementation, it is impossible for us to find out the queue is

[GitHub] [hbase] shahrs87 commented on pull request #3264: HBASE-25887 Wait for appendExecutor to shutdown running tasks

2021-05-21 Thread GitBox
shahrs87 commented on pull request #3264: URL: https://github.com/apache/hbase/pull/3264#issuecomment-845963153 > Ok, after reading some disruptor code and it's shutdown routine, I think the issue is something else here. Agree with @bharathv that the bug lies in appending entries

[GitHub] [hbase] Apache-HBase commented on pull request #3210: HBASE-25827 Per Cell TTL tags get duplicated with increments causing tags length overflow

2021-05-21 Thread GitBox
Apache-HBase commented on pull request #3210: URL: https://github.com/apache/hbase/pull/3210#issuecomment-845951647 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3280: HBASE-25899 Improve efficiency of SnapshotHFileCleaner

2021-05-21 Thread GitBox
Apache-HBase commented on pull request #3280: URL: https://github.com/apache/hbase/pull/3280#issuecomment-845927805 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] shahrs87 commented on pull request #3210: HBASE-25827 Per Cell TTL tags get duplicated with increments causing tags length overflow

2021-05-21 Thread GitBox
shahrs87 commented on pull request #3210: URL: https://github.com/apache/hbase/pull/3210#issuecomment-845926663 @virajjasani PR for branch-2 https://github.com/apache/hbase/pull/3290 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hbase] shahrs87 edited a comment on pull request #3210: HBASE-25827 Per Cell TTL tags get duplicated with increments causing tags length overflow

2021-05-21 Thread GitBox
shahrs87 edited a comment on pull request #3210: URL: https://github.com/apache/hbase/pull/3210#issuecomment-845926663 @virajjasani PR for branch-2 https://github.com/apache/hbase/pull/3290 Thank you for your reviews ! -- This is an automated message from the Apache Git Service. To

[GitHub] [hbase] Apache-HBase commented on pull request #3290: HBASE-25827 Per Cell TTL tags get duplicated with increments causing tags length overflow

2021-05-21 Thread GitBox
Apache-HBase commented on pull request #3290: URL: https://github.com/apache/hbase/pull/3290#issuecomment-845924878 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3280: HBASE-25899 Improve efficiency of SnapshotHFileCleaner

2021-05-21 Thread GitBox
Apache-HBase commented on pull request #3280: URL: https://github.com/apache/hbase/pull/3280#issuecomment-845921226 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3210: HBASE-25827 Per Cell TTL tags get duplicated with increments causing tags length overflow

2021-05-21 Thread GitBox
Apache-HBase commented on pull request #3210: URL: https://github.com/apache/hbase/pull/3210#issuecomment-845920842 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3210: HBASE-25827 Per Cell TTL tags get duplicated with increments causing tags length overflow

2021-05-21 Thread GitBox
Apache-HBase commented on pull request #3210: URL: https://github.com/apache/hbase/pull/3210#issuecomment-845920366 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] shahrs87 commented on pull request #3290: HBASE-25827 Per Cell TTL tags get duplicated with increments causing tags length overflow

2021-05-21 Thread GitBox
shahrs87 commented on pull request #3290: URL: https://github.com/apache/hbase/pull/3290#issuecomment-845900502 @virajjasani PR for branch-2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (HBASE-25897) TestRetainAssignmentOnRestart is flaky after HBASE-25032

2021-05-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17349172#comment-17349172 ] Hudson commented on HBASE-25897: Results for branch master [build #298 on

[jira] [Commented] (HBASE-25032) Do not assign regions to region server which has not called regionServerReport yet

2021-05-21 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17349173#comment-17349173 ] Hudson commented on HBASE-25032: Results for branch master [build #298 on

[GitHub] [hbase] shahrs87 opened a new pull request #3290: HBASE-25827 Per Cell TTL tags get duplicated with increments causing tags length overflow

2021-05-21 Thread GitBox
shahrs87 opened a new pull request #3290: URL: https://github.com/apache/hbase/pull/3290 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] Apache-HBase commented on pull request #3080: HBASE-25682 Add a new command to update the configuration of all RSs in a RSGroup

2021-05-21 Thread GitBox
Apache-HBase commented on pull request #3080: URL: https://github.com/apache/hbase/pull/3080#issuecomment-845894282 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] Apache-HBase commented on pull request #3210: HBASE-25827 Per Cell TTL tags get duplicated with increments causing tags length overflow

2021-05-21 Thread GitBox
Apache-HBase commented on pull request #3210: URL: https://github.com/apache/hbase/pull/3210#issuecomment-845857589 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] wchevreuil merged pull request #3285: Second rebase attempt for HBASE-24749 branch

2021-05-21 Thread GitBox
wchevreuil merged pull request #3285: URL: https://github.com/apache/hbase/pull/3285 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] virajjasani commented on pull request #3210: HBASE-25827 Per Cell TTL tags get duplicated with increments causing tags length overflow

2021-05-21 Thread GitBox
virajjasani commented on pull request #3210: URL: https://github.com/apache/hbase/pull/3210#issuecomment-845824305 @shahrs87 Can you also create PR against branch-2? Once QA is good, we can merge this PR on master and all active branch-2's together. Thanks for working on this fix. --

[GitHub] [hbase] Apache-HBase commented on pull request #3280: HBASE-25899 Improve efficiency of SnapshotHFileCleaner

2021-05-21 Thread GitBox
Apache-HBase commented on pull request #3280: URL: https://github.com/apache/hbase/pull/3280#issuecomment-845811690 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3080: HBASE-25682 Add a new command to update the configuration of all RSs in a RSGroup

2021-05-21 Thread GitBox
Apache-HBase commented on pull request #3080: URL: https://github.com/apache/hbase/pull/3080#issuecomment-845809850 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3289: [Backport]HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-21 Thread GitBox
Apache-HBase commented on pull request #3289: URL: https://github.com/apache/hbase/pull/3289#issuecomment-845740317 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] pankaj72981 commented on a change in pull request #3287: HBASE-25902 HMaster failed to start with NoSuchColumnFamilyException during upgrade from HBase 1.x to HBase 2.x

2021-05-21 Thread GitBox
pankaj72981 commented on a change in pull request #3287: URL: https://github.com/apache/hbase/pull/3287#discussion_r636684897 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java ## @@ -223,6 +253,21 @@ public TableDescriptor

[GitHub] [hbase] pankaj72981 commented on a change in pull request #3287: HBASE-25902 HMaster failed to start with NoSuchColumnFamilyException during upgrade from HBase 1.x to HBase 2.x

2021-05-21 Thread GitBox
pankaj72981 commented on a change in pull request #3287: URL: https://github.com/apache/hbase/pull/3287#discussion_r636676906 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java ## @@ -94,6 +95,10 @@ // TODO. private final Map

[GitHub] [hbase] pankaj72981 commented on a change in pull request #3287: HBASE-25902 HMaster failed to start with NoSuchColumnFamilyException during upgrade from HBase 1.x to HBase 2.x

2021-05-21 Thread GitBox
pankaj72981 commented on a change in pull request #3287: URL: https://github.com/apache/hbase/pull/3287#discussion_r636675320 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java ## @@ -1601,6 +1601,16 @@ */ public static final int

[GitHub] [hbase] Apache-HBase commented on pull request #3289: [Backport]HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-21 Thread GitBox
Apache-HBase commented on pull request #3289: URL: https://github.com/apache/hbase/pull/3289#issuecomment-845695475 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3288: [Backport]HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-21 Thread GitBox
Apache-HBase commented on pull request #3288: URL: https://github.com/apache/hbase/pull/3288#issuecomment-845689365 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] sunhelly commented on a change in pull request #3280: HBASE-25899 Improve efficiency of SnapshotHFileCleaner

2021-05-21 Thread GitBox
sunhelly commented on a change in pull request #3280: URL: https://github.com/apache/hbase/pull/3280#discussion_r636656646 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java ## @@ -226,7 +226,7 @@ public synchronized void