[GitHub] [hbase] saintstack opened a new pull request #3353: HBASE-25969 Purge netty-all transitive includes

2021-06-03 Thread GitBox
saintstack opened a new pull request #3353: URL: https://github.com/apache/hbase/pull/3353 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [hbase] Apache-HBase commented on pull request #3352: HBASE-25913 Introduce EnvironmentEdge.Clock and Clock.currentTimeAdvancing

2021-06-03 Thread GitBox
Apache-HBase commented on pull request #3352: URL: https://github.com/apache/hbase/pull/3352#issuecomment-854383001 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Created] (HBASE-25969) Purge netty-all transitive includes

2021-06-03 Thread Michael Stack (Jira)
Michael Stack created HBASE-25969: - Summary: Purge netty-all transitive includes Key: HBASE-25969 URL: https://issues.apache.org/jira/browse/HBASE-25969 Project: HBase Issue Type: Sub-task

[jira] [Commented] (HBASE-25930) Thrift does not support requests in Kerberos environment

2021-06-03 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357069#comment-17357069 ] Istvan Toth commented on HBASE-25930: - This seems to have been caused by HBASE-21652. Before the

[GitHub] [hbase] Apache-HBase commented on pull request #3352: HBASE-25913 Introduce EnvironmentEdge.Clock and Clock.currentTimeAdvancing

2021-06-03 Thread GitBox
Apache-HBase commented on pull request #3352: URL: https://github.com/apache/hbase/pull/3352#issuecomment-854330449 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3352: HBASE-25913 Introduce EnvironmentEdge.Clock and Clock.currentTimeAdvancing

2021-06-03 Thread GitBox
Apache-HBase commented on pull request #3352: URL: https://github.com/apache/hbase/pull/3352#issuecomment-854308171 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3352: HBASE-25913 Introduce EnvironmentEdge.Clock and Clock.currentTimeAdvancing

2021-06-03 Thread GitBox
Apache-HBase commented on pull request #3352: URL: https://github.com/apache/hbase/pull/3352#issuecomment-854307859 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25929) RegionServer JVM crash when compaction

2021-06-03 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357021#comment-17357021 ] Hudson commented on HBASE-25929: Results for branch branch-2.4 [build #134 on

[GitHub] [hbase] Apache-HBase commented on pull request #3352: HBASE-25913 Introduce EnvironmentEdge.Clock and Clock.currentTimeAdvancing

2021-06-03 Thread GitBox
Apache-HBase commented on pull request #3352: URL: https://github.com/apache/hbase/pull/3352#issuecomment-854306336 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] tomscut commented on pull request #3325: HBASE-25934 Add username for RegionScannerHolder

2021-06-03 Thread GitBox
tomscut commented on pull request #3325: URL: https://github.com/apache/hbase/pull/3325#issuecomment-854300252 > Those failed unit tests work fine locally. > > org.apache.hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController.(?) Hi @saintstack , could you please

[jira] [Comment Edited] (HBASE-25913) Introduce EnvironmentEdge.currentTimeAdvancing

2021-06-03 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356996#comment-17356996 ] Andrew Kyle Purtell edited comment on HBASE-25913 at 6/4/21, 1:45 AM:

[jira] [Comment Edited] (HBASE-25913) Introduce EnvironmentEdge.currentTimeAdvancing

2021-06-03 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356996#comment-17356996 ] Andrew Kyle Purtell edited comment on HBASE-25913 at 6/4/21, 1:45 AM:

[jira] [Comment Edited] (HBASE-25913) Introduce EnvironmentEdge.currentTimeAdvancing

2021-06-03 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356996#comment-17356996 ] Andrew Kyle Purtell edited comment on HBASE-25913 at 6/4/21, 1:41 AM:

[jira] [Updated] (HBASE-25913) Introduce EnvironmentEdge.currentTimeAdvancing

2021-06-03 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25913: Status: Patch Available (was: Open) > Introduce

[jira] [Comment Edited] (HBASE-25913) Introduce EnvironmentEdge.currentTimeAdvancing

2021-06-03 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356996#comment-17356996 ] Andrew Kyle Purtell edited comment on HBASE-25913 at 6/4/21, 1:19 AM:

[jira] [Commented] (HBASE-25913) Introduce EnvironmentEdge.currentTimeAdvancing

2021-06-03 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356996#comment-17356996 ] Andrew Kyle Purtell commented on HBASE-25913: - Draft PR:

[GitHub] [hbase] apurtell opened a new pull request #3352: HBASE-25913 Introduce EnvironmentEdge.Clock and Clock.currentTimeAdvancing

2021-06-03 Thread GitBox
apurtell opened a new pull request #3352: URL: https://github.com/apache/hbase/pull/3352 - Introduce a Clock abstraction into EnvironmentEdge and define Clock#currentTimeAdvancing, which ensures that every call to this method returns an advancing time. - Use a per region

[jira] [Updated] (HBASE-25913) Introduce EnvironmentEdge.currentTimeAdvancing

2021-06-03 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25913: Attachment: jmh-HBASE-25913.tar.gz > Introduce

[jira] [Updated] (HBASE-25913) Introduce EnvironmentEdge.currentTimeAdvancing

2021-06-03 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25913: Attachment: (was:

[jira] [Updated] (HBASE-25913) Introduce EnvironmentEdge.currentTimeAdvancing

2021-06-03 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25913: Attachment: (was: jmh-HBASE-25913.tar.gz) > Introduce

[jira] [Commented] (HBASE-25913) Introduce EnvironmentEdge.currentTimeAdvancing

2021-06-03 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356982#comment-17356982 ] Andrew Kyle Purtell commented on HBASE-25913: - Multithreaded benchmarks:

[jira] [Updated] (HBASE-25913) Introduce EnvironmentEdge.currentTimeAdvancing

2021-06-03 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25913: Attachment: HBASE-25913_Multithreaded_Benchmarks.pdf > Introduce

[GitHub] [hbase] busbey commented on pull request #3349: HBASE-25966 Fix typo in NOTICE.vm

2021-06-03 Thread GitBox
busbey commented on pull request #3349: URL: https://github.com/apache/hbase/pull/3349#issuecomment-854178740 I'll dig in later this evening to see what's going on here. for the jars in particular this looks like the opposite of what I thought was going to happen after reading the patch.

[jira] [Updated] (HBASE-25895) Implement a Cluster Metrics JSON endpoint

2021-06-03 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-25895: - Release Note: Introduces a REST+JSON endpoint on the master info server port, which is used to

[GitHub] [hbase] Apache-HBase commented on pull request #3350: HBASE-25950 add basic compaction server metric

2021-06-03 Thread GitBox
Apache-HBase commented on pull request #3350: URL: https://github.com/apache/hbase/pull/3350#issuecomment-854133310 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3350: HBASE-25950 add basic compaction server metric

2021-06-03 Thread GitBox
Apache-HBase commented on pull request #3350: URL: https://github.com/apache/hbase/pull/3350#issuecomment-854118616 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] busbey commented on pull request #3349: HBASE-25966 Fix typo in NOTICE.vm

2021-06-03 Thread GitBox
busbey commented on pull request #3349: URL: https://github.com/apache/hbase/pull/3349#issuecomment-854059708 I'm building this branch locally now so I can check through stuff. Thanks for finding and fixing this Nick! -- This is an automated message from the Apache Git Service. To

[GitHub] [hbase] Apache-HBase commented on pull request #3351: HBASE-25967 The readRequestsCount does not calculate when the outResu…

2021-06-03 Thread GitBox
Apache-HBase commented on pull request #3351: URL: https://github.com/apache/hbase/pull/3351#issuecomment-854035459 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25524) Region Servers should give some indication that short-circuit reads are configured properly and working

2021-06-03 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356565#comment-17356565 ] Sean Busbey commented on HBASE-25524: - We should be able to use the read from

[jira] [Commented] (HBASE-25524) Region Servers should give some indication that short-circuit reads are configured properly and working

2021-06-03 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356564#comment-17356564 ] Sean Busbey commented on HBASE-25524: - ACDC requires the following justification for disclosure: Who

[jira] [Issue Comment Deleted] (HBASE-25524) Region Servers should give some indication that short-circuit reads are configured properly and working

2021-06-03 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-25524: Comment: was deleted (was: ACDC requires the following justification for disclosure: Who

[GitHub] [hbase] Apache-HBase commented on pull request #3350: HBASE-25950 add basic compaction server metric

2021-06-03 Thread GitBox
Apache-HBase commented on pull request #3350: URL: https://github.com/apache/hbase/pull/3350#issuecomment-854002166 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3351: HBASE-25967 The readRequestsCount does not calculate when the outResu…

2021-06-03 Thread GitBox
Apache-HBase commented on pull request #3351: URL: https://github.com/apache/hbase/pull/3351#issuecomment-853973352 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Comment Edited] (HBASE-25930) Thrift does not support requests in Kerberos environment

2021-06-03 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356448#comment-17356448 ] Istvan Toth edited comment on HBASE-25930 at 6/3/21, 2:02 PM: -- I have

[jira] [Commented] (HBASE-25930) Thrift does not support requests in Kerberos environment

2021-06-03 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356448#comment-17356448 ] Istvan Toth commented on HBASE-25930: - I have encountered the same issue, and this patch fixed it

[GitHub] [hbase] Apache-HBase commented on pull request #3351: HBASE-25967 The readRequestsCount does not calculate when the outResu…

2021-06-03 Thread GitBox
Apache-HBase commented on pull request #3351: URL: https://github.com/apache/hbase/pull/3351#issuecomment-853880701 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] bsglz opened a new pull request #3351: HBASE-25967 The readRequestsCount does not calculate when the outResu…

2021-06-03 Thread GitBox
bsglz opened a new pull request #3351: URL: https://github.com/apache/hbase/pull/3351 …lts is empty -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [hbase] Apache-HBase commented on pull request #3318: HBASE-25929 RegionServer JVM crash when compaction

2021-06-03 Thread GitBox
Apache-HBase commented on pull request #3318: URL: https://github.com/apache/hbase/pull/3318#issuecomment-853826396 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3350: HBASE-25950 add basic compaction server metric

2021-06-03 Thread GitBox
Apache-HBase commented on pull request #3350: URL: https://github.com/apache/hbase/pull/3350#issuecomment-853818089 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] Apache-HBase commented on pull request #3350: HBASE-25950 add basic compaction server metric

2021-06-03 Thread GitBox
Apache-HBase commented on pull request #3350: URL: https://github.com/apache/hbase/pull/3350#issuecomment-853796682 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25524) Region Servers should give some indication that short-circuit reads are configured properly and working

2021-06-03 Thread Rahul Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356345#comment-17356345 ] Rahul Kumar commented on HBASE-25524: - Ping [~busbey] on the above concern. > Region Servers should

[jira] [Updated] (HBASE-25891) Remove dependence storing WAL filenames for backup

2021-06-03 Thread Mallikarjun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mallikarjun updated HBASE-25891: Description: Currently WAL logs are stored in `backup:system` meta table  {code:java} // code

[jira] [Updated] (HBASE-25784) Support for Parallel Backups enabling multi tenancy with rsgroups

2021-06-03 Thread Mallikarjun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mallikarjun updated HBASE-25784: Description: *Existing Design* *!image-2021-06-03-16-33-59-282.png|width=292,height=408!*

[jira] [Updated] (HBASE-25784) Support for Parallel Backups enabling multi tenancy with rsgroups

2021-06-03 Thread Mallikarjun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mallikarjun updated HBASE-25784: Description: *Existing Design* *!image-2021-06-03-16-33-59-282.png|width=292,height=408!*

[jira] [Updated] (HBASE-25784) Support for Parallel Backups enabling multi tenancy with rsgroups

2021-06-03 Thread Mallikarjun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mallikarjun updated HBASE-25784: Attachment: image-2021-06-03-16-34-34-957.png > Support for Parallel Backups enabling multi

[jira] [Updated] (HBASE-25784) Support for Parallel Backups enabling multi tenancy with rsgroups

2021-06-03 Thread Mallikarjun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mallikarjun updated HBASE-25784: Attachment: image-2021-06-03-16-33-59-282.png > Support for Parallel Backups enabling multi

[GitHub] [hbase] Apache-HBase commented on pull request #3318: HBASE-25929 RegionServer JVM crash when compaction

2021-06-03 Thread GitBox
Apache-HBase commented on pull request #3318: URL: https://github.com/apache/hbase/pull/3318#issuecomment-853780203 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3319: HBASE-25914 Provide slow/large logs on RegionServer UI

2021-06-03 Thread GitBox
Apache-HBase commented on pull request #3319: URL: https://github.com/apache/hbase/pull/3319#issuecomment-853779513 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Resolved] (HBASE-25666) Explain why balancer is skipping runs

2021-06-03 Thread Zhuoyue Huang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhuoyue Huang resolved HBASE-25666. --- Resolution: Fixed > Explain why balancer is skipping runs >

[GitHub] [hbase] Apache-HBase commented on pull request #3319: HBASE-25914 Provide slow/large logs on RegionServer UI

2021-06-03 Thread GitBox
Apache-HBase commented on pull request #3319: URL: https://github.com/apache/hbase/pull/3319#issuecomment-853776904 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Resolved] (HBASE-25929) RegionServer JVM crash when compaction

2021-06-03 Thread Yi Mei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yi Mei resolved HBASE-25929. Fix Version/s: 2.4.4 2.3.6 2.5.0 3.0.0-alpha-1

[jira] [Commented] (HBASE-25929) RegionServer JVM crash when compaction

2021-06-03 Thread Yi Mei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356309#comment-17356309 ] Yi Mei commented on HBASE-25929: Pused to branch-2.3+. Thanks [~anoop.hbase] and [~zhangduo] for

[jira] [Commented] (HBASE-25799) add clusterReadRequests and clusterWriteRequests jmx

2021-06-03 Thread Zheng Wang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356300#comment-17356300 ] Zheng Wang commented on HBASE-25799: Pushed to master, but when push to branch-2, there are

[GitHub] [hbase] mymeiyi merged pull request #3318: HBASE-25929 RegionServer JVM crash when compaction

2021-06-03 Thread GitBox
mymeiyi merged pull request #3318: URL: https://github.com/apache/hbase/pull/3318 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Updated] (HBASE-25918) Upgrade hbase-thirdparty dependency to 3.5.1

2021-06-03 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25918: -- Summary: Upgrade hbase-thirdparty dependency to 3.5.1 (was: Upgrade hbase-thirdparty dependency to

[GitHub] [hbase] Apache-HBase commented on pull request #3318: HBASE-25929 RegionServer JVM crash when compaction

2021-06-03 Thread GitBox
Apache-HBase commented on pull request #3318: URL: https://github.com/apache/hbase/pull/3318#issuecomment-853699192 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-13126) Provide alternate mini cluster classes other than HBTU for downstream users to write unit tests

2021-06-03 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-13126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356289#comment-17356289 ] Duo Zhang commented on HBASE-13126: --- {quote} make a new parent class to HBTU that lives in

[GitHub] [hbase] virajjasani commented on a change in pull request #3277: HBASE-25893 Corruption in recovered WAL in WALSplitter

2021-06-03 Thread GitBox
virajjasani commented on a change in pull request #3277: URL: https://github.com/apache/hbase/pull/3277#discussion_r644575803 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java ## @@ -1369,13 +1369,17 @@ public

[GitHub] [hbase] Apache-HBase commented on pull request #3319: HBASE-25914 Provide slow/large logs on RegionServer UI

2021-06-03 Thread GitBox
Apache-HBase commented on pull request #3319: URL: https://github.com/apache/hbase/pull/3319#issuecomment-853687434 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25914) Provide slow/large logs on RegionServer UI

2021-06-03 Thread Zhuoyue Huang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17356283#comment-17356283 ] Zhuoyue Huang commented on HBASE-25914: --- The latest version was pushed to [GitHub Pull Request

[jira] [Updated] (HBASE-25914) Provide slow/large logs on RegionServer UI

2021-06-03 Thread Zhuoyue Huang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhuoyue Huang updated HBASE-25914: -- Attachment: opeartionDetails1.png > Provide slow/large logs on RegionServer UI >

[GitHub] [hbase] Apache-HBase commented on pull request #3350: HBASE-25950 add basic compaction server metric

2021-06-03 Thread GitBox
Apache-HBase commented on pull request #3350: URL: https://github.com/apache/hbase/pull/3350#issuecomment-853684821 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-25914) Provide slow/large logs on RegionServer UI

2021-06-03 Thread Zhuoyue Huang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhuoyue Huang updated HBASE-25914: -- Attachment: operationDetails2.png > Provide slow/large logs on RegionServer UI >

[jira] [Updated] (HBASE-25968) Request compact to compaction server

2021-06-03 Thread Yulin Niu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yulin Niu updated HBASE-25968: -- Description: In this patch, figure out the offload compaction process:

[GitHub] [hbase] mymeiyi commented on pull request #3318: HBASE-25929 RegionServer JVM crash when compaction

2021-06-03 Thread GitBox
mymeiyi commented on pull request #3318: URL: https://github.com/apache/hbase/pull/3318#issuecomment-853660197 > Hi, Anoop, after reviewin the code, I do not think the problem is `lastCleanCell`. > > The problem here is that, after calling `scanner.next(cells, scannerContext)`, we

[GitHub] [hbase] bsglz merged pull request #3188: HBASE-25799 add clusterReadRequests and clusterWriteRequests jmx

2021-06-03 Thread GitBox
bsglz merged pull request #3188: URL: https://github.com/apache/hbase/pull/3188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Created] (HBASE-25968) Request compact to compaction server

2021-06-03 Thread Yulin Niu (Jira)
Yulin Niu created HBASE-25968: - Summary: Request compact to compaction server Key: HBASE-25968 URL: https://issues.apache.org/jira/browse/HBASE-25968 Project: HBase Issue Type: Sub-task

[GitHub] [hbase] nyl3532016 opened a new pull request #3350: HBASE-25950 add basic compaction server metric

2021-06-03 Thread GitBox
nyl3532016 opened a new pull request #3350: URL: https://github.com/apache/hbase/pull/3350 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [hbase] anoopsjohn commented on pull request #3318: HBASE-25929 RegionServer JVM crash when compaction

2021-06-03 Thread GitBox
anoopsjohn commented on pull request #3318: URL: https://github.com/apache/hbase/pull/3318#issuecomment-853616762 Thanks Duo. Ya I got it.. Was looking around that lastCleanCell ref as that was initially been referred. I got it very clear from @mymeiyi reply. Ya change looks good.

[GitHub] [hbase] Apache9 commented on pull request #3318: HBASE-25929 RegionServer JVM crash when compaction

2021-06-03 Thread GitBox
Apache9 commented on pull request #3318: URL: https://github.com/apache/hbase/pull/3318#issuecomment-853608676 Hi, Anoop, after reviewin the code, I do not think the problem is `lastCleanCell`. The problem here is that, after calling `scanner.next(cells, scannerContext)`, we then

[GitHub] [hbase] anoopsjohn commented on a change in pull request #3318: HBASE-25929 RegionServer JVM crash when compaction

2021-06-03 Thread GitBox
anoopsjohn commented on a change in pull request #3318: URL: https://github.com/apache/hbase/pull/3318#discussion_r644512914 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java ## @@ -451,25 +451,26 @@ protected boolean

[GitHub] [hbase] anoopsjohn commented on a change in pull request #3318: HBASE-25929 RegionServer JVM crash when compaction

2021-06-03 Thread GitBox
anoopsjohn commented on a change in pull request #3318: URL: https://github.com/apache/hbase/pull/3318#discussion_r644512740 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java ## @@ -451,25 +451,26 @@ protected boolean

[GitHub] [hbase] Apache-HBase commented on pull request #3188: HBASE-25799 add clusterReadRequests and clusterWriteRequests jmx

2021-06-03 Thread GitBox
Apache-HBase commented on pull request #3188: URL: https://github.com/apache/hbase/pull/3188#issuecomment-853597040 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3188: HBASE-25799 add clusterReadRequests and clusterWriteRequests jmx

2021-06-03 Thread GitBox
Apache-HBase commented on pull request #3188: URL: https://github.com/apache/hbase/pull/3188#issuecomment-853596461 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m