[GitHub] [hbase] Apache-HBase commented on pull request #3483: HBASE-25973 Balancer should explain progress in a better way in log -…

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3483: URL: https://github.com/apache/hbase/pull/3483#issuecomment-881828099 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3499: HBASE-26089 Support RegionCoprocessor on CompactionServer

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3499: URL: https://github.com/apache/hbase/pull/3499#issuecomment-881827216 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3499: HBASE-26089 Support RegionCoprocessor on CompactionServer

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3499: URL: https://github.com/apache/hbase/pull/3499#issuecomment-881827135 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3499: HBASE-26089 Support RegionCoprocessor on CompactionServer

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3499: URL: https://github.com/apache/hbase/pull/3499#issuecomment-881802332 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #3483: HBASE-25973 Balancer should explain progress in a better way in log -…

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3483: URL: https://github.com/apache/hbase/pull/3483#issuecomment-881802049 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-26083) L1 miss metric is incorrect when using CombinedBlockCache

2021-07-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17382406#comment-17382406 ] Hudson commented on HBASE-26083: Results for branch branch-2.4 [build #161 on

[GitHub] [hbase] Apache9 commented on pull request #3478: HBASE-26081 Copy HBTU to hbase-testing-util, rename the HBTU related …

2021-07-16 Thread GitBox
Apache9 commented on pull request #3478: URL: https://github.com/apache/hbase/pull/3478#issuecomment-881795895 > Why you thinking the package movement? The HBTU I'd think should be a top-level package rather than a sub-package down in testing? To avoid conflict with the copied ones

[GitHub] [hbase] Apache9 commented on pull request #3478: HBASE-26081 Copy HBTU to hbase-testing-util, rename the HBTU related …

2021-07-16 Thread GitBox
Apache9 commented on pull request #3478: URL: https://github.com/apache/hbase/pull/3478#issuecomment-881795344 > So, a user of these classes who moved to hbase 3.0.0 might have to amend their CLASSPATH but that is all? They might have to add hbase-testing jar to their CLASSPATH?

[GitHub] [hbase] Apache9 commented on a change in pull request #3478: HBASE-26081 Copy HBTU to hbase-testing-util, rename the HBTU related …

2021-07-16 Thread GitBox
Apache9 commented on a change in pull request #3478: URL: https://github.com/apache/hbase/pull/3478#discussion_r671589537 ## File path: hbase-it/src/test/java/org/apache/hadoop/hbase/DistributedHBaseCluster.java ## @@ -33,17 +33,23 @@ import

[GitHub] [hbase] Apache9 commented on pull request #3478: HBASE-26081 Copy HBTU to hbase-testing-util, rename the HBTU related …

2021-07-16 Thread GitBox
Apache9 commented on pull request #3478: URL: https://github.com/apache/hbase/pull/3478#issuecomment-881794378 > You move the fundamentals HBTU and HBC from top-level into sub-package to send downstreamers the message that these classes are off-limits going forward? The idea is to

[GitHub] [hbase] Apache9 commented on a change in pull request #3478: HBASE-26081 Copy HBTU to hbase-testing-util, rename the HBTU related …

2021-07-16 Thread GitBox
Apache9 commented on a change in pull request #3478: URL: https://github.com/apache/hbase/pull/3478#discussion_r671588185 ## File path: hbase-rest/pom.xml ## @@ -432,24 +436,13 @@ com.sun.jersey -jersey-core +

[GitHub] [hbase] Apache-HBase commented on pull request #3485: HBASE-25973 Balancer should explain progress in a better way in log -…

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3485: URL: https://github.com/apache/hbase/pull/3485#issuecomment-881786691 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3485: HBASE-25973 Balancer should explain progress in a better way in log -…

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3485: URL: https://github.com/apache/hbase/pull/3485#issuecomment-881786468 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3483: HBASE-25973 Balancer should explain progress in a better way in log -…

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3483: URL: https://github.com/apache/hbase/pull/3483#issuecomment-881780627 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3484: HBASE-25973 Balancer should explain progress in a better way in log -…

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3484: URL: https://github.com/apache/hbase/pull/3484#issuecomment-881761508 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3483: HBASE-25973 Balancer should explain progress in a better way in log -…

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3483: URL: https://github.com/apache/hbase/pull/3483#issuecomment-881760194 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3485: HBASE-25973 Balancer should explain progress in a better way in log -…

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3485: URL: https://github.com/apache/hbase/pull/3485#issuecomment-881757587 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25973) Balancer should explain progress in a better way in log

2021-07-16 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17382370#comment-17382370 ] Michael Stack commented on HBASE-25973: --- Merged to branch-2.3 and branch-2.4. Waiting on branch-2

[jira] [Updated] (HBASE-25973) Balancer should explain progress in a better way in log

2021-07-16 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-25973: -- Fix Version/s: 3.0.0-alpha-2 > Balancer should explain progress in a better way in log >

[jira] [Updated] (HBASE-25973) Balancer should explain progress in a better way in log

2021-07-16 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-25973: -- Fix Version/s: 2.4.5 2.3.6 > Balancer should explain progress in a better

[GitHub] [hbase] saintstack merged pull request #3484: HBASE-25973 Balancer should explain progress in a better way in log -…

2021-07-16 Thread GitBox
saintstack merged pull request #3484: URL: https://github.com/apache/hbase/pull/3484 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] saintstack merged pull request #3485: HBASE-25973 Balancer should explain progress in a better way in log -…

2021-07-16 Thread GitBox
saintstack merged pull request #3485: URL: https://github.com/apache/hbase/pull/3485 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] Apache-HBase commented on pull request #3485: HBASE-25973 Balancer should explain progress in a better way in log -…

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3485: URL: https://github.com/apache/hbase/pull/3485#issuecomment-881738433 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3484: HBASE-25973 Balancer should explain progress in a better way in log -…

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3484: URL: https://github.com/apache/hbase/pull/3484#issuecomment-881736647 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] saintstack commented on a change in pull request #3496: HBASE-24734 Wrong comparator opening Region when 'split-to-WAL' enabled.

2021-07-16 Thread GitBox
saintstack commented on a change in pull request #3496: URL: https://github.com/apache/hbase/pull/3496#discussion_r671526095 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/CellComparatorImpl.java ## @@ -677,6 +677,18 @@ public int compareRows(Cell left,

[GitHub] [hbase] apurtell commented on a change in pull request #3495: HBASE-24984 WAL corruption due to early DBBs re-use when Durability.A…

2021-07-16 Thread GitBox
apurtell commented on a change in pull request #3495: URL: https://github.com/apache/hbase/pull/3495#discussion_r671519156 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ServerCall.java ## @@ -175,23 +178,17 @@ private void release(int mask) { }

[GitHub] [hbase] apurtell commented on a change in pull request #3495: HBASE-24984 WAL corruption due to early DBBs re-use when Durability.A…

2021-07-16 Thread GitBox
apurtell commented on a change in pull request #3495: URL: https://github.com/apache/hbase/pull/3495#discussion_r671515927 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ServerCall.java ## @@ -97,11 +97,13 @@ private long exceptionSize = 0; private

[jira] [Commented] (HBASE-26088) conn.getBufferedMutator(tableName) leaks thread executors and other problems

2021-07-16 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17382327#comment-17382327 ] Michael Stack commented on HBASE-26088: --- I like the two line removal fix for branch-2. The default

[GitHub] [hbase] Apache-HBase commented on pull request #3484: HBASE-25973 Balancer should explain progress in a better way in log -…

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3484: URL: https://github.com/apache/hbase/pull/3484#issuecomment-881685185 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3485: HBASE-25973 Balancer should explain progress in a better way in log -…

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3485: URL: https://github.com/apache/hbase/pull/3485#issuecomment-881683298 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3478: HBASE-26081 Copy HBTU to hbase-testing-util, rename the HBTU related …

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3478: URL: https://github.com/apache/hbase/pull/3478#issuecomment-881679977 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3478: HBASE-26081 Copy HBTU to hbase-testing-util, rename the HBTU related …

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3478: URL: https://github.com/apache/hbase/pull/3478#issuecomment-881678564 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-22953) Supporting Hadoop 3.3.0

2021-07-16 Thread Dong Qiu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17382291#comment-17382291 ] Dong Qiu commented on HBASE-22953: -- Is hadoop 3.3.0 still unsupported ? > Supporting Hadoop 3.3.0 >

[GitHub] [hbase] Apache-HBase commented on pull request #3444: HBASE-26049 Remove DfsBuilderUtility

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3444: URL: https://github.com/apache/hbase/pull/3444#issuecomment-881661076 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3485: HBASE-25973 Balancer should explain progress in a better way in log -…

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3485: URL: https://github.com/apache/hbase/pull/3485#issuecomment-881656077 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] saintstack commented on pull request #3478: HBASE-26081 Copy HBTU to hbase-testing-util, rename the HBTU related …

2021-07-16 Thread GitBox
saintstack commented on pull request #3478: URL: https://github.com/apache/hbase/pull/3478#issuecomment-881651895 You move the fundamentals HBTU and HBC from top-level into sub-package to send downstreamers the message that these classes are off-limits going forward? -- This is an

[GitHub] [hbase] saintstack commented on a change in pull request #3478: HBASE-26081 Copy HBTU to hbase-testing-util, rename the HBTU related …

2021-07-16 Thread GitBox
saintstack commented on a change in pull request #3478: URL: https://github.com/apache/hbase/pull/3478#discussion_r671458461 ## File path: hbase-rest/pom.xml ## @@ -432,24 +436,13 @@ com.sun.jersey -jersey-core +

[jira] [Commented] (HBASE-26083) L1 miss metric is incorrect when using CombinedBlockCache

2021-07-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17382283#comment-17382283 ] Hudson commented on HBASE-26083: Results for branch branch-2 [build #301 on

[GitHub] [hbase] saintstack commented on pull request #3478: HBASE-26081 Copy HBTU to hbase-testing-util, rename the HBTU related …

2021-07-16 Thread GitBox
saintstack commented on pull request #3478: URL: https://github.com/apache/hbase/pull/3478#issuecomment-881643820 Why you thinking the package movement? The HBTU I'd think should be a top-level package rather than a sub-package down in testing? -- This is an automated message from the

[GitHub] [hbase] saintstack commented on pull request #3478: HBASE-26081 Copy HBTU to hbase-testing-util, rename the HBTU related …

2021-07-16 Thread GitBox
saintstack commented on pull request #3478: URL: https://github.com/apache/hbase/pull/3478#issuecomment-881642756 So, a user of these classes who moved to hbase 3.0.0 might have to amend their CLASSPATH but that is all? They might have to add hbase-testing jar to their CLASSPATH? --

[GitHub] [hbase] Apache-HBase commented on pull request #3485: HBASE-25973 Balancer should explain progress in a better way in log -…

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3485: URL: https://github.com/apache/hbase/pull/3485#issuecomment-881639063 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3485: HBASE-25973 Balancer should explain progress in a better way in log -…

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3485: URL: https://github.com/apache/hbase/pull/3485#issuecomment-881638761 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hbase] Apache-HBase commented on pull request #3483: HBASE-25973 Balancer should explain progress in a better way in log -…

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3483: URL: https://github.com/apache/hbase/pull/3483#issuecomment-881632192 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-26083) L1 miss metric is incorrect when using CombinedBlockCache

2021-07-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17382257#comment-17382257 ] Hudson commented on HBASE-26083: Results for branch branch-2.3 [build #255 on

[GitHub] [hbase] Apache-HBase commented on pull request #3444: HBASE-26049 Remove DfsBuilderUtility

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3444: URL: https://github.com/apache/hbase/pull/3444#issuecomment-881624781 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-25739) TableSkewCostFunction need to use aggregated deviation

2021-07-16 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-25739: -- Fix Version/s: 2.4.5 2.3.6 > TableSkewCostFunction need to use aggregated

[jira] [Resolved] (HBASE-25739) TableSkewCostFunction need to use aggregated deviation

2021-07-16 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25739. --- Hadoop Flags: Reviewed Resolution: Fixed Resovling after merging PRs for branch-2.3+.

[GitHub] [hbase] saintstack merged pull request #3482: HBASE-25739 TableSkewCostFunction need to use aggregated deviation - …

2021-07-16 Thread GitBox
saintstack merged pull request #3482: URL: https://github.com/apache/hbase/pull/3482 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] saintstack merged pull request #3481: HBASE-25739 TableSkewCostFunction need to use aggregated deviation - …

2021-07-16 Thread GitBox
saintstack merged pull request #3481: URL: https://github.com/apache/hbase/pull/3481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (HBASE-24984) WAL corruption due to early DBBs re-use when Durability.ASYNC_WAL is used with multi operation

2021-07-16 Thread Gaurav Kanade (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gaurav Kanade updated HBASE-24984: -- Status: Patch Available (was: Open) > WAL corruption due to early DBBs re-use when

[GitHub] [hbase] Apache-HBase commented on pull request #3460: HBASE-26064 Introduce a StoreFileTracker to abstract the stor…

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3460: URL: https://github.com/apache/hbase/pull/3460#issuecomment-881617735 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[jira] [Commented] (HBASE-24590) Clone snapshot with optional table level property overrides

2021-07-16 Thread Saksham Gangwar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17382242#comment-17382242 ] Saksham Gangwar commented on HBASE-24590: - [~bharathv] will you be able to assign this WI to me,

[GitHub] [hbase] Apache-HBase commented on pull request #3483: HBASE-25973 Balancer should explain progress in a better way in log -…

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3483: URL: https://github.com/apache/hbase/pull/3483#issuecomment-881614548 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3460: HBASE-26064 Introduce a StoreFileTracker to abstract the stor…

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3460: URL: https://github.com/apache/hbase/pull/3460#issuecomment-881613020 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3478: HBASE-26081 Copy HBTU to hbase-testing-util, rename the HBTU related …

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3478: URL: https://github.com/apache/hbase/pull/3478#issuecomment-881601263 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-26083) L1 miss metric is incorrect when using CombinedBlockCache

2021-07-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17382176#comment-17382176 ] Hudson commented on HBASE-26083: Results for branch branch-1 [build #151 on

[GitHub] [hbase] Apache-HBase commented on pull request #3499: HBASE-26089 Support RegionCoprocessor on CompactionServer

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3499: URL: https://github.com/apache/hbase/pull/3499#issuecomment-881552274 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3444: HBASE-26049 Remove DfsBuilderUtility

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3444: URL: https://github.com/apache/hbase/pull/3444#issuecomment-881546553 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24984) WAL corruption due to early DBBs re-use when Durability.ASYNC_WAL is used with multi operation

2021-07-16 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17382156#comment-17382156 ] Huaxiang Sun commented on HBASE-24984: -- Well explained, [~anoop.hbase]. > WAL corruption due to

[GitHub] [hbase] Apache-HBase commented on pull request #3499: HBASE-26089 Support RegionCoprocessor on CompactionServer

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3499: URL: https://github.com/apache/hbase/pull/3499#issuecomment-881540272 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3499: HBASE-26089 Support RegionCoprocessor on CompactionServer

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3499: URL: https://github.com/apache/hbase/pull/3499#issuecomment-881540068 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3460: HBASE-26064 Introduce a StoreFileTracker to abstract the stor…

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3460: URL: https://github.com/apache/hbase/pull/3460#issuecomment-881533893 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] nyl3532016 opened a new pull request #3499: HBASE-26089 Support RegionCoprocessor on CompactionServer

2021-07-16 Thread GitBox
nyl3532016 opened a new pull request #3499: URL: https://github.com/apache/hbase/pull/3499 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] Apache-HBase commented on pull request #3493: HBASE-26090 Remove the deprecated methods in Scan which should be rem…

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3493: URL: https://github.com/apache/hbase/pull/3493#issuecomment-881507150 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-26090) Remove the deprecated methods in Scan which should be removed in 3.0.0

2021-07-16 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26090: -- Description: (was: The following methods have been removed: public Scan setTimeStamp(long

[jira] [Updated] (HBASE-26090) Remove the deprecated methods in Scan which should be removed in 3.0.0

2021-07-16 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26090: -- Description: The following methods have been removed: public Scan setTimeStamp(long timestamp);

[jira] [Updated] (HBASE-26090) Remove the deprecated methods in Scan which should be removed in 3.0.0

2021-07-16 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26090: -- Release Note: The following methods have been removed: public Scan setTimeStamp(long timestamp);

[jira] [Updated] (HBASE-26090) Remove the deprecated methods in Scan which should be removed in 3.0.0

2021-07-16 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26090: -- Component/s: scan Client API > Remove the deprecated methods in

[jira] [Resolved] (HBASE-26090) Remove the deprecated methods in Scan which should be removed in 3.0.0

2021-07-16 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-26090. --- Hadoop Flags: Reviewed Resolution: Fixed Merged to master. Thanks all for reviewing. >

[GitHub] [hbase] Apache9 merged pull request #3493: HBASE-26090 Remove the deprecated methods in Scan which should be rem…

2021-07-16 Thread GitBox
Apache9 merged pull request #3493: URL: https://github.com/apache/hbase/pull/3493 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Assigned] (HBASE-25394) Support Snapshot related operation with direct insert HFiles into data/CF directory

2021-07-16 Thread Szabolcs Bukros (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szabolcs Bukros reassigned HBASE-25394: --- Assignee: Szabolcs Bukros > Support Snapshot related operation with direct insert

[jira] [Commented] (HBASE-26083) L1 miss metric is incorrect when using CombinedBlockCache

2021-07-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17382087#comment-17382087 ] Hudson commented on HBASE-26083: Results for branch master [build #344 on

[GitHub] [hbase] Apache-HBase commented on pull request #3493: HBASE-26090 Remove the deprecated methods in Scan which should be rem…

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3493: URL: https://github.com/apache/hbase/pull/3493#issuecomment-881456069 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3444: HBASE-26049 Remove DfsBuilderUtility

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3444: URL: https://github.com/apache/hbase/pull/3444#issuecomment-881455464 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3444: HBASE-26049 Remove DfsBuilderUtility

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3444: URL: https://github.com/apache/hbase/pull/3444#issuecomment-881445014 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3483: HBASE-25973 Balancer should explain progress in a better way in log -…

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3483: URL: https://github.com/apache/hbase/pull/3483#issuecomment-881438887 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3497: HBASE-26091 Remove FirstKeyValueMatchingQualifiersFilter

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3497: URL: https://github.com/apache/hbase/pull/3497#issuecomment-881385895 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #3497: HBASE-26091 Remove FirstKeyValueMatchingQualifiersFilter

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3497: URL: https://github.com/apache/hbase/pull/3497#issuecomment-881385224 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3444: HBASE-26049 Remove DfsBuilderUtility

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3444: URL: https://github.com/apache/hbase/pull/3444#issuecomment-881375654 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3493: HBASE-26090 Remove the deprecated methods in Scan which should be rem…

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3493: URL: https://github.com/apache/hbase/pull/3493#issuecomment-881374544 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3492: HBASE-25986 set default value of normalization enabled from hbase site

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3492: URL: https://github.com/apache/hbase/pull/3492#issuecomment-881371103 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 18m

[GitHub] [hbase] Apache-HBase commented on pull request #3498: HBASE-26094 L2 BC should not be the victimhandler of L1 BC when using combined BC

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3498: URL: https://github.com/apache/hbase/pull/3498#issuecomment-881344632 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 16m

[GitHub] [hbase] Apache-HBase commented on pull request #3483: HBASE-25973 Balancer should explain progress in a better way in log -…

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3483: URL: https://github.com/apache/hbase/pull/3483#issuecomment-881341484 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3493: HBASE-26090 Remove the deprecated methods in Scan which should be rem…

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3493: URL: https://github.com/apache/hbase/pull/3493#issuecomment-881340015 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache9 commented on a change in pull request #3493: HBASE-26090 Remove the deprecated methods in Scan which should be rem…

2021-07-16 Thread GitBox
Apache9 commented on a change in pull request #3493: URL: https://github.com/apache/hbase/pull/3493#discussion_r671123615 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java ## @@ -1212,11 +1206,7 @@ public static Scan toScan(

[GitHub] [hbase] Apache-HBase commented on pull request #3493: HBASE-26090 Remove the deprecated methods in Scan which should be rem…

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3493: URL: https://github.com/apache/hbase/pull/3493#issuecomment-881328635 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] anoopsjohn commented on a change in pull request #3493: HBASE-26090 Remove the deprecated methods in Scan which should be rem…

2021-07-16 Thread GitBox
anoopsjohn commented on a change in pull request #3493: URL: https://github.com/apache/hbase/pull/3493#discussion_r671109693 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java ## @@ -1212,11 +1206,7 @@ public static Scan toScan(

[GitHub] [hbase] Apache-HBase commented on pull request #3497: HBASE-26091 Remove FirstKeyValueMatchingQualifiersFilter

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3497: URL: https://github.com/apache/hbase/pull/3497#issuecomment-881311468 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] YutSean commented on pull request #3437: HBASE-26037 Implement namespace and table level access control for thrift & thrift2

2021-07-16 Thread GitBox
YutSean commented on pull request #3437: URL: https://github.com/apache/hbase/pull/3437#issuecomment-881286408 While grant and revoke have a lot of common attributes, like username, action lists. Besides, one function I think it is easier to maintain. -- This is an automated message

[GitHub] [hbase] Apache-HBase commented on pull request #3483: HBASE-25973 Balancer should explain progress in a better way in log -…

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3483: URL: https://github.com/apache/hbase/pull/3483#issuecomment-881271900 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3497: HBASE-26091 Remove FirstKeyValueMatchingQualifiersFilter

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3497: URL: https://github.com/apache/hbase/pull/3497#issuecomment-881267142 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3493: HBASE-26090 Remove the deprecated methods in Scan which should be rem…

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3493: URL: https://github.com/apache/hbase/pull/3493#issuecomment-881261498 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] GeorryHuang commented on a change in pull request #3497: HBASE-26091 Remove FirstKeyValueMatchingQualifiersFilter

2021-07-16 Thread GitBox
GeorryHuang commented on a change in pull request #3497: URL: https://github.com/apache/hbase/pull/3497#discussion_r671032563 ## File path: hbase-protocol-shaded/src/main/protobuf/client/Filter.proto ## @@ -88,10 +88,6 @@ message FilterWrapper { message FirstKeyOnlyFilter {

[GitHub] [hbase] Apache-HBase commented on pull request #3496: HBASE-24734 Wrong comparator opening Region when 'split-to-WAL' enabled.

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3496: URL: https://github.com/apache/hbase/pull/3496#issuecomment-881233421 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3483: HBASE-25973 Balancer should explain progress in a better way in log -…

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3483: URL: https://github.com/apache/hbase/pull/3483#issuecomment-881230352 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache9 commented on pull request #3493: HBASE-26090 Remove the deprecated methods in Scan which should be rem…

2021-07-16 Thread GitBox
Apache9 commented on pull request #3493: URL: https://github.com/apache/hbase/pull/3493#issuecomment-881227079 > These were deprecated from 2.0.0 right? Yes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hbase] Apache-HBase commented on pull request #3497: HBASE-26091 Remove FirstKeyValueMatchingQualifiersFilter

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3497: URL: https://github.com/apache/hbase/pull/3497#issuecomment-881226000 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache9 commented on a change in pull request #3497: HBASE-26091 Remove FirstKeyValueMatchingQualifiersFilter

2021-07-16 Thread GitBox
Apache9 commented on a change in pull request #3497: URL: https://github.com/apache/hbase/pull/3497#discussion_r671014258 ## File path: hbase-protocol-shaded/src/main/protobuf/client/Filter.proto ## @@ -88,10 +88,6 @@ message FilterWrapper { message FirstKeyOnlyFilter { }

[GitHub] [hbase] Apache-HBase commented on pull request #3496: HBASE-24734 Wrong comparator opening Region when 'split-to-WAL' enabled.

2021-07-16 Thread GitBox
Apache-HBase commented on pull request #3496: URL: https://github.com/apache/hbase/pull/3496#issuecomment-881220420 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24734) Wrong comparator opening Region when 'split-to-WAL' enabled.

2021-07-16 Thread Yi Mei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17381808#comment-17381808 ] Yi Mei commented on HBASE-24734: Hi [~anoop.hbase] when split meta wal to hfile, it has already use META

  1   2   >