[GitHub] [hbase] Apache9 commented on a change in pull request #4202: HBASE-26791 Memstore flush fencing issue for SFT

2022-03-17 Thread GitBox
Apache9 commented on a change in pull request #4202: URL: https://github.com/apache/hbase/pull/4202#discussion_r829710259 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/StoreFileListFile.java ## @@ -114,23 +127,96 @@ private int

[GitHub] [hbase] thangTang commented on a change in pull request #4233: HBASE-26850 Optimize the implementation of LRUCache in LRUDictionary

2022-03-17 Thread GitBox
thangTang commented on a change in pull request #4233: URL: https://github.com/apache/hbase/pull/4233#discussion_r829708104 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/util/LRUDictionary.java ## @@ -95,23 +95,32 @@ private short put(byte[] array, int

[GitHub] [hbase] thangTang commented on a change in pull request #4233: HBASE-26850 Optimize the implementation of LRUCache in LRUDictionary

2022-03-17 Thread GitBox
thangTang commented on a change in pull request #4233: URL: https://github.com/apache/hbase/pull/4233#discussion_r829708104 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/util/LRUDictionary.java ## @@ -95,23 +95,32 @@ private short put(byte[] array, int

[GitHub] [hbase] sunhelly commented on a change in pull request #4233: HBASE-26850 Optimize the implementation of LRUCache in LRUDictionary

2022-03-17 Thread GitBox
sunhelly commented on a change in pull request #4233: URL: https://github.com/apache/hbase/pull/4233#discussion_r829702965 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/util/LRUDictionary.java ## @@ -95,23 +95,32 @@ private short put(byte[] array, int

[jira] [Commented] (HBASE-26833) Avoid waiting to clear buffer usage of ReplicationSourceShipper when aborting the RS

2022-03-17 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17508567#comment-17508567 ] Hudson commented on HBASE-26833: Results for branch branch-2.4 [build #311 on

[GitHub] [hbase] Apache-HBase commented on pull request #4241: Backport StoreFileTracker (HBASE-26067, HBASE-26584, and others) to branch-2.5

2022-03-17 Thread GitBox
Apache-HBase commented on pull request #4241: URL: https://github.com/apache/hbase/pull/4241#issuecomment-1072006508 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #4241: Backport StoreFileTracker (HBASE-26067, HBASE-26584, and others) to branch-2.5

2022-03-17 Thread GitBox
Apache-HBase commented on pull request #4241: URL: https://github.com/apache/hbase/pull/4241#issuecomment-1071986293 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Assigned] (HBASE-26859) Split TestSnapshotProcedure to several smaller tests

2022-03-17 Thread ruanhui (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ruanhui reassigned HBASE-26859: --- Assignee: ruanhui > Split TestSnapshotProcedure to several smaller tests >

[GitHub] [hbase] apurtell edited a comment on pull request #4241: Backport StoreFileTracker (HBASE-26067, HBASE-26584, and others) to branch-2.5

2022-03-17 Thread GitBox
apurtell edited a comment on pull request #4241: URL: https://github.com/apache/hbase/pull/4241#issuecomment-1071962513 This isn't meant for code review. The description on this issue lists all commit SHAs and PR#s for the individual changes that were cherry picked from branch-2. If you

[GitHub] [hbase] apurtell commented on pull request #4241: Backport StoreFileTracker (HBASE-26067, HBASE-26584, and others) to branch-2.5

2022-03-17 Thread GitBox
apurtell commented on pull request #4241: URL: https://github.com/apache/hbase/pull/4241#issuecomment-1071962513 This isn't meant for code review. The description on this issue lists all commit SHAs and PR#s for the individual changes that were cherry picked from branch-2. The result

[GitHub] [hbase] apurtell opened a new pull request #4241: Backport StoreFileTracker (HBASE-26067, HBASE-26584, and others) to branch-2.5

2022-03-17 Thread GitBox
apurtell opened a new pull request #4241: URL: https://github.com/apache/hbase/pull/4241 In a discussion on dev@ the idea was floated that StoreFileTracker could be backported into branch-2.5 to be released as part of 2.5.0 as an experimental feature. This issue considers the backport.

[jira] [Updated] (HBASE-26826) Backport StoreFileTracker (HBASE-26067, HBASE-26584, and others) to branch-2.5

2022-03-17 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26826: Status: Patch Available (was: In Progress) > Backport StoreFileTracker

[jira] [Updated] (HBASE-26826) Backport StoreFileTracker (HBASE-26067, HBASE-26584, and others) to branch-2.5

2022-03-17 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26826: Description: In a discussion on dev@ the idea was floated that StoreFileTracker

[jira] [Updated] (HBASE-26826) Backport StoreFileTracker (HBASE-26067, HBASE-26584, and others) to branch-2.5

2022-03-17 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26826: Description: In a discussion on dev@ the idea was floated that StoreFileTracker

[jira] [Updated] (HBASE-26826) Backport StoreFileTracker (HBASE-26067, HBASE-26584, and others) to branch-2.5

2022-03-17 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26826: Description: In a discussion on dev@ the idea was floated that StoreFileTracker

[jira] [Updated] (HBASE-26826) Backport StoreFileTracker (HBASE-26067, HBASE-26584, and others) to branch-2.5

2022-03-17 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26826: Description: In a discussion on dev@ the idea was floated that StoreFileTracker

[jira] [Updated] (HBASE-26826) Backport StoreFileTracker (HBASE-26067, HBASE-26584, and others) to branch-2.5

2022-03-17 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26826: Description: In a discussion on dev@ the idea was floated that StoreFileTracker

[jira] [Updated] (HBASE-26826) Backport StoreFileTracker (HBASE-26067, HBASE-26584, and others) to branch-2.5

2022-03-17 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26826: Summary: Backport StoreFileTracker (HBASE-26067, HBASE-26584, and others) to

[jira] [Updated] (HBASE-26826) Backport StoreFileTracker (HBASE-26067 and others) to branch-2.5

2022-03-17 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26826: Summary: Backport StoreFileTracker (HBASE-26067 and others) to branch-2.5 (was:

[jira] [Updated] (HBASE-26826) Backport HBASE-26067 (Change the way on how we track store file list) to branch-2.5

2022-03-17 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26826: Component/s: Operability regionserver > Backport HBASE-26067

[jira] [Updated] (HBASE-26826) Backport HBASE-26067 (Change the way on how we track store file list) to branch-2.5

2022-03-17 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26826: Description: In a discussion on dev@ the idea was floated that StoreFileTracker

[jira] [Updated] (HBASE-26826) Backport HBASE-26067 (Change the way on how we track store file list) to branch-2.5

2022-03-17 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26826: Description: In a discussion on dev@ the idea was floated that StoreFileTracker

[jira] [Updated] (HBASE-26826) Backport HBASE-26067 (Change the way on how we track store file list) to branch-2.5

2022-03-17 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26826: Description: In a discussion on dev@ the idea was floated that StoreFileTracker

[jira] [Updated] (HBASE-26826) Backport HBASE-26067 (Change the way on how we track store file list) to branch-2.5

2022-03-17 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26826: Description: In a discussion on dev@ the idea was floated that StoreFileTracker

[jira] [Updated] (HBASE-26826) Backport HBASE-26067 (Change the way on how we track store file list) to branch-2.5

2022-03-17 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26826: Description: In a discussion on dev@ the idea was floated that StoreFileTracker

[jira] [Updated] (HBASE-26826) Backport HBASE-26067 (Change the way on how we track store file list) to branch-2.5

2022-03-17 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26826: Description: In a discussion on dev@ the idea was floated that StoreFileTracker

[jira] [Updated] (HBASE-26826) Backport HBASE-26067 (Change the way on how we track store file list) to branch-2.5

2022-03-17 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26826: Description: In a discussion on dev@ the idea was floated that StoreFileTracker

[GitHub] [hbase] Apache-HBase commented on pull request #4240: HBASE-26860 Backport "HBASE-25681 Add a switch for server/table queryMeter" to branch-2.4

2022-03-17 Thread GitBox
Apache-HBase commented on pull request #4240: URL: https://github.com/apache/hbase/pull/4240#issuecomment-1071937852 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-26826) Backport HBASE-26067 (Change the way on how we track store file list) to branch-2.5

2022-03-17 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26826: Description: In a discussion on dev@ the idea was floated that StoreFileTracker

[jira] [Updated] (HBASE-26826) Backport HBASE-26067 (Change the way on how we track store file list) to branch-2.5

2022-03-17 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26826: Description: In a discussion on dev@ the idea was floated that StoreFileTracker

[jira] [Commented] (HBASE-26826) Backport HBASE-26067 (Change the way on how we track store file list) to branch-2.5

2022-03-17 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17508507#comment-17508507 ] Andrew Kyle Purtell commented on HBASE-26826: - Thanks [~wchevreuil] . I have picked and

[jira] [Updated] (HBASE-26826) Backport HBASE-26067 (Change the way on how we track store file list) to branch-2.5

2022-03-17 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26826: Description: In a discussion on dev@ the idea was floated that StoreFileTracker

[jira] [Work started] (HBASE-26826) Backport HBASE-26067 (Change the way on how we track store file list) to branch-2.5

2022-03-17 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-26826 started by Andrew Kyle Purtell. --- > Backport HBASE-26067 (Change the way on how we track store

[jira] [Updated] (HBASE-26826) Backport HBASE-26067 (Change the way on how we track store file list) to branch-2.5

2022-03-17 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26826: Description: In a discussion on dev@ the idea was floated that StoreFileTracker

[GitHub] [hbase] Apache-HBase commented on pull request #4240: HBASE-26860 Backport "HBASE-25681 Add a switch for server/table queryMeter" to branch-2.4

2022-03-17 Thread GitBox
Apache-HBase commented on pull request #4240: URL: https://github.com/apache/hbase/pull/4240#issuecomment-1071910719 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #4239: HBASE-26859 Split TestSnapshotProcedure to several smaller tests

2022-03-17 Thread GitBox
Apache-HBase commented on pull request #4239: URL: https://github.com/apache/hbase/pull/4239#issuecomment-1071910198 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-26826) Backport HBASE-26067 (Change the way on how we track store file list) to branch-2.5

2022-03-17 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17508479#comment-17508479 ] Wellington Chevreuil commented on HBASE-26826: -- Thanks for opening this one, [~apurtell] !

[GitHub] [hbase] Apache-HBase commented on pull request #4181: HBASE-26810 Add dynamic configuration support for system coprocessors

2022-03-17 Thread GitBox
Apache-HBase commented on pull request #4181: URL: https://github.com/apache/hbase/pull/4181#issuecomment-1071844095 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Assigned] (HBASE-26826) Backport HBASE-26067 (Change the way on how we track store file list) to branch-2.5

2022-03-17 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell reassigned HBASE-26826: --- Assignee: Andrew Kyle Purtell > Backport HBASE-26067 (Change the way on

[jira] [Updated] (HBASE-26826) Backport HBASE-26067 (Change the way on how we track store file list) to branch-2.5

2022-03-17 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26826: Description: In a discussion on dev@ the idea was floated that StoreFileTracker

[GitHub] [hbase] Apache-HBase commented on pull request #4239: HBASE-26859 Split TestSnapshotProcedure to several smaller tests

2022-03-17 Thread GitBox
Apache-HBase commented on pull request #4239: URL: https://github.com/apache/hbase/pull/4239#issuecomment-1071587096 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Comment Edited] (HBASE-25687) Backport "HBASE-25681 Add a switch for server/table queryMeter" to branch-2 and branch-1

2022-03-17 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17508382#comment-17508382 ] Bryan Beaudreault edited comment on HBASE-25687 at 3/17/22, 8:37 PM: -

[jira] [Commented] (HBASE-26704) EOL HBase 2.3.x

2022-03-17 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17508410#comment-17508410 ] Sean Busbey commented on HBASE-26704: - announced:

[jira] [Resolved] (HBASE-26704) EOL HBase 2.3.x

2022-03-17 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey resolved HBASE-26704. - Resolution: Fixed > EOL HBase 2.3.x > --- > > Key: HBASE-26704 >

[GitHub] [hbase] Apache-HBase commented on pull request #4225: HBASE-26842 fix TestSnapshotProcedure for branch-2

2022-03-17 Thread GitBox
Apache-HBase commented on pull request #4225: URL: https://github.com/apache/hbase/pull/4225#issuecomment-1071338751 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #4240: HBASE-26860 Backport "HBASE-25681 Add a switch for server/table queryMeter" to branch-2.4

2022-03-17 Thread GitBox
Apache-HBase commented on pull request #4240: URL: https://github.com/apache/hbase/pull/4240#issuecomment-1071297769 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #4181: HBASE-26810 Add dynamic configuration support for system coprocessors

2022-03-17 Thread GitBox
Apache-HBase commented on pull request #4181: URL: https://github.com/apache/hbase/pull/4181#issuecomment-1071280420 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #4239: HBASE-26859 Split TestSnapshotProcedure to several smaller tests

2022-03-17 Thread GitBox
Apache-HBase commented on pull request #4239: URL: https://github.com/apache/hbase/pull/4239#issuecomment-1071238597 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #4225: HBASE-26842 fix TestSnapshotProcedure for branch-2

2022-03-17 Thread GitBox
Apache-HBase commented on pull request #4225: URL: https://github.com/apache/hbase/pull/4225#issuecomment-1071234348 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-26860) Backport "HBASE-25681 Add a switch for server/table queryMeter" to branch-2.4

2022-03-17 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault updated HBASE-26860: -- Status: Patch Available (was: Open) [https://github.com/apache/hbase/pull/4240]

[jira] [Updated] (HBASE-26860) Backport "HBASE-25681 Add a switch for server/table queryMeter" to branch-2.4

2022-03-17 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault updated HBASE-26860: -- Labels: patch-available (was: ) > Backport "HBASE-25681 Add a switch for

[GitHub] [hbase] bbeaudreault opened a new pull request #4240: HBASE-26860 Backport "HBASE-25681 Add a switch for server/table queryMeter" to branch-2.4

2022-03-17 Thread GitBox
bbeaudreault opened a new pull request #4240: URL: https://github.com/apache/hbase/pull/4240 Note: This was a clean cherry-pick of https://github.com/apache/hbase/commit/8ff17c68e2fb71c818cd16e6d3445d0c2658798b. If there's a better way for a committer to simply cherry-pick that into

[jira] [Created] (HBASE-26860) Backport "HBASE-25681 Add a switch for server/table queryMeter" to branch-2.4

2022-03-17 Thread Bryan Beaudreault (Jira)
Bryan Beaudreault created HBASE-26860: - Summary: Backport "HBASE-25681 Add a switch for server/table queryMeter" to branch-2.4 Key: HBASE-26860 URL: https://issues.apache.org/jira/browse/HBASE-26860

[jira] [Commented] (HBASE-25687) Backport "HBASE-25681 Add a switch for server/table queryMeter" to branch-2 and branch-1

2022-03-17 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17508382#comment-17508382 ] Bryan Beaudreault commented on HBASE-25687: --- Fix versions only referenced the 1.x version.

[GitHub] [hbase] Apache-HBase commented on pull request #4220: HBASE-26834 Adapt ConnectionRule for both sync and async connections (branch-2)

2022-03-17 Thread GitBox
Apache-HBase commented on pull request #4220: URL: https://github.com/apache/hbase/pull/4220#issuecomment-1071206132 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-26704) EOL HBase 2.3.x

2022-03-17 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17508381#comment-17508381 ] Sean Busbey commented on HBASE-26704: - note that the removal from the distro area was done today as

[GitHub] [hbase] Apache-HBase commented on pull request #4220: HBASE-26834 Adapt ConnectionRule for both sync and async connections (branch-2)

2022-03-17 Thread GitBox
Apache-HBase commented on pull request #4220: URL: https://github.com/apache/hbase/pull/4220#issuecomment-1071192159 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-25687) Backport "HBASE-25681 Add a switch for server/table queryMeter" to branch-2 and branch-1

2022-03-17 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault updated HBASE-25687: -- Fix Version/s: 2.5.0 > Backport "HBASE-25681 Add a switch for server/table

[jira] [Commented] (HBASE-26852) --hadoop-profile is not honored in branch-2 PR builds

2022-03-17 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17508366#comment-17508366 ] Tak-Lon (Stephen) Wu commented on HBASE-26852: -- (y) > --hadoop-profile is not honored in

[jira] [Created] (HBASE-26859) Split TestSnapshotProcedure to several smaller tests

2022-03-17 Thread ruanhui (Jira)
ruanhui created HBASE-26859: --- Summary: Split TestSnapshotProcedure to several smaller tests Key: HBASE-26859 URL: https://issues.apache.org/jira/browse/HBASE-26859 Project: HBase Issue Type:

[GitHub] [hbase] Apache-HBase commented on pull request #4238: HBASE-26858 Refactor TestMasterRegionOnTwoFileSystems to avoid dead loop

2022-03-17 Thread GitBox
Apache-HBase commented on pull request #4238: URL: https://github.com/apache/hbase/pull/4238#issuecomment-1071125117 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #4238: HBASE-26858 Refactor TestMasterRegionOnTwoFileSystems to avoid dead loop

2022-03-17 Thread GitBox
Apache-HBase commented on pull request #4238: URL: https://github.com/apache/hbase/pull/4238#issuecomment-1071115415 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #4125: HBASE-26666 Add native TLS encryption support to RPC server/client

2022-03-17 Thread GitBox
Apache-HBase commented on pull request #4125: URL: https://github.com/apache/hbase/pull/4125#issuecomment-1071086355 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] wchevreuil commented on a change in pull request #4202: HBASE-26791 Memstore flush fencing issue for SFT

2022-03-17 Thread GitBox
wchevreuil commented on a change in pull request #4202: URL: https://github.com/apache/hbase/pull/4202#discussion_r829183047 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/StoreFileListFile.java ## @@ -114,23 +127,96 @@ private

[GitHub] [hbase] anmolnar commented on pull request #4125: HBASE-26666 Add native TLS encryption support to RPC server/client

2022-03-17 Thread GitBox
anmolnar commented on pull request #4125: URL: https://github.com/apache/hbase/pull/4125#issuecomment-1071063417 > LGTM. please give another try and see if we can have a clean build. > > [nit] I may miss something but I'm wondered if we have any test or manual that has use

[GitHub] [hbase] anmolnar commented on a change in pull request #4125: HBASE-26666 Add native TLS encryption support to RPC server/client

2022-03-17 Thread GitBox
anmolnar commented on a change in pull request #4125: URL: https://github.com/apache/hbase/pull/4125#discussion_r829243045 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServer.java ## @@ -181,4 +204,80 @@ public int getNumOpenConnections() {

[GitHub] [hbase] Apache-HBase commented on pull request #4225: HBASE-26842 fix TestSnapshotProcedure for branch-2

2022-03-17 Thread GitBox
Apache-HBase commented on pull request #4225: URL: https://github.com/apache/hbase/pull/4225#issuecomment-1071028824 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] anmolnar commented on pull request #4125: HBASE-26666 Add native TLS encryption support to RPC server/client

2022-03-17 Thread GitBox
anmolnar commented on pull request #4125: URL: https://github.com/apache/hbase/pull/4125#issuecomment-1071016410 Out of curiosity, does anybody know why HBase not using Epoll (native transport) for client sockets? -- This is an automated message from the Apache Git Service. To respond

[GitHub] [hbase] anmolnar commented on pull request #4125: HBASE-26666 Add native TLS encryption support to RPC server/client

2022-03-17 Thread GitBox
anmolnar commented on pull request #4125: URL: https://github.com/apache/hbase/pull/4125#issuecomment-1071015155 @meszibalu Please take another look. I addressed your comments. I also changed back the client Netty stack to use a single thread. It still works and given that it only

[GitHub] [hbase] anmolnar commented on a change in pull request #4125: HBASE-26666 Add native TLS encryption support to RPC server/client

2022-03-17 Thread GitBox
anmolnar commented on a change in pull request #4125: URL: https://github.com/apache/hbase/pull/4125#discussion_r829220298 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServer.java ## @@ -181,4 +204,80 @@ public int getNumOpenConnections() {

[GitHub] [hbase] anmolnar commented on a change in pull request #4125: HBASE-26666 Add native TLS encryption support to RPC server/client

2022-03-17 Thread GitBox
anmolnar commented on a change in pull request #4125: URL: https://github.com/apache/hbase/pull/4125#discussion_r829219622 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServer.java ## @@ -181,4 +204,80 @@ public int getNumOpenConnections() {

[GitHub] [hbase] Apache-HBase commented on pull request #4220: HBASE-26834 Adapt ConnectionRule for both sync and async connections (branch-2)

2022-03-17 Thread GitBox
Apache-HBase commented on pull request #4220: URL: https://github.com/apache/hbase/pull/4220#issuecomment-1071005583 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Resolved] (HBASE-26833) Avoid waiting to clear buffer usage of ReplicationSourceShipper when aborting the RS

2022-03-17 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-26833. --- Hadoop Flags: Reviewed Resolution: Fixed Pushed addendum to branch-2.4+. > Avoid waiting to

[jira] [Reopened] (HBASE-26833) Avoid waiting to clear buffer usage of ReplicationSourceShipper when aborting the RS

2022-03-17 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reopened HBASE-26833: --- Reopen for applying an addendum. It introduces NPE in TestReplicationSource.testTerminateClearsBuffer.

[jira] [Commented] (HBASE-26720) ExportSnapshot should validate the source snapshot before copying files

2022-03-17 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17508226#comment-17508226 ] Hudson commented on HBASE-26720: Results for branch branch-2.5 [build #66 on

[jira] [Commented] (HBASE-26680) Close and do not write trailer for the broken WAL writer

2022-03-17 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17508225#comment-17508225 ] Hudson commented on HBASE-26680: Results for branch branch-2.5 [build #66 on

[jira] [Commented] (HBASE-26813) Remove javax.ws.rs-api dependency

2022-03-17 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17508228#comment-17508228 ] Hudson commented on HBASE-26813: Results for branch branch-2.5 [build #66 on

[jira] [Commented] (HBASE-26828) Increase the concurrency when running UTs in pre commit job

2022-03-17 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17508227#comment-17508227 ] Hudson commented on HBASE-26828: Results for branch branch-2.5 [build #66 on

[jira] [Commented] (HBASE-26848) Set java.io.tmpdir on mvn command when running jenkins job

2022-03-17 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17508224#comment-17508224 ] Hudson commented on HBASE-26848: Results for branch branch-2.5 [build #66 on

[jira] [Resolved] (HBASE-26852) --hadoop-profile is not honored in branch-2 PR builds

2022-03-17 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-26852. -- Resolution: Invalid I believe this was broken by the syntax error introduced and subsequently

[GitHub] [hbase] Apache-HBase edited a comment on pull request #4220: HBASE-26834 Adapt ConnectionRule for both sync and async connections (branch-2)

2022-03-17 Thread GitBox
Apache-HBase edited a comment on pull request #4220: URL: https://github.com/apache/hbase/pull/4220#issuecomment-1069210615 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec

[jira] [Commented] (HBASE-26812) ShortCircuitingClusterConnection fails to close RegionScanners when making short-circuited calls

2022-03-17 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17508222#comment-17508222 ] chenglei commented on HBASE-26812: -- Ok, I would try to fix it for branch-2. >

[GitHub] [hbase] Apache-HBase edited a comment on pull request #4220: HBASE-26834 Adapt ConnectionRule for both sync and async connections (branch-2)

2022-03-17 Thread GitBox
Apache-HBase edited a comment on pull request #4220: URL: https://github.com/apache/hbase/pull/4220#issuecomment-1069119243 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec

[GitHub] [hbase] Apache-HBase edited a comment on pull request #4220: HBASE-26834 Adapt ConnectionRule for both sync and async connections (branch-2)

2022-03-17 Thread GitBox
Apache-HBase edited a comment on pull request #4220: URL: https://github.com/apache/hbase/pull/4220#issuecomment-1069106207 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec |

[GitHub] [hbase] Apache-HBase edited a comment on pull request #4220: HBASE-26834 Adapt ConnectionRule for both sync and async connections (branch-2)

2022-03-17 Thread GitBox
Apache-HBase edited a comment on pull request #4220: URL: https://github.com/apache/hbase/pull/4220#issuecomment-1069101366 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec |

[GitHub] [hbase] Apache-HBase edited a comment on pull request #4220: HBASE-26834 Adapt ConnectionRule for both sync and async connections (branch-2)

2022-03-17 Thread GitBox
Apache-HBase edited a comment on pull request #4220: URL: https://github.com/apache/hbase/pull/4220#issuecomment-1069094348 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec |

[GitHub] [hbase] Apache-HBase edited a comment on pull request #4220: HBASE-26834 Adapt ConnectionRule for both sync and async connections (branch-2)

2022-03-17 Thread GitBox
Apache-HBase edited a comment on pull request #4220: URL: https://github.com/apache/hbase/pull/4220#issuecomment-1067133658 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec |

[jira] [Commented] (HBASE-26848) Set java.io.tmpdir on mvn command when running jenkins job

2022-03-17 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17508219#comment-17508219 ] Hudson commented on HBASE-26848: Results for branch branch-2 [build #488 on

[GitHub] [hbase] Apache-HBase edited a comment on pull request #4220: HBASE-26834 Adapt ConnectionRule for both sync and async connections (branch-2)

2022-03-17 Thread GitBox
Apache-HBase edited a comment on pull request #4220: URL: https://github.com/apache/hbase/pull/4220#issuecomment-1069201229 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec |

[GitHub] [hbase] Apache-HBase edited a comment on pull request #4220: HBASE-26834 Adapt ConnectionRule for both sync and async connections (branch-2)

2022-03-17 Thread GitBox
Apache-HBase edited a comment on pull request #4220: URL: https://github.com/apache/hbase/pull/4220#issuecomment-1069228999 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec |

[jira] [Commented] (HBASE-26848) Set java.io.tmpdir on mvn command when running jenkins job

2022-03-17 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17508217#comment-17508217 ] Hudson commented on HBASE-26848: Results for branch branch-2.4 [build #310 on

[GitHub] [hbase] wchevreuil commented on pull request #4223: HBASE-26838 Junit jar is not included in the hbase tar ball, causing …

2022-03-17 Thread GitBox
wchevreuil commented on pull request #4223: URL: https://github.com/apache/hbase/pull/4223#issuecomment-1070946146 > If we want to ship the IntegrationTest classes in our binary distribution, what we need to do is restructure hbase-it so that the IntegrationTest jars are in

[GitHub] [hbase] Apache9 commented on a change in pull request #4223: HBASE-26838 Junit jar is not included in the hbase tar ball, causing …

2022-03-17 Thread GitBox
Apache9 commented on a change in pull request #4223: URL: https://github.com/apache/hbase/pull/4223#discussion_r829130074 ## File path: hbase-assembly/src/main/assembly/hadoop-three-compat.xml ## @@ -261,6 +262,14 @@ io.opentelemetry.javaagent:* + +

[GitHub] [hbase] wchevreuil commented on a change in pull request #4223: HBASE-26838 Junit jar is not included in the hbase tar ball, causing …

2022-03-17 Thread GitBox
wchevreuil commented on a change in pull request #4223: URL: https://github.com/apache/hbase/pull/4223#discussion_r829127313 ## File path: hbase-assembly/src/main/assembly/hadoop-three-compat.xml ## @@ -261,6 +262,14 @@ io.opentelemetry.javaagent:* + +

[jira] [Created] (HBASE-26858) Refactor TestMasterRegionOnTwoFileSystems to avoid dead loop

2022-03-17 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-26858: - Summary: Refactor TestMasterRegionOnTwoFileSystems to avoid dead loop Key: HBASE-26858 URL: https://issues.apache.org/jira/browse/HBASE-26858 Project: HBase

[jira] [Commented] (HBASE-26848) Set java.io.tmpdir on mvn command when running jenkins job

2022-03-17 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17508189#comment-17508189 ] Duo Zhang commented on HBASE-26848: --- There are two stderr files on hbase3 {noformat}

[GitHub] [hbase] anmolnar commented on a change in pull request #4125: HBASE-26666 Add native TLS encryption support to RPC server/client

2022-03-17 Thread GitBox
anmolnar commented on a change in pull request #4125: URL: https://github.com/apache/hbase/pull/4125#discussion_r829044839 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java ## @@ -297,11 +295,10 @@ public void

[GitHub] [hbase] anmolnar commented on a change in pull request #4125: HBASE-26666 Add native TLS encryption support to RPC server/client

2022-03-17 Thread GitBox
anmolnar commented on a change in pull request #4125: URL: https://github.com/apache/hbase/pull/4125#discussion_r829044839 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java ## @@ -297,11 +295,10 @@ public void

[GitHub] [hbase] Apache-HBase commented on pull request #4237: HBASE-26851 [Documentation] Point out compatibility issues with WAL Compression and Replication in doc

2022-03-17 Thread GitBox
Apache-HBase commented on pull request #4237: URL: https://github.com/apache/hbase/pull/4237#issuecomment-1070664707 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #4237: HBASE-26851 [Documentation] Point out compatibility issues with WAL Compression and Replication in doc

2022-03-17 Thread GitBox
Apache-HBase commented on pull request #4237: URL: https://github.com/apache/hbase/pull/4237#issuecomment-1070631696 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

  1   2   >