[GitHub] [hbase] Apache-HBase commented on pull request #4725: HBASE-27152 Under compaction mark may leak

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4725: URL: https://github.com/apache/hbase/pull/4725#issuecomment-1225216460 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 39s |

[jira] [Commented] (HBASE-27152) Under compaction mark may leak

2022-08-23 Thread Xiaolin Ha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583993#comment-17583993 ] Xiaolin Ha commented on HBASE-27152: Hi, [~zhangduo] , it's an issue about the pool.submit and

[jira] (HBASE-27152) Under compaction mark may leak

2022-08-23 Thread Xiaolin Ha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27152 ] Xiaolin Ha deleted comment on HBASE-27152: was (Author: xiaolin ha): [~zhangduo] I ran it locally several times and all passed, is there any more error info?  > Under compaction mark may

[GitHub] [hbase] Apache-HBase commented on pull request #4713: HBASE-27304 Support using IP to expose master/rs servers for some special scenarios

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4713: URL: https://github.com/apache/hbase/pull/4713#issuecomment-1225180860 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s |

[jira] [Commented] (HBASE-20904) Prometheus /metrics http endpoint for monitoring integration

2022-08-23 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-20904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583971#comment-17583971 ] Duo Zhang commented on HBASE-20904: --- [~lkovacs] Please remember to fill the release note as this is a

[jira] [Resolved] (HBASE-20904) Prometheus /metrics http endpoint for monitoring integration

2022-08-23 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-20904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-20904. --- Fix Version/s: 2.6.0 3.0.0-alpha-4 Hadoop Flags: Reviewed Resolution:

[jira] [Assigned] (HBASE-20904) Prometheus /metrics http endpoint for monitoring integration

2022-08-23 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-20904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-20904: - Assignee: Luca Kovacs (was: Madhusoodan) > Prometheus /metrics http endpoint for monitoring

[GitHub] [hbase] Apache9 closed pull request #1814: HBASE-20904 Prometheus /metrics http endpoint for monitoring

2022-08-23 Thread GitBox
Apache9 closed pull request #1814: HBASE-20904 Prometheus /metrics http endpoint for monitoring URL: https://github.com/apache/hbase/pull/1814 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hbase] Apache-HBase commented on pull request #4721: HBASE-27231 FSHLog should retry writing WAL entries when syncs to HDF…

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4721: URL: https://github.com/apache/hbase/pull/4721#issuecomment-1225132746 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 7s |

[GitHub] [hbase] YutSean commented on pull request #4657: HBASE-27246 RSGroupMappingScript#getRSGroup has thread safety problem

2022-08-23 Thread GitBox
YutSean commented on PR #4657: URL: https://github.com/apache/hbase/pull/4657#issuecomment-1225131188 > Please run spotless:apply to fix the style issue? > > Thanks. Sorry for the delay, but has already run the spotless to fix the style. -- This is an automated message from

[GitHub] [hbase] Apache9 commented on pull request #4716: HBASE-27312 Update create-release to work with maven-gpg-plugin-3.0.1 and gnupg >= 2.1.x

2022-08-23 Thread GitBox
Apache9 commented on PR #4716: URL: https://github.com/apache/hbase/pull/4716#issuecomment-1225129303 > > I also changed the script locally to use `agent-socket` instead of `agent-extra-socket` but probably this is just a different usage. > > I own the build machine so I can put the

[GitHub] [hbase] Apache-HBase commented on pull request #4657: HBASE-27246 RSGroupMappingScript#getRSGroup has thread safety problem

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4657: URL: https://github.com/apache/hbase/pull/4657#issuecomment-1225125258 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

[GitHub] [hbase] Apache9 merged pull request #4691: HBASE-20904 Prometheus /metrics http endpoint for monitoring

2022-08-23 Thread GitBox
Apache9 merged PR #4691: URL: https://github.com/apache/hbase/pull/4691 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HBASE-27321) The ReplicationLogCleaner is not thread safe but can be called from different thread at the same time

2022-08-23 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583957#comment-17583957 ] Duo Zhang commented on HBASE-27321: --- I think either we change ReplicationLogCleaner to be thread safe,

[jira] [Updated] (HBASE-27321) The ReplicationLogCleaner is not thread safe but can be called from different thread at the same time

2022-08-23 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-27321: -- Component/s: master Replication > The ReplicationLogCleaner is not thread safe but

[jira] [Created] (HBASE-27321) The ReplicationLogCleaner is not thread safe but can be called from different thread at the same time

2022-08-23 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-27321: - Summary: The ReplicationLogCleaner is not thread safe but can be called from different thread at the same time Key: HBASE-27321 URL: https://issues.apache.org/jira/browse/HBASE-27321

[jira] [Commented] (HBASE-27303) Unnecessary replication to secondary region replicas should avoid when WAL.sync throws Exception

2022-08-23 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583952#comment-17583952 ] chenglei commented on HBASE-27303: -- Pushed to matser, thanks [~zhangduo] for reviewing. > Unnecessary

[jira] [Updated] (HBASE-27303) Unnecessary replication to secondary region replicas should avoid when WAL.sync throws Exception

2022-08-23 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenglei updated HBASE-27303: - Fix Version/s: 3.0.0-alpha-4 Resolution: Fixed Status: Resolved (was: Patch

[GitHub] [hbase] comnetwork merged pull request #4707: HBASE-27303 Unnecessary replication to secondary region replicas shou…

2022-08-23 Thread GitBox
comnetwork merged PR #4707: URL: https://github.com/apache/hbase/pull/4707 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] Apache-HBase commented on pull request #4713: HBASE-27304 Support using IP to expose master/rs servers for some special scenarios

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4713: URL: https://github.com/apache/hbase/pull/4713#issuecomment-1225027236 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 9s |

[GitHub] [hbase] Apache-HBase commented on pull request #4713: HBASE-27304 Support using IP to expose master/rs servers for some special scenarios

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4713: URL: https://github.com/apache/hbase/pull/4713#issuecomment-1225014429 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s |

[GitHub] [hbase] Apache-HBase commented on pull request #4721: HBASE-27231 FSHLog should retry writing WAL entries when syncs to HDF…

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4721: URL: https://github.com/apache/hbase/pull/4721#issuecomment-1224967414 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 0s |

[GitHub] [hbase] Apache-HBase commented on pull request #4724: HBASE-27280 Add mutual authentication support to TLS

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4724: URL: https://github.com/apache/hbase/pull/4724#issuecomment-1224965827 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 5m 40s |

[GitHub] [hbase] Apache-HBase commented on pull request #4724: HBASE-27280 Add mutual authentication support to TLS

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4724: URL: https://github.com/apache/hbase/pull/4724#issuecomment-1224959936 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s |

[GitHub] [hbase] Apache-HBase commented on pull request #4724: HBASE-27280 Add mutual authentication support to TLS

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4724: URL: https://github.com/apache/hbase/pull/4724#issuecomment-1224959295 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

[jira] [Commented] (HBASE-27305) add an option to skip file splitting when bulkload hfiles

2022-08-23 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583874#comment-17583874 ] Hudson commented on HBASE-27305: Results for branch master [build #664 on

[jira] [Commented] (HBASE-27311) The implementation of syncReplicationPeerLock is incomplete

2022-08-23 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583875#comment-17583875 ] Hudson commented on HBASE-27311: Results for branch master [build #664 on

[GitHub] [hbase] bbeaudreault opened a new pull request, #4724: HBASE-27280 Add mutual authentication support to TLS

2022-08-23 Thread GitBox
bbeaudreault opened a new pull request, #4724: URL: https://github.com/apache/hbase/pull/4724 As with the rest of the netty tls stuff, this is largely pulled and adapted from ZK. This adds support for setting netty's ClientAuth mode (none, need, want) which will handle the cert

[GitHub] [hbase] Apache-HBase commented on pull request #4721: HBASE-27231 FSHLog should retry writing WAL entries when syncs to HDF…

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4721: URL: https://github.com/apache/hbase/pull/4721#issuecomment-1224922380 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 20s |

[GitHub] [hbase] Apache-HBase commented on pull request #4713: HBASE-27304 Support using IP to expose master/rs servers for some special scenarios

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4713: URL: https://github.com/apache/hbase/pull/4713#issuecomment-1224886209 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

[GitHub] [hbase] taklwu commented on pull request #4697: HBASE-27297 "HBASE-26810 Add dynamic configuration support for system…

2022-08-23 Thread GitBox
taklwu commented on PR #4697: URL: https://github.com/apache/hbase/pull/4697#issuecomment-1224880673 thanks Nick and Duo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [hbase] Apache-HBase commented on pull request #4713: HBASE-27304 Support using IP to expose master/rs servers for some special scenarios

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4713: URL: https://github.com/apache/hbase/pull/4713#issuecomment-1224840574 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 47s |

[GitHub] [hbase] Apache-HBase commented on pull request #4713: HBASE-27304 Support using IP to expose master/rs servers for some special scenarios

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4713: URL: https://github.com/apache/hbase/pull/4713#issuecomment-1224801850 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s |

[jira] [Commented] (HBASE-27104) Add a tool command list_unknownservers

2022-08-23 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583831#comment-17583831 ] Hudson commented on HBASE-27104: Results for branch branch-2.5 [build #193 on

[jira] [Commented] (HBASE-27305) add an option to skip file splitting when bulkload hfiles

2022-08-23 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583832#comment-17583832 ] Hudson commented on HBASE-27305: Results for branch branch-2.5 [build #193 on

[GitHub] [hbase] Apache-HBase commented on pull request #4721: HBASE-27231 FSHLog should retry writing WAL entries when syncs to HDF…

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4721: URL: https://github.com/apache/hbase/pull/4721#issuecomment-1224578971 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 20s |

[GitHub] [hbase] Apache-HBase commented on pull request #4721: HBASE-27231 FSHLog should retry writing WAL entries when syncs to HDF…

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4721: URL: https://github.com/apache/hbase/pull/4721#issuecomment-1224499757 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

[GitHub] [hbase] Apache-HBase commented on pull request #4721: HBASE-27231 FSHLog should retry writing WAL entries when syncs to HDF…

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4721: URL: https://github.com/apache/hbase/pull/4721#issuecomment-1224466753 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

[GitHub] [hbase] Apache-HBase commented on pull request #4723: HBASE-27320 hide some sensitive configuration information in the UI

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4723: URL: https://github.com/apache/hbase/pull/4723#issuecomment-1224439677 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

[GitHub] [hbase] Apache-HBase commented on pull request #4723: HBASE-27320 hide some sensitive configuration information in the UI

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4723: URL: https://github.com/apache/hbase/pull/4723#issuecomment-1224429421 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s |

[GitHub] [hbase] Apache-HBase commented on pull request #4723: HBASE-27320 hide some sensitive configuration information in the UI

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4723: URL: https://github.com/apache/hbase/pull/4723#issuecomment-1224427823 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 5s |

[jira] [Created] (HBASE-27320) hide some sensitive configuration information in the UI

2022-08-23 Thread ruanhui (Jira)
ruanhui created HBASE-27320: --- Summary: hide some sensitive configuration information in the UI Key: HBASE-27320 URL: https://issues.apache.org/jira/browse/HBASE-27320 Project: HBase Issue Type:

[GitHub] [hbase] Apache-HBase commented on pull request #4713: HBASE-27304 Support using IP to expose master/rs servers for some special scenarios

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4713: URL: https://github.com/apache/hbase/pull/4713#issuecomment-1224362977 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 32s |

[GitHub] [hbase] Apache-HBase commented on pull request #4720: HBASE-27315 Add timeout to JavaRegexEngine

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4720: URL: https://github.com/apache/hbase/pull/4720#issuecomment-1224350439 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3s |

[GitHub] [hbase] Apache-HBase commented on pull request #4720: HBASE-27315 Add timeout to JavaRegexEngine

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4720: URL: https://github.com/apache/hbase/pull/4720#issuecomment-1224341398 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s |

[GitHub] [hbase] 2005hithlj commented on a diff in pull request #4713: HBASE-27304 Support using IP to expose master/rs servers for some special scenarios

2022-08-23 Thread GitBox
2005hithlj commented on code in PR #4713: URL: https://github.com/apache/hbase/pull/4713#discussion_r952865546 ## hbase-server/src/main/java/org/apache/hadoop/hbase/util/RegionMover.java: ## @@ -181,6 +184,19 @@ public RegionMoverBuilder(String hostname, Configuration conf) {

[jira] [Commented] (HBASE-27301) Add Delete addFamilyVersion timestamp verify

2022-08-23 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583730#comment-17583730 ] Huaxiang Sun commented on HBASE-27301: -- I went through the Jira list again. What happened is that

[jira] [Updated] (HBASE-27301) Add Delete addFamilyVersion timestamp verify

2022-08-23 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun updated HBASE-27301: - Fix Version/s: 2.4.14 (was: 2.4.13) > Add Delete addFamilyVersion

[GitHub] [hbase] Apache-HBase commented on pull request #4722: HBASE-27214 Implement the new replication hfile/log cleaner

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4722: URL: https://github.com/apache/hbase/pull/4722#issuecomment-1224292458 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 48s |

[jira] [Updated] (HBASE-27125) The batch size of cleaning expired mob files should have an upper bound

2022-08-23 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun updated HBASE-27125: - Fix Version/s: 2.4.13 (was: 2.4.14) > The batch size of cleaning expired

[jira] [Commented] (HBASE-27125) The batch size of cleaning expired mob files should have an upper bound

2022-08-23 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583723#comment-17583723 ] Huaxiang Sun commented on HBASE-27125: -- This was released in 2.4.13, due to fix scope error, it was

[jira] [Commented] (HBASE-27129) Add a config that allows us to configure region-level storage policies

2022-08-23 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583722#comment-17583722 ] Huaxiang Sun commented on HBASE-27129: -- Remove 2.4.13 from the fixed version as it is only in 2.5+.

[jira] [Updated] (HBASE-27129) Add a config that allows us to configure region-level storage policies

2022-08-23 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun updated HBASE-27129: - Fix Version/s: (was: 2.4.14) > Add a config that allows us to configure region-level

[GitHub] [hbase] Apache-HBase commented on pull request #4718: HBASE-27314 Make index block be customized and configured

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4718: URL: https://github.com/apache/hbase/pull/4718#issuecomment-1224274119 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 6s |

[GitHub] [hbase] Apache-HBase commented on pull request #4718: HBASE-27314 Make index block be customized and configured

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4718: URL: https://github.com/apache/hbase/pull/4718#issuecomment-1224273527 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 6s |

[jira] [Created] (HBASE-27319) Fix RC calculation in create-release

2022-08-23 Thread Nick Dimiduk (Jira)
Nick Dimiduk created HBASE-27319: Summary: Fix RC calculation in create-release Key: HBASE-27319 URL: https://issues.apache.org/jira/browse/HBASE-27319 Project: HBase Issue Type: Task

[jira] [Commented] (HBASE-27301) Add Delete addFamilyVersion timestamp verify

2022-08-23 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583704#comment-17583704 ] Huaxiang Sun commented on HBASE-27301: -- Sorry to miss your message, [~zhangduo] . I may marked the

[jira] [Updated] (HBASE-27312) Update create-release to work with maven-gpg-plugin-3.0.1 and gnupg >= 2.1.x

2022-08-23 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-27312: - Status: Patch Available (was: Open) > Update create-release to work with

[jira] [Assigned] (HBASE-27312) Update create-release to work with maven-gpg-plugin-3.0.1 and gnupg >= 2.1.x

2022-08-23 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk reassigned HBASE-27312: Assignee: Nick Dimiduk > Update create-release to work with maven-gpg-plugin-3.0.1 and

[GitHub] [hbase] ndimiduk commented on a diff in pull request #4716: HBASE-27312 Update create-release to work with maven-gpg-plugin-3.0.1 and gnupg >= 2.1.x

2022-08-23 Thread GitBox
ndimiduk commented on code in PR #4716: URL: https://github.com/apache/hbase/pull/4716#discussion_r952753036 ## dev-support/create-release/README.txt: ## @@ -105,6 +105,9 @@ $ scp ~/gpg.example.apache.pub example.gce.host: # gpg-agent's extra socket (this will restrict what

[GitHub] [hbase] Apache-HBase commented on pull request #4691: HBASE-20904 Prometheus /metrics http endpoint for monitoring

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4691: URL: https://github.com/apache/hbase/pull/4691#issuecomment-1224222519 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

[GitHub] [hbase] Apache-HBase commented on pull request #4722: HBASE-27214 Implement the new replication hfile/log cleaner

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4722: URL: https://github.com/apache/hbase/pull/4722#issuecomment-1224218054 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s |

[GitHub] [hbase] comnetwork commented on a diff in pull request #4707: HBASE-27303 Unnecessary replication to secondary region replicas shou…

2022-08-23 Thread GitBox
comnetwork commented on code in PR #4707: URL: https://github.com/apache/hbase/pull/4707#discussion_r952689280 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java: ## @@ -8040,11 +8040,17 @@ private WriteEntry doWALAppend(WALEdit walEdit,

[GitHub] [hbase] comnetwork commented on a diff in pull request #4707: HBASE-27303 Unnecessary replication to secondary region replicas shou…

2022-08-23 Thread GitBox
comnetwork commented on code in PR #4707: URL: https://github.com/apache/hbase/pull/4707#discussion_r952689280 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java: ## @@ -8040,11 +8040,17 @@ private WriteEntry doWALAppend(WALEdit walEdit,

[GitHub] [hbase] Apache-HBase commented on pull request #4660: HBASE-27249 Remove invalid peer RegionServer crash

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4660: URL: https://github.com/apache/hbase/pull/4660#issuecomment-1224213083 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s |

[GitHub] [hbase] comnetwork commented on a diff in pull request #4707: HBASE-27303 Unnecessary replication to secondary region replicas shou…

2022-08-23 Thread GitBox
comnetwork commented on code in PR #4707: URL: https://github.com/apache/hbase/pull/4707#discussion_r952689280 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java: ## @@ -8040,11 +8040,17 @@ private WriteEntry doWALAppend(WALEdit walEdit,

[GitHub] [hbase] ndimiduk commented on pull request #4716: HBASE-27312 Update create-release to work with maven-gpg-plugin-3.0.1 and gnupg >= 2.1.x

2022-08-23 Thread GitBox
ndimiduk commented on PR #4716: URL: https://github.com/apache/hbase/pull/4716#issuecomment-1224209423 > I also changed the script locally to use `agent-socket` instead of `agent-extra-socket` but probably this is just a different usage. > > I own the build machine so I can put the

[GitHub] [hbase] Apache-HBase commented on pull request #4721: HBASE-27231 FSHLog should retry writing WAL entries when syncs to HDF…

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4721: URL: https://github.com/apache/hbase/pull/4721#issuecomment-1224175448 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 0s |

[GitHub] [hbase] Apache-HBase commented on pull request #4660: HBASE-27249 Remove invalid peer RegionServer crash

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4660: URL: https://github.com/apache/hbase/pull/4660#issuecomment-1224161435 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 17s |

[GitHub] [hbase] Apache9 commented on a diff in pull request #4707: HBASE-27303 Unnecessary replication to secondary region replicas shou…

2022-08-23 Thread GitBox
Apache9 commented on code in PR #4707: URL: https://github.com/apache/hbase/pull/4707#discussion_r952702359 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java: ## @@ -8040,11 +8040,17 @@ private WriteEntry doWALAppend(WALEdit walEdit,

[GitHub] [hbase] comnetwork commented on a diff in pull request #4707: HBASE-27303 Unnecessary replication to secondary region replicas shou…

2022-08-23 Thread GitBox
comnetwork commented on code in PR #4707: URL: https://github.com/apache/hbase/pull/4707#discussion_r952689280 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java: ## @@ -8040,11 +8040,17 @@ private WriteEntry doWALAppend(WALEdit walEdit,

[GitHub] [hbase] comnetwork commented on a diff in pull request #4707: HBASE-27303 Unnecessary replication to secondary region replicas shou…

2022-08-23 Thread GitBox
comnetwork commented on code in PR #4707: URL: https://github.com/apache/hbase/pull/4707#discussion_r952689280 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java: ## @@ -8040,11 +8040,17 @@ private WriteEntry doWALAppend(WALEdit walEdit,

[GitHub] [hbase] comnetwork commented on a diff in pull request #4707: HBASE-27303 Unnecessary replication to secondary region replicas shou…

2022-08-23 Thread GitBox
comnetwork commented on code in PR #4707: URL: https://github.com/apache/hbase/pull/4707#discussion_r952689280 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java: ## @@ -8040,11 +8040,17 @@ private WriteEntry doWALAppend(WALEdit walEdit,

[GitHub] [hbase] Apache-HBase commented on pull request #4721: HBASE-27231 FSHLog should retry writing WAL entries when syncs to HDF…

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4721: URL: https://github.com/apache/hbase/pull/4721#issuecomment-1224134855 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s |

[GitHub] [hbase] Apache-HBase commented on pull request #4721: HBASE-27231 FSHLog should retry writing WAL entries when syncs to HDF…

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4721: URL: https://github.com/apache/hbase/pull/4721#issuecomment-1224116426 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

[GitHub] [hbase] Apache-HBase commented on pull request #4717: HBASE-27226 Document native TLS support in Netty RPC

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4717: URL: https://github.com/apache/hbase/pull/4717#issuecomment-1224104672 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 22s |

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4717: HBASE-27226 Document native TLS support in Netty RPC

2022-08-23 Thread GitBox
bbeaudreault commented on code in PR #4717: URL: https://github.com/apache/hbase/pull/4717#discussion_r952642898 ## src/main/asciidoc/_chapters/security.adoc: ## @@ -675,6 +675,290 @@ For more information about ACLs, please see the

[jira] [Commented] (HBASE-27318) Configuration to allow client fallback to non-SSL if handshake fails

2022-08-23 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583638#comment-17583638 ] Duo Zhang commented on HBASE-27318: --- We should implement this, maybe a parameter to say whether the

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4717: HBASE-27226 Document native TLS support in Netty RPC

2022-08-23 Thread GitBox
bbeaudreault commented on code in PR #4717: URL: https://github.com/apache/hbase/pull/4717#discussion_r952642898 ## src/main/asciidoc/_chapters/security.adoc: ## @@ -675,6 +675,290 @@ For more information about ACLs, please see the

[GitHub] [hbase] Apache-HBase commented on pull request #4720: HBASE-27315 Add timeout to JavaRegexEngine

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4720: URL: https://github.com/apache/hbase/pull/4720#issuecomment-1224098694 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 8s |

[GitHub] [hbase] Apache-HBase commented on pull request #4717: HBASE-27226 Document native TLS support in Netty RPC

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4717: URL: https://github.com/apache/hbase/pull/4717#issuecomment-1224090657 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 35s |

[GitHub] [hbase] Apache-HBase commented on pull request #4717: HBASE-27226 Document native TLS support in Netty RPC

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4717: URL: https://github.com/apache/hbase/pull/4717#issuecomment-1224090084 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 16s |

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4717: HBASE-27226 Document native TLS support in Netty RPC

2022-08-23 Thread GitBox
bbeaudreault commented on code in PR #4717: URL: https://github.com/apache/hbase/pull/4717#discussion_r952634498 ## src/main/asciidoc/_chapters/security.adoc: ## @@ -675,6 +675,228 @@ For more information about ACLs, please see the

[jira] [Created] (HBASE-27318) Configuration to allow fallback to non-SSL if handshake fails

2022-08-23 Thread Bryan Beaudreault (Jira)
Bryan Beaudreault created HBASE-27318: - Summary: Configuration to allow fallback to non-SSL if handshake fails Key: HBASE-27318 URL: https://issues.apache.org/jira/browse/HBASE-27318 Project:

[jira] [Updated] (HBASE-27318) Configuration to allow client fallback to non-SSL if handshake fails

2022-08-23 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault updated HBASE-27318: -- Summary: Configuration to allow client fallback to non-SSL if handshake fails (was:

[GitHub] [hbase] anmolnar commented on pull request #4717: HBASE-27226 Document native TLS support in Netty RPC

2022-08-23 Thread GitBox
anmolnar commented on PR #4717: URL: https://github.com/apache/hbase/pull/4717#issuecomment-1224071916 @bbeaudreault Docs updated. Please re-validate the rolling upgrade steps. Hope I got it right. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] Apache-HBase commented on pull request #4720: HBASE-27315 Add timeout to JavaRegexEngine

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4720: URL: https://github.com/apache/hbase/pull/4720#issuecomment-1224054195 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 0s |

[GitHub] [hbase] Apache-HBase commented on pull request #4720: HBASE-27315 Add timeout to JavaRegexEngine

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4720: URL: https://github.com/apache/hbase/pull/4720#issuecomment-1224042588 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s |

[jira] [Updated] (HBASE-27152) Under compaction mark may leak

2022-08-23 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-27152: - Fix Version/s: 2.5.1 (was: 2.5.0) > Under compaction mark may leak >

[GitHub] [hbase] Apache-HBase commented on pull request #4718: HBASE-27314 Make index block be customized and configured

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4718: URL: https://github.com/apache/hbase/pull/4718#issuecomment-1224021954 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 56s |

[GitHub] [hbase] Apache-HBase commented on pull request #4691: HBASE-20904 Prometheus /metrics http endpoint for monitoring

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4691: URL: https://github.com/apache/hbase/pull/4691#issuecomment-1223996067 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 59s |

[jira] [Resolved] (HBASE-27297) Backport "HBASE-26810 Add dynamic configuration support for system coprocessors" to branch-2.5

2022-08-23 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-27297. -- Assignee: (was: Tak-Lon (Stephen) Wu) Resolution: Duplicate Resolved via

[jira] [Updated] (HBASE-26882) Backport "HBASE-26810 Add dynamic configuration support for system coprocessors" to branch-2

2022-08-23 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-26882: - Fix Version/s: (was: 2.6.0) > Backport "HBASE-26810 Add dynamic configuration support for

[jira] [Resolved] (HBASE-26882) Backport "HBASE-26810 Add dynamic configuration support for system coprocessors" to branch-2

2022-08-23 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-26882. -- Resolution: Fixed > Backport "HBASE-26810 Add dynamic configuration support for system >

[GitHub] [hbase] ndimiduk merged pull request #4697: HBASE-27297 "HBASE-26810 Add dynamic configuration support for system…

2022-08-23 Thread GitBox
ndimiduk merged PR #4697: URL: https://github.com/apache/hbase/pull/4697 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] Apache-HBase commented on pull request #4722: HBASE-27214 Implement the new replication hfile/log cleaner

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4722: URL: https://github.com/apache/hbase/pull/4722#issuecomment-1223957957 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 0s |

[GitHub] [hbase] comnetwork commented on pull request #4721: HBASE-27231 FSHLog should retry writing WAL entries when syncs to HDF…

2022-08-23 Thread GitBox
comnetwork commented on PR #4721: URL: https://github.com/apache/hbase/pull/4721#issuecomment-1223944185 @Apache9 ,thank you very much for point this out, yes, the original {{FSHLog.RingBufferEventHandler.onEvent}} which called {{FSHLog.append}} also have the same problem you described

[GitHub] [hbase] Apache-HBase commented on pull request #4722: HBASE-27214 Implement the new replication hfile/log cleaner

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4722: URL: https://github.com/apache/hbase/pull/4722#issuecomment-1223922959 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 1s |

[GitHub] [hbase] Apache-HBase commented on pull request #4722: HBASE-27214 Implement the new replication hfile/log cleaner

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4722: URL: https://github.com/apache/hbase/pull/4722#issuecomment-1223915230 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 45s |

[GitHub] [hbase] Apache-HBase commented on pull request #4721: HBASE-27231 FSHLog should retry writing WAL entries when syncs to HDF…

2022-08-23 Thread GitBox
Apache-HBase commented on PR #4721: URL: https://github.com/apache/hbase/pull/4721#issuecomment-1223906523 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 21s |

  1   2   >