[GitHub] [hbase] Apache-HBase commented on pull request #5038: HBASE-27650 Merging empty regions corrupts meta cache (branch-2)

2023-02-25 Thread via GitHub
Apache-HBase commented on PR #5038: URL: https://github.com/apache/hbase/pull/5038#issuecomment-1445289812 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 22s |

[GitHub] [hbase] Apache-HBase commented on pull request #5052: HBASE-27660 Ignore invalid hostname when getNetworkInterfaces

2023-02-25 Thread via GitHub
Apache-HBase commented on PR #5052: URL: https://github.com/apache/hbase/pull/5052#issuecomment-1445288708 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

[jira] [Work started] (HBASE-27668) PB's parseDelimitedFrom can successfully return when there are not enough bytes

2023-02-25 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-27668 started by Duo Zhang. - > PB's parseDelimitedFrom can successfully return when there are not enough > bytes

[jira] [Assigned] (HBASE-27668) PB's parseDelimitedFrom can successfully return when there are not enough bytes

2023-02-25 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-27668: - Assignee: Duo Zhang > PB's parseDelimitedFrom can successfully return when there are not

[GitHub] [hbase] Apache-HBase commented on pull request #5038: HBASE-27650 Merging empty regions corrupts meta cache (branch-2)

2023-02-25 Thread via GitHub
Apache-HBase commented on PR #5038: URL: https://github.com/apache/hbase/pull/5038#issuecomment-1445283774 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

[jira] [Created] (HBASE-27668) PB's parseDelimitedFrom can successfully return when there are not enough bytes

2023-02-25 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-27668: - Summary: PB's parseDelimitedFrom can successfully return when there are not enough bytes Key: HBASE-27668 URL: https://issues.apache.org/jira/browse/HBASE-27668 Project:

[jira] [Commented] (HBASE-27668) PB's parseDelimitedFrom can successfully return when there are not enough bytes

2023-02-25 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693593#comment-17693593 ] Duo Zhang commented on HBASE-27668: --- [~vjasani] FYI. > PB's parseDelimitedFrom can successfully

[GitHub] [hbase] Apache-HBase commented on pull request #5055: HBASE-27632 Refactor WAL.Reader implementation so we can better suppo…

2023-02-25 Thread via GitHub
Apache-HBase commented on PR #5055: URL: https://github.com/apache/hbase/pull/5055#issuecomment-1445278019 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s |

[jira] [Commented] (HBASE-27661) Set size of systable queue in UT

2023-02-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693589#comment-17693589 ] Hudson commented on HBASE-27661: Results for branch branch-2 [build #751 on

[jira] [Commented] (HBASE-15242) Client metrics for retries and timeouts

2023-02-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-15242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693588#comment-17693588 ] Hudson commented on HBASE-15242: Results for branch branch-2 [build #751 on

[GitHub] [hbase] Apache-HBase commented on pull request #5056: HBASE-27666 Allow preCompact hooks to return scanners whose cells can be shipped

2023-02-25 Thread via GitHub
Apache-HBase commented on PR #5056: URL: https://github.com/apache/hbase/pull/5056#issuecomment-1445274629 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

[GitHub] [hbase] Apache-HBase commented on pull request #5056: HBASE-27666 Allow preCompact hooks to return scanners whose cells can be shipped

2023-02-25 Thread via GitHub
Apache-HBase commented on PR #5056: URL: https://github.com/apache/hbase/pull/5056#issuecomment-1445274213 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 22s |

[GitHub] [hbase] Apache-HBase commented on pull request #5037: HBASE-27650 Merging empty regions corrupts meta cache

2023-02-25 Thread via GitHub
Apache-HBase commented on PR #5037: URL: https://github.com/apache/hbase/pull/5037#issuecomment-1445272073 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 19s |

[jira] [Updated] (HBASE-26708) Netty "leak detected" and OutOfDirectMemoryError due to direct memory buffering with SASL implementation

2023-02-25 Thread zhuobin zheng (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhuobin zheng updated HBASE-26708: -- Description: Under constant data ingestion, using default Netty based RpcServer and

[jira] [Commented] (HBASE-27661) Set size of systable queue in UT

2023-02-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693583#comment-17693583 ] Hudson commented on HBASE-27661: Results for branch branch-2.4 [build #519 on

[GitHub] [hbase] Apache-HBase commented on pull request #5038: HBASE-27650 Merging empty regions corrupts meta cache (branch-2)

2023-02-25 Thread via GitHub
Apache-HBase commented on PR #5038: URL: https://github.com/apache/hbase/pull/5038#issuecomment-1445262916 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

[GitHub] [hbase] Apache-HBase commented on pull request #5037: HBASE-27650 Merging empty regions corrupts meta cache

2023-02-25 Thread via GitHub
Apache-HBase commented on PR #5037: URL: https://github.com/apache/hbase/pull/5037#issuecomment-1445261870 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s |

[GitHub] [hbase] Apache-HBase commented on pull request #5038: HBASE-27650 Merging empty regions corrupts meta cache (branch-2)

2023-02-25 Thread via GitHub
Apache-HBase commented on PR #5038: URL: https://github.com/apache/hbase/pull/5038#issuecomment-1445258268 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 54s |

[GitHub] [hbase] Apache-HBase commented on pull request #5056: HBASE-27666 Allow preCompact hooks to return scanners whose cells can be shipped

2023-02-25 Thread via GitHub
Apache-HBase commented on PR #5056: URL: https://github.com/apache/hbase/pull/5056#issuecomment-1445254422 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 14s |

[GitHub] [hbase] Apache-HBase commented on pull request #5038: HBASE-27650 Merging empty regions corrupts meta cache (branch-2)

2023-02-25 Thread via GitHub
Apache-HBase commented on PR #5038: URL: https://github.com/apache/hbase/pull/5038#issuecomment-1445249610 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

[GitHub] [hbase] Apache-HBase commented on pull request #5056: HBASE-27666 Allow preCompact hooks to return scanners whose cells can be shipped

2023-02-25 Thread via GitHub
Apache-HBase commented on PR #5056: URL: https://github.com/apache/hbase/pull/5056#issuecomment-1445238929 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

[GitHub] [hbase] Apache-HBase commented on pull request #5056: HBASE-27666 Allow preCompact hooks to return scanners whose cells can be shipped

2023-02-25 Thread via GitHub
Apache-HBase commented on PR #5056: URL: https://github.com/apache/hbase/pull/5056#issuecomment-1445238625 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

[GitHub] [hbase] Apache-HBase commented on pull request #5037: HBASE-27650 Merging empty regions corrupts meta cache

2023-02-25 Thread via GitHub
Apache-HBase commented on PR #5037: URL: https://github.com/apache/hbase/pull/5037#issuecomment-1445236658 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 55s |

[GitHub] [hbase] Apache-HBase commented on pull request #5038: HBASE-27650 Merging empty regions corrupts meta cache (branch-2)

2023-02-25 Thread via GitHub
Apache-HBase commented on PR #5038: URL: https://github.com/apache/hbase/pull/5038#issuecomment-1445224566 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

[GitHub] [hbase] Apache-HBase commented on pull request #5037: HBASE-27650 Merging empty regions corrupts meta cache

2023-02-25 Thread via GitHub
Apache-HBase commented on PR #5037: URL: https://github.com/apache/hbase/pull/5037#issuecomment-1445219620 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s |

[GitHub] [hbase] Apache-HBase commented on pull request #5056: HBASE-27666 Allow preCompact hooks to return scanners whose cells can be shipped

2023-02-25 Thread via GitHub
Apache-HBase commented on PR #5056: URL: https://github.com/apache/hbase/pull/5056#issuecomment-1445213684 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 51s |

[GitHub] [hbase] Apache-HBase commented on pull request #5038: HBASE-27650 Merging empty regions corrupts meta cache (branch-2)

2023-02-25 Thread via GitHub
Apache-HBase commented on PR #5038: URL: https://github.com/apache/hbase/pull/5038#issuecomment-1445213555 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

[GitHub] [hbase] Apache-HBase commented on pull request #5038: HBASE-27650 Merging empty regions corrupts meta cache (branch-2)

2023-02-25 Thread via GitHub
Apache-HBase commented on PR #5038: URL: https://github.com/apache/hbase/pull/5038#issuecomment-1445213213 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

[GitHub] [hbase] Apache-HBase commented on pull request #5038: HBASE-27650 Merging empty regions corrupts meta cache (branch-2)

2023-02-25 Thread via GitHub
Apache-HBase commented on PR #5038: URL: https://github.com/apache/hbase/pull/5038#issuecomment-1445213032 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 30s |

[GitHub] [hbase] Apache-HBase commented on pull request #5037: HBASE-27650 Merging empty regions corrupts meta cache

2023-02-25 Thread via GitHub
Apache-HBase commented on PR #5037: URL: https://github.com/apache/hbase/pull/5037#issuecomment-1445211350 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 51s |

[GitHub] [hbase] Apache-HBase commented on pull request #5055: HBASE-27632 Refactor WAL.Reader implementation so we can better suppo…

2023-02-25 Thread via GitHub
Apache-HBase commented on PR #5055: URL: https://github.com/apache/hbase/pull/5055#issuecomment-1445209255 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

[GitHub] [hbase] Apache-HBase commented on pull request #5056: HBASE-27666 Allow preCompact hooks to return scanners whose cells can be shipped

2023-02-25 Thread via GitHub
Apache-HBase commented on PR #5056: URL: https://github.com/apache/hbase/pull/5056#issuecomment-1445207398 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 5m 25s |

[GitHub] [hbase] Apache-HBase commented on pull request #5051: HBASE-26874 VerifyReplication recompare async

2023-02-25 Thread via GitHub
Apache-HBase commented on PR #5051: URL: https://github.com/apache/hbase/pull/5051#issuecomment-1445206751 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

[GitHub] [hbase] Apache-HBase commented on pull request #5051: HBASE-26874 VerifyReplication recompare async

2023-02-25 Thread via GitHub
Apache-HBase commented on PR #5051: URL: https://github.com/apache/hbase/pull/5051#issuecomment-1445205128 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

[GitHub] [hbase] Apache-HBase commented on pull request #5051: HBASE-26874 VerifyReplication recompare async

2023-02-25 Thread via GitHub
Apache-HBase commented on PR #5051: URL: https://github.com/apache/hbase/pull/5051#issuecomment-1445204961 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 22s |

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #5051: HBASE-26874 VerifyReplication recompare async

2023-02-25 Thread via GitHub
bbeaudreault commented on code in PR #5051: URL: https://github.com/apache/hbase/pull/5051#discussion_r1117976005 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplication.java: ## @@ -240,55 +266,138 @@ public void

[GitHub] [hbase] Apache-HBase commented on pull request #5056: HBASE-27666 Allow preCompact hooks to return scanners whose cells can be shipped

2023-02-25 Thread via GitHub
Apache-HBase commented on PR #5056: URL: https://github.com/apache/hbase/pull/5056#issuecomment-1445201991 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s |

[GitHub] [hbase] Apache-HBase commented on pull request #5055: HBASE-27632 Refactor WAL.Reader implementation so we can better suppo…

2023-02-25 Thread via GitHub
Apache-HBase commented on PR #5055: URL: https://github.com/apache/hbase/pull/5055#issuecomment-1445198970 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 5m 11s |

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #5051: HBASE-26874 VerifyReplication recompare async

2023-02-25 Thread via GitHub
bbeaudreault commented on code in PR #5051: URL: https://github.com/apache/hbase/pull/5051#discussion_r1117974033 ## hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/replication/TestVerifyReplication.java: ## @@ -447,6 +447,36 @@ public void

[jira] [Assigned] (HBASE-27666) Allow preCompact hooks to return scanners whose cells can be shipped

2023-02-25 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault reassigned HBASE-27666: - Assignee: Bryan Beaudreault > Allow preCompact hooks to return scanners whose

[jira] [Updated] (HBASE-27666) Allow preCompact hooks to return scanners whose cells can be shipped

2023-02-25 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault updated HBASE-27666: -- Labels: patch-available (was: ) Status: Patch Available (was: Open) > Allow

[jira] [Updated] (HBASE-27649) WALPlayer does not properly dedupe overridden cell versions

2023-02-25 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault updated HBASE-27649: -- Fix Version/s: 2.6.0 3.0.0-alpha-4 2.5.4

[jira] [Commented] (HBASE-15242) Client metrics for retries and timeouts

2023-02-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-15242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693521#comment-17693521 ] Hudson commented on HBASE-15242: Results for branch branch-2.5 [build #304 on

[GitHub] [hbase] bbeaudreault merged pull request #5058: HBASE-27649 WALPlayer does not properly dedupe overridden cell versions

2023-02-25 Thread via GitHub
bbeaudreault merged PR #5058: URL: https://github.com/apache/hbase/pull/5058 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HBASE-15242) Client metrics for retries and timeouts

2023-02-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-15242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693517#comment-17693517 ] Hudson commented on HBASE-15242: Results for branch master [build #782 on

[GitHub] [hbase] Apache-HBase commented on pull request #5037: HBASE-27650 Merging empty regions corrupts meta cache

2023-02-25 Thread via GitHub
Apache-HBase commented on PR #5037: URL: https://github.com/apache/hbase/pull/5037#issuecomment-1445176027 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

[GitHub] [hbase] Apache-HBase commented on pull request #5058: HBASE-27649 WALPlayer does not properly dedupe overridden cell versions

2023-02-25 Thread via GitHub
Apache-HBase commented on PR #5058: URL: https://github.com/apache/hbase/pull/5058#issuecomment-1445170635 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s |

[GitHub] [hbase] Apache-HBase commented on pull request #5058: HBASE-27649 WALPlayer does not properly dedupe overridden cell versions

2023-02-25 Thread via GitHub
Apache-HBase commented on PR #5058: URL: https://github.com/apache/hbase/pull/5058#issuecomment-1445170036 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 22s |

[GitHub] [hbase] Apache-HBase commented on pull request #5058: HBASE-27649 WALPlayer does not properly dedupe overridden cell versions

2023-02-25 Thread via GitHub
Apache-HBase commented on PR #5058: URL: https://github.com/apache/hbase/pull/5058#issuecomment-1445169045 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 49s |

[GitHub] [hbase] Apache-HBase commented on pull request #5037: HBASE-27650 Merging empty regions corrupts meta cache

2023-02-25 Thread via GitHub
Apache-HBase commented on PR #5037: URL: https://github.com/apache/hbase/pull/5037#issuecomment-1445165477 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 20s |

[GitHub] [hbase] Apache-HBase commented on pull request #5056: HBASE-27666 Allow preCompact hooks to return scanners whose cells can be shipped

2023-02-25 Thread via GitHub
Apache-HBase commented on PR #5056: URL: https://github.com/apache/hbase/pull/5056#issuecomment-1445164397 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 58s |

[GitHub] [hbase] bbeaudreault opened a new pull request, #5058: HBASE-27649 WALPlayer does not properly dedupe overridden cell versions

2023-02-25 Thread via GitHub
bbeaudreault opened a new pull request, #5058: URL: https://github.com/apache/hbase/pull/5058 Re-submit of #5047 with bad commits dropped. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hbase] bbeaudreault merged pull request #5057: Revert "HBASE-27649 WALPlayer does not properly dedupe overridden cell versions"

2023-02-25 Thread via GitHub
bbeaudreault merged PR #5057: URL: https://github.com/apache/hbase/pull/5057 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] bbeaudreault opened a new pull request, #5057: Revert "HBASE-27649 WALPlayer does not properly dedupe overridden cell versions"

2023-02-25 Thread via GitHub
bbeaudreault opened a new pull request, #5057: URL: https://github.com/apache/hbase/pull/5057 Reverts apache/hbase#5047 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hbase] bbeaudreault commented on pull request #5047: HBASE-27649 WALPlayer does not properly dedupe overridden cell versions

2023-02-25 Thread via GitHub
bbeaudreault commented on PR #5047: URL: https://github.com/apache/hbase/pull/5047#issuecomment-1445161490 Ugh, somehow some temp code got in here in hbase-backup. Going to revert -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hbase] bbeaudreault merged pull request #5047: HBASE-27649 WALPlayer does not properly dedupe overridden cell versions

2023-02-25 Thread via GitHub
bbeaudreault merged PR #5047: URL: https://github.com/apache/hbase/pull/5047 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] bbeaudreault commented on pull request #5047: HBASE-27649 WALPlayer does not properly dedupe overridden cell versions

2023-02-25 Thread via GitHub
bbeaudreault commented on PR #5047: URL: https://github.com/apache/hbase/pull/5047#issuecomment-1445161199 checkstyle/spotbugs are in hbase-backups module, which i haven't changed here. Will be handling that in a separate issue. Otherwise pre-commit passing so going to merge. Thanks! --

[GitHub] [hbase] Apache-HBase commented on pull request #5055: HBASE-27632 Refactor WAL.Reader implementation so we can better suppo…

2023-02-25 Thread via GitHub
Apache-HBase commented on PR #5055: URL: https://github.com/apache/hbase/pull/5055#issuecomment-1445157573 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s |

[jira] [Resolved] (HBASE-27661) Set size of systable queue in UT

2023-02-25 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-27661. --- Fix Version/s: 2.6.0 3.0.0-alpha-4 2.4.17

[GitHub] [hbase] Apache9 opened a new pull request, #5055: HBASE-27632 Refactor WAL.Reader implementation so we can better suppo…

2023-02-25 Thread via GitHub
Apache9 opened a new pull request, #5055: URL: https://github.com/apache/hbase/pull/5055 …rt WAL splitting and replication -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [hbase] Apache9 commented on pull request #5037: HBASE-27650 Merging empty regions corrupts meta cache

2023-02-25 Thread via GitHub
Apache9 commented on PR #5037: URL: https://github.com/apache/hbase/pull/5037#issuecomment-1445144063 After consideration, I think we can make this assumption The problem can only occur when the new region fully cover an old region, for example, we have Start_New < Start_Old <

[GitHub] [hbase] Apache-HBase commented on pull request #5047: HBASE-27649 WALPlayer does not properly dedupe overridden cell versions

2023-02-25 Thread via GitHub
Apache-HBase commented on PR #5047: URL: https://github.com/apache/hbase/pull/5047#issuecomment-1445142921 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 7s |

[GitHub] [hbase] Apache-HBase commented on pull request #5047: HBASE-27649 WALPlayer does not properly dedupe overridden cell versions

2023-02-25 Thread via GitHub
Apache-HBase commented on PR #5047: URL: https://github.com/apache/hbase/pull/5047#issuecomment-1445142304 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s |

[GitHub] [hbase] Apache-HBase commented on pull request #5047: HBASE-27649 WALPlayer does not properly dedupe overridden cell versions

2023-02-25 Thread via GitHub
Apache-HBase commented on PR #5047: URL: https://github.com/apache/hbase/pull/5047#issuecomment-1445142220 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s |

[GitHub] [hbase] Apache9 merged pull request #5053: HBASE-27661 Set size of systable queue in UT

2023-02-25 Thread via GitHub
Apache9 merged PR #5053: URL: https://github.com/apache/hbase/pull/5053 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] Apache9 commented on a diff in pull request #5052: HBASE-27660 Ignore invalid hostname when getNetworkInterfaces

2023-02-25 Thread via GitHub
Apache9 commented on code in PR #5052: URL: https://github.com/apache/hbase/pull/5052#discussion_r1117937116 ## hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerHostname.java: ## @@ -205,4 +204,22 @@ public void

[GitHub] [hbase] Apache9 commented on a diff in pull request #5047: HBASE-27649 WALPlayer does not properly dedupe overridden cell versions

2023-02-25 Thread via GitHub
Apache9 commented on code in PR #5047: URL: https://github.com/apache/hbase/pull/5047#discussion_r1117928502 ## hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestWALPlayer.java: ## @@ -131,6 +133,84 @@ public void testPlayingRecoveredEdit() throws Exception {