[GitHub] [hbase] Apache-HBase commented on pull request #4966: HBASE-27216 Revisit the ReplicationSyncUp tool

2023-03-15 Thread via GitHub
Apache-HBase commented on PR #4966: URL: https://github.com/apache/hbase/pull/4966#issuecomment-1471356813 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 19s |

[jira] [Commented] (HBASE-27688) HFile splitting occurs during bulkload, the CREATE_TIME_TS of hfileinfo is 0

2023-03-15 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700973#comment-17700973 ] Hudson commented on HBASE-27688: Results for branch branch-2.4 [build #530 on

[jira] [Commented] (HBASE-27714) WALEntryStreamTestBase creates a new HBTU in startCluster method which causes all sub classes are testing default configurations

2023-03-15 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700974#comment-17700974 ] Hudson commented on HBASE-27714: Results for branch branch-2.4 [build #530 on

[jira] [Assigned] (HBASE-27718) The regionStateNode only need remove once in regionOffline

2023-03-15 Thread chaijunjie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chaijunjie reassigned HBASE-27718: -- Assignee: chaijunjie > The regionStateNode only need remove once in regionOffline >

[GitHub] [hbase] NihalJain commented on pull request #5109: HBASE-27671 Client should not be able to restore/clone a snapshot aft…

2023-03-15 Thread via GitHub
NihalJain commented on PR #5109: URL: https://github.com/apache/hbase/pull/5109#issuecomment-1471181297 Could you please review @virajjasani , @apurtell , @Reidd ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Commented] (HBASE-27711) Regions permanently stuck in unknown_server state

2023-03-15 Thread Jack Yang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700923#comment-17700923 ] Jack Yang commented on HBASE-27711: --- Thanks for sharing.  {{Our test restarts one server node, waits

[GitHub] [hbase] Apache-HBase commented on pull request #5109: HBASE-27671 Client should not be able to restore/clone a snapshot aft…

2023-03-15 Thread via GitHub
Apache-HBase commented on PR #5109: URL: https://github.com/apache/hbase/pull/5109#issuecomment-1470953835 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 6s |

[GitHub] [hbase] Apache-HBase commented on pull request #5109: HBASE-27671 Client should not be able to restore/clone a snapshot aft…

2023-03-15 Thread via GitHub
Apache-HBase commented on PR #5109: URL: https://github.com/apache/hbase/pull/5109#issuecomment-1470942972 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 23s |

[jira] [Comment Edited] (HBASE-27706) Possible Zstd incompatibility

2023-03-15 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700886#comment-17700886 ] Andrew Kyle Purtell edited comment on HBASE-27706 at 3/15/23 10:28 PM:

[jira] [Comment Edited] (HBASE-27706) Possible Zstd incompatibility

2023-03-15 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700886#comment-17700886 ] Andrew Kyle Purtell edited comment on HBASE-27706 at 3/15/23 10:28 PM:

[jira] [Comment Edited] (HBASE-27706) Possible Zstd incompatibility

2023-03-15 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700886#comment-17700886 ] Andrew Kyle Purtell edited comment on HBASE-27706 at 3/15/23 10:26 PM:

[jira] [Commented] (HBASE-27706) Possible Zstd incompatibility

2023-03-15 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700886#comment-17700886 ] Andrew Kyle Purtell commented on HBASE-27706: - The problem is a difference in the Hadoop

[GitHub] [hbase] Apache-HBase commented on pull request #5080: HBASE-27686: Recovery of BucketCache and Prefetched data after RS Crash

2023-03-15 Thread via GitHub
Apache-HBase commented on PR #5080: URL: https://github.com/apache/hbase/pull/5080#issuecomment-1470898780 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 23s |

[GitHub] [hbase] Apache-HBase commented on pull request #4966: HBASE-27216 Revisit the ReplicationSyncUp tool

2023-03-15 Thread via GitHub
Apache-HBase commented on PR #4966: URL: https://github.com/apache/hbase/pull/4966#issuecomment-1470891129 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s |

[GitHub] [hbase] Apache-HBase commented on pull request #5080: HBASE-27686: Recovery of BucketCache and Prefetched data after RS Crash

2023-03-15 Thread via GitHub
Apache-HBase commented on PR #5080: URL: https://github.com/apache/hbase/pull/5080#issuecomment-1470890099 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 19s |

[GitHub] [hbase] wchevreuil commented on a diff in pull request #5080: HBASE-27686: Recovery of BucketCache and Prefetched data after RS Crash

2023-03-15 Thread via GitHub
wchevreuil commented on code in PR #5080: URL: https://github.com/apache/hbase/pull/5080#discussion_r1137779568 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCachePersister.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software

[GitHub] [hbase] Apache-HBase commented on pull request #4966: HBASE-27216 Revisit the ReplicationSyncUp tool

2023-03-15 Thread via GitHub
Apache-HBase commented on PR #4966: URL: https://github.com/apache/hbase/pull/4966#issuecomment-1470804305 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

[jira] [Updated] (HBASE-27711) Regions permanently stuck in unknown_server state

2023-03-15 Thread Aaron Beitch (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aaron Beitch updated HBASE-27711: - Attachment: config.txt > Regions permanently stuck in unknown_server state >

[jira] [Commented] (HBASE-27711) Regions permanently stuck in unknown_server state

2023-03-15 Thread Aaron Beitch (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700847#comment-17700847 ] Aaron Beitch commented on HBASE-27711: -- Our deployment typically has about 20 regions split between

[jira] [Commented] (HBASE-27688) HFile splitting occurs during bulkload, the CREATE_TIME_TS of hfileinfo is 0

2023-03-15 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700839#comment-17700839 ] Hudson commented on HBASE-27688: Results for branch branch-2.5 [build #317 on

[jira] [Commented] (HBASE-27714) WALEntryStreamTestBase creates a new HBTU in startCluster method which causes all sub classes are testing default configurations

2023-03-15 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700840#comment-17700840 ] Hudson commented on HBASE-27714: Results for branch branch-2.5 [build #317 on

[GitHub] [hbase] Apache-HBase commented on pull request #5110: HBASE-27720 TestClusterRestartFailover is flakey due to metrics assertion

2023-03-15 Thread via GitHub
Apache-HBase commented on PR #5110: URL: https://github.com/apache/hbase/pull/5110#issuecomment-1470741459 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 16s |

[GitHub] [hbase] Apache-HBase commented on pull request #5109: HBASE-27671 Client should not be able to restore/clone a snapshot aft…

2023-03-15 Thread via GitHub
Apache-HBase commented on PR #5109: URL: https://github.com/apache/hbase/pull/5109#issuecomment-1470711135 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 52s |

[jira] [Commented] (HBASE-27714) WALEntryStreamTestBase creates a new HBTU in startCluster method which causes all sub classes are testing default configurations

2023-03-15 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700830#comment-17700830 ] Hudson commented on HBASE-27714: Results for branch master [build #796 on

[jira] [Commented] (HBASE-27716) Fix TestWALOpenAfterDNRollingStart

2023-03-15 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700831#comment-17700831 ] Hudson commented on HBASE-27716: Results for branch master [build #796 on

[GitHub] [hbase] Apache-HBase commented on pull request #5110: HBASE-27720 TestClusterRestartFailover is flakey due to metrics assertion

2023-03-15 Thread via GitHub
Apache-HBase commented on PR #5110: URL: https://github.com/apache/hbase/pull/5110#issuecomment-1470636746 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 43s |

[GitHub] [hbase] Apache-HBase commented on pull request #5109: HBASE-27671 Client should not be able to restore/clone a snapshot aft…

2023-03-15 Thread via GitHub
Apache-HBase commented on PR #5109: URL: https://github.com/apache/hbase/pull/5109#issuecomment-1470595961 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 4s |

[GitHub] [hbase] Apache-HBase commented on pull request #5080: HBASE-27686: Recovery of BucketCache and Prefetched data after RS Crash

2023-03-15 Thread via GitHub
Apache-HBase commented on PR #5080: URL: https://github.com/apache/hbase/pull/5080#issuecomment-1470562311 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 23s |

[GitHub] [hbase] Apache-HBase commented on pull request #5109: HBASE-27671 Client should not be able to restore/clone a snapshot aft…

2023-03-15 Thread via GitHub
Apache-HBase commented on PR #5109: URL: https://github.com/apache/hbase/pull/5109#issuecomment-1470557489 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 22s |

[jira] [Commented] (HBASE-27711) Regions permanently stuck in unknown_server state

2023-03-15 Thread Aaron Beitch (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700802#comment-17700802 ] Aaron Beitch commented on HBASE-27711: -- Thank you for the summary, that is state much clearer than

[GitHub] [hbase] Kota-SH commented on a diff in pull request #5080: HBASE-27686: Recovery of BucketCache and Prefetched data after RS Crash

2023-03-15 Thread via GitHub
Kota-SH commented on code in PR #5080: URL: https://github.com/apache/hbase/pull/5080#discussion_r113756 ## hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/bucket/TestBucketCachePersister.java: ## @@ -0,0 +1,195 @@ +/* + * Licensed to the Apache Software

[GitHub] [hbase] Apache-HBase commented on pull request #4966: HBASE-27216 Revisit the ReplicationSyncUp tool

2023-03-15 Thread via GitHub
Apache-HBase commented on PR #4966: URL: https://github.com/apache/hbase/pull/4966#issuecomment-1470450655 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

[jira] [Assigned] (HBASE-27721) LEAK: RefCnt.release() was not called before it's garbage-collected in regionserver

2023-03-15 Thread Rajeshbabu Chintaguntla (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajeshbabu Chintaguntla reassigned HBASE-27721: --- Assignee: Rajeshbabu Chintaguntla > LEAK: RefCnt.release() was not

[jira] [Created] (HBASE-27721) LEAK: RefCnt.release() was not called before it's garbage-collected in regionserver

2023-03-15 Thread chiranjeevi (Jira)
chiranjeevi created HBASE-27721: --- Summary: LEAK: RefCnt.release() was not called before it's garbage-collected in regionserver Key: HBASE-27721 URL: https://issues.apache.org/jira/browse/HBASE-27721

[GitHub] [hbase] Apache-HBase commented on pull request #5110: HBASE-27720 TestClusterRestartFailover is flakey due to metrics assertion

2023-03-15 Thread via GitHub
Apache-HBase commented on PR #5110: URL: https://github.com/apache/hbase/pull/5110#issuecomment-1470296886 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 47s |

[GitHub] [hbase-operator-tools] ndimiduk commented on pull request #112: HBASE-27696 [hbase-operator-tools] Use $revision as placeholder for maven version

2023-03-15 Thread via GitHub
ndimiduk commented on PR #112: URL: https://github.com/apache/hbase-operator-tools/pull/112#issuecomment-1470284224 I don't know if this has a negative impact on tools that report out of maven central. All that metadata is stripped away from one of our official, programmatically

[GitHub] [hbase-operator-tools] Apache9 commented on pull request #112: HBASE-27696 [hbase-operator-tools] Use $revision as placeholder for maven version

2023-03-15 Thread via GitHub
Apache9 commented on PR #112: URL: https://github.com/apache/hbase-operator-tools/pull/112#issuecomment-1470277019 > > Oh, what is the reason to only resolve ci friendly properties but not all properties? > > It appears that by default, the flatten plugin makes a "minimized" pom --

[GitHub] [hbase-operator-tools] ndimiduk commented on pull request #112: HBASE-27696 [hbase-operator-tools] Use $revision as placeholder for maven version

2023-03-15 Thread via GitHub
ndimiduk commented on PR #112: URL: https://github.com/apache/hbase-operator-tools/pull/112#issuecomment-1470269899 > Oh, what is the reason to only resolve ci friendly properties but not all properties? It appears that by default, the flatten plugin makes a "minimized" pom -- it

[GitHub] [hbase-operator-tools] Apache9 commented on pull request #112: HBASE-27696 [hbase-operator-tools] Use $revision as placeholder for maven version

2023-03-15 Thread via GitHub
Apache9 commented on PR #112: URL: https://github.com/apache/hbase-operator-tools/pull/112#issuecomment-1470246552 Oh, what is the reason to only resolve ci friendly properties but not all properties? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] wchevreuil commented on pull request #5080: HBASE-27686: Recovery of BucketCache and Prefetched data after RS Crash

2023-03-15 Thread via GitHub
wchevreuil commented on PR #5080: URL: https://github.com/apache/hbase/pull/5080#issuecomment-1470220090 Lets also update the flag for evictions. That way, we would sort the need for update on evictions as well. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [hbase] Apache-HBase commented on pull request #5109: HBASE-27671 Client should not be able to restore/clone a snapshot aft…

2023-03-15 Thread via GitHub
Apache-HBase commented on PR #5109: URL: https://github.com/apache/hbase/pull/5109#issuecomment-1470212591 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s |

[jira] [Updated] (HBASE-27652) Client-side lock contention around Configuration when using read replica regions

2023-03-15 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-27652: - Fix Version/s: 2.6.0 2.5.4 Resolution: Fixed Status:

[GitHub] [hbase] ndimiduk merged pull request #5108: Backport "HBASE-27652 Client-side lock contention around Configuration when using read replica regions" to branch-2.5

2023-03-15 Thread via GitHub
ndimiduk merged PR #5108: URL: https://github.com/apache/hbase/pull/5108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase-operator-tools] ndimiduk commented on pull request #112: HBASE-27696 [hbase-operator-tools] Use $revision as placeholder for maven version

2023-03-15 Thread via GitHub
ndimiduk commented on PR #112: URL: https://github.com/apache/hbase-operator-tools/pull/112#issuecomment-1470167139 Fails locally but works in CI...  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] ndimiduk opened a new pull request, #5110: HBASE-27720 TestClusterRestartFailover is flakey due to metrics assertion

2023-03-15 Thread via GitHub
ndimiduk opened a new pull request, #5110: URL: https://github.com/apache/hbase/pull/5110 This test has been flakey. When it is rerun by surefire, the underlying minicluster isn't completely cleaned. specifically, the metics system isn't reset. The result is an otherwise successful re-run

[GitHub] [hbase] NihalJain commented on pull request #5109: HBASE-27671 Client should not be able to restore/clone a snapshot aft…

2023-03-15 Thread via GitHub
NihalJain commented on PR #5109: URL: https://github.com/apache/hbase/pull/5109#issuecomment-1470151300 Sample output when TTL Expires ``` hbase:013:0> restore_snapshot 'snap' ERROR: TTL for snapshot 'snap' has already expired. For usage try 'help "restore_snapshot"'

[jira] [Updated] (HBASE-27671) Client should not be able to restore/clone a snapshot after it's TTL has expired

2023-03-15 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-27671: --- Attachment: Screenshot 2023-03-15 at 8.20.31 PM.png > Client should not be able to restore/clone a

[jira] [Updated] (HBASE-27720) TestClusterRestartFailover is flakey due to metrics assertion

2023-03-15 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-27720: - Summary: TestClusterRestartFailover is flakey due to metrics assertion (was:

[jira] [Created] (HBASE-27720) TestClusterRestartFailover is flakey

2023-03-15 Thread Nick Dimiduk (Jira)
Nick Dimiduk created HBASE-27720: Summary: TestClusterRestartFailover is flakey Key: HBASE-27720 URL: https://issues.apache.org/jira/browse/HBASE-27720 Project: HBase Issue Type: Task

[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #112: HBASE-27696 [hbase-operator-tools] Use $revision as placeholder for maven version

2023-03-15 Thread via GitHub
Apache-HBase commented on PR #112: URL: https://github.com/apache/hbase-operator-tools/pull/112#issuecomment-1470109862 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec |

[GitHub] [hbase] NihalJain opened a new pull request, #5109: HBASE-27671 Client should not be able to restore/clone a snapshot aft…

2023-03-15 Thread via GitHub
NihalJain opened a new pull request, #5109: URL: https://github.com/apache/hbase/pull/5109 …er it's TTL has expired -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Updated] (HBASE-27671) Client should not be able to restore/clone a snapshot after it's TTL has expired

2023-03-15 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-27671: --- Summary: Client should not be able to restore/clone a snapshot after it's TTL has expired (was:

[jira] [Updated] (HBASE-27671) Client should not be able to restore/clone a snapshot after it has TTL expired

2023-03-15 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-27671: --- Summary: Client should not be able to restore/clone a snapshot after it has TTL expired (was: Able

[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #112: HBASE-27696 [hbase-operator-tools] Use $revision as placeholder for maven version

2023-03-15 Thread via GitHub
Apache-HBase commented on PR #112: URL: https://github.com/apache/hbase-operator-tools/pull/112#issuecomment-1470077209 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at

[GitHub] [hbase] Apache-HBase commented on pull request #5036: HBASE-27652 Client-side lock contention around Configuration when using read replica regions

2023-03-15 Thread via GitHub
Apache-HBase commented on PR #5036: URL: https://github.com/apache/hbase/pull/5036#issuecomment-1470070792 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 33s |

[GitHub] [hbase-operator-tools] ndimiduk commented on pull request #112: HBASE-27696 [hbase-operator-tools] Use $revision as placeholder for maven version

2023-03-15 Thread via GitHub
ndimiduk commented on PR #112: URL: https://github.com/apache/hbase-operator-tools/pull/112#issuecomment-1470069218 > embedBuildProfileDependencies I can add that, but this project doesn't use profiles to manage dependency set, so I don't think it's necessary. abase-connectors.git

[GitHub] [hbase-operator-tools] ndimiduk commented on a diff in pull request #112: HBASE-27696 [hbase-operator-tools] Use $revision as placeholder for maven version

2023-03-15 Thread via GitHub
ndimiduk commented on code in PR #112: URL: https://github.com/apache/hbase-operator-tools/pull/112#discussion_r1137126778 ## pom.xml: ## @@ -320,6 +321,33 @@ true + Review Comment: I thought so too, but that doesn't fix it

[jira] [Commented] (HBASE-27709) Fix UT failures after HBASE-27632 goes in

2023-03-15 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700691#comment-17700691 ] Duo Zhang commented on HBASE-27709: --- Let's see if HBASE-27715 and HBASE-27716 can fix the problems. >

[jira] [Resolved] (HBASE-27715) Refactoring the long tryAdvanceEntry method in WALEntryStream

2023-03-15 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-27715. --- Hadoop Flags: Reviewed Resolution: Fixed Pushed to master and branch-2. Thanks [~heliangjun]

[jira] [Assigned] (HBASE-27715) Refactoring the long tryAdvanceEntry method in WALEntryStream

2023-03-15 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-27715: - Assignee: Duo Zhang > Refactoring the long tryAdvanceEntry method in WALEntryStream >

[GitHub] [hbase] Apache9 merged pull request #5105: HBASE-27715 Refactoring the long tryAdvanceEntry method in WALEntrySt…

2023-03-15 Thread via GitHub
Apache9 merged PR #5105: URL: https://github.com/apache/hbase/pull/5105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] Apache9 commented on pull request #5105: HBASE-27715 Refactoring the long tryAdvanceEntry method in WALEntrySt…

2023-03-15 Thread via GitHub
Apache9 commented on PR #5105: URL: https://github.com/apache/hbase/pull/5105#issuecomment-1470040314 OK, good, all green. Let me merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hbase-operator-tools] Apache9 commented on pull request #112: HBASE-27696 [hbase-operator-tools] Use $revision as placeholder for maven version

2023-03-15 Thread via GitHub
Apache9 commented on PR #112: URL: https://github.com/apache/hbase-operator-tools/pull/112#issuecomment-1470034845 Seems the mvn install job in pre commit can not recognize the `$revision` property? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase-operator-tools] Apache9 commented on a diff in pull request #112: HBASE-27696 [hbase-operator-tools] Use $revision as placeholder for maven version

2023-03-15 Thread via GitHub
Apache9 commented on code in PR #112: URL: https://github.com/apache/hbase-operator-tools/pull/112#discussion_r1137089720 ## pom.xml: ## @@ -320,6 +321,33 @@ true + Review Comment: We should add this into the plugins section, not

[GitHub] [hbase-operator-tools] Apache9 commented on pull request #112: HBASE-27696 [hbase-operator-tools] Use $revision as placeholder for maven version

2023-03-15 Thread via GitHub
Apache9 commented on PR #112: URL: https://github.com/apache/hbase-operator-tools/pull/112#issuecomment-1470026637 We use these configurations in hbase for flatten-maven-plugin ``` true true ``` -- This is an automated message

[GitHub] [hbase] Apache-HBase commented on pull request #5036: HBASE-27652 Client-side lock contention around Configuration when using read replica regions

2023-03-15 Thread via GitHub
Apache-HBase commented on PR #5036: URL: https://github.com/apache/hbase/pull/5036#issuecomment-1470005824 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 13s |

[GitHub] [hbase] Apache-HBase commented on pull request #5108: Backport "HBASE-27652 Client-side lock contention around Configuration when using read replica regions" to branch-2.5

2023-03-15 Thread via GitHub
Apache-HBase commented on PR #5108: URL: https://github.com/apache/hbase/pull/5108#issuecomment-1469990816 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

[GitHub] [hbase] Apache-HBase commented on pull request #5108: Backport "HBASE-27652 Client-side lock contention around Configuration when using read replica regions" to branch-2.5

2023-03-15 Thread via GitHub
Apache-HBase commented on PR #5108: URL: https://github.com/apache/hbase/pull/5108#issuecomment-1469975238 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s |

[jira] [Work started] (HBASE-27671) Able to restore snapshot even after TTL expired

2023-03-15 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-27671 started by Nihal Jain. -- > Able to restore snapshot even after TTL expired >

[GitHub] [hbase] Apache-HBase commented on pull request #5103: HBASE-27708 CPU hot-spot resolving User subject

2023-03-15 Thread via GitHub
Apache-HBase commented on PR #5103: URL: https://github.com/apache/hbase/pull/5103#issuecomment-1469841992 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 50s |

[GitHub] [hbase] Apache-HBase commented on pull request #5103: HBASE-27708 CPU hot-spot resolving User subject

2023-03-15 Thread via GitHub
Apache-HBase commented on PR #5103: URL: https://github.com/apache/hbase/pull/5103#issuecomment-1469812120 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 22s |

[GitHub] [hbase] Apache-HBase commented on pull request #5103: HBASE-27708 CPU hot-spot resolving User subject

2023-03-15 Thread via GitHub
Apache-HBase commented on PR #5103: URL: https://github.com/apache/hbase/pull/5103#issuecomment-1469811198 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s |

[GitHub] [hbase] Apache-HBase commented on pull request #5105: HBASE-27715 Refactoring the long tryAdvanceEntry method in WALEntrySt…

2023-03-15 Thread via GitHub
Apache-HBase commented on PR #5105: URL: https://github.com/apache/hbase/pull/5105#issuecomment-1469793956 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3s |

[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #112: HBASE-27696 [hbase-operator-tools] Use $revision as placeholder for maven version

2023-03-15 Thread via GitHub
Apache-HBase commented on PR #112: URL: https://github.com/apache/hbase-operator-tools/pull/112#issuecomment-1469784412 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec |

[GitHub] [hbase] Apache-HBase commented on pull request #5105: HBASE-27715 Refactoring the long tryAdvanceEntry method in WALEntrySt…

2023-03-15 Thread via GitHub
Apache-HBase commented on PR #5105: URL: https://github.com/apache/hbase/pull/5105#issuecomment-1469771066 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 2s |

[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #112: HBASE-27696 [hbase-operator-tools] Use $revision as placeholder for maven version

2023-03-15 Thread via GitHub
Apache-HBase commented on PR #112: URL: https://github.com/apache/hbase-operator-tools/pull/112#issuecomment-1469761680 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at

[GitHub] [hbase] ndimiduk commented on pull request #5103: HBASE-27708 CPU hot-spot resolving User subject

2023-03-15 Thread via GitHub
ndimiduk commented on PR #5103: URL: https://github.com/apache/hbase/pull/5103#issuecomment-1469761251 Pushed the caching down into the `SecureHadoopUser` implementation, which is IA.Private and final. I assume this is the instance that is used throughout. -- This is an automated message

[GitHub] [hbase] Apache-HBase commented on pull request #5103: HBASE-27708 CPU hot-spot resolving User subject

2023-03-15 Thread via GitHub
Apache-HBase commented on PR #5103: URL: https://github.com/apache/hbase/pull/5103#issuecomment-1469756487 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s |

[GitHub] [hbase] ndimiduk commented on pull request #5103: HBASE-27708 CPU hot-spot resolving User subject

2023-03-15 Thread via GitHub
ndimiduk commented on PR #5103: URL: https://github.com/apache/hbase/pull/5103#issuecomment-1469750939 This is a wreck. Let me try something else. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #112: HBASE-27696 [hbase-operator-tools] Use $revision as placeholder for maven version

2023-03-15 Thread via GitHub
Apache-HBase commented on PR #112: URL: https://github.com/apache/hbase-operator-tools/pull/112#issuecomment-1469749587 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec |

[GitHub] [hbase] Apache9 commented on pull request #5103: HBASE-27708 CPU hot-spot resolving User subject

2023-03-15 Thread via GitHub
Apache9 commented on PR #5103: URL: https://github.com/apache/hbase/pull/5103#issuecomment-1469739206 I'm still a bit nervous about the implementation... As you said, the ugi field is not even final, and we can also get the UGI instance from outside and change it, how could we make

[GitHub] [hbase] Apache-HBase commented on pull request #5108: Backport "HBASE-27652 Client-side lock contention around Configuration when using read replica regions" to branch-2.5

2023-03-15 Thread via GitHub
Apache-HBase commented on PR #5108: URL: https://github.com/apache/hbase/pull/5108#issuecomment-1469735772 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 31s |

[GitHub] [hbase-operator-tools] ndimiduk commented on pull request #112: HBASE-27696 [hbase-operator-tools] Use $revision as placeholder for maven version

2023-03-15 Thread via GitHub
ndimiduk commented on PR #112: URL: https://github.com/apache/hbase-operator-tools/pull/112#issuecomment-1469735673 Yetus needs to perform a `mvn install` before it can proceed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hbase] Apache-HBase commented on pull request #5103: HBASE-27708 CPU hot-spot resolving User subject

2023-03-15 Thread via GitHub
Apache-HBase commented on PR #5103: URL: https://github.com/apache/hbase/pull/5103#issuecomment-1469722349 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 22s |

[GitHub] [hbase] Apache-HBase commented on pull request #5103: HBASE-27708 CPU hot-spot resolving User subject

2023-03-15 Thread via GitHub
Apache-HBase commented on PR #5103: URL: https://github.com/apache/hbase/pull/5103#issuecomment-1469721997 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #112: HBASE-27696 [hbase-operator-tools] Use $revision as placeholder for maven version

2023-03-15 Thread via GitHub
Apache-HBase commented on PR #112: URL: https://github.com/apache/hbase-operator-tools/pull/112#issuecomment-1469721641 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at

[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #112: HBASE-27696 [hbase-operator-tools] Use $revision as placeholder for maven version

2023-03-15 Thread via GitHub
Apache-HBase commented on PR #112: URL: https://github.com/apache/hbase-operator-tools/pull/112#issuecomment-1469721210 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec |

[GitHub] [hbase] Apache-HBase commented on pull request #5036: HBASE-27652 Client-side lock contention around Configuration when using read replica regions

2023-03-15 Thread via GitHub
Apache-HBase commented on PR #5036: URL: https://github.com/apache/hbase/pull/5036#issuecomment-1469718698 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #112: HBASE-27696 [hbase-operator-tools] Use $revision as placeholder for maven version

2023-03-15 Thread via GitHub
Apache-HBase commented on PR #112: URL: https://github.com/apache/hbase-operator-tools/pull/112#issuecomment-1469691641 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at

[jira] [Commented] (HBASE-27706) Possible Zstd incompatibility

2023-03-15 Thread Frens Jan Rumph (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700575#comment-17700575 ] Frens Jan Rumph commented on HBASE-27706: - I've been able to reproduce the issue in an isolated

[GitHub] [hbase-operator-tools] ndimiduk commented on pull request #112: HBASE-27696 [hbase-operator-tools] Use $revision as placeholder for maven version

2023-03-15 Thread via GitHub
ndimiduk commented on PR #112: URL: https://github.com/apache/hbase-operator-tools/pull/112#issuecomment-1469642332 I think the maven version is too old. Yetus is pretty old here as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Created] (HBASE-27719) Fix surefire corrupted channel

2023-03-15 Thread Nick Dimiduk (Jira)
Nick Dimiduk created HBASE-27719: Summary: Fix surefire corrupted channel Key: HBASE-27719 URL: https://issues.apache.org/jira/browse/HBASE-27719 Project: HBase Issue Type: Task

[GitHub] [hbase] Apache-HBase commented on pull request #5106: HBASE-27718 The regionStateNode only need remove once in regionOffline

2023-03-15 Thread via GitHub
Apache-HBase commented on PR #5106: URL: https://github.com/apache/hbase/pull/5106#issuecomment-1469619881 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

[GitHub] [hbase] Apache-HBase commented on pull request #5106: HBASE-27718 The regionStateNode only need remove once in regionOffline

2023-03-15 Thread via GitHub
Apache-HBase commented on PR #5106: URL: https://github.com/apache/hbase/pull/5106#issuecomment-1469603810 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

[GitHub] [hbase] Apache-HBase commented on pull request #5105: HBASE-27715 Refactoring the long tryAdvanceEntry method in WALEntrySt…

2023-03-15 Thread via GitHub
Apache-HBase commented on PR #5105: URL: https://github.com/apache/hbase/pull/5105#issuecomment-1469465080 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 55s |

[GitHub] [hbase] Apache9 commented on a diff in pull request #5105: HBASE-27715 Refactoring the long tryAdvanceEntry method in WALEntrySt…

2023-03-15 Thread via GitHub
Apache9 commented on code in PR #5105: URL: https://github.com/apache/hbase/pull/5105#discussion_r1136586490 ## hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java: ## @@ -206,73 +206,125 @@ private void setCurrentPath(Path path) {